Re: [bugfix] set same mac of bond slave

2024-04-29 Thread Simon Jones
e this patch does: > > > https://github.com/batmancn/dpdk/commit/a484ac3f407a6a22d4eb63da23e98e8e76833722 > > ``` > > commit a484ac3f407a6a22d4eb63da23e98e8e76833722 (HEAD -> > > bugfix-bond-same-mac-20240429, batmancn/bugfix-bond-same-mac-20240429) > > Author: batmancn

Re: [PATCH v3 1/2] vhost: destroy device when all vqs are inactive

2024-04-29 Thread Xuan Zhuo
On Mon, 29 Apr 2024 09:27:42 -0700, Stephen Hemminger wrote: > On Tue, 11 Oct 2022 18:44:28 +0200 > Maxime Coquelin wrote: > > > On 9/12/22 05:36, Kangjie Xu wrote: > > > We change the behavior of vhost_user_get_vring_base(). Previosly, > > > destroying a virtqueue will cause the whole device to

Re: [bugfix] set same mac of bond slave

2024-04-29 Thread Stephen Hemminger
722 (HEAD -> > bugfix-bond-same-mac-20240429, batmancn/bugfix-bond-same-mac-20240429) > Author: batmancn > Date: Mon Apr 29 18:44:18 2024 +0800 > > Bugfix, config same mac address of bond slave. > > Signed-off-by: Simon Jones This won't apply to current DPDK since slave has been renamed to member.

[bugfix] set same mac of bond slave

2024-04-29 Thread Simon Jones
Hi, all Should bond slave need set same mac address? Like this patch does: https://github.com/batmancn/dpdk/commit/a484ac3f407a6a22d4eb63da23e98e8e76833722 ``` commit a484ac3f407a6a22d4eb63da23e98e8e76833722 (HEAD -> bugfix-bond-same-mac-20240429, batmancn/bugfix-bond-same-mac-20240429) Aut

Re: [RFC] eal: make lcore_init aware of cgroup

2024-04-29 Thread Stephen Hemminger
On Mon, 29 Apr 2024 12:52:25 -0700 Stephen Hemminger wrote: > Some lcores maybe restricted from being used by DPDK by cgroups. > This should be detected at startup and only those cpu's allowed > to be used by the process should be marked as enabled. > > This is a lightly tested patch, and parsin

Re: [DPDK/core Bug 1425] enable_stdatomic=true breaks C++ on GCC 11 and earlier

2024-04-29 Thread Tyler Retzlaff
On Mon, Apr 29, 2024 at 06:21:13AM +, bugzi...@dpdk.org wrote: > https://bugs.dpdk.org/show_bug.cgi?id=1425 > > Bug ID: 1425 >Summary: enable_stdatomic=true breaks C++ on GCC 11 and > earlier >Product: DPDK >Version: 23.11 >

Re: Run unit tests with C++ too

2024-04-29 Thread Tyler Retzlaff
On Mon, Apr 29, 2024 at 09:01:08AM +0100, Ferruh Yigit wrote: > On 4/28/2024 8:46 AM, Mattias Rönnblom wrote: > > It would be great if the unit test suite (app/test/*) was compiled (and > > run) using a C++ (C++11) compiler as well. At least, if such is available. > > > > With the current state of

[RFC] eal: make lcore_init aware of cgroup

2024-04-29 Thread Stephen Hemminger
Some lcores maybe restricted from being used by DPDK by cgroups. This should be detected at startup and only those cpu's allowed to be used by the process should be marked as enabled. This is a lightly tested patch, and parsing the cpuset info here probably needs more checking. It is a response to

Re: [PATCH v2] lib/vhost: add flag for async connection in client mode

2024-04-29 Thread Thomas Monjalon
25/04/2024 16:04, Morten Brørup: > > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > > Sent: Thursday, 25 April 2024 15.48 > > > > On 4/17/24 11:15, Ушков Даниил wrote: > > > > > > Signed-off-by: Ушков Даниил > > > --- > > > Fixes: > > > 1. Fix warning about the name in signature. > >

[DPDK/ethdev Bug 1426] Bonding driver does not receive all packets in 8023ad mode (LACP)

2024-04-29 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1426 Bug ID: 1426 Summary: Bonding driver does not receive all packets in 8023ad mode (LACP) Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCON

Re: [PATCH v4] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-29 Thread Nicholas Pratte
I fixed the docstring under setup_hugepages in os_session, and I also made a quick fix to the dts.rst documentation. For the dts.rst documentation, I think the following changes make more sense, based on the concerns outlined: (here is a snip of the documentation with the change I made) "as doing

Re: [PATCH v3 1/2] vhost: destroy device when all vqs are inactive

2024-04-29 Thread Stephen Hemminger
On Tue, 11 Oct 2022 18:44:28 +0200 Maxime Coquelin wrote: > On 9/12/22 05:36, Kangjie Xu wrote: > > We change the behavior of vhost_user_get_vring_base(). Previosly, > > destroying a virtqueue will cause the whole device to be destroyed. > > The behavior is not specified in the vhost-user protoco

Re: [dpdk-dev] [PATCH v5 4/4] app: hook in EAL usage help

2024-04-29 Thread Stephen Hemminger
This patch appears stuck in limbo. Some comments. On Mon, 5 Apr 2021 21:39:54 +0200 Thomas Monjalon wrote: > diff --git a/app/test-compress-perf/comp_perf_options_parse.c > b/app/test-compress-perf/comp_perf_options_parse.c > index 019eddb7bd..39d7fd8c69 100644 > --- a/app/test-compress-perf/

Re: [PATCH 1/5] dts: fix InteractiveShell command prompt filtering

2024-04-29 Thread Jeremy Spewock
On Thu, Apr 18, 2024 at 2:31 AM Juraj Linkeš wrote: > > > Ok this makes sense now. Let's definitely drop the last prompt, there > aren't any upsides (that I can see) and this sort of downside may > occur elsewhere. +1

Re: [PATCH 3/5] dts: add parsing utility module

2024-04-29 Thread Jeremy Spewock
On Fri, Apr 12, 2024 at 7:11 AM Luca Vizzarro wrote: > > @@ -0,0 +1,147 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright(c) 2024 Arm Limited > + > +"""Parsing utility module. > + > +This module provides :class:`~TextParser` which can be used to model any > data structure > +that can

Re: [PATCH 5/5] dts: add `show port stats` command to TestPmdShell

2024-04-29 Thread Jeremy Spewock
On Fri, Apr 12, 2024 at 7:11 AM Luca Vizzarro wrote: > +def show_port_stats(self, port_id: int) -> TestPmdPortStats: > +"""Returns the given port statistics. > + > +Args: > +port_id: The port ID to gather information for. > + > +Raises: > +Inter

Re: [PATCH] devtools: add .clang-format file

2024-04-29 Thread Stephen Hemminger
On Mon, 29 Apr 2024 14:32:43 +0100 Ferruh Yigit wrote: > On 4/29/2024 2:04 PM, Abdullah Ömer Yamaç wrote: > > clang-format is a tool to format C/C++/Objective-C code. It can be used > > to reformat code to match a given coding style, or to ensure that code > > adheres to a specific coding style.

Re: [PATCH] devtools: add .clang-format file

2024-04-29 Thread Stephen Hemminger
On Mon, 29 Apr 2024 14:32:43 +0100 Ferruh Yigit wrote: > ``` > RTE_ETH_FOREACH_DEV(p) I think all those foreach macros need to be in clang format. For example the kernel clang format has: # Taken from: # git grep -h '^#define [^[:space:]]*for_each[^[:space:]]*(' include/ tools/ \ #

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-29 Thread Stephen Hemminger
On Mon, 29 Apr 2024 08:20:13 +0200 Morten Brørup wrote: > > turn talk the control plane, which in turn would talk to the data plane > > (including ). > > > > Either the control plane or the O&M layer could keep track of a reset > > offset. Doesn't have to be on the PMD level. > > Exactly. >

Re: [PATCH 2/5] dts: skip first line of send_command output

2024-04-29 Thread Jeremy Spewock
Apologies for the complications that this interactive shell provides here. These problems didn't arise previously primarily because the interactive shells were designed to receive commands, give you the raw output, and then the developer extract specifically what they want from the output and ignor

Re: [PATCH 5/6] dts: add statefulness to InteractiveShell

2024-04-29 Thread Jeremy Spewock
On Wed, Apr 10, 2024 at 9:36 AM Juraj Linkeš wrote: > > On Wed, Apr 10, 2024 at 1:27 PM Luca Vizzarro wrote: > > > > On 10/04/2024 07:53, Juraj Linkeš wrote: > > > I have a general question. What are these changes for? Do you > > > anticipate us needing this in the future? Wouldn't it be better t

Re: [PATCH v4 0/3] dts: API docs generation

2024-04-29 Thread Patrick Robb
On Mon, Apr 29, 2024 at 9:49 AM Jeremy Spewock wrote: > > > The patchset contains the .rst sources which Sphinx uses to generate the > > html pages. These were first generated with the sphinx-apidoc utility > > and modified to provide a better look. The documentation just doesn't > > look that g

Re: [PATCH] bus/pci: fix build with musl 1.2.4 / Alpine 3.19

2024-04-29 Thread Patrick Robb
On Mon, Apr 29, 2024 at 6:01 AM David Marchand wrote: > Following an upgrade of musl, pread64/pwrite64 wrappers are not provided > anymore. Switch to POSIX pread/pwrite. > > Bugzilla ID: 1422 > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > > Tested-by: Patrick Robb We will re-enable

Re: 21.11.7 patches review and test

2024-04-29 Thread Kevin Traynor
On 29/04/2024 12:21, Ali Alnubani wrote: >> -Original Message- >> From: Kevin Traynor >> Sent: Thursday, April 18, 2024 3:34 PM >> To: sta...@dpdk.org >> Cc: dev@dpdk.org; Abhishek Marathe ; >> Ali Alnubani ; David Christensen >> ; Hemant Agrawal ; >> Ian Stokes ; Jerin Jacob ; John >> McN

Re: [PATCH v4 0/3] dts: API docs generation

2024-04-29 Thread Jeremy Spewock
> The patchset contains the .rst sources which Sphinx uses to generate the > html pages. These were first generated with the sphinx-apidoc utility > and modified to provide a better look. The documentation just doesn't > look that good without the modifications and there isn't enough > configurati

Re: [PATCH] devtools: add .clang-format file

2024-04-29 Thread Ferruh Yigit
On 4/29/2024 2:04 PM, Abdullah Ömer Yamaç wrote: > clang-format is a tool to format C/C++/Objective-C code. It can be used > to reformat code to match a given coding style, or to ensure that code > adheres to a specific coding style. It helps to maintain a consistent > coding style across the DPDK

[PATCH] devtools: add .clang-format file

2024-04-29 Thread Abdullah Ömer Yamaç
clang-format is a tool to format C/C++/Objective-C code. It can be used to reformat code to match a given coding style, or to ensure that code adheres to a specific coding style. It helps to maintain a consistent coding style across the DPDK codebase. .clang-format file overrides the default style

Re: [v1 1/1] docs: af_xdp device plugin repo update

2024-04-29 Thread Maryam Tahhan
On 26/04/2024 15:54, Ferruh Yigit wrote: On 4/25/2024 4:08 PM, Maryam Tahhan wrote: Fixup the references to the AF_XDP Device Plugin repo. Fixes: 66a2aca4f512 ("docs: fix AF_XDP device plugin howto") Cc:sta...@dpdk.org Signed-off-by: Maryam Tahhan --- doc/guides/howto/af_xdp_cni.rst | 12 +++

Re: [PATCH 6/6] dts: add statefulness to TestPmdShell

2024-04-29 Thread Juraj Linkeš
On Fri, Apr 26, 2024 at 8:06 PM Jeremy Spewock wrote: > > Apologies for being so late on the discussion, but just a few of my > thoughts: > > * I think using something like overloading even though it is new to > python is completely fine because this new python version is a > dependency of the DT

RE: 21.11.7 patches review and test

2024-04-29 Thread Ali Alnubani
> -Original Message- > From: Kevin Traynor > Sent: Thursday, April 18, 2024 3:34 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; David Christensen > ; Hemant Agrawal ; > Ian Stokes ; Jerin Jacob ; John > McNamara ; Ju-Hyoung Lee > ; Kevin Traynor ; Luca > B

RE: [RFC v3 1/6] eal: extend bit manipulation functionality

2024-04-29 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > Sent: Monday, 29 April 2024 11.52 > > Add functionality to test, set, clear, and assign the value to > individual bits in 32-bit or 64-bit words. > > These functions have no implications on memory ordering, atomicity and > does not

Re: [PATCH] bus/pci: fix build with musl 1.2.4 / Alpine 3.19

2024-04-29 Thread Bruce Richardson
On Mon, Apr 29, 2024 at 12:00:59PM +0200, David Marchand wrote: > Following an upgrade of musl, pread64/pwrite64 wrappers are not provided > anymore. Switch to POSIX pread/pwrite. > > Bugzilla ID: 1422 > Cc: sta...@dpdk.org > > Signed-off-by: David Marchand > --- Acked-by: Bruce Richardson

[RFC v3 4/6] eal: add unit tests for exactly-once bit access functions

2024-04-29 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_once_[set|clear|assign|test]() family of functions. Signed-off-by: Mattias Rönnblom --- app/test/test_bitops.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index f788b5

[RFC v3 6/6] eal: add unit tests for atomic bit access functions

2024-04-29 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_atomic_[set|clear|assign|test|test_and_[set|clear|assign]]() family of functions. RFC v3: * Rename variable 'main' to make ICC happy. Signed-off-by: Mattias Rönnblom --- app/test/test_bitops.c | 233 ++- lib/eal/inc

[RFC v3 5/6] eal: add atomic bit operations

2024-04-29 Thread Mattias Rönnblom
Add atomic bit test/set/clear/assign and test-and-set/clear functions. All atomic bit functions allow (and indeed, require) the caller to specify a memory order. RFC v3: * Work around lack of C++ support for _Generic (Tyler Retzlaff). RFC v2: o Add rte_bit_atomic_test_and_assign() (for consist

[RFC v3 3/6] eal: add exactly-once bit access functions

2024-04-29 Thread Mattias Rönnblom
Add bit test/set/clear/assign functions which prevents certain compiler optimizations and guarantees that program-level memory loads and/or stores will actually occur. These functions are useful when interacting with memory-mapped hardware devices. The "once" family of functions does not promise

[RFC v3 2/6] eal: add unit tests for bit operations

2024-04-29 Thread Mattias Rönnblom
Extend bitops tests to cover the rte_bit_[set|clear|assign|test]() family of functions. The tests are converted to use the test suite runner framework. Signed-off-by: Mattias Rönnblom --- app/test/test_bitops.c | 76 +- 1 file changed, 61 insertions(+), 1

[RFC v3 1/6] eal: extend bit manipulation functionality

2024-04-29 Thread Mattias Rönnblom
Add functionality to test, set, clear, and assign the value to individual bits in 32-bit or 64-bit words. These functions have no implications on memory ordering, atomicity and does not use volatile and thus does not prevent any compiler optimizations. RFC v3: * Work around lack of C++ support f

[RFC v3 0/6] Improve EAL bit operations API

2024-04-29 Thread Mattias Rönnblom
This patch set represent an attempt to improve and extend the RTE bitops API, in particular for functions that operate on individual bits. All new functionality is exposed to the user as generic selection macros, delegating the actual work to private (__-marked) static inline functions. Public fun

[PATCH] bus/pci: fix build with musl 1.2.4 / Alpine 3.19

2024-04-29 Thread David Marchand
Following an upgrade of musl, pread64/pwrite64 wrappers are not provided anymore. Switch to POSIX pread/pwrite. Bugzilla ID: 1422 Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/bus/pci/linux/pci_vfio.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff

Re: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-29 Thread Mattias Rönnblom
On 2024-04-29 09:57, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Sunday, 28 April 2024 17.49 On 2024-04-26 14:20, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] Sent: Thursday, 25 April 2024 18.53 Making 'rte_eth_stats_reset()' and 'r

Re:Re: [PATCH v2] eal/linux: enhanced error handling for affinity

2024-04-29 Thread Jianyue Wu
Yes, agree with that, there is also trace from kernel can see that. I'll ignore this patch. At 2024-04-27 08:18:53, "Stephen Hemminger" wrote: >On Fri, 26 Apr 2024 08:47:37 -0700 >Tyler Retzlaff wrote: > >> > int >> > -- >> >> i do not think introducing os specific behavior/logging to the

[PATCH v3] lib/vhost: add flag for async connection in client mode

2024-04-29 Thread Daniil Ushkov
This patch introduces a new flag RTE_VHOST_USER_ASYNC_CONNECT, which in combination with the flag RTE_VHOST_USER_CLIENT makes rte_vhost_driver_start connect asynchronously to the vhost server. Signed-off-by: Daniil Ushkov --- Fixes: * Cyrillic name in Signed-off-by. Let it be another email addre

Re: [PATCH v3] net/af_packet: cache align Rx/Tx structs

2024-04-29 Thread Ferruh Yigit
On 4/26/2024 4:41 PM, Tyler Retzlaff wrote: > On Fri, Apr 26, 2024 at 11:05:02AM +0200, Mattias Rönnblom wrote: >> Cache align Rx and Tx queue struct to avoid false sharing. >> >> The RX struct happens to be 64 bytes on x86_64 already, so cache >> alignment has no effect there, but it does on 32-bi

Re: Run unit tests with C++ too

2024-04-29 Thread Ferruh Yigit
On 4/28/2024 8:46 AM, Mattias Rönnblom wrote: > It would be great if the unit test suite (app/test/*) was compiled (and > run) using a C++ (C++11) compiler as well. At least, if such is available. > > With the current state of affairs, header file macros or functions are > not verified to be funct

RE: [PATCH] ethdev: document that stats reset APIs are not thread-safe

2024-04-29 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Sunday, 28 April 2024 17.49 > > On 2024-04-26 14:20, Morten Brørup wrote: > >> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > >> Sent: Thursday, 25 April 2024 18.53 > >> > >> Making 'rte_eth_stats_reset()' and 'rte_eth_xstats_rese

RE: [PATCH 0/4] net/mlx5: some unrelated fixes and improvements

2024-04-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Michael Baum > Sent: Tuesday, April 16, 2024 6:31 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Dariusz Sosnowski > ; Raslan Darawsheh ; Slava > Ovsiienko ; Ori Kam ; > Suanming Mou > Subject: [PATCH 0/4] net/mlx5: some unrelated fixes and improvements > > T

RE: [PATCH] common/mlx5: fix unsigned signed mismatch warning

2024-04-29 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Tyler Retzlaff > Sent: Tuesday, April 16, 2024 2:10 AM > To: dev@dpdk.org > Cc: Dariusz Sosnowski ; Dekel Peled > ; Matan Azrad ; Ori Kam > ; Suanming Mou ; Slava > Ovsiienko ; Tyler Retzlaff > ; dek...@mellanox.com; Matan Azrad > ; sta...@dpdk.org > Subje

Re: [PATCH 4/6] dts: use testpmd params for scatter test suite

2024-04-29 Thread Juraj Linkeš
On Fri, Apr 26, 2024 at 8:06 PM Jeremy Spewock wrote: > > On Wed, Apr 10, 2024 at 9:19 AM Juraj Linkeš > wrote: > > > > On Wed, Apr 10, 2024 at 12:53 PM Luca Vizzarro > > wrote: > > > > > > On 09/04/2024 20:12, Juraj Linkeš wrote: > > > >> @@ -104,16 +108,15 @@ def pmd_scatter(self, mbsize: in

RE: [RFC v2 5/6] eal: add atomic bit operations

2024-04-29 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Sunday, 28 April 2024 17.38 > > On 2024-04-26 14:00, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Friday, 26 April 2024 11.39 > >> > >> On 2024-04-25 18:18, Morten Brørup wrote: > Fro