#
Attendees
* Patrick Robb
* Juraj Linkeš
* Paul Szczepanek
* Luca Vizzarro
* Nicholas Pratte
#
Minutes
=
On Thu, 25 Apr 2024 00:27:36 +0200
Mattias Rönnblom wrote:
> On 2024-04-24 21:13, Stephen Hemminger wrote:
> > On Wed, 24 Apr 2024 18:50:50 +0100
> > Ferruh Yigit wrote:
> >
> >>> I don't know how slow af_packet is, but if you care about performance,
> >>> you don't want to use atomic add for
On 2024-04-24 15:42, Aditya Ambadipudi wrote:
From: Honnappa Nagarahalli
Add a multi-thread unsafe double ended queue data structure. This
library provides a simple and efficient alternative to multi-thread
safe ring when multi-thread safety is not required.
Signed-off-by: Aditya Ambadipudi
S
On 2024-04-24 21:13, Stephen Hemminger wrote:
On Wed, 24 Apr 2024 18:50:50 +0100
Ferruh Yigit wrote:
I don't know how slow af_packet is, but if you care about performance,
you don't want to use atomic add for statistics.
There are a few soft drivers already using atomics adds for updatin
Hi,
On Wed, 24 Apr 2024, Dariusz Sosnowski wrote:
-Original Message-
From: Ivan Malov
Sent: Tuesday, April 23, 2024 13:44
To: Jie Hai
Cc: Yuying Zhang ; Aman Singh
; NBU-Contact-Thomas Monjalon (EXTERNAL)
; ferruh.yi...@amd.com >> Ferruh Yigit
; andrew.rybche...@oktetlabs.ru;
dek...@n
> -Original Message-
> From: Ivan Malov
> Sent: Tuesday, April 23, 2024 13:44
> To: Jie Hai
> Cc: Yuying Zhang ; Aman Singh
> ; NBU-Contact-Thomas Monjalon (EXTERNAL)
> ; ferruh.yi...@amd.com >> Ferruh Yigit
> ; andrew.rybche...@oktetlabs.ru;
> dek...@nvidia.com; psathe...@marvell.com; NB
On Wed, 24 Apr 2024 18:50:50 +0100
Ferruh Yigit wrote:
> > I don't know how slow af_packet is, but if you care about performance,
> > you don't want to use atomic add for statistics.
> >
>
> There are a few soft drivers already using atomics adds for updating stats.
> If we document expectati
On Wed, 24 Apr 2024 17:12:39 +
"Van Haaren, Harry" wrote:
> >
> > From: Stephen Hemminger
> > Sent: Wednesday, April 24, 2024 5:13 PM
> > To: Van Haaren, Harry
> > Cc: dev@dpdk.org; Richardson, Bruce; Jerin Jacob
> > Subject: Re: [PATCH] event: fix wa
24/04/2024 19:25, Morten Brørup:
> > Inlining should be avoided in public headers because of ABI
> > compatibility issue
> > and structures being exported because of inline requirement.
>
> This sounds like a techboard decision, which I don't think it was.
> Suggested wording:
>
> A disadvantage
On Wed, 24 Apr 2024 11:29:51 +0100
Ferruh Yigit wrote:
> On 4/24/2024 5:08 AM, Stephen Hemminger wrote:
> > For the 24.11 release, I want to remove the unused type string argument
> > that shows up in rte_malloc() and related functions, then percolates down
> > through. It was a idea in the 1.0
On Wed, 24 Apr 2024 17:57:46 +0100
Ferruh Yigit wrote:
> OK to merge file descriptors instead of duplicating them.
>
> But we have this 4 queue limitation only for multi process case, right?
> If user is planning to use only with primary, this will reduce the
> supported queue number.
>
> Does
Hi Andrew,
> This patchset introduces a new crypto PMD for AMD Pensando hardware
> accelerators. It allows applications running directly on the AMD Pensando
> DSC to offload cryptographic operations to hardware cryptographic blocks.
>
> Andrew Boyer (6):
> crypto/ionic: introduce AMD Pensando io
On 4/24/2024 11:28 AM, Bruce Richardson wrote:
> On Wed, Apr 24, 2024 at 11:21:52AM +0100, Ferruh Yigit wrote:
>> On 4/23/2024 9:56 PM, Mattias Rönnblom wrote:
>>> On 2024-04-23 13:15, Ferruh Yigit wrote:
On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
> Cache align Rx and Tx queue struct t
On 4/24/2024 12:57 PM, Mattias Rönnblom wrote:
> On 2024-04-24 12:21, Ferruh Yigit wrote:
>> On 4/23/2024 9:56 PM, Mattias Rönnblom wrote:
>>> On 2024-04-23 13:15, Ferruh Yigit wrote:
On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
> Cache align Rx and Tx queue struct to avoid false sharing
> Inlining should be avoided in public headers because of ABI
> compatibility issue
> and structures being exported because of inline requirement.
This sounds like a techboard decision, which I don't think it was.
Suggested wording:
A disadvantage of inlining in public headers is ABI compatibilit
Hi Ali,
Wathsala reached out asking how the checkpatch CI check can be updated so
that this series passes checkpatch.
If building the dictionary is a 1 time operation for you, you may have to
apply this patch and re-run devtools/build-dict.sh so that the new
dictionary is in place for a V3 of thi
>
> From: Stephen Hemminger
> Sent: Wednesday, April 24, 2024 5:13 PM
> To: Van Haaren, Harry
> Cc: dev@dpdk.org; Richardson, Bruce; Jerin Jacob
> Subject: Re: [PATCH] event: fix warning from useless snprintf
>
> On Wed, 24 Apr 2024 08:45:52 +
> "Van H
> From: Stephen Hemminger [mailto:step...@networkplumber.org]
> Sent: Wednesday, 24 April 2024 18.24
>
> On Wed, 24 Apr 2024 11:29:51 +0100
> Ferruh Yigit wrote:
>
> > On 4/24/2024 5:08 AM, Stephen Hemminger wrote:
> > > For the 24.11 release, I want to remove the unused type string
> argument
>
On 3/11/2024 7:45 PM, Stephen Hemminger wrote:
> The TAP device can use same file descriptopr for both rx and tx queues.
> This allows up to 8 queues (versus 4).
>
> Signed-off-by: Stephen Hemminger
> ---
> v4 - fix typos reported by check patch
>
> drivers/net/tap/meson.build | 2 +-
> dri
On Wed, 24 Apr 2024 08:45:52 +
"Van Haaren, Harry" wrote:
> > From: Stephen Hemminger
> > Sent: Wednesday, April 24, 2024 4:45 AM
> > To: dev@dpdk.org
> > Cc: Richardson, Bruce; Stephen Hemminger; Van Haaren, Harry; Jerin Jacob
> > Subject: [PATCH] event: fix warning from useless snprintf
>
On Tue, 23 Apr 2024 11:02:43 +0800
Jianyue Wu wrote:
> Improve the robustness of setting thread affinity in DPDK
> by adding detailed error logging.
Is this an error you saw in your application or something inside DPDK?
> Changes:
> 1. Check the return value of pthread_setaffinity_np() and log
Members Attending: 10/11
- Aaron Conole
- Bruce Richardson
- Hemant Agrawal
- Honnappa Nagarahalli
- Kevin Traynor
- Konstantin Ananyev
- Maxime Coquelin
- Morten Brørup
- Stephen Hemminger
- Thomas Monjalon (Chair)
NO
[...]
> +
> +/* mask of all valid flag values to deque_create() */
> +#define __RTE_DEQUE_F_MASK (RTE_DEQUE_F_EXACT_SZ)
> +ssize_t
> +rte_deque_get_memsize_elem(unsigned int esize, unsigned int count)
> +{
> + ssize_t sz;
> +
> + /* Check if element size is a multiple of 4B */
> + if (
Improve the robustness of setting thread affinity in DPDK
by adding detailed error logging.
Changes:
1. Check the return value of pthread_setaffinity_np() and log an error
if the call fails.
2. Include the current thread name, the intended CPU set, and a detailed
error message in the log.
Sample
Improve the robustness of setting thread affinity in DPDK
by adding detailed error logging.
Changes:
1. Check the return value of pthread_setaffinity_np() and log an error
if the call fails.
2. Include the current thread name, the intended CPU set, and a detailed
error message in the log.
Sample
Add unit test cases that test all of the enqueue/dequeue functions.
Both normal enqueue/dequeue functions and the zerocopy API functions.
Signed-off-by: Aditya Ambadipudi
Change-Id: Ida5bdefdd9d001b792a8d4be011387ff4f84c154
---
v2:
* Addressed the spell check warning issue with the word "Deque"
From: Honnappa Nagarahalli
Add a multi-thread unsafe double ended queue data structure. This
library provides a simple and efficient alternative to multi-thread
safe ring when multi-thread safety is not required.
Signed-off-by: Aditya Ambadipudi
Signed-off-by: Honnappa Nagarahalli
Change-Id: I
As previously discussed in the mailing list [1] we are sending out this
patch that provides the implementation and unit test cases for the
RTE_DEQUE library. This includes functions for creating a RTE_DEQUE
object. Allocating memory to it. Deleting that object and free'ing the
memory associated wi
Recheck-request: github-robot
Robin Jarry, Apr 14, 2024 at 12:35:
Jerin Jacob, Apr 06, 2024 at 01:11:
> Great.
>
> You may consider improving and/or adding inbuilt nodes for generic
> protocol processing. Furthermore, consider contributing on app/graph.
> I think, most likely, you should be able to leverage app/graph.
Tha
From: Chinh Cao
There are some function prototypes that were introduced at some point
but were never implemented, so remove them.
Signed-off-by: Chinh Cao
---
drivers/net/ixgbe/base/ixgbe_api.h | 1 -
drivers/net/ixgbe/base/ixgbe_x550.h | 2 --
2 files changed, 3 deletions(-)
diff --git a/dr
From: Milosz Szymonek
Add mask for MACLEN indexes in advanced context descriptors (bits 9:15).
IXGBE_ADVTXD_MACLEN_MASK will be used in Windows driver code.
Signed-off-by: Milosz Szymonek
---
drivers/net/ixgbe/base/ixgbe_type.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ix
From: Dawid Zielinski
Added length check against EEPROM size in words to prevent untrusted
loop bound reported by static code analysis.
Signed-off-by: Dawid Zielinski
---
drivers/net/ixgbe/base/ixgbe_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe
From: Barbara Skobiej
HWSW semaphore acquisition in Atom C3000 NIC is a two stage process.
Each time two semaphore acquisitions are required. Each second semaphore
failure require re-acquisition of first semaphore. This patch decouples
the two acquisitions preventing potentially hundreds of thous
From: Barbara Skobiej
This patch adds missing QV defines:
- offset of ANVM data
- Immediate Field module pointer offset
- 2.5GBASE-T and 5GBASE-T physical layer types for X550
Signed-off-by: Barbara Skobiej
Signed-off-by: Jan Sokolowski
---
drivers/net/ixgbe/base/ixgbe_type.h | 5 +
1 fil
From: Barbara Skobiej
Including one header file in second header file should be avoided, so
fix it by forward declaring the struct instead.
Signed-off-by: Barbara Skobiej barbara.skob...@intel.com
---
drivers/net/ixgbe/base/ixgbe_mbx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Marcin Jurczak
This patch removes non-inclusive language from code, user interface
and comments.
Signed-off-by: Marcin Jurczak
Reviewed-by: Michael, Alice
---
drivers/net/ixgbe/base/ixgbe_common.c | 34 +--
drivers/net/ixgbe/base/ixgbe_common.h | 2 +-
drivers/n
From: Krzysztof Galazka
Extend SFP+ cage crosstalk fix by re-checking link state
after 5ms delay to filter out spurious link up indication
by transceiver with no fibre cable connected.
Signed-off-by: Krzysztof Galazka
Reviewed-by: Jan Sokolowski
---
drivers/net/ixgbe/base/ixgbe_common.c | 19
From: Piotr Skajewski
As there have been a long list of flaws due to missing "break" statement
kernel no longer allow implict fall-through and reports warning during
compilation. Convert all "fall-through" comments to actual code.
Signed-off-by: Piotr Skajewski
Reviewed-by: Michael, Alice
---
From: Slawomir Mrozowicz
Adding a functionality that retrieves information from PF regarding
the link state of a given VF.
It is part of the general functionality that allows the PF driver
to control the state of the virtual link VF devices.
Signed-off-by: Slawomir Mrozowicz
Reviewed-by: Tyl, R
From: Mical MarekX
Unifying FW access method to direct register read/writes across
all Atom(R) C3000 products. Atom(R) C3000 fiber exhibited an issue with
the Host Interface Command execution being locked when
another LAN function attempted to acquire the SWFW sync
on Manageability Host. This res
From: Radoslaw Tyl
Add fw_rst_cnt to store the number of resets after fw update.
This value is required to detect if the EICR.MNG event occurred
after firmware update reset.
Signed-off-by: Radoslaw Tyl
Reviewed-by: Skajewski, PiotrX
Reviewed-by: Mrozowicz, SlawomirX
Reviewed-by: Michael, Alic
From: Radoslaw Tyl
Some function comments have mismatches between actual function names and
function name in comments, which causes warnings with kernel-doc. Fix
comments to match function names.
Signed-off-by: Radoslaw Tyl
Reviewed-by: Skajewski, PiotrX
Reviewed-by: Mrozowicz, SlawomirX
Revi
From: Slawomir Mrozowicz
Issue observed: system crash While loading the driver when debug macros
were defined.
The solution removes the debug macro call from
ixgbe_set_mac_type() function which causes the crash.
So far, the ixgbe_set_mac_type() function has called in the ixgbe driver
ixgbe_prob
From: Radoslaw Tyl
Change max credit and credit refill to a maximum possible value.
Too small values cause the incorrect calculation of the bandwidth limits
to each traffic class for frames larger than 4088 bytes.
Signed-off-by: Radoslaw Tyl
Reviewed-by: Skajewski, PiotrX
Tested-by: Skajewski,
From: Jakub Chylkowski
Current mailbox API does not work as described in documentation and
is prone to errors (for example, it is doing locks on read). Introduce
new mailbox API and provide compatibility functions with old API.
New error codes have been introduced:
- IXGBE_ERR_CONFIG - ixgbe_mbx
From: Jakub Chylkowski
Some of mailbox-related registers have different names than it is
specified in datasheet. Correct these names to correspond to their
datasheet counterparts. Additionally, several calculations are changed
to no longer use magic numbers but dedicated macros instead.
Signed-o
From: Jakub Chylkowski
There is name similarity within IXGBE_VT_MSGTYPE_ACK and
PFMAILBOX.ACK / VFMAILBOX.ACK which may cause confusion. Rename MSGTYPE
macros to SUCCESS and FAILURE as they are not specified in datasheet and
now will be easily distinguishable.
Signed-off-by: Jakub Chylkowski
Re
From: Radoslaw Tyl
Function ixgbe_get_phy_type_from_id() for X550_PHY_ID2 and
X550_PHY_ID3 always return ixgbe_phy_unknown instead of ixgbe_phy_aq
because phy ID's last 4 bits are always masked, and should not be
taken into account when selecting phy type.
This patch adds default PHY ID for X550
From: Piotr Skajewski
When 5000 Base-T was set on PF the VF reported 100 Base-T.
This patch change ixgbe_check_mac_link_vf function
where was incorrect conditional which points to PF mac types,
now it is pointing correctly to VF mac types.
Fixes: 12e20906905c ("net/ixgbe/base: include new speeds
From: Piotr Pietruszewski
This reverts the following commit:
13de249e ("net/ixgbe/base: remove default advertising for x550 2.5G/5G")
The commit removing advertising 2.5G and 5G speeds from
ixgbe_get_copper_speeds_supported() was supposed to disable 2.5G and 5G
during the autonegotiatio
This patchset updates IXGBE base driver to latest shared code snapshot,
fixing a few issues as well as adding support for new hardware.
Barbara Skobiej (3):
net/ixgbe/base: remove circular header dependency
net/ixgbe/base: add missing QV defines
net/ixgbe/base: improve SWFW semaphore acquisi
On 2024-04-24 12:21, Ferruh Yigit wrote:
On 4/23/2024 9:56 PM, Mattias Rönnblom wrote:
On 2024-04-23 13:15, Ferruh Yigit wrote:
On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
Cache align Rx and Tx queue struct to avoid false sharing.
RX struct happens to be 64 bytes on x86_64 already, so cach
https://bugs.dpdk.org/show_bug.cgi?id=1420
Bug ID: 1420
Summary: DTS: implement bind_ports_to_driver() for both nodes
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity:
On 4/24/2024 5:08 AM, Stephen Hemminger wrote:
> For the 24.11 release, I want to remove the unused type string argument
> that shows up in rte_malloc() and related functions, then percolates down
> through. It was a idea in the 1.0 release of DPDK, never implemented and
> never removed. Yes it w
On Wed, Apr 24, 2024 at 11:21:52AM +0100, Ferruh Yigit wrote:
> On 4/23/2024 9:56 PM, Mattias Rönnblom wrote:
> > On 2024-04-23 13:15, Ferruh Yigit wrote:
> >> On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
> >>> Cache align Rx and Tx queue struct to avoid false sharing.
> >>>
> >>> RX struct happe
On 4/23/2024 9:56 PM, Mattias Rönnblom wrote:
> On 2024-04-23 13:15, Ferruh Yigit wrote:
>> On 4/23/2024 10:08 AM, Mattias Rönnblom wrote:
>>> Cache align Rx and Tx queue struct to avoid false sharing.
>>>
>>> RX struct happens to be 64 bytes on x86_64 already, so cache alignment
>>> makes no chang
> From: Stephen Hemminger
> Sent: Wednesday, April 24, 2024 4:45 AM
> To: dev@dpdk.org
> Cc: Richardson, Bruce; Stephen Hemminger; Van Haaren, Harry; Jerin Jacob
> Subject: [PATCH] event: fix warning from useless snprintf
>
> With Gcc-14, this warning is generated:
> ../drivers/event/sw/sw_evdev.
https://bugs.dpdk.org/show_bug.cgi?id=1419
Bug ID: 1419
Summary: [mlx5] Segfault when calling rte_eth_dev_start() twice
Product: DPDK
Version: unspecified
Hardware: x86
OS: Linux
Status: UNCONFIRMED
Severi
59 matches
Mail list logo
