On Wed, 24 Apr 2024 11:29:51 +0100 Ferruh Yigit <ferruh.yi...@amd.com> wrote:
> On 4/24/2024 5:08 AM, Stephen Hemminger wrote: > > For the 24.11 release, I want to remove the unused type string argument > > that shows up in rte_malloc() and related functions, then percolates down > > through. It was a idea in the 1.0 release of DPDK, never implemented and > > never removed. Yes it will cause API breakage, a large sweeping change; > > probably easily scripted with coccinelle. > > > > Maybe doing ABI version now? > > > > Won't this impact many applications, is there big enough motivation to > force many DPDK applications to update their code, living with it looks > simpler. > Something like this script, and fix up the result. From 13ec14dff523f6e896ab55a17a3c66b45bd90bbc Mon Sep 17 00:00:00 2001 From: Stephen Hemminger <step...@networkplumber.org> Date: Wed, 24 Apr 2024 09:39:27 -0700 Subject: [PATCH] devtools/cocci: add script to find unnecessary malloc type The malloc type argument is unused and should be NULL. This script finds and fixes those places. Signed-off-by: Stephen Hemminger <step...@networkplumber.org> --- devtools/cocci/malloc-type.cocci | 33 ++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) create mode 100644 devtools/cocci/malloc-type.cocci diff --git a/devtools/cocci/malloc-type.cocci b/devtools/cocci/malloc-type.cocci new file mode 100644 index 0000000000..cd74797ecb --- /dev/null +++ b/devtools/cocci/malloc-type.cocci @@ -0,0 +1,33 @@ +// +// The Ting type field in malloc routines was never +// implemented and should be NULL +// +@@ +expression T != NULL; +expression num, socket, size, align; +@@ +( +- rte_malloc(T, size, align) ++ rte_malloc(NULL, size, align) +| +- rte_zmalloc(T, size, align) ++ rte_zmalloc(NULL, size, align) +| +- rte_calloc(T, num, size, align) ++ rte_calloc(NULL, num, size, align) +| +- rte_realloc(T, size, align) ++ rte_realloc(NULL, size, align) +| +- rte_realloc_socket(T, size, align, socket) ++ rte_realloc_socket(NULL, size, align, socket) +| +- rte_malloc_socket(T, size, align, socket) ++ rte_malloc_socket(NULL, size, align, socket) +| +- rte_zmalloc_socket(T, size, align, socket) ++ rte_zmalloc_socket(NULL, size, align, socket) +| +- rte_calloc_socket(T, num, size, align, socket) ++ rte_calloc_socket(NULL, num, size, align, socket) +) -- 2.43.0
