Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h

2024-04-06 Thread Ashish Sadanandan
On Wed, Apr 3, 2024 at 8:52 AM Thomas Monjalon wrote: > 02/04/2024 18:03, Ashish Sadanandan: > > Hi everyone, > > I've made the updates as suggested. Could someone please review the > latest > > patchset? Not sure if I followed the new patchset instructions correctly, > > I've always had trouble

RE: [PATCH 3/4] vhost: use alloca instead of vla sizeof

2024-04-06 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 4 April 2024 19.15 > > RFC sample illustrating conversion of VLA to alloca() where > sizeof(array) was in use. > > Signed-off-by: Tyler Retzlaff > --- > lib/vhost/socket.c | 5 +++-- > 1 file changed, 3 insertions(+)

RE: [PATCH] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-06 Thread Morten Brørup
> From: Patrick Robb [mailto:pr...@iol.unh.edu] > Sent: Saturday, 6 April 2024 21.21 > > On Sat, Apr 6, 2024 at 4:47 AM Morten Brørup > wrote: > > > > > > This change seems very CPU specific. > > > > E.g. in x86 32-bit mode, the hugepage size is 4 MB, not 2 MB. > > > > I don't know the recommende

Re: [PATCH] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-06 Thread Patrick Robb
On Sat, Apr 6, 2024 at 4:47 AM Morten Brørup wrote: > > > This change seems very CPU specific. > > E.g. in x86 32-bit mode, the hugepage size is 4 MB, not 2 MB. > > I don't know the recommended hugepage size on other architectures. > Thanks Morten, that's an important insight which we weren't awa

RE: [PATCH 2/4] hash: use alloca instead of vla trivial

2024-04-06 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 4 April 2024 19.15 > > RFC sample illustrating simple conversion of VLA to alloca() where > dimension multiplier removed. > > Signed-off-by: Tyler Retzlaff > --- [...] > { > - uint32_t tmp_tuple[tuple_len / siz

RE: [PATCH 4/4] dispatcher: use alloca instead of vla multi dimensional

2024-04-06 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 4 April 2024 19.15 > > RFC sample illustrating conversion of multi-dimensional VLA to use > alloca(). > > Signed-off-by: Tyler Retzlaff > --- > lib/dispatcher/rte_dispatcher.c | 6 +++--- > 1 file changed, 3 insertio

RE: [PATCH 1/4] latencystats: use alloca instead of vla trivial

2024-04-06 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 4 April 2024 19.15 > > RFC sample illustrating simple conversion of VLA to alloca(). > > Signed-off-by: Tyler Retzlaff > --- [...] > --- a/lib/latencystats/rte_latencystats.c > +++ b/lib/latencystats/rte_latencystat

RE: [PATCH 01/83] examples: move alignment attribute on types

2024-04-06 Thread Morten Brørup
+To: David Hunt, Distributor maintainer +To: Radu Nicolau and Akhil Goyal, IPsec security gateway example maintainers > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 20 March 2024 16.37 > > Move location of __rte_aligned(a) to new conventional location. The new > p

[PATCH 2/2] dma/cnxk: remove completion pool

2024-04-06 Thread pbhagavatula
From: Pavan Nikhilesh Use DMA ops to store metadata, remove use of completion pool. Signed-off-by: Pavan Nikhilesh --- drivers/dma/cnxk/cnxk_dmadev.c | 53 ++-- drivers/dma/cnxk/cnxk_dmadev.h | 24 +-- drivers/dma/cnxk/cnxk_dmadev_fp.c| 79 +-

[PATCH 1/2] eventdev/dma: reorganize event DMA ops

2024-04-06 Thread pbhagavatula
From: Pavan Nikhilesh Re-organize event DMA ops structure to allow holding source and destination pointers without the need for additional memory, the mempool allocating memory for rte_event_dma_adapter_ops can size the structure to accommodate all the needed source and destination pointers. Add

RE: [PATCH v1 1/2] deque: add multi-thread unsafe double ended queue

2024-04-06 Thread Morten Brørup
> From: Aditya Ambadipudi [mailto:aditya.ambadip...@arm.com] > Sent: Monday, 1 April 2024 03.37 > > From: Honnappa Nagarahalli > > Add a multi-thread unsafe double ended queue data structure. This > library provides a simple and efficient alternative to multi-thread > safe ring when multi-thread

RE: [PATCH] maintainers: change e-mail for vmxnet3

2024-04-06 Thread Morten Brørup
> From: Jochen Behrens [mailto:jochen.behr...@broadcom.com] > Sent: Friday, 5 April 2024 23.56 > > Change my address as VMware was acquired by Broadcom. > > Signed-off-by: Jochen Behrens > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/

RE: [PATCH v4 01/30] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy

2024-04-06 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Friday, 5 April 2024 18.53 > > Rte_memcpy should not be used for the simple case of copying > a fix size structure because it is slower and will hide problems "it is slower"... not always true. Perhaps: "it is not faster than m

RE: [PATCH] dts: Change hugepage runtime config to 2MB Exclusively

2024-04-06 Thread Morten Brørup
> From: Nicholas Pratte [mailto:npra...@iol.unh.edu] > Sent: Thursday, 4 April 2024 17.31 > > The previous implementation configures and allocates hugepage sizes > based on a system default. This can lead to two problems: overallocation > of > hugepages (which may crash the remote host), and confi