RE: [PATCH] test: fix option block

2024-03-14 Thread Jiale, SongX
> -Original Message- > From: Mingjin Ye > Sent: Thursday, March 14, 2024 5:46 PM > To: dev@dpdk.org > Cc: Ye, MingjinX ; sta...@dpdk.org > Subject: [PATCH] test: fix option block > > The options allow (-a) and block (-b) cannot be used at the same time. > Therefore, allow (-a) will not be

[PATCH v4 8/8] crypto/cnxk: update the context structure of tls

2024-03-14 Thread Vidya Sagar Velumuri
Keep the record context for TLS-1.3 in sync with microcode structure. Report error if optional padding is enabled for AEAD case in both TLS-1.2 and DTLS-1.2. Use the proper offset for calculating the context size in case of TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/r

[PATCH v4 7/8] crypto/cnxk: add support for oop processing in TLS

2024-03-14 Thread Vidya Sagar Velumuri
From: Aakash Sasidharan Add support for out-of-place processing in TLS. Signed-off-by: Aakash Sasidharan --- drivers/crypto/cnxk/cn10k_tls_ops.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_tls_ops.h b/drivers/crypto/cnxk/cn10k_tls_o

[PATCH v4 6/8] crypto/cnxk: add support for padding verification in TLS

2024-03-14 Thread Vidya Sagar Velumuri
For TLS-1.2: - Verify that the padding bytes are having pad len as the value. - Report error in case of discrepancies. - Trim the padding and MAC from the tls-1.2 records For TLS-1.3: - Find the content type as the last non-zero byte in the record. - Return the content type as the inner content

[PATCH v4 5/8] crypto/cnxk: move metadata to second cacheline

2024-03-14 Thread Vidya Sagar Velumuri
From: Anoob Joseph In security session, move PMD metadata to second cacheline. Also optimize the fields to minimize the memory usage. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 10 ++ drivers/crypto/cnxk/cn10k_ipsec.

[PATCH v4 4/8] crypto/cnxk: avoid branches in datapath

2024-03-14 Thread Vidya Sagar Velumuri
From: Anoob Joseph Avoid branches in datapath. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_ipsec_la_ops.h b/drivers/crypto/cnxk/cn10k_ipsec_la_ops.h index a30b8e4

[PATCH v4 3/8] crypto/cnxk: add support for session update for TLS

2024-03-14 Thread Vidya Sagar Velumuri
Add session update support for TLS Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 3 +++ drivers/crypto/cnxk/cn10k_tls.c | 17 + drivers/crypto/cnxk/cn10k_tls.h | 4 3 files changed, 24 insertions(+) diff --git a/dr

[PATCH v4 2/8] crypto/cnxk: enable sha384 and chachapoly for tls

2024-03-14 Thread Vidya Sagar Velumuri
Enable SHA384-HMAC support for TLS & DTLS 1.2. Enable CHACHA20-POLY1305 support for TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_ie_ot_tls.h | 1 + drivers/crypto/cnxk/cn10k_tls.c | 56 +-- drivers/crypto/cnxk/cnxk_cryptodev.h

[PATCH v4 1/8] crypto/cnxk: multi seg support block ciphers in tls

2024-03-14 Thread Vidya Sagar Velumuri
Add support for Scatter-Gather mode for block ciphers in TLS-1.2 Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 3 +- drivers/crypto/cnxk/cn10k_tls.c | 5 +++ drivers/crypto/cnxk/cn10k_tls_ops.h | 48 ++- 3 files changed,

[PATCH v4 0/8] Fixes and minor improvements for Crypto cnxk

2024-03-14 Thread Vidya Sagar Velumuri
Fixes and minor improvements for Crypto cnxk PMD. v4: * Addressed checkpatch issue v3: * Resend v2: * Squashed related patches Aakash Sasidharan (1): crypto/cnxk: add support for oop processing in TLS Anoob Joseph (2): crypto/cnxk: avoid branches in datapath crypto/cnxk: move metadata to

[PATCH v2 1/2] build: build only one library type on Windows

2024-03-14 Thread Tyler Retzlaff
MSVC is the only compiler that can produce usable shared libraries for DPDK on Windows because of the use of exported TLS variables. Disable building of shared libraries with LLVM and MinGW so that remaining __declspec macros needed for the functional libraries built by MSVC can be used without tr

[PATCH v2 2/2] buildtools: when building static library use static deps

2024-03-14 Thread Tyler Retzlaff
Use static deps when default_library=static and use shared deps when using default_library=shared. Signed-off-by: Tyler Retzlaff --- buildtools/chkincs/meson.build | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/buildtools/chkincs/meson.build b/buildtools/

[PATCH v2 0/2] build and install only one library type on Windows

2024-03-14 Thread Tyler Retzlaff
MSVC is the only compiler that can produce usable shared libraries for DPDK on Windows because of the use of exported TLS variables. Disable building of shared libraries with LLVM and MinGW so that remaining __declspec macros needed for the functional libraries built by MSVC can be used without tr

RE: [PATCH v2] dmadev: fix structure alignment

2024-03-14 Thread Ma, WenwuX
Hi Chengwen, > -Original Message- > From: fengchengwen > Sent: Friday, March 15, 2024 2:06 PM > To: Ma, WenwuX ; dev@dpdk.org > Cc: Jiale, SongX ; sta...@dpdk.org > Subject: Re: [PATCH v2] dmadev: fix structure alignment > > Hi Wenwu, > > On 2024/3/15 9:43, Wenwu Ma wrote: > > The struc

Re: [PATCH v2] dmadev: fix structure alignment

2024-03-14 Thread fengchengwen
Hi Wenwu, On 2024/3/15 9:43, Wenwu Ma wrote: > The structure rte_dma_dev needs only 8 byte alignment. > This patch replaces __rte_cache_aligned of rte_dma_dev > with __rte_aligned(8). > > Fixes: b36970f2e13e ("dmadev: introduce DMA device library") > Cc: sta...@dpdk.org > > Signed-off-by: Wenwu

Re: [PATCH v2] dmadev: fix structure alignment

2024-03-14 Thread Tyler Retzlaff
On Fri, Mar 15, 2024 at 09:43:31AM +0800, Wenwu Ma wrote: > The structure rte_dma_dev needs only 8 byte alignment. > This patch replaces __rte_cache_aligned of rte_dma_dev > with __rte_aligned(8). > > Fixes: b36970f2e13e ("dmadev: introduce DMA device library") > Cc: sta...@dpdk.org > > Signed-of

RE: [PATCH 3/3] net/vdev: fix insert vdev core dump

2024-03-14 Thread Jiang, YuX
> -Original Message- > From: Mingjin Ye > Sent: Thursday, March 14, 2024 5:37 PM > To: dev@dpdk.org > Cc: Ye, MingjinX ; sta...@dpdk.org > Subject: [PATCH 3/3] net/vdev: fix insert vdev core dump > > Inserting a vdev device when the device arguments are already stored in > devargs_list, t

[PATCH v3 8/8] crypto/cnxk: update the context structure of tls

2024-03-14 Thread Vidya Sagar Velumuri
Keep the record context for TLS-1.3 in sync with microcode structure. Report error if optional padding is enabled for AEAD case in both TLS-1.2 and DTLS-1.2. Use the proper offset for calculating the context size in case of TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/r

[PATCH v3 7/8] crypto/cnxk: add support for oop processing in TLS

2024-03-14 Thread Vidya Sagar Velumuri
From: Aakash Sasidharan Add support for out-of-place processing in TLS. Signed-off-by: Aakash Sasidharan --- drivers/crypto/cnxk/cn10k_tls_ops.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_tls_ops.h b/drivers/crypto/cnxk/cn10k_tls_o

[PATCH v3 6/8] crypto/cnxk: add support for padding verification in TLS

2024-03-14 Thread Vidya Sagar Velumuri
For TLS-1.2: - Verify that the padding bytes are having pad len as the value. - Report error in case of discrepancies. - Trim the padding and MAC from the tls-1.2 records For TLS-1.3: - Find the content type as the last non-zero byte in the record. - Return the content type as the inner content

[PATCH v3 5/8] crypto/cnxk: move metadata to second cacheline

2024-03-14 Thread Vidya Sagar Velumuri
From: Anoob Joseph In security session, move PMD metadata to second cacheline. Also optimize the fields to minimize the memory usage. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 10 ++ drivers/crypto/cnxk/cn10k_ipsec.

[PATCH v3 4/8] crypto/cnxk: avoid branches in datapath

2024-03-14 Thread Vidya Sagar Velumuri
From: Anoob Joseph Avoid branches in datapath. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_ipsec_la_ops.h b/drivers/crypto/cnxk/cn10k_ipsec_la_ops.h index a30b8e4

[PATCH v3 3/8] crypto/cnxk: add support for session update for TLS

2024-03-14 Thread Vidya Sagar Velumuri
Add session update support for TLS Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 3 +++ drivers/crypto/cnxk/cn10k_tls.c | 17 + drivers/crypto/cnxk/cn10k_tls.h | 4 3 files changed, 24 insertions(+) diff --git a/dr

[PATCH v3 2/8] crypto/cnxk: enable sha384 and chachapoly for tls

2024-03-14 Thread Vidya Sagar Velumuri
Enable SHA384-HMAC support for TLS & DTLS 1.2. Enable CHACHA20-POLY1305 support for TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_ie_ot_tls.h | 1 + drivers/crypto/cnxk/cn10k_tls.c | 56 +-- drivers/crypto/cnxk/cnxk_cryptodev.h

[PATCH v3 1/8] crypto/cnxk: multi seg support block ciphers in tls

2024-03-14 Thread Vidya Sagar Velumuri
Add support for Scatter-Gather mode for block ciphers in TLS-1.2 Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 3 +- drivers/crypto/cnxk/cn10k_tls.c | 5 +++ drivers/crypto/cnxk/cn10k_tls_ops.h | 48 ++- 3 files changed,

[PATCH v3 0/8] Fixes and minor improvements for Crypto cnxk

2024-03-14 Thread Vidya Sagar Velumuri
Fixes and minor improvements for Crypto cnxk PMD. v3: Resend v2: * Squashed related patches Aakash Sasidharan (1): crypto/cnxk: add support for oop processing in TLS Anoob Joseph (2): crypto/cnxk: avoid branches in datapath crypto/cnxk: move metadata to second cacheline Vidya Sagar Velum

[PATCH] app/testpmd: fix unpassed RSS algorithm

2024-03-14 Thread Jie Hai
The RSS algorithm from user is parased but not passed to the rte_eth_dev_rss_hash_update() API as we wanted, this patch fixes it. Fixes: 3da59f30a23f ("app/testpmd: set RSS hash algorithm") Cc: sta...@dpdk.org Signed-off-by: Jie Hai --- app/test-pmd/cmdline.c | 1 + 1 file changed, 1 insertion(

[PATCH v2] net/hns3: support new device

2024-03-14 Thread Jie Hai
This patch introduces the new devices, which are on-chip network interface controllers with RDMA/DCB/ROH supporting. One is 100GE and the other is 200GE. Both can be found on HIP09/HIP10 SoCs. Cc: sta...@dpdk.org Signed-off-by: Jie Hai --- doc/guides/nics/hns3.rst | 2 +- doc/guid

[PATCH v2] dmadev: fix structure alignment

2024-03-14 Thread Wenwu Ma
The structure rte_dma_dev needs only 8 byte alignment. This patch replaces __rte_cache_aligned of rte_dma_dev with __rte_aligned(8). Fixes: b36970f2e13e ("dmadev: introduce DMA device library") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma --- v2: - Because of performance drop, adjust the code to

[PATCH] net/igc: fix disabling timesync

2024-03-14 Thread Wenwu Ma
When disabling timesync, we should clear the IGC_RXPBS_CFG_TS_EN bit of IGC_RXPBS, the patch fixes this. Fixes: 4f6fbbf6f17d ("net/igc: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Wenwu Ma --- drivers/net/igc/igc_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

Re: [PATCH v4] net/i40e: support FEC feature

2024-03-14 Thread Medvedkin, Vladimir
Hi Zhichao, On 12/03/2024 08:44, Zeng, ZhichaoX wrote: Hi Vladimir: Thanks for your comments, some responses and questions are inline. From: Medvedkin, Vladimir Sent: Monday, March 11, 2024 11:59 PM To: Zeng, ZhichaoX ; dev@dpdk.org Cc: Cui, KaixinX ; Yang, Qiming ; Zhang, Yuying Subject:

[DPDK/ethdev Bug 1403] PMD: IDPF segfaults during init on GCP baremetal

2024-03-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1403 Bug ID: 1403 Summary: PMD: IDPF segfaults during init on GCP baremetal Product: DPDK Version: unspecified Hardware: All OS: Linux Status: UNCONFIRMED Severity: no

RE: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

2024-03-14 Thread Akhil Goyal
> Subject: Re: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library > tag > > We are rebuilding from this tag right now. I know the IPSEC update is > now postponed until after 24.03, but once this install is done, do you > want me to issue retests for all the recent patches which had

Re: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

2024-03-14 Thread Patrick Robb
We are rebuilding from this tag right now. I know the IPSEC update is now postponed until after 24.03, but once this install is done, do you want me to issue retests for all the recent patches which had failed for ARM on this library previously? Then I guess it will be verified as you say. On Thu,

[PATCH] build: build only one library type on Windows

2024-03-14 Thread Tyler Retzlaff
MSVC is the only compiler that can produce usable shared libraries for DPDK on Windows because of the use of exported TLS variables. Disable building of shared libraries with LLVM and MinGW so that remaining __declspec macros needed for the functional libraries built by MSVC can be used without tr

[PATCH] build and install only one library type on Windows

2024-03-14 Thread Tyler Retzlaff
MSVC is the only compiler that can produce usable shared libraries for DPDK on Windows because of the use of exported TLS variables. Disable building of shared libraries with LLVM and MinGW so that remaining __declspec macros needed for the functional libraries built by MSVC can be used without tr

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-03-14 Thread Akhil Goyal
> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt > endianness problem > > > From: Shihong Wang > > > > The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s > > value is stored in an array of encryption or authentication keys > > according to big-endian. So i

RE: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag

2024-03-14 Thread Akhil Goyal
> Subject: [EXTERNAL] [PATCH v3] doc/ipsec_mb: update Arm IPsec-MB library tag > > Updates the tag of Arm IPsec-MB library to SECLIB-IPSEC-2024.03.12 > in snow3g and zuc documentation. > > Signed-off-by: Jack Bond-Preston > Reviewed-by: Wathsala Vithanage Is this tag verified in CI?

RE: [EXT] [PATCH] app/test-crypto-perf: add throughput OOP decryption

2024-03-14 Thread Akhil Goyal
> During throughput running, re-filling the test data will > impact the performance test result. So for now, to run > decrypt throughput testing is not supported since the > test data is not filled. > > But if user requires OOP(out-of-place) mode, the test > data from source mbuf will never be mod

RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem

2024-03-14 Thread Akhil Goyal
> From: Shihong Wang > > The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s > value is stored in an array of encryption or authentication keys > according to big-endian. So it maybe need to convert the endianness > order to ensure that the value assigned to the SA salt is CPU-e

Re: [PATCH v6 02/23] mbuf: consolidate driver asserts for mbuf struct

2024-03-14 Thread Tyler Retzlaff
We've gone around in circles a little on this series. Let's discuss it at the next techboard meeting, please put it on the agenda. Summary MSVC does not support the typedef of zero-sized typed arrays used in struct rte_mbuf and a handful of other structs built on Windows. Better known as ``RTE_M

Re: [PATCH] hash: remove return statement from function returning void

2024-03-14 Thread Tyler Retzlaff
On Thu, Mar 14, 2024 at 04:58:54PM +0100, David Marchand wrote: > Hello Tyler, > > On Fri, Mar 8, 2024 at 10:20 PM Tyler Retzlaff > wrote: > > > > rte_thash_gfni_bulk and rte_thash_gfni_bulk_stub both return void. > > Remove superfluous return statement from rte_thash_gfni_bulk. > > > > Fixes: 94

[PATCH] eal: fix comment about vfio device info in version.map

2024-03-14 Thread Stephen Hemminger
The function was added for 24.03 release, not 23.11. Fixes: de2d364f0c57 ("vfio: get device info") Signed-off-by: Stephen Hemminger --- lib/eal/version.map | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/version.map b/lib/eal/version.map index c06ceaad5097..3df50c3fbb

Re: [PATCH] hash: remove return statement from function returning void

2024-03-14 Thread David Marchand
Hello Tyler, On Fri, Mar 8, 2024 at 10:20 PM Tyler Retzlaff wrote: > > rte_thash_gfni_bulk and rte_thash_gfni_bulk_stub both return void. > Remove superfluous return statement from rte_thash_gfni_bulk. > > Fixes: 944a03a5cfc1 ("hash: fix MSVC link on GFNI stubs") > Cc: step...@networkplumber.org

Re: [RFC v2] eal: increase passed max multi-process file descriptors

2024-03-14 Thread David Marchand
On Thu, Mar 14, 2024 at 4:23 PM Stephen Hemminger wrote: > Rather than mess with versioning everything, probably better to just > hold off to 24.11 release and do the change there. > > It will limit xdp and tap PMD's to 8 queues but no user has been > demanding more yet. IIUC, this limitation onl

Re: [RFC v2] eal: increase passed max multi-process file descriptors

2024-03-14 Thread Stephen Hemminger
On Fri, 8 Mar 2024 12:36:39 -0800 Stephen Hemminger wrote: > Both XDP and TAP device are limited in the number of queues > because of limitations on the number of file descriptors that > are allowed. The original choice of 8 was too low; the allowed > maximum is 253 according to unix(7) man page

Re: [PATCH 00/12] Add TLS features

2024-03-14 Thread Patrick Robb
Recheck-request: iol-broadcom-Performance Sorry, you had a false failure in CI, so triggering a retest to correct that. We need to tune this system to reduce performance variance - I am asking Broadcom if we can make the fail threshold less sensitive in the interim.

Re: [RFC] eal: increase the number of availble file descriptors for MP

2024-03-14 Thread David Marchand
On Fri, Mar 8, 2024 at 7:54 PM Stephen Hemminger wrote: > > The current limit of file descriptors is too low, it should have > been set to the maximum possible to send across an unix domain > socket. > > This is an attempt to allow increasing it without breaking ABI. > But in the process it expose

[PATCH v2 8/8] crypto/cnxk: update the context structure of tls

2024-03-14 Thread Vidya Sagar Velumuri
Keep the record context for TLS-1.3 in sync with microcode structure. Report error if optional padding is enabled for AEAD case in both TLS-1.2 and DTLS-1.2. Use the proper offset for calculating the context size in case of TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/r

[PATCH v2 7/8] crypto/cnxk: add support for oop processing in TLS

2024-03-14 Thread Vidya Sagar Velumuri
From: Aakash Sasidharan Add support for out-of-place processing in TLS. Signed-off-by: Aakash Sasidharan --- drivers/crypto/cnxk/cn10k_tls_ops.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_tls_ops.h b/drivers/crypto/cnxk/cn10k_tls_o

[PATCH v2 6/8] crypto/cnxk: add support for padding verification in TLS

2024-03-14 Thread Vidya Sagar Velumuri
For TLS-1.2: - Verify that the padding bytes are having pad len as the value. - Report error in case of discrepancies. - Trim the padding and MAC from the tls-1.2 records For TLS-1.3: - Find the content type as the last non-zero byte in the record. - Return the content type as the inner content

[PATCH v2 5/8] crypto/cnxk: move metadata to second cacheline

2024-03-14 Thread Vidya Sagar Velumuri
In security session, move PMD metadata to second cacheline. Also optimize the fields to minimize the memory usage. Signed-off-by: Anoob Joseph Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 10 ++ drivers/crypto/cnxk/cn10k_ipsec.c | 4 ++--

[PATCH v2 4/8] crypto/cnxk: avoid branches in datapath

2024-03-14 Thread Vidya Sagar Velumuri
From: Anoob Joseph Avoid branches in datapath. Signed-off-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec_la_ops.h | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/cnxk/cn10k_ipsec_la_ops.h b/drivers/crypto/cnxk/cn10k_ipsec_la_ops.h index a30b8e4

[PATCH v2 3/8] crypto/cnxk: add support for session update for TLS

2024-03-14 Thread Vidya Sagar Velumuri
Add session update support for TLS Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.c | 3 +++ drivers/crypto/cnxk/cn10k_tls.c | 17 + drivers/crypto/cnxk/cn10k_tls.h | 4 3 files changed, 24 insertions(+) diff --git a/dr

[PATCH v2 2/8] crypto/cnxk: enable sha384 and chachapoly for tls

2024-03-14 Thread Vidya Sagar Velumuri
Enable SHA384-HMAC support for TLS & DTLS 1.2. Enable CHACHA20-POLY1305 support for TLS-1.3. Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/roc_ie_ot_tls.h | 1 + drivers/crypto/cnxk/cn10k_tls.c | 56 +-- drivers/crypto/cnxk/cnxk_cryptodev.h

[PATCH v2 1/8] crypto/cnxk: multi seg support block ciphers in tls

2024-03-14 Thread Vidya Sagar Velumuri
Add support for Scatter-Gather mode for block ciphers in TLS-1.2 Signed-off-by: Vidya Sagar Velumuri --- drivers/crypto/cnxk/cn10k_cryptodev_sec.h | 3 +- drivers/crypto/cnxk/cn10k_tls.c | 5 +++ drivers/crypto/cnxk/cn10k_tls_ops.h | 48 ++- 3 files changed,

[PATCH v2 0/8] crypto/cnxk: fixes and minor updates for TLS

2024-03-14 Thread Vidya Sagar Velumuri
v2: * squashed the related patches Aakash Sasidharan (1): crypto/cnxk: add support for oop processing in TLS Anoob Joseph (1): crypto/cnxk: avoid branches in datapath Vidya Sagar Velumuri (6): crypto/cnxk: multi seg support block ciphers in tls crypto/cnxk: enable sha384 and chachapoly f

RE: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc algorithm

2024-03-14 Thread Akhil Goyal
> > Subject: RE: [EXTERNAL] [PATCH] app/crypto-perf-test: fix unset crc > > algorithm > > > > > Because net crc api is not thread-safe, setting crc algorithm by the > > > application will prevent race condition in the calc function. > > > Race condition still may occur when any of the threads will

Re: [PATCH v2 0/6] testpmd options parsing cleanup

2024-03-14 Thread Ferruh Yigit
On 3/14/2024 9:17 AM, David Marchand wrote: > This is a cleanup I had in store for ages but never sent. > The idea is to reuse the conventions from EAL and examples when it > comes to using getopt API. > > > Changes since v1: > - following Ferruh review, added 2 more cleanup patches, > > David M

[PATCH] net/gve: add IPv4 checksum offloading capability

2024-03-14 Thread Rushil Gupta
Gvnic's DQO format allows offloading IPv4 checksum. Made changes to Tx and Rx path to translate DPDK flags to descriptor for offloading (and vice-versa). Add ptype adminq support to only add this flags for supported L3/L4 packet-types. Signed-off-by: Rushil Gupta Reviewed-by: Joshua Washington -

Re: [PATCH] config/arm: add fallback march for Neoverse V2

2024-03-14 Thread Jerin Jacob
On Thu, Mar 7, 2024 at 1:36 PM Anoob Joseph wrote: > > Add march & fallback march for Neoverse V2 to support build with older > compilers that doesn't support mcpu = 'neoverse-v2'. > > Signed-off-by: Anoob Joseph Acked-by: Jerin Jacob > --- > > Depends-on: series-31402 ("config/arm: avoid mcp

RE: [PATCH v7 2/2] doc: announce Intel IPsec MB version bump

2024-03-14 Thread Power, Ciara
> -Original Message- > From: Brian Dooley > Sent: Thursday, March 14, 2024 10:38 AM > Cc: dev@dpdk.org; gak...@marvell.com; De Lara Guarch, Pablo > ; Dooley, Brian > Subject: [PATCH v7 2/2] doc: announce Intel IPsec MB version bump > > The Intel IPsec Multi-buffer version is set to be

Re: [PATCH v8 3/5] config/arm: add crypto march feature to thunderxt83

2024-03-14 Thread Jerin Jacob
On Thu, Mar 14, 2024 at 5:09 PM wrote: > > From: Pavan Nikhilesh > > Some older compilers don't recognize crypto march feature > for thunderxt83 mcpu. > Explicitly add it to march feature list. > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob > --- > config/arm/meson.build | 2 +- >

[PATCH 13/13] net/mlx5/hws: fix port ID for root matcher and rule

2024-03-14 Thread Itamar Gozlan
From: Erez Shitrit In root tables matcher and rule need to have their port-id, otherwise the translate function that done in dpdk layer will not get the right attributes. For that whenever the matcher is matching the source-port we need to get the relevant port-id before calling the translate fun

[PATCH 12/13] net/mlx5/hws: extending tag saving for match and jumbo

2024-03-14 Thread Itamar Gozlan
From: Erez Shitrit Save the exact tag when matching over jumbo masking. Fixes: 348cdeec6472 ("net/mlx5/hws: add FW WQE rule creation logic") Signed-off-by: Erez Shitrit Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-)

[PATCH 10/13] net/mlx5/hws: fix rule is in resize check

2024-03-14 Thread Itamar Gozlan
From: Alex Vesker The check to detect if a rule is in resize was done incorrectly, this can lead to an incorrect function call upon completion for rules which are not in resize (move). Since the resize_info is in a union we cannot rely only on the pointer value but also need to make sure the matc

[PATCH 11/13] net/mlx5/hws: drop at attach number of actions

2024-03-14 Thread Itamar Gozlan
From: Alex Vesker Requesting the user for number of action resources is not defined well enough, instead the user should provide an initial action template which should contain the future attached action templates. Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5

[PATCH 09/13] net/mlx5/hws: simplify code for updating CQ doorbell record

2024-03-14 Thread Itamar Gozlan
From: Yevgeny Kliteynik Simplify the code that does CQ poll - have DB record update as part of CQ polling. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx

[PATCH 08/13] net/mlx5/hws: fix code analysis error in passing 0 enum val

2024-03-14 Thread Itamar Gozlan
From: Yevgeny Kliteynik Instead of passing 0 as an enum parameter, define flag NONE. This resolves the following code analysis error: "enumerated type mixed with another type". This value is currently used in tests only, and will later be used in backward-compatible steering API. Fixes: 5cadd74f

Re: [PATCH v2 6/6] app/testpmd: enhance getopt_long usage

2024-03-14 Thread Ferruh Yigit
On 3/14/2024 9:17 AM, David Marchand wrote: > This is a cleanup similar to previous ones in EAL and examples. > Instead of using strcmp for every long options while getopt_long already > did such parsing, rely on getopt_long return value. > > Note for reviewers: this patch is best reviewed once ap

[PATCH 06/13] net/mlx5/hws: simplify send_queues_close code

2024-03-14 Thread Itamar Gozlan
From: Yevgeny Kliteynik Small simplification to the send_queues_close code Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/n

[PATCH 07/13] net/mlx5/hws: fix error flow in mlx5dr_context_open

2024-03-14 Thread Itamar Gozlan
From: Yevgeny Kliteynik Add missing spinlock destruction in error flow. Fixes: b0290e56dd08 ("net/mlx5/hws: add context object") Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx

[PATCH 05/13] net/mlx5/hws: return -rte_errno on rule creation failure

2024-03-14 Thread Itamar Gozlan
From: Yevgeny Kliteynik mlx5dr_rule_create returns -ret, so internal functions should return rte_errno on failure. Fix return values of the function that creates rule in root table. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_rule.c | 2 +- 1 file ch

[PATCH 04/13] net/mlx5/hws: remove unused capabilities and fields

2024-03-14 Thread Itamar Gozlan
From: Yevgeny Kliteynik The following caps were never in use: - wire_regc - metadata_c - metadata_c_mask Also send ring's reg_addr field wasn't in use. Removing these caps and fields from structs and removing the code that queried them. Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad

[PATCH 03/13] net/mlx5/hws: fix wrong comment in mlx5dr_send

2024-03-14 Thread Itamar Gozlan
From: Yevgeny Kliteynik Remove comment that documents parameter that doesn't exist. Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer") Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_send.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/

[PATCH 02/13] common/mlx5: fix error in mlx5 prm structs

2024-03-14 Thread Itamar Gozlan
From: Yevgeny Kliteynik Fix wrong reserved size and add helpful comment Fixes: 365cdf5f8ce ("net/mlx5/hws: add command layer") Signed-off-by: Yevgeny Kliteynik Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_prm.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/d

[PATCH 01/13] net/mlx5/hws: move warn into debug level when needed

2024-03-14 Thread Itamar Gozlan
From: Erez Shitrit When the user tries to create a matcher and if failed with specific errno (E2BIG) the message will be in debug level and not in warning. It is a part of a feature when the user re-try to insert a new matching depends on that errno, no need the annoying message. Fixes: c55c2bf

[PATCH v8 4/5] config/arm: add support for fallback march

2024-03-14 Thread pbhagavatula
From: Pavan Nikhilesh Some ARM CPUs have specific march requirements and are not compatible with the supported march list. Add fallback march in case the mcpu and the march advertised in the part_number_config are not supported by the compiler. Example mcpu = neoverse-n2 march =

[PATCH v8 5/5] config/arm: allow WFE to be enabled config time

2024-03-14 Thread pbhagavatula
From: Pavan Nikhilesh Allow RTE_ARM_USE_WFE to be enabled at meson configuration time by passing it via c_args instead of modifying `config/arm/meson.build`. Example usage: meson build -Dc_args='-DRTE_ARM_USE_WFE' \ --cross-file config/arm/arm64_cn10k_linux_gcc Signed-off-by: Pavan Nik

[PATCH v8 2/5] config/arm: add armv9-a march support

2024-03-14 Thread pbhagavatula
From: Pavan Nikhilesh Add armv9-a as supported march flag for ARM neoverse class of processors. Update supported march list to include armv9-a. Signed-off-by: Pavan Nikhilesh --- config/arm/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/config/arm/meson.buil

[PATCH v8 3/5] config/arm: add crypto march feature to thunderxt83

2024-03-14 Thread pbhagavatula
From: Pavan Nikhilesh Some older compilers don't recognize crypto march feature for thunderxt83 mcpu. Explicitly add it to march feature list. Signed-off-by: Pavan Nikhilesh --- config/arm/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/arm/meson.build b/

[PATCH v8 1/5] config/arm: avoid mcpu and march conflicts

2024-03-14 Thread pbhagavatula
From: Pavan Nikhilesh The compiler options march and mtune are a subset of mcpu and will lead to conflicts if improper march is chosen for a given mcpu. To avoid conflicts, discard part number march when mcpu is available and is supported by the compiler. Example: march = armv9-a

Re: [PATCH v2 5/6] app/testpmd: remove dead code for disabling cmdline library

2024-03-14 Thread Ferruh Yigit
On 3/14/2024 9:17 AM, David Marchand wrote: > The cmdline library is always enabled with meson. > Remove traces of a time when it may have been possible to disable it. > > Signed-off-by: David Marchand > Acked-by: Ferruh Yigit

RE: [PATCH] net/mlx5: fix next L3 protocol fetching

2024-03-14 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Dariusz Sosnowski > Sent: Thursday, March 14, 2024 12:59 PM > To: Slava Ovsiienko ; Ori Kam ; > Suanming Mou ; Matan Azrad > ; Gregory Etelson > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH] net/mlx5: fix next L3 protocol fetching > > During flo

Re: [PATCH v2 2/2] bus/pci: fix secondary process save 'FD' problem

2024-03-14 Thread Burakov, Anatoly
On 1/29/2024 10:22 AM, Chaoyong He wrote: From: Zerun Fu In the previous logic the 'fd' was only saved in the primary process, but for some devices this value is also used in the secondary logic. For example, the call of 'rte_pci_find_ext_capability()' will fail in the secondary process. Fix

Re: [PATCH v2 0/8] fix some coverity issues

2024-03-14 Thread Ferruh Yigit
On 3/14/2024 7:40 AM, Chaoyong He wrote: > This patch series fix some coverity issues, includes: > - 414936 > - 414937 > - 414938 > - 414939 > - 414941 > - 414942 > - 415042 > - 415051 > > --- > v2: > * Fix one imported uninitialized pointer problem. > --- > > Chaoyong He (6): > net/nfp: fix re

Re: [PATCH 0/8] fix some coverity issues

2024-03-14 Thread Ferruh Yigit
On 3/14/2024 10:58 AM, Ferruh Yigit wrote: > On 3/14/2024 7:05 AM, Chaoyong He wrote: >> This patch series fix some coverity issues, includes: >> - 414936 >> - 414937 >> - 414938 >> - 414939 >> - 414941 >> - 414942 >> - 415042 >> - 415051 >> >> Chaoyong He (6): >> net/nfp: fix return value check

[PATCH] net/mlx5: fix next L3 protocol fetching

2024-03-14 Thread Dariusz Sosnowski
During flow pattern validation in DV, the next protocol type should be calculated if and only if protocol mask is defined. Fixes: 1d7b7ec3a236 ("net/mlx5: remove code duplications") Cc: getel...@nvidia.com Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_dv.c |

Re: [PATCH 0/8] fix some coverity issues

2024-03-14 Thread Ferruh Yigit
On 3/14/2024 7:05 AM, Chaoyong He wrote: > This patch series fix some coverity issues, includes: > - 414936 > - 414937 > - 414938 > - 414939 > - 414941 > - 414942 > - 415042 > - 415051 > > Chaoyong He (6): > net/nfp: fix return value check > net/nfp: fix string overflow > net/nfp: fix unreac

Re: [PATCH v2 1/2] bus/pci: fix secondary process PCI uio resource map problem

2024-03-14 Thread Burakov, Anatoly
On 1/29/2024 10:22 AM, Chaoyong He wrote: From: Zerun Fu For the primary process, the logic loops all BARs and will skip the map of BAR with an invalid physical address (0), also will assign 'uio_res->nb_maps' with the real mapped BARs number. But for the secondary process, instead of loops all

[PATCH v7 2/2] doc: announce Intel IPsec MB version bump

2024-03-14 Thread Brian Dooley
The Intel IPsec Multi-buffer version is set to be bumped to a minimum version of 1.4 for the 24.11 LTS release. Signed-off-by: Brian Dooley --- doc/guides/rel_notes/deprecation.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_note

[PATCH v7 1/2] doc: remove outdated version details

2024-03-14 Thread Brian Dooley
SW PMDs documentation is updated to remove details of unsupported IPsec Multi-buffer versions. DPDK older than 20.11 is end of life. So, older DPDK versions are removed from the Crypto library version table. Signed-off-by: Sivaramakrishnan Venkat Signed-off-by: Brian Dooley Acked-by: Pablo de La

DPDK Release Status Meeting 2024-03-14

2024-03-14 Thread Mcnamara, John
Release status meeting minutes 2024-03-14 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the current/u

[DPDK/other Bug 1402] net/ice: vlan stripping is broken

2024-03-14 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1402 Bug ID: 1402 Summary: net/ice: vlan stripping is broken Product: DPDK Version: 23.07 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority

[PATCH] test: fix option block

2024-03-14 Thread Mingjin Ye
The options allow (-a) and block (-b) cannot be used at the same time. Therefore, allow (-a) will not be added when block (-b) is present. Fixes: b3ce7891ad38 ("test: fix probing in secondary process") Cc: sta...@dpdk.org Signed-off-by: Mingjin Ye --- app/test/process.h | 17 ++---

[PATCH 3/3] net/vdev: fix insert vdev core dump

2024-03-14 Thread Mingjin Ye
Inserting a vdev device when the device arguments are already stored in devargs_list, the rte_devargs_insert function replaces the supplied new devargs with the found devargs and frees the new devargs. As a result, the use of free devargs results in a core dump. This patch fixes the issue by using

[PATCH 2/3] bus/vdev: revert fix devargs after multi-process bus scan

2024-03-14 Thread Mingjin Ye
The asan tool detected a memory leak in the vdev driver alloc_devargs. The previous commit does not insert device arguments into devargs_list when attaching a device during a bus scan of a secondary process. This resulted in an existing memory leak when removing a vdev device, since rte_devargs_rem

[PATCH 1/3] bus/vdev: revert fix devargs in secondary process

2024-03-14 Thread Mingjin Ye
The asan tool detected a memory leak in the vdev driver alloc_devargs. The previous commit was that when inserting a vdev device, the primary process alloc devargs and the secondary process looks for devargs. This causes the device to not be created if the secondary process does not initialise the

[PATCH 0/3] fix insert dev core dump

2024-03-14 Thread Mingjin Ye
revert 2 patches and fix insert vdev core dump. Mingjin Ye (3): bus/vdev: revert fix devargs in secondary process bus/vdev: revert fix devargs after multi-process bus scan net/vdev: fix insert vdev core dump drivers/bus/vdev/vdev.c | 34 ++ 1 file changed, 6

RE: [PATCH 00/12] Add TLS features

2024-03-14 Thread Anoob Joseph
> Subject: [PATCH 00/12] Add TLS features > > Add the following features > 1. Multi segmented packet for TLS > 2. Padding verification for TLS > 3. SHA384 & ChaChaPoly for TLS > > Aakash Sasidharan (1): > crypto/cnxk: add support for oop processing in TLS > > Anoob Joseph (1): > crypto/cnxk:

  1   2   >