RE: [PATCH v3 6/6] table: replace zero length array with flex array

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 28 February 2024 00.57 > > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Tyler Retzlaff > --- Reviewed-by: Morten Brørup

RE: [PATCH v3 5/6] lpm: replace zero length array with flex array

> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 28 February 2024 00.57 > > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Tyler Retzlaff > --- Reviewed-by: Morten Brørup

Re: [PATCH v2] app/dma-perf: support bi-directional transfer

Hi Amit and Gowrishankar, It's nature to support multiple dmadev test in one testcase, and the original framework supports it. But it seem we both complicated it when adding support for non-mem2mem dma test. The new added "direction" and "vchan_dev" could treat as the dmadev's private configure

[dpdk-dev] [PATCH] common/cnxk: fix Coverity issues

From: Satheesh Paul Fix Out-of-bounds access and remove dead code reported by Coverity. Coverity issue: 384431, 384439, 380992 Fixes: 585bb3e538f9 ("common/cnxk: add VF support to base device class") Fixes: da1ec39060b2 ("common/cnxk: delay inline device RQ enable to dev start") Cc: sta...@dpdk.

[PATCH v2] app/eventdev: support DMA adapter test

Added performance test support for DMA adapter. Signed-off-by: Amit Prakash Shukla --- v2: - Fixed intel compilation error. app/test-eventdev/evt_common.h | 3 + app/test-eventdev/evt_main.c | 15 ++ app/test-eventdev/evt_options.c | 28 +++ app/test-eventdev/evt_options.

[DPDK/examples Bug 1387] [dpdk24.03] cbdma: Failed to launch dpdk-dma app

https://bugs.dpdk.org/show_bug.cgi?id=1387 Bug ID: 1387 Summary: [dpdk24.03] cbdma: Failed to launch dpdk-dma app Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: norm

[DPDK/ethdev Bug 1386] [dpdk-24.03] [ABI][meson test] driver-tests/link_bonding_autotest test failed: Segmentation fault when do ABI testing

https://bugs.dpdk.org/show_bug.cgi?id=1386 Bug ID: 1386 Summary: [dpdk-24.03] [ABI][meson test] driver-tests/link_bonding_autotest test failed: Segmentation fault when do ABI testing Product: DPDK Version: unspeci

Re: [PATCH v2] app/dma-perf: replace pktmbuf with mempool objects

On 2/27/2024 5:57 PM, fengchengwen wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hi Vipin, On 2024/2/27 17:57, Varghese, Vipin wrote: On 2/26/2024 7:35 AM, fengchengwen wrote: Caution: This mess

Re: [PATCH] app/dma-perf: add average latency per worker

On 2/27/2024 6:39 PM, fengchengwen wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hi Vipin, On 2024/2/27 17:50, Varghese, Vipin wrote: On 2/23/2024 3:15 PM, fengchengwen wrote: Caution: This mess

Re: [PATCH] app/dma-perf: add average latency per worker

On 2/23/2024 3:15 PM, fengchengwen wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. Hi Vipin, On 2023/12/20 0:40, Vipin Varghese wrote: Modify the user display data with total average latency per wo

Re: [PATCH] net/hns3: fix Rx packet truncation when KEEP CRC enabled

On 2024/2/27 0:43, Ferruh Yigit wrote: > On 2/26/2024 3:16 AM, Jie Hai wrote: >> On 2024/2/23 21:53, Ferruh Yigit wrote: >>> On 2/20/2024 3:58 AM, Jie Hai wrote: Hi, Ferruh, Thanks for your review. On 2024/2/7 22:15, Ferruh Yigit wrote: > On 2/6/2024 1:10 AM, Jie Hai

[DPDK/ethdev Bug 932] tap stop fails because of 'tap_lsc_intr_handle_set()' failure

https://bugs.dpdk.org/show_bug.cgi?id=932 Stephen Hemminger (step...@networkplumber.org) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[PATCH v3 6/6] table: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff --- lib/table/rte_table_acl.c | 2 +- lib/table/rte_table_array.c | 2 +- lib/table/rte_table_hash_cuckoo.c | 2 +- lib/table/rte_table_hash_ext.c| 2 +- lib/table/rte_table_ha

[PATCH v3 5/6] lpm: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff --- lib/lpm/rte_lpm6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/lpm/rte_lpm6.c b/lib/lpm/rte_lpm6.c index 271bc48..08fef82 100644 --- a/lib/lpm/rte_lpm6.c +++ b/li

[PATCH v3 1/6] hash: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Honnappa Nagarahalli Reviewed-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Stephen Hemminger --- lib/hash/rte_thash.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[PATCH v3 4/6] pipeline: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Add a temporary suppression for rte_pipeline_table_entry libabigail bug: Bugzilla ID: https://sourceware.org/bugzilla/show_bug.cgi?id=31377 Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Acked-by: Stephen Hemming

[PATCH v3 0/6] more replacement of zero length array

Replace some missed zero length arrays not captured in the original series. https://patchwork.dpdk.org/project/dpdk/list/?series=30410&state=* Zero length arrays are a GNU extension that has been superseded by flex arrays. https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html v3: * add temporary

[PATCH v3 3/6] fib: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Morten Brørup Acked-by: Stephen Hemminger --- lib/fib/dir24_8.h | 2 +- lib/fib/trie.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/fib/dir24_8.h

[PATCH v3 2/6] rcu: replace zero length array with flex array

Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Tyler Retzlaff Reviewed-by: Honnappa Nagarahalli Reviewed-by: Morten Brørup Acked-by: Chengwen Feng Acked-by: Stephen Hemminger --- lib/rcu/rcu_qsbr_pvt.h | 2 +- lib/rcu/rte_rcu_qsbr.h | 2 +- 2 files cha

[PATCH 3/3] rcu: use rte macro instead of GCC attribute

Use existing __rte_pure macro from rte_common.h instead of directly using __attribute__((__may_alias__)). Signed-off-by: Tyler Retzlaff --- lib/rcu/rcu_qsbr_pvt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/rcu/rcu_qsbr_pvt.h b/lib/rcu/rcu_qsbr_pvt.h index 5fd7ca2..39

[PATCH 2/3] lpm: use rte macro instead of GCC attribute

Use newly added __rte_pure macro from rte_common.h instead of directly using __attribute__((pure)). Signed-off-by: Tyler Retzlaff --- lib/lpm/rte_lpm.c | 4 ++-- lib/lpm/rte_lpm6.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/lpm/rte_lpm.c b/lib/lpm/rte_lpm.c index

[PATCH 1/3] eal: add rte pure attribute macro

Add __rte_pure for __attribute__((pure)) to permit elimination of direct use of __attribute__((pure)) in other libs. Signed-off-by: Tyler Retzlaff --- lib/eal/include/rte_common.h | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_comm

[PATCH 0/3] use rte macros instead of GCC __attribute

Clean up direct uses of GCC __attribute__ in libs outside of EAL. A checkpatch check already warns for new additions. Tyler Retzlaff (3): eal: add rte pure attribute macro lpm: use rte macro instead of GCC attribute rcu: use rte macro instead of GCC attribute lib/eal/include/rte_common.h |

Re: [PATCH] remove some MSVC conditional compile to empty

On Thu, Feb 15, 2024 at 02:20:17PM -0800, Tyler Retzlaff wrote: > Introduce a new macro __rte_attribute intended for internal use that > may be used when defining other __rte_xxx macros that should expand > empty on MSVC. > > Use the new macro to clean up conditional compile in rte_common.h > > T

Re: [PATCH v2] lib/hash: add siphash

On Tue, 27 Feb 2024 22:57:06 +0100 Mattias Rönnblom wrote: > The portable and x86 version will compile to the same thing on x86. > > A simpler implementation would be > > static __rte_always_inline uint64_t > u8to64_le(const uint8_t *p) > { > uint64_t w; > memcpy(&w, p, sizeof(w));

markdown list issues

Ran markdownlint https://github.com/markdownlint/markdownlint on current DPDK main. The results are: $ mdl doc/ doc//api/doxy-api-index.md:179: MD004 Unordered list style doc//api/doxy-api-index.md:186: MD004 Unordered list style doc//api/doxy-api-index.md:193: MD004 Unordered list style doc//api/

Re: [PATCH v2] lib/hash: add siphash

On 2024-02-27 20:14, Stephen Hemminger wrote: Add SipHash which is a fast and cryptographicly sound hash created by Jean-Philippe Aumasson and Daniel J. Bernstein. Siphash is widely used by Linux, FreeBSD, OpenBSD and other projects because it is fast and resistant to DoS attacks. This version is

Re: [PATCH v3 0/7] test case blocking and logging

I just had a very small comment which has nothing to do with functionality and is really just about something being checked twice which does no harm. Outside of that however, the whole series looked good to me.

Re: [PATCH v3 3/7] dts: filter test suites in executions

> + > +lowercase_suite_to_find = ( > +f"{self._test_suite_class_prefix}{module_name.replace('_', > '')}".lower() > +) > +for class_name, class_obj in inspect.getmembers(test_suite_module, > is_test_suite): > +if ( > +class_name.star

[PATCH] ethdev: fix coverity issue

Fixing uninitialized value access. Coverity issue: 414934 Fixes: 9a9eb104edf6 ("ethdev: parse multiple representor devargs") Signed-off-by: Harman Kalra --- lib/ethdev/ethdev_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/ethdev_driver.c b/lib/ethdev/ethdev_driver.c ind

Re: [PATCH] common/idpf: refine get packet type

Hi Beilei, Just a one nit below, besides that LGTM Acked-by: Vladimir Medvedkin On 22/12/2023 16:51, beilei.x...@intel.com wrote: From: Beilei Xing Since the response of virtual channel virtchnl2_get_ptype_info is changed on IMC side, driver needs to be updated when requiring the virtual ch

[PATCH v2] app/dma-perf: support bi-directional transfer

Adds bi-directional DMA transfer support to test performance. One DMA device on one core will do mem2dev transfer and another DMA device on another core will do dev2mem transfer. Depends-on: series-31252 ("PCI Dev and SG copy support") Signed-off-by: Amit Prakash Shukla --- v2: - Fixed depends o

[PATCH 1/2] build: build eal library with MSVC

* MSVC now has limited handling of GCC __extension__ keyword when compiling C so only expand __extension__ empty on MSVC when building with C++. * When building with MSVC enable the statement expressions compiler extension. * When building with MSVC enable building of eal library. Signed-o

[PATCH 2/2] build: build ring library with MSVC

* Use RTE_USE_C11_MEM_MODEL when building with MSVC. * When building with MSVC enable building of ring library. Signed-off-by: Tyler Retzlaff --- config/meson.build | 3 +++ lib/meson.build| 1 + 2 files changed, 4 insertions(+) diff --git a/config/meson.build b/config/meson.build index 68

[PATCH 0/2] build eal & ring libraries with MSVC

Enable build of eal & ring library when building with MSVC. This series depends on 2 other series that seem to be near being accepted for merge. https://patches.dpdk.org/project/dpdk/list/?series=31229 https://patches.dpdk.org/project/dpdk/list/?series=31230 Since the rc2 deadline is soon th

[PATCH v4 23/23] net/cnxk: other flow operations

Implementing other flow operations - validate, destroy, query, flush, dump for representor ports Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_rep_flow.c | 414 +++ drivers/net/cnxk/cnxk_rep_msg.h | 32 +++ 2 files changed, 446 insertions(+) diff --git a/dr

[PATCH v4 22/23] net/cnxk: flow create on representor ports

Implementing base infra for handling flow operations performed on representor ports, where these representor ports may be representing native representees or part of companian apps. Also added support for handling flow create operation Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_flow.h

[PATCH v4 21/23] net/cnxk: generalise flow operation APIs

Flow operations can be performed on cnxk ports as well as representor ports. Since representor ports are not cnxk ports but have eswitch as base device underneath, special handling is required to align with base infra. Introducing a flag to generic flow APIs to discriminate if the operation request

[PATCH v4 20/23] net/cnxk: add representor port pattern and action

Adding support for representor port as item matching and action. Signed-off-by: Harman Kalra --- doc/guides/nics/cnxk.rst | 1 + doc/guides/nics/features/cnxk.ini | 4 + doc/guides/nics/features/cnxk_vec.ini | 4 + doc/guides/nics/features/cnxk_vf.ini | 4 + drivers/net

[PATCH v4 19/23] net/cnxk: add represented port pattern and action

From: Kiran Kumar K Adding support for represented_port item matching and action. Signed-off-by: Kiran Kumar K Signed-off-by: Satheesh Paul Signed-off-by: Harman Kalra --- doc/guides/nics/cnxk.rst | 1 + doc/guides/nics/features/cnxk.ini | 1 + doc/guides/nics/features/c

[PATCH v4 17/23] net/cnxk: eswitch VF as ethernet device

Adding support for eswitch VF to probe as normal cnxk ethernet device Signed-off-by: Harman Kalra --- drivers/net/cnxk/cn10k_ethdev.c| 3 +++ drivers/net/cnxk/cnxk_ethdev.c | 41 +- drivers/net/cnxk/cnxk_ethdev.h | 3 +++ drivers/net/cnxk/cnxk_ethdev_ops

[PATCH v4 16/23] common/cnxk: base support for eswitch VF

Base ROC layer changes for supporting eswitch VF and NIX lbk changes for ESW Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_constants.h | 1 + drivers/common/cnxk/roc_dev.c | 1 + drivers/common/cnxk/roc_nix.c | 15 +-- drivers/common/cnxk/roc_nix.h | 1

[PATCH v4 18/23] common/cnxk: support port representor and represented port

From: Kiran Kumar K Implementing the common infrastructural changes for supporting port representors and represented ports used as action and pattern in net layer. Signed-off-by: Kiran Kumar K Signed-off-by: Satheesh Paul Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_npc.c |

[PATCH v4 14/23] common/cnxk: get representees ethernet stats

Implementing an mbox interface to fetch the representees's ethernet stats from the kernel. Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_eswitch.c | 45 +++ drivers/common/cnxk/roc_eswitch.h | 2 ++ drivers/common/cnxk/roc_mbox.h| 31 +++

[PATCH v4 13/23] net/cnxk: representor ethdev ops

Implementing ethernet device operation callbacks for port representors PMD Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_rep.c | 28 +- drivers/net/cnxk/cnxk_rep.h | 35 +++ drivers/net/cnxk/cnxk_rep_msg.h | 8 + drivers/net/cnxk/cnxk_rep_ops.c | 495 +

[PATCH v4 15/23] net/cnxk: ethernet statistics for representor

Adding representor ethernet statistics support which can fetch stats for representees which are operating independently or part of companian app. Adds xstats callback for representor port statistics. Signed-off-by: Harman Kalra Signed-off-by: Ankur Dwivedi --- drivers/net/cnxk/cnxk_rep.h |

[PATCH v4 12/23] net/cnxk: handling representee notification

In case of any representee coming up or going down, kernel sends a mbox up call which signals a thread to process these messages and enable/disable HW resources accordingly. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 8 + drivers/net/cnxk/cnxk_eswitch.h | 19 ++ drivers

[PATCH v4 11/23] common/cnxk: representee notification callback

Setting up a callback which gets invoked every time a representee comes up or goes down. Later this callback gets handled by network counterpart. Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_dev.c | 70 ++ drivers/common/cnxk/roc_dev_priv.h | 3 ++ dr

[PATCH v4 10/23] net/cnxk: add representor control plane

Implementing the control path for representor ports, where represented ports can be configured using TLV messaging. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 70 ++- drivers/net/cnxk/cnxk_eswitch.h | 8 + drivers/net/cnxk/cnxk_rep.c | 52 ++ drivers/net/cnxk/cnxk_

[PATCH v4 09/23] net/cnxk: eswitch fastpath routines

Implementing fastpath RX and TX fast path routines which can be invoked from respective representors rx burst and tx burst Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.h | 5 + drivers/net/cnxk/cnxk_eswitch_rxtx.c | 211 +++ drivers/net/cnxk/meson.

[PATCH v4 08/23] net/cnxk: eswitch flow configurations

Adding flow rules for eswitch PF and VF and implementing interfaces to delete, shift flow rules Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 44 +++ drivers/net/cnxk/cnxk_eswitch.h | 25 +- drivers/net/cnxk/cnxk_eswitch_devargs.c | 1 + drivers/net/cnxk/c

[PATCH v4 07/23] common/cnxk: interface to update VLAN TPID

Introducing eswitch variant of set vlan tpid api which can be using for PF and VF Signed-off-by: Harman Kalra --- drivers/common/cnxk/roc_eswitch.c | 15 +++ drivers/common/cnxk/roc_eswitch.h | 4 drivers/common/cnxk/roc_nix_priv.h | 11 +-- drivers/common/cnxk/roc_ni

[PATCH v4 06/23] common/cnxk: common NPC changes for eswitch

Adding new MCAM API for installing flow using generic npc_install_flow mbox and other helper APIs. Also adding rss action configuration for eswitch. Signed-off-by: Harman Kalra --- drivers/common/cnxk/meson.build| 1 + drivers/common/cnxk/roc_api.h | 3 + drivers/common/cnxk/roc_esw

[PATCH v4 05/23] net/cnxk: probing representor ports

Basic skeleton for probing representor devices. If PF device is passed with "representor" devargs, representor ports gets probed as a separate ethdev device. Signed-off-by: Harman Kalra --- MAINTAINERS | 1 + doc/guides/nics/cnxk.rst| 35 + drivers/net/cnxk/cnx

[PATCH v4 04/23] net/cnxk: eswitch devargs parsing

Implementing the devargs parsing logic via which the representors pattern is provided. These patterns define for which representies representors shall be created. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 88 + drivers/net/cnxk/cnxk_eswitch.h

[PATCH v4 03/23] net/cnxk: eswitch HW resource configuration

Configuring the hardware resources used by the eswitch device. Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 216 1 file changed, 216 insertions(+) diff --git a/drivers/net/cnxk/cnxk_eswitch.c b/drivers/net/cnxk/cnxk_eswitch.c index c4ea3063a

[PATCH v4 02/23] net/cnxk: implementing eswitch device

Eswitch device is a parent or base device behind all the representors, acting as transport layer between representors and representees Signed-off-by: Harman Kalra --- drivers/net/cnxk/cnxk_eswitch.c | 378 drivers/net/cnxk/cnxk_eswitch.h | 103 + drivers/

[PATCH v4 01/23] common/cnxk: add support for representors

Introducing a new Mailbox for registering base device behind all representors and also registering debug log type for representors and base device driver. Signed-off-by: Harman Kalra --- doc/guides/nics/cnxk.rst| 4 drivers/common/cnxk/roc_constants.h | 1 + drivers/common/cnx

[PATCH v4 00/23] net/cnxk: support for port representors

Introducing port representor support to CNXK drivers by adding virtual ethernet ports providing a logical representation in DPDK for physical function(PF) or SR-IOV virtual function (VF) devices for control and monitoring. These port representor ethdev instances can be spawned on an as needed basi

[PATCH v2] lib/hash: add siphash

Add SipHash which is a fast and cryptographicly sound hash created by Jean-Philippe Aumasson and Daniel J. Bernstein. Siphash is widely used by Linux, FreeBSD, OpenBSD and other projects because it is fast and resistant to DoS attacks. This version is designed to be useful as alternative hash with

[PATCH v10 2/4] app/dma-perf: add PCI device support

Add support to test performance for "device to memory" and "memory to device" data transfer. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- v10: - PCI config parsing using kvargs. app/test-dma-perf/benchmark.c | 117 ++ ap

Re: [PATCH v9] net/bnx2x: fix warnings about rte_memcpy lengths

On Tue, 27 Feb 2024 12:27:31 +0100 Morten Brørup wrote: > > > 1. The extra 2 byte copy is effectively harmless due to padding, as > > mentioned in the commit message. > > > 2. The decorated rte_memcpy (if work on that patch series is ever > > > resumed) > > is an improvement, not a bug fix

[PATCH v10 4/4] app/dma-perf: add SG copy support

From: Gowrishankar Muthukrishnan Add SG copy support. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- v10: - SG config variables renamed. app/test-dma-perf/benchmark.c | 278 +- app/test-dma-perf/config.ini | 25

[PATCH] common/cnxk: fix link cfg for sdp

Link configure registers are invalid and should not be accessed for SDP ports. But while on txq release which does SQ flush calls backpressure disable API which configures these link registers. Fixes: 58debb813a8d ("common/cnxk: enable TM to listen on Rx pause frames") Signed-off-by: Harman Kalra

[PATCH v10 3/4] app/dma-perf: validate copied memory

From: Gowrishankar Muthukrishnan Validate copied memory to ensure DMA copy did not fail. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- app/test-dma-perf/benchmark.c | 21 - app/test-dma-perf/main.c | 16 +++-

[PATCH v10 1/4] app/dma-perf: add skip support

Add support to skip running a dma-perf test-case. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- app/test-dma-perf/config.ini | 2 ++ app/test-dma-perf/main.c | 48 ++-- app/test-dma-perf/main.h | 1 + 3 files cha

[PATCH v10 0/4] PCI Dev and SG copy support

Improve dma-perf application to support PCI dev and SG copy, along with additional supports as below: - validate copied memory - skip tests if not opted. v10: - Review suggestions. - v9 sent again. Amit Prakash Shukla (2): app/dma-perf: add skip support app/dma-perf: add PCI device support

Re: [PATCH v3 00/16] stop using variadic argument pack extension

On Mon, Feb 26, 2024 at 12:54:36PM -0800, Stephen Hemminger wrote: > On Mon, 26 Feb 2024 12:19:30 -0800 > Tyler Retzlaff wrote: > > > RTE_LOG_LINE cannot be augmented with a prefix format and arguments > > without the user of RTE_LOG_LINE using the args... and ## args compiler > > extension to co

Re: [PATCH] dumpcap: correctly disable promiscuous mode at exit

On Tue, 27 Feb 2024 11:23:26 +0200 Isaac Boukris wrote: > Signed-off-by: Isaac Boukris > --- > app/dumpcap/main.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/app/dumpcap/main.c b/app/dumpcap/main.c > index d57db0589a..88cec43086 100644 > --- a/app/dumpcap/main

[PATCH v5 4/4] hash: add SVE support for bulk key lookup

- Implemented SVE code for comparing signatures in bulk lookup. - Added Defines in code for SVE code support. - Optimise NEON code - New SVE code is ~5% slower than optimized NEON for N2 processor. Signed-off-by: Yoan Picchi Signed-off-by: Harjot Singh Reviewed-by: Nathan Brown Reviewed-by: Rui

[PATCH v5 3/4] test/hash: check bulk lookup of keys after collision

This patch adds unit test for rte_hash_lookup_bulk(). It also update the test_full_bucket test to the current number of entries in a hash bucket. Signed-off-by: Yoan Picchi Signed-off-by: Harjot Singh Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- app/test/test_hash.c | 99 ++

[PATCH v5 1/4] hash: pack the hitmask for hash in bulk lookup

Current hitmask includes padding due to Intel's SIMD implementation detail. This patch allows non Intel SIMD implementations to benefit from a dense hitmask. Signed-off-by: Yoan Picchi Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- .mailmap | 2 + lib/hash/rte_cuck

[PATCH v5 0/4] hash: add SVE support for bulk key lookup

From: Yoan Picchi This patchset adds SVE support for the signature comparison in the cuckoo hash lookup and improves the existing NEON implementation. These optimizations required changes to the data format and signature of the relevant functions to support dense hitmasks (no padding) and having

[PATCH v5 2/4] hash: optimize compare signature for NEON

Upon a successful comparison, NEON sets all the bits in the lane to 1 We can skip shifting by simply masking with specific masks. Signed-off-by: Yoan Picchi Reviewed-by: Ruifeng Wang Reviewed-by: Nathan Brown --- lib/hash/rte_cuckoo_hash.c | 16 +++- 1 file changed, 7 insertions(+)

[PATCH] lib/hash: add SipHash function

Add SipHash which is a fast and cryptographicly sound hash created by Jean-Philippe Aumasson and Daniel J. Bernstein. Siphash is widely used by Linux, FreeBSD, OpenBSD and other projects because it is fast and resistant to DoS attacks. This version is designed to be useful as alternative hash with

Re: [PATCH] net/ixgbevf: fix RSS init for x550 nics

On 15/02/2024 13:31, edwin.brosse...@6wind.com wrote: From: Edwin Brossette Different Intel nics with the igxbe pmd do not handle RSS in the same way when working with virtualization. While some nics like Intel 82599ES only have a single RSS table in the device and leave all rss features to b

Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

On Tue, Feb 27, 2024 at 04:18:10PM +0100, David Marchand wrote: > Hello Dodji, > > On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff > wrote: > > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > > RTE_MARKER fields from rte_mbuf struct. > > > > Maintain alignment of fields a

Re: [PATCH v6 01/23] mbuf: add accessors for rearm and Rx descriptor fields

On Tue, Feb 27, 2024 at 10:10:03AM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Tuesday, 27 February 2024 06.41 > > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Provide > > inline functions to access compatible type pointe

Re: [PATCH 1/2] baseband/fpga_5gnr_fec: use new barrier API

Hi Tyler, On 2/26/24 12:03, Maxime Coquelin wrote: Hello, On 2/22/24 19:05, Chautru, Nicolas wrote: Hi Maxime, Why would we change this here and now? Is the intent not to use new suggested semantics for new patches only? The pull request was rejected because of the use of such barrier, whi

RE: [RFC v4 1/6] eal: add static per-lcore memory allocation facility

> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Tuesday, 27 February 2024 17.28 > > On 2024-02-27 16:05, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > >> Sent: Tuesday, 27 February 2024 14.44 > >> > >> On 2024-02-27 10:58, Morten Brørup wrote: >

Re: [RFC v4 1/6] eal: add static per-lcore memory allocation facility

On 2024-02-27 16:05, Morten Brørup wrote: From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] Sent: Tuesday, 27 February 2024 14.44 On 2024-02-27 10:58, Morten Brørup wrote: From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] Sent: Sunday, 25 February 2024 16.03 [...] +static vo

[PATCH v9 1/4] app/dma-perf: add skip support

Add support to skip running a dma-perf test-case. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- app/test-dma-perf/config.ini | 2 ++ app/test-dma-perf/main.c | 48 ++-- app/test-dma-perf/main.h | 1 + 3 files cha

RE: [PATCH] net/mlx5: fix condition of LACP miss flow

Hi, > -Original Message- > From: Bing Zhao > Sent: Wednesday, February 21, 2024 8:50 AM > To: Suanming Mou ; Raslan Darawsheh > ; dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix condition of LACP miss fl

RE: [PATCH] net/mlx5/hws: set the correct VLAN inner_type value

Hi, > -Original Message- > From: Bing Zhao > Sent: Wednesday, February 21, 2024 8:28 AM > To: Suanming Mou ; Raslan Darawsheh > ; dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org; Hamdan Agbariya > ; Erez Shitrit > Subject: [PATCH] net/

Re: [RFC PATCH 1/2] power: refactor core power management library

On 2/20/2024 3:33 PM, Sivaprasad Tummala wrote: > This patch introduces a comprehensive refactor to the core power > management library. The primary focus is on improving modularity > and organization by relocating specific driver implementations > from the 'lib/power' directory to dedicated direct

RE: [PATCH] net/mlx5: prevent querying aged flows on uninit port

Hi, > -Original Message- > From: Bing Zhao > Sent: Wednesday, February 21, 2024 5:23 AM > To: Suanming Mou ; Raslan Darawsheh > ; dev@dpdk.org > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org; Michael Baum > > Subject: [PATCH] net/mlx5: prevent quer

RE: [PATCH] net/mlx5: fix error packets drop in the regular Rx

Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Tuesday, February 20, 2024 1:45 PM > To: dev@dpdk.org > Cc: Matan Azrad ; Raslan Darawsheh > ; Ori Kam ; Dariusz Sosnowski > ; sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix error packets drop in the regular Rx > > When packet ge

RE: [PATCH] net/mlx5: fix use after free when releasing tx queues

Hi, > -Original Message- > From: Yunjian Wang > Sent: Tuesday, February 20, 2024 11:32 AM > To: dev@dpdk.org > Cc: Dariusz Sosnowski ; Ori Kam > ; Matan Azrad ; Slava Ovsiienko > ; Suanming Mou ; > luyi...@huawei.com; Pengfei Sun ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5: fix use aft

RE: [PATCH v3] net/mlx5: enable PCI related counters

Hi, > -Original Message- > From: Wathsala Vithanage > Sent: Thursday, February 15, 2024 8:27 PM > To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > Dariusz Sosnowski ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Matan Azrad > Cc: dev@dpdk.org; n...@arm.com; Wathsala Vithanage > ; Honnappa

RE: [PATCH v2] build: make buffer headroom configurable

> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Tuesday, 27 February 2024 17.02 > > While this is not likely a setting that many will need to change, it's > not > the first time I've heard of users looking to adjust it. > > Because it's such a simple change, I'd support havin

RE: [EXT] Re: [PATCH v8 4/4] app/dma-perf: add SG copy support

> > diff --git a/app/test-dma-perf/config.ini > > b/app/test-dma-perf/config.ini index cddcf93c6e..f460b93414 100644 > > --- a/app/test-dma-perf/config.ini > > +++ b/app/test-dma-perf/config.ini > > @@ -9,6 +9,8 @@ > > ; "buf_size" denotes the memory size of a single operation. > > ; "dma_ring_si

RE: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 27 February 2024 16.18 > > Hello Dodji, > > On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff > wrote: > > > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > > RTE_MARKER fields from rte_mbuf struct. >

[PATCH v9 2/4] app/dma-perf: add PCI device support

Add support to test performance for "device to memory" and "memory to device" data transfer. Signed-off-by: Amit Prakash Shukla Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- v9: - PCI config parsing using kvargs. app/test-dma-perf/benchmark.c | 117 ++ app

Re: [PATCH v2] build: make buffer headroom configurable

On Tue, Feb 20, 2024 at 02:57:35PM +, Parthakumar Roy wrote: > The default value for RTE_PKTMBUF_HEADROOM used to be set in > config/rte_config.h. This patch removes it from the file and > instead, a meson option, pkt_mbuf_headroom, is introduced to make > headroom tunable from the build proces

[PATCH v9 4/4] app/dma-perf: add SG copy support

From: Gowrishankar Muthukrishnan Add SG copy support. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- v9: - SG config variables renamed. app/test-dma-perf/benchmark.c | 278 +- app/test-dma-perf/config.ini | 25 +

[PATCH v9 3/4] app/dma-perf: validate copied memory

From: Gowrishankar Muthukrishnan Validate copied memory to ensure DMA copy did not fail. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Anoob Joseph Acked-by: Chengwen Feng --- app/test-dma-perf/benchmark.c | 21 - app/test-dma-perf/main.c | 16 +++-

[PATCH v9 0/4] PCI Dev and SG copy support

Improve dma-perf application to support PCI dev and SG copy, along with additional supports as below: - validate copied memory - skip tests if not opted. v9: - Review suggestions. Amit Prakash Shukla (2): app/dma-perf: add skip support app/dma-perf: add PCI device support Gowrishankar Muth

[PATCH] net/mlx5: fix the HWS registers initialization

The method to initialize tag registers by using capability bits is not supported on some old NICs. In the meanwhile, the HWS for flow rule insertion is not supported either. There is no need to initialize HWS only resource on the old NICs. Fixes: 48041ccbaa8d ("net/mlx5: initialize HWS flow regist

Re: [PATCH v6 20/23] mbuf: remove and stop using rte marker fields

Hello Dodji, On Tue, Feb 27, 2024 at 6:44 AM Tyler Retzlaff wrote: > > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 alignas(RTE_CACHE_LINE_MIN_SIZE).

RE: [RFC v4 1/6] eal: add static per-lcore memory allocation facility

> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Tuesday, 27 February 2024 14.44 > > On 2024-02-27 10:58, Morten Brørup wrote: > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > >> Sent: Sunday, 25 February 2024 16.03 > > > > [...] > > > >> +static void * > >> +lco

  1   2   >