[PATCH v3 7/7] dts: improve test suite and case filtering

2024-02-22 Thread Juraj Linkeš
The two places where we specify which test suite and test cases to run are complimentary and not that intuitive to use. A unified way provides a better user experience. The syntax in test run configuration file has not changed, but the environment variable and the command line arguments was change

[PATCH v3 6/7] dts: refactor logging configuration

2024-02-22 Thread Juraj Linkeš
Remove unused parts of the code and add useful features: 1. Add DTS execution stages such as execution and test suite to better identify where in the DTS lifecycle we are when investigating logs, 2. Logging to separate files in specific stages, which is mainly useful for having test suite log

[PATCH v3 5/7] dts: block all test cases when earlier setup fails

2024-02-22 Thread Juraj Linkeš
In case of a failure before a test suite, the child results will be recursively recorded as blocked, giving us a full report which was missing previously. Signed-off-by: Juraj Linkeš --- dts/framework/runner.py | 21 ++-- dts/framework/test_result.py | 186 +

[PATCH v3 4/7] dts: reorganize test result

2024-02-22 Thread Juraj Linkeš
The current order of Result classes in the test_suite.py module is guided by the needs of type hints, which is not as intuitively readable as ordering them by the occurrences in code. The order goes from the topmost level to lowermost: BaseResult DTSResult ExecutionResult BuildTargetResult TestSuit

[PATCH v3 3/7] dts: filter test suites in executions

2024-02-22 Thread Juraj Linkeš
We're currently filtering which test cases to run after some setup steps, such as DPDK build, have already been taken. This prohibits us to mark the test suites and cases that were supposed to be run as blocked when an earlier setup fails, as that information is not available at that time. To reme

[PATCH v3 2/7] dts: move test suite execution logic to DTSRunner

2024-02-22 Thread Juraj Linkeš
Move the code responsible for running the test suite from the TestSuite class to the DTSRunner class. This restructuring decision was made to consolidate and unify the related logic into a single unit. Signed-off-by: Juraj Linkeš --- dts/framework/runner.py | 175

[PATCH v3 1/7] dts: convert dts.py methods to class

2024-02-22 Thread Juraj Linkeš
The dts.py module deviates from the rest of the code without a clear reason. Converting it into a class and using better naming will improve organization and code readability. Signed-off-by: Juraj Linkeš --- dts/framework/dts.py| 338 dts/framework/ru

[PATCH v3 0/7] test case blocking and logging

2024-02-22 Thread Juraj Linkeš
We currently don't record test case results that couldn't be executed because of a previous failure, such as when a test suite setup failed, resulting in no executed test cases. In order to record the test cases that couldn't be executed, we must know the lists of test suites and test cases ahead

[PATCH v2 2/2] common/qat: decouple pmds from the common code

2024-02-22 Thread Arkadiusz Kusztal
Service specific functions were moved to services files. Weak symbols for device create/destroy were removed, named private devs were replaced by an opaque array. Signed-off-by: Arkadiusz Kusztal --- drivers/common/qat/qat_device.c | 112 ++-- drivers/common/q

[PATCH v2 1/2] drivers/qat: isolate parser arguments configuration

2024-02-22 Thread Arkadiusz Kusztal
This commit isolates qat device arguments from the common code. Now arguments are defined per service, and only appear in the application if the service is compiled-in. Signed-off-by: Arkadiusz Kusztal --- drivers/common/qat/qat_common.c | 11 +++ drivers/common/qat/qat_common.h | 3 +

[PATCH] maintainers: update for graph libraries

2024-02-22 Thread Zhirun Yan
Update the email address for graph libraries. Signed-off-by: Zhirun Yan --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 962c359cdd..ff71dc2825 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1738,7 +1738,7 @@ Graph M: Jerin Jaco

RE: [24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node

2024-02-22 Thread Yan, Zhirun
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, February 22, 2024 8:24 PM > To: jer...@marvell.com; ndabilpu...@marvell.com; kirankum...@marvell.com; > Yan, Zhirun ; Pavan Nikhilesh > ; Ruifeng Wang ; > Richardson, Bruce ; Konstantin Ananyev > > Cc: dev@dpdk.org

RE: [24.11 PATCH v3 2/5] graph: add node fastpath error counters

2024-02-22 Thread Yan, Zhirun
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, February 22, 2024 8:24 PM > To: jer...@marvell.com; ndabilpu...@marvell.com; kirankum...@marvell.com; > Yan, Zhirun > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [24.11 PATCH v3 2/5] graph: add node fastpath erro

RE: [24.11 PATCH v3 1/5] graph: add support for node specific errors

2024-02-22 Thread Yan, Zhirun
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Thursday, February 22, 2024 8:24 PM > To: jer...@marvell.com; ndabilpu...@marvell.com; kirankum...@marvell.com; > Yan, Zhirun > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [24.11 PATCH v3 1/5] graph: add support for node spec

[PATCH v4] app/testpmd: support updating flow rule actions

2024-02-22 Thread Oleksandr Kolomeiets
"flow update" updates a flow rule specified by a rule ID with a new action list by making a call to "rte_flow_actions_update()": flow update {port_id} {rule_id} actions {action} [/ {action} [...]] / end [user_id] Creating, updating and destroying a flow rule: testpmd> flow create

[PATCH v2 2/2] net/mlx5: fix modify flex item error

2024-02-22 Thread Rongwei Liu
In the rte_flow_field_data structure, the flex item handle is part of union with other members like level/tag_index. If the user wants to modify the flex item as source or destination, there should not be any checking against zero. Signed-off-by: Rongwei Liu Fixes: c23626f27b09 ("ethdev: add MPL

[PATCH v2 1/2] app/testpmd: fix modify tag typo

2024-02-22 Thread Rongwei Liu
Update the name to the right one: "src_tag_index" Signed-off-by: Rongwei Liu Fixes: c23626f27b09 ("ethdev: add MPLS header modification") Cc: michae...@nvidia.com Cc: sta...@dpdk.org Acked-by: Dariusz Sosnowski --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[PATCH v2 0/2] Fix modify flex item error

2024-02-22 Thread Rongwei Liu
v2: rebase. Rongwei Liu (2): app/testpmd: fix modify tag typo net/mlx5: fix modify flex item error app/test-pmd/cmdline_flow.c | 2 +- drivers/net/mlx5/mlx5_flow.c| 2 +- drivers/net/mlx5/mlx5_flow_hw.c | 6 -- 3 files changed, 6 insertions(+), 4 deletions(-) -- 2.27.0

[PATCH v2 4/4] net/nfp: support RSS flow action

2024-02-22 Thread Chaoyong He
From: Long Wu Add the corresponding logics to support the offload of RSS action. Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_flow.c | 124 ++ drivers/

[PATCH v2 3/4] net/nfp: add representor RSS configuration

2024-02-22 Thread Chaoyong He
From: Long Wu Add RSS configuration logics in representor initialization function. Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/common/nfp/nfp_common_ctrl.h| 1 + drivers/net/nfp/flower/nfp_flower.c | 12 ++-- drivers/ne

[PATCH v2 2/4] net/nfp: support MARK flow action

2024-02-22 Thread Chaoyong He
From: Long Wu Add the corresponding logics to support the offload of MARK action. Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower_cmsg.h | 16 ++ drivers/net/nfp/flower/nfp_flower_flow.c | 27

[PATCH v2 1/4] ethdev: add function to check representor port

2024-02-22 Thread Chaoyong He
From: Long Wu Add a function to check if a device is representor port, also modified the related codes for PMDs. Signed-off-by: Long Wu Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang --- doc/guides/rel_notes/release_24_03.rst | 3 +++ drivers/net/bnxt/bnxt.h| 3 --

[PATCH v2 0/4] add support of MARK and RSS flow action

2024-02-22 Thread Chaoyong He
This patch series add the support of MARK and RSS flow action for NFP PMD, also add a new function to help check if a device is representor port. --- v2: * Modify the title and description of patch series to make it more clear. * Add a new function to ethdev library, PMDs can use it to check if a

Re: [PATCH v2 00/10] patchset for bnxt

2024-02-22 Thread Ajit Khaparde
On Thu, Feb 22, 2024 at 11:48 AM Ajit Khaparde wrote: > > Apart from some fixes, this patchset adds support for > RSS based on IPV6 flow label. > This set also updates the 24.03 release notes. > > v1->v2: > - Patchset rebased against 24.03-rc1 > - Fixed up a typo in patch [8/10] Patchset merged

Re: [PATCH v2 3/3] net/ionic: add vdev support for embedded applications

2024-02-22 Thread Honnappa Nagarahalli
> On Feb 20, 2024, at 2:42 PM, Andrew Boyer wrote: > > Add support for running DPDK applications directly on AMD Pensando > embedded HW. The platform exposes the device BARs through UIO. The > UIO code in the common/ionic library walks the sysfs filesystem > to identify the relevant BARs and ma

[PATCH v3] net/af_xdp: fix resources leak when xsk configure fails

2024-02-22 Thread Yunjian Wang
In xdp_umem_configure() allocated some resources for the xsk umem, we should delete them when xsk configure fails, otherwise it will lead to resources leak. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- v3: remove unnecessary null ch

[PATCH v2 14/17] eal: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of EAL_LOG in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/eal/common/eal_trace.h | 8 1 file changed, 4 in

[PATCH v2 16/17] vhost: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/vhost/vhost_crypto.c | 21 +++-- 1 f

[PATCH v2 17/17] ip_frag: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Remove use of args... and just use __VA_ARGS__. The macros expanding the argument pack do not require args extension to remove trailing comma. Signed-off-by: Tyler Retzlaff --- lib/ip_frag/ip_frag_common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ip_frag/ip_fra

[PATCH v2 12/17] rcu: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/rcu/rte_rcu_qsbr.c | 4 ++-- lib/rcu/rte_rcu_qsbr.h

[PATCH v2 15/17] vhost: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/vhost/vhost.h | 8 1 file changed, 4 insert

[PATCH v2 13/17] stack: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/stack/stack_pvt.h | 16 1 file chan

[PATCH v2 07/17] mldev: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/mldev/rte_mldev.h | 4 ++-- 1 file changed, 2 insert

[PATCH v2 09/17] pdump: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/pdump/rte_pdump.c | 4 ++-- 1 file changed, 2 insert

[PATCH v2 11/17] rawdev: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/rawdev/rte_rawdev_pmd.h | 17 + 1 fi

[PATCH v2 10/17] power: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/power/power_common.h | 6 +++--- 1 file changed, 3 i

[PATCH v2 06/17] metrics: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/metrics/rte_metrics_telemetry.c | 12 ++-- 1

[PATCH v2 08/17] net: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/net/rte_net_crc.c | 4 ++-- 1 file changed, 2 insert

[PATCH v2 05/17] compressdev: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/compressdev/rte_compressdev_internal.h | 4 ++-- 1 f

[PATCH v2 03/17] cfgfile: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/cfgfile/rte_cfgfile.c | 5 +++-- 1 file changed, 3 i

[PATCH v2 04/17] cmdline: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Remove use of args... and just use __VA_ARGS__. The macros expanding the argument pack do not require args extension to remove trailing comma. Signed-off-by: Tyler Retzlaff --- lib/cmdline/cmdline_parse.c | 2 +- lib/cmdline/cmdline_parse_num.c | 4 ++-- 2 files changed, 3 insertions(+), 3 d

[PATCH v2 02/17] bpf: stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
Use RTE_LOG_LINE_PREFIX instead of RTE_LOG_LINE in macro expansions which allow a prefix and arguments to be inserted into the log line without the need to use the ## args variadic argument pack extension. Signed-off-by: Tyler Retzlaff --- lib/bpf/bpf_impl.h | 4 ++-- 1 file changed, 2 insertion

[PATCH v2 01/17] log: add a per line log helper with parameterized prefix

2024-02-22 Thread Tyler Retzlaff
Providing a custom prefix when logging is common for components. Lift ISO C99 compliant helper macros from mlx5_common.h and provide RTE_LOG_LINE_PREFIX macro that can expand similar to RTE_LOG_LINE with a custom prefix and argument list. Signed-off-by: Tyler Retzlaff --- lib/log/rte_log.h | 14

[PATCH v2 00/17] stop using variadic argument pack extension

2024-02-22 Thread Tyler Retzlaff
RTE_LOG_LINE cannot be augmented with a prefix format and arguments without the user of RTE_LOG_LINE using the args... and ## args compiler extension to conditionally remove trailing comma when the macro receives only a single argument. Provide a new/similar macro RTE_LOG_LINE_PREFIX that accepts

Re: [PATCH v2 2/4] config/arm: add generic V2 SoC

2024-02-22 Thread Honnappa Nagarahalli
> On Feb 22, 2024, at 1:08 AM, Thomas Monjalon wrote: > > 20/02/2024 02:45, Honnappa Nagarahalli: >> Add generic V2 CPU SoC. This will allow for compiling a binary >> that will run on any SoC that uses V2 CPU. > [...] >> +soc_v2 = { >> +'description': 'Arm Neoverse V2', >> +'implementer

RE: [PATCH v4 2/2] config/arm: use common cpu arch for cross files

2024-02-22 Thread Wathsala Wathawana Vithanage
Hi Thomas, > > [host_machine] > > system = 'linux' > > cpu_family = 'aarch64' > > -cpu = 'armv8-a' > > +cpu = 'aarch64' > > Why aarch64 here and below? Joyce is no longer with Arm, and we have not been able to figure out this patch. I think the first patch of this series makes sense. This sec

RE: [PATCH 8/8] crypto/ipsec_mb: set and use session ID

2024-02-22 Thread Wathsala Wathawana Vithanage
> From: Pablo de Lara > > When creating a session, get the session ID that defines the fixed session > parameters and store it in the private data. > When retrieving IMB_JOB's, if their internal session ID matches the one in the > private session data, these fixed session parameters do not need t

Minutes of Technical Board Meeting, 2024-February-21

2024-02-22 Thread Maxime Coquelin
# Techboard attendees - Bruce Richardson - Honnappa Nagarahalli - Jerin Jacob - Kevin Traynor - Konstantin Ananyev - Maxime Coquelin (Chair) - Morten Brørup - Thomas Monjalon # General information - Next meeting will take place on March 6th, and will be chaired by Morten Brørup. # Agenda - Upd

[PATCH v2 10/10] doc: update release notes for bnxt

2024-02-22 Thread Ajit Khaparde
Update release notes indicating support in bnxt PMD for 5760X device family. Signed-off-by: Ajit Khaparde --- doc/guides/rel_notes/release_24_03.rst | 4 1 file changed, 4 insertions(+) diff --git a/doc/guides/rel_notes/release_24_03.rst b/doc/guides/rel_notes/release_24_03.rst index 879b

[PATCH v2 09/10] net/bnxt: fix compressed Rx CQE handling

2024-02-22 Thread Ajit Khaparde
We were trying to reuse 32-byte CQE macros for compressed CQE handling. And that was causing the packet error bits to be misinterpreted. Fix it by using appropriate macros. Fixes: d58c6c077cc2 ("net/bnxt: add AVX2 Rx for compressed CQE") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_r

[PATCH v2 08/10] net/bnxt: fix compressed CQE handling

2024-02-22 Thread Ajit Khaparde
We were trying to reuse parts of 32-byte CQE handling for compressed CQE handling. And that was causing the packet errors to be misinterpreted. Fix it by using separate code for the compressed CQE handling. Fixes: 812fd99f8c4e ("net/bnxt: add SSE Rx for compressed CQE") Signed-off-by: Ajit Khapa

[PATCH v2 07/10] net/bnxt: add IPv6 flow label based RSS support

2024-02-22 Thread Ajit Khaparde
P7 hardware family can support IPv6 flow label based RSS. Check if the firmware indicates capability bit to support IPv6 flow label based RSS and parse the RSS hash types appropriately. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h| 1 + drivers/net/bnxt/bnxt_ethdev.c | 2 ++

[PATCH v2 05/10] net/bnxt: fix a null pointer dereference

2024-02-22 Thread Ajit Khaparde
From: Kalesh AP In the recent changes to rte_eth_dev_release_port() the library sets eth_dev->data to NULL at the end of the routine. This causes a NULL pointer dereference in the bnxt_rep_dev_info_get_op() and bnxt_representor_uninit() routines when it tries to validate parent dev. Add code to

[PATCH v2 06/10] net/bnxt: handle UDP GSO Tx

2024-02-22 Thread Ajit Khaparde
The UDP GSO capability is not being detected and reported correctly. This is causing UDP GSO to not happen in some cases. This patch fixes the issue. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 ++- drivers/net/bnxt/bnxt_txr.c | 3 ++- 2 files changed, 4 insertions(+), 2 d

[PATCH v2 04/10] net/bnxt: fix AGG ID computation

2024-02-22 Thread Ajit Khaparde
Fix the computation of AGG ID for P5 and P7 device families. The AGG ID for TPA completions for P7 device family is being incorrectly obtained. Fix the code to handle it. Fixes: 3b56c3ffc182 ("net/bnxt: refactor code to support P7 devices") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt

[PATCH v2 03/10] net/bnxt: increase queue size for async handling

2024-02-22 Thread Ajit Khaparde
Increase the default NQ/CQ depth for async handling. In some cases the hardware can generate a high number of async notifications. Increase the notification/completion queue size to accommodate them. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt_ring.h

[PATCH v2 02/10] net/bnxt: add dual rate module detection log

2024-02-22 Thread Ajit Khaparde
From: Kalesh AP Firmware sends an async notification to the driver when it detects a Dual rate module. Display below warning message: "Speed change not supported with dual rate transceivers on this board" Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_cpr.c

[PATCH v2 01/10] net/bnxt: extend long bd check for VXLAN GPE

2024-02-22 Thread Ajit Khaparde
Extend long Tx BD check for VXLAN GPE packets. This will allow the long BD to be selected for Tx with VXLAN GPE frames. Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_txr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_t

[PATCH v2 00/10] patchset for bnxt

2024-02-22 Thread Ajit Khaparde
Apart from some fixes, this patchset adds support for RSS based on IPV6 flow label. This set also updates the 24.03 release notes. v1->v2: - Patchset rebased against 24.03-rc1 - Fixed up a typo in patch [8/10] Ajit Khaparde (8): net/bnxt: extend long bd check for VXLAN GPE net/bnxt: increas

[RFC 5/5] crypto/ionic: add documentation

2024-02-22 Thread Andrew Boyer
Add a features list and (basic) guide for the ionic crypto PMD. Signed-off-by: Andrew Boyer --- MAINTAINERS | 7 + doc/guides/cryptodevs/features/ionic.ini | 40 doc/guides/cryptodevs/ionic.rst | 39 +++ 3 fi

[RFC 4/5] crypto/ionic: add datapath and capabilities support

2024-02-22 Thread Andrew Boyer
This defines the main datapath and reports the device capabilities to the stack. Signed-off-by: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto.h | 62 +++ drivers/crypto/ionic/ionic_crypto_caps.c | 55 ++ drivers/crypto/ionic/ionic_crypto_main.c | 417 +++- drivers/crypto/

[RFC 2/5] crypto/ionic: add device and admin command handlers

2024-02-22 Thread Andrew Boyer
This defines the handlers used for device (register-based) and admin (adminq-based) commands. Signed-off-by: Andrew Boyer --- drivers/crypto/ionic/ionic_crypto.h | 209 drivers/crypto/ionic/ionic_crypto_cmds.c | 651 +++ drivers/crypto/ionic/ionic_crypto_main.c

[RFC 3/5] crypto/ionic: add device object and vdev support

2024-02-22 Thread Andrew Boyer
This defines the main device object routines and the vdev support code. The vdev code uses the common library. Signed-off-by: Andrew Boyer --- drivers/common/ionic/ionic_common.h | 2 + drivers/common/ionic/ionic_common_uio.c | 48 +- drivers/common/ionic/version.map | 1 + dr

[RFC 1/5] crypto/ionic: introduce AMD Pensando ionic crypto driver

2024-02-22 Thread Andrew Boyer
Introduce a new crypto PMD for AMD Pensando hardware accelerators. It allows applications running directly on the AMD Pensando DSC to offload cryptographic operations to hardware cryptographic blocks. This commit adds the firmware interface definition file. Signed-off-by: Andrew Boyer --- drive

[RFC 0/5] crypto/ionic: introduce AMD Pensando ionic crypto driver

2024-02-22 Thread Andrew Boyer
This patchset introduces a new crypto PMD for AMD Pensando hardware accelerators. It allows applications running directly on the AMD Pensando DSC to offload cryptographic operations to hardware cryptographic blocks. Depends-on: series-31157 ("net/ionic, common/ionic: add vdev support") Andrew Boy

RE: [PATCH v2] app/testpmd: use Tx preparation in txonly engine

2024-02-22 Thread Konstantin Ananyev
> +CC: Ethernet API maintainers > +CC: Jerin (commented on another branch of this thread) > > > From: Konstantin Ananyev [mailto:konstantin.anan...@huawei.com] > > Sent: Sunday, 11 February 2024 16.04 > > > > > > > > TSO breaks when MSS spans more than 8 data fragments. Those > > > > > > packets

RE: [PATCH 1/2] baseband/fpga_5gnr_fec: use new barrier API

2024-02-22 Thread Chautru, Nicolas
Hi Maxime, Why would we change this here and now? Is the intent not to use new suggested semantics for new patches only? Are all DPDK drivers being changed? I am unsure we would want to change these drivers, this is kind of risk introduced by code churn that gets ecosystem unwilling to move to

[PATCH v3 2/2] net/mlx5: add cross port meter mark action sharing

2024-02-22 Thread Dariusz Sosnowski
This patch adds support for sharing meter mark actions between multiple ports of the same physical NIC. Meter objects pool, meter mark actions and meter profiles can be created only on the host port. Guest ports are allowed to use meter objects created on the host port through indirect actions. Di

[PATCH v3 1/2] net/mlx5: move meter init functions

2024-02-22 Thread Dariusz Sosnowski
Move mlx5_flow_meter_init() and mlx5_flow_meter_uinit() to module for meter operations. Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_hw.c| 203 drivers/net/mlx5/mlx5_flow_meter.c | 207 + 2 files c

[PATCH v3 0/2] net/mlx5: add cross port meter mark action sharing

2024-02-22 Thread Dariusz Sosnowski
This patchset adds support for sharing indirect METER_MARK flow actions between ports, when flow engine is configured with RTE_FLOW_PORT_FLAG_SHARE_INDIRECT. v3: - Rebased on top of v24.03-rc1. - Fixed completion polling issue with meter queues. v2: - Updated release notes. Dariusz Sosnowski (2)

[PATCH] doc: fix some typos in cryptodev overview

2024-02-22 Thread Andrew Boyer
Very minor improvements. Fixes: 2717246ecd7d ("cryptodev: replace mbuf scatter gather flag") Cc: pablo.de.lara.gua...@intel.com Cc: sta...@dpdk.org Signed-off-by: Andrew Boyer --- doc/guides/cryptodevs/overview.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/doc/gu

RE: [EXT] [PATCH v3 1/2] crypto/ipsec_mb: bump minimum IPsec Multi-buffer version

2024-02-22 Thread Akhil Goyal
> SW PMDs increment IPsec Multi-buffer version to 1.4. > A minimum IPsec Multi-buffer version of 1.4 or greater is now required. > > Signed-off-by: Sivaramakrishnan Venkat > Acked-by: Ciara Power > --- > v2: > - Removed unused macro in ipsec_mb_ops.c > - set_gcm_job() modified correc

RE: [EXT] [PATCH] examples/ipsec-secgw: fix cryptodev to SA mapping

2024-02-22 Thread Akhil Goyal
> @@ -908,7 +907,11 @@ ipsec_enqueue(ipsec_xform_fn xform_func, struct > ipsec_ctx *ipsec_ctx, > continue; > } > > - enqueue_cop(sa->cqp[ipsec_ctx->lcore_id], &priv->cop); > + if (sa->cqp[ipsec_ctx->lcore_id]) > + enqu

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-22 Thread Honnappa Nagarahalli
> On Feb 22, 2024, at 6:39 AM, Abdullah Ömer Yamaç wrote: > > As a final decision, I will add a new hash API that forces the reclaim. Is it > ok for everyone? Ack from my side > > On Thu, Feb 22, 2024 at 5:37 AM Honnappa Nagarahalli > wrote: > > > > On Feb 21, 2024, at 3:51 PM, Abdullah

[PATCH 2/2] baseband/fpga_lte_fec: use new barrier API

2024-02-22 Thread Maxime Coquelin
rte_smp_rmb() is deprecated, use the new API instead as suggested in rte_atomic header. Signed-off-by: Maxime Coquelin --- drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b

[PATCH 1/2] baseband/fpga_5gnr_fec: use new barrier API

2024-02-22 Thread Maxime Coquelin
rte_smp_rmb() is deprecated, use the new API instead as suggested in rte_atomic header. Signed-off-by: Maxime Coquelin --- drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_f

RE: [PATCH v5 0/4] add pointer compression API

2024-02-22 Thread Konstantin Ananyev
> For some reason your email is not visible to me, even though it's in the > archive. No worries. > > On 02/11/202416:32,Konstantin Ananyev konstantin.v.ananyev wrote: > > > From one side the code itself is very small and straightforward, > from > > other side - it is not clear to me what is

RE: [PATCH v2] net/af_xdp: fix resources leak when xsk configure fails

2024-02-22 Thread Loftus, Ciara
> Subject: [PATCH v2] net/af_xdp: fix resources leak when xsk configure fails > > In xdp_umem_configure() allocated some resources for the > xsk umem, we should delete them when xsk configure fails, > otherwise it will lead to resources leak. > > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP

Re: [PATCH v2] net/af_xdp: fix resources leak when xsk configure fails

2024-02-22 Thread Ferruh Yigit
On 2/22/2024 1:35 PM, Yunjian Wang wrote: > In xdp_umem_configure() allocated some resources for the > xsk umem, we should delete them when xsk configure fails, > otherwise it will lead to resources leak. > > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > Cc: sta...@dpdk.org > > Signe

Re: [PATCH 0/6] remove incorrect code for loading 16B descriptors

2024-02-22 Thread Burakov, Anatoly
On 1/23/2024 12:40 PM, Bruce Richardson wrote: Inside the AVX2 code paths, there was special case code for loading two 16-byte descriptors simultaneously, if that build-time feature was enabled. As well as not being enabled by default, these code blocks also were incorrect as there is no guarante

RE: [v9 2/3] net/af_xdp: fix multi interface support for K8s

2024-02-22 Thread Loftus, Ciara
> Subject: [v9 2/3] net/af_xdp: fix multi interface support for K8s > > The original 'use_cni' implementation, was added > to enable support for the AF_XDP PMD in a K8s env > without any escalated privileges. > However 'use_cni' used a hardcoded socket rather > than a configurable one. If a DPDK p

[PATCH v2] net/af_xdp: fix resources leak when xsk configure fails

2024-02-22 Thread Yunjian Wang
In xdp_umem_configure() allocated some resources for the xsk umem, we should delete them when xsk configure fails, otherwise it will lead to resources leak. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- v2: update code style as sugge

[PATCH v5 3/3] config/arm: allow WFE to be enabled config time

2024-02-22 Thread pbhagavatula
From: Pavan Nikhilesh Allow RTE_ARM_USE_WFE to be enabled at meson configuration time by passing it via c_args instead of modifying `config/arm/meson.build`. Example usage: meson build -Dc_args='-DRTE_ARM_USE_WFE' \ --cross-file config/arm/arm64_cn10k_linux_gcc Signed-off-by: Pavan Nik

[PATCH v5 1/3] config/arm: avoid mcpu and march conflicts

2024-02-22 Thread pbhagavatula
From: Pavan Nikhilesh The compiler options march and mtune are a subset of mcpu and will lead to conflicts if improper march is chosen for a given mcpu. To avoid conflicts, discard part number march when mcpu is available and is supported by the compiler. Example: march = armv9-a

[PATCH v5 2/3] config/arm: add support for fallback march

2024-02-22 Thread pbhagavatula
From: Pavan Nikhilesh Some ARM CPUs have specific march requirements and are not compatible with the supported march list. Add fallback march in case the mcpu and the march advertised in the part_number_config are not supported by the compiler. Example mcpu = neoverse-n2 march =

Re: [PATCH] lib/hash,lib/rcu: feature hidden key count in hash

2024-02-22 Thread Abdullah Ömer Yamaç
As a final decision, I will add a new hash API that forces the reclaim. Is it ok for everyone? On Thu, Feb 22, 2024 at 5:37 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > On Feb 21, 2024, at 3:51 PM, Abdullah Ömer Yamaç > wrote: > > > > > > > > On Wed, Feb 21, 2024 at 6:2

RE: [EXT] Re: [PATCH v4 2/3] config/arm: add support for fallback march

2024-02-22 Thread Pavan Nikhilesh Bhagavatula
> On Wed, Feb 21, 2024 at 9:20 PM wrote: > > > > From: Pavan Nikhilesh > > > > Some ARM CPUs have specific march requirements and > > are not compatible with the supported march list. > > Add fallback march in case the mcpu and the march > > advertised in the part_number_config are not supported

[24.11 PATCH v3 4/5] node: add error stats for ip4 lookup node

2024-02-22 Thread pbhagavatula
From: Pavan Nikhilesh Add error counters for ip4 LPM lookup failures in ip4_lookup node. Signed-off-by: Pavan Nikhilesh --- lib/node/ip4_lookup.c | 9 + lib/node/ip4_lookup_neon.h | 5 + lib/node/ip4_lookup_sse.h | 6 ++ lib/node/node_private.h| 8 4 files ch

[24.11 PATCH v3 5/5] node: add error stats for ip4 reassembly node

2024-02-22 Thread pbhagavatula
From: Pavan Nikhilesh Add reassembly failure error counter for ip4 reassembly node. Signed-off-by: Pavan Nikhilesh --- lib/node/ip4_reassembly.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/node/ip4_reassembly.c b/lib/node/ip4_reassembly.c index 04823cc596..ab71ef1331 10064

[24.11 PATCH v3 3/5] graph: add stats for node specific errors

2024-02-22 Thread pbhagavatula
From: Pavan Nikhilesh Add support for retrieving/printing stats for node specific errors using rte_graph_cluster_stats_get(). Signed-off-by: Pavan Nikhilesh --- lib/graph/graph_stats.c | 81 - lib/graph/rte_graph.h | 4 ++ 2 files changed, 84 insertio

[24.11 PATCH v3 2/5] graph: add node fastpath error counters

2024-02-22 Thread pbhagavatula
From: Pavan Nikhilesh Add node fastpath error counters advertised during node registration. Signed-off-by: Pavan Nikhilesh --- lib/graph/graph_populate.c | 22 +++--- lib/graph/graph_private.h | 2 ++ lib/graph/rte_graph_worker_common.h | 1 + 3 files chang

RE: [PATCH v3] common/qat: add virtual qat device (vQAT)

2024-02-22 Thread Power, Ciara
Hi Arek, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Wednesday, February 21, 2024 7:50 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Power, Ciara ; Kusztal, > ArkadiuszX > Subject: [PATCH v3] common/qat: add virtual qat device (vQAT) > > This commit adds virtual QAT devic

RE: [PATCH] net/af_xdp: fix resources leak when xsk configure fails

2024-02-22 Thread wangyunjian
> -Original Message- > From: Loftus, Ciara [mailto:ciara.lof...@intel.com] > Sent: Thursday, February 22, 2024 7:06 PM > To: Tahhan, Maryam ; wangyunjian > > Cc: dev@dpdk.org; ferruh.yi...@amd.com; sta...@dpdk.org > Subject: RE: [PATCH] net/af_xdp: fix resources leak when xsk configure fai

Re: [PATCH] net/cnxk: support Tx queue descriptor count

2024-02-22 Thread Jerin Jacob
On Wed, Jan 24, 2024 at 6:09 PM wrote: > > From: Satha Rao > > Added cnxk APIs to get used txq descriptor count. > > Signed-off-by: Satha Rao > --- > doc/guides/nics/features/cnxk.ini | 1 + Please update release notes

Re: [PATCH v8] app/testpmd : fix packets not getting flushed in heavy-weight mode API

2024-02-22 Thread kumaraparameshwaran rathinavel
On Wed, Feb 21, 2024 at 11:32 PM Ferruh Yigit wrote: > On 2/16/2024 1:56 PM, Ferruh Yigit wrote: > > On 2/16/2024 3:47 AM, Kumara Parameshwaran wrote: > >> In heavy-weight mode GRO which is based on timer, the GRO packets > >> will not be flushed in spite of timer expiry if there is no packet > >

[PATCH v4 14/14] net/cnxk: reset mbuf fields in multi-seg Tx path

2024-02-22 Thread Nithin Dabilpuram
From: Rahul Bhansali Currently in debug mode when a buffer is allocated in SW, nb_segs will have invalid values as it didn't come from driver Rx path. Hence reset mbuf next and nb_segs fields in multi-seg Tx path. Fixes: 3626d5195d49 ("net/cnxk: add multi-segment Tx for CN10K") Signed-off-by: R

[PATCH v4 13/14] common/cnxk: use SQ enable and disable API

2024-02-22 Thread Nithin Dabilpuram
Use SQ enable and disable API in TM setup to affect the state change. Signed-off-by: Nithin Dabilpuram --- drivers/common/cnxk/roc_nix_tm_ops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c ind

[PATCH v4 11/14] net/cnxk: fix check cookies for multi-seg offload

2024-02-22 Thread Nithin Dabilpuram
From: Rahul Bhansali Fix missing check cookies with multi-seg offload case Fixes: 3626d5195d49 ("net/cnxk: add multi-segment Tx for CN10K") Cc: sta...@dpdk.org Signed-off-by: Rahul Bhansali --- drivers/net/cnxk/cn10k_tx.h | 21 - 1 file changed, 20 insertions(+), 1 deletio

[PATCH v4 12/14] common/cnxk: add IO attribute to mbox structs

2024-02-22 Thread Nithin Dabilpuram
IO attribute is needed to mbox structs to avoid unaligned or pair access causing by compiler optimization. Add them to structs where it is missing. Fixes: 503b82de2cbf ("common/cnxk: add mbox request and response definitions") Fixes: ddf955d3917e ("common/cnxk: support CPT second pass") Cc: sta...

[PATCH v4 09/14] common/cnxk: update queue entries copy in RETA table

2024-02-22 Thread Nithin Dabilpuram
From: Kommula Shiva Shankar This patch updates queue entries copy in reta table based on data type Signed-off-by: Kommula Shiva Shankar --- drivers/common/cnxk/roc_nix_rss.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_rss.c b/drivers/com

  1   2   >