On 1/23/2024 12:40 PM, Bruce Richardson wrote:
Inside the AVX2 code paths, there was special case code for loading two
16-byte descriptors simultaneously, if that build-time feature was
enabled. As well as not being enabled by default, these code blocks also
were incorrect as there is no guarantee of the two descriptors being
loaded either atomically or in a defined order. If they were loaded in
an unexpected order the driver logic would break. Therefore we remove
these blocks, and do come cleanup of the following code to remove
indentation.
NOTE: I've split out the removal and subsequent cleanup into separate
patches for ease of review. These can be merged into a single patch on
merge, if so desired.
Bruce Richardson (6):
net/i40e: remove incorrect 16B descriptor read block
net/i40e: reduce code indentation
net/iavf: remove incorrect 16B descriptor read block
net/ice: remove incorrect 16B descriptor read block
net/ice: reduce code indent
net/iavf: reduce code indent
drivers/net/i40e/i40e_rxtx_vec_avx2.c | 64 ++++++++-------------
drivers/net/iavf/iavf_rxtx_vec_avx2.c | 80 ++++++++-------------------
drivers/net/ice/ice_rxtx_vec_avx2.c | 80 ++++++++-------------------
3 files changed, 72 insertions(+), 152 deletions(-)
--
2.40.1
Series-Acked-by: Anatoly Burakov <anatoly.bura...@intel.com>
--
Thanks,
Anatoly
