Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread Patrick Robb
On Fri, Dec 1, 2023 at 4:09 PM Thomas Monjalon wrote: > 01/12/2023 18:24, Patrick Robb: > > For staging branches, Based on TB voting I did add a work item to the > 2024 > > lab SOW for "on-push" staging branch testing, which we will do via these > > GitHub branches (so like, next-virtio-staging).

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread Thomas Monjalon
01/12/2023 18:24, Patrick Robb: > For staging branches, Based on TB voting I did add a work item to the 2024 > lab SOW for "on-push" staging branch testing, which we will do via these > GitHub branches (so like, next-virtio-staging). Not sure about testing staging branches for next-*. Each patch i

Re: [PATCH v8 00/21] dts: docstrings update

2023-12-01 Thread Jeremy Spewock
Hey Juraj, I looked through all the patches and left a few comments. All of the comments I left though were very minor comments about spelling/grammar on a few patches. Otherwise this all looks good to me.

Re: [PATCH v8 20/21] dts: scapy tg docstring update

2023-12-01 Thread Jeremy Spewock
On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš wrote: > Format according to the Google format and PEP257, with slight > deviations. > > Signed-off-by: Juraj Linkeš > --- > .../testbed_model/traffic_generator/scapy.py | 91 +++ > 1 file changed, 54 insertions(+), 37 deletions(-)

Re: [PATCH v8 18/21] dts: sut and tg nodes docstring update

2023-12-01 Thread Jeremy Spewock
On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš wrote: > Format according to the Google format and PEP257, with slight > deviations. > > Signed-off-by: Juraj Linkeš > --- > dts/framework/testbed_model/sut_node.py | 230 > dts/framework/testbed_model/tg_node.py | 42 +++-

Re: [PATCH v8 19/21] dts: base traffic generators docstring update

2023-12-01 Thread Jeremy Spewock
On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš wrote: > Format according to the Google format and PEP257, with slight > deviations. > > Signed-off-by: Juraj Linkeš > --- > .../traffic_generator/__init__.py | 22 - > .../capturing_traffic_generator.py| 45 +

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread Bruce Richardson
On Fri, Dec 01, 2023 at 12:24:12PM -0500, Patrick Robb wrote: >On Fri, Dec 1, 2023 at 11:36 AM Ferruh Yigit <[1]ferruh.yi...@amd.com> >wrote: > > On 12/1/2023 2:30 PM, Bruce Richardson wrote: > > On Fri, Dec 01, 2023 at 11:33:25AM +, Ferruh Yigit wrote: > >> On 12/1/2023

Re: [PATCH v8 15/21] dts: os session docstring update

2023-12-01 Thread Jeremy Spewock
On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš wrote: > Format according to the Google format and PEP257, with slight > deviations. > > Signed-off-by: Juraj Linkeš > --- > dts/framework/testbed_model/os_session.py | 272 -- > 1 file changed, 205 insertions(+), 67 deletions(-)

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread Patrick Robb
On Fri, Dec 1, 2023 at 11:36 AM Ferruh Yigit wrote: > On 12/1/2023 2:30 PM, Bruce Richardson wrote: > > On Fri, Dec 01, 2023 at 11:33:25AM +, Ferruh Yigit wrote: > >> On 12/1/2023 11:13 AM, Bruce Richardson wrote: > >>> On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote: > 3

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread Ferruh Yigit
On 12/1/2023 2:30 PM, Bruce Richardson wrote: > On Fri, Dec 01, 2023 at 11:33:25AM +, Ferruh Yigit wrote: >> On 12/1/2023 11:13 AM, Bruce Richardson wrote: >>> On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote: 30/11/2023 19:33, Patrick Robb: > On Thu, Nov 30, 2023 at 4:2

Re: [PATCH v8 00/21] dts: docstrings update

2023-12-01 Thread Yoan Picchi
On 11/23/23 15:13, Juraj Linkeš wrote: The first commit makes changes to the code. These code changes mainly change the structure of the code so that the actual API docs generation works. There are also some code changes which get reflected in the documentation, such as making functions/methods/a

Tech Board Meeting Minutes, Nov-01, 2023

2023-12-01 Thread Aaron Conole
* Attendees ** Nathan Southern ** Thomas Monjalon ** Honnappa Nagarahalli ** Kevin Traynor ** Hemant Agrawal ** Jerin Jacob Kollanukkaran ** Ben Thomas ** Patrick Robb ** Lincoln Lavoie * Agenda ** UNH Retrospective *** Patrick presented the retrospective at https://docs.google.com/document/

Re: [PATCH v4 0/6] docs: getting started guide consolidation

2023-12-01 Thread Thomas Monjalon
23/11/2023 02:26, David Young: > .../appendix/cross_compile_dpdk.rst | 37 +++ > .../appendix/dpdk_meson_build_options.rst | 57 > .../hugepages_different_architectures.rst | 56 > .../getting_started_guide/appendix/index.rst | 18 ++ > .../running_dpdk_apps_withou

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread Bruce Richardson
On Fri, Dec 01, 2023 at 11:33:25AM +, Ferruh Yigit wrote: > On 12/1/2023 11:13 AM, Bruce Richardson wrote: > > On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote: > >> 30/11/2023 19:33, Patrick Robb: > >>> On Thu, Nov 30, 2023 at 4:24 AM David Marchand > >>> wrote: > >>> > Wh

[Bug 1331] net/ice: driver logs an error level message about QinQ support

2023-12-01 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1331 Bug ID: 1331 Summary: net/ice: driver logs an error level message about QinQ support Product: DPDK Version: 23.07 Hardware: All OS: All Status: UNCONFIR

Re: [PATCH v8 1/6] ip_frag: use a dynamic logtype

2023-12-01 Thread David Marchand
Hello Konstantin, On Fri, Dec 1, 2023 at 1:17 PM Konstantin Ananyev wrote: > > Hi David, > > > On Mon, Aug 14, 2023 at 6:31 PM Stephen Hemminger > > wrote: > > > @@ -52,20 +54,20 @@ rte_ip_frag_table_create(uint32_t bucket_num, > > > uint32_t bucket_entries, > > > if (rte_is_power_of_2(

RE: [PATCH v8 1/6] ip_frag: use a dynamic logtype

2023-12-01 Thread Konstantin Ananyev
Hi David, > On Mon, Aug 14, 2023 at 6:31 PM Stephen Hemminger > wrote: > > @@ -52,20 +54,20 @@ rte_ip_frag_table_create(uint32_t bucket_num, uint32_t > > bucket_entries, > > if (rte_is_power_of_2(bucket_entries) == 0 || > > nb_entries > UINT32_MAX || nb_entries ==

20.11.10 patches review and test

2023-12-01 Thread luca . boccassi
Hi all, Here is a list of patches targeted for stable release 20.11.10. The planned date for the final release is December 12th. Please help with testing and validation of your use cases and report any issues/results with reply-all to this mail. For the final release the fixes and reported valid

0001-vhost-optimize-vhost-user-get-protocol-features

2023-12-01 Thread yuanzhiyuan0...@outlook.com
From 4cf72842a07b2270876939fd2bb2367efaad95f4 Mon Sep 17 00:00:00 2001 From: Yuan Zhiyuan Date: Fri, 1 Dec 2023 11:27:51 + Subject: [PATCH] vhost: optimize vhost user get protocol features variable features is unused in vhost_user_get_protocol_features. Signed-off-by: Yuan Zhiyuan --- lib/

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread Ferruh Yigit
On 12/1/2023 11:13 AM, Bruce Richardson wrote: > On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote: >> 30/11/2023 19:33, Patrick Robb: >>> On Thu, Nov 30, 2023 at 4:24 AM David Marchand >>> wrote: >>> What it means: - for the https://dpdk.org/git/dpdk repository, all the br

Re: [PATCH v2 2/2] app/testpmd: support set RSS hash algorithm

2023-12-01 Thread Ferruh Yigit
On 12/1/2023 8:52 AM, Jie Hai wrote: > Since API rte_eth_dev_rss_hash_update() supports setting RSS hash > algorithm, add new command to support it: > > testpmd> port config 0 rss-hash-algo symmetric_toeplitz > > Signed-off-by: Jie Hai > Reviewed-by: Huisong Li > Reviewed-by: Ferruh Yigit

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread Bruce Richardson
On Fri, Dec 01, 2023 at 09:04:10AM +0100, Thomas Monjalon wrote: > 30/11/2023 19:33, Patrick Robb: > > On Thu, Nov 30, 2023 at 4:24 AM David Marchand > > wrote: > > > > > What it means: > > > - for the https://dpdk.org/git/dpdk repository, all the branches and > > > tags are mirrored to https://g

RE: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread Koikkara Reeny, Shibin
From: Maryam Tahhan Sent: Friday, December 1, 2023 10:20 AM To: Koikkara Reeny, Shibin ; ferruh.yi...@amd.com; step...@networkplumber.org; lihuis...@huawei.com; fengcheng...@huawei.com; liuyongl...@huawei.com Cc: dev@dpdk.org Subject: Re: [v1] net/af_xdp: enable a sock path alongside use_cni

[PATCH 1/1] net/ixgbe: fix memoy leak after device init failure

2023-12-01 Thread Yunjian Wang
In ixgbe_ipsec_ctx_create() allocated memory for the 'security_ctx', we should free it when errors occur, otherwise it will lead to memory leak. Fixes: 9a0752f498d2 ("net/ixgbe: enable inline IPsec") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/ixgbe/ixgbe_ethdev.c | 17 +

[PATCH 1/1] net/iavf: fix memoy leak in error path

2023-12-01 Thread Yunjian Wang
In iavf_security_ctx_create() allocated memory for the 'security_ctx', we should free it when memory malloc for the 'iavf_security_ctx' fails, otherwise it will lead to memory leak. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang ---

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread David Marchand
On Fri, Dec 1, 2023 at 11:33 AM Thomas Monjalon wrote: > > This could be added as a new script in dpdk-ci. > > Like tools/get_mirror.py which would parse MAINTAINERS and send this > > query I mentionned above? > > > > $ tools/pw_maintainers_cli.py --type series list-trees 30419 > > dpdk-next-net >

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread Maryam Tahhan
On 01/12/2023 10:31, Maryam Tahhan wrote: Yeah - I actually will remove the `--no-mlockall --in-memory` in the v2 respin (it's a typo). I'm only interested in showing the multiple af_xdp device (vdev) arguments. I think it's useful for anyone who is looking for a quick reference on how to do it

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread Thomas Monjalon
01/12/2023 09:55, David Marchand: > On Fri, Dec 1, 2023 at 9:04 AM Thomas Monjalon wrote: > > > > 30/11/2023 19:33, Patrick Robb: > > > On Thu, Nov 30, 2023 at 4:24 AM David Marchand > > > wrote: > > > > > > > What it means: > > > > - for the https://dpdk.org/git/dpdk repository, all the branches

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread Maryam Tahhan
On 01/12/2023 10:26, David Marchand wrote: Hello, On Thu, Nov 30, 2023 at 10:13 AM Maryam Tahhan wrote: [snip] diff --git a/doc/guides/howto/af_xdp_cni.rst b/doc/guides/howto/af_xdp_cni.rst index a1a6d5b99c..a2d90c665d 100644 --- a/doc/guides/howto/af_xdp_cni.rst +++ b/doc/guides/howto/af_xdp_

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread David Marchand
Hello, On Thu, Nov 30, 2023 at 10:13 AM Maryam Tahhan wrote: [snip] > diff --git a/doc/guides/howto/af_xdp_cni.rst b/doc/guides/howto/af_xdp_cni.rst > index a1a6d5b99c..a2d90c665d 100644 > --- a/doc/guides/howto/af_xdp_cni.rst > +++ b/doc/guides/howto/af_xdp_cni.rst > @@ -38,9 +38,10 @@ The XSKMA

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread Maryam Tahhan
[snip] Prerequisites @@ -224,7 +225,6 @@ Howto run dpdk-testpmd with CNI plugin:    capabilities:   add:     - CAP_NET_RAW -       - CAP_BPF Why the CAP_BPF is removed?

RE: [PATCH 5/7] net/nfp: fix resource leak for exit of CoreNIC firmware

2023-12-01 Thread Chaoyong He
> On 12/1/2023 3:00 AM, Chaoyong He wrote: > >> On 11/30/2023 8:52 AM, Chaoyong He wrote: > >>> Fix the resource leak problem in the exit logic of CoreNIC firmware. > >>> > >>> Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file") > >>> Cc: sta...@dpdk.org > >>> > >>> Signed-off-by:

RE: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-12-01 Thread Koikkara Reeny, Shibin
Thanks for reply Maryam. My reply is below. Regards, Shibin From: Maryam Tahhan Sent: Thursday, November 30, 2023 2:17 PM To: Koikkara Reeny, Shibin ; ferruh.yi...@amd.com; step...@networkplumber.org; lihuis...@huawei.com; fengcheng...@huawei.com; liuyongl...@huawei.com Cc: dev@dpdk.org Subje

Re: [PATCH 5/7] net/nfp: fix resource leak for exit of CoreNIC firmware

2023-12-01 Thread Ferruh Yigit
On 12/1/2023 3:00 AM, Chaoyong He wrote: >> On 11/30/2023 8:52 AM, Chaoyong He wrote: >>> Fix the resource leak problem in the exit logic of CoreNIC firmware. >>> >>> Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file") >>> Cc: sta...@dpdk.org >>> >>> Signed-off-by: Chaoyong He >>>

[PATCH v2 0/2] app/testpmd: support set RSS hash algorithm

2023-12-01 Thread Jie Hai
This patch set supports setting RSS hash algorithm. -- v2: 1. fix misspelling and format. 2. fix CI compile error. 3. add reviewed-by for patch 1. -- Jie Hai (2): ethdev: add new API to get RSS hash algorithm by name app/testpmd: support set RSS hash algorithm app/test-pmd/cmdline.c

[PATCH v2 1/2] ethdev: add new API to get RSS hash algorithm by name

2023-12-01 Thread Jie Hai
This patch supports conversion from names to hash algorithm (see RTE_ETH_HASH_FUNCTION_XXX). Signed-off-by: Jie Hai Reviewed-by: Huisong Li Reviewed-by: Ferruh Yigit --- doc/guides/rel_notes/release_24_03.rst | 5 + lib/ethdev/rte_ethdev.c| 15 +++ lib/ethdev/r

[PATCH v2 2/2] app/testpmd: support set RSS hash algorithm

2023-12-01 Thread Jie Hai
Since API rte_eth_dev_rss_hash_update() supports setting RSS hash algorithm, add new command to support it: testpmd> port config 0 rss-hash-algo symmetric_toeplitz Signed-off-by: Jie Hai Reviewed-by: Huisong Li --- app/test-pmd/cmdline.c | 81 + doc/gui

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread David Marchand
On Fri, Dec 1, 2023 at 9:04 AM Thomas Monjalon wrote: > > 30/11/2023 19:33, Patrick Robb: > > On Thu, Nov 30, 2023 at 4:24 AM David Marchand > > wrote: > > > > > What it means: > > > - for the https://dpdk.org/git/dpdk repository, all the branches and > > > tags are mirrored to https://github.com

Re: [PATCH v8 1/6] ip_frag: use a dynamic logtype

2023-12-01 Thread David Marchand
On Mon, Aug 14, 2023 at 6:31 PM Stephen Hemminger wrote: > @@ -52,20 +54,20 @@ rte_ip_frag_table_create(uint32_t bucket_num, uint32_t > bucket_entries, > if (rte_is_power_of_2(bucket_entries) == 0 || > nb_entries > UINT32_MAX || nb_entries == 0 || >

Re: [PATCH] version: 24.03-rc0

2023-12-01 Thread Thomas Monjalon
30/11/2023 19:33, Patrick Robb: > On Thu, Nov 30, 2023 at 4:24 AM David Marchand > wrote: > > > What it means: > > - for the https://dpdk.org/git/dpdk repository, all the branches and > > tags are mirrored to https://github.com/DPDK/dpdk as it was done so > > far, > > - for the https://git.dpdk.o

[dpdk-dev] [PATCH] net/af_xdp: fix memzone leak in error path

2023-12-01 Thread Yunjian Wang
In xdp_umem_configure() allocated memzone for the 'umem', we should free it when xsk_umem__create() call fails, otherwise it will lead to memory zone leak. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") Cc: sta...@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/af_xdp/rte_eth_af_