RE: [PATCH 5/7] net/nfp: fix resource leak for exit of CoreNIC firmware

2023-11-30 Thread Chaoyong He
> On 11/30/2023 8:52 AM, Chaoyong He wrote: > > Fix the resource leak problem in the exit logic of CoreNIC firmware. > > > > Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file") > > Cc: sta...@dpdk.org > > > > Signed-off-by: Chaoyong He > > Reviewed-by: Long Wu > > Reviewed-by: Pe

Re: [PATCH v8 12/21] dts: interactive remote session docstring update

2023-11-30 Thread Jeremy Spewock
On Thu, Nov 23, 2023 at 10:14 AM Juraj Linkeš wrote: > Format according to the Google format and PEP257, with slight > deviations. > > Signed-off-by: Juraj Linkeš > --- > .../interactive_remote_session.py | 36 +++ > .../remote_session/interactive_shell.py | 99 +++

Re: [PATCH v7 09/21] dts: test result docstring update

2023-11-30 Thread Jeremy Spewock
On Mon, Nov 20, 2023 at 11:33 AM Juraj Linkeš wrote: > On Thu, Nov 16, 2023 at 11:47 PM Jeremy Spewock > wrote: > > > > The only comments I had on this were a few places where I think > attribute sections should be class variables instead. I tried to mark all > of the places I saw it and it coul

[PATCH v4] eal: verify mmu type for DPDK support (ppc64le)

2023-11-30 Thread David Christensen
IBM POWER systems support more than one type of memory management unit (MMU). The Power ISA 3.0 specification, which applies to P9 and later CPUs, defined a new Radix MMU which, among other things, allows an anonymous memory page mapping to be converted into a hugepage mapping at a specific addres

Re: [PATCH] version: 24.03-rc0

2023-11-30 Thread Patrick Robb
On Thu, Nov 30, 2023 at 4:24 AM David Marchand wrote: > > What it means: > - for the https://dpdk.org/git/dpdk repository, all the branches and > tags are mirrored to https://github.com/DPDK/dpdk as it was done so > far, > - for the https://git.dpdk.org/next/dpdk-next-* repositories, only > branc

[PATCH v2 2/2] net/mlx5: add random item support

2023-11-30 Thread Michael Baum
Add support for random item in HWS mode. Signed-off-by: Michael Baum --- doc/guides/nics/features/mlx5.ini | 1 + doc/guides/nics/mlx5.rst | 10 +- doc/guides/rel_notes/release_24_03.rst | 3 +++ drivers/net/mlx5/mlx5_flow_dv.c| 5 + drivers/net/mlx5/mlx

[PATCH v2 0/2] net/mlx5: add random item support

2023-11-30 Thread Michael Baum
Add support for matching random value using the "rte_flow_item_random" structure. Depends-on: series-29472 ("ethdev: add random item support") v2: - Rebase. - Move release notes to the new release file. Erez Shitrit (1): net/mlx5/hws: add support for random number match Michael Baum (1):

[PATCH v2 1/2] net/mlx5/hws: add support for random number match

2023-11-30 Thread Michael Baum
From: Erez Shitrit The HW adds a random number per each hash, this value can be used for statistic calculation over the packets, for example by setting one bit in the mask of that filed we will get half of the traffic in the flow, and so on with the rest of the mask. Signed-off-by: Erez Shitrit

[PATCH v3 2/2] app/testpmd: add random item support

2023-11-30 Thread Michael Baum
Add support for random item, usage example: pattern random spec value 0x1 mask value 0x3 / eth / end Flow rule with above pattern matching 25% of the traffic, it hits only when random value suffix is "01" and miss the others ("00", "10", "11"). Signed-off-by: Michael Baum --- app/test-

[PATCH v3 1/2] ethdev: add random item support

2023-11-30 Thread Michael Baum
Add support for a new item type "RTE_FLOW_ITEM_TYPE_RANDOM". This item enables to match on some random value as a part of flow rule. Signed-off-by: Michael Baum --- doc/guides/nics/features/default.ini | 1 + doc/guides/prog_guide/rte_flow.rst | 13 ++ doc/guides/rel_notes/release

[PATCH v3 0/2] ethdev: add random item support

2023-11-30 Thread Michael Baum
Add support for matching random value using new "rte_flow_item_random" structure. This random value is not based on the packet data/headers. Application shouldn't assume that this value is kept during the life time of the packet. v2: - Rabase. - Fix copy-paste mistake in release notes. v3: - R

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Maryam Tahhan
Hi Shibin I will add a more detailed note re CAP_BPF in the documentation on the V2. BR Maryam On 30/11/2023 13:56, Koikkara Reeny, Shibin wrote: Hi Maryam, I have one more question. Regards, Shibin -Original Message- From: Koikkara Reeny, Shibin Sent: Thursday, November 30, 2023

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Maryam Tahhan
Hi Shibin No problem. Answer below. BR Maryam On 30/11/2023 13:56, Koikkara Reeny, Shibin wrote: Hi Maryam, I have one more question. Regards, Shibin -Original Message- From: Koikkara Reeny, Shibin Sent: Thursday, November 30, 2023 12:14 PM To: Tahhan, Maryam;ferruh.yi...@amd.com;

RE: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Koikkara Reeny, Shibin
Hi Maryam, I have one more question. Regards, Shibin > -Original Message- > From: Koikkara Reeny, Shibin > Sent: Thursday, November 30, 2023 12:14 PM > To: Tahhan, Maryam ; ferruh.yi...@amd.com; > step...@networkplumber.org; lihuis...@huawei.com; > fengcheng...@huawei.com; liuyongl...@h

RE: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Koikkara Reeny, Shibin
Hi Maryam, I have replied inline. Regards, Shibin From: Maryam Tahhan Sent: Thursday, November 30, 2023 12:33 PM To: Koikkara Reeny, Shibin ; ferruh.yi...@amd.com; step...@networkplumber.org; lihuis...@huawei.com; fengcheng...@huawei.com; liuyongl...@huawei.com Cc: dev@dpdk.org Subject: Re: [

Re: [PATCH v2] eal/linux: force iova-mode va without pa available

2023-11-30 Thread Christian Ehrhardt
On Wed, Nov 29, 2023 at 10:51 PM David Christensen wrote: > > > On 11/24/23 2:09 AM, christian.ehrha...@canonical.com wrote: > > From: David Wilder > > > > When using --no-huge option physical address are not guaranteed > > to be persistent. > > > > This change effectively makes "--no-huge" the

RE: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch

2023-11-30 Thread Ankur Dwivedi
>-Original Message- >From: Thomas Monjalon >Sent: Thursday, November 30, 2023 2:11 PM >To: Ankur Dwivedi >Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran >Subject: Re: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in >checkpatch > >30/11/2023 06:56, Ankur Dwivedi: >> From: Thomas M

Re: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Maryam Tahhan
Hi Shibin Thanks for the review. Comments inline. BR Maryam On 30/11/2023 12:14, Koikkara Reeny, Shibin wrote: Hi Maryam, I have added some suggestion below. Regrads, Shibin [snip] NOTICE); #define UDS_MAX_CMD_LEN 64 #define UDS_MAX_CMD_RESP 128 #d

RE: [v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Koikkara Reeny, Shibin
Hi Maryam, I have added some suggestion below. Regrads, Shibin > -Original Message- > From: Maryam Tahhan > Sent: Thursday, November 30, 2023 9:14 AM > To: ferruh.yi...@amd.com; step...@networkplumber.org; > lihuis...@huawei.com; fengcheng...@huawei.com; > liuyongl...@huawei.com > Cc: d

RE: net/e1000: Test issues following change in max rx/tx queues

2023-11-30 Thread Morten Brørup
+TO: Qiming Yang, author of the patch. +CC: stable > From: Edwin Brossette [mailto:edwin.brosse...@6wind.com] > Sent: Thursday, 30 November 2023 12.25 > > Hello, > > We recently started to observe concerning behaviour on our continuous > integration platform following this commit, which set

Marvell DPDK 24.03 Roadmap

2023-11-30 Thread Jerin Jacob Kollanukkaran
Marvell - DPDK v24.03 Roadmap for generic changes === cryptodev = 1) Support EDDSA asymmetric crypto algorithm ethdev == 1) API to get number of free descriptors available from a Tx queue eventdev 1) Support eventdev adapter for

Re: [RESEND 2/2] app/testpmd: support set RSS hash algorithm

2023-11-30 Thread Ferruh Yigit
On 11/30/2023 10:44 AM, Jie Hai wrote: > +static void > +cmd_config_rss_hash_algo_parsed(void *parsed_result, > + __rte_unused struct cmdline *cl, > + __rte_unused void *data) > +{ > + struct cmd_config_rss_hash_algo *res = parsed_result;

Re: [RESEND 2/2] app/testpmd: support set RSS hash algorithm

2023-11-30 Thread Ferruh Yigit
On 11/30/2023 10:44 AM, Jie Hai wrote: > Since API rte_eth_dev_rss_hash_update() supports setting RSS hash > algorithm, add new command to support it: > > testpmd> port config 0 rss-hash-algo symmetric_toeplitz > > Signed-off-by: Jie Hai > Reviewed-by: Huisong Li > --- > app/test-pmd/cmdline.c

net/e1000: Test issues following change in max rx/tx queues

2023-11-30 Thread Edwin Brossette
Hello, We recently started to observe concerning behaviour on our continuous integration platform following this commit, which set the maximum amount of tx/rx queues at 2 for the e1000 pmd: net/e1000: fix queue number initialization https://git.dpdk.org/dpdk/commit/?id=c1a42d646472fd3477429bf016

Re: [RESEND 1/2] ethdev: add new API to get RSS hash algorithm by name

2023-11-30 Thread Ferruh Yigit
On 11/30/2023 10:44 AM, Jie Hai wrote: > This patch supports conversion from names to hash algorithm > (see RTE_ETH_HASH_FUNCTION_XXX). > > Signed-off-by: Jie Hai > Reviewed-by: Huisong Li > Reviewed-by: Ferruh Yigit

Re: [PATCH 5/7] net/nfp: fix resource leak for exit of CoreNIC firmware

2023-11-30 Thread Ferruh Yigit
On 11/30/2023 8:52 AM, Chaoyong He wrote: > Fix the resource leak problem in the exit logic of CoreNIC firmware. > > Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file") > Cc: sta...@dpdk.org > > Signed-off-by: Chaoyong He > Reviewed-by: Long Wu > Reviewed-by: Peng Zhang <...>

[RESEND 2/2] app/testpmd: support set RSS hash algorithm

2023-11-30 Thread Jie Hai
Since API rte_eth_dev_rss_hash_update() supports setting RSS hash algorithm, add new command to support it: testpmd> port config 0 rss-hash-algo symmetric_toeplitz Signed-off-by: Jie Hai Reviewed-by: Huisong Li --- app/test-pmd/cmdline.c | 79 + doc/gui

[RESEND 1/2] ethdev: add new API to get RSS hash algorithm by name

2023-11-30 Thread Jie Hai
This patch supports conversion from names to hash algorithm (see RTE_ETH_HASH_FUNCTION_XXX). Signed-off-by: Jie Hai Reviewed-by: Huisong Li --- doc/guides/rel_notes/release_24_03.rst | 5 + lib/ethdev/rte_ethdev.c| 15 +++ lib/ethdev/rte_ethdev.h

[RESEND 0/2] app/testpmd: support set RSS hash algorithm

2023-11-30 Thread Jie Hai
This patch set supports setting RSS hash algorithm. Jie Hai (2): ethdev: add new API to get RSS hash algorithm by name app/testpmd: support set RSS hash algorithm app/test-pmd/cmdline.c | 79 + doc/guides/rel_notes/release_24_03.rst | 5 ++ doc/

Re: [PATCH v2] lib/ethdev: modified the definition of 'NVGRE_ENCAP'

2023-11-30 Thread Ferruh Yigit
On 11/30/2023 6:22 AM, Sunyang Wu wrote: > Fix the issue of incorrect definition of 'NVGRE_ENCAP', and > modified the error comments of 'rte_flow_action_nvgre_encap'. > > Fixes: c2beb1d469d2 ("ethdev: add missing items/actions to flow object > converter") > Fixes: 3850cf0c8c37 ("ethdev: add tunnel

Re: [PATCH] version: 24.03-rc0

2023-11-30 Thread Ferruh Yigit
On 11/30/2023 9:53 AM, David Marchand wrote: > On Thu, Nov 30, 2023 at 10:32 AM David Marchand > wrote: For subtree maintainers. It should change nothing to you guys. Please rebase your trees on v24.03-rc0 and push it to dpdk.org. And then double check that the mirror happ

Re: [PATCH 0/2] app/testpmd: support set RSS hash algorithm

2023-11-30 Thread Jie Hai
On 2023/11/30 17:02, Ferruh Yigit wrote: On 11/22/2023 9:48 AM, Jie Hai wrote: This patch set supports setting RSS hash algorithm. Jie Hai (2): ethdev: add new API to get RSS hash algorithm by name app/testpmd: support set RSS hash algorithm app/test-pmd/cmdline.c

Re: [PATCH] version: 24.03-rc0

2023-11-30 Thread David Marchand
On Thu, Nov 30, 2023 at 10:32 AM David Marchand wrote: > > > For subtree maintainers. > > > > > > It should change nothing to you guys. > > > Please rebase your trees on v24.03-rc0 and push it to dpdk.org. > > > And then double check that the mirror happened (looking at git push > > > output, and

Re: [PATCH] version: 24.03-rc0

2023-11-30 Thread David Marchand
On Thu, Nov 30, 2023 at 10:30 AM Ferruh Yigit wrote: > > On 11/30/2023 9:23 AM, David Marchand wrote: > > On Wed, Nov 29, 2023 at 5:20 PM David Marchand > > wrote: > >> > >> Start a new release cycle with empty release notes. > >> Bump version and ABI minor. > >> Bump libabigail from 2.1 to 2.4 a

Re: [PATCH] version: 24.03-rc0

2023-11-30 Thread Ferruh Yigit
On 11/30/2023 9:23 AM, David Marchand wrote: > On Wed, Nov 29, 2023 at 5:20 PM David Marchand > wrote: >> >> Start a new release cycle with empty release notes. >> Bump version and ABI minor. >> Bump libabigail from 2.1 to 2.4 and enable ABI checks. >> >> Signed-off-by: David Marchand > > Applie

Re: [PATCH] version: 24.03-rc0

2023-11-30 Thread David Marchand
On Wed, Nov 29, 2023 at 5:20 PM David Marchand wrote: > > Start a new release cycle with empty release notes. > Bump version and ABI minor. > Bump libabigail from 2.1 to 2.4 and enable ABI checks. > > Signed-off-by: David Marchand Applied, thanks. Copying subtree maintainers, and ci@ mailing li

[v1] net/af_xdp: enable a sock path alongside use_cni

2023-11-30 Thread Maryam Tahhan
With the original 'use_cni' implementation, (using a hardcoded socket rather than a configurable one), if a single pod is requesting multiple net devices and these devices are from different pools, then the container attempts to mount all the netdev UDSes in the pod as /tmp/afxdp.sock. Which means

Re: [PATCH 0/2] app/testpmd: support set RSS hash algorithm

2023-11-30 Thread Ferruh Yigit
On 11/22/2023 9:48 AM, Jie Hai wrote: > This patch set supports setting RSS hash algorithm. > > Jie Hai (2): > ethdev: add new API to get RSS hash algorithm by name > app/testpmd: support set RSS hash algorithm > > app/test-pmd/cmdline.c | 79 + > doc

Re: [PATCH 24.03 v2 1/5] arg_parser: new library for command line parsing

2023-11-30 Thread Bruce Richardson
On Wed, Nov 29, 2023 at 02:14:13PM -0800, Stephen Hemminger wrote: > On Tue, 28 Nov 2023 14:07:41 + > Euan Bourke wrote: > > > +int > > +rte_parse_corelist(const char *corelist, uint16_t *cores, uint32_t > > cores_len) > > +{ > > + int32_t min = -1; > > + char *end = NULL; > > + > > +

[PATCH 7/7] net/nfp: fix resource leak for VF

2023-11-30 Thread Chaoyong He
Fix the resource leak problem in the logic of VF. Fixes: f26e82397f6d ("net/nfp: implement xstats") Cc: james.hers...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev_vf.c | 10 +++--- 1 file changed, 7

[PATCH 6/7] net/nfp: fix resource leak for exit of flower firmware

2023-11-30 Thread Chaoyong He
Fix the resource leak problem in the exit logic of flower firmware. Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/flower/nfp_flower.c | 73

[PATCH 5/7] net/nfp: fix resource leak for exit of CoreNIC firmware

2023-11-30 Thread Chaoyong He
Fix the resource leak problem in the exit logic of CoreNIC firmware. Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 94 +

[PATCH 4/7] net/nfp: fix resource leak for flower firmware

2023-11-30 Thread Chaoyong He
Fix the resource leak problem in the logic of flower firmware application. Fixes: e1124c4f8a45 ("net/nfp: add flower representor framework") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- .../net/nfp/flower/nfp_flower_representor.c | 89 +

[PATCH 3/7] net/nfp: fix resource leak for PF initialization

2023-11-30 Thread Chaoyong He
Fix the resource leak problem in the abnormal logic of PF initialize function. Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file") Fixes: 8ba461d1eecc ("net/nfp: introduce keepalive mechanism for multiple PF") Cc: peng.zh...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chaoyon

[PATCH 2/7] net/nfp: fix resource leak for CoreNIC firmware

2023-11-30 Thread Chaoyong He
Fix the resource leak problem in the logic of CoreNIC firmware application. Fixes: 646ea79ce481 ("net/nfp: move PF functions into its own file") Cc: sta...@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 17 ++---

[PATCH 1/7] net/nfp: fix resource leak for device initialization

2023-11-30 Thread Chaoyong He
Fix the resource leak problem in the abnormal logic of device initialize function. Fixes: f26e82397f6d ("net/nfp: implement xstats") Fixes: 547137405be7 ("net/nfp: initialize IPsec related content") Cc: james.hers...@corigine.com Cc: chang.m...@corigine.com Cc: sta...@dpdk.org Signed-off-by: Chao

[PATCH 0/7] fix resource leak problems

2023-11-30 Thread Chaoyong He
This patch series fix some resource leak problems in NFP PMD. Chaoyong He (7): net/nfp: fix resource leak for device initialization net/nfp: fix resource leak for CoreNIC firmware net/nfp: fix resource leak for PF initialization net/nfp: fix resource leak for flower firmware net/nfp: fix

Re: [EXT] Re: [PATCH v5 0/1] devtools: add tracepoint check in checkpatch

2023-11-30 Thread Thomas Monjalon
30/11/2023 06:56, Ankur Dwivedi: > From: Thomas Monjalon > > 28/11/2023 15:07, Ankur Dwivedi: > >> > 07/03/2023 13:05, Ankur Dwivedi: > >> >> This patch series adds a validation in checkpatch tool to check if > >> >> tracepoint is present in any new function added in ethdev, eventdev > >> >> crypt