Re: [PATCH v2] bus/pci: revise support PASID control

2023-11-16 Thread Chenbo Xia
> On Nov 15, 2023, at 01:36, Abdullah Sevincer > wrote: > > External email: Use caution opening links or attachments > > > This commit revises PASID control function to accept PASID offset to > pasid *structure* instead of taking exact register for controlling the > feature. > > PASID contr

Re: [PATCH v1] bus/pci: revise support PASID control

2023-11-16 Thread Chenbo Xia
On Nov 17, 2023, at 01:43, Chen, Mike Ximing wrote: > > External email: Use caution opening links or attachments > > >> -Original Message- >> From: Chenbo Xia >> Sent: Tuesday, November 14, 2023 8:54 PM >> To: Sevincer, Abdullah >> Cc: dev@dpdk.org; jer...@marvell.com; Chen, Mike Ximi

RE: [EXT] [PATCH v2 08/10] pdcp: replace zero length array with flex array

2023-11-16 Thread Anoob Joseph
> Zero length arrays are GNU extension. Replace with standard flex array. > > Signed-off-by: Stephen Hemminger Acked-by: Anoob Joseph

Re: [dpdk-dev] [PATCH 1/2] devtools: support skipping forbid rule check

2023-11-16 Thread Jerin Jacob
On Wed, Oct 4, 2023 at 11:56 PM wrote: > > From: Jerin Jacob > > In some case, a set of files in directory may need to skip forbid > rules check. > > Added an infrastructure to enable the same using SKIP_FILES variable. > > Signed-off-by: Jerin Jacob Ping for review > --- > devtools/check-for

Re: [dpdk-dev] [PATCH v2] doc: define qualification criteria for external library

2023-11-16 Thread Jerin Jacob
On Thu, Sep 28, 2023 at 11:10 AM wrote: > > From: Jerin Jacob > > Define qualification criteria for external library > based on a techboard meeting minutes [1] and past > learnings from mailing list discussion. > > [1] > http://mails.dpdk.org/archives/dev/2019-June/135847.html > > Signed-off-by:

Re: [PATCH v2 10/10] common/dpaxx: replace zero length array with flex array

2023-11-16 Thread Tyler Retzlaff
On Thu, Nov 16, 2023 at 08:03:22PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > --- Reviewed-by Tyler Retzlaff

Re: [PATCH v2 09/10] net/cpfl: replace zero length array with flex array

2023-11-16 Thread Tyler Retzlaff
On Thu, Nov 16, 2023 at 08:03:21PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v2 08/10] pdcp: replace zero length array with flex array

2023-11-16 Thread Tyler Retzlaff
On Thu, Nov 16, 2023 at 08:03:20PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v2 07/10] net/mlx5: replace zero length array with flex array

2023-11-16 Thread Tyler Retzlaff
On Thu, Nov 16, 2023 at 08:03:19PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v2 06/10] net/enic: replace zero length array with flex array

2023-11-16 Thread Tyler Retzlaff
On Thu, Nov 16, 2023 at 08:03:18PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > Acked-by: John Daley > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v2 05/10] net/nfp: replace zero length array with flex array

2023-11-16 Thread Tyler Retzlaff
On Thu, Nov 16, 2023 at 08:03:17PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > Acked-by: Niklas Söderlund > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v2 04/10] pipeline: replace zero length array with flex array

2023-11-16 Thread Tyler Retzlaff
On Thu, Nov 16, 2023 at 08:03:16PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v2 03/10] security: replace zero length array with flex array

2023-11-16 Thread Tyler Retzlaff
On Thu, Nov 16, 2023 at 08:03:15PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v2 02/10] cryptodev: replace zero length array with flex array

2023-11-16 Thread Tyler Retzlaff
On Thu, Nov 16, 2023 at 08:03:14PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > --- Reviewed-by: Tyler Retzlaff

Re: [PATCH v2 01/10] member: replace zero length array with flex array

2023-11-16 Thread Tyler Retzlaff
On Thu, Nov 16, 2023 at 08:03:13PM -0800, Stephen Hemminger wrote: > Zero length arrays are GNU extension. Replace with > standard flex array. > > Signed-off-by: Stephen Hemminger > --- Reviewed-by: Tyler Retzlaff

[PATCH v2 10/10] common/dpaxx: replace zero length array with flex array

2023-11-16 Thread Stephen Hemminger
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- drivers/common/dpaax/caamflib/desc/ipsec.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/dpaax/caamflib/desc/ipsec.h b/drivers/common/dpaax/caamflib/

[PATCH v2 09/10] net/cpfl: replace zero length array with flex array

2023-11-16 Thread Stephen Hemminger
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_flow_engine_fxp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c b/drivers/net/cpfl/cpfl_flow_engine_fx

[PATCH v2 08/10] pdcp: replace zero length array with flex array

2023-11-16 Thread Stephen Hemminger
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- lib/pdcp/pdcp_entity.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pdcp/pdcp_entity.h b/lib/pdcp/pdcp_entity.h index 4fc6342a5ced..f854192e98dc 100644 --- a/li

[PATCH v2 07/10] net/mlx5: replace zero length array with flex array

2023-11-16 Thread Stephen Hemminger
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- drivers/common/mlx5/mlx5_prm.h | 2 +- drivers/net/mlx5/mlx5.h| 4 ++-- drivers/net/mlx5/mlx5_flow.h | 2 +- drivers/net/mlx5/mlx5_tx.h | 2 +- 4 files changed, 5 insertions

[PATCH v2 06/10] net/enic: replace zero length array with flex array

2023-11-16 Thread Stephen Hemminger
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Acked-by: John Daley --- drivers/net/enic/base/vnic_devcmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/base/vnic_devcmd.h b/drivers/net/enic/base/

[PATCH v2 05/10] net/nfp: replace zero length array with flex array

2023-11-16 Thread Stephen Hemminger
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger Acked-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower_cmsg.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_flower_cmsg.h b/driver

[PATCH v2 04/10] pipeline: replace zero length array with flex array

2023-11-16 Thread Stephen Hemminger
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- lib/pipeline/rte_swx_pipeline_internal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/pipeline/rte_swx_pipeline_internal.h b/lib/pipeline/rte_swx_pipeline_inte

[PATCH v2 02/10] cryptodev: replace zero length array with flex array

2023-11-16 Thread Stephen Hemminger
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- lib/cryptodev/cryptodev_pmd.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/cryptodev/cryptodev_pmd.h b/lib/cryptodev/cryptodev_pmd.h index 3bb3d95c1338..0732b35

[PATCH v2 03/10] security: replace zero length array with flex array

2023-11-16 Thread Stephen Hemminger
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- lib/security/rte_security_driver.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/security/rte_security_driver.h b/lib/security/rte_security_driver.h index 62664

[PATCH v2 01/10] member: replace zero length array with flex array

2023-11-16 Thread Stephen Hemminger
Zero length arrays are GNU extension. Replace with standard flex array. Signed-off-by: Stephen Hemminger --- lib/member/rte_member_heap.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/member/rte_member_heap.h b/lib/member/rte_member_heap.h index 9c4a01aebe95..ab6319bc2d

[PATCH v2 00/10] replace zero length arrays

2023-11-16 Thread Stephen Hemminger
Zero length arrays are a GNU extension that has been superseded by flex arrays. https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html These are places found by cocci/zero_length_array.cocci v2 - rebased on 23.11-rc3 more places started using zero length array Stephen Hemminger (10): member

Re: [PATCH] app/test-pmd: fix L4 checksum with padding data

2023-11-16 Thread Stephen Hemminger
On Fri, 17 Nov 2023 00:50:16 + Ferruh Yigit wrote: > >> Hi Kaiwen, > >> > >> I am trying to understand the problem, what is the testcase that has > >> checksum error? > >> > >> Are the received mbuf data_len & pkt_len wrong? Instead of trying to fix > >> the mbuf during forwarding, can we fix

Re: [Bug 1327] [dpdk-23.11] tso/tso_tunneling: tunnel tso setting to not take effect

2023-11-16 Thread lihuisong (C)
Hi SongX, I've replied to you. Please confirm and try it again. 在 2023/11/17 10:35, bugzi...@dpdk.org 写道: Bug ID 1327 Summary [dpdk-23.11] tso/tso_tunneling: tunnel tso setting to not take effect Product DPDK Version 23.11 Hardwar

RE: [PATCH] net/txgbe: fix out of bound access

2023-11-16 Thread Jiawen Wu
On Thursday, November 16, 2023 10:07 PM, ferruh.yi...@amd.com wrote: > Reported by SuSe CI [1] by GCC [2], possibly false positive. Error: > > In function 'txgbe_host_interface_command', > inlined from 'txgbe_host_interface_command' > at ../drivers/net/txgbe/base/txgbe_mng.c:104

[Bug 1327] [dpdk-23.11] tso/tso_tunneling: tunnel tso setting to not take effect

2023-11-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1327 Bug ID: 1327 Summary: [dpdk-23.11] tso/tso_tunneling: tunnel tso setting to not take effect Product: DPDK Version: 23.11 Hardware: x86 OS: Linux Status:

Re: [PATCH] net/gve: add support for max_rx_bufsize

2023-11-16 Thread lihuisong (C)
在 2023/11/17 6:16, Joshua Washington 写道: The new max_rx_bufsize field in dev_info can be used to guide mbuf sizes chosen by DPDK programs by ensuring that DPDK programs do not waste memory by using an mbuf size too large for the maximum RX buffer size. This patch adds support for this field in

Re: [PATCH] app/testpmd: fix set Tx offload command

2023-11-16 Thread lihuisong (C)
Acked-by: Huisong Li 在 2023/11/17 9:05, fengchengwen 写道: Reviewed-by: Chengwen Feng On 2023/11/17 1:21, Ferruh Yigit wrote: In command to set Tx offload: "port config tx_offload on|off", there is a defect in "on|off" comparison, so command does opposite of what is intended. Fixed comparis

Re: [PATCH] app/test-pmd: fix L4 checksum with padding data

2023-11-16 Thread Ferruh Yigit
On 8/4/2023 9:28 AM, Kaiwen Deng wrote: > IEEE 802 packets may have a minimum size limit. The data fields > should be padded when necessary. In some cases, the padding data > is not zero. Testpmd does not trim these IP packets to the true > length of the frame, so errors will occur when calculating

Re: [PATCH] app/testpmd: fix set Tx offload command

2023-11-16 Thread fengchengwen
Reviewed-by: Chengwen Feng On 2023/11/17 1:21, Ferruh Yigit wrote: > In command to set Tx offload: > "port config tx_offload on|off", > > there is a defect in "on|off" comparison, so command does opposite of > what is intended. Fixed comparison. > > Fixes: 6280fe565b44 ("app/testpmd: allow of

Re: [PATCH] app/test-pmd: fix L4 checksum with padding data

2023-11-16 Thread Ferruh Yigit
On 11/16/2023 10:58 PM, Stephen Hemminger wrote: > On Thu, 2 Nov 2023 19:20:07 + > Ferruh Yigit wrote: > >> On 8/4/2023 9:28 AM, Kaiwen Deng wrote: >>> IEEE 802 packets may have a minimum size limit. The data fields >>> should be padded when necessary. In some cases, the padding data >>> is n

Re: [PATCH] app/test-pmd: fix L4 checksum with padding data

2023-11-16 Thread Stephen Hemminger
On Thu, 2 Nov 2023 19:20:07 + Ferruh Yigit wrote: > On 8/4/2023 9:28 AM, Kaiwen Deng wrote: > > IEEE 802 packets may have a minimum size limit. The data fields > > should be padded when necessary. In some cases, the padding data > > is not zero. Testpmd does not trim these IP packets to the t

Re: [PATCH v7 09/21] dts: test result docstring update

2023-11-16 Thread Jeremy Spewock
The only comments I had on this were a few places where I think attribute sections should be class variables instead. I tried to mark all of the places I saw it and it could be a difference where because of the way they are subclassed they might do it differently but I'm unsure. On Wed, Nov 15, 20

Re: [PATCH v7 08/21] dts: test suite docstring update

2023-11-16 Thread Jeremy Spewock
On Wed, Nov 15, 2023 at 8:12 AM Juraj Linkeš wrote: > Format according to the Google format and PEP257, with slight > deviations. > > Signed-off-by: Juraj Linkeš > --- > dts/framework/test_suite.py | 223 +++- > 1 file changed, 168 insertions(+), 55 deletions(-)

[PATCH] net/gve: add support for max_rx_bufsize

2023-11-16 Thread Joshua Washington
The new max_rx_bufsize field in dev_info can be used to guide mbuf sizes chosen by DPDK programs by ensuring that DPDK programs do not waste memory by using an mbuf size too large for the maximum RX buffer size. This patch adds support for this field in the GVE PMD. Signed-off-by: Joshua Washingto

Re: [PATCH v7 07/21] dts: dts runner and main docstring update

2023-11-16 Thread Jeremy Spewock
On Wed, Nov 15, 2023 at 8:11 AM Juraj Linkeš wrote: > Format according to the Google format and PEP257, with slight > deviations. > > Signed-off-by: Juraj Linkeš > --- > dts/framework/dts.py | 128 --- > dts/main.py | 8 ++- > 2 files changed,

DPDK Release Status Meeting 2023-11-16

2023-11-16 Thread Mcnamara, John
Release status meeting minutes 2023-11-16 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * AMD * ARM * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the current w

Re: [PATCH v7 01/21] dts: code adjustments for doc generation

2023-11-16 Thread Jeremy Spewock
On Wed, Nov 15, 2023 at 8:11 AM Juraj Linkeš wrote: > The standard Python tool for generating API documentation, Sphinx, > imports modules one-by-one when generating the documentation. This > requires code changes: > * properly guarding argument parsing in the if __name__ == '__main__' > block,

Re: [PATCH v3 0/7] dts: Port scatter suite over

2023-11-16 Thread Juraj Linkeš
On Mon, Nov 13, 2023 at 9:28 PM wrote: > > From: Jeremy Spewock > > The only thing this version changes is it fixes typos in the commit > messages so it will pass checkpatch. > > Depends-on: series-30231 ("dts: Add the ability to bind ports to drivers") > > Jeremy Spewock (7): > dts: Add scatte

Re: [PATCH v3 1/7] dts: Add scatter test suite

2023-11-16 Thread Juraj Linkeš
On Mon, Nov 13, 2023 at 9:28 PM wrote: > > From: Jeremy Spewock > > This test suite provides testing the support of scattered packets by > Poll Mode Drivers using testpmd. It incorporates 5 different test cases > which test the sending and receiving of packets with lengths that are > less than th

Re: [PATCH v3 2/7] dts: add waiting for port up in testpmd

2023-11-16 Thread Juraj Linkeš
On Mon, Nov 13, 2023 at 9:28 PM wrote: > > From: Jeremy Spewock > > Added a method within the testpmd interactive shell that polls the > status of ports and verifies that the link status on a given port is > "up." Polling will continue until either the link comes up, or the > timeout is reached.

Re: [PATCH v3 4/7] dts: allow passing parameters into interactive apps

2023-11-16 Thread Juraj Linkeš
On Mon, Nov 13, 2023 at 9:28 PM wrote: > > From: Jeremy Spewock > > Modified interactive applications to allow for the ability to pass > parameters into the app on start up. Also modified the way EAL > parameters are handled so that the trailing "--" separator is added be > default after all EAL

Re: [PATCH v3 5/7] dts: add optional packet filtering to scapy sniffer

2023-11-16 Thread Juraj Linkeš
As I'm thinking about the filtering, it's not a trivial manner. For now, I'd like to pass a class instead of multiple parameters, as that will be easier to extend if we need to add to the filter. The class could be a dataclass holding the various booleans. Then the capturing traffic generators woul

Re: [PATCH v3 6/7] dts: add pci addresses to EAL parameters

2023-11-16 Thread Juraj Linkeš
On Mon, Nov 13, 2023 at 9:28 PM wrote: > > From: Jeremy Spewock > > Added allow list to the EAL parameters created in DTS to ensure that > only the relevant PCI devices are considered when launching DPDK > applications. > > Signed-off-by: Jeremy Spewock > --- > dts/framework/testbed_model/sut_n

Re: [PATCH v3 7/7] dts: allow configuring MTU of ports

2023-11-16 Thread Juraj Linkeš
On Mon, Nov 13, 2023 at 9:28 PM wrote: > > From: Jeremy Spewock > > Adds methods in both os_session and linux session to allow for setting > MTU of port interfaces in an OS agnostic way. > > Signed-off-by: Jeremy Spewock > --- > dts/framework/remote_session/linux_session.py | 7 +++ > dts/f

Re: [PATCH] maintainers: Adding new maintainer to Nvidia mlx5

2023-11-16 Thread Thomas Monjalon
> > > > > Adding Dariusz Sosnowski as NVIDIA mlx5 maintainer. > > > > > > > > > > Signed-off-by: Maayan Kashani > > > > > > > > Welcome, Dariusz > > > > Acked-by: Viacheslav Ovsiienko > > > Acked-by: Suanming Mou > > > > Welcome Dariusz! > > > > Acked-by: Matan Azrad > > Thank you! > > Acke

RE: [PATCH v1] crypto/qat: skip SM3 HMAC on QAT when no SM3 slice exists

2023-11-16 Thread Akhil Goyal
> > Subject: [PATCH v1] crypto/qat: skip SM3 HMAC on QAT when no SM3 slice > > exists > > > > Add check to skip SM3 HMAC on QAT when no SM3 slice exists > > > > Fixes: 171c655 ("crypto/qat: add SM3 HMAC to GEN4 devices") > > Cc: arkadiuszx.kusz...@intel.com > > Cc: sta...@dpdk.org > > > > Signed-of

RE: [EXT] [PATCH v2] crypto/qat: fix gen3 legacy capabilities

2023-11-16 Thread Akhil Goyal
> When the legacy capability flag was enabled for QAT GEN3, > in the case of the last legacy capability in the list being SM3 or SM4, > when no slice is on the device, the loop continues instead of checking > if the end of the legacy capbilities list has been met. > > To fix this, the check for th

RE: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush

2023-11-16 Thread Akhil Goyal
> > > Subject: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush > > > > > > Previously it was possible to increment `processed_jobs` to a value > > > greater than requested `nb_ops`, because after flushing at most > > > `nb_ops` jobs the while loop continued, so `processed_jobs` could > >

[PATCH v8 1/3] test/dma: use unit test framework

2023-11-16 Thread Gowrishankar Muthukrishnan
Use unit test framework to execute DMA tests. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- v8: - Used local macro instead of NAME_MAX, due to compilation issue in Windows. --- app/test/test_dmadev.c | 235 + app/test/test_dmad

[PATCH v8 2/3] test/dma: test multiple vchan

2023-11-16 Thread Gowrishankar Muthukrishnan
Support API with multiple vchan test. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- app/test/test_dmadev_api.c | 63 +- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_ap

[PATCH v8 3/3] test/dma: add SG copy tests

2023-11-16 Thread Gowrishankar Muthukrishnan
Add scatter-gather copy tests. Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- app/test/test_dmadev.c | 139 ++- app/test/test_dmadev_api.c | 164 ++--- 2 files changed, 28

[PATCH v8 0/3] test/dma: add vchan reconfig and SG tests

2023-11-16 Thread Gowrishankar Muthukrishnan
This patch series reworks DMA tests to follow unit test framework followed by new vchan reconfig and SG tests. v8: - Addressed compilation issue in Windows platform. Gowrishankar Muthukrishnan (3): test/dma: use unit test framework test/dma: test multiple vchan test/dma: add SG copy tests

RE: [PATCH v1] bus/pci: revise support PASID control

2023-11-16 Thread Chen, Mike Ximing
> -Original Message- > From: Chenbo Xia > Sent: Tuesday, November 14, 2023 8:54 PM > To: Sevincer, Abdullah > Cc: dev@dpdk.org; jer...@marvell.com; Chen, Mike Ximing > ; Richardson, Bruce > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > ; Marchand, David ; > nipun.gu...@amd.com > Subject: R

Re: [PATCH v7 21/21] dts: test suites docstring update

2023-11-16 Thread Yoan Picchi
On 11/15/23 13:09, Juraj Linkeš wrote: Format according to the Google format and PEP257, with slight deviations. Signed-off-by: Juraj Linkeš --- dts/tests/TestSuite_hello_world.py | 16 + dts/tests/TestSuite_os_udp.py | 19 +++ dts/tests/TestSuite_smoke_tests.py | 53 ++

Re: [PATCH v12 02/16] baseband/acc100: refactor to segregate common code

2023-11-16 Thread David Marchand
Hello, Looking back in the mailing list archive... On Wed, Oct 12, 2022 at 8:00 PM Nicolas Chautru wrote: > +/* Helper macro for logging */ > +#define rte_acc_log(level, fmt, ...) \ > + rte_log(RTE_LOG_ ## level, RTE_LOG_NOTICE, fmt "\n", \ > + ##__VA_ARGS__) I noticed that

[PATCH] app/testpmd: fix set Tx offload command

2023-11-16 Thread Ferruh Yigit
In command to set Tx offload: "port config tx_offload on|off", there is a defect in "on|off" comparison, so command does opposite of what is intended. Fixed comparison. Fixes: 6280fe565b44 ("app/testpmd: allow offload config for all ports") Signed-off-by: Ferruh Yigit --- Cc: huangdeng...@hua

Re: [PATCH] maintainers: update for ISA-L PMD driver

2023-11-16 Thread Thomas Monjalon
16/11/2023 17:44, Pablo de Lara: > Add maintainer for ISA-L PMD, as I maintain > the ISA-L library now. > > Signed-off-by: Pablo de Lara > --- > ISA-L > M: Lee Daly > +M: Pablo de Lara > F: drivers/compress/isal/ Good to see you in such a role Pablo. I suppose Lee Daly agrees to get your he

[PATCH] maintainers: update for ISA-L PMD driver

2023-11-16 Thread Pablo de Lara
Add maintainer for ISA-L PMD, as I maintain the ISA-L library now. Signed-off-by: Pablo de Lara --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9291439421..09d447c9e0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1213,6 +1213,7 @@ F: drivers/c

[PATCH v3] net/axgbe: support TSO

2023-11-16 Thread Jesna K E
Added TSO support for axgbe PMD. Initial Implementation for the TSO feature support Currently only headers transmitted to tester receiver side Signed-off-by: Jesna K E --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_common.h | 12 drivers/net/axgbe/axgbe_dev.c

Re: [PATCH] net/txgbe: fix out of bound access

2023-11-16 Thread Luca Boccassi
On Thu, 2023-11-16 at 14:07 +, Ferruh Yigit wrote: > Reported by SuSe CI [1] by GCC [2], possibly false positive. Error: > > In function 'txgbe_host_interface_command', > inlined from 'txgbe_host_interface_command' > at ../drivers/net/txgbe/base/txgbe_mng.c:104:1, > inl

[PATCH] net/txgbe: fix out of bound access

2023-11-16 Thread Ferruh Yigit
Reported by SuSe CI [1] by GCC [2], possibly false positive. Error: In function 'txgbe_host_interface_command', inlined from 'txgbe_host_interface_command' at ../drivers/net/txgbe/base/txgbe_mng.c:104:1, inlined from 'txgbe_hic_reset' at ../drivers/net/txgbe/ba

[PATCH v7 3/3] test/dma: add SG copy tests

2023-11-16 Thread Gowrishankar Muthukrishnan
Add scatter-gather copy tests. Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- app/test/test_dmadev.c | 139 ++- app/test/test_dmadev_api.c | 164 ++--- 2 files changed, 28

[PATCH v7 2/3] test/dma: test multiple vchan

2023-11-16 Thread Gowrishankar Muthukrishnan
Support API with multiple vchan test. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- app/test/test_dmadev_api.c | 63 +- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_ap

[PATCH v7 1/3] test/dma: use unit test framework

2023-11-16 Thread Gowrishankar Muthukrishnan
Use unit test framework to execute DMA tests. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- v7: - Used string const in unit_test_cases name member to avoid compilation failure in Windows platform. --- app/test/test_dmadev.c | 234 +

[PATCH v7 0/3] test/dma: add vchan reconfig and SG tests

2023-11-16 Thread Gowrishankar Muthukrishnan
This patch series reworks DMA tests to follow unit test framework followed by new vchan reconfig and SG tests. v7: - Addressed compilation issue in Windows platform. Gowrishankar Muthukrishnan (3): test/dma: use unit test framework test/dma: test multiple vchan test/dma: add SG copy tests

RE: [PATCH 0/2] net/mlx5: fix completions processing

2023-11-16 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Gregory Etelson > Sent: Thursday, November 16, 2023 10:09 AM > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh ; Ori Kam > > Subject: [PATCH 0/2] net/mlx5: fix completions processing > > Gregory Etelson (2): > net/mlx5: fi

[PATCH] cmdline-gen: fix error when command list has empty lines

2023-11-16 Thread Robin Jarry
Fix the following error when a command list file contains empty lines: Traceback (most recent call last): File "buildtools/dpdk-cmdline-gen.py", line 202, in main() File "buildtools/dpdk-cmdline-gen.py", line 184, in main process_commands(args.infile, sys.stdout, None, args.context_na

[PATCH v6 3/3] test/dma: add SG copy tests

2023-11-16 Thread Gowrishankar Muthukrishnan
Add scatter-gather copy tests. Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- app/test/test_dmadev.c | 139 ++- app/test/test_dmadev_api.c | 164 ++--- 2 files changed, 28

[PATCH v6 2/3] test/dma: test multiple vchan

2023-11-16 Thread Gowrishankar Muthukrishnan
Support API with multiple vchan test. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- app/test/test_dmadev_api.c | 63 +- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_ap

[PATCH v6 0/3] test/dma: add vchan reconfig and SG tests

2023-11-16 Thread Gowrishankar Muthukrishnan
This patch series reworks DMA tests to follow unit test framework followed by new vchan reconfig and SG tests. v6: - fixed coding style warning (to use REGISTER_DRIVER_TEST). Gowrishankar Muthukrishnan (3): test/dma: use unit test framework test/dma: test multiple vchan test/dma: add SG co

[PATCH v6 1/3] test/dma: use unit test framework

2023-11-16 Thread Gowrishankar Muthukrishnan
Use unit test framework to execute DMA tests. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- app/test/test_dmadev.c | 234 + app/test/test_dmadev_api.c | 95 +-- 2 files changed, 192 insertions(+), 137 deletions(-) dif

[PATCH v5 3/3] test/dma: add SG copy tests

2023-11-16 Thread Gowrishankar Muthukrishnan
Add scatter-gather copy tests. Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- app/test/test_dmadev.c | 139 ++- app/test/test_dmadev_api.c | 164 ++--- 2 files changed, 28

[PATCH v5 2/3] test/dma: test multiple vchan

2023-11-16 Thread Gowrishankar Muthukrishnan
Support API with multiple vchan test. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- app/test/test_dmadev_api.c | 63 +- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_ap

[PATCH v5 1/3] test/dma: use unit test framework

2023-11-16 Thread Gowrishankar Muthukrishnan
Use unit test framework to execute DMA tests. Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Chengwen Feng --- app/test/test_dmadev.c | 236 + app/test/test_dmadev_api.c | 95 +-- 2 files changed, 193 insertions(+), 138 deletions(-) dif

[PATCH v5 0/3] test/dma: add vchan reconfig and SG tests

2023-11-16 Thread Gowrishankar Muthukrishnan
This patch series reworks DMA tests to follow unit test framework followed by new vchan reconfig and SG tests. v5: - patch rebased. Gowrishankar Muthukrishnan (3): test/dma: use unit test framework test/dma: test multiple vchan test/dma: add SG copy tests app/test/test_dmadev.c | 375

Re: [PATCH] eal: use C11 alignas instead of GCC attribute aligned

2023-11-16 Thread Mattias Rönnblom
On 2023-11-15 18:39, Tyler Retzlaff wrote: Now that we have enabled C11 replace the use of __rte_cache_aligned and __rte_aligned(n) with alignas(RTE_CACHE_LINE_SIZE) and __rte_aligned(n) respectively. Signed-off-by: Tyler Retzlaff --- lib/eal/arm/include/rte_vect.h | 4 +++- lib/eal/co

[PATCH v2] net/axgbe: support TSO

2023-11-16 Thread Jesna K E
Added TSO support for axgbe PMD. Initial Implementation for the TSO feature support Currently only headers transmitted to tester receiver side Signed-off-by: Jesna K E --- doc/guides/nics/features/axgbe.ini | 1 + drivers/net/axgbe/axgbe_common.h | 12 ++ drivers/net/axgbe/axgbe_dev.c

RE: release candidate 23.11-rc3

2023-11-16 Thread Xu, HailinX
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, November 15, 2023 6:01 AM > To: annou...@dpdk.org > Subject: release candidate 23.11-rc3 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v23.11-rc3 > > There are 129 new pat

[Bug 1326] rxtx_offload/txoffload_port: tx_offload switch is opposite to expected

2023-11-16 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1326 Bug ID: 1326 Summary: rxtx_offload/txoffload_port: tx_offload switch is opposite to expected Product: DPDK Version: 23.11 Hardware: x86 OS: Linux Status

[PATCH 2/2] net/mlx5: fix indirect list actions completions processing

2023-11-16 Thread Gregory Etelson
MLX5 PMD separates async HWS jobs completion to 2 categories: - HWS flow rule completion; - HWS indirect action completion; When processing the latter, current PMD could not differentiate between copletion to legacy indirect and indirect list actions. The patch marks async job object with indirec

[PATCH 0/2] net/mlx5: fix completions processing

2023-11-16 Thread Gregory Etelson
Gregory Etelson (2): net/mlx5: fix sync queue completion processing net/mlx5: fix indirect list actions completions processing drivers/net/mlx5/mlx5.h | 6 + drivers/net/mlx5/mlx5_flow_hw.c | 356 +--- 2 files changed, 201 insertions(+), 161 deletions(-)

[PATCH 1/2] net/mlx5: fix sync queue completion processing

2023-11-16 Thread Gregory Etelson
Indirect **SYNC** METER_MARK and CT update actions do not remove completion after WQE post. That implementation speeds up update time by avoiding HW timeout. The completion is remoted before the following WQE post. However, HWS queue updates do not reflect that behaviour. Therefore, during port des