[Bug 1316] Tech99

2023-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1316 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[Bug 1315] 2plus2four

2023-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1315 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |INVALID Statu

Question about loop unrolling in rte_ring datastructure.

2023-11-13 Thread Aditya Ambadipudi
Hello all. My name is Aditya Ambadipudi. I am not the sharpest tool in the shed. I was reading through the rte_ring datastructure. And I have two questions about the optimizations that are being made there. 1. Loop unrolling: https://github.com/DPDK/dpdk/blob/main/lib/ring/rte_ring_elem_pvt

[Bug 1314] Sportspassion

2023-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1314 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added CC||tho...@monjalon.net

[PATCH v2] net/axgbe: invoke correct API when offloads enabled

2023-11-13 Thread Jesna K E
A bug was introduced with the recent fix that when an offload feature is enabled axgbe_xmit_pkts_vec API is called rather than axgbe_xmit_pkts API.This patch fixes it. Fixes: 9963b5131af8 ("net/axgbe: support multi-process") Signed-off-by: Jesna K E --- drivers/net/axgbe/axgbe_ethdev.c | 8

[Bug 1316] Tech99

2023-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1316 Bug ID: 1316 Summary: Tech99 Product: DPDK Version: 23.03 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Component

[Bug 1315] 2plus2four

2023-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1315 Bug ID: 1315 Summary: 2plus2four Product: DPDK Version: 22.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Compo

[PATCH v2] net/axgbe: invoke correct API when offloads enabled

2023-11-13 Thread Jesna K E
A bug was introduced with the recent fix that when an offload feature is enabled axgbe_xmit_pkts_vec API is called rather than axgbe_xmit_pkts API.This patch fixes it. Fixes: 9963b5131af8 ("net/axgbe: support multi-process") Signed-off-by: Jesna K E --- drivers/net/axgbe/axgbe_ethdev.c | 10 ++

RE: [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON()

2023-11-13 Thread Morten Brørup
> From: Stephen Hemminger [mailto:step...@networkplumber.org] > Sent: Tuesday, 14 November 2023 01.22 > > On Mon, 13 Nov 2023 16:16:35 -0800 > Stephen Hemminger wrote: > > > _Static_assert(!(0 != 0), "RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN != 0"); > > Looks like a clang bug, or something about the ot

[Bug 1314] Sportspassion

2023-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1314 Bug ID: 1314 Summary: Sportspassion Product: DPDK Version: 22.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Priority: Normal Co

RE: [PATCH v2] net/gve: fix RX buffer size alignment

2023-11-13 Thread Guo, Junfeng
> -Original Message- > From: Joshua Washington > Sent: Tuesday, November 14, 2023 07:12 > To: Guo, Junfeng ; Jeroen de Borst > ; Rushil Gupta ; Joshua > Washington ; Li, Xiaoyun > Cc: dev@dpdk.org; sta...@dpdk.org; Ferruh Yigit > Subject: [PATCH v2] net/gve: fix RX buffer size alignmen

RE: [PATCH] app/test-pmd: fix L4 checksum with padding data

2023-11-13 Thread Deng, KaiwenX
> -Original Message- > From: Ferruh Yigit > Sent: Friday, November 3, 2023 12:03 PM > To: Deng, KaiwenX ; dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; Singh, Aman Deep ; > Zhang, Yuying ; Matz, Olivier > ; De Lara Guarch, Pablo > > Subject: Re: [PATCH] app/test-p

Re: [PATCH 10/21] lib/eal: replace strtok with strtok_r

2023-11-13 Thread Stephen Hemminger
On Tue, 14 Nov 2023 09:05:10 +0800 fengchengwen wrote: > Hi Stephen, > > On 2023/11/14 0:27, Stephen Hemminger wrote: > > On Mon, 13 Nov 2023 18:45:39 +0800 > > Jie Hai wrote: > > > >> Multiple threads calling the same function may cause condition > >> race issues, which often leads to abnor

Re: [PATCH 10/21] lib/eal: replace strtok with strtok_r

2023-11-13 Thread fengchengwen
Hi Stephen, On 2023/11/14 0:27, Stephen Hemminger wrote: > On Mon, 13 Nov 2023 18:45:39 +0800 > Jie Hai wrote: > >> Multiple threads calling the same function may cause condition >> race issues, which often leads to abnormal behavior and can cause >> more serious vulnerabilities such as abnormal

Re: [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON()

2023-11-13 Thread Stephen Hemminger
On Mon, 13 Nov 2023 16:16:35 -0800 Stephen Hemminger wrote: > _Static_assert(!(0 != 0), "RTE_MBUF_F_RX_IP_CKSUM_UNKNOWN != 0"); Looks like a clang bug, or something about the other compiler flags because compiling just this part is fine.

RE: [PATCH] maintainers: Adding new maintainer to Nvidia mlx5

2023-11-13 Thread Suanming Mou
Hi, > -Original Message- > From: Slava Ovsiienko > Sent: Monday, November 13, 2023 11:22 PM > To: Maayan Kashani ; dev@dpdk.org > Cc: Maayan Kashani ; Matan Azrad > ; Raslan Darawsheh ; NBU-Contact- > Thomas Monjalon (EXTERNAL) > Subject: RE: [PATCH] maintainers: Adding new maintainer to

Re: [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON()

2023-11-13 Thread Stephen Hemminger
On Mon, 13 Nov 2023 14:28:55 -0800 Tyler Retzlaff wrote: > On Mon, Nov 13, 2023 at 02:13:26PM -0800, Stephen Hemminger wrote: > > On Mon, 13 Nov 2023 09:06:04 -0800 > > Stephen Hemminger wrote: > > > > > The macro RTE_MIN has some hidden assignments to provide type > > > safety which means th

Re: [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON()

2023-11-13 Thread Stephen Hemminger
On Mon, 13 Nov 2023 14:28:55 -0800 Tyler Retzlaff wrote: > On Mon, Nov 13, 2023 at 02:13:26PM -0800, Stephen Hemminger wrote: > > On Mon, 13 Nov 2023 09:06:04 -0800 > > Stephen Hemminger wrote: > > > > > The macro RTE_MIN has some hidden assignments to provide type > > > safety which means th

[PATCH v2] net/gve: fix RX buffer size alignment

2023-11-13 Thread Joshua Washington
In GVE, both queue formats have RX buffer size alignment requirements which will not always be respected when a user specifies an mbuf size. Assuming that an mbuf size is greater than the DPDK recommended default (2048 + 128), if the buffer size is not properly aligned with what the device expects,

Re: [PATCH] net/gve: fix RX buffer size alignment

2023-11-13 Thread Joshua Washington
Hello Ferruh, But I am not clear with what is "minimum required by DPDK", since > application can provide smaller mbufs. > Also not clear why this alignment cause problem only with mbuf size > bigger than 2048 + 128 bytes. Can you please clarify? > My apologies, the statement "minimum required by

Re: [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON()

2023-11-13 Thread Tyler Retzlaff
On Mon, Nov 13, 2023 at 02:13:26PM -0800, Stephen Hemminger wrote: > On Mon, 13 Nov 2023 09:06:04 -0800 > Stephen Hemminger wrote: > > > The macro RTE_MIN has some hidden assignments to provide type > > safety which means the statement can not be fully evaluted in > > first pass of compiler. Repl

Re: [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON()

2023-11-13 Thread Stephen Hemminger
On Mon, 13 Nov 2023 09:06:04 -0800 Stephen Hemminger wrote: > The macro RTE_MIN has some hidden assignments to provide type > safety which means the statement can not be fully evaluted in > first pass of compiler. Replace RTE_MIN() with equivalent macro. > > This will cause errors from checkpatc

RE: [PATCH v5 2/2] examples/l3fwd: relax RX Offload with option

2023-11-13 Thread Konstantin Ananyev
> Now the port Rx offload mode is set to RTE_ETH_RX_OFFLOAD_CHECKSUM > by default, but some hw and/or virtual interface does not support > the offload mode presupposed, e.g., some virtio interfaces in > the cloud may only partly support RTE_ETH_RX_OFFLOAD_UDP_CKSUM/ > RTE_ETH_RX_OFFLOAD_TCP_CKSU

RE: [PATCH v5 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-13 Thread Konstantin Ananyev
> Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS > by default, but some hw and/or virtual interface does not > support the RSS and offload mode presupposed, e.g., some > virtio interfaces in the cloud don't support > RSS and the error msg may like: > > virtio_dev_configure(): RSS sup

[PATCH v3 7/7] dts: allow configuring MTU of ports

2023-11-13 Thread jspewock
From: Jeremy Spewock Adds methods in both os_session and linux session to allow for setting MTU of port interfaces in an OS agnostic way. Signed-off-by: Jeremy Spewock --- dts/framework/remote_session/linux_session.py | 7 +++ dts/framework/remote_session/os_session.py| 9 + 2

[PATCH v3 6/7] dts: add pci addresses to EAL parameters

2023-11-13 Thread jspewock
From: Jeremy Spewock Added allow list to the EAL parameters created in DTS to ensure that only the relevant PCI devices are considered when launching DPDK applications. Signed-off-by: Jeremy Spewock --- dts/framework/testbed_model/sut_node.py | 9 + 1 file changed, 9 insertions(+) dif

[PATCH v3 5/7] dts: add optional packet filtering to scapy sniffer

2023-11-13 Thread jspewock
From: Jeremy Spewock Added the options to filter out LLDP and ARP packets when sniffing for packets with scapy. This was done using BPF filters to ensure that the noise these packets provide does not interfere with test cases. Signed-off-by: Jeremy Spewock --- dts/framework/test_suite.py

[PATCH v3 4/7] dts: allow passing parameters into interactive apps

2023-11-13 Thread jspewock
From: Jeremy Spewock Modified interactive applications to allow for the ability to pass parameters into the app on start up. Also modified the way EAL parameters are handled so that the trailing "--" separator is added be default after all EAL parameters. Signed-off-by: Jeremy Spewock --- dts/

[PATCH v3 3/7] dts: add scatter to the yaml schema

2023-11-13 Thread jspewock
From: Jeremy Spewock Allow for scatter to be specified in the configuration file. Signed-off-by: Jeremy Spewock --- dts/framework/config/conf_yaml_schema.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/confi

[PATCH v3 2/7] dts: add waiting for port up in testpmd

2023-11-13 Thread jspewock
From: Jeremy Spewock Added a method within the testpmd interactive shell that polls the status of ports and verifies that the link status on a given port is "up." Polling will continue until either the link comes up, or the timeout is reached. Signed-off-by: Jeremy Spewock --- .../remote_sessi

[PATCH v3 1/7] dts: Add scatter test suite

2023-11-13 Thread jspewock
From: Jeremy Spewock This test suite provides testing the support of scattered packets by Poll Mode Drivers using testpmd. It incorporates 5 different test cases which test the sending and receiving of packets with lengths that are less than the mbuf data buffer size, the same as the mbuf data bu

[PATCH v3 0/7] dts: Port scatter suite over

2023-11-13 Thread jspewock
From: Jeremy Spewock The only thing this version changes is it fixes typos in the commit messages so it will pass checkpatch. Depends-on: series-30231 ("dts: Add the ability to bind ports to drivers") Jeremy Spewock (7): dts: Add scatter test suite dts: add waiting for port up in testpmd

RE: [PATCH v4 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-13 Thread Konstantin Ananyev
> > > Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS > > > by default, but some hw and/or virtual interface does not > > > support the RSS and offload mode presupposed, e.g., some > > > virtio interfaces in the cloud don't support > > > RSS and the error msg may like: > > > > > > virt

Re: [PATCH v2 0/3] use static_assertion for build errors

2023-11-13 Thread Tyler Retzlaff
On Mon, Nov 13, 2023 at 06:13:30PM +, Ferruh Yigit wrote: > On 11/13/2023 5:06 PM, Stephen Hemminger wrote: > > This series fixes a couple places where expressions that could not > > be evaluated as constant early in compiler passes were used. And then > > converts RTE_BUILD_BUG_ON() with stati

RE: [PATCH v2 0/3] use static_assertion for build errors

2023-11-13 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@amd.com] > Sent: Monday, 13 November 2023 19.14 > > On 11/13/2023 5:06 PM, Stephen Hemminger wrote: > > This series fixes a couple places where expressions that could not > > be evaluated as constant early in compiler passes were used. And then > > convert

Re: [PATCH v2 0/3] use static_assertion for build errors

2023-11-13 Thread Ferruh Yigit
On 11/13/2023 5:06 PM, Stephen Hemminger wrote: > This series fixes a couple places where expressions that could not > be evaluated as constant early in compiler passes were used. And then > converts RTE_BUILD_BUG_ON() with static_assert. > > Stephen Hemminger (3): > event/opdl: fix non-constant

Re: [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert

2023-11-13 Thread Tyler Retzlaff
On Mon, Nov 13, 2023 at 05:12:48PM +, Bruce Richardson wrote: > On Mon, Nov 13, 2023 at 09:06:05AM -0800, Stephen Hemminger wrote: > > Both Gcc, clang and MSVC have better way to do compile time > > assertions rather than using out of bounds array access. > > The old method would fail if -Wvla

Re: [PATCH v3 1/1] dts: bind to DPDK driver before running test suites

2023-11-13 Thread Patrick Robb
On Thu, Nov 9, 2023 at 6:17 PM wrote: > From: Jeremy Spewock > > Modifies the current process so that we bind to os_driver_for_dpdk from > the configuration file before running test suites and bind back to the > os_driver afterwards. This allows test suites to assume that the ports > are bound t

Re: [PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON()

2023-11-13 Thread Tyler Retzlaff
On Mon, Nov 13, 2023 at 09:06:04AM -0800, Stephen Hemminger wrote: > The macro RTE_MIN has some hidden assignments to provide type > safety which means the statement can not be fully evaluted in > first pass of compiler. Replace RTE_MIN() with equivalent macro. > > This will cause errors from chec

Re: [PATCH v2 1/3] event/opdl: fix non-constant compile time assertion

2023-11-13 Thread Tyler Retzlaff
On Mon, Nov 13, 2023 at 09:06:03AM -0800, Stephen Hemminger wrote: > RTE_BUILD_BUG_ON() was being used with a non-constant value. > The inline function rte_is_power_of_2() is not constant since > inline expansion happens later in the compile process. > Replace it with macro which will be constant.

Re: [PATCH v4 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-13 Thread Stephen Hemminger
On Mon, 13 Nov 2023 08:34:47 -0800 Stephen Hemminger wrote: > On Mon, 13 Nov 2023 16:02:54 + > Trevor Tao wrote: > > > Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS > > by default, but some hw and/or virtual interface does not > > support the RSS and offload mode presupposed, e.

RE: [PATCH v1] crypto/qat: skip SM3 HMAC on QAT when no SM3 slice exists

2023-11-13 Thread Power, Ciara
> -Original Message- > From: Sivaramakrishnan Venkat > Sent: Monday, November 13, 2023 4:23 PM > To: Ji, Kai > Cc: dev@dpdk.org; sta...@dpdk.org; gak...@marvell.com; Sivaramakrishnan, > VenkatX ; Kusztal, ArkadiuszX > > Subject: [PATCH v1] crypto/qat: skip SM3 HMAC on QAT when no SM3

RE: [PATCH v7 1/2] bus/pci: support PASID control

2023-11-13 Thread Sevincer, Abdullah
I have pushed another patch addressing David's comments. https://patches.dpdk.org/project/dpdk/patch/20231113172759.3529518-1-abdullah.sevin...@intel.com/

[PATCH v1] bus/pci: revise support PASID control

2023-11-13 Thread Abdullah Sevincer
This commit revises PASID control function to accept PASID offset to pasid *structure* instead of taking exact register for controlling the feature. PASID control function was introduced in earlier commit. Pls see commit 5a6878335b81 ("event/dlb2: disable PASID") and commit 60ea19609aec ("bus/pci:

[PATCH] net/mlx5: remove non constant size from type cast

2023-11-13 Thread Tyler Retzlaff
Placing a non-constant size in the subscript [size] of a type cast is causing unnecessary generation of a VLA. Remove size and just provide [] indicating the type is an array of unspecified size. Signed-off-by: Tyler Retzlaff --- drivers/net/mlx5/mlx5_rxq.c | 5 ++--- drivers/net/mlx5/mlx5_txq.c

Re: [PATCH v2 1/3] event/opdl: fix non-constant compile time assertion

2023-11-13 Thread Bruce Richardson
On Mon, Nov 13, 2023 at 09:06:03AM -0800, Stephen Hemminger wrote: > RTE_BUILD_BUG_ON() was being used with a non-constant value. > The inline function rte_is_power_of_2() is not constant since > inline expansion happens later in the compile process. > Replace it with macro which will be constant.

Re: [PATCH v2 3/3] eal: replace out of bounds VLA with static_assert

2023-11-13 Thread Bruce Richardson
On Mon, Nov 13, 2023 at 09:06:05AM -0800, Stephen Hemminger wrote: > Both Gcc, clang and MSVC have better way to do compile time > assertions rather than using out of bounds array access. > The old method would fail if -Wvla is enabled because compiler > can't determine size in that code. Also, th

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-13 Thread Tyler Retzlaff
On Mon, Nov 13, 2023 at 06:45:29PM +0800, Jie Hai wrote: > Multiple threads calling the same function may cause condition > race issues, which often leads to abnormal behavior and can cause > more serious vulnerabilities such as abnormal termination, denial > of service, and compromised data integr

[PATCH v2 3/3] eal: replace out of bounds VLA with static_assert

2023-11-13 Thread Stephen Hemminger
Both Gcc, clang and MSVC have better way to do compile time assertions rather than using out of bounds array access. The old method would fail if -Wvla is enabled because compiler can't determine size in that code. Also, the use of new _Static_assert will catch broken code that is passing non-cons

[PATCH v2 2/3] net/sfc: fix non-constant expression inr RTE_BUILD_BUG_ON()

2023-11-13 Thread Stephen Hemminger
The macro RTE_MIN has some hidden assignments to provide type safety which means the statement can not be fully evaluted in first pass of compiler. Replace RTE_MIN() with equivalent macro. This will cause errors from checkpatch about multiple evaluations of same expression in macro but it is ok in

[PATCH v2 0/3] use static_assertion for build errors

2023-11-13 Thread Stephen Hemminger
This series fixes a couple places where expressions that could not be evaluated as constant early in compiler passes were used. And then converts RTE_BUILD_BUG_ON() with static_assert. Stephen Hemminger (3): event/opdl: fix non-constant compile time assertion net/sfc: fix non-constant expressi

[PATCH v2 1/3] event/opdl: fix non-constant compile time assertion

2023-11-13 Thread Stephen Hemminger
RTE_BUILD_BUG_ON() was being used with a non-constant value. The inline function rte_is_power_of_2() is not constant since inline expansion happens later in the compile process. Replace it with macro which will be constant. Fixes: 4236ce9bf5bf ("event/opdl: add OPDL ring infrastructure library") C

Re: [PATCH v1 2/3] net/axgbe: correct API call when offload enabled

2023-11-13 Thread Ferruh Yigit
On 11/13/2023 3:23 PM, Ferruh Yigit wrote: > On 11/11/2023 4:00 PM, Jesna K E wrote: >> Fixes: 9963b5131af8 ("net/axgbe: support multi-process") >> > > Can you please add more description? > > >> Signed-off-by: Jesna K E >> --- >> drivers/net/axgbe/axgbe_ethdev.c | 10 ++ >> 1 file cha

Re: [PATCH v4 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-13 Thread Stephen Hemminger
On Mon, 13 Nov 2023 16:02:54 + Trevor Tao wrote: > Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS > by default, but some hw and/or virtual interface does not > support the RSS and offload mode presupposed, e.g., some > virtio interfaces in the cloud don't support > RSS and the erro

Re: BUILD bug hidden in SFC driver.

2023-11-13 Thread Stephen Hemminger
On Mon, 13 Nov 2023 16:04:51 +0400 (+04) Ivan Malov wrote: > diff --git a/drivers/net/sfc/sfc_ef100_tx.c b/drivers/net/sfc/sfc_ef100_tx.c > index 1b6374775f..01f37c2616 100644 > --- a/drivers/net/sfc/sfc_ef100_tx.c > +++ b/drivers/net/sfc/sfc_ef100_tx.c > @@ -563,7 +563,7 @@ sfc_ef100_tx_pkt_desc

Re: [RFC] eal: use _Static_assert() for RTE_BUILD_BUG_ON

2023-11-13 Thread Tyler Retzlaff
On Sat, Nov 11, 2023 at 06:52:26PM +0100, Morten Brørup wrote: > > From: Stephen Hemminger [mailto:step...@networkplumber.org] > > Sent: Saturday, 11 November 2023 18.22 > > > > The method of doing sizeof a bad array element was an interesting > > hack but it has a couple of problems. First, it wo

Re: [RFC] eal: use _Static_assert() for RTE_BUILD_BUG_ON

2023-11-13 Thread Tyler Retzlaff
On Sat, Nov 11, 2023 at 09:21:53AM -0800, Stephen Hemminger wrote: > The method of doing sizeof a bad array element was an interesting > hack but it has a couple of problems. First, it won't work if > VLA checking is enabled. It doesn't enforce that the expression > is constant. > > Replace that w

Re: BUILD bug hidden in SFC driver.

2023-11-13 Thread Tyler Retzlaff
On Sat, Nov 11, 2023 at 08:56:34AM -0800, Stephen Hemminger wrote: > While examining the use of VLA in DPDK, ran into a bug in sfc driver. > > If DPDK is built with -Wvla, then the RTE_BUILD_BUG_ON() macro won't work > as written. Experimenting with a better more portable version of that macro > a

[PATCH v1] crypto/qat: skip SM3 HMAC on QAT when no SM3 slice exists

2023-11-13 Thread Sivaramakrishnan Venkat
Add check to skip SM3 HMAC on QAT when no SM3 slice exists Fixes: 171c655 ("crypto/qat: add SM3 HMAC to GEN4 devices") Cc: arkadiuszx.kusz...@intel.com Cc: sta...@dpdk.org Signed-off-by: Sivaramakrishnan Venkat --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 4 +++- 1 file changed, 3 inserti

[PATCH v6 5/5] test: cleanups to pcapng test

2023-11-13 Thread Stephen Hemminger
Overhaul of the pcapng test: - promote it to be a fast test so it gets regularly run. - create null device and use i. - use UDP discard packets that are valid so that for debugging the resulting pcapng file can be looked at with wireshark. - do basic checks on resulting pcap file that l

[PATCH v6 4/5] pcapng: avoid using alloca()

2023-11-13 Thread Stephen Hemminger
The function alloca() like VLA's has problems if the caller passes a large value. Instead use a fixed size buffer (2K) which will be more than sufficient for the info related blocks in the file. Add bounds checks as well. Signed-off-by: Stephen Hemminger Acked-by: Morten Brørup --- lib/pcapng/r

[PATCH v6 3/5] pcapng: modify timestamp calculation

2023-11-13 Thread Stephen Hemminger
The computation of timestamp is best done in the part of pcapng library that is in secondary process. The secondary process is already doing a bunch of system calls which makes it not performance sensitive. This does change the rte_pcapng_copy() and rte_pcapng_write_stats() experimental API's. Sim

[PATCH v6 2/5] dumpcap: allow multiple invocations

2023-11-13 Thread Stephen Hemminger
If dumpcap is run twice with each instance pointing a different interface, it would fail because of overlap in ring a pool names. Fix by putting process id in the name. It is still not allowed to do multiple invocations on the same interface because only one callback is allowed and only one copy o

[PATCH v6 1/5] pdump: fix setting rte_errno on mp error

2023-11-13 Thread Stephen Hemminger
The response from MP server sets err_value to negative on error. The convention for rte_errno is to use a positive value on error. This makes errors like duplicate registration show up with the correct error value. Fixes: 660098d61f57 ("pdump: use generic multi-process channel") Signed-off-by: Ste

[PATCH v6 0/5] dumpcap and pcapng fixes

2023-11-13 Thread Stephen Hemminger
It fixes issues related to timestamping. The design choices are to maximize performance in the primary process; and do all the time adjustment in the secondary (dumpcap) since the dumpcap needs to system calls anyway to write the result. This patches set changes where the adjustment is calculated

[PATCH v5 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-13 Thread Trevor Tao
Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS by default, but some hw and/or virtual interface does not support the RSS and offload mode presupposed, e.g., some virtio interfaces in the cloud don't support RSS and the error msg may like: virtio_dev_configure(): RSS support requested bu

[PATCH v5 2/2] examples/l3fwd: relax RX Offload with option

2023-11-13 Thread Trevor Tao
Now the port Rx offload mode is set to RTE_ETH_RX_OFFLOAD_CHECKSUM by default, but some hw and/or virtual interface does not support the offload mode presupposed, e.g., some virtio interfaces in the cloud may only partly support RTE_ETH_RX_OFFLOAD_UDP_CKSUM/ RTE_ETH_RX_OFFLOAD_TCP_CKSUM, but not RT

[PATCH v5 0/2] example/l3fwd: relax l3fwd rx RSS/Offload if needed

2023-11-13 Thread Trevor Tao
This series try to relax l3fwd rx RSS/Offload mode requirement if they are not supported by underlying hw or virtual devices, there is an option named relax_rx_mode added to enable this option. Trevor Tao (2): examples/l3fwd: relax RSS requirement with option examples/l3fwd: relax RX Offload w

Re:RE: Re: [PATCH v3 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-13 Thread taozj888
Hi all: At 2023-11-13 21:19:14, "Konstantin Ananyev" wrote: > > >>> Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS >>> by default, but some hw and/or virtual interface does not >>> support the RSS and offload mode presupposed, e.g., some >>> virtio interfaces in the cloud don't suppor

[PATCH v4 2/2] examples/l3fwd: relax RX Offload with option

2023-11-13 Thread Trevor Tao
Now the port Rx offload mode is set to RTE_ETH_RX_OFFLOAD_CHECKSUM by default, but some hw and/or virtual interface does not support the offload mode presupposed, e.g., some virtio interfaces in the cloud may only partly support RTE_ETH_RX_OFFLOAD_UDP_CKSUM/ RTE_ETH_RX_OFFLOAD_TCP_CKSUM, but not RT

[PATCH v4 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-13 Thread Trevor Tao
Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS by default, but some hw and/or virtual interface does not support the RSS and offload mode presupposed, e.g., some virtio interfaces in the cloud don't support RSS and the error msg may like: virtio_dev_configure(): RSS support requested bu

[PATCH v4 0/2] example/l3fwd: relax l3fwd rx RSS/Offload if needed

2023-11-13 Thread Trevor Tao
This series try to relax l3fwd rx RSS/Offload mode requirement if they are not supported by underlying hw or virtual devices, there is an option named relax_rx_mode added to enable this option. Trevor Tao (2): examples/l3fwd: relax RSS requirement with option examples/l3fwd: relax RX Offload w

Re: [PATCH v1 1/1] ml/cnxk: fix fast-path synchronization

2023-11-13 Thread Jerin Jacob
On Mon, Nov 13, 2023 at 11:01 AM Srikanth Yalavarthi wrote: > > Segfaults are reported with TVM/LLVM models as NULL value > is read by dequeue thread for the op handle. This is due > synchronization issue between enqueue and dequeue threads. > > This fix ensures the op handle written to internal r

RE: [PATCH v7 1/2] bus/pci: support PASID control

2023-11-13 Thread Sevincer, Abdullah
>+Ok, that is indeed an issue. >+I found some patches exposing this capability with vfio-pci but I am not sure >what is the latest work on the topic. That's right, some kernels may expose the capability some not. We realized it when Bruce reported my earlier patch with the api rte_pci_find_ext_

Re: [PATCH v7 00/25] Promote 22.11 and older API's to stable

2023-11-13 Thread David Marchand
On Tue, Oct 24, 2023 at 4:54 AM Stephen Hemminger wrote: > > Since 23.11 is an LTS release it is time to remove the experimental > bandaid off many API's. There are about 890 API's marked with experimental > on current main branch. This addresses the easy to remove ones and > gets it down to about

Re: [PATCH] graph: mark API's as stable

2023-11-13 Thread David Marchand
On Tue, Aug 15, 2023 at 3:46 AM Yan, Zhirun wrote: > > On Thu, Aug 10, 2023 at 11:35 PM Stephen Hemminger > > wrote: > > > > > > The graph library has been marked experimental since initial release > > > in 2020. Time to take the training wheels off. > > > > > > Signed-off-by: Stephen Hemminger

Re: [PATCH v1 2/3] net/axgbe: correct API call when offload enabled

2023-11-13 Thread Ferruh Yigit
On 11/11/2023 4:00 PM, Jesna K E wrote: > Fixes: 9963b5131af8 ("net/axgbe: support multi-process") > Can you please add more description? > Signed-off-by: Jesna K E > --- > drivers/net/axgbe/axgbe_ethdev.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/dr

RE: [PATCH] maintainers: Adding new maintainer to Nvidia mlx5

2023-11-13 Thread Slava Ovsiienko
> -Original Message- > From: Maayan Kashani > Sent: Monday, November 13, 2023 4:55 PM > To: dev@dpdk.org > Cc: Maayan Kashani ; Matan Azrad > ; Raslan Darawsheh ; NBU- > Contact-Thomas Monjalon (EXTERNAL) > Subject: [PATCH] maintainers: Adding new maintainer to Nvidia mlx5 > > Adding Dar

[Bug 1313] Build errors with clang 17.0.3 and ASan

2023-11-13 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1313 Bug ID: 1313 Summary: Build errors with clang 17.0.3 and ASan Product: DPDK Version: 23.11 Hardware: All OS: All Status: UNCONFIRMED Severity: normal Pr

Re: [PATCH v1 1/3] net/axgbe: packet size doesn't exceed the configured MTU

2023-11-13 Thread Ferruh Yigit
On 11/11/2023 4:00 PM, Jesna K E wrote: > Signed-off-by: Jesna K E > Hi Jesna, Description is missing, making it hard to understand the problem and motivation of the change. > --- > drivers/net/axgbe/axgbe_ethdev.c | 6 -- > drivers/net/axgbe/axgbe_rxtx.c | 20 ++-- > 2

[PATCH] app/test: don't count skipped tests as executed

2023-11-13 Thread Bruce Richardson
The logic around skipped tests is a little confusing in the unit test runner. * Any explicitly disabled tests are counted as skipped but not executed. * Any tests that return TEST_SKIPPED are counted as both skipped and executed, using the same statistics counters. This makes the stats very st

[PATCH] maintainers: Adding new maintainer to Nvidia mlx5

2023-11-13 Thread Maayan Kashani
Adding Dariusz Sosnowski as NVIDIA mlx5 maintainer. Signed-off-by: Maayan Kashani --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 80e071d13e..c9fccc97b6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -867,10 +867,11 @@ F: doc/g

RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain

2023-11-13 Thread Suanming Mou
Hi, > -Original Message- > From: Bing Zhao > Sent: Monday, November 13, 2023 9:51 PM > To: Suanming Mou ; Matan Azrad > ; Slava Ovsiienko ; Raslan > Darawsheh ; Ori Kam > Cc: dev@dpdk.org; Dariusz Sosnowski ; > sta...@dpdk.org > Subject: RE: [PATCH] net/mlx5: fix the LACP redirection in

RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain

2023-11-13 Thread Bing Zhao
Hi Suanming, My answers are inline. > -Original Message- > From: Suanming Mou > Sent: Monday, November 13, 2023 9:14 PM > To: Bing Zhao ; Matan Azrad ; Slava > Ovsiienko ; Raslan Darawsheh > ; Ori Kam > Cc: dev@dpdk.org; Dariusz Sosnowski ; > sta...@dpdk.org > Subject: RE: [PATCH] net/m

Re: [virtio] Invitation to comment on Virtual I/O Device (VIRTIO) Version 1.3 - ends December 8th

2023-11-13 Thread Cornelia Huck
It seems that the original mail did not make it to some of the mailing lists it was intended to go to, possibly due to the html part of the original mail. Therefore, I'm trying again, this time with plain text only. Apologies in advance for any duplicates. On Wed, Nov 08 2023, Paul Knight wrote:

RE: Re: [PATCH v3 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-13 Thread Konstantin Ananyev
>> Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS >> by default, but some hw and/or virtual interface does not >> support the RSS and offload mode presupposed, e.g., some >> virtio interfaces in the cloud don't support >> RSS and the error msg may like: >> >> virtio_dev_configure():

[PATCH v3] crypto/openssl: fix asym memory leaks

2023-11-13 Thread Ciara Power
Numerous memory leaks were detected by ASAN in the OpenSSL PMD asymmetric code path. These are now fixed to free all variables allocated by OpenSSL functions such as BN_bin2bn and OSSL_PARAM_BLD_new. Some need to exist until the op is processed, for example the BIGNUMs associated with DSA. The po

RE: [PATCH] net/mlx5: fix the LACP redirection in Rx domain

2023-11-13 Thread Suanming Mou
Hi, One small comment, v2 is needed. > -Original Message- > From: Bing Zhao > Sent: Monday, November 13, 2023 8:42 PM > To: Matan Azrad ; Slava Ovsiienko > ; Raslan Darawsheh ; Suanming > Mou ; Ori Kam > Cc: dev@dpdk.org; Dariusz Sosnowski ; > sta...@dpdk.org > Subject: [PATCH] net/mlx5

Re: [PATCH v1] doc: support IPsec Multi-buffer lib v1.5

2023-11-13 Thread Thomas Monjalon
13/11/2023 10:13, Akhil Goyal: > > Hi Venkat, > > > > > Subject: [PATCH v1] doc: support IPsec Multi-buffer lib v1.5 > > > > > > Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G and > > > CHACHA20_POLY1305 PMD documentation guides with information about > > > the latest Intel IPsec Multi-buffer

[PATCH v2] crypto/openssl: fix asym memory leaks

2023-11-13 Thread Ciara Power
Numerous memory leaks were detected by ASAN in the OpenSSL PMD asymmetric code path. These are now fixed to free all variables allocated by OpenSSL functions such as BN_bin2bn and OSSL_PARAM_BLD_new. Some need to exist until the op is processed, for example the BIGNUMs associated with DSA. The po

[PATCH v4 3/3] test/dma: add SG copy tests

2023-11-13 Thread Gowrishankar Muthukrishnan
Add scatter-gather copy tests. Signed-off-by: Vidya Sagar Velumuri Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_dmadev.c | 139 ++- app/test/test_dmadev_api.c | 164 ++--- 2 files changed, 289 insertions(+), 14 delet

[PATCH v4 2/3] test/dma: test multiple vchan

2023-11-13 Thread Gowrishankar Muthukrishnan
Support API with multiple vchan test. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_dmadev_api.c | 63 +- 1 file changed, 55 insertions(+), 8 deletions(-) diff --git a/app/test/test_dmadev_api.c b/app/test/test_dmadev_api.c index 73d4db825a..2b8

[PATCH v4 1/3] test/dma: use unit test framework

2023-11-13 Thread Gowrishankar Muthukrishnan
Use unit test framework to execute DMA tests. Signed-off-by: Gowrishankar Muthukrishnan --- app/test/test_dmadev.c | 235 + app/test/test_dmadev_api.c | 95 +-- 2 files changed, 193 insertions(+), 137 deletions(-) diff --git a/app/test/test_d

[PATCH v4 0/3] test/dma: add vchan reconfig and SG tests

2023-11-13 Thread Gowrishankar Muthukrishnan
This patch series reworks DMA tests to follow unit test framework followed by new vchan reconfig and SG tests. v4: - Suggestions from Fengchenwen addressed. Gowrishankar Muthukrishnan (3): test/dma: use unit test framework test/dma: test multiple vchan test/dma: add SG copy tests app/tes

[PATCH] net/mlx5: fix the LACP redirection in Rx domain

2023-11-13 Thread Bing Zhao
When the "lacp_by_user" is not set from the application in bond mode, the LACP traffic should be handled by the kernel driver by default. This commit adds the missing support in the template API when "dv_flow_en=2". The behavior will be the same as that in the DV mode with "dv_flow_en=1". The LACP

RE: Re: [PATCH v3 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-13 Thread Morten Brørup
From: taozj888 [mailto:taozj...@163.com] Sent: Monday, 13 November 2023 12.47 At 2023-11-13 07:33:49, "Stephen Hemminger" wrote: >On Sun, 12 Nov 2023 07:16:10 + >Trevor Tao wrote: > >> Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS >> by default, but some hw and/or virtual in

Re: BUILD bug hidden in SFC driver.

2023-11-13 Thread Ivan Malov
Hi Stephen, On Sat, 11 Nov 2023, Stephen Hemminger wrote: While examining the use of VLA in DPDK, ran into a bug in sfc driver. If DPDK is built with -Wvla, then the RTE_BUILD_BUG_ON() macro won't work as written. Experimenting with a better more portable version of that macro as: #def

Re:Re: [PATCH v3 1/2] examples/l3fwd: relax RSS requirement with option

2023-11-13 Thread taozj888
At 2023-11-13 07:33:49, "Stephen Hemminger" wrote: >On Sun, 12 Nov 2023 07:16:10 + >Trevor Tao wrote: > >> Now the port Rx mq_mode had been set to RTE_ETH_MQ_RX_RSS >> by default, but some hw and/or virtual interface does not >> support the RSS and offload mode presupposed, e.g., some >> virt

RE: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush

2023-11-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: Cornu, Marcel D > Sent: Monday, November 13, 2023 11:13 AM > To: Karas, Krzysztof ; Ji, Kai ; > De > Lara Guarch, Pablo ; Power, Ciara > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v2] crypto/ipsec_mb: do not dequeue ops after flush > > > >

Re: [PATCH 00/21] replace strtok with strtok_r

2023-11-13 Thread fengchengwen
Hi Jie, Good fix There are two minor I think need to modify: 1. The [PATCH 13/21] lib/telemetry should be lib/security 2. All commits should add Cc because it's potential bug. The other LGTM, with above fixed Series-acked-by: Chengwen Feng Thanks Chengwen On 2023/11/13 18:45, Jie Hai wrote: >

  1   2   >