[PATCH] net/ice: fix DCF port statistics not cleared

2023-10-30 Thread Zhichao Zeng
As the kernel driver does not reset the statistics after exiting testpmd, the previous statistics being retained the next time testpmd is started. Call 'ice_dcf_stats_reset' during the initialization of the DCF in order to clear any statistics that may exist from the last use of the DCF and to avo

[PATCH v2] test/security: fix buffer leaks in error path

2023-10-30 Thread Akhil Goyal
In case of failure of a test in macsec autotest, the buffers were not getting cleaned. Added appropriate code to clean the buffers. Fixes: 993ea577a006 ("test/security: add inline MACsec cases") Cc: sta...@dpdk.org Signed-off-by: Akhil Goyal --- - Used rte_pktmbuf_free_bulk as suggested by Steph

[Bug 936] DPDK init for i40e pmd fails (PF/VF API version mismatch)

2023-10-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=936 dengkaiwen (kaiwenx.d...@intel.com) changed: What|Removed |Added Resolution|--- |INVALID Status|U

Re: [PATCH v3 0/3] introduce maximum Rx buffer size

2023-10-30 Thread lihuisong (C)
在 2023/10/31 2:48, Stephen Hemminger 写道: On Mon, 30 Oct 2023 09:25:34 +0800 "lihuisong (C)" wrote: The "min_rx_bufsize" in struct rte_eth_dev_info stands for the minimum Rx buffer size supported by hardware. Actually, some engines also have the maximum Rx buffer specification, like, hns3.

[Bug 366] i40e PMD returns 0 for secondary invoking rx_burst on queue 0, when Primary dies

2023-10-30 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=366 dengkaiwen (kaiwenx.d...@intel.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED CC|

Re: [PATCH] net/netvsc: add support for mtu_set

2023-10-30 Thread Rahul Gupta

Re: [PATCH] ipsec: use sym_session_opaque_data for RTE_SECURITY_TYPE_CPU_CRYPTO

2023-10-30 Thread Konstantin Ananyev
ipsec related processing in dpdk makes use of the crypto.ses opaque data pointer. This patch updates rte_ipsec_session_prepare to set ss->crypto.ses in the RTE_SECURITY_TYPE_CPU_CRYPTO case. Hmm.. not sure why we need to do that for CPU_CRYPTO? As I remember CPU_CRYPTO is synchronous operati

Re: [PATCH v1] event/dlb2: add support for disabling PASID

2023-10-30 Thread Stephen Hemminger
On Wed, 7 Jun 2023 16:00:50 -0500 Abdullah Sevincer wrote: > From: Abdullah Sevincer > To: dev@dpdk.org > Cc: jer...@marvell.com, mike.ximing.c...@intel.com, Abdullah Sevincer > > Subject: [PATCH v1] event/dlb2: add support for disabling PASID > Date: Wed, 7 Jun 2023 16:00:50 -0500 > X-Mail

[PATCH v7] devtools: add script to check for non inclusive naming

2023-10-30 Thread Stephen Hemminger
Script to find words that should not be used. Really just a wrapper around git grep command. By default it prints matches but can also display counts. Uses the word lists from Inclusive Naming Initiative see https://inclusivenaming.org/word-lists/ Note: the list has extra comma at end of list of

[PATCH v6] devtools: add script to check for non inclusive naming

2023-10-30 Thread Stephen Hemminger
Script to find words that should not be used. Really just a wrapper around git grep command. By default it prints matches. Uses the word lists from Inclusive Naming Initiative see https://inclusivenaming.org/word-lists/ Note: the list has extra comma at end of list of elements which is not valid

[PATCH v5] devtools: add script to check for non inclusive naming

2023-10-30 Thread Stephen Hemminger
Script to find words that should not be used. Really just a wrapper around git grep command. By default it prints matches. Uses the word lists from Inclusive Naming Initiative see https://inclusivenaming.org/word-lists/ Note: the list has extra comma at end of list of elements which is not valid

[PATCH v4] devtools: add script to check for non inclusive naming

2023-10-30 Thread Stephen Hemminger
Script to find words that should not be used. Really just a wrapper around git grep command. By default it prints matches. Uses the word lists from Inclusive Naming Initiative see https://inclusivenaming.org/word-lists/ Note: the list has extra comma at end of list of elements which is not valid

[PATCH v3] event/dlb2: fix disable PASID for kernel 6.2

2023-10-30 Thread Abdullah Sevincer
vfio-pci driver in Linux kernel 6.2 enables PASID by default. In DLB hardware, enabling PASID puts DLB in SIOV mode. This breaks DLB PF-PMD mode. For DLB PF-PMD mode to function properly PASID needs to be disabled for kernel 6.2. In this commit this issue is addressed and PASID is disabled by writ

Re: memif thread race condition on memif.disconnect()

2023-10-30 Thread Stephen Hemminger
On Wed, 11 Oct 2023 19:57:56 + "Bly, Mike" wrote: > Hello, > > We have run into a timing issue between threads when using the memif > interface type and need some guidance. > > Our application has a DPDK based process operating (among other > things) a memif server interface. The problem is

RE: [PATCH v1 4/4] crypto/cnxk: add ECDH support

2023-10-30 Thread Akhil Goyal
> Subject: [PATCH v1 4/4] crypto/cnxk: add ECDH support > > Add ECDH support in CNXK PMD. > > Signed-off-by: Gowrishankar Muthukrishnan Added release notes while applying.

RE: [PATCH v1 1/4] test/cryptodev: add ECDH tests

2023-10-30 Thread Akhil Goyal
> Subject: [PATCH v1 1/4] test/cryptodev: add ECDH tests > > Add ECDH tests. > > Signed-off-by: Gowrishankar Muthukrishnan > --- Please rebase this patch. Applied the PMD patches of this series on dpdk-next-crypto. Send the test app patch again after rebasing on next-crypto. Thanks.

Re: [PATCH v3 0/3] introduce maximum Rx buffer size

2023-10-30 Thread Stephen Hemminger
On Mon, 30 Oct 2023 09:25:34 +0800 "lihuisong (C)" wrote: > > > >> The "min_rx_bufsize" in struct rte_eth_dev_info stands for the > >> minimum Rx buffer size supported by hardware. Actually, some > >> engines also have the maximum Rx buffer specification, like, hns3. > >> > >> If mbuf data room

[PATCH] net/mlx5: reuse reformat and modify header actions in a table

2023-10-30 Thread Gregory Etelson
If application defined several actions templates with non-shared reformat or modify headers actions AND used these templates to create a table, HWS could share reformat or modify headers resources, instead of creating a resource for each action template. The patch activates HWS code in a way that

RE: [PATCH 00/13] net/mlx5: support more REG C registers

2023-10-30 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Monday, October 30, 2023 10:38 AM > To: Gregory Etelson ; dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh > Subject: RE: [PATCH 00/13] net/mlx5: support more REG C registers > > Hi, > > > -Original Messa

RE: [PATCH v2 2/2] net/mlx5: support new RSS symmetric hash function

2023-10-30 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Xueming Li > Sent: Sunday, August 27, 2023 11:18 AM > To: Ori Kam > Cc: Xueming(Steven) Li ; dev@dpdk.org; > fengcheng...@huawei.com; Ivan Malov > Subject: [PATCH v2 2/2] net/mlx5: support new RSS symmetric hash function > > This patch supports the new

RE: [PATCH] net/mlx5: supporting group set miss actions API

2023-10-30 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Tomer Shmilovich > Sent: Tuesday, September 26, 2023 6:59 PM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > > Cc: dev@dpdk.org > Subject: [PATCH] net/mlx5: supporting group set miss actions API > > Add implementation for rte_flow_group_

Re: [PATCH] devargs: fix derefrence before null test

2023-10-30 Thread Stephen Hemminger
On Mon, 30 Oct 2023 19:45:29 +0800 Weiguo Li wrote: > diff --git a/lib/eal/common/eal_common_devargs.c > b/lib/eal/common/eal_common_devargs.c index fb5d0a293b..8d6c3938eb > 100644 --- a/lib/eal/common/eal_common_devargs.c > +++ b/lib/eal/common/eal_common_devargs.c > @@ -185,11 +185,13 @@ rte_de

[PATCH] config/arm: add cortex-A55 part number

2023-10-30 Thread Hemant Agrawal
This patch adds the part number for Cortex-A55 ARM Cores A55 is used in NXP-i.mx93 SoCs. Signed-off-by: Hemant Agrawal --- config/arm/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/config/arm/meson.build b/config/arm/meson.build index 3f22d8a2fc..efd0bf32bc 100644 --- a/config/a

RE: [PATCH] net/mlx5: support bus socket with no hugepages

2023-10-30 Thread Slava Ovsiienko
Hi, Hari 1. >> We have a DPDK application running with all the CPU logical cores belonging to a single socket on a multi-socket system. 2. >> But the NIC itself is on a bus that is attached to the CPU from a different socket 3. >> socket where this NIC card is present because that is o

Re: [PATCH v3 00/19] use rte optional stdatomic API

2023-10-30 Thread David Marchand
On Thu, Oct 26, 2023 at 2:32 AM Tyler Retzlaff wrote: > > Replace the use of gcc builtin __atomic_xxx intrinsics with > corresponding rte_atomic_xxx optional stdatomic API. > > v3: > * add missing atomic specification on head variable > in struct rte_ring_headtail > * adapt to use rte_atom

RE: [PATCH] maintainers: update ena maintainers list

2023-10-30 Thread Atrash, Wajeeh
> -Original Message- > From: shaib...@amazon.com > Sent: Monday, October 30, 2023 3:21 PM > To: ferruh.yi...@amd.com; dev@dpdk.org > Cc: Beider, Ron ; Atrash, Wajeeh > ; Bernstein, Amit ; > Brandes, Shai > Subject: [PATCH] maintainers: update ena maintainers list > > From: Shai Brande

Re: [PATCH] maintainers: update ena maintainers list

2023-10-30 Thread David Marchand
Hello, On Mon, Oct 30, 2023 at 2:21 PM wrote: > > From: Shai Brandes > > Removed obsolete maintainers and added the ena team members. > > Signed-off-by: Shai Brandes > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > ind

RE: [PATCH] maintainers: update ena maintainers list

2023-10-30 Thread Bernstein, Amit
> -Original Message- > From: shaib...@amazon.com > Sent: Monday, October 30, 2023 15:21 > To: ferruh.yi...@amd.com; dev@dpdk.org > Cc: Beider, Ron ; Atrash, Wajeeh > ; Bernstein, Amit ; > Brandes, Shai > Subject: [PATCH] maintainers: update ena maintainers list > > From: Shai Brandes

[PATCH] maintainers: update ena maintainers list

2023-10-30 Thread shaibran
From: Shai Brandes Removed obsolete maintainers and added the ena team members. Signed-off-by: Shai Brandes --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f463188f1d..a181ab63b4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

RE: How to rte_epoll_wait for IPC?

2023-10-30 Thread Honnappa Nagarahalli
> -Original Message- > From: Morten Brørup > Sent: Friday, October 6, 2023 10:53 AM > To: Honnappa Nagarahalli ; Harman Kalra > ; Anatoly Burakov ; David > Hunt > Cc: dev@dpdk.org; nd ; nd > Subject: RE: How to rte_epoll_wait for IPC? > > > From: Honnappa Nagarahalli [mailto:honnappa

Re: [External] Re: [PATCH] eal: fix modify data area after memset

2023-10-30 Thread Fengnan Chang
Thanks for your response, It's my fault, I got mixed up, this problem only can reproduce after apply https://patches.dpdk.org/project/dpdk/patch/2023083937.60975-1-changfeng...@bytedance.com/ , I'll reorganize this to previous patch. So sorry for waste your time. Stephen Hemminger 于2023年10月2

Re: [PATCH RESEND v6 0/5] app/testpmd: support multiple process attach and detach port

2023-10-30 Thread lihuisong (C)
Hi Ferruh and Thomas, This series have been discussing more than one year. Kindly ping for reivew. 在 2023/10/9 18:34, lihuisong (C) 写道: Hi Ferruh and Thomas, Can you take a look at this series? They've been over a year on disscussion. 在 2023/8/2 11:15, Huisong Li 写道: This patchset fix so

[PATCH] devargs: fix derefrence before null test

2023-10-30 Thread Weiguo Li
Pointer 'da' was dereferenced and then compared to NULL, reorder the code to keep the logic consistent. Fixes: 4969f5914c9e ("devargs: introduce new parsing helper") Cc: sta...@dpdk.org Signed-off-by: Weiguo Li --- .mailmap| 2 +- lib/eal/common/eal_common_devargs.c

Re: [PATCH] net/mlx5: support bus socket with no hugepages

2023-10-30 Thread Hari Sasank
Hi Slava We have a DPDK application running with all the CPU logical cores belonging to a single socket on a multi-socket system. But the NIC itself is on a bus that is attached to the CPU from a different socket. In this case, the driver is allocating huge pages belonging to a socket that is d

RE: [PATCH] eal/unix: lower log level for reading files

2023-10-30 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Monday, 30 October 2023 11.35 > > I would add "sysfs" in the title. > > 27/10/2023 11:13, David Marchand: > > On Fri, Oct 27, 2023 at 11:00 AM Morten Brørup > wrote: > > > > > > > From: David Marchand [mailto:david.march...@redhat.com]

RE: [PATCH] net/mlx5: support bus socket with no hugepages

2023-10-30 Thread Slava Ovsiienko
Hi, Hari As I see almost all updates, using newly introduced MLX5_MEM_FALLBACK_ANY_SOCKET flag, are related to the memory mapped for the hardware usage (NIC accesses these areas with DMA over the PCIe bus segment NIC attached to). It means the memory allegiance to the specific is strong and mig

[PATCH 2/2] net/ngbe: add proper memory barriers in Rx

2023-10-30 Thread Jiawen Wu
Refer to commit 85e46c532bc7 ("net/ixgbe: add proper memory barriers in Rx"). Fix the same issue as ixgbe. Although due to the testing schedule, the current test has not found this problem. We also do the same fix in ngbe, to ensure the read ordering be correct. Fixes: 79f3128d4d98 ("net/ngbe: su

[PATCH 1/2] net/txgbe: add proper memory barriers in Rx

2023-10-30 Thread Jiawen Wu
Refer to commit 85e46c532bc7 ("net/ixgbe: add proper memory barriers in Rx"). Fix the same issue as ixgbe. Segmentation fault has been observed while running the txgbe_recv_pkts_lro() function to receive packets on the Loongson 3A5000 processor. It's caused by the out-of-order execution of CPU. So

Re: [PATCH] eal/unix: lower log level for reading files

2023-10-30 Thread Thomas Monjalon
I would add "sysfs" in the title. 27/10/2023 11:13, David Marchand: > On Fri, Oct 27, 2023 at 11:00 AM Morten Brørup > wrote: > > > > > From: David Marchand [mailto:david.march...@redhat.com] > > > Sent: Friday, 27 October 2023 10.01 > > > > > > The eal_parse_sysfs_value helper both returns an e

RE: [PATCH v2 0/3] net/mlx5: add port representor destination to mirror

2023-10-30 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Suanming Mou > Sent: Monday, October 30, 2023 4:28 AM > Cc: dev@dpdk.org; Raslan Darawsheh ; Ori Kam > > Subject: [PATCH v2 0/3] net/mlx5: add port representor destination to mirror > > In order to clone the traffic from FDB to NIC TIR, user can set port

[PATCH v2] net/ice: fix crash on closing representor ports

2023-10-30 Thread Mingjin Ye
Since the representor port needs to access the resources of the associated DCF when it is closed. Therefore, the correct close port operation is to close all the representor ports first, and then close the associated DCF port. If the DCF port is closed before the representor port on pmd exit. This

RE: [PATCH 00/13] net/mlx5: support more REG C registers

2023-10-30 Thread Suanming Mou
Hi, > -Original Message- > From: Gregory Etelson > Sent: Monday, October 30, 2023 2:23 AM > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh > Subject: [PATCH 00/13] net/mlx5: support more REG C registers > > Support increased number of REG_Cx registers. > >

RE: [PATCH 13/13] net/mlx5: add validation support for tags

2023-10-30 Thread Dariusz Sosnowski
Hi, > -Original Message- > From: Gregory Etelson > Sent: Sunday, October 29, 2023 19:23 > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh ; Ori Kam > ; Matan Azrad ; Slava Ovsiienko > ; Suanming Mou > Subject: [PATCH 13/13] net/mlx5: add validation support fo

RE: [PATCH 12/13] net/mlx5: add support for more registers

2023-10-30 Thread Dariusz Sosnowski
Hi, > -Original Message- > From: Gregory Etelson > Sent: Sunday, October 29, 2023 19:23 > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh ; Ori Kam > ; Matan Azrad ; Slava Ovsiienko > ; Suanming Mou > Subject: [PATCH 12/13] net/mlx5: add support for more regi

RE: [PATCH 11/13] net/mlx5: fix query for NIC flow cap

2023-10-30 Thread Dariusz Sosnowski
Hi, > -Original Message- > From: Gregory Etelson > Sent: Sunday, October 29, 2023 19:23 > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh ; Ori Kam > ; Bing Zhao ; Matan Azrad > ; Slava Ovsiienko ; Suanming > Mou > Subject: [PATCH 11/13] net/mlx5: fix query f

RE: [PATCH 10/13] net/mlx5: fix insert by index

2023-10-30 Thread Dariusz Sosnowski
Hi, > -Original Message- > From: Gregory Etelson > Sent: Sunday, October 29, 2023 19:23 > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh ; Ori Kam > ; Erez Shitrit ; Matan Azrad > ; Slava Ovsiienko ; Suanming > Mou ; Alex Vesker > Subject: [PATCH 10/13] net/

RE: [PATCH 09/13] net/mlx5: add support for calc hash

2023-10-30 Thread Dariusz Sosnowski
Hi, > -Original Message- > From: Gregory Etelson > Sent: Sunday, October 29, 2023 19:23 > To: dev@dpdk.org > Cc: Gregory Etelson ; Maayan Kashani > ; Raslan Darawsheh ; Ori Kam > ; Matan Azrad ; Slava Ovsiienko > ; Suanming Mou > Subject: [PATCH 09/13] net/mlx5: add support for calc hash

RE: [PATCH v3] test/cryptodev: add modexp group tests

2023-10-30 Thread Akhil Goyal
> Subject: [PATCH v3] test/cryptodev: add modexp group tests > > Add modexp tests for groups 5, 14, 15, 16, 17 and 18. > > Signed-off-by: Gowrishankar Muthukrishnan Applied to dpdk-next-crypto

RE: [PATCH] test/crypto: fix mbuf port in Rx inject

2023-10-30 Thread Akhil Goyal
> Subject: RE: [PATCH] test/crypto: fix mbuf port in Rx inject > > > > > By default mbuf port is not initialized and for Rx inject mbuf port update > > is > > required before submitting packet. > > > > Fixes: 69e1a909aa08 ("test/crypto: add Rx inject") > > > > Signed-off-by: Rahul Bhansali > >

RE: [PATCH v4] net/mlx5: add indirect encap decap support

2023-10-30 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Sunday, October 29, 2023 5:30 PM > To: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; NBU-Contact-Thomas Monjalon (EXTERNAL) > > Subject: [PATCH v4] net/mlx5: add indirect encap decap support > > Support th

RE: [EXT] [PATCH] ipsec: use sym_session_opaque_data for RTE_SECURITY_TYPE_CPU_CRYPTO

2023-10-30 Thread Akhil Goyal
> ipsec related processing in dpdk makes use of the crypto.ses opaque > data pointer. This patch updates rte_ipsec_session_prepare to set > ss->crypto.ses in the RTE_SECURITY_TYPE_CPU_CRYPTO case. > > Signed-off-by: Garry Marshall > --- Konstantin/ Kai, Is the below change ok for CPU crypto us

RE: [EXT] [PATCH] crypto/qat: fix build when no openssl exists

2023-10-30 Thread Akhil Goyal
> Previously some compilation errors existed when no openssl > was installed on the system, and intel-ipsec-mb was installed, > due to missing headers and macros. > > This patch fixes the issue by adding in extra ifdefs around openssl > specific code paths, and by adding the relevant macros explic

RE: [PATCH] test/crypto: fix mbuf port in Rx inject

2023-10-30 Thread Anoob Joseph
> > By default mbuf port is not initialized and for Rx inject mbuf port update is > required before submitting packet. > > Fixes: 69e1a909aa08 ("test/crypto: add Rx inject") > > Signed-off-by: Rahul Bhansali Acked-by: Anoob Joseph <>

RE: [EXT] [PATCH] crypto/ipsec_mb: Do not dequeue ops from ring after job flush.

2023-10-30 Thread Akhil Goyal
> Subject: [EXT] [PATCH] crypto/ipsec_mb: Do not dequeue ops from ring after job > flush. > Previously it was possible to increment `processed_jobs` to a value > greater than requested `nb_ops`, because after flushing at most > `nb_ops` jobs the while loop continued, so `processed_jobs` could > sti