Pointer 'da' was dereferenced and then compared to NULL,
reorder the code to keep the logic consistent.

Fixes: 4969f5914c9e ("devargs: introduce new parsing helper")
Cc: sta...@dpdk.org

Signed-off-by: Weiguo Li <liwei...@xencore.cn>
---
 .mailmap                            | 2 +-
 lib/eal/common/eal_common_devargs.c | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/.mailmap b/.mailmap
index 3f5bab26a8..b4f0ae26b8 100644
--- a/.mailmap
+++ b/.mailmap
@@ -1500,7 +1500,7 @@ Waterman Cao <waterman....@intel.com>
 Weichun Chen <weichunx.c...@intel.com>
 Wei Dai <wei....@intel.com>
 Weifeng Li <liweifen...@126.com>
-Weiguo Li <liw...@foxmail.com>
+Weiguo Li <liw...@foxmail.com> <liwei...@xencore.cn>
 Wei Huang <wei.hu...@intel.com>
 Wei Hu <w...@microsoft.com>
 Wei Hu (Xavier) <xavier.hu...@huawei.com>
diff --git a/lib/eal/common/eal_common_devargs.c 
b/lib/eal/common/eal_common_devargs.c
index fb5d0a293b..8d6c3938eb 100644
--- a/lib/eal/common/eal_common_devargs.c
+++ b/lib/eal/common/eal_common_devargs.c
@@ -185,11 +185,13 @@ rte_devargs_parse(struct rte_devargs *da, const char *dev)
 {
        struct rte_bus *bus = NULL;
        const char *devname;
-       const size_t maxlen = sizeof(da->name);
        size_t i;
 
        if (da == NULL)
                return -EINVAL;
+
+       const size_t maxlen = sizeof(da->name);
+
        memset(da, 0, sizeof(*da));
 
        /* First parse according global device syntax. */
-- 
2.34.1

Reply via email to