Re: [PATCH v2 15/29] meter: remove experimental warning from comments

2023-10-18 Thread David Marchand
On Wed, Aug 9, 2023 at 2:12 AM Stephen Hemminger wrote: > > The API's for rte_meter_trtcm were never properly flagged > as experimental; missing __rte_experimental but there was The 4115 trtcm API was properly marked experimental in the past. See commit 655796d2b5fb ("meter: support RFC4115 trTCM

[PATCH] net/nfp: support represented port action

2023-10-18 Thread Chaoyong He
Add the corresponding logics to support the offload of represented port action. Signed-off-by: Chaoyong He --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/nfp_flow.c | 51 +++- 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/doc/guide

RE: [EXT] Re: [PATCH v6 18/34] ml/cnxk: support config and close of tvmdp library

2023-10-18 Thread Srikanth Yalavarthi
> -Original Message- > From: Jerin Jacob > Sent: 19 October 2023 00:04 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Anup Prabhu ; > Prince Takkar ; Srikanth Yalavarthi > > Subject: [EXT] Re: [PATCH v6 18/34] ml/cnxk: support config and close of >

RE: [EXT] Re: [PATCH v6 00/34] Implementation of revised ml/cnxk driver

2023-10-18 Thread Srikanth Yalavarthi
> -Original Message- > From: Jerin Jacob > Sent: 18 October 2023 19:50 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Anup Prabhu ; > Prince Takkar ; Srikanth Yalavarthi > > Subject: [EXT] Re: [PATCH v6 00/34] Implementation of revised ml/cnxk > driv

[PATCH] net/nfp: update the supported list of packet types

2023-10-18 Thread Chaoyong He
From: Qin Ke The NFP PMD supports reporting more packet types then previously claimed, extend the list of supported types. While at it add a check to only list supported packet types if the firmware supports the feature. Signed-off-by: Qin Ke Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_

Re: [PATCH v5 2/2] eventdev: fix missing driver names in info struct

2023-10-18 Thread Jerin Jacob
On Wed, Oct 18, 2023 at 9:07 PM Bruce Richardson wrote: > > Rather than relying on the individual drivers to always populated the > driver name field in the info structure - something missed by some > drivers, we can do so in the eventdev rte_event_dev_info_get() function. > This fixes issues > >

Re: [PATCH] event/cnxk: update fc check to use SQEs

2023-10-18 Thread Jerin Jacob
On Mon, Oct 16, 2023 at 8:52 PM wrote: > > From: Pavan Nikhilesh > > Update fc check to count SQEs instead of SQBs while waiting for > space. > > Signed-off-by: Pavan Nikhilesh Applied to dpdk-next-net-eventdev/for-main. Thanks

[PATCH v3] app/dma-perf: fix physical address seg-fault

2023-10-18 Thread Vipin Varghese
do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return the start of the virtual address for both src and dst. But in case of iova mode set as PA, this results in seg-fault. This is because rte_memcpy uses VA address and not PA. This fix invokes `rte_pktmbuf_mtod` for both src and dst. Bugzill

[PATCH v7 34/34] ml/cnxk: enable creation of mvtvm virtual device

2023-10-18 Thread Srikanth Yalavarthi
Enable support to create a mvtvm virtual device on system's without a PCI based ML HW accelerator. Signed-off-by: Srikanth Yalavarthi --- doc/guides/mldevs/cnxk.rst | 50 +++- drivers/ml/cnxk/cn10k_ml_dev.c | 8 ++ drivers/ml/cnxk/cn10k_ml_dev.h | 3 + drivers/ml/cnxk/cnxk_ml_

[PATCH v7 33/34] ml/cnxk: enable fast-path ops for TVM models

2023-10-18 Thread Srikanth Yalavarthi
From: Anup Prabhu Enable fast-path ops support for TVM models. Models would use TVMDP library function calls to execute inference operations for Hybrid and LLVM model sub-types. For TVM MRVL model subtypes that have a single MRVL layer, the inference requests are directly enqueued to hardware by

[PATCH v7 32/34] ml/cnxk: support quantize and dequantize callback

2023-10-18 Thread Srikanth Yalavarthi
From: Prince Takkar Added support for quantize and dequantize callback functions for TVM models. Signed-off-by: Prince Takkar --- drivers/ml/cnxk/mvtvm_ml_ops.c | 129 + drivers/ml/cnxk/mvtvm_ml_ops.h | 4 + 2 files changed, 133 insertions(+) diff --git a/dri

[PATCH v7 31/34] ml/cnxk: add generic ML malloc and free callback

2023-10-18 Thread Srikanth Yalavarthi
Implemented generic ML malloc and free callbacks Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 30 ++ drivers/ml/cnxk/cn10k_ml_ops.h | 3 +++ drivers/ml/cnxk/mvtvm_ml_ops.c | 2 ++ 3 files changed, 35 insertions(+) diff --git a/drivers/ml/

[PATCH v7 30/34] ml/cnxk: implement I/O alloc and free callbacks

2023-10-18 Thread Srikanth Yalavarthi
Implemented callback functions for IO allocation and free for Glow layers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 87 ++ drivers/ml/cnxk/cn10k_ml_ops.h | 3 ++ drivers/ml/cnxk/mvtvm_ml_ops.c | 2 + 3 files changed, 92 insertions(

[PATCH v7 29/34] ml/cnxk: enable reporting model runtime as xstats

2023-10-18 Thread Srikanth Yalavarthi
Added model xstats entries to compute runtime latency. Allocated internal resources for TVM model xstats. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 9 +++ drivers/ml/cnxk/cn10k_ml_ops.h | 2 + drivers/ml/cnxk/cnxk_ml_ops.c| 131 ++

[PATCH v7 27/34] ml/cnxk: update internal TVM model info structure

2023-10-18 Thread Srikanth Yalavarthi
From: Prince Takkar Added support to update internal model info structure for TVM models. Signed-off-by: Prince Takkar Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/mvtvm_ml_model.c | 65 drivers/ml/cnxk/mvtvm_ml_model.h | 2 + drivers/ml/cnxk/mvtvm_

[PATCH v7 28/34] ml/cnxk: support device dump for TVM models

2023-10-18 Thread Srikanth Yalavarthi
Enabled support to print TVM model layer info. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cnxk_ml_model.c | 7 +++- drivers/ml/cnxk/mvtvm_ml_model.c | 59 drivers/ml/cnxk/mvtvm_ml_model.h | 2 ++ drivers/ml/cnxk/mvtvm_ml_stubs.c | 8 + drivers

[PATCH v7 26/34] ml/cnxk: support start and stop for TVM models

2023-10-18 Thread Srikanth Yalavarthi
Added support to start and stop TVM models. TVM model start would invoke layer start for all Glow layers part of the model. TVM model stop would invoke layer stop for all Glow layers part of the model. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cn10k_ml_op

[PATCH v7 25/34] ml/cnxk: enable OCM check for multilayer TVM model

2023-10-18 Thread Srikanth Yalavarthi
From: Anup Prabhu Enabled check for OCM size requirement for multi-layer TVM model. Compute OCM scratch and WB requirement for all layers during the load stage. Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_ops.c | 60 +++ 1 file changed, 60 insertions(

[PATCH v7 24/34] ml/cnxk: enable model unload in tvmdp library

2023-10-18 Thread Srikanth Yalavarthi
Enable unloading model using external tvmdp library. Updated layer unload callback to support multiple layers. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cn10k_ml_ops.c | 8 +--- drivers/ml/cnxk/cnxk_ml_ops.c| 7 +-- drivers/ml/cnxk/mvtvm_m

[PATCH v7 23/34] ml/cnxk: update internal info for TVM model

2023-10-18 Thread Srikanth Yalavarthi
Enabled updating internal IO info structures for TVM model. Compute static fields related to the model I/O. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cnxk_ml_ops.c| 4 ++ drivers/ml/cnxk/mvtvm_ml_model.c | 111 +++ drivers/ml/cnxk/mvtvm_ml_model.h |

[PATCH v7 22/34] ml/cnxk: fetch layer info and load TVM model

2023-10-18 Thread Srikanth Yalavarthi
Added support to fetch TVM model layer information and update internal structures based on the layer information Set callback functions for layer load and unload and enable model loading using TVMDP library. Added support to fetch full metadata after model load. Signed-off-by: Srikanth Yalavarthi

[PATCH v7 18/34] ml/cnxk: support config and close of tvmdp library

2023-10-18 Thread Srikanth Yalavarthi
Added support to configure and close TVMDP library based on ML device configuration options. Updated meson build to enable Jansson, TVM runtime, TVMDP library as build dependencies. Signed-off-by: Srikanth Yalavarthi --- doc/guides/mldevs/cnxk.rst | 153 +++ dr

[PATCH v7 21/34] ml/cnxk: add support to parse TVM model objects

2023-10-18 Thread Srikanth Yalavarthi
Added support to parse TVM model objects from the model archive buffer. Added support to check for all expected objects and copy TVM model objects to internal buffers. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_ops.c| 5 ++- drivers/ml/cnxk/mv

[PATCH v7 20/34] ml/cnxk: add support for identify model type

2023-10-18 Thread Srikanth Yalavarthi
Enable support to parse model buffer to identify the model type and model sub-type. Enabled basic checks for Glow model type buffer. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_model.c | 49 drivers/ml/cnxk/cnxk_ml_mode

[PATCH v7 17/34] ml/cnxk: move error handling to cnxk layer

2023-10-18 Thread Srikanth Yalavarthi
Move error type structures to cnxk layer. cn10k layer to handle fw and hw error sub-types only. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 41 ++- drivers/ml/cnxk/cn10k_ml_ops.c | 93 +- drivers/ml/cnxk/cnxk_ml_dev.c | 8

[PATCH v7 19/34] ml/cnxk: add structures to support TVM model type

2023-10-18 Thread Srikanth Yalavarthi
Introduced model type, sub-type and layer type. Added internal structures for TVM model objects. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 3 ++ drivers/ml/cnxk/cn10k_ml_ops.c | 6 ++- drivers/ml/cnxk/cnxk_ml_model.h | 66 +++- dri

[PATCH v7 16/34] ml/cnxk: update fast path functions

2023-10-18 Thread Srikanth Yalavarthi
Implemented cnxk layer fast-path functions and added support for model specific fast-path functions. CNXK layer functions would invoke model specific fast-path functions. Added support for model specific poll handling functions and updated internal inference sync function. Drop use of rte_ml_op as

[PATCH v7 15/34] ml/cnxk: update device and model xstats functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device and model extended stats. Handling resources for the xstats is done in the cnxk layer. Introduced internal xstats group. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 4 - drivers/ml/cnxk/cn10k_ml_ops.c | 531 +++

[PATCH v7 12/34] ml/cnxk: update data quantization functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper functions to quantize input data and dequantize output data. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 164 - drivers/ml/cnxk/cn10k_ml_ops.h | 7 -- drivers/ml/cnxk/cnxk_ml_io.c | 95 +++ driver

[PATCH v7 11/34] ml/cnxk: update model utility functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper function to update model params and fetch model info. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 38 ++- drivers/ml/cnxk/cn10k_ml_ops.h | 5 ++-- drivers/ml/cnxk/cnxk_ml_ops.c | 48 -- 3 fil

[PATCH v7 14/34] ml/cnxk: update device stats functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device stats Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 32 -- drivers/ml/cnxk/cn10k_ml_ops.h | 2 -- drivers/ml/cnxk/cnxk_ml_ops.c | 36 -- 3 files changed, 34 ins

[PATCH v7 10/34] ml/cnxk: update model start and stop functions

2023-10-18 Thread Srikanth Yalavarthi
Implemented cnxk wrapper functions to start and stop ML models. Wrapper functions would invoke the cn10k model start and stop functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 28 ++-- drivers/ml/cnxk/cn10k_ml_ocm.h | 12 +- drivers/ml/cnxk/cn10k_ml_ops.c | 282

[PATCH v7 13/34] ml/cnxk: update device debug functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper for device dump and selftest debug functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 118 + drivers/ml/cnxk/cn10k_ml_model.h | 1 + drivers/ml/cnxk/cn10k_ml_ocm.c | 8 +- drivers/ml/cnxk/cn10k_ml_ocm.h | 2 +- dr

[PATCH v7 09/34] ml/cnxk: update model load and unload functions

2023-10-18 Thread Srikanth Yalavarthi
Implemented cnxk wrapper functions to load and unload ML models. Wrapper functions would invoke the cn10k model load and unload functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 244 - drivers/ml/cnxk/cn10k_ml_model.h | 26 ++- drivers/

[PATCH v7 04/34] ml/cnxk: add generic cnxk request structure

2023-10-18 Thread Srikanth Yalavarthi
Added generic cnxk request structure. Moved common fields from cn10k structures to cnxk structure. Moved job related structures and enumerations to ops headers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 72 +++ drivers/ml/cnxk/cn10k_ml_dev.h | 269 +

[PATCH v7 08/34] ml/cnxk: update queue-pair handling functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device queue-pairs. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 135 + drivers/ml/cnxk/cn10k_ml_ops.h | 7 +- drivers/ml/cnxk/cnxk_ml_ops.c | 153 - drivers/ml/cnxk

[PATCH v7 07/34] ml/cnxk: update device handling functions

2023-10-18 Thread Srikanth Yalavarthi
Implement CNXK wrapper functions for dev_info_get, dev_configure, dev_close, dev_start and dev_stop. The wrapper functions allocate / release common resources for the ML driver and invoke device specific functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 230 ++---

[PATCH v7 03/34] ml/cnxk: add generic model and layer structures

2023-10-18 Thread Srikanth Yalavarthi
Introduce generic cnxk model and layer structure. These structures would enable supporting models with multiple layers. A model is a collection of multiple independent layers with flow dependencies between the layers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 9

[PATCH v7 06/34] ml/cnxk: rename cnxk ops function pointers struct

2023-10-18 Thread Srikanth Yalavarthi
Renamed cn10k ML ops structure with cnxk prefix. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 2 +- drivers/ml/cnxk/cn10k_ml_ops.c | 73 +- drivers/ml/cnxk/cn10k_ml_ops.h | 34 +++- drivers/ml/cnxk/cnxk_ml_ops.c | 36 ++

[PATCH v7 02/34] ml/cnxk: add generic cnxk device structure

2023-10-18 Thread Srikanth Yalavarthi
Introduce generic cnxk device structure. This structure is a top level device structure for the driver, which would encapsulate the target / platform specific device structure. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 316 ++-- drivers/ml/cnxk/cn1

[PATCH v7 05/34] ml/cnxk: add generic cnxk xstats structures

2023-10-18 Thread Srikanth Yalavarthi
Introduced generic xstats structures and renamed cn10k xstats enumerations with cnxk prefix. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 86 +--- drivers/ml/cnxk/cn10k_ml_model.h | 6 +- drivers/ml/cnxk/cn10k_ml_ops.c | 169 ++---

[PATCH v7 01/34] ml/cnxk: drop support for register polling

2023-10-18 Thread Srikanth Yalavarthi
Dropped support for device argument "poll_mem" for cnxk ML driver. Support to use registers for polling is removed and DDR addresses would be used for polling. Signed-off-by: Srikanth Yalavarthi --- doc/guides/mldevs/cnxk.rst | 16 - drivers/ml/cnxk/cn10k_ml_dev.c | 36 +-- dri

[PATCH v7 00/34] Implementation of revised ml/cnxk driver

2023-10-18 Thread Srikanth Yalavarthi
This patch series is an implementation of revised ml/cnxk driver to support models compiled with TVM compiler framework. TVM models use a hybrid mode for execution, with regions of the model executing on the ML accelerator and the rest executing on CPU cores. This series of commits reorganizes the

[PATCH v3] app/dma-perf: fix physical address seg-fault

2023-10-18 Thread Vipin Varghese
do_cpu_mem_copy uses DPDK API rte_mbuf_data_iova to return the start of the virtual address for both src and dst. But in case of iova mode set as PA, this results in seg-fault. This is because rte_memcpy uses VA address and not PA. This fix invokes `rte_pktmbuf_mtod` for both src and dst. Bugzill

RE: [PATCH v2] net/cpfl: update CP channel API

2023-10-18 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Jingjing > Sent: Thursday, October 19, 2023 10:51 AM > To: Xing, Beilei ; Zhang, Yuying > > Cc: dev@dpdk.org > Subject: RE: [PATCH v2] net/cpfl: update CP channel API > > > > > -Original Message- > > From: Xing, Beilei > > Sent: Thursday, Oc

Re: [PATCH v6 3/3] net/octeon_ep: add new fastpath routines

2023-10-18 Thread Jerin Jacob
On Thu, Oct 19, 2023 at 6:52 AM Vamsi Attunuru wrote: > > Adds new fastpath routines for cn10k & cn9k endpoint > devices and assigns the fastpath routines based on > the offload flags. > > Patch also adds misc changes to improve performance > and code-readability. > > Signed-off-by: Vamsi Attunuru

RE: [PATCH v2] net/cpfl: update CP channel API

2023-10-18 Thread Wu, Jingjing
> -Original Message- > From: Xing, Beilei > Sent: Thursday, October 19, 2023 6:58 PM > To: Wu, Jingjing ; Zhang, Yuying > > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH v2] net/cpfl: update CP channel API > > From: Beilei Xing > > Update the cpchnl2 function type according to t

[PATCH v2] net/cpfl: update CP channel API

2023-10-18 Thread beilei . xing
From: Beilei Xing Update the cpchnl2 function type according to the definition in MEV 1.0 release. Signed-off-by: Beilei Xing --- v2 change: - rename unused enum drivers/net/cpfl/cpfl_cpchnl.h | 19 ++- drivers/net/cpfl/cpfl_ethdev.h | 2 +- drivers/net/cpfl/cpfl_r

RE: [PATCH v2] net/cpfl: remove devargs from adapter

2023-10-18 Thread Zhang, Qi Z
> -Original Message- > From: beilei.x...@intel.com > Sent: Wednesday, October 18, 2023 6:56 PM > To: Wu, Jingjing ; Zhang, Yuying > > Cc: dev@dpdk.org; Xing, Beilei > Subject: [PATCH v2] net/cpfl: remove devargs from adapter > > From: Beilei Xing > > Member devargs can be removed f

RE: [PATCH v2] net/cpfl: fix memory leak

2023-10-18 Thread Zhang, Qi Z
> -Original Message- > From: beilei.x...@intel.com > Sent: Wednesday, October 18, 2023 10:27 PM > To: Wu, Jingjing ; Zhang, Yuying > > Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org > Subject: [PATCH v2] net/cpfl: fix memory leak > > From: Beilei Xing > > Fix resource leak reporte

Re: [PATCH v2 00/29] promote many API's to stable

2023-10-18 Thread David Marchand
On Wed, Oct 18, 2023 at 9:14 PM David Marchand wrote: > > Hello Stephen, > > On Wed, Aug 9, 2023 at 2:10 AM Stephen Hemminger > wrote: > > > > Since 23.11 is an LTS release it is time to remove the experimental > > bandaid off many API's. There are about 850 API's marked with experimental > > on

Re: [PATCH 00/15] eal: mark older API's stable

2023-10-18 Thread David Marchand
On Wed, Aug 9, 2023 at 6:44 PM Stephen Hemminger wrote: > > About 80 function in EAL were marked experimental > and should have been made stable by now. > > Stephen Hemminger (15): > eal: make bitops a stable API > eal: mark rte_dev API's as stable > eal: make rte_class API's stable > eal:

Re: [PATCH v2 00/29] promote many API's to stable

2023-10-18 Thread David Marchand
Hello Stephen, On Wed, Aug 9, 2023 at 2:10 AM Stephen Hemminger wrote: > > Since 23.11 is an LTS release it is time to remove the experimental > bandaid off many API's. There are about 850 API's marked with experimental > on current main branch. This addresses the easy to remove ones and > gets i

Re: [PATCH v6 18/34] ml/cnxk: support config and close of tvmdp library

2023-10-18 Thread Jerin Jacob
On Wed, Oct 18, 2023 at 7:52 PM Srikanth Yalavarthi wrote: > > Added support to configure and close TVMDP library based > on ML device configuration options. > > Updated meson build to enable Jansson, TVM runtime, TVMDP > library as build dependencies. > > Signed-off-by: Srikanth Yalavarthi > ---

Re: [PATCH v2 17/29] kvargs: remove experimental flag

2023-10-18 Thread Bruce Richardson
On Tue, Aug 08, 2023 at 05:10:05PM -0700, Stephen Hemminger wrote: > The function rte_kvargs_get_with_value was added in 21.11 > so experimental flag can be removed. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Bruce Richardson

Re: [PATCH v2 15/29] meter: remove experimental warning from comments

2023-10-18 Thread Bruce Richardson
On Tue, Aug 08, 2023 at 05:10:03PM -0700, Stephen Hemminger wrote: > The API's for rte_meter_trtcm were never properly flagged > as experimental; missing __rte_experimental but there was > an experimental comment in the docbook comment. > Remove the comment. > > Signed-off-by: Stephen Hemminger >

Re: [PATCH v2 14/29] dmadev: mark API's as not experimental

2023-10-18 Thread Bruce Richardson
On Tue, Aug 08, 2023 at 05:10:02PM -0700, Stephen Hemminger wrote: > These were added in 20.11 time now to remove experimental flag. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Bruce Richardson

Re: [PATCH v2 10/29] mbuf: remove experimental from create_extbuf

2023-10-18 Thread Bruce Richardson
On Tue, Aug 08, 2023 at 05:09:58PM -0700, Stephen Hemminger wrote: > This API was added in 2020 and should no longer be experimental. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Bruce Richardson

Re: [PATCH v2 02/29] cmdline: make experimental API's stable

2023-10-18 Thread Bruce Richardson
On Tue, Aug 08, 2023 at 05:09:50PM -0700, Stephen Hemminger wrote: > These API's have all ben around for several releases. > > Signed-off-by: Stephen Hemminger > --- Acked-by: Bruce Richardson

[PATCH v2] add CREDITS file

2023-10-18 Thread Stephen Hemminger
Add a credits file of past contributors to DPDK. There are obviously more names that should be added but lets start this with Venky. Signed-off-by: Stephen Hemminger Acked-by: Jerin Jacob --- v2 - reword opening, fix spelling CREDITS | 9 + 1 file changed, 9 insertions(+) create mode

Re: [EXT] [PATCH] ml/cnxk: don't export internal headers

2023-10-18 Thread Jerin Jacob
On Wed, Oct 18, 2023 at 3:03 PM Srikanth Yalavarthi wrote: > > > -Original Message- > > From: David Marchand > > Sent: 18 October 2023 14:46 > > To: dev@dpdk.org > > Cc: Jerin Jacob Kollanukkaran ; tho...@monjalon.net; > > Srikanth Yalavarthi ; Prince Takkar > > > > Subject: [EXT] [PATCH

Re: [PATCH v6 00/34] Implementation of revised ml/cnxk driver

2023-10-18 Thread Jerin Jacob
On Wed, Oct 18, 2023 at 7:24 PM Srikanth Yalavarthi wrote: > > This patch series is an implementation of revised ml/cnxk driver > to support models compiled with TVM compiler framework. TVM models > use a hybrid mode for execution, with regions of the model executing > on the ML accelerator and th

[PATCH v6 34/34] ml/cnxk: enable creation of mvtvm virtual device

2023-10-18 Thread Srikanth Yalavarthi
Enable support to create a mvtvm virtual device on system's without a PCI based ML HW accelerator. Signed-off-by: Srikanth Yalavarthi --- doc/guides/mldevs/cnxk.rst | 49 +++- drivers/ml/cnxk/cn10k_ml_dev.c | 8 ++ drivers/ml/cnxk/cn10k_ml_dev.h | 3 + drivers/ml/cnxk/cnxk_ml_

[PATCH v6 33/34] ml/cnxk: enable fast-path ops for TVM models

2023-10-18 Thread Srikanth Yalavarthi
From: Anup Prabhu Enable fast-path ops support for TVM models. Models would use TVMDP library function calls to execute inference operations for Hybrid and LLVM model sub-types. For TVM MRVL model subtypes that have a single MRVL layer, the inference requests are directly enqueued to hardware by

[PATCH v6 32/34] ml/cnxk: support quantize and dequantize callback

2023-10-18 Thread Srikanth Yalavarthi
From: Prince Takkar Added support for quantize and dequantize callback functions for TVM models. Signed-off-by: Prince Takkar --- drivers/ml/cnxk/mvtvm_ml_ops.c | 129 + drivers/ml/cnxk/mvtvm_ml_ops.h | 4 + 2 files changed, 133 insertions(+) diff --git a/dri

[PATCH v6 30/34] ml/cnxk: implement I/O alloc and free callbacks

2023-10-18 Thread Srikanth Yalavarthi
Implemented callback functions for IO allocation and free for Glow layers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 87 ++ drivers/ml/cnxk/cn10k_ml_ops.h | 3 ++ drivers/ml/cnxk/mvtvm_ml_ops.c | 2 + 3 files changed, 92 insertions(

[PATCH v6 31/34] ml/cnxk: add generic ML malloc and free callback

2023-10-18 Thread Srikanth Yalavarthi
Implemented generic ML malloc and free callbacks Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 30 ++ drivers/ml/cnxk/cn10k_ml_ops.h | 3 +++ drivers/ml/cnxk/mvtvm_ml_ops.c | 2 ++ 3 files changed, 35 insertions(+) diff --git a/drivers/ml/

[PATCH v6 29/34] ml/cnxk: enable reporting model runtime as xstats

2023-10-18 Thread Srikanth Yalavarthi
Added model xstats entries to compute runtime latency. Allocated internal resources for TVM model xstats. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 9 +++ drivers/ml/cnxk/cn10k_ml_ops.h | 2 + drivers/ml/cnxk/cnxk_ml_ops.c| 131 ++

[PATCH v6 27/34] ml/cnxk: update internal TVM model info structure

2023-10-18 Thread Srikanth Yalavarthi
From: Prince Takkar Added support to update internal model info structure for TVM models. Signed-off-by: Prince Takkar Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/mvtvm_ml_model.c | 65 drivers/ml/cnxk/mvtvm_ml_model.h | 2 + drivers/ml/cnxk/mvtvm_

[PATCH v6 28/34] ml/cnxk: support device dump for TVM models

2023-10-18 Thread Srikanth Yalavarthi
Enabled support to print TVM model layer info. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cnxk_ml_model.c | 7 +++- drivers/ml/cnxk/mvtvm_ml_model.c | 59 drivers/ml/cnxk/mvtvm_ml_model.h | 2 ++ drivers/ml/cnxk/mvtvm_ml_stubs.c | 8 + drivers

[PATCH v6 26/34] ml/cnxk: support start and stop for TVM models

2023-10-18 Thread Srikanth Yalavarthi
Added support to start and stop TVM models. TVM model start would invoke layer start for all Glow layers part of the model. TVM model stop would invoke layer stop for all Glow layers part of the model. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cn10k_ml_op

[PATCH v6 25/34] ml/cnxk: enable OCM check for multilayer TVM model

2023-10-18 Thread Srikanth Yalavarthi
From: Anup Prabhu Enabled check for OCM size requirement for multi-layer TVM model. Compute OCM scratch and WB requirement for all layers during the load stage. Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_ops.c | 60 +++ 1 file changed, 60 insertions(

[PATCH v6 23/34] ml/cnxk: update internal info for TVM model

2023-10-18 Thread Srikanth Yalavarthi
Enabled updating internal IO info structures for TVM model. Compute static fields related to the model I/O. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cnxk_ml_ops.c| 4 ++ drivers/ml/cnxk/mvtvm_ml_model.c | 111 +++ drivers/ml/cnxk/mvtvm_ml_model.h |

[PATCH v6 24/34] ml/cnxk: enable model unload in tvmdp library

2023-10-18 Thread Srikanth Yalavarthi
Enable unloading model using external tvmdp library. Updated layer unload callback to support multiple layers. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cn10k_ml_ops.c | 8 +--- drivers/ml/cnxk/cnxk_ml_ops.c| 7 +-- drivers/ml/cnxk/mvtvm_m

[PATCH v6 22/34] ml/cnxk: fetch layer info and load TVM model

2023-10-18 Thread Srikanth Yalavarthi
Added support to fetch TVM model layer information and update internal structures based on the layer information Set callback functions for layer load and unload and enable model loading using TVMDP library. Added support to fetch full metadata after model load. Signed-off-by: Srikanth Yalavarthi

[PATCH v6 21/34] ml/cnxk: add support to parse TVM model objects

2023-10-18 Thread Srikanth Yalavarthi
Added support to parse TVM model objects from the model archive buffer. Added support to check for all expected objects and copy TVM model objects to internal buffers. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_ops.c| 5 ++- drivers/ml/cnxk/mv

[PATCH v6 20/34] ml/cnxk: add support for identify model type

2023-10-18 Thread Srikanth Yalavarthi
Enable support to parse model buffer to identify the model type and model sub-type. Enabled basic checks for Glow model type buffer. Signed-off-by: Srikanth Yalavarthi Signed-off-by: Anup Prabhu --- drivers/ml/cnxk/cnxk_ml_model.c | 49 drivers/ml/cnxk/cnxk_ml_mode

[PATCH v6 18/34] ml/cnxk: support config and close of tvmdp library

2023-10-18 Thread Srikanth Yalavarthi
Added support to configure and close TVMDP library based on ML device configuration options. Updated meson build to enable Jansson, TVM runtime, TVMDP library as build dependencies. Signed-off-by: Srikanth Yalavarthi --- doc/guides/mldevs/cnxk.rst | 78 dr

[PATCH v6 19/34] ml/cnxk: add structures to support TVM model type

2023-10-18 Thread Srikanth Yalavarthi
Introduced model type, sub-type and layer type. Added internal structures for TVM model objects. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 3 ++ drivers/ml/cnxk/cn10k_ml_ops.c | 6 ++- drivers/ml/cnxk/cnxk_ml_model.h | 66 +++- dri

[PATCH v6 17/34] ml/cnxk: move error handling to cnxk layer

2023-10-18 Thread Srikanth Yalavarthi
Move error type structures to cnxk layer. cn10k layer to handle fw and hw error sub-types only. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 41 ++- drivers/ml/cnxk/cn10k_ml_ops.c | 93 +- drivers/ml/cnxk/cnxk_ml_dev.c | 8

[PATCH v6 16/34] ml/cnxk: update fast path functions

2023-10-18 Thread Srikanth Yalavarthi
Implemented cnxk layer fast-path functions and added support for model specific fast-path functions. CNXK layer functions would invoke model specific fast-path functions. Added support for model specific poll handling functions and updated internal inference sync function. Drop use of rte_ml_op as

[PATCH v6 15/34] ml/cnxk: update device and model xstats functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device and model extended stats. Handling resources for the xstats is done in the cnxk layer. Introduced internal xstats group. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 4 - drivers/ml/cnxk/cn10k_ml_ops.c | 531 +++

[PATCH v6 14/34] ml/cnxk: update device stats functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device stats Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 32 -- drivers/ml/cnxk/cn10k_ml_ops.h | 2 -- drivers/ml/cnxk/cnxk_ml_ops.c | 36 -- 3 files changed, 34 ins

[PATCH v6 13/34] ml/cnxk: update device debug functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper for device dump and selftest debug functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 118 + drivers/ml/cnxk/cn10k_ml_model.h | 1 + drivers/ml/cnxk/cn10k_ml_ocm.c | 8 +- drivers/ml/cnxk/cn10k_ml_ocm.h | 2 +- dr

[PATCH v6 12/34] ml/cnxk: update data quantization functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper functions to quantize input data and dequantize output data. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 164 - drivers/ml/cnxk/cn10k_ml_ops.h | 7 -- drivers/ml/cnxk/cnxk_ml_io.c | 95 +++ driver

[PATCH v6 11/34] ml/cnxk: update model utility functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper function to update model params and fetch model info. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 38 ++- drivers/ml/cnxk/cn10k_ml_ops.h | 5 ++-- drivers/ml/cnxk/cnxk_ml_ops.c | 48 -- 3 fil

[PATCH v6 10/34] ml/cnxk: update model start and stop functions

2023-10-18 Thread Srikanth Yalavarthi
Implemented cnxk wrapper functions to start and stop ML models. Wrapper functions would invoke the cn10k model start and stop functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 28 ++-- drivers/ml/cnxk/cn10k_ml_ocm.h | 12 +- drivers/ml/cnxk/cn10k_ml_ops.c | 282

[PATCH v6 09/34] ml/cnxk: update model load and unload functions

2023-10-18 Thread Srikanth Yalavarthi
Implemented cnxk wrapper functions to load and unload ML models. Wrapper functions would invoke the cn10k model load and unload functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_model.c | 244 - drivers/ml/cnxk/cn10k_ml_model.h | 26 ++- drivers/

[PATCH v6 08/34] ml/cnxk: update queue-pair handling functions

2023-10-18 Thread Srikanth Yalavarthi
Added cnxk wrapper function to handle ML device queue-pairs. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 135 + drivers/ml/cnxk/cn10k_ml_ops.h | 7 +- drivers/ml/cnxk/cnxk_ml_ops.c | 153 - drivers/ml/cnxk

[PATCH v6 04/34] ml/cnxk: add generic cnxk request structure

2023-10-18 Thread Srikanth Yalavarthi
Added generic cnxk request structure. Moved common fields from cn10k structures to cnxk structure. Moved job related structures and enumerations to ops headers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 72 +++ drivers/ml/cnxk/cn10k_ml_dev.h | 269 +

[PATCH v6 07/34] ml/cnxk: update device handling functions

2023-10-18 Thread Srikanth Yalavarthi
Implement CNXK wrapper functions for dev_info_get, dev_configure, dev_close, dev_start and dev_stop. The wrapper functions allocate / release common resources for the ML driver and invoke device specific functions. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 230 ++---

[PATCH v6 03/34] ml/cnxk: add generic model and layer structures

2023-10-18 Thread Srikanth Yalavarthi
Introduce generic cnxk model and layer structure. These structures would enable supporting models with multiple layers. A model is a collection of multiple independent layers with flow dependencies between the layers. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 9

[PATCH v6 06/34] ml/cnxk: rename cnxk ops function pointers struct

2023-10-18 Thread Srikanth Yalavarthi
Renamed cn10k ML ops structure with cnxk prefix. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 2 +- drivers/ml/cnxk/cn10k_ml_ops.c | 73 +- drivers/ml/cnxk/cn10k_ml_ops.h | 34 +++- drivers/ml/cnxk/cnxk_ml_ops.c | 36 ++

[PATCH v6 05/34] ml/cnxk: add generic cnxk xstats structures

2023-10-18 Thread Srikanth Yalavarthi
Introduced generic xstats structures and renamed cn10k xstats enumerations with cnxk prefix. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.h | 86 +--- drivers/ml/cnxk/cn10k_ml_model.h | 6 +- drivers/ml/cnxk/cn10k_ml_ops.c | 169 ++---

[PATCH v6 02/34] ml/cnxk: add generic cnxk device structure

2023-10-18 Thread Srikanth Yalavarthi
Introduce generic cnxk device structure. This structure is a top level device structure for the driver, which would encapsulate the target / platform specific device structure. Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 316 ++-- drivers/ml/cnxk/cn1

[PATCH v6 01/34] ml/cnxk: drop support for register polling

2023-10-18 Thread Srikanth Yalavarthi
Dropped support for device argument "poll_mem" for cnxk ML driver. Support to use registers for polling is removed and DDR addresses would be used for polling. Signed-off-by: Srikanth Yalavarthi --- Depends-on: patch-132887 ("ml/cnxk: don't export internal headers") doc/guides/mldevs/cnxk.rst

[PATCH v6 00/34] Implementation of revised ml/cnxk driver

2023-10-18 Thread Srikanth Yalavarthi
This patch series is an implementation of revised ml/cnxk driver to support models compiled with TVM compiler framework. TVM models use a hybrid mode for execution, with regions of the model executing on the ML accelerator and the rest executing on CPU cores. This series of commits reorganizes the

Re: [PATCH v4] bus/pci: fix legacy device IO port map in secondary process

2023-10-18 Thread David Marchand
On Wed, Oct 18, 2023 at 2:39 PM Gupta, Nipun wrote: > On 10/18/2023 3:35 PM, David Marchand wrote: > > On Mon, Oct 9, 2023 at 5:06 AM Ma, WenwuX wrote: > >>> From a pci bus API pov, nothing prevents a driver from mixing memory > >>> mapped with vfio and ioport resources (iow, calls to > >>> rte_

Re: [PATCH v4 2/2] event/skeleton: set driver name string

2023-10-18 Thread Bruce Richardson
On Wed, Oct 18, 2023 at 01:52:08PM +0100, Bruce Richardson wrote: > On Wed, Oct 18, 2023 at 02:44:11PM +0200, David Marchand wrote: > > On Wed, Oct 18, 2023 at 2:26 PM Bruce Richardson > > wrote: > > > > > > When calling rte_eventdev_info_get() the driver name string field should > > > be populate

[PATCH v5 2/2] eventdev: fix missing driver names in info struct

2023-10-18 Thread Bruce Richardson
Rather than relying on the individual drivers to always populated the driver name field in the info structure - something missed by some drivers, we can do so in the eventdev rte_event_dev_info_get() function. This fixes issues Fixes: 929da5e6 ("event/skeleton: add skeleton eventdev driver") F

  1   2   >