> -----Original Message----- > From: Jerin Jacob <jerinjac...@gmail.com> > Sent: 18 October 2023 19:50 > To: Srikanth Yalavarthi <syalavar...@marvell.com> > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > <sshankarn...@marvell.com>; Anup Prabhu <apra...@marvell.com>; > Prince Takkar <ptak...@marvell.com>; Srikanth Yalavarthi > <syalavar...@marvell.com> > Subject: [EXT] Re: [PATCH v6 00/34] Implementation of revised ml/cnxk > driver > > External Email > > ---------------------------------------------------------------------- > On Wed, Oct 18, 2023 at 7:24 PM Srikanth Yalavarthi > <syalavar...@marvell.com> wrote: > > > > This patch series is an implementation of revised ml/cnxk driver to > > support models compiled with TVM compiler framework. TVM models use > a > > hybrid mode for execution, with regions of the model executing on the > > ML accelerator and the rest executing on CPU cores. > > > > This series of commits reorganizes the ml/cnxk driver and adds support > > to execute multiple regions with-in a TVM model. > > > > Fix this warning > > ### [PATCH] ml/cnxk: enable creation of mvtvm virtual device > > Warning in drivers/ml/cnxk/cn10k_ml_dev.c: > Using rte_panic/rte_exit
Updated the driver patches to avoid using rte_panic/rte_exit. Changes part of v7. > > Fix as needed which is relevent > ### [PATCH] ml/cnxk: add generic cnxk device structure > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #1778: FILE: drivers/ml/cnxk/cn10k_ml_ops.c:1316: > + strncpy(xstats_map[idx].name, > cn10k_mldev->xstats.entries[i].map.name, > > total: 0 errors, 1 warnings, 2276 lines checked > > ### [PATCH] ml/cnxk: add generic model and layer structures > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #117: FILE: drivers/ml/cnxk/cn10k_ml_model.c:379: > + strncpy(layer->info.input[i].name, (char > *)metadata->input1[i].input_name, > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #166: FILE: drivers/ml/cnxk/cn10k_ml_model.c:411: > + strncpy(layer->info.input[i].name, (char > *)metadata->input2[j].input_name, > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #221: FILE: drivers/ml/cnxk/cn10k_ml_model.c:449: > + strncpy(layer->info.output[i].name, > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #255: FILE: drivers/ml/cnxk/cn10k_ml_model.c:472: > + strncpy(layer->info.output[i].name, > > total: 0 errors, 4 warnings, 1905 lines checked > > ### [PATCH] ml/cnxk: update model load and unload functions > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #83: FILE: drivers/ml/cnxk/cn10k_ml_model.c:367: > + strncpy(io_info->input[i].name, (char > *)metadata->input1[i].input_name, > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #135: FILE: drivers/ml/cnxk/cn10k_ml_model.c:399: > + strncpy(io_info->input[i].name, (char > *)metadata->input2[j].input_name, > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #204: FILE: drivers/ml/cnxk/cn10k_ml_model.c:437: > + strncpy(io_info->output[i].name, (char > *)metadata->output1[i].output_name, > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #244: FILE: drivers/ml/cnxk/cn10k_ml_model.c:461: > + strncpy(io_info->output[i].name, (char > *)metadata->output2[j].output_name, > > total: 0 errors, 4 warnings, 1094 lines checked > > ### [PATCH] ml/cnxk: update device and model xstats functions > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #1100: FILE: drivers/ml/cnxk/cnxk_ml_ops.c:856: > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #1100: FILE: drivers/ml/cnxk/cnxk_ml_ops.c:856: > + strncpy(xstats_map[idx].name, xs->map.name, > RTE_ML_STR_MAX); > > total: 0 errors, 1 warnings, 1248 lines checked > > ### [PATCH] ml/cnxk: fetch layer info and load TVM model > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #172: FILE: drivers/ml/cnxk/mvtvm_ml_ops.c:125: > + strncpy(model->layer[layer_id].name, > > total: 0 errors, 1 warnings, 207 lines checked > > ### [PATCH] ml/cnxk: update internal info for TVM model > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #85: FILE: drivers/ml/cnxk/mvtvm_ml_model.c:175: > + strncpy(model->mvtvm.info.input[i].name, > metadata->input[i].name, > > WARNING:STRNCPY: Prefer strscpy, strscpy_pad, or __nonstring over > strncpy - see: https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_90&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=rCRq1CQlxbyMlcn4Bf-vfXpQbosVe-pT3EtatPXlKmg&e= > #118: FILE: drivers/ml/cnxk/mvtvm_ml_model.c:208: > + strncpy(model->mvtvm.info.output[i].name, > metadata->output[i].name, > > total: 0 errors, 2 warnings, 173 lines checked > > ### [PATCH] ml/cnxk: enable reporting model runtime as xstats > > WARNING:STRCPY: Prefer strscpy over strcpy - see: > https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_88&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=mUyWaXNokXAr7ebegeCamaauO7XAu7W5GqbaP20g-i8&e= > #113: FILE: drivers/ml/cnxk/cnxk_ml_ops.c:243: > + strcpy(suffix, "cycles"); > > WARNING:STRCPY: Prefer strscpy over strcpy - see: > https://urldefense.proofpoint.com/v2/url?u=https- > 3A__github.com_KSPP_linux_issues_88&d=DwIFaQ&c=nKjWec2b6R0mOyPa > z7xtfQ&r=SNPqUkGl0n_Ms1iJa_6wD6LBwX8efL_NOyXvAX-iCMI&m=Wc- > 9LbDLV9eZtdFI_acMCdshpvh76LPngspZk3yJrdWbVO8NUnmS3ywndxRTEuAI > &s=mUyWaXNokXAr7ebegeCamaauO7XAu7W5GqbaP20g-i8&e= > #115: FILE: drivers/ml/cnxk/cnxk_ml_ops.c:245: > + strcpy(suffix, "ns"); > Replaced all str* functions with rte_str* functions. Changes part of v7. > total: 0 errors, 2 warnings, 477 lines checked
