[PATCH] ci: fix race on container image name

2023-08-01 Thread David Marchand
We had a race on the container image name when the prepare job was running a day before the build job was triggered. Example: - a prepare job generated image name on 2023/08/01: 2023-08-01T23:59:32.9711845Z ++ date -u +%Y-%m-%d 2023-08-01T23:59:32.9713485Z + echo image=image-fedora:37-2023-08

Re: Fedora in CI

2023-08-01 Thread David Marchand
On Wed, Aug 2, 2023 at 4:28 AM Stephen Hemminger wrote: > > Looks like CI github build is failing because still trying Fedora 37. > Since latest release is Fedora 38, should get updated to that. That's not the reason why the Ci failed on the cmdline_poll series. -- David Marchand

Re: [PATCH v4] build: update DPDK to use C11 standard

2023-08-01 Thread David Marchand
On Tue, Aug 1, 2023 at 10:12 PM Patrick Robb wrote: > On Tue, Aug 1, 2023 at 12:20 PM Tyler Retzlaff > wrote: >> >> >> yes, support is being dropped for RHEL 7 in the main branch. >> >> http://mails.dpdk.org/archives/dev/2023-February/263516.html >> >> it seems like now that we are in 23.11 me

[PATCH v2] app/testpmd: add flush multicast MAC address command

2023-08-01 Thread Dengdui Huang
Add command to flush multicast MAC address Usage: mcast_addr flush : flush multicast MAC address on port_id Signed-off-by: Dengdui Huang --- app/test-pmd/cmdline.c | 43 + app/test-pmd/config.c | 18 + app/test-pmd/t

Re: [PATCH] app/testpmd: add flush multicast MAC address command

2023-08-01 Thread huangdengdui
在 2023/8/2 12:16, Stephen Hemminger 写道: > On Wed, 2 Aug 2023 10:41:46 +0800 > huangdengdui wrote: > >> 在 2023/8/1 23:18, Stephen Hemminger 写道: >>> On Tue, 1 Aug 2023 10:43:04 +0800 >>> Dengdui Huang wrote: >>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 0d0

[PATCH v4 3/4] eal: adapt rte pause APIs to use C11 atomics

2023-08-01 Thread Tyler Retzlaff
Adapt rte_pause.h APIs to use standard C11 atomics. Update consumers of the pause APIs for the API break. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- app/test-bbdev/test_bbdev_perf.c | 123 --- app/test/test_func_reentrancy.c | 8 +-

[PATCH v4 4/4] eal: adapt rte spinlock and rwlock APIs to use C11 atomics

2023-08-01 Thread Tyler Retzlaff
Adapt rte_spinlock.h and rte_rwlock.h APIs to use standard C11 atomics. Update consumers of the spinlock and rwlock APIs for the API break. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/include/generic/rte_rwlock.h | 46 ++ lib/eal/include/g

[PATCH v4 0/4] eal: update public API to use stdatomic atomics

2023-08-01 Thread Tyler Retzlaff
Update EAL public API to use standard C11 atomics. In accordance with technical board discussion February 2023. http://mails.dpdk.org/archives/dev/2023-February/263516.html This initial series makes no attempt to adapt every use of builtin atomics from GCC it intends only to adapt the public API o

[PATCH v4 2/4] devtools: forbid use of GCC atomic builtins

2023-08-01 Thread Tyler Retzlaff
Refrain from using compiler __atomic_xxx builtins DPDK now uses standard C11 atomics atomic_xxx. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- devtools/checkpatches.sh | 8 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh ind

[PATCH v4 1/4] build: require minimum c11 compiler

2023-08-01 Thread Tyler Retzlaff
Update top level meson.build to require c_std=c11 and remove use of -std=gnu99. Signed-off-by: Tyler Retzlaff --- drivers/net/failsafe/meson.build | 1 - lib/eal/common/eal_common_errno.c | 1 + meson.build | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH v3 4/4] eal: adapt rte spinlock and rwlock APIs to use C11 atomics

2023-08-01 Thread Tyler Retzlaff
Adapt rte_spinlock.h and rte_rwlock.h APIs to use standard C11 atomics. Update consumers of the spinlock and rwlock APIs for the API break. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- lib/eal/include/generic/rte_rwlock.h | 46 ++ lib/eal/include/g

[PATCH v3 3/4] eal: adapt rte pause APIs to use C11 atomics

2023-08-01 Thread Tyler Retzlaff
Adapt rte_pause.h APIs to use standard C11 atomics. Update consumers of the pause APIs for the API break. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- app/test-bbdev/test_bbdev_perf.c | 123 --- app/test/test_func_reentrancy.c | 8 +-

[PATCH v3 2/4] devtools: forbid use of GCC atomic builtins

2023-08-01 Thread Tyler Retzlaff
Refrain from using compiler __atomic_xxx builtins DPDK now uses standard C11 atomics atomic_xxx. Signed-off-by: Tyler Retzlaff Acked-by: Morten Brørup --- devtools/checkpatches.sh | 8 1 file changed, 8 insertions(+) diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh ind

[PATCH v3 0/4] eal: update public API to use stdatomic atomics

2023-08-01 Thread Tyler Retzlaff
Update EAL public API to use standard C11 atomics. In accordance with technical board discussion February 2023. http://mails.dpdk.org/archives/dev/2023-February/263516.html This initial series makes no attempt to adapt every use of builtin atomics from GCC it intends only to adapt the public API o

[PATCH v3 1/4] build: require minimum c11 compiler

2023-08-01 Thread Tyler Retzlaff
Update top level meson.build to require c_std=c11 and remove use of -std=gnu99. Signed-off-by: Tyler Retzlaff --- drivers/net/failsafe/meson.build | 1 - lib/eal/common/eal_common_errno.c | 1 + meson.build | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH] app/testpmd: add flush multicast MAC address command

2023-08-01 Thread Stephen Hemminger
On Wed, 2 Aug 2023 10:41:46 +0800 huangdengdui wrote: > 在 2023/8/1 23:18, Stephen Hemminger 写道: > > On Tue, 1 Aug 2023 10:43:04 +0800 > > Dengdui Huang wrote: > > > >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > >> index 0d0723f659..2d9d925776 100644 > >> --- a/app/test-pmd

[PATCH RESEND v6 1/5] drivers/bus: restore driver assignment at front of probing

2023-08-01 Thread Huisong Li
The driver assignment was moved back at the end of the device probing because there is no something to use rte_driver during the phase of probing. See commit 391797f04208 ("drivers/bus: move driver assignment to end of probing") However, it is necessary for probing callback to reference rte_driver

[PATCH RESEND v6 2/5] ethdev: fix skip valid port in probing callback

2023-08-01 Thread Huisong Li
The event callback in application may use the macro RTE_ETH_FOREACH_DEV to iterate over all enabled ports to do something(like, verifying the port id validity) when receive a probing event. If the ethdev state of a port is not RTE_ETH_DEV_UNUSED, this port will be considered as a valid port. Howev

[PATCH RESEND v6 4/5] app/testpmd: add attach and detach port for multiple process

2023-08-01 Thread Huisong Li
The port information needs to be updated due to attaching and detaching port. Currently, it is done in the same thread as removing or probing device, which doesn't satisfy the operation of attaching and detaching device in multiple process. If this operation is performed in one process, the other

[PATCH RESEND v6 0/5] app/testpmd: support multiple process attach and detach port

2023-08-01 Thread Huisong Li
This patchset fix some bugs and support attaching and detaching port in primary and secondary. --- -v6: adjust rte_eth_dev_is_used position based on alphabetical order in version.map -v5: move 'ALLOCATED' state to the back of 'REMOVED' to avoid abi break. -v4: fix a misspelling. -v3:

[PATCH RESEND v6 3/5] app/testpmd: check the validity of the port

2023-08-01 Thread Huisong Li
This patch checks the validity of port id for all events in 'eth_event_callback()'. Signed-off-by: Huisong Li Acked-by: Aman Singh Acked-by: Chengwen Feng --- app/test-pmd/testpmd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/t

[PATCH RESEND v6 5/5] app/testpmd: stop forwarding in new or destroy event

2023-08-01 Thread Huisong Li
When testpmd receives the new or destroy event, the port related information will be updated. Testpmd must stop packet forwarding before updating the information to avoid some serious problems. Signed-off-by: Huisong Li Acked-by: Chengwen Feng --- app/test-pmd/testpmd.c | 4 1 file changed

[PATCH v2] app/testpmd: fix UDP cksum error for UFO enable

2023-08-01 Thread Huisong Li
The command "tso set " is used to enable UFO, please see commit ce8e6e742807 ("app/testpmd: support UFO in checksum engine") The above patch configures the RTE_MBUF_F_TX_UDP_SEG to enable UFO only if tso_segsz is set. Then tx_prepare() may call rte_net_intel_cksum_prepare() to compute pseudo head

Re: [PATCH] app/testpmd: add flush multicast MAC address command

2023-08-01 Thread huangdengdui
在 2023/8/1 23:18, Stephen Hemminger 写道: > On Tue, 1 Aug 2023 10:43:04 +0800 > Dengdui Huang wrote: > >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index 0d0723f659..2d9d925776 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -494,6 +494,9 @@ sta

RE: [[PATCH v1] 0/8] *** SUBJECT HERE ***

2023-08-01 Thread 11
Your git commit headings are messed up with extra []. Yes, this is my problem :) David has been mentioned before , I'm re edit the cover-letter now. Thanks a lot. Regards wenbo -Original Message- From: Stephen Hemminger Sent: 2023年8月2日 10:31 To: Wenbo Cao Cc: dev@dpdk.org Subject: Re:

Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

2023-08-01 Thread Stephen Hemminger
On Tue, 1 Aug 2023 07:21:29 + Wenbo Cao wrote: > *** BLURB HERE *** > > Wenbo Cao (8): > net/rnp: add skeleton > net/rnp: add ethdev probe and remove > net/rnp: add device init and uninit > net/rnp: add mbx basic api feature > net/rnp add reset code for Chip Init process > net/r

Re: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

2023-08-01 Thread Stephen Hemminger
On Wed, 2 Aug 2023 09:41:29 +0800 "11" wrote: > Hi Stephen, > > Thanks for your comment, as your advice that I need to define the virtual > function pointers > As the below type ? No, keep the struct the same, but make it const where used. You also do a copy of the ops struct so the one you ini

RE: [[PATCH v1] 3/8] net/rnp: add device init and uninit

2023-08-01 Thread 11
Hi Stephen, Why have two labels for same place, to later patches insert code here? For this question the new code in rnp_init_port_resource Will zmalloc dev->data->mac_addrs and dev->data->hash_mac_addrs So I wish to free the zmalloc mem when init port resource failed Regards wenbo -Origi

Re: [PATCH v1] mempool: fix some errors in html api

2023-08-01 Thread Rma Ma
Hi, I know, it's a simple, no-impact patch for dpdk functionality. However, this can be misleading for app programs. When the return value of the interface is judged against -ENOENT, this will cause the program to error out. It also affects the presentation of the api documentation: https://doc.d

Re: [[PATCH v1] 1/8] net/rnp: add skeleton

2023-08-01 Thread Stephen Hemminger
On Tue, 1 Aug 2023 07:21:38 + Wenbo Cao wrote: > +Mucse rnp > +M: caowe...@mucse.com > +F: drivers/net/rnp > +F: doc/guides/nics/rnp.rst > +F: doc/guides/nics/features/rnp.ini Please use the full email address for the M: line. > diff --git a/drivers/net/meson.build b/drivers/net/meson.bui

RE: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

2023-08-01 Thread 11
Hi Stephen, Thanks for your comment, as your advice that I need to define the virtual function pointers As the below type ? const struct rnp_mbx_api { .. } If It will protect the virtual function address ,won't be remove by mistake? Regards Wenbo -Original Message- From: Stephen Hemminger

Re: [PATCH] app/testpmd: add flush multicast MAC address command

2023-08-01 Thread huangdengdui
在 2023/8/1 23:18, Stephen Hemminger 写道: > On Tue, 1 Aug 2023 10:43:04 +0800 > Dengdui Huang wrote: > >> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c >> index 0d0723f659..2d9d925776 100644 >> --- a/app/test-pmd/cmdline.c >> +++ b/app/test-pmd/cmdline.c >> @@ -494,6 +494,9 @@ sta

[PATCH v2] cmdline: remove cmdline_poll()

2023-08-01 Thread Stephen Hemminger
The API functions cmdline_poll() was unused by any project, untested, and buggy. Remove it from 23.11 release. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- doc/guides/rel_notes/release_23_11.rst | 1 + lib/cmdline/cmdline.c | 34 - lib/cmdline/cm

Re: [PATCH v4] build: update DPDK to use C11 standard

2023-08-01 Thread Patrick Robb
On Tue, Aug 1, 2023 at 12:20 PM Tyler Retzlaff wrote: > > yes, support is being dropped for RHEL 7 > > http://mails.dpdk.org/archives/dev/2023-February/263516.html > > it seems like now that we are in 23.11 merge window the CI pipelines for > the unsupported targets can be decomissioned? > > > >

Re: [PATCH v2 0/4] eal: update public API to use stdatomic atomics

2023-08-01 Thread Tyler Retzlaff
top post just a heads up on this series, please defer review until v3 is submitted. clang is stricter in atomic type enforcement than gcc so a new revision is needed that removes the direct use of intrinsics replacing them with the standard atomics for all _Atomic types. thanks On Mon, Jul 31,

Re: [PATCH v4] build: update DPDK to use C11 standard

2023-08-01 Thread Tyler Retzlaff
On Tue, Aug 01, 2023 at 04:50:45PM +0100, Bruce Richardson wrote: > On Tue, Aug 01, 2023 at 03:47:03PM +, Ali Alnubani wrote: > > > -Original Message- > > > From: Bruce Richardson > > > Sent: Tuesday, August 1, 2023 4:16 PM > > > To: dev@dpdk.org > > > Cc: Bruce Richardson ; Morten Brø

Re: [PATCH] lib/ethdev: sanity check on callback before resource allocation

2023-08-01 Thread Stephen Hemminger
On Tue, 11 Jul 2023 01:18:09 + Kaiyu Zhang wrote: > sanity check is performed after a rte_eth_dev object is allocated. > The object is not freed if the check fails, though in the current > reality this never happens, but it's better programming paradigm > to move the quick check up front to t

[PATCH v2 1/2] flow_classify: remove library

2023-08-01 Thread Stephen Hemminger
The flow_classify library was marked for removal last year because there was no maintainer and the functionality is limited. Signed-off-by: Stephen Hemminger --- MAINTAINERS | 7 - app/test/meson.build | 4 - app/test/test_flow_class

[PATCH v2 0/2] Remove disabled functionality

2023-08-01 Thread Stephen Hemminger
The KNI and flow_classify library were already marked disabled in 23.11 release. Stephen Hemminger (2): flow_classify: remove library kni: remove deprecated kernel network interface MAINTAINERS | 17 - app/test/meson.build | 6 -

Re: [PATCH v4] build: update DPDK to use C11 standard

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 03:47:03PM +, Ali Alnubani wrote: > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, August 1, 2023 4:16 PM > > To: dev@dpdk.org > > Cc: Bruce Richardson ; Morten Brørup > > ; Tyler Retzlaff > > > > Subject: [PATCH v4] build: update DPDK to us

RE: [PATCH v4] build: update DPDK to use C11 standard

2023-08-01 Thread Ali Alnubani
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, August 1, 2023 4:16 PM > To: dev@dpdk.org > Cc: Bruce Richardson ; Morten Brørup > ; Tyler Retzlaff > > Subject: [PATCH v4] build: update DPDK to use C11 standard > > As previously announced, DPDK 23.11 will require a C11 sup

RE: [PATCH] net/mlx5: fix leak in sysfs port name translation

2023-08-01 Thread Bing Zhao
Hi David, Thanks for catching this. BR. Bing > -Original Message- > From: David Marchand > Sent: Tuesday, August 1, 2023 11:19 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Suanming Mou > ; Bing Zhao > Subject: [PATCH] net/mlx5: fix leak in sy

Re: [[PATCH v1] 4/8] net/rnp: add mbx basic api feature

2023-08-01 Thread Stephen Hemminger
On Tue, 1 Aug 2023 07:22:07 + Wenbo Cao wrote: > +struct rnp_mbx_api { > + void (*init_mbx)(struct rnp_hw *hw); > + int32_t (*read)(struct rnp_hw *hw, > + uint32_t *msg, > + uint16_t size, > + enum MBX_ID); > + int32_t (

Re: [PATCH v2] eventdev/eth_rx: update adapter create APIs

2023-08-01 Thread Jerin Jacob
On Tue, Aug 1, 2023 at 7:22 PM Naga Harish K S V wrote: > > The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and > rte_event_eth_rx_adapter_create() are updated to take additional argument > as a pointer of type struct rte_event_eth_rx_adapter_params. > > The API rte_event_eth

Re: [[PATCH v1] 3/8] net/rnp: add device init and uninit

2023-08-01 Thread Stephen Hemminger
On Tue, 1 Aug 2023 06:43:41 + Wenbo Cao wrote: > + return 0; > +eth_alloc_error: > +init_failed: Why have two labels for same place, to later patches insert code here?

[PATCH] net/mlx5: fix leak in sysfs port name translation

2023-08-01 Thread David Marchand
getline() may allocate a buffer even though it returns -1: """ If *lineptr is set to NULL before the call, then getline() will allocate a buffer for storing the line. This buffer should be freed by the user program even if getline() failed. """ This leak has been observed on a RHEL8 system with

Re: [PATCH] app/testpmd: add flush multicast MAC address command

2023-08-01 Thread Stephen Hemminger
On Tue, 1 Aug 2023 10:43:04 +0800 Dengdui Huang wrote: > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 0d0723f659..2d9d925776 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -494,6 +494,9 @@ static void cmd_help_long_parsed(void *parsed_result, >

Re: [PATCH v2] build: check drivers class dependencies early

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 03:41:33PM +0200, David Marchand wrote: > Drivers implementing a class of devices (for example, drivers/event) > depend on the associated abstraction library (lib/eventdev). > This dependency is expressed in the top level meson.build for this class > (drivers/event/meson.bui

RE: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Ali Alnubani
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, August 1, 2023 1:37 PM > To: Patrick Robb ; Bruce Richardson > ; Ali Alnubani > Cc: Tyler Retzlaff ; dev@dpdk.org; Morten > Brørup ; david.march...@redhat.com; > Raslan Darawsheh > Subject: Re: [PATCH v3] build: update DPDK to

Re: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Bruce Richardson
+David Christensen On Tue, Aug 01, 2023 at 01:47:19PM +, Ali Alnubani wrote: > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, August 1, 2023 4:22 PM > > To: Ali Alnubani > > Cc: David Marchand ; Patrick Robb > > ; Tyler Retzlaff ; > > dev@dpdk.org; Morten Brørup ;

[PATCH v2] eventdev/eth_rx: update adapter create APIs

2023-08-01 Thread Naga Harish K S V
The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and rte_event_eth_rx_adapter_create() are updated to take additional argument as a pointer of type struct rte_event_eth_rx_adapter_params. The API rte_event_eth_rx_adapter_create_with_params() is deprecated. Signed-off-by: Naga

RE: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Ali Alnubani
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, August 1, 2023 4:22 PM > To: Ali Alnubani > Cc: David Marchand ; Patrick Robb > ; Tyler Retzlaff ; > dev@dpdk.org; Morten Brørup ; NBU- > Contact-Thomas Monjalon (EXTERNAL) > Subject: Re: [PATCH v3] build: update DPDK to use

[PATCH v2] build: check drivers class dependencies early

2023-08-01 Thread David Marchand
Drivers implementing a class of devices (for example, drivers/event) depend on the associated abstraction library (lib/eventdev). This dependency is expressed in the top level meson.build for this class (drivers/event/meson.build). As we are making more libraries optional, custom constructs refere

Re: [PATCH v4] build: update DPDK to use C11 standard

2023-08-01 Thread David Marchand
On Tue, Aug 1, 2023 at 3:29 PM Bruce Richardson wrote: > > On Tue, Aug 01, 2023 at 03:24:19PM +0200, David Marchand wrote: > > On Tue, Aug 1, 2023 at 3:16 PM Bruce Richardson > > wrote: > > > > > > As previously announced, DPDK 23.11 will require a C11 supporting > > > compiler and will use the C

Re: [PATCH v4] build: update DPDK to use C11 standard

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 03:24:19PM +0200, David Marchand wrote: > On Tue, Aug 1, 2023 at 3:16 PM Bruce Richardson > wrote: > > > > As previously announced, DPDK 23.11 will require a C11 supporting > > compiler and will use the C11 standard in all builds. > > > > Forcing use of the C standard, rath

Re: [PATCH v4] build: update DPDK to use C11 standard

2023-08-01 Thread David Marchand
On Tue, Aug 1, 2023 at 3:16 PM Bruce Richardson wrote: > > As previously announced, DPDK 23.11 will require a C11 supporting > compiler and will use the C11 standard in all builds. > > Forcing use of the C standard, rather than the standard with > GNU extensions, means that some posix definitions

Re: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 12:42:36PM +, Ali Alnubani wrote: > > On Ubuntu 20.04 while cross compiling for ppc64le with > powerpc64le-linux-gnu-gcc 9.4, I see: > > [..] > lib/acl/acl_run_altivec.h:44:16: error: two or more data types in declaration > specifiers > [..] > lib/acl/acl_run_altive

[PATCH v4] build: update DPDK to use C11 standard

2023-08-01 Thread Bruce Richardson
As previously announced, DPDK 23.11 will require a C11 supporting compiler and will use the C11 standard in all builds. Forcing use of the C standard, rather than the standard with GNU extensions, means that some posix definitions which are not in the C standard are unavailable by default. We fix

Re: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 12:42:36PM +, Ali Alnubani wrote: > > -Original Message- > > From: Bruce Richardson > > Sent: Tuesday, August 1, 2023 1:51 PM > > To: David Marchand > > Cc: Patrick Robb ; Tyler Retzlaff > > ; dev@dpdk.org; Morten Brørup > > ; NBU-Contact-Thomas Monjalon > > (E

RE: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Ali Alnubani
> -Original Message- > From: Bruce Richardson > Sent: Tuesday, August 1, 2023 1:51 PM > To: David Marchand > Cc: Patrick Robb ; Tyler Retzlaff > ; dev@dpdk.org; Morten Brørup > ; NBU-Contact-Thomas Monjalon > (EXTERNAL) > Subject: Re: [PATCH v3] build: update DPDK to use C11 standard >

Marvell DPDK 23.11 Roadmap

2023-08-01 Thread Jerin Jacob Kollanukkaran
Marvell - DPDK v23.11 Roadmap for non-driver changes === cryptodev = 1) Support for cryptodev to inject packets to ethdev Rx. On capable devices, this would help in using ethdev Rx offloads (like inline reassembly, inner packet parsing) after c

RE: [PATCH] build: check drivers class dependencies early

2023-08-01 Thread Morten Brørup
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Tuesday, 1 August 2023 12.49 > > > From: David Marchand [mailto:david.march...@redhat.com] > > Sent: Tuesday, 1 August 2023 12.21 > > > > On Tue, Aug 1, 2023 at 11:25 AM Bruce Richardson > > wrote: > > > > > > On Tue, Aug 01, 2023

Re: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 11:39:06AM +0100, Bruce Richardson wrote: > On Tue, Aug 01, 2023 at 12:35:21PM +0200, David Marchand wrote: > > On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson > > wrote: > > > > > > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: > > > >Hi Bruce, > > > >

RE: [PATCH] build: check drivers class dependencies early

2023-08-01 Thread Morten Brørup
> From: David Marchand [mailto:david.march...@redhat.com] > Sent: Tuesday, 1 August 2023 12.21 > > On Tue, Aug 1, 2023 at 11:25 AM Bruce Richardson > wrote: > > > > On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote: > > > Drivers implementing a class of devices (for example, drivers/

Re: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 12:35:21PM +0200, David Marchand wrote: > On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson > wrote: > > > > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: > > >Hi Bruce, > > >I see some failures for this series for our Ubuntu 20.04 containers. > > >

Re: Threads using mempools

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 10:21:16AM +, Dumitrescu, Cristian wrote: >Hi folks, > > >Is there a way in DPDK to create a POSIX thread in the driver/app and >hook it up to an existing mempool by creating a mempool cache on the >fly for this thread? > > >The regular RTE lcores

Re: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Thomas Monjalon
01/08/2023 12:19, Bruce Richardson: > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: > >Hi Bruce, > >I see some failures for this series for our Ubuntu 20.04 containers. > >And, our DTS testbeds which are on ubuntu 20.04 are skipping running > >testsuites because they

Re: [PATCH] build: check drivers class dependencies early

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 12:20:47PM +0200, David Marchand wrote: > On Tue, Aug 1, 2023 at 11:25 AM Bruce Richardson > wrote: > > > > On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote: > > > Drivers implementing a class of devices (for example, drivers/event) > > > depend on the associa

Re: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread David Marchand
On Tue, Aug 1, 2023 at 12:19 PM Bruce Richardson wrote: > > On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: > >Hi Bruce, > >I see some failures for this series for our Ubuntu 20.04 containers. > >And, our DTS testbeds which are on ubuntu 20.04 are skipping running > >

[[PATCH v1] 7/8] net/rnp add devargs runtime parsing functions

2023-08-01 Thread Wenbo Cao
add various runtime devargs command line options supported by this driver. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp.h| 22 + drivers/net/rnp/rnp_ethdev.c | 164 +++ drivers/net/rnp/rnp_mbx_fw.c | 164 +++ driver

[[PATCH v1] 6/8] net/rnp add port info resource init

2023-08-01 Thread Wenbo Cao
Add Api For FW Mac Info, Port Resoucre info init Code For Different Shape Of Nic Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_api.c | 47 +++ drivers/net/rnp/base/rnp_api.h | 10 ++ drivers/net/rnp/base/rnp_hw.h | 19 +++ drivers/net/rnp/meson.build| 1 + drivers/net/rnp/r

[[PATCH v1] 5/8] net/rnp add reset code for Chip Init process

2023-08-01 Thread Wenbo Cao
we must get the shape info of nic from Firmware for reset. so the related codes is first get firmware info and then reset the chip Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_api.c | 24 +++ drivers/net/rnp/base/rnp_api.h | 7 + drivers/net/rnp/base/rnp_cfg.h | 7 +

[[PATCH v1] 3/8] net/rnp: add device init and uninit

2023-08-01 Thread Wenbo Cao
Add basic init and uninit function Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 18 drivers/net/rnp/meson.build | 1 + drivers/net/rnp/rnp.h | 25 + drivers/net/rnp/rnp_ethdev.c | 197 +- drivers/net/rnp/rnp_logs.h| 34

[[PATCH v1] 2/8] net/rnp: add ethdev probe and remove

2023-08-01 Thread Wenbo Cao
Add basic PCIe ethdev probe and remove. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp.h| 13 ++ drivers/net/rnp/rnp_ethdev.c | 83 2 files changed, 96 insertions(+) create mode 100644 drivers/net/rnp/rnp.h diff --git a/drivers/net/rnp/rnp.h b

[[PATCH v1] 4/8] net/rnp: add mbx basic api feature

2023-08-01 Thread Wenbo Cao
mbx base code is for communicate with the firmware Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 107 ++- drivers/net/rnp/meson.build | 1 + drivers/net/rnp/rnp.h | 35 +++ drivers/net/rnp/rnp_ethdev.c | 68 + drivers/net/rnp/rnp_logs.h| 9 + drivers/n

[[PATCH v1] 1/8] net/rnp: add skeleton

2023-08-01 Thread Wenbo Cao
Add Basic PMD library and doc build infrastructure Update maintainers file to claim responsibility. Signed-off-by: Wenbo Cao --- MAINTAINERS | 6 + doc/guides/nics/features/rnp.ini | 8 ++ doc/guides/nics/index.rst| 1 + doc/guides/nics/rnp.rst |

[[PATCH v1] 0/8] *** SUBJECT HERE ***

2023-08-01 Thread Wenbo Cao
*** BLURB HERE *** Wenbo Cao (8): net/rnp: add skeleton net/rnp: add ethdev probe and remove net/rnp: add device init and uninit net/rnp: add mbx basic api feature net/rnp add reset code for Chip Init process net/rnp add port info resource init net/rnp add devargs runtime parsing fun

Re: [RFC] eventdev/eth_rx: update adapter create APIs

2023-08-01 Thread Jerin Jacob
On Tue, Aug 1, 2023 at 3:10 PM Naga Harish K S V wrote: > > The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and > rte_event_eth_rx_adapter_create() are updated to take additional argument > as a pointer of type struct rte_event_eth_rx_adapter_params. Please avod API prototyp

Threads using mempools

2023-08-01 Thread Dumitrescu, Cristian
Hi folks, Is there a way in DPDK to create a POSIX thread in the driver/app and hook it up to an existing mempool by creating a mempool cache on the fly for this thread? The regular RTE lcores and service cores seem to be the only threads that have access to mempools, is my observation correct

Re: [PATCH] build: check drivers class dependencies early

2023-08-01 Thread David Marchand
On Tue, Aug 1, 2023 at 11:25 AM Bruce Richardson wrote: > > On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote: > > Drivers implementing a class of devices (for example, drivers/event) > > depend on the associated abstraction library (lib/eventdev). > > This dependency is expressed in

Re: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Bruce Richardson
On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: >Hi Bruce, >I see some failures for this series for our Ubuntu 20.04 containers. >And, our DTS testbeds which are on ubuntu 20.04 are skipping running >testsuites because they can't compile DPDK. So, that's why it has som

[RFC] Rx adapter create API changes

2023-08-01 Thread Naga Harish K, S V
Hi all, The API "rte_event_eth_rx_adapter_create_with_params()" is an extension to rte_event_eth_rx_adapter_create() with additional adapter configuration params structure. There is no equivalent API existing today for "rte_event_eth_rx_adapter_create_ext()" API. We may need to have one more a

[RFC] eventdev/eth_rx: update adapter create APIs

2023-08-01 Thread Naga Harish K S V
The adapter create APIs such as rte_event_eth_rx_adapter_create_ext() and rte_event_eth_rx_adapter_create() are updated to take additional argument as a pointer of type struct rte_event_eth_rx_adapter_params. The API rte_event_eth_rx_adapter_create_with_params() is deprecated. Signed-off-by: Naga

Re: [PATCH] build: check drivers class dependencies early

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 10:52:53AM +0200, David Marchand wrote: > Drivers implementing a class of devices (for example, drivers/event) > depend on the associated abstraction library (lib/eventdev). > This dependency is expressed in the top level meson.build for this class > (drivers/event/meson.bui

Re: [PATCH v3] build: update DPDK to use C11 standard

2023-08-01 Thread Bruce Richardson
On Mon, Jul 31, 2023 at 08:39:31PM -0400, Patrick Robb wrote: >Hi Bruce, >I see some failures for this series for our Ubuntu 20.04 containers. >And, our DTS testbeds which are on ubuntu 20.04 are skipping running >testsuites because they can't compile DPDK. So, that's why it has som

Re: [PATCH v4 2/9] event/dlb2: skip configuration if no eventdev lib

2023-08-01 Thread Bruce Richardson
On Tue, Aug 01, 2023 at 10:36:30AM +0200, David Marchand wrote: > Hello Bruce, > > On Tue, Jul 18, 2023 at 11:10 AM Bruce Richardson > wrote: > > > > On Thu, Jun 29, 2023 at 11:39:53AM +0200, David Marchand wrote: > > > On Wed, Jun 28, 2023 at 12:19 PM David Marchand > > > wrote: > > > > > > > >

Re: Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

2023-08-01 Thread David Marchand
On Tue, Aug 1, 2023 at 10:09 AM 曹文博 wrote: > Thanks for your advice, as you can see this is first time that send the patch > :(. No problem, everyone had to learn how to do this in the past. There is an issue with threading the patches together. You should read the contributors guide and check

[PATCH] build: check drivers class dependencies early

2023-08-01 Thread David Marchand
Drivers implementing a class of devices (for example, drivers/event) depend on the associated abstraction library (lib/eventdev). This dependency is expressed in the top level meson.build for this class (drivers/event/meson.build). As we are making more libraries optional, custom constructs refere

[PATCH 1/1] node: remove MAX macro from all nodes

2023-08-01 Thread Rakesh Kudurumalla
Removed MAX macro from all graph nodes to extend edges to nodes at ease Signed-off-by: Rakesh Kudurumalla --- v2: Update changes to TOT and resolve dependecy related issues lib/node/ip4_lookup.c | 2 +- lib/node/ip6_lookup.c | 2 +- lib/node/rte_node_ip4_api.h | 2 -- lib/node

Re: [PATCH v4 2/9] event/dlb2: skip configuration if no eventdev lib

2023-08-01 Thread David Marchand
Hello Bruce, On Tue, Jul 18, 2023 at 11:10 AM Bruce Richardson wrote: > > On Thu, Jun 29, 2023 at 11:39:53AM +0200, David Marchand wrote: > > On Wed, Jun 28, 2023 at 12:19 PM David Marchand > > wrote: > > > > > > On Fri, Jun 23, 2023 at 5:07 PM Bruce Richardson > > > wrote: > > > > > > > > Whil

[PATCH] security: hide security context

2023-08-01 Thread Akhil Goyal
rte_security_ctx is used by all security APIs to identify which device security_op it need to call and hence it should be opaque to the application. Hence, it is now moved to internal header file and all APIs will now take an opaque pointer for it. The fast path inline APIs like set metadata need t

回复:Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

2023-08-01 Thread 曹文博
Hi David, Thanks for your advice, as you can see this is first time that send the patch :(. For nic feature/cap, what is the right thing that i need to do ? Describe on the cover letter or that on the doc/guides/nics/features/rnp.ini. regards Wenbo --回复的邮件信息--

Re: [[PATCH v1] 0/8] *** SUBJECT HERE ***

2023-08-01 Thread David Marchand
Hello Wenbo, On Tue, Aug 1, 2023 at 9:21 AM Wenbo Cao wrote: > > *** BLURB HERE *** I think you hit the "send" button too early, adding a new net driver deserves a better cover letter :-). Please provide some high level description of this driver features and the nic details/capabilities. Also,

Re: [PATCH] flow_classify: remove library

2023-08-01 Thread David Marchand
Hello, On Mon, Jul 31, 2023 at 10:45 PM Stephen Hemminger wrote: > > The flow_classify library was marked for removal last year > because there was no maintainer and the functionality is > limited. > > Signed-off-by: Stephen Hemminger > --- > MAINTAINERS | 7

Re: [PATCH v2] kni: remove deprecated kernel network interface

2023-08-01 Thread David Marchand
Hello Stephen, While rebasing, please also fix those nits: On Sun, Jul 30, 2023 at 4:12 AM Stephen Hemminger wrote: > diff --git a/doc/guides/contributing/documentation.rst > b/doc/guides/contributing/documentation.rst > index 7fcbb7fc43b2..f16c94e9768b 100644 > --- a/doc/guides/contributing/do

RE: [PATCH v2 0/4] eal: update public API to use stdatomic atomics

2023-08-01 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Tuesday, 1 August 2023 07.04 > > Update EAL public API to use standard C11 atomics. In accordance with > technical board discussion February 2023. > http://mails.dpdk.org/archives/dev/2023-February/263516.html > > This initial s

[[PATCH v1] 7/8] net/rnp add devargs runtime parsing functions

2023-08-01 Thread Wenbo Cao
add various runtime devargs command line options supported by this driver. Signed-off-by: Wenbo Cao --- drivers/net/rnp/rnp.h| 22 + drivers/net/rnp/rnp_ethdev.c | 164 +++ drivers/net/rnp/rnp_mbx_fw.c | 164 +++ driver

[[PATCH v1] 6/8] net/rnp add port info resource init

2023-08-01 Thread Wenbo Cao
Add Api For FW Mac Info, Port Resoucre info init Code For Different Shape Of Nic Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_api.c | 47 +++ drivers/net/rnp/base/rnp_api.h | 10 ++ drivers/net/rnp/base/rnp_hw.h | 19 +++ drivers/net/rnp/meson.build| 1 + drivers/net/rnp/r

[[PATCH v1] 5/8] net/rnp add reset code for Chip Init process

2023-08-01 Thread Wenbo Cao
we must get the shape info of nic from Firmware for reset. so the related codes is first get firmware info and then reset the chip Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_api.c | 24 +++ drivers/net/rnp/base/rnp_api.h | 7 + drivers/net/rnp/base/rnp_cfg.h | 7 +

[[PATCH v1] 3/8] net/rnp: add device init and uninit

2023-08-01 Thread Wenbo Cao
Add basic init and uninit function Signed-off-by: Wenbo Cao --- drivers/net/rnp/base/rnp_hw.h | 18 drivers/net/rnp/meson.build | 1 + drivers/net/rnp/rnp.h | 25 + drivers/net/rnp/rnp_ethdev.c | 197 +- drivers/net/rnp/rnp_logs.h| 34

  1   2   >