Event device early back-pressure indication

2023-04-12 Thread Mattias Rönnblom
Hi. Consider this situation: An application EAL thread receives an eventdev event (or some other stimuli), which in turn triggers some action. This action results in a number of new events being prepared, and a number of associated state changes in the application. On attempting to enqueue th

Re: [PATCH v1 1/2] dts: fabric requirements

2023-04-12 Thread Juraj Linkeš
On Wed, Apr 12, 2023 at 5:38 PM Honnappa Nagarahalli wrote: > > > > > -Original Message- > > From: Thomas Monjalon > > Sent: Wednesday, April 12, 2023 10:25 AM > > To: Juraj Linkeš > > Cc: Wathsala Wathawana Vithanage ; > > jspew...@iol.unh.edu; pr...@iol.unh.edu; Honnappa Nagarahalli >

Re: [PATCH] dmadev: add tracepoints

2023-04-12 Thread fengchengwen
On 2023/4/12 19:00, Morten Brørup wrote: >> From: Chengwen Feng [mailto:fengcheng...@huawei.com] >> Sent: Wednesday, 12 April 2023 04.48 >> >> Add tracepoints at important APIs for tracing support. >> >> Signed-off-by: Chengwen Feng >> --- > ... >> +) >> + >> +RTE_TRACE_POINT( >> +rte_dma_t

[PATCH 10/10] net/gve: support jumbo frame for GQI

2023-04-12 Thread Junfeng Guo
Add multi-segment support to enable GQI Rx Jumbo Frame. Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Junfeng Guo Signed-off-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.h | 8 ++ drivers/net/gve/gve_rx.c | 137 +-- 2 f

[PATCH 09/10] net/gve: add maintainers for GVE

2023-04-12 Thread Junfeng Guo
Add maintainers from Google for GVE. Signed-off-by: Junfeng Guo Signed-off-by: Rushil Gupta --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8df23e5099..08001751b0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -713,6 +713,9 @@ F: doc/guides/

[PATCH 08/10] net/gve: enable Tx checksum offload for DQO

2023-04-12 Thread Junfeng Guo
Enable Tx checksum offload once any flag of L4 checksum is set. Signed-off-by: Junfeng Guo Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.h | 4 drivers/net/gve/gve_tx_dqo.c | 5 + 2 files changed, 9 insertio

[PATCH 07/10] net/gve: support basic stats for DQO

2023-04-12 Thread Junfeng Guo
Add basic stats support for DQO. Signed-off-by: Junfeng Guo Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.c | 5 - drivers/net/gve/gve_rx_dqo.c | 14 +- drivers/net/gve/gve_tx_dqo.c | 7 +++ 3 f

[PATCH 06/10] net/gve: support basic Rx data path for DQO

2023-04-12 Thread Junfeng Guo
Add basic Rx data path support for DQO. Signed-off-by: Junfeng Guo Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.c | 1 + drivers/net/gve/gve_ethdev.h | 3 + drivers/net/gve/gve_rx_dqo.c | 128 +++

[PATCH 05/10] net/gve: support basic Tx data path for DQO

2023-04-12 Thread Junfeng Guo
Add basic Tx data path support for DQO. Signed-off-by: Junfeng Guo Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.c | 1 + drivers/net/gve/gve_ethdev.h | 4 + drivers/net/gve/gve_tx_dqo.c | 141 +++

[PATCH 04/10] net/gve: support queue release and stop for DQO

2023-04-12 Thread Junfeng Guo
Add support for queue operations: - gve_tx_queue_release_dqo - gve_rx_queue_release_dqo - gve_stop_tx_queues_dqo - gve_stop_rx_queues_dqo Signed-off-by: Junfeng Guo Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.c

[PATCH 03/10] net/gve: support device start and close for DQO

2023-04-12 Thread Junfeng Guo
Add device start and close support for DQO. Signed-off-by: Junfeng Guo Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.c | 43 +++- 1 file changed, 42 insertions(+), 1 deletion(-) diff

[PATCH 02/10] net/gve: add Rx queue setup for DQO

2023-04-12 Thread Junfeng Guo
Add support for rx_queue_setup_dqo ops. Signed-off-by: Junfeng Guo Signed-off-by: Rushil Gupta Signed-off-by: Joshua Washington Signed-off-by: Jeroen de Borst --- drivers/net/gve/gve_ethdev.c | 1 + drivers/net/gve/gve_ethdev.h | 11 +++ drivers/net/gve/gve_rx_dqo.c | 156 +

[PATCH 01/10] net/gve: add Tx queue setup for DQO

2023-04-12 Thread Junfeng Guo
Add support for tx_queue_setup_dqo ops. DQO format has submission and completion queue pair for each Tx/Rx queue. Note that with DQO format all descriptors and doorbells, as well as counters are written in little-endian. Signed-off-by: Junfeng Guo Signed-off-by: Rushil Gupta Signed-off-by: Josh

[PATCH 00/10] gve PMD enhancement

2023-04-12 Thread Junfeng Guo
This patch set includs two main enhancements for gve PMD: - support basic data path with DQO queue format - support jumbo frame with GQI queue format This patch set is based on this: patchwork.dpdk.org/project/dpdk/list/?series=27653&state=* Junfeng Guo (10): net/gve: add Tx queue setup for D

RE: 21.11.4 patches review and test

2023-04-12 Thread Xu, HailinX
> -Original Message- > From: Kevin Traynor > Sent: Thursday, April 6, 2023 7:38 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; Walker, Benjamin > ; David Christensen ; > Hemant Agrawal ; Stokes, Ian > ; Jerin Jacob ; Mcnamara, John > ; Ju-Hyoung Lee ; Kevi

[PATCH 4/4] net/iavf: enable UDP fragmentation offload

2023-04-12 Thread Zhichao Zeng
This commit enables transmit segmentation offload for UDP, including both non-tunneled and tunneled packets. The command "tso set " or "tunnel_tso set " is used to enable UFO. Signed-off-by: Zhichao Zeng --- drivers/net/iavf/iavf_rxtx.c | 2 +- drivers/net/iavf/iavf_rxtx.h | 2 ++ 2 files cha

[PATCH 3/4] net/ice: enable UDP fragmentation offload

2023-04-12 Thread Zhichao Zeng
This commit enables transmit segmentation offload for UDP, including both non-tunneled and tunneled packets. The command "tso set " or "tunnel_tso set " is used to enable UFO. Signed-off-by: Zhichao Zeng --- drivers/net/ice/ice_rxtx.c | 15 --- 1 file changed, 12 insertions(+), 3

[PATCH 2/4] app/testpmd: support UFO in checksum engine

2023-04-12 Thread Zhichao Zeng
This commit supports UFO for both non-tunnel and tunneled packets. Similar to TSO, the command "tso set " or "tunnel_tso set " is used to enable UFO, and the following conditions need to be met: a. The NIC supports UFO; b. For enabling UFO in tunnel packets, "csum parse_tunnel" must be set to

[PATCH 1/4] net: calculate correct UDP pseudo header for UFO

2023-04-12 Thread Zhichao Zeng
This commit calculates the correct pseudo header for the UDP fragmentation offload by adding UDP_SEG flag. Signed-off-by: Zhichao Zeng --- lib/net/rte_ip.h | 4 ++-- lib/net/rte_net.h | 5 +++-- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/net/rte_ip.h b/lib/net/rte_ip.h i

[PATCH 0/4] support UDP fragmentation offload

2023-04-12 Thread Zhichao Zeng
This patch set supports UDP fragmentation offload for ice and iavf. Zhichao Zeng (4): net: calculate correct UDP pseudo header for UFO app/testpmd: support UFO in checksum engine net/ice: enable UDP fragmentation offload net/iavf: enable UDP fragmentation offload app/test-pmd/csumonly.c

Re: [PATCH] dmadev: add tracepoints

2023-04-12 Thread fengchengwen
On 2023/4/12 17:52, Bruce Richardson wrote: > On Wed, Apr 12, 2023 at 02:48:08AM +, Chengwen Feng wrote: >> Add tracepoints at important APIs for tracing support. >> >> Signed-off-by: Chengwen Feng >> --- >> lib/dmadev/meson.build | 2 +- >> lib/dmadev/rte_dmadev.c

[Bug 1215] Hotplug sigbus handler is using signal unsafe calls

2023-04-12 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1215 Bug ID: 1215 Summary: Hotplug sigbus handler is using signal unsafe calls Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: m

[PATCH v2] net/mlx5: fix lro update tcp header cksum error

2023-04-12 Thread jiangheng (G)
The variable csum is the sum of three 16 bits integers, the max value is 0x2FFFD. The corner case of sum of 3 is 0x1 gives the wrong result: 0x1 + 0x = 0x1, the upper 16 bits are not 0. It must be folded again to ensure that the upper 16 bits are 0. Fixes: e4c2a16eb1de ("net/mlx5: hand

RE: [PATCH v5] enhance NUMA affinity heuristic

2023-04-12 Thread You, KaisenX
> -Original Message- > From: You, KaisenX > Sent: 2023年3月9日 9:58 > To: Thomas Monjalon > Cc: dev@dpdk.org; Zhou, YidingX ; > david.march...@redhat.com; Matz, Olivier ; > ferruh.yi...@amd.com; zhou...@loongson.cn; sta...@dpdk.org; > Richardson, Bruce ; jer...@marvell.com; > Burakov, Anat

RE: [PATCH] doc: fix event timer adapter guide

2023-04-12 Thread Carrillo, Erik G
> -Original Message- > From: pbhagavat...@marvell.com > Sent: Friday, April 7, 2023 3:14 AM > To: jer...@marvell.com; Carrillo, Erik G > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH] doc: fix event timer adapter guide > > From: Pavan Nikhilesh > > Remove incorrect spec definiti

RE: [PATCH v2] eventdev/timer: fix timeout event wait behavior

2023-04-12 Thread Carrillo, Erik G
> -Original Message- > From: Shijith Thotton > Sent: Tuesday, March 21, 2023 12:20 AM > To: Carrillo, Erik G ; jer...@marvell.com > Cc: Shijith Thotton ; dev@dpdk.org; > pbhagavat...@marvell.com; sta...@dpdk.org > Subject: [PATCH v2] eventdev/timer: fix timeout event wait behavior > > Imp

[PATCH] eventdev/timer: move buffer flush call

2023-04-12 Thread Erik Gabriel Carrillo
The SW event timer adapter attempts to flush its event buffer on every adapter tick. If events remain in the buffer after the attempt, another attempt to flush won't occur until the next adapter tick, which delays the enqueue of those events to the event device unecessarily. Move the buffer flush

RE: [RFC 00/27] Add VDUSE support to Vhost library

2023-04-12 Thread Morten Brørup
> From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, 12 April 2023 17.28 > > Hi Ferruh, > > On 4/12/23 13:33, Ferruh Yigit wrote: > > On 3/31/2023 4:42 PM, Maxime Coquelin wrote: > >> This series introduces a new type of backend, VDUSE, > >> to the Vhost library. > >> >

RE: [PATCH v2] common/mlx5: enable operation in iova virtual address mode

2023-04-12 Thread Morten Brørup
> From: Viacheslav Ovsiienko [mailto:viachesl...@nvidia.com] > Sent: Wednesday, 12 April 2023 19.07 > > The ConnectX NIC series hardware provides advanced internal > MMU option and can operate directly over virtual addresses, > the host software should not care about any virtual-to-physical > addr

RE: [PATCH] eal: choose IOVA mode according to compilation flags

2023-04-12 Thread Morten Brørup
> From: Viacheslav Ovsiienko [mailto:viachesl...@nvidia.com] > Sent: Wednesday, 12 April 2023 19.20 > > The DPDK can be compiled to be run in IOVA VA mode with > 'enable_iova_as_pa=false' meson option. If there is no > explicit EAL --iova-mode parameter specified in the command > line the rte_eal_

[PATCH v4] app/testpmd: txonly multiflow port change support

2023-04-12 Thread Joshua Washington
Google cloud routes traffic using IP addresses without the support of MAC addresses, so changing source IP address for txonly-multi-flow can have negative performance implications for net/gve when using testpmd. This patch updates txonly multiflow mode to modify source ports instead of source IP ad

Re: [PATCH 1/1] net/gve: update base code for DQO

2023-04-12 Thread Rushil Gupta
Sorry for the confusion. I was talking about the same patch (titled net/gve: update copyright holders); however, I am not able to find it on patchwork. On Wed, Apr 12, 2023 at 9:03 AM Ferruh Yigit wrote: > On 4/12/2023 4:42 PM, Rushil Gupta wrote: > > > > > > On Wed, Apr 12, 2023 at 2:41 AM Guo

Re: [dpdk-dev][dpdk-users] A problem about memory may not be all-zero allocated by rte_zmalloc_socket()

2023-04-12 Thread Stephen Hemminger
On Wed, 23 Feb 2022 15:38:09 + Honnappa Nagarahalli wrote: > I have a question, does the dpdk code implement to ensure that the memory > initialization is 0? > [Ruifeng] Clearing of the memory should be done by the kernel. In section > 3.1.4.6 of Programmer's Guide, it says: " > Hugepages a

[PATCH] eal: choose IOVA mode according to compilation flags

2023-04-12 Thread Viacheslav Ovsiienko
The DPDK can be compiled to be run in IOVA VA mode with 'enable_iova_as_pa=false' meson option. If there is no explicit EAL --iova-mode parameter specified in the command line the rte_eal_init() tried to deduce VA or PA mode without taking into account the above mentioned compile time option, resu

[PATCH v2] common/mlx5: enable operation in iova virtual address mode

2023-04-12 Thread Viacheslav Ovsiienko
The ConnectX NIC series hardware provides advanced internal MMU option and can operate directly over virtual addresses, the host software should not care about any virtual-to-physical address translations. It means the mlx5 PMDs can operate in DPDK IOVA VA (virtual address) mode transparently. To

Re: [PATCH 1/1] net/gve: update base code for DQO

2023-04-12 Thread Ferruh Yigit
On 4/12/2023 4:42 PM, Rushil Gupta wrote: > > > On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng > wrote: > > > > > -Original Message- > > From: Ferruh Yigit > > > Sent: Wednesday, April 12, 2023 17:35 > > To:

Re: [PATCH 1/1] net/gve: update base code for DQO

2023-04-12 Thread Rushil Gupta
On Wed, Apr 12, 2023 at 2:41 AM Guo, Junfeng wrote: > > > > -Original Message- > > From: Ferruh Yigit > > Sent: Wednesday, April 12, 2023 17:35 > > To: Guo, Junfeng ; Richardson, Bruce > > > > Cc: dev@dpdk.org; Zhang, Qi Z ; Rushil Gupta > > > > Subject: Re: [PATCH 1/1] net/gve: update

RE: [PATCH v1 1/2] dts: fabric requirements

2023-04-12 Thread Honnappa Nagarahalli
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, April 12, 2023 10:25 AM > To: Juraj Linkeš > Cc: Wathsala Wathawana Vithanage ; > jspew...@iol.unh.edu; pr...@iol.unh.edu; Honnappa Nagarahalli > ; lijuan...@intel.com; > bruce.richard...@intel.com; dev@dpdk.org > Subject:

Re: [RFC 00/27] Add VDUSE support to Vhost library

2023-04-12 Thread Maxime Coquelin
Hi Ferruh, On 4/12/23 13:33, Ferruh Yigit wrote: On 3/31/2023 4:42 PM, Maxime Coquelin wrote: This series introduces a new type of backend, VDUSE, to the Vhost library. VDUSE stands for vDPA device in Userspace, it enables implementing a Virtio device in userspace and have it attached to the K

Re: [PATCH v1 1/2] dts: fabric requirements

2023-04-12 Thread Thomas Monjalon
12/04/2023 15:42, Juraj Linkeš: > On Tue, Apr 11, 2023 at 4:48 PM Thomas Monjalon wrote: > > > > 04/04/2023 13:51, Juraj Linkeš: > > > On Mon, Apr 3, 2023 at 5:18 PM Thomas Monjalon > > > wrote: > > > > > > > 03/04/2023 16:56, Juraj Linkeš: > > > > > On Mon, Apr 3, 2023 at 2:33 PM Thomas Monjalo

Re: Consult the official release version of dpdk-kmod

2023-04-12 Thread Tyler Retzlaff
On Mon, Apr 10, 2023 at 12:34:28PM +, wangzengyuan wrote: > Hi, > > We are honored to use dpdk and dpdk-kmod, two outstanding open source > softwares. However, according to the company's open source software usage > standards, only officially released versions can be introduced as open sourc

Re: [PATCH v4 06/14] eal: use prefetch intrinsics

2023-04-12 Thread Tyler Retzlaff
On Wed, Apr 12, 2023 at 10:05:57AM +0100, Bruce Richardson wrote: > On Tue, Apr 11, 2023 at 02:12:20PM -0700, Tyler Retzlaff wrote: > > Inline assembly is not supported for MSVC x64 instead use _mm_prefetch > > and _mm_cldemote intrinsics. > > > > Signed-off-by: Tyler Retzlaff > > --- > > Acked-

RE: 20.11.8 patches review and test

2023-04-12 Thread Ali Alnubani
> -Original Message- > From: luca.bocca...@gmail.com > Sent: Friday, March 31, 2023 9:20 PM > To: sta...@dpdk.org > Cc: dev@dpdk.org; Abhishek Marathe ; > Ali Alnubani ; benjamin.wal...@intel.com; David > Christensen ; Hemant Agrawal > ; Ian Stokes ; Jerin > Jacob ; John McNamara ; > Ju-Hy

RE: [PATCH] net/mlx5: fix lro update tcp header cksum error

2023-04-12 Thread Slava Ovsiienko
Hi, Jiangheng You are right, the corner case of sum of 3 is 0x1 gives the wrong result. Could you, please, format the patch according to the rules and send v2 ? - add Fixes: tag with reference to appropriate commit - add Cc: sta...@dpdk.org - fix typos in commit message - capitalize sentence

[PATCH v4] net/sfc: stop misuse of Rx ingress m-port metadata on EF100

2023-04-12 Thread Ivan Malov
The driver supports representor functionality. In it, packets coming from VFs to the dedicated back-end Rx queue get demultiplexed into front-end Rx queues of representor ethdevs as per the per-packet metadata indicating logical HW ingress ports. On transmit, packets are provided with symmetrical m

Re: [PATCH v1 1/2] dts: fabric requirements

2023-04-12 Thread Juraj Linkeš
On Tue, Apr 11, 2023 at 4:48 PM Thomas Monjalon wrote: > > 04/04/2023 13:51, Juraj Linkeš: > > On Mon, Apr 3, 2023 at 5:18 PM Thomas Monjalon wrote: > > > > > 03/04/2023 16:56, Juraj Linkeš: > > > > On Mon, Apr 3, 2023 at 2:33 PM Thomas Monjalon > > > wrote: > > > > > > > > > 03/04/2023 13:46, J

RE: [PATCH] common/mlx5: enable opration in iova virtual address mode

2023-04-12 Thread Morten Brørup
> From: Viacheslav Ovsiienko [mailto:viachesl...@nvidia.com] > Sent: Wednesday, 12 April 2023 14.53 > > The ConnectX NIC series hardware provides the advanced internal > MMU option and can operate directly ob virtual addresses, host > software should not do any virtual-to-physical address translat

RE: NVIDIA mlx5 PMD roadmap question

2023-04-12 Thread Slava Ovsiienko
Hi, Morten Thank you for pointing out this opportunity - to enable IOVA VA mode support in mlx5 drivers. Now we propose this patch: http://patches.dpdk.org/project/dpdk/patch/20230412125320.8585-1-viachesl...@nvidia.com/ The mlx5 hardware has its own MMU facility, no extra efforts are needed to

[PATCH] common/mlx5: enable opration in iova virtual address mode

2023-04-12 Thread Viacheslav Ovsiienko
The ConnectX NIC series hardware provides the advanced internal MMU option and can operate directly ob virtual addresses, host software should not do any virtual-to-physical address translations. It means the mlx5 PMDs can operate in DPDK IOVA VA (virtual address) mode transparently. To force IOVA

RE: [PATCH v4 03/14] eal: use barrier intrinsics

2023-04-12 Thread Konstantin Ananyev
> Inline assembly is not supported for MSVC x64 instead expand > rte_compiler_barrier as _ReadWriteBarrier and for rte_smp_mb > _m_mfence intrinsics. > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/include/generic/rte_atomic.h | 4 > lib/eal/x86/include/rte_atomic.h | 5 - > 2 f

RE: [PATCH v4 06/14] eal: use prefetch intrinsics

2023-04-12 Thread Konstantin Ananyev
> On Tue, Apr 11, 2023 at 02:12:20PM -0700, Tyler Retzlaff wrote: > > Inline assembly is not supported for MSVC x64 instead use _mm_prefetch > > and _mm_cldemote intrinsics. > > > > Signed-off-by: Tyler Retzlaff > > --- > > Acked-by: Bruce Richardson > > One comment inline below for future c

Re: [PATCH v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100

2023-04-12 Thread Ferruh Yigit
On 3/12/2023 10:54 AM, Ivan Malov wrote: > The driver supports representor functionality. In it, > packets coming from VFs to the dedicated back-end Rx > queue get demultiplexed into front-end Rx queues of > representor ethdevs as per the per-packet metadata > indicating logical HW ingress ports. O

[PATCH] net/mlx5: fix lro update tcp header cksum error

2023-04-12 Thread jiangheng (G)
csum is the sum of three 16 bits value it must be folded twice to ensure that the upper 16 bits are 0 --- drivers/net/mlx5/mlx5_rx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_rx.c b/drivers/net/mlx5/mlx5_rx.c index a2be523e9e..ae537dfffa 100644 --- a/drivers/net/mlx

Re: [RFC 00/27] Add VDUSE support to Vhost library

2023-04-12 Thread Ferruh Yigit
On 3/31/2023 4:42 PM, Maxime Coquelin wrote: > This series introduces a new type of backend, VDUSE, > to the Vhost library. > > VDUSE stands for vDPA device in Userspace, it enables > implementing a Virtio device in userspace and have it > attached to the Kernel vDPA bus. > > Once attached to the

RE: [PATCH] dmadev: add tracepoints

2023-04-12 Thread Morten Brørup
> From: Chengwen Feng [mailto:fengcheng...@huawei.com] > Sent: Wednesday, 12 April 2023 04.48 > > Add tracepoints at important APIs for tracing support. > > Signed-off-by: Chengwen Feng > --- [...] > diff --git a/lib/dmadev/rte_dmadev_trace.h b/lib/dmadev/rte_dmadev_trace.h > new file mode 100

RE: [PATCH v4 01/14] eal: use rdtsc intrinsic

2023-04-12 Thread Konstantin Ananyev
> Inline assembly is not supported for MSVC x64. Convert code to use > __rdtsc intrinsic. > > Signed-off-by: Tyler Retzlaff > --- > lib/eal/x86/include/rte_cycles.h | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/lib/eal/x86/include/rte_cycles.h > b/l

RE: [PATCH v4 02/14] eal: use rtm and xtest intrinsics

2023-04-12 Thread Konstantin Ananyev
> Inline assembly is not supported for MSVC x64. Convert code to use > _xend, _xabort and _xtest intrinsics. > > Signed-off-by: Tyler Retzlaff > --- > config/x86/meson.build| 6 ++ > lib/eal/x86/include/rte_rtm.h | 18 +- > 2 files changed, 11 insertions(+), 13 de

[PATCH] net/ixgbe: consider DCB/VMDq conf when getting RSS conf

2023-04-12 Thread Min Zhou
The mrqe field of MRQC register is an enum. From the Intel 82599 datasheet, we know that these values below for the mrqe field are all related to RSS configuration: b = RSS disabled. 0001b = RSS only -- Single set of RSS 16 queues. 0010b = DCB enabled and RSS disabled --

[PATCH v1] power: support amd-pstate cpufreq driver

2023-04-12 Thread Sivaprasad Tummala
amd-pstate introduces a new CPU frequency control mechanism for AMD processors using the ACPI Collaborative Performance Power Control feature for a finer grained frequency management. Patch to add support for amd-pstate driver. Signed-off-by: Sivaprasad Tummala --- app/test/test_power.c

Re: [PATCH] dmadev: add tracepoints

2023-04-12 Thread Bruce Richardson
On Wed, Apr 12, 2023 at 02:48:08AM +, Chengwen Feng wrote: > Add tracepoints at important APIs for tracing support. > > Signed-off-by: Chengwen Feng > --- > lib/dmadev/meson.build | 2 +- > lib/dmadev/rte_dmadev.c | 39 ++-- > lib/dmadev/rte_dmadev.h

[RFC] app/testpmd: use RSS conf from software when configuring DCB

2023-04-12 Thread Min Zhou
In the testpmd command, we have to stop the port firstly before configuring the DCB. However, some PMDs may execute a hardware reset during the port stop, such as ixgbe. Some kind of reset operations of PMD could clear the configurations of RSS in the hardware register. This would cause the loss of

RE: [PATCH 1/1] net/gve: update base code for DQO

2023-04-12 Thread Guo, Junfeng
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, April 12, 2023 17:35 > To: Guo, Junfeng ; Richardson, Bruce > > Cc: dev@dpdk.org; Zhang, Qi Z ; Rushil Gupta > > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > On 4/12/2023 10:09 AM, Guo, Junfeng wrote: > > >

Re: [PATCH 1/1] net/gve: update base code for DQO

2023-04-12 Thread Ferruh Yigit
On 4/12/2023 10:09 AM, Guo, Junfeng wrote: > > >> -Original Message- >> From: Ferruh Yigit >> Sent: Wednesday, April 12, 2023 16:50 >> To: Guo, Junfeng ; Richardson, Bruce >> >> Cc: dev@dpdk.org; Zhang, Qi Z ; Rushil Gupta >> >> Subject: Re: [PATCH 1/1] net/gve: update base code for DQ

RE: [PATCH 1/1] net/gve: update base code for DQO

2023-04-12 Thread Guo, Junfeng
> -Original Message- > From: Ferruh Yigit > Sent: Wednesday, April 12, 2023 16:50 > To: Guo, Junfeng ; Richardson, Bruce > > Cc: dev@dpdk.org; Zhang, Qi Z ; Rushil Gupta > > Subject: Re: [PATCH 1/1] net/gve: update base code for DQO > > On 4/11/2023 7:51 AM, Guo, Junfeng wrote: > > H

Re: [PATCH v4 06/14] eal: use prefetch intrinsics

2023-04-12 Thread Bruce Richardson
On Tue, Apr 11, 2023 at 02:12:20PM -0700, Tyler Retzlaff wrote: > Inline assembly is not supported for MSVC x64 instead use _mm_prefetch > and _mm_cldemote intrinsics. > > Signed-off-by: Tyler Retzlaff > --- Acked-by: Bruce Richardson One comment inline below for future consideration. > lib/

Re: [PATCH v4 03/14] eal: use barrier intrinsics

2023-04-12 Thread Bruce Richardson
On Tue, Apr 11, 2023 at 02:12:17PM -0700, Tyler Retzlaff wrote: > Inline assembly is not supported for MSVC x64 instead expand > rte_compiler_barrier as _ReadWriteBarrier and for rte_smp_mb > _m_mfence intrinsics. > > Signed-off-by: Tyler Retzlaff Acked-by: Bruce Richardson One whitespace line

Re: [PATCH v4 02/14] eal: use rtm and xtest intrinsics

2023-04-12 Thread Bruce Richardson
On Tue, Apr 11, 2023 at 02:12:16PM -0700, Tyler Retzlaff wrote: > Inline assembly is not supported for MSVC x64. Convert code to use > _xend, _xabort and _xtest intrinsics. > > Signed-off-by: Tyler Retzlaff > --- Subject to the CI not reporting any errors: Acked-by: Bruce Richardson > config

Re: [PATCH 1/1] net/gve: update base code for DQO

2023-04-12 Thread Ferruh Yigit
On 4/11/2023 7:51 AM, Guo, Junfeng wrote: Hi Junfeng, message moved down. > >> -Original Message- >> From: Rushil Gupta >> Sent: Tuesday, April 11, 2023 12:59 >> To: Zhang, Qi Z ; ferruh.yi...@amd.com >> Cc: Richardson, Bruce ; dev@dpdk.org; >> Rushil Gupta ; Guo, Junfeng >> >> Subject

Re: [PATCH v3 11/11] telemetry: avoid expanding versioned symbol macros on msvc

2023-04-12 Thread Bruce Richardson
On Tue, Apr 11, 2023 at 01:34:14PM -0700, Tyler Retzlaff wrote: > On Tue, Apr 11, 2023 at 11:24:07AM +0100, Bruce Richardson wrote: > > On Wed, Apr 05, 2023 at 05:45:19PM -0700, Tyler Retzlaff wrote: > > > Windows does not support versioned symbols. Fortunately Windows also > > > doesn't have an ex

RE: [EXT] Re: [PATCH 1/1] app/mldev: add internal function for file read

2023-04-12 Thread Srikanth Yalavarthi
> -Original Message- > From: Stephen Hemminger > Sent: 28 March 2023 21:22 > To: Srikanth Yalavarthi > Cc: Anup Prabhu ; dev@dpdk.org; Shivah Shankar > Shankar Narayan Rao ; Prince Takkar > ; Srikanth Yalavarthi > Subject: [EXT] Re: [PATCH 1/1] app/mldev: add internal function for file r

[PATCH v2 0/3] Enable iavf Rx Timestamp offload on vector path

2023-04-12 Thread Zhichao Zeng
Enable timestamp offload with the command '--enable-rx-timestamp', pay attention that getting Rx timestamp offload will drop the performance. --- v2: fix compile warning and SSE path Zhichao Zeng (3): net/iavf: support Rx timestamp offload on AVX512 net/iavf: support Rx timestamp offload on A

[DPDK] heap memory fragmentation issue

2023-04-12 Thread wuchangsheng (C)
Hello: When using rte_malloc and rte_free to request and release memory repeatedly, the usage of large pages gradually increases. Checking the relevant source code shows that memory requests and releases are started from the head of the freelist chain list of the heap. Memory fragmentation

[PATCH v2 3/3] net/iavf: support Rx timestamp offload on SSE

2023-04-12 Thread Zhichao Zeng
This patch enables Rx timestamp offload on SSE data path. Enable timestamp offload with the command '--enable-rx-timestamp', pay attention that getting Rx timestamp offload will drop the performance. Signed-off-by: Zhichao Zeng --- v2: fix compile warning and timestamp error --- drivers/net/ia

[PATCH v2 2/3] net/iavf: support Rx timestamp offload on AVX2

2023-04-12 Thread Zhichao Zeng
This patch enables Rx timestamp offload on AVX2 data path. Enable timestamp offload with the command '--enable-rx-timestamp', pay attention that getting Rx timestamp offload will drop the performance. Signed-off-by: Zhichao Zeng --- v2: fix compile warning --- drivers/net/iavf/iavf_rxtx_vec_av

[PATCH v2 1/3] net/iavf: support Rx timestamp offload on AVX512

2023-04-12 Thread Zhichao Zeng
This patch enables Rx timestamp offload on AVX512 data path. Enable timestamp offload with the command '--enable-rx-timestamp', pay attention that getting Rx timestamp offload will drop the performance. Signed-off-by: Wenjun Wu Signed-off-by: Zhichao Zeng --- v2: fix compile warning --- drive

[PATCH v2 0/3] Enable iavf Rx Timestamp offload on vector path

2023-04-12 Thread Zhichao Zeng
Enable timestamp offload with the command '--enable-rx-timestamp', pay attention that getting Rx timestamp offload will drop the performance. --- v2: fix compile warning and SSE path Zhichao Zeng (3): net/iavf: support Rx timestamp offload on AVX512 net/iavf: support Rx timestamp offload on A

[PATCH v3] net: fix return type of IPv4 L4 packet checksum

2023-04-12 Thread eagostini
From: Elena Agostini Function returns 0 or -1 but the return type is uint16_t. Fixes: d178f693bbfe ("net: add UDP/TCP checksum in mbuf segments") Cc: xiaoyun...@intel.com Signed-off-by: Elena Agostini --- V2: added fixline and fixed cc address V3: title changed --- lib/net/rte_ip.h | 2

Re: [PATCH v2] net: fix return type of IPv6 L4 packet checksum

2023-04-12 Thread Thomas Monjalon
12/04/2023 10:22, Thomas Monjalon: > 06/04/2023 11:49, eagost...@nvidia.com: > > From: Elena Agostini > > > > Function returns 0 or -1 but the return type is uint16_t. > > > > Fixes: d178f693bbfe ("net: add UDP/TCP checksum in mbuf segments") > > Cc: xiaoyun...@intel.com > > > > Signed-off-by:

Re: [PATCH v2] net: fix return type of IPv6 L4 packet checksum

2023-04-12 Thread Thomas Monjalon
06/04/2023 11:49, eagost...@nvidia.com: > From: Elena Agostini > > Function returns 0 or -1 but the return type is uint16_t. > > Fixes: d178f693bbfe ("net: add UDP/TCP checksum in mbuf segments") > Cc: xiaoyun...@intel.com > > Signed-off-by: Elena Agostini The title should be about IPv4, not

RE: [EXT] [PATCH v2 25/44] net/octeontx: fix segment fault when parse devargs

2023-04-12 Thread Harman Kalra
Hi, Thanks for fixing the seg fault. Acked-by: Harman Kalra Thanks Harman > -Original Message- > From: Chengwen Feng > Sent: Monday, March 20, 2023 2:51 PM > To: tho...@monjalon.net; ferruh.yi...@amd.com; Harman Kalra > ; Santosh Shukla > ; Jerin Jacob > > Cc: dev@dpdk.org > Subject:

Re: Hardware timestamps

2023-04-12 Thread David Marchand
Hello, On Wed, Apr 12, 2023 at 8:57 AM Игорь К wrote: > > I have tried to get hw timestamps of packets on Intel X550T(10G) and > AQC107(10G). > But RTE_ETH_RX_OFFLOAD_TIMESTAMP = 0 in dev_info.rx_offload_capa. > Tell me is it possible to get hw timestamps on these NICs with DPDK? Looking at the