[PATCH v4] net/ice: fix ice dcf control thread crash

The control thread accesses the hardware resources after the resources were released, which results in a segment error. The 'ice-reset' threads are detached, so thread resources cannot be reclaimed by `pthread_join` calls. This commit synchronizes the number of 'ice-reset' threads by adding two v

Minutes of Technical Board Meeting, 2023-March-8

Minutes of Technical Board Meeting, 2023-March-8 Members Attending - -Aaron -Bruce -Hemant -Honnappa -Jerin (Chair) -Kevin -Konstantin -Maxime -Stephen -Thomas NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public,

RE: [PATCH] net/idpf: reset queue flag when queue is stopped

> -Original Message- > From: Xing, Beilei > Sent: Thursday, March 16, 2023 4:09 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; Xing, Beilei ; sta...@dpdk.org; > Wu, Jingjing > Subject: [PATCH] net/idpf: reset queue flag when queue is stopped > > From: Beilei Xing > > Reset q_started flag

RE: [PATCH v1] ethdev: fix address sanitizer bug

> -Original Message- > From: Ankur Dwivedi > Sent: 2023年3月16日 17:48 > To: dev@dpdk.org > Cc: Yuan, DukaiX ; jer...@marvell.com; > tho...@monjalon.net; ferruh.yi...@amd.com; > andrew.rybche...@oktetlabs.ru; sk...@marvell.com; Ankur Dwivedi > > Subject: [PATCH v1] ethdev: fix address saniti

Re: [PATCH 0/5] fix segment fault when parse args

On 2023/3/17 2:18, Ferruh Yigit wrote: > On 3/14/2023 12:48 PM, Chengwen Feng wrote: >> The rte_kvargs_process() was used to parse KV pairs, it also supports >> to parse 'only keys' (e.g. socket_id) type. And the callback function >> parameter 'value' is NULL when parsed 'only keys'. >> >> It may

Re: [RFC v2 2/2] eal: add high-performance timer facility

On Wed, 15 Mar 2023 18:03:42 +0100 Mattias Rönnblom wrote: > The htimer library attempts at providing a timer facility with roughly > the same functionality, but less overhead and better scalability than > DPDK timer library. > > The htimer library employs per-lcore hierarchical timer wheels and

[PATCH v1] net/ipn3ke: fix representor name

The device name used in rte_eth_dev_allocated() function is afu device name instead of representor name, this patch correct it. Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver") Cc: sta...@dpdk.org Signed-off-by: Wei Huang --- drivers/net/ipn3ke/ipn3ke_ethdev.c | 2 +- 1 file changed, 1 insert

[PATCH v1] net/ipn3ke: fix thread exit issue

Thread does not exit after driver is removed. When there is no more representor exist, the variable 'num' will be 0 and thread can exit safely at this time. Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor") Cc: sta...@dpdk.org Signed-off-by: Wei Huang --- drivers/net/ipn3ke/ipn3ke_representor

[PATCH v1] raw/ifpga: remove virtual device unplug operation

VDEV bus has implemented cleanup() function to perform cleanup for devices on the bus during eal_cleanup(), so there is no need for ifpga driver to record virtual devices and unplug them. Signed-off-by: Wei Huang --- drivers/raw/ifpga/ifpga_rawdev.c | 99

[PATCH v1] bus/ifpga: add fpga bus cleanup

In this patch, cleanup method is implemented for FPGA bus which will be called during eal_bus_cleanup(). Signed-off-by: Wei Huang --- drivers/bus/ifpga/ifpga_bus.c | 36 1 file changed, 36 insertions(+) diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bu

[PATCH v1] bus/ifpga: fix issue of accessing null address

In function ifpga_scan_one(), variable 'path' is NULL if device argument 'afu_bts' is not set, subsequent string copy with 'path' would lead to segmentation fault. Fixes: 6fa4aa2b3645 ("bus/ifpga: fix forcing optional devargs") Cc: sta...@dpdk.org Signed-off-by: Wei Huang --- drivers/bus/ifpga/

RE: [EXT] Re: [PATCH v6 12/12] app/mldev: add documentation for mldev test cases

> -Original Message- > From: Srikanth Yalavarthi > Sent: 16 March 2023 23:37 > To: Thomas Monjalon > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla ; Srikanth > Yalavarthi ; Srikanth Yalavarthi > > Sub

RE: [EXT] Re: [PATCH v6 05/12] app/mldev: add ordered inference test case

> -Original Message- > From: Thomas Monjalon > Sent: 16 March 2023 23:32 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla ; Srikanth > Yalavarthi > Subject: Re: [EXT] Re: [PAT

[PATCH v3 6/8] ml/cnxk: check for null pointer before dereference

Fix deference before null check. Issue reported by coverity scan. Coverity issue: 383665 Fixes: 817e3e55bb18 ("ml/cnxk: support simulator environment") Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

[PATCH v3 8/8] ml/cnxk: reduce levels of nested variables access

Reduce the number of levels to access nested structure variables. Use available variables or add new local pointer variables for access to keep the code uniform. Fixes: 298b2af4267f ("ml/cnxk: add internal structures for derived info") Fixes: 0b9c0768ce2b ("ml/cnxk: support model query") Signed-o

[PATCH v3 5/8] ml/cnxk: fix potential memory leak in xstats

Local buffer xstats_map is not released, when the xstats name passed by the user application is not valid. This patch releases the memory in such cases. Fixes: 4ff4ab8e1a20 ("ml/cnxk: support extended statistics") Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 4 +++- 1

[PATCH v3 4/8] ml/cnxk: remove logically dead code

Remove logically dead code. Issue reported by coverity scan. Coverity issue: 383664 Fixes: da3325131d71 ("ml/cnxk: find OCM mask and page slots for a model") Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 21 +++-- 1 file changed, 3 insertions(+), 18 del

[PATCH v3 2/8] ml/cnxk: fix potential division by zero

Fix division or modulo by zero issue reported by coverity. Added a check to count, before updating average value of a stat. Coverity issue: 383658 Fixes: 4ff4ab8e1a20 ("ml/cnxk: support extended statistics") Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ops.c | 3 ++- 1 file c

[PATCH v3 7/8] ml/cnxk: avoid variable name reuse in a function

Avoid reusing variable name in different scopes with in same function. Move variable declarations to beginning of function. Fixes: b7d0650ebce0 ("ml/cnxk: reserve and free OCM pages") Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 17 - 1 file changed, 8

[PATCH v3 1/8] ml/cnxk: fix evaluation order violation issues

Fix evaluation order violation issues reported by coverity tool. ocm_mask variable is being written twice with the same value. Coverity issue: 383659 Fixes: b7d0650ebce0 ("ml/cnxk: reserve and free OCM pages") Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_ocm.c | 13 +-

[PATCH v3 3/8] ml/cnxk: add pointer check after memory allocation

Added checks for null pointers after memory allocation. Issues were reported by klocwork static analysis tool. Fixes: 515e3608c741 ("ml/cnxk: configure OCM page size") Fixes: 4ff4ab8e1a20 ("ml/cnxk: support extended statistics") Signed-off-by: Srikanth Yalavarthi --- drivers/ml/cnxk/cn10k_ml_oc

[PATCH v3 0/8] Fixes to ml/cnxk driver

This is a series of fixes for ml/cnxk diver. Changes include fixes for coverity scan issues, klocwork issues and additional fixes. v3: * split fixes into multiple patches * add code improvement changes v2: * additional null pointer checks * xstats memory leak fix v1: * initial consolidated patch

[PATCH v7 11/11] app/mldev: enable reporting stats in mldev app

Enable reporting driver xstats and inference end-to-end latency and throughput in mldev inference tests. Reporting of stats can be enabled using "--stats" option. Signed-off-by: Srikanth Yalavarthi Acked-by: Anup Prabhu --- app/test-mldev/ml_options.c| 10 +- app/test-mldev/ml_

[PATCH v7 10/11] app/mldev: enable support for inference validation

Enabled support to validate inference output with reference output provided by the user. Validation would be successful only when the inference outputs are within the 'tolerance' specified through command line option "--tolerance". Signed-off-by: Srikanth Yalavarthi Acked-by: Anup Prabhu --- ap

[PATCH v7 08/11] app/mldev: enable support for queue pairs and size

Added support to create multiple queue-pairs per device to enqueue and dequeue inference requests. Number of queue pairs to be created can be specified through "--queue_pairs" option. Support is also enabled to control the number of descriptors per each queue pair through "--queue_size" option. Inf

[PATCH v7 09/11] app/mldev: enable support for inference batches

Enabled support to execute multiple batches of inferences per each enqueue request. Input and reference for the test should be appropriately provided for multi-batch run. Number of batches can be specified through "--batches" option. Signed-off-by: Srikanth Yalavarthi Acked-by: Anup Prabhu ---

[PATCH v7 06/11] app/mldev: add test case to interleave inferences

Added test case to interleave inference requests from multiple models. Interleaving would load and start all models and launch inference requests for the models using available queue-pairs Operations sequence when testing with N models and R reps, (load + start) x N -> (enqueue + dequeue) x N x R

[PATCH v7 05/11] app/mldev: add ordered inference test case

Added an ordered test case to execute inferences with single or multiple models. In this test case inference requests for a model are enqueued after completion of all requests for the previous model. Test supports inference repetitions. Operations sequence when testing with N models and R reps, (

[PATCH v7 04/11] app/mldev: add test case to validate model ops

Added test case to validate model operations. Model ops test is a collection of sub-tests. Each sub-test invokes the model operations in a specific order. Sub-test A: (load -> start -> stop -> unload) x n Sub-test B: load x n -> start x n -> stop x n -> unload x n Sub-test C: load x n + (start +

[PATCH v7 07/11] app/mldev: enable support for burst inferences

Added 'burst_size' support for inference tests. Burst size controls the number of inference requests handled during the burst enqueue and dequeue operations of the test case. Signed-off-by: Srikanth Yalavarthi Acked-by: Anup Prabhu --- app/test-mldev/ml_options.c| 12 +- app/test-m

[PATCH v7 03/11] app/mldev: add test case to validate device ops

Added test case to validate device handling operations. Device ops test is a collection of multiple sub-tests. Enabled sub-test to validate device reconfiguration. Set device_ops as the default test. Signed-off-by: Srikanth Yalavarthi Acked-by: Anup Prabhu --- app/test-mldev/meson.build |

[PATCH v7 01/11] app/mldev: implement test framework for mldev

Implemented framework for mldev test application. New test cases can be added using the framework. Support is also enabled to add options specific to the test cases. User can launch the tests by specifying the name of test as part of launch arguments. Code to parse command line arguments is import

[PATCH v7 02/11] app/mldev: add common test functions

Added common functions used by all tests. Common code includes functions to check capabilities, options, and handle ML devices. Signed-off-by: Srikanth Yalavarthi Acked-by: Anup Prabhu --- app/test-mldev/meson.build | 1 + app/test-mldev/test_common.c | 136 +

[PATCH v7 00/11] Implementation of mldev test application

Machine learning device APIs test application = This series of patches introduces a test application for machine learning device APIs. A test framework is implemented with multiple test enabled, to validate the device, model and fast-path functions. New

[PATCH v2 1/1] test/mbuf: fix mbuf autotest when mbuf debug is enabled

How to reproduce: 1. Define RTE_LIBRTE_MBUF_DEBUG 2. MALLOC_PERTURB_=178 DPDK_TEST=mbuf_autotest gdb --args obj-x86_64-linux-gnu/app/test/dpdk-test --file-prefix=mbuf_autotest PANIC in rte_mbuf_sanity_check(): bad pkt_len ... #6 0x77d3d4cc in rte_mbuf_sanity_check (m=m@entr

RE: [EXT] [PATCH v3 2/2] crypto/qat: add cipher-crc offload support

> Subject: [EXT] [PATCH v3 2/2] crypto/qat: add cipher-crc offload support > Update title as crypto/qat: support cipher-crc offload > This patch adds support to the QAT symmetric crypto PMD for combined > cipher-crc offload feature, primarily for DOCSIS, on gen2/gen3/gen4 > QAT devices. > > A n

RE: [PATCH] crypto/cnxk: update number of max capabilities

> > Subject: [PATCH] crypto/cnxk: update number of max capabilities > > > > To ensure that the end marker can fit into the capabilities array, the max > > number of capabilities has been incremented. > > Additionally, throw an error if max length is reached. It's critical because > > `rte_cryptodev

RE: [EXT] [PATCH 1/2] examples/ipsec-secgw: allow single xform SA

> Subject: [EXT] [PATCH 1/2] examples/ipsec-secgw: allow single xform SA > > Update check capabilities before session create to allow single xform SA > i.e. auth or cipher only > > Fixes: a8781df86c14 ("examples/ipsec-secgw: check capabilities before session > create") > Cc: gak...@marvell.com,ka

RE: [PATCH v2] crypto/ipsec_mb: expect ENOTSUP

> Acked-by: Kai Ji > > > Subject: [PATCH v2] crypto/ipsec_mb: expect ENOTSUP > > > > Commit b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request > > handler") is part of DPDK 22.11 release and it enforces usage of shared > > config and multiprocess mode. > > > > DPDK is not required to b

RE: [PATCH v5] test: add cryptodev crosscheck suite

> Hi Akhil, Volodymyr > > > Subject: RE: [PATCH v5] test: add cryptodev crosscheck suite > > > > > > > Subject: [PATCH v5] test: add cryptodev crosscheck suite > > > > > > Add a validation test suite that helps in verifying that the output > > > generated by two different cryptodevs match for a wi

RE: [PATCH] app/test: handle error packets from inline IPsec

> Subject: [PATCH] app/test: handle error packets from inline IPsec > > In inline IPsec path, when the ol_flags indicate error, pkt might > be incomplete. Hence don't trust the m->pkt_len to determine the > size of packet, rather consider even data length's per segment. > > Signed-off-by: Nithin

[PATCH v2] app/testpmd: fix wrong encap/decap size calculation

Testpmd app has some functions to create either encap or decap buffer for some special cases: - "l2_encap" and "l2_decap" - "mplsogre_encap" and "mplsogre_decap" - "mplsoudp_encap" and "mplsoudp_decap" The functions use both "rte_flow_item_eth" and "rte_flow_item_vlan" structures to represent t

RE: [PATCH] app/compress-perf: fix remaining data for ops

> Acked-by: Kai Ji > > > Subject: [PATCH] app/compress-perf: fix remaining data for ops > > > > From: Arkadiusz Kusztal > > > > Individual variables are needed for tracking the remaining data for > > compression and decompression. > > > > Fixes: 83cc3b90ad7a ("app/compress-perf: fix testing sing

Re: [PATCH 5/5] net/sfc: fix segment fault when parse devargs

On 3/14/2023 12:48 PM, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault when parse input args

Re: [PATCH 3/5] net/pcap: fix segment fault when parse devargs

On 3/14/2023 12:48 PM, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault when parse input args

Re: [PATCH 2/5] net/memif: fix segment fault when parse devargs

On 3/14/2023 12:48 PM, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault when parse input args

Re: [PATCH 0/5] fix segment fault when parse args

On 3/14/2023 12:48 PM, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > It may leads to segment fault when parse args with '

RE: [PATCH 0/3] cryptodev test improvements

> Acked-by: Kai Ji > > > Subject: [PATCH 0/3] cryptodev test improvements > > > > The meson driver-tests suite was missing some QAT and SW PMD crypto > > tests, which are now added. > > > > Some issues were highlighted after adding to the driver-tests suite, > > which are also addressed in this p

RE: [EXT] Re: [PATCH v6 12/12] app/mldev: add documentation for mldev test cases

> -Original Message- > From: Thomas Monjalon > Sent: 16 March 2023 23:34 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla ; Srikanth > Yalavarthi > Subject: Re: [EXT] Re: [PAT

Re: [EXT] Re: [PATCH v6 12/12] app/mldev: add documentation for mldev test cases

16/03/2023 18:56, Srikanth Yalavarthi: > From: Thomas Monjalon > > 11/03/2023 16:09, Srikanth Yalavarthi: > > > Added documentation specific to mldev test cases. Added details about > > > all test cases and option supported by individual tests. > > > > Would it be possible to add documentation of

Re: [EXT] Re: [PATCH v6 05/12] app/mldev: add ordered inference test case

16/03/2023 18:47, Srikanth Yalavarthi: > From: Thomas Monjalon > > 11/03/2023 16:08, Srikanth Yalavarthi: > > > static struct option lgopts[] = { > > > - {ML_TEST, 1, 0, 0}, {ML_DEVICE_ID, 1, 0, 0}, {ML_SOCKET_ID, 1, 0, 0}, > > {ML_MODELS, 1, 0, 0}, > > > - {ML_DEBUG, 0, 0, 0}, {ML_HELP, 0, 0, 0

RE: [EXT] Re: [PATCH v6 12/12] app/mldev: add documentation for mldev test cases

> -Original Message- > From: Thomas Monjalon > Sent: 16 March 2023 23:21 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [EXT] Re: [PATCH v6 12/12] app/mldev: add

RE: [EXT] Re: [PATCH v6 09/12] app/mldev: enable support for inference batches

> -Original Message- > From: Thomas Monjalon > Sent: 16 March 2023 23:18 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [EXT] Re: [PATCH v6 09/12] app/mldev: enab

Re: [PATCH v6 12/12] app/mldev: add documentation for mldev test cases

11/03/2023 16:09, Srikanth Yalavarthi: > Added documentation specific to mldev test cases. Added details > about all test cases and option supported by individual tests. Would it be possible to add documentation of test cases while adding the code? Keeping related code and doc changes in the same

RE: [EXT] Re: [PATCH v6 05/12] app/mldev: add ordered inference test case

> -Original Message- > From: Thomas Monjalon > Sent: 16 March 2023 23:15 > To: Srikanth Yalavarthi > Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao > ; Jerin Jacob Kollanukkaran > ; Anup Prabhu ; Prince Takkar > ; Parijat Shukla > Subject: [EXT] Re: [PATCH v6 05/12] app/mldev: add

Re: [PATCH v6 09/12] app/mldev: enable support for inference batches

11/03/2023 16:09, Srikanth Yalavarthi: > @@ -528,8 +533,8 @@ ml_request_initialize(struct rte_mempool *mp, void > *opaque, void *obj, unsigned > req->niters = 0; > > /* quantize data */ > - rte_ml_io_quantize(t->cmn.opt->dev_id, t->model[t->fid].id, > -t->

Re: [PATCH v6 05/12] app/mldev: add ordered inference test case

11/03/2023 16:08, Srikanth Yalavarthi: > static struct option lgopts[] = { > - {ML_TEST, 1, 0, 0}, {ML_DEVICE_ID, 1, 0, 0}, {ML_SOCKET_ID, 1, 0, 0}, > {ML_MODELS, 1, 0, 0}, > - {ML_DEBUG, 0, 0, 0}, {ML_HELP, 0, 0, 0}, {NULL, 0, 0, 0}}; > + {ML_TEST, 1, 0, 0}, {ML_DEVICE_ID, 1,

Re: [PATCH v4 0/2] Fix testpmd interrupt regression

On 3/16/2023 5:05 PM, Thomas Monjalon wrote: > 16/03/2023 18:01, Ferruh Yigit: >> On 3/16/2023 3:31 PM, Stephen Hemminger wrote: >>> On Thu, 16 Mar 2023 12:20:41 + >>> Ferruh Yigit wrote: >>> On 3/15/2023 5:31 PM, Stephen Hemminger wrote: > Resolve issues from using control-C in testp

Re: [PATCH 1/5] app/pdump: fix segment fault when parse args

On 3/14/2023 12:48 PM, Chengwen Feng wrote: > The rte_kvargs_process() was used to parse KV pairs, it also supports > to parse 'only keys' (e.g. socket_id) type. And the callback function > parameter 'value' is NULL when parsed 'only keys'. > > This patch fixes segment fault when parse --pdump arg

[PATCH] app/testpmd: revert cleanup cleanly from signal

This reverts commit 0fd1386c30c3ad9365d7fdd2829bf7cb2e1b9dff. Because of reported issues on Windows [1] and it is risky to fix it at this stage, fixed feature will be considered in next version. [1] Bugzilla ID: 1180 Signed-off-by: Ferruh Yigit --- Cc: Stephen Hemminger Cc: Pier Damouny ---

Re: [PATCH] app/testpmd: fix wrong encap/decap size calculation

16/03/2023 18:16, Michael Baum: > Testpmd app has some functions to create either encap or decap buffer > for some special cases: > - "l2_encap" and "l2_decap" > - "mplsogre_encap" and "mplsogre_decap" > - "mplsoudp_encap" and "mplsoudp_decap" > > The functions use both "rte_flow_item_eth" and

RE: [EXT] Re: [PATCH] ml/cnxk: fix updating error code and message

> -Original Message- > From: Thomas Monjalon > Sent: 16 March 2023 22:32 > To: Srikanth Yalavarthi > Cc: Prince Takkar ; dev@dpdk.org; Shivah Shankar > Shankar Narayan Rao ; Anup Prabhu > ; Parijat Shukla > Subject: [EXT] Re: [PATCH] ml/cnxk: fix updating error code and message > > Ex

[PATCH v2 1/1] ml/cnxk: fix reporting of incorrect error info

In the rte_ml_op_error_get driver function, the errcode field of rte_ml_op_error structure is not being updated. This is causing an incorrect or junk value being reported as errcode to caller. For error subtype not supported by driver, the error message reported is incorrect or junk. Fixes: 57c37

[PATCH] app/testpmd: fix wrong encap/decap size calculation

Testpmd app has some functions to create either encap or decap buffer for some special cases: - "l2_encap" and "l2_decap" - "mplsogre_encap" and "mplsogre_decap" - "mplsoudp_encap" and "mplsoudp_decap" The functions use both "rte_flow_item_eth" and "rte_flow_item_vlan" structures to represent t

Re: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues

16/03/2023 18:02, Srikanth Yalavarthi: > > -Original Message- > > From: Thomas Monjalon > > Sent: 16 March 2023 22:30 > > To: Srikanth Yalavarthi > > Cc: Prince Takkar ; Shivah Shankar Shankar Narayan > > Rao ; dev@dpdk.org; Anup Prabhu > > > > Subject: [EXT] Re: [PATCH v2 1/1] ml/cnxk:

Re: [PATCH 2/2] app/testpmd: add testpmd based sleeping

On 3/16/2023 3:14 PM, Anthony Harivel wrote: > Sleep for an incremental amount of time if the fwd engine has processed > less than at least half a burst of packets (i.e 16pkts with default > setting) on a polling iteration of testpmd. > > Upon detecting the threshold of >= 16 pkts on an Rxq, reset

Re: [PATCH v4 0/2] Fix testpmd interrupt regression

16/03/2023 18:01, Ferruh Yigit: > On 3/16/2023 3:31 PM, Stephen Hemminger wrote: > > On Thu, 16 Mar 2023 12:20:41 + > > Ferruh Yigit wrote: > > > >> On 3/15/2023 5:31 PM, Stephen Hemminger wrote: > >>> Resolve issues from using control-C in testpmd. > >>> Fixes regression from recent change t

Re: [PATCH v3] net/sfc: stop misuse of Rx ingress m-port metadata on EF100

On 3/12/2023 10:54 AM, Ivan Malov wrote: > The driver supports representor functionality. In it, > packets coming from VFs to the dedicated back-end Rx > queue get demultiplexed into front-end Rx queues of > representor ethdevs as per the per-packet metadata > indicating logical HW ingress ports. O

RE: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues

> -Original Message- > From: Thomas Monjalon > Sent: 16 March 2023 22:30 > To: Srikanth Yalavarthi > Cc: Prince Takkar ; Shivah Shankar Shankar Narayan > Rao ; dev@dpdk.org; Anup Prabhu > > Subject: [EXT] Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues > > External Email > > -

Re: [PATCH] ml/cnxk: fix updating error code and message

11/03/2023 12:50, Srikanth Yalavarthi: > Error code reported by applications is incorrect, as the value Which error is reported by applications? In general, errors are reported by drivers. > is not being set by error get function. For error subtype not > supported by driver, the error message rep

Re: [PATCH v4 0/2] Fix testpmd interrupt regression

On 3/16/2023 3:31 PM, Stephen Hemminger wrote: > On Thu, 16 Mar 2023 12:20:41 + > Ferruh Yigit wrote: > >> On 3/15/2023 5:31 PM, Stephen Hemminger wrote: >>> Resolve issues from using control-C in testpmd. >>> Fixes regression from recent change to use cmdline_poll(). >>> >>> v4 - drop sig_at

Re: [PATCH v2 1/1] ml/cnxk: fix multiple coverity issues

16/03/2023 10:33, Srikanth Yalavarthi: > Added checks for null pointers. Removed logically dead code. > Fix division or modulo by zero. Fix evaluation order violation > issues. Fix potential memory leak in xstats function. I think it would be better to split this patch a little, so we can easily s

Re: [PATCH 2/2] bus/platform: do not allow adding existing device

16/03/2023 10:41, Tomasz Duszynski: > Do not allow adding the same device multiple times. > > Coverity issue: 383663 > Fixes: 17c839f74da3 ("bus: add platform bus") > > Signed-off-by: Tomasz Duszynski Series applied, thanks.

Re: [PATCH] bus/platform: fix resource leak

16/03/2023 09:14, Tomasz Duszynski: > On error function may return without releasing some > allocated resources which causes a memory leak. Fix it. > > Coverity issue: 383660 > Fixes: 17c839f74da3 ("bus: add platform bus") > > Signed-off-by: Tomasz Duszynski Applied, thanks.

Re: [PATCH] bus/platform: probe devices without resources

13/03/2023 08:07, Tomasz Duszynski: > Platform device does not necessarily need to have any resources > defined. That means device is only capable of doing DMA transfers > and platform bus should not hinder a valid use-case. > > Signed-off-by: Tomasz Duszynski Applied, thanks.

Re: [PATCH 2/2] app/testpmd: add testpmd based sleeping

On Thu, 16 Mar 2023 16:14:38 +0100 Anthony Harivel wrote: > Sleep for an incremental amount of time if the fwd engine has processed > less than at least half a burst of packets (i.e 16pkts with default > setting) on a polling iteration of testpmd. > > Upon detecting the threshold of >= 16 pkts o

Re: [PATCH v2 00/16] replace __atomic operations returning new value

On Thu, Mar 16, 2023 at 04:25:41PM +0100, Thomas Monjalon wrote: > 16/03/2023 11:03, Bruce Richardson: > > On Wed, Mar 15, 2023 at 02:15:29PM -0700, Tyler Retzlaff wrote: > > > This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with > > > __atomic_fetch_{add,and,or,sub,xor} intrinsics

[Bug 1179] lib/mldev build failure on aarch64 with gcc 4.8

https://bugs.dpdk.org/show_bug.cgi?id=1179 David Marchand (david.march...@redhat.com) changed: What|Removed |Added Resolution|--- |FIXED St

Re: [PATCH] app/test: fix data length of each packet segment

On Thu, Mar 16, 2023 at 4:26 PM David Marchand wrote: > On Mon, Mar 6, 2023 at 7:52 AM Zhuobin Huang wrote: > > > > Assign correct data length to each segments according > > to the given pkt_len and nb_pkt_segs, instead of > > using pkt_len as the data_len of every packet segment > > > > Fixes: a

Re: [PATCH v2] reorder: fix registration of dynamic field in mbuf

On Mon, Mar 13, 2023 at 2:05 PM Volodymyr Fialko wrote: > > It's possible to initialize reorder buffer with user allocated memory via > rte_reorder_init() function. In such case rte_reorder_create() is not > required and reorder dynamic field in rte_mbuf will not be registered. > > Both reorder li

Re: [PATCH 21.11] ring: squash gcc 12.2.1 warnings

On Thu, Mar 16, 2023 at 12:00 PM David Marchand wrote: > > On Tue, Dec 20, 2022 at 1:38 PM Kevin Traynor wrote: > > > > gcc 12.2.1 on Fedora 37 is giving stringop-overread and > > stringop-overflow warnings when compiled with --buildtype=debug > > e.g. [1]. > > > > These are not yet fixed on main

RE: [PATCH v5] test: add cryptodev crosscheck suite

Hi Akhil, Volodymyr > -Original Message- > From: Akhil Goyal > Sent: Thursday 16 March 2023 09:45 > To: Volodymyr Fialko ; dev@dpdk.org; Fan Zhang > ; Power, Ciara > Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > ; hemant.agra...@nxp.com; Ji, Kai ; > Volodymyr Fialko > Subject: RE: [PAT

Re: [PATCH v2] reorder: fix registration of dynamic field in mbuf

On Wed, Mar 15, 2023 at 4:47 PM Pattan, Reshma wrote: > > -Original Message- > > From: David Marchand > > > A gentle reminder, please review and ack/comment. > > > Can we have this merged before RC3? > > > > I did not go into depth this time, the fix seems ok. > > Reshma, please review. >

Re: [PATCH] app/test: fix data length of each packet segment

On Mon, Mar 6, 2023 at 7:52 AM Zhuobin Huang wrote: > > Assign correct data length to each segments according > to the given pkt_len and nb_pkt_segs, instead of > using pkt_len as the data_len of every packet segment > > Fixes: a9c9e9698d5e ("app/test: allow to create packets of different sizes")

Re: [PATCH v2 00/16] replace __atomic operations returning new value

16/03/2023 11:03, Bruce Richardson: > On Wed, Mar 15, 2023 at 02:15:29PM -0700, Tyler Retzlaff wrote: > > This series replaces uses of __atomic_{add,and,or,sub,xor}_fetch with > > __atomic_fetch_{add,and,or,sub,xor} intrinsics where the new value > > is used. [...] > > Tyler Retzlaff (16): > > ap

[Bug 1191] rte_acl_classify returning mismatch result

https://bugs.dpdk.org/show_bug.cgi?id=1191 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[Bug 1190] rte_acl_classify returning mismatch result

https://bugs.dpdk.org/show_bug.cgi?id=1190 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Resolution|--- |DUPLICATE Sta

Re: [PATCH] app/testpmd: dump private info in 'show port info'

16/03/2023 11:46, Ferruh Yigit: > On 3/16/2023I 9:19 AM, Dmitry Kozlyuk wrote: > > On Thu, Mar 16, 2023 at 4:11 AM fengchengwen > > wrote: > >> Because we have no API to know the PMD whether impl specific ops, we could > >> only knowed by invoking. > >> Except above impl, I also consider the oth

[PATCH 2/2] app/testpmd: add testpmd based sleeping

Sleep for an incremental amount of time if the fwd engine has processed less than at least half a burst of packets (i.e 16pkts with default setting) on a polling iteration of testpmd. Upon detecting the threshold of >= 16 pkts on an Rxq, reset the sleep time to zero (i.e. no sleep). Sleep time wi

[PATCH 1/2] app/testpmd: fwd engines report processed packets

Change packet_fwd_t to return the number of processed packets instead of a boolean. This will be used in the next commit to determine the load ratio of an lcore and adjust the sleep duration accordingly Signed-off-by: Anthony Harivel --- .mailmap | 1 + app/test-pmd/5tswap

Re: [PATCH v2 0/2] vhost: fix names to follow new naming convention

On 3/9/23 06:16, Nobuhiro MIKI wrote: In this series, we simply replace 'master' with 'frontend' and 'slave' with 'backend' so that vhost user protocol message, protocol names follow the new naming conventions. v2: - Update .mailmap in patch 1 - Replace 'master' with 'frontend' in patch 2 No

Re: [PATCH] vhost: fix possible null pointer dereference

On 3/9/23 12:36, Maxime Coquelin wrote: When handling VHOST_USER_SET_MEM_TABLE request ending up in changing existing memory map, a device's memory pointer may ends up being dereference while being NULL in IOTLB cache flush function. Coverity issue: 383646 Fixes: dea092d0addb ("vhost: fix mad

Re: [PATCH 0/3] net/vhost pmd fixes for Rx interrupts

On 3/9/23 13:37, David Marchand wrote: This series fixes Rx interrupts for net/vhost when a virtio driver is not connected at the time net/vhost starts. These fixes are a bit late for 23.03, probably a bit scary (wrt the amount of touched code) and I do not mind deferring them to the next rele

Re: [PATCH v2] net/virtio: remove address width limit for modern devices

On 3/14/23 09:53, David Marchand wrote: Modern devices don't have the same limitation as legacy devices, because vring addresses are not configured using a 32-bit register. Fixes: 6ba1f63b5ab0 ("virtio: support specification 1.0") Cc: sta...@dpdk.org Signed-off-by: David Marchand Reviewed-b

Re: [PATCH v2] vhost: fix madvise IOTLB entries pages overlap check

On 3/15/23 12:40, Maxime Coquelin wrote: At removal time, when testing whether the IOTLB entry has shared pages with the previous and next entries in the cache, it checks whether the start address of the entry to be removed is on the same page as the start address of the next entry in the cach

Re: [PATCH v2] vhost: fix madvise IOTLB entries pages overlap check

On 3/16/23 09:52, David Marchand wrote: On Thu, Mar 16, 2023 at 9:38 AM Maxime Coquelin wrote: On 3/16/23 09:13, David Marchand wrote: On Wed, Mar 15, 2023 at 12:40 PM Maxime Coquelin wrote: At removal time, when testing whether the IOTLB entry has shared pages with the previous and next

Re: [PATCH 1/5] ethdev: support setting and querying rss algorithm

Hi, Thanks for responding and PSB. On Thu, 16 Mar 2023, Dongdong Liu wrote: Hi Ivan Many thanks for your review. On 2023/3/15 19:28, Ivan Malov wrote: Hi, On Wed, 15 Mar 2023, Dongdong Liu wrote: From: Jie Hai Currently, rte_eth_rss_conf supports configuring rss hash functions, rss key

Re: [PATCH v1 0/2] test-bbdev coverity fixes

On 3/9/23 04:36, Hernan Vargas wrote: Fixes for coverity issues 383647, 383155. Hernan Vargas (2): test/bbdev: fix possible div by zero issue test/bbdev: fix unchecked ret value issue app/test-bbdev/test_bbdev_perf.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-)

[PATCH V2 2/2] app/testpmd: assign custom ID to flow rules

From: Eli Britstein Upon creation of a flow, testpmd assigns it a flow ID. Later, the flow ID is used for flow operations (query, destroy, dump). The testpmd application allows to manage flow rules with its IDs. The flow ID is known only when the flow is created. In order to prepare a complete s

[PATCH V2 1/2] app/testpmd: change flow rule type

From: Eli Britstein Change flow rule type to be uint64_t (instead of currently uint32_t) to be able to accommodate larger IDs, as a pre-step towards allowing user-id to flows. Signed-off-by: Eli Britstein --- app/test-pmd/cmdline_flow.c | 12 ++-- app/test-pmd/config.c | 34 +

  1   2   >