RE: [PATCH v7 2/4] event/dlb2: remove superfluous rte_memcpy

2023-02-09 Thread Morten Brørup
> From: Sevincer, Abdullah [mailto:abdullah.sevin...@intel.com] > Sent: Thursday, 9 February 2023 19.50 > > Acked: by abdullah.sevin...@intel.com Thanks. Patchwork didn't catch it due to formatting, but the point is obvious: Acked-by: Abdullah Sevincer > > -Original Message- > From:

RE: [PATCH v2 2/2] test/mempool: add zero-copy API's

2023-02-09 Thread Morten Brørup
> From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com] > Sent: Friday, 10 February 2023 07.54 > > Added mempool test cases with zero-copy get and put API's > > Signed-off-by: Kamalakshitha Aligeri > Reviewed-by: Ruifeng Wang > Reviewed-by: Feifei Wang I already acked v1 of this

RE: [PATCH v2 1/2] net/i40e: replace put function

2023-02-09 Thread Morten Brørup
> From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com] > Sent: Friday, 10 February 2023 07.54 > > Integrated zero-copy put API in mempool cache in i40e PMD. > On Ampere Altra server, l3fwd single core's performance improves by 5% > with the new API > > Signed-off-by: Kamalakshitha A

Re: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map

2023-02-09 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 12:30 PM Ankur Dwivedi wrote: > > >On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi > >wrote: > >> > >> The file rte_mempool_trace.h contains tracepoints which are internal > >> to the mempool library. This file is renamed to mempool_trace.h, and > >> is made an internal heade

RE: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map

2023-02-09 Thread Ankur Dwivedi
>On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi >wrote: >> >> The file rte_mempool_trace.h contains tracepoints which are internal >> to the mempool library. This file is renamed to mempool_trace.h, and >> is made an internal header. The tracepoints in this file are removed >> from the experimental

[PATCH v2 2/2] test/mempool: add zero-copy API's

2023-02-09 Thread Kamalakshitha Aligeri
Added mempool test cases with zero-copy get and put API's Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: https://patchwork.dpdk.org/project/dpdk/patch/20230209145833.129986-1...@smartsharesystems.com/ app/test/test_mempool.c | 81 +++

[PATCH v2 1/2] net/i40e: replace put function

2023-02-09 Thread Kamalakshitha Aligeri
Integrated zero-copy put API in mempool cache in i40e PMD. On Ampere Altra server, l3fwd single core's performance improves by 5% with the new API Signed-off-by: Kamalakshitha Aligeri Reviewed-by: Ruifeng Wang Reviewed-by: Feifei Wang --- Link: https://patchwork.dpdk.org/project/dpdk/patch/202

[PATCH v2 0/2] Integrated mempool cache zero-copy API's

2023-02-09 Thread Kamalakshitha Aligeri
In i40e PMD, for fast_free path in Tx, freeing mbufs need to do an extra memcpy due to the special structure of ‘txep’. Thus, replaced the put_bulk function with the zero-copy put API to avoid the cost of this memcpy. On Ampere-altra server, for single-core DPDK l3fwd test, throughput improves by 5

Re: [PATCH v3] eventdev/timer: fix overflow issue

2023-02-09 Thread Jerin Jacob
On Thu, Feb 9, 2023 at 8:44 PM Erik Gabriel Carrillo wrote: > > The software timer adapter converts event timer timeout ticks to a > number of TSC cycles at which an rte_timer should expire. The > computation uses an integer multiplication that can result in overflow. > > If necessary, reduce the

Re: [PATCH v4 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-09 Thread Jerin Jacob
On Fri, Feb 10, 2023 at 10:28 AM Naga Harish K S V wrote: > > The adapter configuration parameters defined in the > ``struct rte_event_eth_rx_adapter_runtime_params`` can be configured `` character you can remove in git commit. > and retrieved using ``rte_event_eth_rx_adapter_runtime_params_set`

[PATCH] malloc: fix malloc performance may becomes worse as the number of malloc increases

2023-02-09 Thread Fengnan Chang
Here is a simple test case: " uint64_t entry_time, time; size_t size = 4096; unsigned align = 4096; for (int j = 0; j < 10; j++) { entry_time = rte_get_timer_cycles(); for (int i = 0; i < 2000; i++) { rte_malloc(NULL, size, align); } time = (rte_get_t

Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map

2023-02-09 Thread Jerin Jacob
On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi wrote: > > The file rte_mempool_trace.h contains tracepoints which are internal to the > mempool library. This file is renamed to mempool_trace.h, and is made an > internal header. The tracepoints in this file are removed from the > experimental section

RE: [EXT] Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map

2023-02-09 Thread Ankur Dwivedi
>On Thu, Feb 9, 2023 at 2:30 PM Ankur Dwivedi >wrote: >> >> The file rte_mempool_trace.h contains tracepoints which are internal >> to the mempool library. This file is renamed to mempool_trace.h, and >> is made an internal header. The tracepoints in this file are removed >> from the > >This patch

RE: [PATCH] eal: introduce atomics abstraction

2023-02-09 Thread Honnappa Nagarahalli
> On Thu, Feb 09, 2023 at 12:16:38AM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > For environments where stdatomics are not supported, we > > > > > > > > could > > > > > have a > > > > > > > stdatomic.h in DPDK implementing the same APIs (we have to >

[PATCH v4 3/3] eventdev/crypto: add params set/get APIs

2023-02-09 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the ``struct rte_event_crypto_adapter_runtime_params`` can be configured and retrieved using ``rte_event_crypto_adapter_runtime_params_set`` and ``rte_event_eth_rx_adapter_runtime_params_get`` respectively. Signed-off-by: Naga Harish K S V -

[PATCH v4 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-09 Thread Naga Harish K S V
The adapter configuration parameters defined in the ``struct rte_event_eth_tx_adapter_runtime_params`` can be configured and retrieved using ``rte_event_eth_tx_adapter_runtime_params_set`` and ``rte_event_eth_tx_adapter_runtime_params_get`` respectively. Signed-off-by: Naga Harish K S V --- app/

[PATCH v4 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-09 Thread Naga Harish K S V
The adapter configuration parameters defined in the ``struct rte_event_eth_rx_adapter_runtime_params`` can be configured and retrieved using ``rte_event_eth_rx_adapter_runtime_params_set`` and ``rte_event_eth_tx_adapter_runtime_params_get`` respectively. Signed-off-by: Naga Harish K S V --- app/

[dpdk-dev] [PATCH 3/3] common/cnxk: fix inline IPsec rule creation

2023-02-09 Thread psatheesh
From: Satheesh Paul Use inline IPsec device to create IPsec rules irrespective of RTE_ETH_RX_OFFLOAD_SECURITY offload flag. Fixes: 1aa86a170e ("drivers: support IPsec rule reservation scheme") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Nithin Dabilpuram Reviewed-by: Kiran K

[dpdk-dev] [PATCH 2/3] common/cnxk: fix printing IPsec flow rules

2023-02-09 Thread psatheesh
From: Satheesh Paul When dumping flow data, dump preallocated IPsec rules also. Fixes: 1aa86a170e ("drivers: support IPsec rule reservation scheme") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Jerin Jacob Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc.c

[dpdk-dev] [PATCH 1/3] common/cnxk: fix channel mask for SDP interfaces

2023-02-09 Thread psatheesh
From: Satheesh Paul Fix channel mask of SDP interfaces on CN10K. Fixes: f137566333 ("common/cnxk: support setting channel mask for SDP interfaces") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc.c | 9 +++-- drivers/commo

[PATCH v4 3/3] ring: add telemetry cmd for ring info

2023-02-09 Thread Jie Hai
This patch supports dump of ring information by its name. An example using this command is shown below: --> /ring/info,MP_mb_pool_0 { "/ring/info": { "name": "MP_mb_pool_0", "socket": 0, "flags": "0x0", "producer_type": "MP", "consumer_type": "MC", "size": 262144, "ma

[PATCH v4 2/3] ring: add telemetry cmd to list rings

2023-02-09 Thread Jie Hai
Add a telemetry command to list the rings used in the system. An example using this command is shown below: --> /ring/list { "/ring/list": [ "HT_:7d:00.2", "MP_mb_pool_0" ] } Signed-off-by: Jie Hai Acked-by: Konstantin Ananyev Reviewed-by: Honnappa Nagarahalli --- lib/ring/mes

[PATCH v4 1/3] ring: fix unmatched type definition and usage

2023-02-09 Thread Jie Hai
Field flags of struct rte_ring is defined as int type. However, it is used as unsigned int. To ensure consistency, change the type of flags to unsigned int. Fixes: cc4b218790f6 ("ring: support configurable element size") Signed-off-by: Jie Hai --- lib/ring/rte_ring_core.h | 2 +- 1 file changed

[PATCH v4 0/3] add telemetry cmds for ring

2023-02-09 Thread Jie Hai
This patch set supports telemetry cmd to list rings and dump information of a ring by its name. v1->v2: 1. Add space after "switch". 2. Fix wrong strlen parameter. v2->v3: 1. Remove prefix "rte_" for static function. 2. Add Acked-by Konstantin Ananyev for PATCH 1. 3. Introduce functions to return

Re: [PATCH v3 03/16] efd: replace RTE_LOGTYPE_EFD with local type

2023-02-09 Thread Stephen Hemminger
On Fri, 10 Feb 2023 10:03:47 +0800 fengchengwen wrote: > On 2023/2/10 9:07, Stephen Hemminger wrote: > > Replace all uses of global logtype with a local log type. > > Do not break message formats across source lines. > > > > Signed-off-by: Stephen Hemminger > > --- > > ... > > > }; > > EA

Re: [PATCH v3 01/16] gso: remove logtype

2023-02-09 Thread Stephen Hemminger
On Fri, 10 Feb 2023 02:29:44 + "Hu, Jiayu" wrote: > Hi Stephen, > > > -Original Message- > > From: Stephen Hemminger > > Sent: Friday, February 10, 2023 9:07 AM > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Hu, Jiayu > > ; Konstantin Ananyev > > ; Mark Kavanagh > > > > Subject:

回复: [PATCH 1/2] net/i40e: replace put function

2023-02-09 Thread Feifei Wang
> -邮件原件- > 发件人: Morten Brørup > 发送时间: Thursday, February 9, 2023 7:31 PM > 收件人: Feifei Wang ; Kamalakshitha Aligeri > ; yuying.zh...@intel.com; > beilei.x...@intel.com; olivier.m...@6wind.com; > andrew.rybche...@oktetlabs.ru; bruce.richard...@intel.com; > konstantin.anan...@huawei.com; H

RE: [PATCH v3 01/16] gso: remove logtype

2023-02-09 Thread Hu, Jiayu
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Friday, February 10, 2023 9:07 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Hu, Jiayu > ; Konstantin Ananyev > ; Mark Kavanagh > > Subject: [PATCH v3 01/16] gso: remove logtype > > If a large packet is passed into GSO

Microsoft DPDK 23.07 Roadmap

2023-02-09 Thread Tyler Retzlaff
Microsoft DPDK 23.07 Release Roadmap 1. Atomics Abstraction Introduce atomics abstraction to DPDK, allowing DPDK and applications to optionally use standard C11 atomics. The work is initially targeted for the DPDK release 23.07 and opens the opportunity for DPDK to be used on a wider range of pla

Re: [PATCH v3 03/16] efd: replace RTE_LOGTYPE_EFD with local type

2023-02-09 Thread fengchengwen
On 2023/2/10 9:07, Stephen Hemminger wrote: > Replace all uses of global logtype with a local log type. > Do not break message formats across source lines. > > Signed-off-by: Stephen Hemminger > --- ... > }; > EAL_REGISTER_TAILQ(rte_efd_tailq); > > +RTE_LOG_REGISTER_DEFAULT(efd_logtype, INF

[PATCH v3 3/3] eventdev/crypto: add params set/get APIs

2023-02-09 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the ``struct rte_event_crypto_adapter_runtime_params`` can be configured and retrieved using ``rte_event_crypto_adapter_runtime_params_set`` and ``rte_event_eth_rx_adapter_runtime_params_get`` respectively. Signed-off-by: Naga Harish K S V -

[PATCH v3 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-09 Thread Naga Harish K S V
The adapter configuration parameters defined in the ``struct rte_event_eth_tx_adapter_runtime_params`` can be configured and retrieved using ``rte_event_eth_tx_adapter_runtime_params_set`` and ``rte_event_eth_tx_adapter_runtime_params_get`` respectively. Signed-off-by: Naga Harish K S V --- app/

[PATCH v3 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-09 Thread Naga Harish K S V
The adapter configuration parameters defined in the ``struct rte_event_eth_rx_adapter_runtime_params`` can be configured and retrieved using ``rte_event_eth_rx_adapter_runtime_params_set`` and ``rte_event_eth_tx_adapter_runtime_params_get`` respectively. Signed-off-by: Naga Harish K S V --- app/

Re: [PATCH v3 01/16] gso: remove logtype

2023-02-09 Thread fengchengwen
On 2023/2/10 9:07, Stephen Hemminger wrote: > If a large packet is passed into GSO routines of unknown protocol > then library would log a message and pass it through. This is incorrect > behaviour on many levels: > - it allows oversize packet to get passed on to NIC driver > - no direct return

Re: [PATCH] ethdev: telemetry xstats support hide zero

2023-02-09 Thread fengchengwen
On 2023/2/10 7:30, Ferruh Yigit wrote: > On 2/9/2023 3:07 AM, Chengwen Feng wrote: >> The number of xstats may be large, after the hide zero option is added, >> only non-zero values can be displayed. >> > > Hi Chengwen, > > No objection on the functionality, we have similar config option in > tes

[PATCH v3 15/16] app/test: remove use of RTE_LOGTYPE_PIPELINE

2023-02-09 Thread Stephen Hemminger
Instead of using static type PIPELINE for logging in test application use stderr instead. If not testing RTE_LOG() better to not use it since log also goes to syslog. Signed-off-by: Stephen Hemminger --- app/test/test_table_acl.c | 50 -- app/test/test_table

[PATCH v3 16/16] pipeline: replace RTE_LOGTYPE_PIPELINE with dynamic log type

2023-02-09 Thread Stephen Hemminger
Split the static global PIPELINE log type into multiple suffix log types (by stage). Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/pipeline/rte_pipeline.c | 242 3 files changed, 87

[PATCH v3 14/16] table: convert RTE_LOGTYPE_TABLE to dynamic logtype

2023-02-09 Thread Stephen Hemminger
Use logtype suffixes for various components of this library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/table/rte_table_acl.c | 90 +-- lib/table/rte_table_array.c | 23 ++

[PATCH v3 13/16] port: replace RTE_LOGTYPE_PORT with dynamic type

2023-02-09 Thread Stephen Hemminger
Split up the single static RTE_LOGTYPE_PORT into separate sub types for each component: port.ethdev, port.evendev, ... Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/port/rte_port_ethdev.c | 23 + lib/port/rt

[PATCH v3 12/16] sched: replace RTE_LOGTYPE_SCHED with dynamic type

2023-02-09 Thread Stephen Hemminger
Also can remove unused RTE_LOGTYPE_METER Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 2 - lib/eal/include/rte_log.h | 4 +- lib/sched/rte_pie.c | 16 +- lib/sched/rte_sched.c | 299 +--- lib/sched/rte_sched_l

[PATCH v3 11/16] hash: replace RTE_LOGTYPE_HASH with dynamic type

2023-02-09 Thread Stephen Hemminger
A little more complex here since the one hash library actually has multiple routines in it. Split up the logtypes for hash and toeplitz. The hash crc file has another issue around logging. It is calling RTE_LOG during a constructor which is maybe problematic because this will all run before the D

[PATCH v3 10/16] kni: replace RTE_LOGTYPE_KNI with dynamic type

2023-02-09 Thread Stephen Hemminger
Even though KNI will eventually disappear, fix the logtype now. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/kni/rte_kni.c | 63 ++--- 3 files changed, 35 insertions(+), 31 dele

[PATCH v3 09/16] lpm: replace RTE_LOGTYPE_LPM with dynamic types

2023-02-09 Thread Stephen Hemminger
Split lpm and lpm6 into separate log types since they are in different files and user may want to change log levels for IPv4 vs IPv6. For rib and fib libraries give them own types as well. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h

[PATCH v3 08/16] mempool: replace RTE_LOGTYPE_MEMPOOL with dynamic type

2023-02-09 Thread Stephen Hemminger
Convert from RTE_LOGTYPE_MEMPOOL to logtype_mempool. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mempool/rte_mempool.c | 33 ++--- lib/mempool/rte_mempool_log.h | 10 ++ lib/

[PATCH v3 07/16] ring: replace RTE_LOGTYPE_RING with dynamic type

2023-02-09 Thread Stephen Hemminger
The logtype for ring only used in library. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/ring/rte_ring.c | 31 +++ 3 files changed, 20 insertions(+), 14 deletions(-) diff --git a/

[PATCH v3 06/16] power: replace RTE_LOGTYPE_POWER with dynamic type

2023-02-09 Thread Stephen Hemminger
Use dynamic log type for power library. Also replace use of RTE_LOGTYPE_USER1 with lib.power.guest. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c| 1 - lib/eal/include/rte_log.h | 2 +- lib/power/guest_channel.c | 48 + lib/power/power_ac

[PATCH v3 05/16] acl: replace LOGTYPE_ACL with dynamic type

2023-02-09 Thread Stephen Hemminger
Get rid of RTE_LOGTYPE_ACL and RTE_LOGTYPE_MALLOC. For ACL library use a dynamic type. The one message using RTE_LOGTYPE_MALLOC should have been under the ACL logtype anyway. The test code should not have been using fixed log type so just change that to stderr. Signed-off-by: Stephen Hemminger -

[PATCH v3 04/16] mbuf: replace RTE_LOGTYPE_MBUF with dynamic type

2023-02-09 Thread Stephen Hemminger
Introduce a new dynamic logtype for mbuf related messages. Since this is used in multiple files put one macro in mbuf_log.h Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/mbuf/mbuf_log.h | 10 ++ lib/m

[PATCH v3 03/16] efd: replace RTE_LOGTYPE_EFD with local type

2023-02-09 Thread Stephen Hemminger
Replace all uses of global logtype with a local log type. Do not break message formats across source lines. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- lib/efd/rte_efd.c | 106 +++---

[PATCH v3 02/16] log: drop unused RTE_LOGTYPE_TIMER

2023-02-09 Thread Stephen Hemminger
The timer code does not use rte_log. Signed-off-by: Stephen Hemminger --- lib/eal/common/eal_common_log.c | 1 - lib/eal/include/rte_log.h | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/eal/common/eal_common_log.c b/lib/eal/common/eal_common_log.c index c369154cb

[PATCH v3 01/16] gso: remove logtype

2023-02-09 Thread Stephen Hemminger
If a large packet is passed into GSO routines of unknown protocol then library would log a message and pass it through. This is incorrect behaviour on many levels: - it allows oversize packet to get passed on to NIC driver - no direct return is visible to applications - if it happens once, ma

[PATCH v3 00/16] Replace use of static logtypes

2023-02-09 Thread Stephen Hemminger
This patchset removes the main uses of static LOGTYPE's in DPDK libraries. It starts with the easy one and goes on to the more complex ones. It does not address the larger effort which is the eal, eventdev, cryptodev, and pmd log types. Mostly this is semi-automatic conversion but some places lik

Re: [PATCH v2] eal: introduce atomics abstraction

2023-02-09 Thread Tyler Retzlaff
On Thu, Feb 09, 2023 at 10:13:41PM +, Ferruh Yigit wrote: > On 2/9/2023 5:40 PM, Tyler Retzlaff wrote: > > On Thu, Feb 09, 2023 at 12:53:41PM +, Ferruh Yigit wrote: > >> On 2/9/2023 9:04 AM, Bruce Richardson wrote: > >>> On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote: >

[PATCH v3 5/5] ipsec: fix usage of RTE_LOGTYPE_USER1

2023-02-09 Thread Stephen Hemminger
There already is a logtype in this driver, use it! Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler") Cc: kai...@intel.com Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH v3 4/5] vhost: use logtype instead of RTE_LOGTYPE_USER1

2023-02-09 Thread Stephen Hemminger
Fix instances of USER1 logtype in fdset and crypto sections. Acked-by: Chenbo Xia Signed-off-by: Stephen Hemminger --- lib/vhost/fd_man.c | 16 +--- lib/vhost/vhost_crypto.c | 25 +++-- 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/lib/vh

[PATCH v3 3/5] latencystats: use dynamic logtype

2023-02-09 Thread Stephen Hemminger
Libraries should not reuse RTE_LOGTYPE_USER1 for their logging. Instead they should register their own type. Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats") Cc: reshma.pat...@intel.com Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 55

[PATCH v3 2/5] reorder: use a dynamic logtype

2023-02-09 Thread Stephen Hemminger
Libraries should not be reusing RTE_LOGTYPE_USER1 instead of doing proper logtype registration. Fixes: b70b56032bff ("reorder: new library") Cc: sergio.gonzalez.mon...@intel.com Signed-off-by: Stephen Hemminger --- lib/reorder/rte_reorder.c | 35 +++ 1 file change

[PATCH v3 1/5] ip_frag: use a dynamic logtype

2023-02-09 Thread Stephen Hemminger
DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in lieu of doing proper logtype registration. Acked-by: Konstantin Ananyev Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library") Signed-off-by: Stephen Hemminger --- lib/ip_frag/ip_frag_common.h | 16 ++- lib

[PATCH v3 0/5] Replace use of RTE_LOGTYPE_USER1 in library

2023-02-09 Thread Stephen Hemminger
The DPDK libraries and drivers should not be using the USER1 logtype. v3 - fix typo in ip_frag v2 - fix some compiler warnings Stephen Hemminger (5): ip_frag: use a dynamic logtype reorder: use a dynamic logtype latencystats: use dynamic logtype vhost: use logtype instead of RTE_LOGTYPE_U

Re: [PATCH] ethdev: telemetry xstats support hide zero

2023-02-09 Thread Ferruh Yigit
On 2/9/2023 3:07 AM, Chengwen Feng wrote: > The number of xstats may be large, after the hide zero option is added, > only non-zero values can be displayed. > Hi Chengwen, No objection on the functionality, we have similar config option in testpmd too, but I have some question on telemetry side

[PATCH v1 9/9] baseband/acc: remove printf from PMD function

2023-02-09 Thread Nicolas Chautru
Replacing usage of printf in companion function for bbdev-test by rte_log. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_acc100_pmd.c | 18 +- drivers/baseband/acc/rte_vrb_pmd.c| 2 +- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/bas

[PATCH v1 8/9] baseband/acc: add support for 4GUL CRC drop in VRB PMD

2023-02-09 Thread Nicolas Chautru
Adding support for the capability to drop the CRC24B when using the turbo-decoder. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb

[PATCH v1 7/9] baseband/acc: fix potential arithmetic overflow Fix potential issue of overflow causing coverity warning.

2023-02-09 Thread Nicolas Chautru
Coverity issue: 383154 Fixes: 8e16839937 ("baseband/acc: extension of the device structure") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 2 +- drivers/baseband/acc/vrb_pmd.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/d

[PATCH v1 6/9] baseband/acc: fix iteration counter in TB mode

2023-02-09 Thread Nicolas Chautru
The iteration count was not using correct structure (4G vs 5G) in TB mode. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff

[PATCH v1 5/9] baseband/acc: prevent to dequeue more than requested

2023-02-09 Thread Nicolas Chautru
Add support for corner-case when more operations are requested than expected, in the case of encoder muxing operations. Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 27 +++

[PATCH v1 3/9] baseband/acc: remove interrupt support on VRB1

2023-02-09 Thread Nicolas Chautru
Not enabling interrupt in VRB1 PMD variant to avoid potential corner case. Fixes: 3cabc8eaf524 ("baseband/acc200: support interrupt") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/bas

[PATCH v1 4/9] baseband/acc: add explicit mbuf apend for soft output

2023-02-09 Thread Nicolas Chautru
Adding an explicit mbuf append in the case of soft output mbuf being provided. Fixes: e640f6cdfa84 ("baseband/acc200: add LDPC processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/b

[PATCH v1 1/9] baseband/acc: protection for TB negative scenario

2023-02-09 Thread Nicolas Chautru
Adding handling of negative scenario for malformed Transport Block mode operations. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 20 1 file changed, 20 insertions(+) d

[PATCH v1 2/9] baseband/acc: add support for 4GUL with SO and TB

2023-02-09 Thread Nicolas Chautru
Implementation to support the case when using LTE decoder with soft output and transport block mode. Fixes: bec597b78a0 ("baseband/acc200: add LTE processing") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc/rte_vrb_pmd.c | 21 +++-- 1 file changed, 1

[PATCH v1 0/9] baseband/acc: VRB PMD fixes

2023-02-09 Thread Nicolas Chautru
Hi, Series of mainly fixes for corner-cases and protection in the VRB PMD. The last 2 commits are not fixes but add support for missing minor capability, as well as a request to remove printf from code (function called from bbdev-test). Thanks Nic Nicolas Chautru (9): baseband/acc: protection

Re: [PATCH v2] eal: introduce atomics abstraction

2023-02-09 Thread Ferruh Yigit
On 2/9/2023 5:40 PM, Tyler Retzlaff wrote: > On Thu, Feb 09, 2023 at 12:53:41PM +, Ferruh Yigit wrote: >> On 2/9/2023 9:04 AM, Bruce Richardson wrote: >>> On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote: Introduce atomics abstraction that permits optional use of standard C11

Re: [PATCH v2] eal: introduce atomics abstraction

2023-02-09 Thread Tyler Retzlaff
On Thu, Feb 09, 2023 at 08:19:14PM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Thursday, 9 February 2023 19.15 > > > > On Thu, Feb 09, 2023 at 09:05:46AM +0100, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roret...@linux.microso

Re: [PATCH v4 1/2] ethdev: introduce the PHY affinity field in Tx queue API

2023-02-09 Thread Ferruh Yigit
On 2/3/2023 1:33 PM, Jiawei Wang wrote: > When multiple physical ports are connected to a single DPDK port, > (example: kernel bonding, DPDK bonding, failsafe, etc.), > we want to know which physical port is used for Rx and Tx. > I assume "kernel bonding" is out of context, but this patch concern

RE: [PATCH v2] eal: introduce atomics abstraction

2023-02-09 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Thursday, 9 February 2023 19.15 > > On Thu, Feb 09, 2023 at 09:05:46AM +0100, Morten Brørup wrote: > > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > > Sent: Wednesday, 8 February 2023 22.44 > > > > > > Introduc

RE: [PATCH v9 1/2] ethdev: add query and update sync and async function calls

2023-02-09 Thread Gregory Etelson
Hello Andrew, > On 2/2/23 14:54, Gregory Etelson wrote: > > diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c > > index 7d0c24366c..4554c8f021 100644 > > --- a/lib/ethdev/rte_flow.c > > +++ b/lib/ethdev/rte_flow.c > > @@ -1883,3 +1883,85 @@ rte_flow_async_action_handle_query(uint16_t > po

RE: [PATCH v7 2/4] event/dlb2: remove superfluous rte_memcpy

2023-02-09 Thread Sevincer, Abdullah
Acked: by abdullah.sevin...@intel.com -Original Message- From: Morten Brørup Sent: Thursday, February 9, 2023 8:51 AM To: dev@dpdk.org; roret...@linux.microsoft.com; rm...@marvell.com; McDaniel, Timothy ; ma...@nvidia.com; viachesl...@nvidia.com Cc: ruifeng.w...@arm.com; zhou...@loongso

Re: [PATCH v2] eal: introduce atomics abstraction

2023-02-09 Thread Tyler Retzlaff
On Thu, Feb 09, 2023 at 09:05:46AM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > > Sent: Wednesday, 8 February 2023 22.44 > > > > Introduce atomics abstraction that permits optional use of standard C11 > > atomics when meson is provided the new enable

Re: [PATCH v2] eal: introduce atomics abstraction

2023-02-09 Thread Tyler Retzlaff
On Thu, Feb 09, 2023 at 12:53:41PM +, Ferruh Yigit wrote: > On 2/9/2023 9:04 AM, Bruce Richardson wrote: > > On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote: > >> Introduce atomics abstraction that permits optional use of standard C11 > >> atomics when meson is provided the new e

Re: [PATCH v2] eal: introduce atomics abstraction

2023-02-09 Thread Tyler Retzlaff
On Thu, Feb 09, 2023 at 09:04:16AM +, Bruce Richardson wrote: > On Wed, Feb 08, 2023 at 01:43:38PM -0800, Tyler Retzlaff wrote: > > Introduce atomics abstraction that permits optional use of standard C11 > > atomics when meson is provided the new enable_stdatomics=true option. > > > > Signed-o

Re: [PATCH] eal: introduce atomics abstraction

2023-02-09 Thread Tyler Retzlaff
On Thu, Feb 09, 2023 at 12:16:38AM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > > > > > > > > > > > > For environments where stdatomics are not supported, we could > > > > have a > > > > > > stdatomic.h in DPDK implementing the same APIs (we have to > > > > > > support > > > > only >

Re: [PATCH v7 3/3] examples/l3fwd-graph: changes to configure pcap capture

2023-02-09 Thread Jerin Jacob
On Thu, Feb 9, 2023 at 3:54 PM Amit Prakash Shukla wrote: > > Added support to configure pcap capture. > > Signed-off-by: Amit Prakash Shukla Acked-by: Jerin Jacob > --- > v2: > - Fixed code style issue > - Fixed CI compilation issue on github-robot > > v3: > - Code review suggestion from

Re: [PATCH v4 3/3] net/cnxk: skip red drop for ingress policer

2023-02-09 Thread Jerin Jacob
On Thu, Feb 9, 2023 at 2:06 PM Rakesh Kudurumalla wrote: > > Dropping of packets is based on action configured > to meter.If both skip_red and drop actions are configured > then tail dropping in invoked else if only drop action is > configured then RED drop is invoked.This action is supported > on

[PATCH v2 5/5] ipsec: fix usage of RTE_LOGTYPE_USER1

2023-02-09 Thread Stephen Hemminger
There already is a logtype in this driver, use it! Fixes: b35848bc01f6 ("crypto/ipsec_mb: add multi-process IPC request handler") Cc: kai...@intel.com Signed-off-by: Stephen Hemminger --- drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH v2 3/5] latencystats: use dynamic logtype

2023-02-09 Thread Stephen Hemminger
Libraries should not reuse RTE_LOGTYPE_USER1 for their logging. Instead they should register their own type. Fixes: 5cd3cac9ed22 ("latency: added new library for latency stats") Cc: reshma.pat...@intel.com Signed-off-by: Stephen Hemminger --- lib/latencystats/rte_latencystats.c | 55

[PATCH v2 4/5] vhost: use logtype instead of RTE_LOGTYPE_USER1

2023-02-09 Thread Stephen Hemminger
Fix instances of USER1 logtype in fdset and crypto sections. Acked-by: Chenbo Xia Signed-off-by: Stephen Hemminger --- lib/vhost/fd_man.c | 16 +--- lib/vhost/vhost_crypto.c | 25 +++-- 2 files changed, 20 insertions(+), 21 deletions(-) diff --git a/lib/vh

[PATCH v2 2/5] reorder: use a dynamic logtype

2023-02-09 Thread Stephen Hemminger
Libraries should not be reusing RTE_LOGTYPE_USER1 instead of doing proper logtype registration. Fixes: b70b56032bff ("reorder: new library") Cc: sergio.gonzalez.mon...@intel.com Signed-off-by: Stephen Hemminger --- lib/reorder/rte_reorder.c | 35 +++ 1 file change

[PATCH v2 1/5] ip_frag: use a dynamic logtype

2023-02-09 Thread Stephen Hemminger
DPDK libraries should not be reusing RTE_LOGTYPE_USER1 in lieu of doing proper logtype registration. Acked-by: Konstantin Ananyev Fixes: 416707812c03 ("ip_frag: refactor reassembly code into a proper library") Signed-off-by: Stephen Hemminger --- lib/ip_frag/ip_frag_common.h | 16 ++- lib

[PATCH v2 0/5] Replace use of RTE_LOGTYPE_USER1 in libraries.

2023-02-09 Thread Stephen Hemminger
This is split out of other rte_log patchset. The DPDK libraries and drivers should not be using the USER1 logtype. v2 - fix some compile warnings Stephen Hemminger (5): ip_frag: use a dynamic logtype reorder: use a dynamic logtype latencystats: use dynamic logtype vhost: use logtype inste

RE: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-09 Thread Naga Harish K, S V
> -Original Message- > From: Jerin Jacob > Sent: Monday, February 6, 2023 10:08 PM > To: Naga Harish K, S V > Cc: jer...@marvell.com; Carrillo, Erik G ; Gujjar, > Abhinandan S ; dev@dpdk.org; > Jayatheerthan, Jay > Subject: Re: [PATCH v2 1/3] eventdev/eth_rx: add params set/get APIs >

RE: [PATCH v1 13/13] test/bbdev: remove iteration count check

2023-02-09 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, February 9, 2023 1:11 AM > To: Vargas, Hernan ; dev@dpdk.org; > gak...@marvell.com; Rix, Tom > Cc: Chautru, Nicolas ; Zhang, Qi Z > > Subject: Re: [PATCH v1 13/13] test/bbdev: remove iteration count check > > >

[PATCH v3 2/3] eventdev/eth_tx: add params set/get APIs

2023-02-09 Thread Naga Harish K S V
The adapter configuration parameters defined in the ``struct rte_event_eth_tx_adapter_runtime_params`` can be configured and retrieved using ``rte_event_eth_tx_adapter_runtime_params_set`` and ``rte_event_eth_tx_adapter_runtime_params_get`` respectively. Signed-off-by: Naga Harish K S V --- app/

[PATCH v3 3/3] eventdev/crypto: add params set/get APIs

2023-02-09 Thread Naga Harish K S V
The adapter runtime configuration parameters defined in the ``struct rte_event_crypto_adapter_runtime_params`` can be configured and retrieved using ``rte_event_crypto_adapter_runtime_params_set`` and ``rte_event_eth_rx_adapter_runtime_params_get`` respectively. Signed-off-by: Naga Harish K S V -

[PATCH v3 1/3] eventdev/eth_rx: add params set/get APIs

2023-02-09 Thread Naga Harish K S V
The adapter configuration parameters defined in the ``struct rte_event_eth_rx_adapter_runtime_params`` can be configured and retrieved using ``rte_event_eth_rx_adapter_runtime_params_set`` and ``rte_event_eth_tx_adapter_runtime_params_get`` respectively. Signed-off-by: Naga Harish K S V --- app/

RE: [PATCH v7 3/4] net/mlx5: fix warning about rte_memcpy length

2023-02-09 Thread Morten Brørup
PING mlx5 maintainers. Care to review this minor improvement, so it can be included in 23.03? > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Monday, 16 January 2023 14.07 > > Use RTE_PTR_ADD where copying to the offset of a field in a structure > holding multiple fields, to av

RE: [PATCH v7 2/4] event/dlb2: remove superfluous rte_memcpy

2023-02-09 Thread Morten Brørup
PING dlb2 maintainers. Care to review this, so it can be included in 23.03? > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Monday, 16 January 2023 14.07 > > Copying with the same src and dst address has no effect; removed to > avoid compiler warning with decorated rte_memcpy. >

Re: [PATCH v1] dts: add Dockerfile

2023-02-09 Thread Patrick Robb
On Fri, Nov 4, 2022 at 5:16 AM Juraj Linkeš wrote: > Adding folks I forgot to add. > > > -Original Message- > > From: Juraj Linkeš > > Sent: Thursday, November 3, 2022 2:47 PM > > Cc: dev@dpdk.org; Juraj Linkeš > > Subject: [PATCH v1] dts: add Dockerfile > > > > The Dockerfile defines d

RE: [PATCH v7 1/4] net/bnx2x: fix warnings about rte_memcpy lengths

2023-02-09 Thread Morten Brørup
PING bnx2x maintainers. Care to review this bugfix, so it can be included in 23.03? > From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Monday, 16 January 2023 14.07 > > Bugfix: The vlan in the bulletin does not contain a VLAN header, only > the > VLAN ID, so only copy 2 byte, not

Re: [PATCH v5 1/3] pcapng: comment option support for epb

2023-02-09 Thread Stephen Hemminger
On Thu, 9 Feb 2023 10:13:41 +0100 David Marchand wrote: > Stephen, Reshma, > > On Fri, Feb 3, 2023 at 9:19 AM Amit Prakash Shukla > wrote: > > > > This change enhances rte_pcapng_copy to have comment in enhanced > > packet block. > > > > Signed-off-by: Amit Prakash Shukla > > Is this change

Re: [PATCH v3 00/10] dts: add hello world testcase

2023-02-09 Thread Patrick Robb
On Thu, Jan 19, 2023 at 11:16 AM Owen Hilyard wrote: > Everything looks good to me with the exception of some issues I ran into > with terminal codes. Setting TERM=dumb before running fixed it, but we > might want to set that inside of DTS since I can't think of a reason why we > would need color

Re: [PATCH v5 00/21] add support for cpfl PMD in DPDK

2023-02-09 Thread Stephen Hemminger
On Thu, 9 Feb 2023 08:45:20 + Mingxia Liu wrote: > The patchset introduced the cpfl (Control Plane Function Library) PMD > for Intel® IPU E2100’s Configure Physical Function (Device ID: 0x1453) > > The cpfl PMD inherits all the features from idpf PMD which will follow > an ongoing standard

  1   2   3   >