PING mlx5 maintainers. Care to review this minor improvement, so it can be included in 23.03?
> From: Morten Brørup [mailto:m...@smartsharesystems.com] > Sent: Monday, 16 January 2023 14.07 > > Use RTE_PTR_ADD where copying to the offset of a field in a structure > holding multiple fields, to avoid compiler warnings with decorated > rte_memcpy. > > Fixes: 16a7dbc4f69006cc1c96ca2a2c6d3e3c51a2ff50 ("net/mlx5: make flow > modify action list thread safe") > Cc: xuemi...@nvidia.com > Cc: ma...@nvidia.com > Cc: viachesl...@nvidia.com > > Signed-off-by: Morten Brørup <m...@smartsharesystems.com> > --- > v7: > * No changes. > v6: > * Add Fixes to patch description. > v5: > * First patch in series. > --- > drivers/net/mlx5/mlx5_flow_dv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow_dv.c > b/drivers/net/mlx5/mlx5_flow_dv.c > index 62c38b87a1..dd9f5fda1a 100644 > --- a/drivers/net/mlx5/mlx5_flow_dv.c > +++ b/drivers/net/mlx5/mlx5_flow_dv.c > @@ -5662,7 +5662,7 @@ flow_dv_modify_create_cb(void *tool_ctx, void > *cb_ctx) > "cannot allocate resource memory"); > return NULL; > } > - rte_memcpy(&entry->ft_type, > + rte_memcpy(RTE_PTR_ADD(entry, offsetof(typeof(*entry), ft_type)), > RTE_PTR_ADD(ref, offsetof(typeof(*ref), ft_type)), > key_len + data_len); > if (entry->ft_type == MLX5DV_FLOW_TABLE_TYPE_FDB) > -- > 2.17.1
