[PATCH] net/ixgbe: enable IPv6 mask for generic flow API

2023-01-27 Thread Kaiwen Deng
Add IPv6 addr mask and L4 mask support for rte_flow APIs. IPv6 flow rules do not take effect in ixgbe when set IPv6 addr mask and L4 mask to default value as 0xFF. Set IPv6 addr mask and L4 mask as 0 to enable fields can fix this issue. Fixes: 11777435c727 ("net/ixgbe: parse flow director filter

[PATCH v8] doc: add PMD known issue

2023-01-27 Thread Mingjin Ye
Add a known issue: Rx path dynamic change is not supported for PMD. Fixes: de853a3bb151 ("net/ice: disable DDP package on Windows") Cc: sta...@dpdk.org Signed-off-by: Mingjin Ye --- doc/guides/nics/ice.rst | 12 1 file changed, 12 insertions(+) diff --git a/doc/guides/nics/ice.rst

[PATCH] vhost: fix vdpa driver multi-queue initialization failure

2023-01-27 Thread Hao Chen
When 'virtio_is_Ready' returns 1, 'vdpa_dev->ops->dev_conf' will be called, and the vdpa driver called 'rte_vhost_get_vhost_vring' to get the vring addr info from 'vhost_devices->virtqueue[]'. virtio_is_ready's nr_vring is VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY(2), multi-queue's nr_vring is greater tha

[PATCH] vhost: fix vdpa driver multi-queue initialization failure

2023-01-27 Thread Hao Chen
When 'virtio_is_Ready' returns 1, 'vdpa_dev->ops->dev_conf' will be called, and the vdpa driver called 'rte_vhost_get_vhost_vring' to get the vring addr info from 'vhost_devices->virtqueue[]'. virtio_is_ready's nr_vring is VIRTIO_BUILTIN_NUM_VQS_TO_BE_READY(2), multi-queue's nr_vring is greater tha

Re: [PATCH V4 0/5] app/testpmd: support mulitple process attach and detach port

2023-01-27 Thread lihuisong (C)
在 2023/1/19 22:35, Thomas Monjalon 写道: 19/01/2023 11:31, lihuisong (C): 在 2023/1/18 22:12, Thomas Monjalon 写道: 11/01/2023 11:46, Ferruh Yigit: On 1/11/2023 10:27 AM, Ferruh Yigit wrote: On 1/11/2023 12:53 AM, lihuisong (C) wrote: 在 2023/1/11 0:51, Ferruh Yigit 写道: Hi Huisong, I haven't c

Re: [PATCH V5] ethdev: fix one address occupies two indexes in MAC addrs

2023-01-27 Thread lihuisong (C)
在 2023/1/19 22:38, Thomas Monjalon 写道: Hi, You missed some questions and comments below. Sorry for my later reply. I just got back from vacation. Please take a look again. 19/01/2023 10:57, lihuisong (C): 在 2023/1/18 16:26, Thomas Monjalon 写道: 20/10/2022 11:31, Huisong Li: The dev->data-

Re: [PATCH v4] app/testpmd: fix interactive mode with no ports

2023-01-27 Thread Ferruh Yigit
On 1/19/2023 5:45 PM, Gregory Etelson wrote: > Testpmd terminated unconditionally if it failed to start all ports. > > The patch allows testpmd to get into the command line, > if the interactive mode was requested. > > Fixes: 6937d2103e22 ("app/testpmd: add option to not start device") > > Cc: s

[PATCH] app/testpmd: fix link check condition on port start

2023-01-27 Thread Ferruh Yigit
In testpmd port start function, 'need_check_link_status' variable is used to detect if a link check is required after port is started. Intention is if at least one port is started, link check should be called, and initially 'need_check_link_status' used as following: ``` start_port need_ch

[PATCH v2 2/2] vhost: fix possible FD leaks on truncation

2023-01-27 Thread Maxime Coquelin
This patch fixes possible FDs leaks when truncation happens on either the message buffer or its control data. Indeed, by returning early, it did not let a chance to retrieve the FDs passed as ancillary data, and so caused a potential FDs leak. This patch fixes this by extracting the FDs from the a

[PATCH v2 2/2] vhost: fix possible FD leaks on MSG_TRUNC and MSG_CTRUNC

2023-01-27 Thread Maxime Coquelin
This patch fixes possible FDs leaks when truncation happens on either the message buffer or its control data. Indeed, by returning early, it did not let a chance to retrieve the FDs passed as ancillary data, and so caused a potential FDs leak. This patch fixes this by extracting the FDs from the a

[PATCH v2 1/2] vhost: fix possible FDs leak

2023-01-27 Thread Maxime Coquelin
On failure, read_vhost_message() only closed the message FDs if the header size was unexpected, but there are other cases where it is required. For exemple in the case the payload size read from the header is greater than the expected maximum payload size. This patch fixes this by closing all mess

[PATCH v2 0/2] Vhost: fix FD leaks and improve logs

2023-01-27 Thread Maxime Coquelin
This two-patches series fix possible FD leaks when receiving Vhost-user messages fails. It also improve logging by differentiating message's buffer truncation and control data truncation. Maxime Coquelin (2): vhost: fix possible FDs leak vhost: fix possible FD leaks on truncation lib/vhost/s

Re: [PATCH] vhost: improve truncated messages handling

2023-01-27 Thread Maxime Coquelin
On 1/27/23 14:57, Maxime Coquelin wrote: This patch improves truncated messages logging to ease debugging. First, it differentiates between message's buffer truncation and control data truncation. Indeed, MSG_CTRUNC can happen even if enough room was provided, in case LSM detects access right

Re: [PATCH 8/8] net/txgbe: add SFP hot-plug identification support

2023-01-27 Thread Ferruh Yigit
On 1/18/2023 6:00 AM, Jiawen Wu wrote: > Support to identify the new SFP/SFP+ module when the device is started. > > Signed-off-by: Jiawen Wu <...> > @@ -2972,9 +3029,6 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, > rte_intr_type_get(intr_handle) != RTE_INTR_HANDLE_V

Re: [PATCH 4/8] net/ngbe: fix packet type to parse from offload flags

2023-01-27 Thread Ferruh Yigit
On 1/18/2023 6:00 AM, Jiawen Wu wrote: > In some external applications, developers may fill in wrong packet_type > in rte_mbuf for transmission. It will result in Tx ring hang when Tx > checksum offload is on. So change it to parse from ol_flags. And remove > redundant tunnel type since the NIC doe

Re: [PATCH 3/8] net/txgbe: fix packet type to parse from offload flags

2023-01-27 Thread Ferruh Yigit
On 1/18/2023 6:00 AM, Jiawen Wu wrote: > In some external applications, developers may fill in wrong packet_type > in rte_mbuf for transmission. It will result in Tx ring hang when Tx > checksum offload is on. So change it to parse from ol_flags. > Can you please give more information on what pac

Re: [PATCH 1/8] net/txgbe: fix Rx buffer size in configure register

2023-01-27 Thread Ferruh Yigit
On 1/18/2023 6:00 AM, Jiawen Wu wrote: > When round up buffer size to 1K, to configure the register, hardware will > receive packets exceeding the buffer size in LRO mode. It will cause a > segment fault in the receive function. > > Fixes: be797cbf4582 ("net/txgbe: add Rx and Tx init") > Cc: sta..

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-27 Thread Thomas Monjalon
27/01/2023 11:42, Nithin Kumar Dabilpuram: > From: Thomas Monjalon > > 27/01/2023 06:02, Nithin Kumar Dabilpuram: > > > From: Thomas Monjalon > > > > Ferruh is proposing to have a command "port config ..." > > > > to configure the flags to negotiate. > > > > Are you OK with this approach? > > >

Re: [PATCH v5 4/8] ethdev: use GRE protocol struct for flow matching

2023-01-27 Thread Niklas Söderlund
Hi Ferruh and Thomas, Thanks for your work. On 2023-01-26 16:19:00 +, Ferruh Yigit wrote: > From: Thomas Monjalon > > As announced in the deprecation notice, flow item structures > should re-use the protocol header definitions from the directory lib/net/. > > The protocol struct is added i

[PATCH] vhost: improve truncated messages handling

2023-01-27 Thread Maxime Coquelin
This patch improves truncated messages logging to ease debugging. First, it differentiates between message's buffer truncation and control data truncation. Indeed, MSG_CTRUNC can happen even if enough room was provided, in case LSM detects access rights issue. Then, it does not return directly in

Re: [EXT] Re: [dpdk-dev] [PATCH v1 00/12] mldev: introduce machine learning device library

2023-01-27 Thread Thomas Monjalon
Hi, Shivah Shankar, please quote your replies so we can distinguish what I said from what you say. Please try to understand my questions, you tend to reply to something else. 27/01/2023 05:29, Jerin Jacob: > On Fri, Jan 27, 2023 at 8:04 AM Shivah Shankar Shankar Narayan Rao > wrote: > > 25/01/

Re: deprecation notice process / clarification

2023-01-27 Thread Thomas Monjalon
25/01/2023 23:36, Tyler Retzlaff: > hi, > > i'm looking for some guidance when cleaning up / removing the remaining > shim functions for pthread in windows and i'm not sure how our > deprecation notice / policies apply. > > windows has been providing lib/eal/windows/include/pthread.h shim that >

Re: [PATCH] vhost: decrease log level for unimplemented request

2023-01-27 Thread Maxime Coquelin
Hi Kevin, On 12/8/22 12:10, Kevin Traynor wrote: On 06/12/2022 15:02, Maxime Coquelin wrote: This patch changes VHOST_USER_SET_VRING_ERR "not implemented" log level from INFO to DEBUG. Indeed, it is not required to support this message type, and since version 7.1, QEMU sends this message for e

RE: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-27 Thread Nithin Kumar Dabilpuram
> -Original Message- > From: Thomas Monjalon > Sent: Friday, January 27, 2023 2:25 PM > To: Nithin Kumar Dabilpuram > Cc: Aman Singh ; Yuying Zhang > ; > Ivan Malov ; Andrew Rybchenko > ; dev@dpdk.org; Hanumanth Reddy Pothula > ; Ferruh Yigit ; > viachesl...@nvidia.com; > Jerin Jacob

Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-01-27 Thread Jerin Jacob
On Fri, Jan 27, 2023 at 2:56 PM Thomas Monjalon wrote: > > 27/01/2023 10:02, Jerin Jacob: > > On Fri, Jan 27, 2023 at 2:20 PM Thomas Monjalon wrote: > > > 27/01/2023 07:40, Jerin Jacob: > > > > On Thu, Jan 26, 2023 at 4:27 PM Thomas Monjalon > > > > wrote: > > > > > 25/01/2023 15:59, Srikanth Y

Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-01-27 Thread Thomas Monjalon
27/01/2023 10:02, Jerin Jacob: > On Fri, Jan 27, 2023 at 2:20 PM Thomas Monjalon wrote: > > 27/01/2023 07:40, Jerin Jacob: > > > On Thu, Jan 26, 2023 at 4:27 PM Thomas Monjalon > > > wrote: > > > > 25/01/2023 15:59, Srikanth Yalavarthi: > > > > > From: Thomas Monjalon > > > > > > 25/01/2023 14:

Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-01-27 Thread Jerin Jacob
On Fri, Jan 27, 2023 at 2:20 PM Thomas Monjalon wrote: > > 27/01/2023 07:40, Jerin Jacob: > > On Thu, Jan 26, 2023 at 4:27 PM Thomas Monjalon wrote: > > > 25/01/2023 15:59, Srikanth Yalavarthi: > > > > From: Thomas Monjalon > > > > > 25/01/2023 14:25, Srikanth Yalavarthi: > > > > > > From: Thoma

Re: [EXT] Re: [PATCH v5 2/2] app/testpmd: add command to process Rx metadata negotiation

2023-01-27 Thread Thomas Monjalon
27/01/2023 06:02, Nithin Kumar Dabilpuram: > From: Thomas Monjalon > > Ferruh is proposing to have a command "port config ..." > > to configure the flags to negotiate. > > Are you OK with this approach? > > Yes, we are fine to have such command to enable and disable the feature > with default be

Re: [EXT] Re: [PATCH v3 0/4] implementation of ML common code

2023-01-27 Thread Thomas Monjalon
27/01/2023 07:40, Jerin Jacob: > On Thu, Jan 26, 2023 at 4:27 PM Thomas Monjalon wrote: > > 25/01/2023 15:59, Srikanth Yalavarthi: > > > From: Thomas Monjalon > > > > 25/01/2023 14:25, Srikanth Yalavarthi: > > > > > From: Thomas Monjalon > > > > > > 20/12/2022 18:52, Srikanth Yalavarthi: > > > >