On 1/18/2023 6:00 AM, Jiawen Wu wrote: > Support to identify the new SFP/SFP+ module when the device is started. > > Signed-off-by: Jiawen Wu <jiawe...@trustnetic.com>
<...> > @@ -2972,9 +3029,6 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, > rte_intr_type_get(intr_handle) != RTE_INTR_HANDLE_VFIO_MSIX) > wr32(hw, TXGBE_PX_INTA, 1); > > - /* clear all cause mask */ > - txgbe_disable_intr(hw); > - This change looks like a major one, is it related to the "SFP/SFP+ module"? I assume this is replace by below line [1], if this is unrelated please separate it to its own patch, and if it related can you please explain why it is related in the commit log. > /* read-on-clear nic registers here */ > eicr = ((u32 *)hw->isb_mem)[TXGBE_ISB_MISC]; > PMD_DRV_LOG(DEBUG, "eicr %x", eicr); > @@ -3000,6 +3054,8 @@ txgbe_dev_interrupt_get_status(struct rte_eth_dev *dev, > if (eicr & TXGBE_ICRMISC_HEAT) > intr->flags |= TXGBE_FLAG_OVERHEAT; > [1] > + ((u32 *)hw->isb_mem)[TXGBE_ISB_MISC] = 0; > +
