RE: [PATCH v2 2/2] doc: simplify the binding steps

Hi Thomas, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, November 22, 2022 7:01 AM > To: Chautru, Nicolas > Cc: dev@dpdk.org; gak...@marvell.com; maxime.coque...@redhat.com; > Vargas, Hernan > Subject: Re: [PATCH v2 2/2] doc: simplify the binding steps > > 15/11/2022 2

Re: [PATCH v2] net/pcap: fix timeout of stopping device

On Tue, 22 Nov 2022 09:25:33 + "Zhou, YidingX" wrote: > > -Original Message- > > From: Zhou, YidingX > > Sent: Wednesday, September 21, 2022 3:15 PM > > To: Stephen Hemminger ; Zhang, Qi Z > > > > Cc: dev@dpdk.org; Burakov, Anatoly ; He, > > Xingguang ; sta...@dpdk.org > > Subject:

Re: [PATCH] ring: build with global includes

On Tue, Nov 22, 2022 at 09:17:50AM +, Bruce Richardson wrote: > On Tue, Nov 22, 2022 at 09:51:53AM +0100, David Marchand wrote: > > On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff > > wrote: > > > > > > On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > > > > 21/11/2022 22:27,

RE: Regarding User Data in DPDK ACL Library.

> > > > > > > > > On Thu, 17 Nov 2022 19:28:12 +0530 venkatesh bs > > > > > > wrote: > > > > > > > > > > > > > Hi DPDK Team, > > > > > > > > > > > > > > After the ACL match for highest priority DPDK Classification > > > > > > > API returns User Data Which is as mentioned below in the document. >

Re: [PATCH v2 09/11] malloc: check result of malloc_elem_free

2022-11-21 17:32 (UTC-0500), ok...@kernel.org: > From: Sinan Kaya > > In malloc_heap_free result of call to malloc_elem_free is dereferenced > here and may be null. It may not: "malloc_elem_free()" never returns NULL by definition: it takes a valid busy element and returns a valid free element.

Re: [PATCH v2 08/11] malloc: check result of rte_mem_virt2memseg

2022-11-21 17:32 (UTC-0500), ok...@kernel.org: > From: Sinan Kaya > > In malloc_elem_find_max_iova_contig result of call to rte_mem_virt2memseg > is dereferenced here and may be null. > > Signed-off-by: Sinan Kaya > --- > lib/eal/common/malloc_elem.c | 11 --- > lib/eal/common/malloc_h

Re: [PATCH v2 07/11] malloc: check result of rte_fbarray_get

2022-11-21 17:32 (UTC-0500), ok...@kernel.org: > From: Sinan Kaya > > In eal_memalloc_is_contig result of call to rte_fbarray_get > is dereferenced here and may be null. > > Signed-off-by: Sinan Kaya > --- > lib/eal/common/eal_common_memalloc.c | 5 - > 1 file changed, 4 insertions(+), 1 d

Re: [PATCH v2 06/11] malloc: check result of rte_mem_virt2memseg_list

2022-11-21 17:32 (UTC-0500), ok...@kernel.org: > From: Sinan Kaya > > In alloc_pages_on_heap result of call to rte_mem_virt2memseg_list > is dereferenced here and may be null. > > Signed-off-by: Sinan Kaya > --- > lib/eal/common/malloc_heap.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

Re: [PATCH v2 05/11] malloc: malloc_elem_join_adjacent_free can return null

2022-11-21 17:32 (UTC-0500), ok...@kernel.org: > From: Sinan Kaya > > In malloc_heap_add_memory result of call to malloc_elem_join_adjacent_free > is dereferenced here and may be null. It may not: "malloc_elem_join_adjacent_free()" never returns NULL by definition. Would annotating "malloc_elem_

Re: [PATCH v2 04/11] memzone: check result of malloc_elem_from_data

2022-11-21 17:32 (UTC-0500), ok...@kernel.org: > From: Sinan Kaya > > In memzone_reserve_aligned_thread_unsafe result of call > to malloc_elem_from_data is dereferenced here and may be null. > > Signed-off-by: Sinan Kaya Acked-by: Dmitry Kozlyuk

release candidate 22.11-rc4

A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v22.11-rc4 There are 56 new patches in this snapshot. Release notes: https://doc.dpdk.org/guides/rel_notes/release_22_11.html This is the last release candidate. Only documentation should be upda

Re: [PATCH v2] usertools/hugepages: show usage if no action specified

22/11/2022 16:38, David Marchand: > On Tue, Nov 22, 2022 at 4:33 PM Thomas Monjalon wrote: > > > > Previously, the script was doing nothing if no argument was provided. > > > > If neither show, mount/unmount, clear/reserve are specified, > > it is assumed that the user does not know how to use the

Re: [PATCH v2] usertools/hugepages: show usage if no action specified

On Tue, Nov 22, 2022 at 4:33 PM Thomas Monjalon wrote: > > Previously, the script was doing nothing if no argument was provided. > > If neither show, mount/unmount, clear/reserve are specified, > it is assumed that the user does not know how to use the script. > So the usage and an error message a

[PATCH v2] usertools/hugepages: show usage if no action specified

Previously, the script was doing nothing if no argument was provided. If neither show, mount/unmount, clear/reserve are specified, it is assumed that the user does not know how to use the script. So the usage and an error message are printed. The exit code will be non-zero. The user will understan

[PATCH RESEND v2 11/11] bus/vdev: check result of rte_vdev_device_name

From: Sinan Kaya In rte_eth_vdev_allocate result of call to rte_vdev_device_name is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/ethdev/ethdev_vdev.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ethdev/ethdev_vdev.h b/lib/ethdev/ethdev_vdev.h index 364f140f

[PATCH RESEND v2 10/11] malloc: check result of elem_start_pt

From: Sinan Kaya In malloc_elem_alloc result of call to elem_start_pt is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_elem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/malloc_elem.c b/lib/eal/common/malloc_elem.c index 8f4981

[PATCH RESEND v2 09/11] malloc: check result of malloc_elem_free

From: Sinan Kaya In malloc_heap_free result of call to malloc_elem_free is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c index 8827

[PATCH RESEND v2 07/11] malloc: check result of rte_fbarray_get

From: Sinan Kaya In eal_memalloc_is_contig result of call to rte_fbarray_get is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memalloc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_memalloc.c b/

[PATCH RESEND v2 08/11] malloc: check result of rte_mem_virt2memseg

From: Sinan Kaya In malloc_elem_find_max_iova_contig result of call to rte_mem_virt2memseg is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_elem.c | 11 --- lib/eal/common/malloc_heap.c | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-)

[PATCH RESEND v2 06/11] malloc: check result of rte_mem_virt2memseg_list

From: Sinan Kaya In alloc_pages_on_heap result of call to rte_mem_virt2memseg_list is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/malloc_heap.c

[PATCH RESEND v2 04/11] memzone: check result of malloc_elem_from_data

From: Sinan Kaya In memzone_reserve_aligned_thread_unsafe result of call to malloc_elem_from_data is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/common/eal_common_memzone.c

[PATCH RESEND v2 05/11] malloc: malloc_elem_join_adjacent_free can return null

From: Sinan Kaya In malloc_heap_add_memory result of call to malloc_elem_join_adjacent_free is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/malloc_heap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/eal/common/malloc_heap.c b/lib/eal/common/mallo

[PATCH RESEND v2 03/11] memzone: check result of rte_fbarray_get

From: Sinan Kaya In memzone_lookup_thread_unsafe result of call to rte_fbarray_get is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- lib/eal/common/eal_common_memzone.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/eal/common/eal_common_memzone.

[PATCH RESEND v2 02/11] net/tap: check if name is null

From: Sinan Kaya In rte_pmd_tun_probe result of call to rte_vdev_device_name is dereferenced here and may be null. Signed-off-by: Sinan Kaya --- drivers/net/tap/rte_eth_tap.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c in

[PATCH RESEND v2 01/11] ethdev: check return result of rte_eth_dev_info_get

From: Sinan Kaya rte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get is not checked, potentially leaving dev_info uninitialized. Signed-off-by: Sinan Kaya --- lib/ethdev/rte_class_eth.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ethdev/rt

[PATCH RESEND v2 00/11] codeql fixes for various subsystems

From: Sinan Kaya Following up the codeql reported problems first submitted by Stephen Hemminger here: https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ Posting a series of fixes about potential null pointer accesses. Changes from v1: - Remove braces around single line stateme

Re: [PATCH v2 00/11] codeql fixes for various subsystems

On Tue, 2022-11-22 at 16:24 +0100, David Marchand wrote: > Thanks for the fixes, but it looks like the v2 series is truncated. > > Can you resend it so it passes through the CI? Sure

Re: [PATCH v2] mempool: fix rte_mempool_avail_count may segment fault when used in multiprocess

Hi, On Tue, Nov 15, 2022 at 08:35:02PM +0800, Fengnan Chang wrote: > rte_mempool_create put tailq entry into rte_mempool_tailq list before > populate, and pool_data set when populate. So in multi process, if > process A create mempool, and process B can get mempool through > rte_mempool_lookup bef

Re: [PATCH v2 00/11] codeql fixes for various subsystems

Hello, On Mon, Nov 21, 2022 at 11:32 PM wrote: > > From: Sinan Kaya > > Following up the codeql reported problems first submitted > by Stephen Hemminger here: > > https://lore.kernel.org/all/20220527161210.77212d0b@hermes.local/t/ > > Posting a series of fixes about potential null pointer access

Re: [PATCH] usertools/hugepages: show usage if no action specified

07/11/2022 10:39, Robin Jarry: > Thomas Monjalon, Nov 04, 2022 at 12:30: > > Previously, the script was doing nothing if no argument was provided. > > > > If neither show, mount/unmount, clear/reserve are specified, > > it is assumed that the user does not know how to use the script. > > So the usa

Re: [PATCH v2] doc: avoid meson deprecation in setup

On Tue, Nov 22, 2022 at 12:38 PM David Marchand wrote: > > From: Stephen Hemminger > > The command "meson build" causes a deprecation warning with meson 0.64.0. > > WARNING: Running the setup command as `meson [options]` instead of > `meson setup [options]` is ambiguous and deprecated. > > Th

Re: [PATCH] bus/pci: fix leak with multiple bus scan

On Mon, Nov 21, 2022 at 12:12 PM David Marchand wrote: > > The addition of the bus_info field did not account for the fact that the > PCI bus can be scanned multiple times (like for device hotplug and other > uses in SPDK). > Indeed, during pci_scan_one() for devices that were already registered,

Re: [PATCH v2 2/2] doc: simplify the binding steps

15/11/2022 20:59, Nicolas Chautru: > -The PCI virtual functions must be configured before working or getting > assigned > -to VMs/Containers. The configuration involves allocating the number of > hardware > +The device must be configured to work properly. > +The configuration involves allocating

Re: [PATCH v2 1/2] doc: make the Linux drivers doc more generic

15/11/2022 20:59, Nicolas Chautru: > Minor change so that for the documentation to be less NIC centric, > as these steps can apply more generally to PCIe devices. > > Signed-off-by: Nicolas Chautru [...] > Different PMDs may require different kernel drivers in order to work > properly. > Depen

Re: [PATCH 2/2] docs: sort files lists in generator scripts

14/11/2022 15:29, Bruce Richardson: > On Mon, Nov 14, 2022 at 02:22:25PM +, luca.bocca...@gmail.com wrote: > > From: Luca Boccassi > > > > In order to build the documentation in a reproducible manner, sort the > > lists of > > files used as input, since walking the filesystem is not guarante

RE: Regarding User Data in DPDK ACL Library.

> -Original Message- > From: Honnappa Nagarahalli > Sent: Monday, November 21, 2022 4:57 PM > To: Konstantin Ananyev ; Stephen Hemminger > ; venkatesh bs > > Cc: us...@dpdk.org; dev@dpdk.org; nd ; nd > Subject: RE: Regarding User Data in DPDK ACL Library. > > > > > > > > > On Thu, 1

Re: [PATCH v2] doc: fix max supported packet len for virtio driver

22/11/2022 10:36, Maxime Coquelin: > > On 11/19/22 09:24, li...@chinatelecom.cn wrote: > > From: Yi Li > > > > According to VIRTIO_MAX_RX_PKTLEN macro definition, for virtio driver > > currently supported pkt size is 9728. > > > > Fixes: fc1f2750a3ec ("doc: programmers guide") +Cc: sta...@dpdk

[PATCH] net/nfp: update descriptors logic

From: Jin Liu The minimum value of TX/RX descriptors for NFP3800 card is not same with NFP4000 card, the minimum value of NFP4000 card is 256 while NFP3800 card is 512, add the minimum descriptor macro for NFP3800 card. Modify the logic of get descriptor value, assign the value of descriptor for

Re: [PATCH] drivers: remove unused build variable

02/11/2022 13:17, Bruce Richardson: > On Mon, Oct 31, 2022 at 11:44:44AM +0100, Thomas Monjalon wrote: > > The variable fmt_name has been removed from DPDK 21.02-rc1. > > Then some drivers were integrated in the same year with this variable. > > Of this course it has no effect, so it is cleaned up.

[PATCH] net/mlx5: fix available tag registers calculation for HWS

Before this patch, if two ports in separate switch domains were probed by an application, the shared array of available TAG registers was calculated incorrectly. When the intersection of supported REG_C registers and available TAG registers was calculated, capabilities were checked against an inde

Re: [PATCH] pipeline: fix validate header instruction

21/11/2022 15:24, Cristian Dumitrescu: > From: Yogesh Jangra > > The exported data structure for the header validate instruction did > not populate its struct_id field, which results in segmentation fault. > > Fixes: 216bc906d00 ("pipeline: export pipeline instructions to file") > Cc: sta...@dpd

Re: [PATCH v2] doc: avoid meson deprecation in setup

On Tue, Nov 22, 2022 at 12:38 PM David Marchand wrote: > > From: Stephen Hemminger > > The command "meson build" causes a deprecation warning with meson 0.64.0. > > WARNING: Running the setup command as `meson [options]` instead of > `meson setup [options]` is ambiguous and deprecated. > > Th

Re: [dpdk-dev v7] doc: support IPsec Multi-buffer lib v1.3

21/11/2022 17:35, Kai Ji: > From: Pablo de Lara > > Updated AESNI MB and AESNI GCM, KASUMI, ZUC, SNOW3G > and CHACHA20_POLY1305 PMD documentation guides > with information about the latest Intel IPSec Multi-buffer > library supported. > > Signed-off-by: Pablo de Lara > Acked-by: Ciara Power >

[PATCH v2] doc: avoid meson deprecation in setup

From: Stephen Hemminger The command "meson build" causes a deprecation warning with meson 0.64.0. WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated. Therefore fix the examples in the documentation. Signed-off-by: Stephen

RE: release candidate 22.11-rc3

> -Original Message- > From: Jiang, YuX > Sent: Monday, November 21, 2022 9:51 PM > To: 'Thomas Monjalon' ; dev (dev@dpdk.org) > > Cc: Devlin, Michelle ; Mcnamara, John > ; Richardson, Bruce > ; Zhang, Qi Z > Subject: RE: release candidate 22.11-rc3 > > > -Original Message- > > Fr

dpdk l2fwd performance issue in VM

Hi All, I'm trying to deploy a l2fwd application on VMs to test it. I have a 1Gbps link speed NIC, when I run a simple l2fwd application able to achieve 1gbps traffic without any loss of packet. I have modified the l2fwd application a bit. I have two l2fwd applications namely P1 and P2. P1 receive

OvS DPDK inside a VM/Guest

Hello All, I hope you are doing well. I am a student of TU Dresden, I am reaching out to you regarding a question posted for running OvS-DPDK inside a virtual machine. (https://inbox.dpdk.org/dev/caej-pb5a9bxohcbc8d8trtwxqva95h1cwou3zotnox+r0f3...@mail.gmail.com/) I need to run simulations on

Re: [PATCH v2] doc: fix max supported packet len for virtio driver

On 11/19/22 09:24, li...@chinatelecom.cn wrote: From: Yi Li According to VIRTIO_MAX_RX_PKTLEN macro definition, for virtio driver currently supported pkt size is 9728. Fixes: fc1f2750a3ec ("doc: programmers guide") Signed-off-by: Yi Li --- v2 change: Add "Fixes:" description in commit me

Re: [PATCH] bus/pci: fix bus info memleak during PCI scan

On Mon, Nov 21, 2022 at 9:44 AM David Marchand wrote: > > On Fri, Nov 18, 2022 at 2:36 PM Tomasz Zawadzki > wrote: > > > > During pci_scan_one() for devices that were already registered > > the pci_common_set() is called to set some of the fields again. > > > > This resulted in bus_info allocatio

RE: [PATCH v2] net/pcap: fix timeout of stopping device

> -Original Message- > From: Zhou, YidingX > Sent: Wednesday, September 21, 2022 3:15 PM > To: Stephen Hemminger ; Zhang, Qi Z > > Cc: dev@dpdk.org; Burakov, Anatoly ; He, > Xingguang ; sta...@dpdk.org > Subject: RE: [PATCH v2] net/pcap: fix timeout of stopping device > > > > >

Re: Commit broke 32-bit testpmd app

Hi, In my initial reply (see below), I also asked if you had logs to share. And wondered whether it happens with Virtio PCI or Virtio-user? Regards, Maxime On 11/16/22 00:30, Sampath Peechu (speechu) wrote: ++ dev@dpdk.org *From: *Maxime Coquelin *Date: *Tuesday, Novemb

Re: [PATCH] ring: build with global includes

On Tue, Nov 22, 2022 at 09:51:53AM +0100, David Marchand wrote: > On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff > wrote: > > > > On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > > > 21/11/2022 22:27, Konstantin Ananyev: > > > > From: Tyler Retzlaff > > > > > e.g. i don't see.

Re: [PATCH v2] doc: update QAT device support

18/11/2022 18:19, Brian Dooley: > Update what drivers and devices are supported for Asymmetric Crypto > Service on QAT > > Signed-off-by: Brian Dooley Acked-by: Kai Ji Applied, thanks.

Re: [PATCH] ring: build with global includes

On Mon, Nov 21, 2022 at 11:49 PM Tyler Retzlaff wrote: > > On Mon, Nov 21, 2022 at 10:36:24PM +0100, Thomas Monjalon wrote: > > 21/11/2022 22:27, Konstantin Ananyev: > > > From: Tyler Retzlaff > > > > e.g. i don't see. > > > > > > > > deps += ['eal'] > > > > > > > > is the dependency on eal the l

Re: [PATCH v7 1/1] app/testpmd: add valid check to verify multi mempool feature

On 11/22/2022 6:52 AM, Tang, Yaqi wrote: > >> -Original Message- >> From: Han, YingyaX >> Sent: Tuesday, November 22, 2022 2:43 PM >> To: Hanumanth Pothula ; Singh, Aman Deep >> ; Zhang, Yuying >> Cc: dev@dpdk.org; andrew.rybche...@oktetlabs.ru; tho...@monjalon.net; >> Jiang, YuX ; jer..

Re: [PATCH 2/2] doc: update MLX5 LRO limitation

22/11/2022 06:17, Gregory Etelson: > Hello Thomas, > > > > .. note:: > > > > > > MAC addresses not already present in the bridge table of the > > associated > > > > If you would like to read the doc, I guess you'd prefer to find this info > > in the section dedicated to LRO, not in a random