RE: [EXT] Re: [PATCH v4 1/1] app/testpmd: add valid check to verify multi mempool feature

2022-11-18 Thread Hanumanth Reddy Pothula
> -Original Message- > From: Ferruh Yigit > Sent: Saturday, November 19, 2022 2:26 AM > To: Hanumanth Reddy Pothula ; > tho...@monjalon.net; andrew.rybche...@oktetlabs.ru; Nithin Kumar > Dabilpuram > Cc: dev@dpdk.org; yux.ji...@intel.com; Jerin Jacob Kollanukkaran > ; Aman Singh ; Yuyin

[PATCH] ring: build with global includes

2022-11-18 Thread Tyler Retzlaff
Meson include global_inc so that rte_config.h can be found in the include path. Signed-off-by: Tyler Retzlaff --- lib/ring/meson.build | 2 ++ 1 file changed, 2 insertions(+) diff --git a/lib/ring/meson.build b/lib/ring/meson.build index c20685c..defd9da 100644 --- a/lib/ring/meson.build +++ b/

[PATCH] ring: build with global includes

2022-11-18 Thread Tyler Retzlaff
ring has no dependencies and should be able to be built standalone but cannot be since it cannot find rte_config.h. this change directs meson to include global_inc paths just like is done with other libraries e.g. telemetry. Tyler Retzlaff (1): ring: build with global includes lib/ring/meson.b

Re: [PATCH v4 1/1] app/testpmd: add valid check to verify multi mempool feature

2022-11-18 Thread Ferruh Yigit
On 11/18/2022 2:13 PM, Hanumanth Pothula wrote: > Validate ethdev parameter 'max_rx_mempools' to know whether > device supports multi-mempool feature or not. > My preference would be revert the testpmd patch [1] that adds this new feature after -rc2, and add it back next release with new testpmd

DPDK Release Status Meeting 2022-11-17

2022-11-18 Thread Mcnamara, John
Release status meeting minutes 2022-11-17 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Canonical [No] * Debian/Microsoft * Intel * Marvell * Nvidia * Red Hat * Xilinx/AMD Release Dates - The fo

[PATCH v2] doc: update QAT device support

2022-11-18 Thread Brian Dooley
Update what drivers and devices are supported for Asymmetric Crypto Service on QAT Signed-off-by: Brian Dooley --- doc/guides/cryptodevs/qat.rst | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst in

RE: [PATCH] failsafe: fix segfault on hotplug event

2022-11-18 Thread Konstantin Ananyev
Hi Luc, > > Hi Konstantin, > > > > > It is not recommended way to update rte_eth_fp_ops[] contents directly. > > > There are eth_dev_fp_ops_setup()/ eth_dev_fp_ops_reset() that supposed > > > to be used for that. > > > > Good to know. I see another fix that was made in a different PMD that > >

[PATCH] net/nfp: fix return path in TSO processing function

2022-11-18 Thread Niklas Söderlund
From: Fei Qin When enable TSO, nfp_net_nfdk_tx_tso() fills segment information in Tx descriptor. However, the return path for TSO is lost and the LSO related fields of Tx descriptor is filled with zeros which prevents packets from being sent. This patch fixes the return path in TSO processing fu

RE: [RFC v2] mempool: add API to return pointer to free space on per-core cache

2022-11-18 Thread Morten Brørup
> From: Kamalakshitha Aligeri [mailto:kamalakshitha.alig...@arm.com] > Sent: Wednesday, 16 November 2022 18.25 > > Expose the pointer to free space in per core cache in PMD, so that the > objects can be directly copied to cache without any temporary storage > > Signed-off-by: Kamalakshitha Aliger

Re: [PATCH] app/testpmd: fix action destruction memory leak

2022-11-18 Thread Ferruh Yigit
On 11/18/2022 12:21 PM, Suanming Mou wrote: > Hi, > >> -Original Message- >> From: Ferruh Yigit >> Sent: Friday, November 18, 2022 6:40 PM >> To: Suanming Mou ; david.march...@redhat.com; >> Aman Singh ; Yuying Zhang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH] app/testpmd: fix action

RE: [PATCH 01/11] service: fix build with clang 15

2022-11-18 Thread Van Haaren, Harry
> -Original Message- > From: David Marchand > Sent: Friday, November 18, 2022 8:53 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Van Haaren, Harry ; Jerin > Jacob > > Subject: [PATCH 01/11] service: fix build with clang 15 > > This variable is not used. > > Bugzilla ID: 1130 > Fixes: 21

[PATCH v4 1/1] app/testpmd: add valid check to verify multi mempool feature

2022-11-18 Thread Hanumanth Pothula
Validate ethdev parameter 'max_rx_mempools' to know whether device supports multi-mempool feature or not. Bugzilla ID: 1128 Signed-off-by: Hanumanth Pothula v4: - updated if condition. v3: - Simplified conditional check. - Corrected spell, whether. v2: - Rebased on tip of next-net/main. ---

Re: [PATCH 1/3] net/nfp: fix wrong increment of free list counter

2022-11-18 Thread Ferruh Yigit
On 11/18/2022 1:44 AM, Chaoyong He wrote: > When receiving a packet that is larger than the mbuf size, the Rx > function will break the receive loop and sent a free list descriptor > with random DMA address. > > Fix this by moving the increment of the free list descriptor counter > to after the pa

[PATCH] bus/pci: fix bus info memleak during PCI scan

2022-11-18 Thread Tomasz Zawadzki
During pci_scan_one() for devices that were already registered the pci_common_set() is called to set some of the fields again. This resulted in bus_info allocation leaking, so this patch ensures they are always freed beforehand. Fixes: 8f4de2dba9b9 ("bus/pci: fill bus specific information") Sign

Re: [PATCH] net/nfp: fix the problem of mask table free

2022-11-18 Thread Ferruh Yigit
On 11/15/2022 1:13 AM, Chaoyong He wrote: > The free process of mask table has problem, should use > 'rte_has_free()' rather than 'rte_free()'. s/_has_/_hash_/ > > Fixes: ac09376096d8 ("net/nfp: add structures and functions for flow offload") > > Signed-off-by: Chaoyong He > Reviewed-by: Nikla

RE: [PATCH] app/testpmd: fix action destruction memory leak

2022-11-18 Thread Suanming Mou
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Friday, November 18, 2022 6:40 PM > To: Suanming Mou ; david.march...@redhat.com; > Aman Singh ; Yuying Zhang > > Cc: dev@dpdk.org > Subject: Re: [PATCH] app/testpmd: fix action destruction memory leak > > On 11/17/2022 8:55 AM, Suan

RE: [PATCH v2 0/4] crypto/ccp cleanup

2022-11-18 Thread Uttarwar, Sunil Prakashrao
[AMD Official Use Only - General] Hi David, Please find the below update - only one DPDK application can use ccp crypto engines (PCI bus allow/blocklist is not respected, right?), Yes, only one crypto device can be used in a DPDK application for the crypto operations. This is introduced from

RE: [PATCH v3 1/1] app/testpmd: add valid check to verify multi mempool feature

2022-11-18 Thread Hanumanth Reddy Pothula
Hi Yingya, Uploaded new patch-set, can you please help in verifying the same, https://patches.dpdk.org/project/dpdk/patch/20221118111358.3563760-1-hpoth...@marvell.com/ Regards, Hanumanth > -Original Message- > From: Han, YingyaX > Sent: Friday, November 18, 2022 12:22 PM > To: Ferruh Y

Re: [PATCH] net/nfp: fix issue of data len exceeds descriptor limitation

2022-11-18 Thread Ferruh Yigit
On 11/17/2022 8:33 AM, Chaoyong He wrote: > From: Long Wu > > If dma_len is larger than "NFDK_DESC_TX_DMA_LEN_HEAD", the value of > dma_len bitwise and NFDK_DESC_TX_DMA_LEN_HEAD maybe less than packet > head length. Fill maximum dma_len in first tx descriptor to make > sure the whole head is incl

[PATCH v3 1/1] app/testpmd: add valid check to verify multi mempool feature

2022-11-18 Thread Hanumanth Pothula
Validate ethdev parameter 'max_rx_mempools' to know whether device supports multi-mempool feature or not. Bugzilla ID: 1128 Signed-off-by: Hanumanth Pothula v4: - updated if condition. v3: - Simplified conditional check. - Corrected spell, whether. v2: - Rebased on tip of next-net/main. ---

Re: [PATCH] app/testpmd: fix action destruction memory leak

2022-11-18 Thread Ferruh Yigit
On 11/17/2022 8:55 AM, Suanming Mou wrote: > In case action handle destroy fails, the job memory was not freed > properly. This commit fixes the possible memory leak in the action > handle destruction failed case. > > Fixes: c9dc03840873 ("ethdev: add indirect action async query") > > Signed-off-

RE: Regarding User Data in DPDK ACL Library.

2022-11-18 Thread Konstantin Ananyev
> On Thu, 17 Nov 2022 19:28:12 +0530 > venkatesh bs wrote: > > > Hi DPDK Team, > > > > After the ACL match for highest priority DPDK Classification API returns > > User Data Which is as mentioned below in the document. > > > > 53. Packet Classification and Access Control — Data Plane Developmen

Re: [PATCH 02/11] vhost: fix build with clang 15

2022-11-18 Thread Maxime Coquelin
On 11/18/22 09:53, David Marchand wrote: This variable is not used. Fixes: abeb86525577 ("vhost: remove copy threshold for async path") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/vhost/virtio_net.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/vhost/virtio_net.c

Re: [PATCH] doc: fix max supported packet len for virtio driver

2022-11-18 Thread Zhang, Fan
Hi Yi, Please add "Fixes: x" description to the commit message. You may find more information in https://core.dpdk.org/contribute/. Regards, Fan On 11/18/2022 1:26 AM, li...@chinatelecom.cn wrote: From: Yi Li According to VIRTIO_MAX_RX_PKTLEN macro definition, for virtio driver current

RE: [PATCH] net/idpf: add supported ptypes get

2022-11-18 Thread Peng, Yuan
> -Original Message- > From: Xing, Beilei > Sent: Friday, November 18, 2022 11:51 AM > To: Wu, Jingjing > Cc: dev@dpdk.org; Peng, Yuan ; Xing, Beilei > > Subject: [PATCH] net/idpf: add supported ptypes get > > From: Beilei Xing > > Failed to launch l3fwd, the log shows: > port 0 ca

RE: [PATCH v3] net/idpf: fix crash when launching l3fwd

2022-11-18 Thread Peng, Yuan
> -Original Message- > From: Xing, Beilei > Sent: Friday, November 18, 2022 3:03 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Peng, Yuan ; Xing, Beilei > > Subject: [PATCH v3] net/idpf: fix crash when launching l3fwd > > From: Beilei Xing > > There's core dump when launching l3fwd with

RE: [PATCH v3] net/idpf: fix crash when launching l3fwd

2022-11-18 Thread Zhang, Qi Z
> -Original Message- > From: beilei.x...@intel.com > Sent: Friday, November 18, 2022 3:03 PM > To: Wu, Jingjing > Cc: dev@dpdk.org; Peng, Yuan ; Xing, Beilei > > Subject: [PATCH v3] net/idpf: fix crash when launching l3fwd > > From: Beilei Xing > > There's core dump when launching

RE: [PATCH V1] doc: add tested Intel platforms with Intel NICs

2022-11-18 Thread Zhang, Qi Z
> -Original Message- > From: Peng, Yuan > Sent: Thursday, November 17, 2022 1:38 PM > To: Chen, LingliX ; Zhang, Qi Z > ; dev@dpdk.org > Cc: Peng, Yuan > Subject: RE: [PATCH V1] doc: add tested Intel platforms with Intel NICs > > Acked-by: Peng, Yuan > > > -Original Message-

RE: [PATCH] net/idpf: add supported ptypes get

2022-11-18 Thread Zhang, Qi Z
> -Original Message- > From: Wu, Jingjing > Sent: Friday, November 18, 2022 2:43 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Peng, Yuan > Subject: RE: [PATCH] net/idpf: add supported ptypes get > > > > > -Original Message- > > From: Xing, Beilei > > Sent: Friday, November 18

[PATCH 11/11] test/event: fix build with clang 15

2022-11-18 Thread David Marchand
This variable is not used. Fixes: d1f3385d0076 ("test: add event timer adapter auto-test") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test/test_event_timer_adapter.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/test/test_event_timer_adapter.c b/app/test/test_event_ti

[PATCH 09/11] test/efd: fix build with clang 15

2022-11-18 Thread David Marchand
This local variable hides the more global one. The original intent was probably to use the global one. Fixes: 0e925aef2779 ("app/test: add EFD functional and perf tests") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test/test_efd_perf.c | 1 - 1 file changed, 1 deletion(-) diff --

[PATCH 10/11] test/member: fix build with clang 15

2022-11-18 Thread David Marchand
This local variable hides the more global one. The original intent was probably to use the global one. Fixes: 0cc67a96e486 ("test/member: add functional and perf tests") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test/test_member.c | 1 - app/test/test_member_perf.c | 1 - 2

[PATCH 08/11] app/testpmd: fix build with clang 15 in flow code

2022-11-18 Thread David Marchand
This variable is not used and has been copy/pasted in a lot of other code. Fixes: 938a184a1870 ("app/testpmd: implement basic support for flow API") Fixes: 55509e3a49fb ("app/testpmd: support shared flow action") Fixes: 04cc665fab38 ("app/testpmd: add flow template management") Fixes: c4b38873346b

[PATCH 07/11] app/testpmd: fix build with clang 15

2022-11-18 Thread David Marchand
This variable is used to create some artificial load. Fixes: 3c156061b938 ("app/testpmd: add noisy neighbour forwarding mode") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- app/test-pmd/noisy_vnf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/noisy_vn

[PATCH 06/11] net/ice: fix build with clang 15

2022-11-18 Thread David Marchand
This variable is not used. Fixes: 0d8d7bd720ba ("net/ice: support DDP dump switch rule binary") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/ice/ice_ddp_package.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ice/ice_ddp_package.c b/drivers/net/ice/ice_

[PATCH 05/11] net/dpaa2: fix build with clang 15

2022-11-18 Thread David Marchand
This variable is not used. Fixes: 4690a6114ff6 ("net/dpaa2: enable error queues optionally") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/dpaa2/dpaa2_rxtx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_rxtx.c b/drivers/net/d

[PATCH 04/11] net/atlantic: fix build with clang 15

2022-11-18 Thread David Marchand
This variable is not used. Fixes: 2b1472d7150c ("net/atlantic: implement Tx path") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/atlantic/atl_rxtx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/atlantic/atl_rxtx.c b/drivers/net/atlanti

[PATCH 03/11] bus/dpaa: fix build with clang 15

2022-11-18 Thread David Marchand
This variable is not used. Fixes: f38f61e982f8 ("bus/dpaa: add BMAN hardware interfaces") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/bus/dpaa/base/qbman/bman.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/bus/dpaa/base/qbman/bman.h b/drivers

[PATCH 02/11] vhost: fix build with clang 15

2022-11-18 Thread David Marchand
This variable is not used. Fixes: abeb86525577 ("vhost: remove copy threshold for async path") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/vhost/virtio_net.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/vhost/virtio_net.c b/lib/vhost/virtio_net.c index 4358899718..9abf

[PATCH 01/11] service: fix build with clang 15

2022-11-18 Thread David Marchand
This variable is not used. Bugzilla ID: 1130 Fixes: 21698354c832 ("service: introduce service cores concept") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- lib/eal/common/rte_service.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte

[PATCH 00/11] Fixes for clang 15

2022-11-18 Thread David Marchand
Fedora 37 has just been released with clang 15. The latter seems more picky wrt unused variable. Fixes have been tested in GHA with a simple patch I used in my own repo: https://github.com/david-marchand/dpdk/commit/82cd57ae5490 https://github.com/david-marchand/dpdk/actions/runs/3495454457 -- D

[Bug 1131] [22.11-rc3] vmdq && kni meson build error with gcc12.2.1+debug on Fedora37

2022-11-18 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1131 Thomas Monjalon (tho...@monjalon.net) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

RE: [PATCH] net/iavf:fix slow memory allocation

2022-11-18 Thread Jiale, SongX
> -Original Message- > From: Kaisen You > Sent: Thursday, November 17, 2022 2:57 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zhou, YidingX > ; You, KaisenX ; Wu, > Jingjing ; Xing, Beilei ; Zhang, > Qi Z > Subject: [PATCH] net/iavf:fix slow memory allocation > > In some c