Re: [PATCH v4] testpmd: cleanup cleanly from signal

On 2022-11-09 23:53, Stephen Hemminger wrote: On Wed, 9 Nov 2022 22:46:55 +0100 Mattias Rönnblom wrote: On 2022-11-09 05:10, Stephen Hemminger wrote: Do a clean shutdown of testpmd when a signal is received; instead of having testpmd kill itself. This fixes problem where a signal could be rec

RE: [PATCH v4] app/testpmd: fix protocol header display for Rx buffer split

Hi Andrew, > -Original Message- > From: Andrew Rybchenko > Sent: Thursday, November 10, 2022 2:56 PM > To: Wang, YuanX ; Singh, Aman Deep > ; Zhang, Yuying > Cc: Ding, Xuan ; Tang, Yaqi ; > dev@dpdk.org > Subject: Re: [PATCH v4] app/testpmd: fix protocol header display for Rx > buffer sp

[PATCH v1] net/iavf: fix taninted scalar

tainted_data_downcast: Downcasting match_item->meta from void * to struct virtchnl_proto_hdrs implies that the data that this pointer points to is tainted. var_assign_var: Assigning: proto_hdrs = match_item->meta. Both are now tainted. var_assign_var: Assigning: rss_meta->proto_hdrs = *proto_hdrs

Re: [PATCH v5] testpmd: cleanup cleanly from signal

On 11/9/22 20:29, Stephen Hemminger wrote: Do a clean shutdown of testpmd when a signal is received; instead of having testpmd kill itself. This fixes problem where a signal could be received in the middle of a PMD and then the signal handler would call PMD's close routine which could cause a dea

RE: [PATCH v5] vdpa/ifc: fix update_datapath error handling

> -Original Message- > From: Taekyung Kim > Sent: Thursday, November 10, 2022 12:10 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Pei, Andy ; > kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; sta...@dpdk.org; > Wang, Xiao W > Subject: [PATCH v5] vdpa/ifc: fix update_datapath error ha

RE: [PATCH v5] vdpa/ifc/base: wait for queue disable before saving q-state

> -Original Message- > From: Maheshwari, Abhishek > Sent: Thursday, November 3, 2022 5:35 PM > To: maxime.coque...@redhat.com; Wang, Xiao W > Cc: dev@dpdk.org; sta...@dpdk.org; Xia, Chenbo ; > Mandal, Purna Chandra ; Maheshwari, > Abhishek > Subject: [PATCH v5] vdpa/ifc/base: wait for qu

[PATCH] net/mlx5: fix drop action validation

Currently there's limitation for Drop action that can only co-exist with Count action. Sample and Age actions are also able to exist with Drop within the same flow, and this patch includes them in the Drop action validation. Fixes: acb67cc8 ("net/mlx5: fix action flag data type") Cc: sta...@dpdk.

Re: [PATCH v4] app/testpmd: fix protocol header display for Rx buffer split

On 11/9/22 04:37, Yuan Wang wrote: The "show config rxhdrs" cmd displays the configured protocol headers that are used for protocol-based buffer split. However, it shows inner-ipv6 as inner-ipv4. This patch fixes that by redefining rx_pkt_hdr_protos to hold the full ptypes, and the show and set

Re: [PATCH v12 1/1] app/testpmd: support multiple mbuf pools per Rx queue

On 11/9/22 13:39, Andrew Rybchenko wrote: On 11/9/22 11:04, Singh, Aman Deep wrote: On 11/7/2022 11:01 AM, Hanumanth Pothula wrote: Some of the HW has support for choosing memory pools based on the packet's size. The pool sort capability allows PMD/NIC to choose a memory pool based on the packe

RE: [PATCH v5] vdpa/ifc: fix update_datapath error handling

> -Original Message- > From: Taekyung Kim > Sent: Thursday, November 10, 2022 12:10 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Pei, Andy ; > kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; sta...@dpdk.org; > Wang, Xiao W > Subject: [PATCH v5] vdpa/ifc: fix update_datapath error ha

RE: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets

> -Original Message- > From: Jie Wang > Sent: 2022年11月10日 11:45 > To: dev@dpdk.org > Cc: Yang, SteveX ; Zhang, Qi Z > ; Yang, Qiming ; Xing, Beilei > ; Zhang, Yuying ; Wang, > Jie1X ; sta...@dpdk.org > Subject: [PATCH] net/i40e: fix X722 NIC receives jumbo frame packets > > For NIC I40E_1

RE: release candidate 22.11-rc2

Hi All, Update the test status for Intel part. Till now dpdk22.11-rc2 test is almost finished. No new critical issue is found. Known Critical bug: [22.11-rc1]iavf macfwd performance drop 40%, Intel dev has reverted the patch, but no acked-by. Meson test bugs: 1, https://bugs.dpdk.org/show_bug.

Re: [PATCH v2] doc: update broadcom documentation

On Wed, Nov 9, 2022 at 8:55 PM Ajit Khaparde wrote: > > Update Broadcom NIC documentation. > > Signed-off-by: Ajit Khaparde > Reviewed-by: Kalesh AP > > --- > v1->v2: > Updated commit message & incorrect information in the documentation. > --- > doc/guides/nics/bnxt.rst | 477 ++

[PATCH v2] doc: update broadcom documentation

Update Broadcom NIC documentation. Signed-off-by: Ajit Khaparde Reviewed-by: Kalesh AP --- v1->v2: Updated commit message & incorrect information in the documentation. --- doc/guides/nics/bnxt.rst | 477 +++ 1 file changed, 283 insertions(+), 194 deletions(-

[Bug 747] [dpdk-19.11.9-rc3] Meson build failed with ICC-19.1.1

https://bugs.dpdk.org/show_bug.cgi?id=747 jiang,yu (yux.ji...@intel.com) changed: What|Removed |Added Resolution|--- |WONTFIX Status|CONFIR

[PATCH v5] vdpa/ifc: fix update_datapath error handling

Stop and return the error code when update_datapath fails. update_datapath prepares resources for the vdpa device. The driver should not perform any further actions if update_datapath returns an error. Fixes: a3f8150eac6d ("net/ifcvf: add ifcvf vDPA driver") Cc: sta...@dpdk.org Signed-off-by: Tae

Re: [PATCH v4] vdpa/ifc: fix update_datapath error handling

On Thu, Nov 10, 2022 at 01:53:50AM +, Xia, Chenbo wrote: > Hi Kim, > > > -Original Message- > > From: Taekyung Kim > > Sent: Tuesday, November 8, 2022 4:56 PM > > To: dev@dpdk.org > > Cc: Xia, Chenbo ; Pei, Andy ; > > kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; sta...@dpd

[PATCH] net/i40e: fix X722 NIC receives jumbo frame packets

For NIC I40E_10G-10G_BASE_T_X722, when the port is configured with link speed, it cannot receive jumbo frame packets. Because it set maximum frame size failed when starts the port that the port link status is still down. This patch fix the error that starts the port will force set maximum frame s

RE: [PATCH] doc: update matching list for i40e and ice driver

Hi, Qi I will prepare v2 as this patch have one typo. Qiming > -Original Message- > From: Yang, Qiming > Sent: Wednesday, November 9, 2022 9:47 AM > To: dev@dpdk.org; Zhang, Qi Z > Cc: Yang, Qiming > Subject: [PATCH] doc: update matching list for i40e and ice driver > > Add recommended

[PATCH v1] net/mlx5: fix missing marks on received packets

If HW Steering is enabled, Rx queues were configured to receive MARKs when a table with MARK actions was created. After stopping the port, Rx queue configuration is released, but during starting the port the mark flag was not updated in the Rx queue configuration. This patch introduces a reference

RE: [PATCH v3] net/iavf: revert fix VLAN insertion

> > Subject: [PATCH v3] net/iavf: revert fix VLAN insertion > > > > The vector Tx path does not support VLAN insertion via the L2TAG2 > > field, but the scalar path supports. The previous commit was to force > > to select scalar path as soon as kernel driver requests to use L2TAG2. > > In which si

RE: [PATCH v2] net/ice: fix scalar Rx and Tx path segment

> -Original Message- > From: Mingjin Ye > Sent: Wednesday, November 9, 2022 8:56 PM > To: dev@dpdk.org > Cc: Yang, Qiming ; sta...@dpdk.org; Zhou, YidingX > ; Ye, MingjinX ; Zhang, Qi > Z ; Lu, Wenzhuo ; Wu, > Jingjing ; Li, Xiaoyun ; Ferruh > Yigit > Subject: [PATCH v2] net/ice: fix scal

RE: [PATCH v4] vdpa/ifc: fix update_datapath error handling

Hi Kim, > -Original Message- > From: Taekyung Kim > Sent: Tuesday, November 8, 2022 4:56 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; Pei, Andy ; > kim.tae.ky...@navercorp.com; maxime.coque...@redhat.com; sta...@dpdk.org; > Wang, Xiao W > Subject: [PATCH v4] vdpa/ifc: fix update_datapath er

RE: [PATCH v3 08/14] examples/vhost: fix whitespace

> -Original Message- > From: Stephen Hemminger > Sent: Thursday, November 10, 2022 7:25 AM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Maxime Coquelin > ; Xia, Chenbo > Subject: [PATCH v3 08/14] examples/vhost: fix whitespace > > Add space after keywords. > > Signed-off-by: Stephen Hem

[Bug 1087] [Bug] tcp data len is incorrectly calculated in gro_tcp4_reassemble function

https://bugs.dpdk.org/show_bug.cgi?id=1087 jinag (853048...@qq.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[PATCH 4/4] examples: remove unnecessary null checks

The function rte_free() already handles NULL argument; therefore the checks in this code are unnecessary. Signed-off-by: Stephen Hemminger --- examples/distributor/main.c | 3 +-- examples/fips_validation/main.c | 15 +-- 2 files changed, 6 insertions(+), 12 deletions(-) diff -

[PATCH 3/4] idpf: remvoee unnecessary null checks

The function rte_free() already handles NULL argument; therefore the checks in this code are unnecessary. Signed-off-by: Stephen Hemminger --- drivers/net/idpf/idpf_rxtx.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/idpf/idpf_rxtx.c b/drivers/net/idpf/idpf_r

[PATCH 2/4] mlx5: remove unnecessary null checks

The function rte_free() already handles NULL argument; therefore the checks in this code are unnecessary. Signed-off-by: Stephen Hemminger --- drivers/net/mlx5/hws/mlx5dr_pool.c | 3 +-- drivers/net/mlx5/mlx5_flow_hw.c| 6 ++ 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a

[PATCH 1/4] gve: remove unnecessary null checks

The function rte_free() already handles NULL argument; therefore the checks in this code are unnecessary. Signed-off-by: Stephen Hemminger --- drivers/net/gve/gve_ethdev.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve

[PATCH 0/4] remove unnecessary null checks

This patch set is from running the null_free coccinelle script on the current main branch. Stephen Hemminger (4): gve: remove unnecessary null checks mlx5: remove unnecessary null checks idpf: remove unnecessary null checks examples: remove unnecessary null checks drivers/net/gve/gve_eth

[PATCH v3 14/14] net/bnx2x: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h index 89414ac88a93..9cb927e25449 100644 --- a/drivers/net/bnx2x/bnx2x.h +++ b/drivers

[PATCH v3 13/14] net/i40e: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_pf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 15d9ff868f3a..7050e0057d8e 100644 --- a/drivers/net/i40e/i40e_pf.c +

[PATCH v3 12/14] net/e1000: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_ethdev.c | 4 ++-- drivers/net/e1000/igb_ethdev.c | 8 drivers/net/e1000/igb_pf.c | 2 +- drivers/net/e1000/igb_rxtx.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/driver

[PATCH v3 11/14] bus/pci: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/bus/pci/bsd/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c index 7459d15c7e31..056e2eda2d5f 100644 --- a/drivers/bus/pci/bsd/pci.c +++ b/drivers

[PATCH v3 10/14] examples: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/cmdline/parse_obj_list.c | 2 +- examples/ip_reassembly/main.c | 2 +- examples/multi_process/symmetric_mp/main.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/cmdl

[PATCH v3 09/14] l3fwd: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 7 --- examples/l3fwd/main.c | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index fd3ade330f82..7bd5d8cb22

[PATCH v3 08/14] examples/vhost: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/vhost/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 42e53a0f9a4f..9fee966916e9 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/m

[PATCH v3 07/14] examples/qos_sched: fix whitespace

Add space after keywords. Acked-by: Cristian Dumitrescu Signed-off-by: Stephen Hemminger --- examples/qos_sched/app_thread.c | 6 +++--- examples/qos_sched/args.c | 2 +- examples/qos_sched/init.c | 2 +- examples/qos_sched/main.c | 4 ++-- 4 files changed, 7 insertions(+), 7

[PATCH v3 06/14] test: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_cirbuf.c | 4 ++-- app/test/test_debug.c | 4 ++-- app/test/test_hash.c | 6 +++--- app/test/test_lpm6_perf.c | 2 +- app/test/test_malloc.c | 14 +++--- app/test/test

[PATCH v3 05/14] testpmd: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c| 31 --- app/test-pmd/parameters.c | 10 ++ app/test-pmd/testpmd.c| 2 +- 3 files changed, 23 insertions(+), 20 deletions(-) diff --git a/app/test-pmd/cmdline.c b/a

[PATCH v3 04/14] ip_frag: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 4a89a5f5365a..88ee0aa63f62 100644 --- a/lib/ip_frag/rt

[PATCH v3 03/14] timer: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index 85d67573eb9e..9eb73f1fed13 100644 --- a/lib/timer/rte_timer.c +++ b/lib/timer/rte_timer.c @

[PATCH v3 02/14] cmdline: fix whitespace

Add space after keywords. Remove unnecessary spaces in if expressions. Signed-off-by: Stephen Hemminger --- lib/cmdline/cmdline_parse_string.c | 17 +++-- lib/cmdline/cmdline_rdline.c | 12 ++-- 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/lib/cmdlin

[PATCH v3 01/14] eal: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/eal/include/generic/rte_cycles.h | 4 ++-- lib/eal/linux/eal_hugepage_info.c| 6 +++--- lib/eal/linux/eal_interrupts.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/eal/include/generic/rte_c

[PATCH v3 00/14] whitespace after keywords

The DPDK standard now enforced through checkpatch is to use a space after keywords. Much of the older code that was grandfathered in doesn't follow that, so fix it. No urgency to this patchset, and it might just be viewed as churn. But I prefer to read code that looks all the same. “A foolish con

Re: [PATCH v4] testpmd: cleanup cleanly from signal

On Wed, 9 Nov 2022 22:46:55 +0100 Mattias Rönnblom wrote: > On 2022-11-09 05:10, Stephen Hemminger wrote: > > Do a clean shutdown of testpmd when a signal is received; > > instead of having testpmd kill itself. > > This fixes problem where a signal could be received > > in the middle of a PMD and

RE: [RFC] mempool: zero-copy cache put bulk

> > +To: Bruce also showed interest in this topic, and might have more insights. > > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > Sent: Wednesday, 9 November 2022 18.58 > > > > > > > > > > > > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > > >

[PATCH v2] net/mlx5: fix port's event cleaning order

The shared IB device (sh) has per port data with filed for interrupt handler port_id. It used by shared interrupt handler to find the corresponding rte_eth device by IB port index. If value is equal or greater RTE_MAX_ETHPORTS it means there is no subhandler installed for specified IB port index.

[PATCH] net/mlx5: fix port's event cleaning order

The shared IB device (sh) has per port data with filed for interrupt handler port_id. It used by shared interrupt handler to find the corresponding rte_eth device by IB port index. If value is equal or greater RTE_MAX_ETHPORTS it means there is no subhandler installed for specified IB port index.

Re: Question about naive XOR hash in DPDK

On 2022-11-07 19:57, Bili Dong wrote: Dear DPDK devs, We are using DPDK as the backend target of a P4 pipeline (https://github.com/p4lang/p4-dpdk-target ). A recent issue we are trying to solve is to support a naive XOR hash (something like this

Re: [PATCH v4] testpmd: cleanup cleanly from signal

On 2022-11-09 05:10, Stephen Hemminger wrote: Do a clean shutdown of testpmd when a signal is received; instead of having testpmd kill itself. This fixes problem where a signal could be received in the middle of a PMD and then the signal handler would call PMD's close routine which could cause a

RE: [RFC] mempool: zero-copy cache put bulk

+To: Bruce also showed interest in this topic, and might have more insights. > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Wednesday, 9 November 2022 18.58 > > > > > > > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > > Sent: Sunday, 6 Novembe

[PATCH v2 14/14] net/bnx2x: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h index 89414ac88a93..9cb927e25449 100644 --- a/drivers/net/bnx2x/bnx2x.h +++ b/drivers

[PATCH v2 13/14] net/i40e: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_pf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 15d9ff868f3a..7050e0057d8e 100644 --- a/drivers/net/i40e/i40e_pf.c +

[PATCH v2 12/14] net/e1000: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_ethdev.c | 4 ++-- drivers/net/e1000/igb_ethdev.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 8ee9be12ad19..14

[PATCH v2 11/14] bus/pci: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/bus/pci/bsd/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c index 7459d15c7e31..056e2eda2d5f 100644 --- a/drivers/bus/pci/bsd/pci.c +++ b/drivers

[PATCH v2 09/14] l3fwd: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 7 --- examples/l3fwd/main.c | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index fd3ade330f82..7bd5d8cb22

[PATCH v2 10/14] examples: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/cmdline/parse_obj_list.c | 2 +- examples/ip_reassembly/main.c | 2 +- examples/multi_process/symmetric_mp/main.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/cmdl

[PATCH v2 08/14] examples/vhost: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/vhost/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 42e53a0f9a4f..9fee966916e9 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/m

[PATCH v2 07/14] examples/qos_sched: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/qos_sched/app_thread.c | 6 +++--- examples/qos_sched/args.c | 2 +- examples/qos_sched/init.c | 2 +- examples/qos_sched/main.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/exam

[PATCH v2 06/14] test: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_cirbuf.c | 4 ++-- app/test/test_debug.c | 4 ++-- app/test/test_hash.c | 6 +++--- app/test/test_lpm6_perf.c | 2 +- app/test/test_malloc.c | 14 +++--- app/test/test

[PATCH v2 05/14] testpmd: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c| 31 --- app/test-pmd/parameters.c | 10 ++ app/test-pmd/testpmd.c| 2 +- 3 files changed, 23 insertions(+), 20 deletions(-) diff --git a/app/test-pmd/cmdline.c b/a

[PATCH v2 04/14] ip_frag: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 4a89a5f5365a..88ee0aa63f62 100644 --- a/lib/ip_frag/rt

[PATCH v2 03/14] timer: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index 85d67573eb9e..9eb73f1fed13 100644 --- a/lib/timer/rte_timer.c +++ b/lib/timer/rte_timer.c @

[PATCH v2 02/14] cmdline: fix whitespace

Add space after keywords. Remove unnecessary spaces in if expressions. Signed-off-by: Stephen Hemminger --- lib/cmdline/cmdline_parse_string.c | 16 +++- lib/cmdline/cmdline_rdline.c | 12 ++-- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/lib/cmdline

[PATCH v2 00/14] whitespace after keywords

The DPDK standard now enforced through checkpatch is to use a space after keywords. Much of the older code that was grandfathered in doesn't follow that, so fix it. No urgency to this patchset, and it might just be viewed as churn. But I prefer to read code that looks all the same. “A foolish con

[PATCH v2 01/14] eal: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/eal/linux/eal_hugepage_info.c | 6 +++--- lib/eal/linux/eal_interrupts.c| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c index a1b6c

RE: [PATCH 07/14] examples/qos_sched: fix whitespace

> -Original Message- > From: Stephen Hemminger > Sent: Wednesday, November 9, 2022 7:15 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian > Subject: [PATCH 07/14] examples/qos_sched: fix whitespace > > Add space after keywords. > > Signed-off-by: Stephen Hemminge

[PATCH 14/14] net/bnx2x: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h index 89414ac88a93..9cb927e25449 100644 --- a/drivers/net/bnx2x/bnx2x.h +++ b/drivers

[PATCH 13/14] net/i40e: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/i40e/i40e_pf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 15d9ff868f3a..7050e0057d8e 100644 --- a/drivers/net/i40e/i40e_pf.c +

[PATCH 12/14] net/e1000: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_ethdev.c | 4 ++-- drivers/net/e1000/igb_ethdev.c | 8 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 8ee9be12ad19..14

[PATCH 11/14] bus/pci: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/bus/pci/bsd/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c index 7459d15c7e31..056e2eda2d5f 100644 --- a/drivers/bus/pci/bsd/pci.c +++ b/drivers

[PATCH 10/14] examples: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/cmdline/parse_obj_list.c | 2 +- examples/ip_reassembly/main.c | 2 +- examples/multi_process/symmetric_mp/main.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/cmdl

[PATCH 09/14] l3fwd: fix whitespace

Add space after keywoords Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 6 +++--- examples/l3fwd/main.c | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index fd3ade330f82..b2270e1056c8

[PATCH 08/14] examples/vhost: fix whitespace

Add space after keywords Signed-off-by: Stephen Hemminger --- examples/vhost/main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 42e53a0f9a4f..cabc8682346c 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/mai

[PATCH 07/14] examples/qos_sched: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/qos_sched/app_thread.c | 6 +++--- examples/qos_sched/args.c | 2 +- examples/qos_sched/init.c | 2 +- examples/qos_sched/main.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/exam

[PATCH 06/14] test: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_cirbuf.c | 4 ++-- app/test/test_debug.c | 4 ++-- app/test/test_hash.c | 8 app/test/test_lpm6_perf.c | 2 +- app/test/test_malloc.c | 14 +++--- app/test/te

[PATCH 05/14] testpmd: fix whitspace

Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c| 30 +++--- app/test-pmd/parameters.c | 8 app/test-pmd/testpmd.c| 2 +- 3 files changed, 20 insertions(+), 20 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/

[PATCH 03/14] timer: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index 85d67573eb9e..9eb73f1fed13 100644 --- a/lib/timer/rte_timer.c +++ b/lib/timer/rte_timer.c @

[PATCH 04/14] ip_frag: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 4a89a5f5365a..88ee0aa63f62 100644 --- a/lib/ip_frag/rt

[PATCH 02/14] cmdline: fix whitespace

Add space after keywords. Remove unnecessary spaces in if expressions. Signed-off-by: Stephen Hemminger --- lib/cmdline/cmdline_parse_string.c | 10 +- lib/cmdline/cmdline_rdline.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/lib/cmdline/cmdline_parse

[PATCH 01/14] eal: fix whitespace

Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/eal/linux/eal_hugepage_info.c | 6 +++--- lib/eal/linux/eal_interrupts.c| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c index a1b6c

[PATCH 00/14] whitespace around keywords

The DPDK standard now enforced through checkpatch is to use a space after keywords. Much of the older code that was grandfathered in doesn't follow that, so fix it. No urgency to this patchset, and it might just be viewed as churn. But I prefer to read code that looks all the same. “A foolish con

[PATCH v2 3/3] ethdev: document special cases of port start and stop

This patch clarifies the handling of following cases in the ethdev API docs: - If rte_eth_dev_start() returns (-EAGAIN) for some port, it cannot be started until other port is started. - If rte_eth_dev_stop() returns (-EBUSY) for some port, it cannot be stopped until other port is stopped. Wh

[PATCH v2 2/3] doc: document E-Switch limitations with HWS in mlx5 PMD

This patch adds the following limitations to the mlx5 PMD guide: - With HW Steering and E-Switch enabled, transfer proxy port must be started before any port representor. - With HW Steering and E-Switch enabled, all representors must be stopped before transfer proxy port is stopped. Signed-of

[PATCH v2 1/3] net/mlx5: fix log level on failed transfer proxy stop

This patches increases log level for error reporting when stopping the transfer proxy port failed. Stopping can fail with EBUSY when related representor ports are still running. Fixes: 483181f7b6dd ("net/mlx5: support device control of representor matching") Signed-off-by: Dariusz Sosnowski ---

[PATCH v2 0/3] ethdev: document special cases of port start and stop

This patch series attempts to address the special failure cases of rte_eth_dev_stop() and rte_eth_dev_start(). In case of starting a port, If the port depends on another one being started, PMDs might return (-EAGAIN) to notify about such situation. In case of stopping a port, If the port cannot b

[PATCH v2] doc: support IPsec Multi-buffer lib v1.3

Updated AESNI MB and AESNI GCM, KASUMI, ZUC and SNOW3G PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara --- - v2: Removed repeated word 'the' --- doc/guides/cryptodevs/aesni_gcm.rst | 8 doc/guides/cry

[PATCH] doc: support IPsec Multi-buffer lib v1.3

Updated AESNI MB and AESNI GCM, KASUMI, ZUC and SNOW3G PMD documentation guides with information about the latest Intel IPSec Multi-buffer library supported. Signed-off-by: Pablo de Lara --- doc/guides/cryptodevs/aesni_gcm.rst | 8 doc/guides/cryptodevs/aesni_mb.rst | 18 -

[PATCH v5 3/3] mempool: use cache for frequently updated stats

When built with stats enabled (RTE_LIBRTE_MEMPOOL_STATS defined), the performance of mempools with caches is improved as follows. When accessing objects in the mempool, either the put_bulk and put_objs or the get_success_bulk and get_success_objs statistics counters are likely to be incremented.

[PATCH v5 2/3] mempool: add stats for unregistered non-EAL threads

This patch adds statistics for unregistered non-EAL threads, which was previously not included in the statistics. Add one more entry to the stats array, and use the last index for unregistered non-EAL threads. The unregistered non-EAL thread statistics are incremented atomically. In theory, the

[PATCH v5 1/3] mempool: split stats from debug

Split stats from debug, to make mempool statistics available without the performance cost of continuously validating the debug cookies in the mempool elements. mempool_perf_autotest shows the following improvements in rate_persec. The cost of enabling mempool debug without this patch: -28.1 % and

RE: [RFC] mempool: zero-copy cache put bulk

> > > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > > Sent: Sunday, 6 November 2022 00.11 > > > > + Akshitha, she is working on similar patch > > > > Few comments inline > > > > > From: Morten Brørup > > > Sent: Saturday, November 5, 2022 8:40 AM > > > > > > Zero-copy acces

Re: [PATCH] devtools: set DTS directory to format check

On Wed, Nov 9, 2022 at 12:09 PM Thomas Monjalon wrote: > The script was running on the current directory. > If not in the DTS directory, it would re-format every Python files. > > A new positional argument is added to specify the directory to check. > In most cases, the (new) default value should

[PATCH v5] testpmd: cleanup cleanly from signal

Do a clean shutdown of testpmd when a signal is received; instead of having testpmd kill itself. This fixes problem where a signal could be received in the middle of a PMD and then the signal handler would call PMD's close routine which could cause a deadlock. Added benefit is it gets rid of Windo

[PATCH] devtools: set DTS directory to format check

The script was running on the current directory. If not in the DTS directory, it would re-format every Python files. A new positional argument is added to specify the directory to check. In most cases, the (new) default value should be enough. While updating argument handling, the usage is printe

[PATCH v2] app/testpmd: fix interactive mode with no ports

Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. Fixes: 6937d2103e22 ("app/testpmd: add option to not start device") Cc: step...@networkplumber.org Cc: sta...@dpdk.org Signed-off-by:

Re: [PATCH v8 0/9] dts: ssh connection to a node

On Wed, Nov 9, 2022 at 11:23 AM Honnappa Nagarahalli < honnappa.nagaraha...@arm.com> wrote: > > > > > > 04/11/2022 12:05, Juraj Linkeš: > > > All the necessary code needed to connect to a node in a topology with > > > a bit more, such as basic logging and some extra useful methods. > > > > Applie

[PATCH] app/testpmd: fix interactive mode with no ports

Testpmd terminated unconditionally if it failed to start all ports. The patch allows testpmd to get into the command line, if the interactive mode was requested. Fixes: 6937d2103e22 ("app/testpmd: add option to not start device") Signed-off-by: Gregory Etelson --- app/test-pmd/testpmd.c | 8 +++

[PATCH] net/mlx5: fix port initialization with small LRO

If application provided maximal LRO size was less than expected PMD minimum, the PMD either crashed with assert, if asserts were enabled, or proceeded with port initialization to set port private maximal LRO size below supported minimum. The patch terminates port start if LRO size does not match P

  1   2   >