[PATCH] net/iavf: fix memory leak in flow subscription

2022-10-07 Thread Jie Wang
When creating flow subscription pattern that it might cause a memory leak. This patch fix the error by adding a free memory code. And some typos have also been fixed. Coverity issue: 381130 Fixes: b110b2f63e50 ("net/iavf: add flow subscrption supported pattern") Fixes: 6416f63aae8b ("net/iavf: s

RE: [PATCH v2] net/ice: fix DDP package init

2022-10-07 Thread Zhang, Qi Z
> -Original Message- > From: Huang, ZhiminX > Sent: Saturday, October 8, 2022 2:11 PM > To: Zhang, Qi Z ; Yang, Qiming > > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: RE: [PATCH v2] net/ice: fix DDP package init > > > -Original Message- > > From: Qi Zhang > > Sent: Saturday, Oc

RE: [PATCH v2] net/ice: fix DDP package init

2022-10-07 Thread Huang, ZhiminX
> -Original Message- > From: Qi Zhang > Sent: Saturday, October 8, 2022 10:06 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH v2] net/ice: fix DDP package init > > ICE_DDP_PKG_SAME_VERSION_ALREADY_LOADED and > ICE_DDP_PKG_COMPATIBLE_ALREADY_LOADED should not be t

[PATCH v2] net/ice: fix DDP package init

2022-10-07 Thread Qi Zhang
ICE_DDP_PKG_SAME_VERSION_ALREADY_LOADED and ICE_DDP_PKG_COMPATIBLE_ALREADY_LOADED should not be treated as a DDP package init failure. Use ice_is_init_pkg_successful to check return value of ice_copy_and_init_pkg. Signed-off-by: Qi Zhang --- v2: - fix error from ice_copy_and_init_pkg not be escu

RE: [PATCH] net/ice: fix DDP package init

2022-10-07 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, September 7, 2022 8:05 PM > To: Yang, Qiming > Cc: dev@dpdk.org; Yang, SteveX > Subject: RE: [PATCH] net/ice: fix DDP package init > > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Wednesday, September 7

Re: [PATCH V2 3/6] ethdev: fix push new event

2022-10-07 Thread lihuisong (C)
在 2022/9/27 18:49, Thomas Monjalon 写道: 15/09/2022 14:45, Huisong Li: The 'state' in struct rte_eth_dev may be used to update some information when app receive these events. For example, when app receives a new event, app may get the socket id of this port by calling rte_eth_dev_socket_id to se

Re: [PATCH] ethdev: fix push new event

2022-10-07 Thread lihuisong (C)
在 2022/9/27 18:29, Thomas Monjalon 写道: 11/06/2022 10:59, lihuisong (C): 在 2022/6/7 14:44, Thomas Monjalon 写道: 07/06/2022 03:23, lihuisong (C): 在 2022/6/3 15:42, Thomas Monjalon 写道: 02/06/2022 13:24, lihuisong (C): 在 2022/5/30 19:10, Ferruh Yigit 写道: On 5/30/2022 9:28 AM, Thomas Monjalon w

Re: [PATCH] vhost: enable CONFIG feature

2022-10-07 Thread 陈浩
On 2022/9/26 15:26, Xia, Chenbo wrote: -Original Message- From: Hao Chen Sent: Tuesday, September 13, 2022 5:55 PM To: maxime.coque...@redhat.com; Xia, Chenbo Cc: dev@dpdk.org; ho...@yusur.tech; z...@yusur.tech; Hao Chen Subject: [PATCH] vhost: enable CONFIG feature Enable this feat

RE: [PATCH v5 1/2] member: implement NitroSketch mode

2022-10-07 Thread Rong, Leyi
> -Original Message- > From: Thomas Monjalon > Sent: Monday, October 3, 2022 8:38 PM > To: Wang, Yipeng1 ; Rong, Leyi > > Cc: ferruh.yi...@xilinx.com; Richardson, Bruce ; > david.march...@redhat.com; suanmi...@nvidia.com; zaoxing...@gmail.com; > Gobriel, Sameh ; dev@dpdk.org > Subject:

RE: [PATCH v1] examples/l3fwd: fix core dump after packet match

2022-10-07 Thread Chen, LingliX
> -Original Message- > From: Sean Morrissey > Sent: Wednesday, September 7, 2022 7:34 PM > To: Konstantin Ananyev ; Morrissey, Sean > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: [PATCH v1] examples/l3fwd: fix core dump after packet match > > This patch fixes a core dump which occurs

[Bug 1085] [dpdk-22.11]ieee1588: ninja build failed with 'Dc_args=-DRTE_LIBRTE_IEEE1588'

2022-10-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1085 linglix.c...@intel.com changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

RE: [PATCH v3 2/2] examples/vhost: unconfigure DMA vchannel

2022-10-07 Thread Ding, Xuan
Hi Chenbo, > -Original Message- > From: Xia, Chenbo > Sent: Thursday, September 29, 2022 4:28 PM > To: Ding, Xuan ; maxime.coque...@redhat.com > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > ; Yang, YvonneX ; > Jiang, Cheng1 ; Wang, YuanX > ; Ma, WenwuX > Subject: RE: [PATCH v3 2/2] exam

[PATCH v9 14/14] baseband/acc: simplify meson dependency

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Removed some of libraries from the external dependency captured in meson build file which are not required. Signed-off-by: Nic Chautru --- drivers/baseband/acc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/meson.build b/d

[PATCH v9 13/14] baseband/acc: add PF configure companion function

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added configure function notably to configure the device from the PF within DPDK and bbdev-test (without external dependency). Signed-off-by: Nic Chautru Acked-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 71 drivers/baseband/acc/meson.build | 2

[PATCH v9 12/14] baseband/acc: add device status and vf2pf comms

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added support to expose the device status seen from the host through v2pf mailbox communication. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a

[PATCH v9 11/14] baseband/acc: support interrupt

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added support for capability and functions for MSI/MSI-X interrupt and underlying information ring. Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 302 +- 1 file changed, 299 insertions(+), 3 deletions(-) diff --git a/drivers/b

[PATCH v9 10/14] baseband/acc: add support for FFT operations

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added functions and capability for FFT processing Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 240 +- 1 file changed, 238 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc200_pmd.c b/drivers/baseband/a

[PATCH v9 09/14] baseband/acc: add LTE processing functions

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added functions and capability for 4G FEC Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 851 +- 1 file changed, 846 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/acc/rte_acc200_pmd.c b/drivers/baseband/acc/rte_a

[PATCH v9 08/14] baseband/acc: add LDPC processing functions

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added LDPC encode and decode processing functions. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 84 ++ drivers/baseband/acc/rte_acc200_pmd.c | 1321 - 2 files changed, 1400 insertions(+), 5 dele

[PATCH v9 07/14] baseband/acc: add queue configuration for ACC200

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added function to create and configure queues for the device. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 391 +- 2 files changed, 391 insertions(+)

[PATCH v9 06/14] baseband/acc: add info get function for ACC200

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added support for info_get to allow to query the device. Null capability exposed. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc200_pmd.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 231 ++ 2 files change

[PATCH v9 05/14] baseband/acc: add HW register definitions for ACC200

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added registers list and structure to access the device. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc200_pf_enum.h | 108 + drivers/baseband/acc/acc200_pmd.h | 163 ++ drivers/baseband/acc/ac

[PATCH v9 04/14] baseband/acc: introduce PMD for ACC200

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Introduced stubs for device driver for the ACC200 integrated VRAN accelerator on SPR-EEC Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- MAINTAINERS| 3 + doc/guides/bbdevs/acc200.rst | 257 + do

[PATCH v9 03/14] baseband/acc: rename directory from acc100 to acc

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Used a common directory for the ACC PMDs Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- MAINTAINERS | 2 +- app/test-bbdev/meson.build| 4 ++-- app/test-bbdev/test_bbdev_perf.c

[PATCH v9 01/14] baseband/acc100: remove unused registers

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Cleanep up the enum files to remove un-used registers definitions. No functionality change. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/acc100_pf_enum.h | 939 --- 1 file changed, 939 deletions(-) diff --git a/driv

[PATCH v9 00/14] bbdev ACC200 PMD

2022-10-07 Thread Nicolas Chautru
v9: I had missed a compilation error in debug mode. v8: Rebased to latest and fixed related compilation error. Added acc200.ini and updated rel_notes. Formatting improvement in comments, docs and commit message. v7: Additional update in commits 9,10,11 based on review from Maxime. v5/v6:Updat

RE: [EXT] Re: [PATCH v5 5/7] lib: move mbuf next pointer to first cache line

2022-10-07 Thread Shijith Thotton
>> Swapped position of mbuf next pointer and second dynamic field (dynfield2) >> if the build is configured to disable IOVA as PA. This is to move the >> mbuf next pointer to first cache line. >> >> Signed-off-by: Shijith Thotton >> Acked-by: Olivier Matz > >Why not always move it? >Having things

Re: [PATCH v5 5/7] lib: move mbuf next pointer to first cache line

2022-10-07 Thread Stephen Hemminger
On Sat, 8 Oct 2022 02:32:09 +0530 Shijith Thotton wrote: > Swapped position of mbuf next pointer and second dynamic field (dynfield2) > if the build is configured to disable IOVA as PA. This is to move the > mbuf next pointer to first cache line. > > Signed-off-by: Shijith Thotton > Acked-by: O

Re: [PATCH v5 1/7] mbuf: add API to get and set mbuf physical address

2022-10-07 Thread Stephen Hemminger
On Sat, 8 Oct 2022 02:32:05 +0530 Shijith Thotton wrote: > > +/** > + * Get the IOVA address of the mbuf data buffer. > + * > + * @param m > + * The pointer to the mbuf. > + * @return > + * The IOVA address of the mbuf. > + */ > +static inline rte_iova_t > +rte_mbuf_iova_get(const struct rt

[PATCH v5 7/7] drivers: mark software PMDs work with IOVA as PA disabled

2022-10-07 Thread Shijith Thotton
Enabled software PMDs in IOVA as PA disabled build as they work with IOVA as VA. Signed-off-by: Shijith Thotton Acked-by: Olivier Matz --- drivers/crypto/armv8/meson.build| 1 + drivers/crypto/ipsec_mb/meson.build | 1 + drivers/crypto/null/meson.build | 1 + drivers/crypto/openssl/meso

[PATCH v5 6/7] drivers: mark cnxk PMDs work with IOVA as PA disabled

2022-10-07 Thread Shijith Thotton
Enabled the flag pmd_supports_disable_iova_as_pa in cnxk driver build files as they work with IOVA as VA. Updated cn9k and cn10k soc build configurations to disable the IOVA as PA build by default. Signed-off-by: Shijith Thotton Acked-by: Olivier Matz --- config/arm/meson.build

[PATCH v5 5/7] lib: move mbuf next pointer to first cache line

2022-10-07 Thread Shijith Thotton
Swapped position of mbuf next pointer and second dynamic field (dynfield2) if the build is configured to disable IOVA as PA. This is to move the mbuf next pointer to first cache line. Signed-off-by: Shijith Thotton Acked-by: Olivier Matz --- doc/guides/rel_notes/release_22_11.rst | 3 +++ lib/

[PATCH v5 4/7] mbuf: add second dynamic field member

2022-10-07 Thread Shijith Thotton
If IOVA as PA is disabled during build, mbuf physical address field is undefined. This space is used to add the second dynamic field. Signed-off-by: Shijith Thotton Acked-by: Olivier Matz --- lib/mbuf/rte_mbuf_core.h | 6 +- lib/mbuf/rte_mbuf_dyn.c | 3 +++ 2 files changed, 8 insertions(+)

[PATCH v5 3/7] build: add meson option to configure IOVA mode as PA

2022-10-07 Thread Shijith Thotton
IOVA mode in DPDK is either PA or VA. The new build option enable_iova_as_pa configures the mode to PA at compile time. By default, this option is enabled. If the options is disabled, only drivers which supports it are enabled during build. Supported driver can set the flag pmd_supports_disable_iov

[PATCH v5 2/7] test/dma: use API to get mbuf data physical address

2022-10-07 Thread Shijith Thotton
Used rte_mbuf_data_iova API to get the physical address of mbuf data. Signed-off-by: Shijith Thotton Acked-by: Olivier Matz --- app/test/test_dmadev.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/app/test/test_dmadev.c b/app/test/test_d

[PATCH v5 1/7] mbuf: add API to get and set mbuf physical address

2022-10-07 Thread Shijith Thotton
Added APIs rte_mbuf_iova_set and rte_mbuf_iova_get to set and get the physical address of an mbuf respectively. Updated applications and library to use the same. Signed-off-by: Shijith Thotton Acked-by: Olivier Matz --- app/test-bbdev/test_bbdev_perf.c | 2 +- app/test-crypto-perf/cper

[PATCH v5 0/7] mbuf dynamic field expansion

2022-10-07 Thread Shijith Thotton
This is a continuation of the discussions[1] to add mbuf physical address field to dynamic field. Previous version was to add PA field to dynamic field area based on the EAL IOVA mode option. It was deemed unsafe as some components could still use the PA field without checking IOVA mode and ther

RE: [EXT] Re: [PATCH v3 4/5] drivers: mark Marvell cnxk PMDs work with IOVA as VA

2022-10-07 Thread Shijith Thotton
>> Enabled the flag pmd_iova_as_va in cnxk driver build files as they work >> with IOVA as VA. Updated cn9k and cn10k soc build configurations to >> enable the IOVA as VA build by default. >> >> Signed-off-by: Shijith Thotton >> --- >> config/arm/meson.build | 8 +++- >> driver

RE: [EXT] Re: [PATCH v4 1/7] mbuf: add API to get and set mbuf physical address

2022-10-07 Thread Shijith Thotton
Hi Olivier, >On Sat, Oct 08, 2022 at 01:00:23AM +0530, Shijith Thotton wrote: >> Added APIs rte_mbuf_iova_set and rte_mbuf_iova_get to set and get the >> physical address of an mbuf respectively. Updated applications and >> library to use the same. >> >> Signed-off-by: Shijith Thotton >> --- >>

Re: [PATCH v4 0/7] mbuf dynamic field expansion

2022-10-07 Thread Olivier Matz
Hi Shijith, On Sat, Oct 08, 2022 at 01:00:22AM +0530, Shijith Thotton wrote: > This is a continuation of the discussions[1] to add mbuf physical address > field to dynamic field. > Previous version was to add PA field to dynamic field area based on the EAL > IOVA mode option. It was > deemed uns

Re: [PATCH v3 4/5] drivers: mark Marvell cnxk PMDs work with IOVA as VA

2022-10-07 Thread Olivier Matz
On Wed, Sep 21, 2022 at 07:26:20PM +0530, Shijith Thotton wrote: > Enabled the flag pmd_iova_as_va in cnxk driver build files as they work > with IOVA as VA. Updated cn9k and cn10k soc build configurations to > enable the IOVA as VA build by default. > > Signed-off-by: Shijith Thotton > --- > co

Re: [PATCH v4 2/7] test/dma: use API to get mbuf data physical address

2022-10-07 Thread Olivier Matz
On Sat, Oct 08, 2022 at 01:00:24AM +0530, Shijith Thotton wrote: > Used rte_mbuf_data_iova API to get the physical address of mbuf data. > > Signed-off-by: Shijith Thotton > --- > app/test/test_dmadev.c | 33 ++--- > 1 file changed, 14 insertions(+), 19 deletions(-) >

Re: [PATCH v4 1/7] mbuf: add API to get and set mbuf physical address

2022-10-07 Thread Olivier Matz
Hi, On Sat, Oct 08, 2022 at 01:00:23AM +0530, Shijith Thotton wrote: > Added APIs rte_mbuf_iova_set and rte_mbuf_iova_get to set and get the > physical address of an mbuf respectively. Updated applications and > library to use the same. > > Signed-off-by: Shijith Thotton > --- > app/test-bbdev/

RE: [EXT] [PATCH v3 4/5] examples/l3fwd: fix event vector processing in fib

2022-10-07 Thread Shijith Thotton
> >Fix stack overflow when event vector size is greater than >MAX_BURST_SIZE. >Add missing mac swap and rfc1812 stage. > >Fixes: e8adca1951d4 ("examples/l3fwd: support event vector") > >Signed-off-by: Pavan Nikhilesh >--- > examples/l3fwd/l3fwd_fib.c | 123 ++--- > 1

RE: [EXT] [PATCH v3 5/5] examples/l3fwd: use em vector path for event vector

2022-10-07 Thread Shijith Thotton
>Use em vector path to process event vector. > >Signed-off-by: Pavan Nikhilesh >--- > examples/l3fwd/l3fwd_em.c| 12 +++-- > examples/l3fwd/l3fwd_em.h| 29 +-- > examples/l3fwd/l3fwd_em_hlm.h| 72 +--- > examples/l3fwd/l3fwd_em_sequentia

RE: [EXT] [PATCH v8 4/4] app/testpmd: support mulitiple mbuf pools per Rx queue

2022-10-07 Thread Hanumanth Reddy Pothula
> -Original Message- > From: Andrew Rybchenko > Sent: Saturday, October 8, 2022 1:13 AM > To: Hanumanth Reddy Pothula > Cc: dev@dpdk.org; Thomas Monjalon ; Ferruh Yigit > > Subject: Re: [EXT] [PATCH v8 4/4] app/testpmd: support mulitiple mbuf pools > per > Rx queue > > On 10/7/22 21:

Re: [PATCH v5 1/2] mem: telemetry support for memseg and element information

2022-10-07 Thread David Marchand
On Thu, Oct 6, 2022 at 9:07 AM Amit Prakash Shukla wrote: > > Hi David, > > If no other review comments, could you please pick this series for 22.11 rc1 ? I had a better look and sent some comments. We can still consider this series for rc2 in any case. -- David Marchand

Re: [PATCH v5 1/2] mem: telemetry support for memseg and element information

2022-10-07 Thread David Marchand
On Thu, Sep 29, 2022 at 1:43 PM Amit Prakash Shukla wrote: > 4. /eal/element_list,,, > The command outputs number of elements in a memseg based > on the heap-id, memseg-list-id and memseg-id given as input. > Example: > --> /eal/element_list,0,0,63 > {"/eal/element_list": {"Element_count": 52}} >

Re: [PATCH v5 2/2] mem: telemetry support for system memory information

2022-10-07 Thread David Marchand
On Thu, Sep 29, 2022 at 1:44 PM Amit Prakash Shukla wrote: > > Changes adds telemetry support to display system memory information, > allocated using calls malloc, calloc, mmap, etc. This patch > is based on malloc_info. This patch adds following endpoints: malloc_info is a GNU extension. It is n

Re: [PATCH v8 2/4] ethdev: support multiple mbuf pools per Rx queue

2022-10-07 Thread Andrew Rybchenko
On 10/7/22 21:35, Thomas Monjalon wrote: 07/10/2022 19:29, Andrew Rybchenko: +* **Added support for mulitiple mbuf pools per ethdev Rx queue.** mulitiple -> multiple I can fix when merging. Thanks, I've delegated first 3 patches to you. I think it is ready to go. Let's sort out testpmd patc

Re: [EXT] [PATCH v8 4/4] app/testpmd: support mulitiple mbuf pools per Rx queue

2022-10-07 Thread Andrew Rybchenko
On 10/7/22 21:16, Hanumanth Reddy Pothula wrote: Thanks Andrew for helping me in merging the changes. In below if condition, rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT will be always true as are not setting RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT. I think we need to do && operation. if (rx_pk

Re: [PATCH v2 3/3] devtools: enable kni library for test builds

2022-10-07 Thread David Marchand
On Fri, Oct 7, 2022 at 5:02 PM Bruce Richardson wrote: > > While KNI (or any other deprecated library) may be disabled by default, > for build testing we need it enabled. Therefore explicitly set > "disable_libs" build parameter to empty for any DPDK build where the > value is not being explicitly

RE: [EXT] Re: [PATCH v3 0/5] mbuf dynamic field expansion

2022-10-07 Thread Shijith Thotton
>> This is a continuation of the discussions[1] to add mbuf physical address >> field to >dynamic field. >> Previous version was to add PA field to dynamic field area based on the EAL >IOVA mode option. It was >> deemed unsafe as some components could still use the PA field without >checking IOVA

Re: [PATCH v2 2/3] kni: add deprecation warning at runtime

2022-10-07 Thread David Marchand
On Fri, Oct 7, 2022 at 5:01 PM Bruce Richardson wrote: > > When KNI is being used at runtime, output a warning message about its > deprecated status. This is part of the deprecation process for KNI > agreed by the DPDK technical board.[1] > > [1] http://mails.dpdk.org/archives/dev/2022-June/243596

Re: [PATCH v2 1/3] kni: flag deprecated status at build time

2022-10-07 Thread David Marchand
On Fri, Oct 7, 2022 at 5:01 PM Bruce Richardson wrote: > > To ensure all users are aware of KNI's deprecated status at build time > we can take the following actions: > > 1. disable the library by default. It can be re-enabled by setting >disabled_libs to the empty string (or other string not

[PATCH v4 7/7] drivers: mark software PMDs work with IOVA as PA disabled

2022-10-07 Thread Shijith Thotton
Enabled software PMDs in IOVA as PA disabled build as they work with IOVA as VA. Signed-off-by: Shijith Thotton --- drivers/crypto/armv8/meson.build| 1 + drivers/crypto/ipsec_mb/meson.build | 1 + drivers/crypto/null/meson.build | 1 + drivers/crypto/openssl/meson.build | 1 + drivers/

[PATCH v4 6/7] drivers: mark cnxk PMDs work with IOVA as PA disabled

2022-10-07 Thread Shijith Thotton
Enabled the flag pmd_supports_disable_iova_as_pa in cnxk driver build files as they work with IOVA as VA. Updated cn9k and cn10k soc build configurations to disable the IOVA as PA build by default. Signed-off-by: Shijith Thotton --- config/arm/meson.build | 8 +++- doc/guides/

[PATCH v4 5/7] lib: move mbuf next pointer to first cache line

2022-10-07 Thread Shijith Thotton
Swapped position of mbuf next pointer and second dynamic field (dynfield2) if the build is configured to disable IOVA as PA. This is to move the mbuf next pointer to first cache line. Signed-off-by: Shijith Thotton --- doc/guides/rel_notes/release_22_11.rst | 3 +++ lib/mbuf/rte_mbuf_core.h

[PATCH v4 4/7] mbuf: add second dynamic field member

2022-10-07 Thread Shijith Thotton
If IOVA as PA is disabled during build, mbuf physical address field is undefined. This space is used to add the second dynamic field. Signed-off-by: Shijith Thotton --- lib/mbuf/rte_mbuf_core.h | 6 +- lib/mbuf/rte_mbuf_dyn.c | 3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --

[PATCH v4 3/7] build: add meson option to configure IOVA mode as PA

2022-10-07 Thread Shijith Thotton
IOVA mode in DPDK is either PA or VA. The new build option enable_iova_as_pa configures the mode to PA at compile time. By default, this option is enabled. If the options is disabled, only drivers which supports it are enabled during build. Supported driver can set the flag pmd_supports_disable_iov

[PATCH v4 2/7] test/dma: use API to get mbuf data physical address

2022-10-07 Thread Shijith Thotton
Used rte_mbuf_data_iova API to get the physical address of mbuf data. Signed-off-by: Shijith Thotton --- app/test/test_dmadev.c | 33 ++--- 1 file changed, 14 insertions(+), 19 deletions(-) diff --git a/app/test/test_dmadev.c b/app/test/test_dmadev.c index 9e8e101f40

[PATCH v4 1/7] mbuf: add API to get and set mbuf physical address

2022-10-07 Thread Shijith Thotton
Added APIs rte_mbuf_iova_set and rte_mbuf_iova_get to set and get the physical address of an mbuf respectively. Updated applications and library to use the same. Signed-off-by: Shijith Thotton --- app/test-bbdev/test_bbdev_perf.c | 2 +- app/test-crypto-perf/cperf_test_common.c | 5 ++-

[PATCH v4 0/7] mbuf dynamic field expansion

2022-10-07 Thread Shijith Thotton
This is a continuation of the discussions[1] to add mbuf physical address field to dynamic field. Previous version was to add PA field to dynamic field area based on the EAL IOVA mode option. It was deemed unsafe as some components could still use the PA field without checking IOVA mode and ther

Re: [PATCH v5 0/6] add thread lifetime and attributes API

2022-10-07 Thread Tyler Retzlaff
thanks David, appreciate it. it's nice to finally get this series cleared. On Thu, Oct 06, 2022 at 09:25:12PM +0200, David Marchand wrote: > On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff > wrote: > > > > add rte thread lifetime and attributes api. with these api additions > > there is now suffic

Re: [PATCH v2] build: increase minimum meson version to 0.53.2

2022-10-07 Thread David Marchand
On Fri, Oct 7, 2022 at 6:24 PM Bruce Richardson wrote: > > This patchset bumps the minimum meson version from 0.49.2 to 0.53.2. > Ideally, the minimum version should be 0.53 without a point release, but > some DPDK builds (mingw) are broken with 0.53.0 due to issue[1], fixed > by commit[2] in 0.53

[PATCH v8 14/14] baseband/acc: simplify meson dependency

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Removed some of libraries from the external dependency captured in meson build file which are not required. Signed-off-by: Nic Chautru --- drivers/baseband/acc/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/baseband/acc/meson.build b/d

[PATCH v8 13/14] baseband/acc: add PF configure companion function

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added configure function notably to configure the device from the PF within DPDK and bbdev-test (without external dependency). Signed-off-by: Nic Chautru Acked-by: Hernan Vargas --- app/test-bbdev/test_bbdev_perf.c | 71 drivers/baseband/acc/meson.build | 2

[PATCH v8 12/14] baseband/acc: add device status and vf2pf comms

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added support to expose the device status seen from the host through v2pf mailbox communication. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/rte_acc200_pmd.c | 64 --- 1 file changed, 47 insertions(+), 17 deletions

[PATCH v8 11/14] baseband/acc: support interrupt

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added support for capability and functions for MSI/MSI-X interrupt and underlying information ring. Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 302 +- 1 file changed, 299 insertions(+), 3 deletions(-) diff --git a/drivers/b

[PATCH v8 10/14] baseband/acc: add support for FFT operations

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added functions and capability for FFT processing Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 240 +- 1 file changed, 238 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc/rte_acc200_pmd.c b/drivers/baseband/a

[PATCH v8 09/14] baseband/acc: add LTE processing functions

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added functions and capability for 4G FEC Signed-off-by: Nic Chautru --- drivers/baseband/acc/rte_acc200_pmd.c | 851 +- 1 file changed, 846 insertions(+), 5 deletions(-) diff --git a/drivers/baseband/acc/rte_acc200_pmd.c b/drivers/baseband/acc/rte_a

[PATCH v8 08/14] baseband/acc: add LDPC processing functions

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added LDPC encode and decode processing functions. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 84 ++ drivers/baseband/acc/rte_acc200_pmd.c | 1321 - 2 files changed, 1400 insertions(+), 5 dele

[PATCH v8 07/14] baseband/acc: add queue configuration for ACC200

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added function to create and configure queues for the device. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc_common.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 391 +- 2 files changed, 391 insertions(+)

[PATCH v8 06/14] baseband/acc: add info get function for ACC200

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added support for info_get to allow to query the device. Null capability exposed. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc200_pmd.h | 1 + drivers/baseband/acc/rte_acc200_pmd.c | 239 ++ 2 files change

[PATCH v8 05/14] baseband/acc: add HW register definitions for ACC200

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Added registers list and structure to access the device. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc/acc200_pf_enum.h | 108 + drivers/baseband/acc/acc200_pmd.h | 163 ++ drivers/baseband/acc/ac

[PATCH v8 04/14] baseband/acc: introduce PMD for ACC200

2022-10-07 Thread Nicolas Chautru
Introduced stubs for device driver for the ACC200 integrated VRAN accelerator on SPR-EEC Signed-off-by: Nicolas Chautru Reviewed-by: Maxime Coquelin --- MAINTAINERS| 3 + doc/guides/bbdevs/acc200.rst | 257 + doc/guides/bbdevs/feat

[PATCH v8 03/14] baseband/acc: rename directory from acc100 to acc

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Used a common directory for the ACC PMDs Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- MAINTAINERS | 2 +- app/test-bbdev/meson.build| 4 ++-- app/test-bbdev/test_bbdev_perf.c

[PATCH v8 01/14] baseband/acc100: remove unused registers

2022-10-07 Thread Nicolas Chautru
From: Nic Chautru Cleanep up the enum files to remove un-used registers definitions. No functionality change. Signed-off-by: Nic Chautru Reviewed-by: Maxime Coquelin --- drivers/baseband/acc100/acc100_pf_enum.h | 939 --- 1 file changed, 939 deletions(-) diff --git a/driv

From: Nicolas Chautru

2022-10-07 Thread Nicolas Chautru
v8: Rebased to latest and fix related compilation error. Added acc200.ini and updated rel_notes. Formatting improvement in comments, docs and commit message. v7: Additional update in commits 9,10,11 based on review from Maxime. v5/v6:Updates based on Maxime reviews of v4/v5. Thanks. v4: Rebase

Re: [PATCH v8 2/4] ethdev: support multiple mbuf pools per Rx queue

2022-10-07 Thread Thomas Monjalon
07/10/2022 19:29, Andrew Rybchenko: > +* **Added support for mulitiple mbuf pools per ethdev Rx queue.** mulitiple -> multiple I can fix when merging. > + > + The capability allows application to provide many mempools of different > + size and PMD and/or NIC to choose a memory pool based on th

RE: [EXT] [PATCH v7 04/14] baseband/acc: introduce PMD for ACC200

2022-10-07 Thread Chautru, Nicolas
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Friday, October 7, 2022 11:16 AM > To: Chautru, Nicolas ; dev@dpdk.org; > tho...@monjalon.net > Cc: maxime.coque...@redhat.com; t...@redhat.com; m...@ashroe.eu; > Richardson, Bruce ; > hemant.agra...@nxp.com; david.march...@redha

RE: [EXT] [PATCH v7 04/14] baseband/acc: introduce PMD for ACC200

2022-10-07 Thread Akhil Goyal
> This patch introduces stubs for device driver for the ACC200 > integrated VRAN accelerator on SPR-EEC > > Signed-off-by: Nicolas Chautru > Reviewed-by: Maxime Coquelin > --- > MAINTAINERS | 3 + > doc/guides/bbdevs/acc200.rst | 244

RE: [v2 3/7] examples/fips_validation: add function to calculate SHA hash size

2022-10-07 Thread Akhil Goyal
> Subject: [v2 3/7] examples/fips_validation: add function to calculate SHA hash > size > > Add function to calculate hash size for a given SHA hash algorithm. > > Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA") > > Signed-off-by: Gowrishankar Muthukrishnan > Acked-by: Br

[PATCH 35/35] net/ionic: add watchdogs to protect each queue type

2022-10-07 Thread Andrew Boyer
Ring the doorbell again for the following scenarios: * No receives posted but Rx queue not empty after deadline * No transmits posted but Tx work still pending after deadline * Admin queue work still pending after deadline This will help the queues recover in the extremely rare case that a door

[PATCH 34/35] net/ionic: retry init commands up to five times

2022-10-07 Thread Andrew Boyer
In some configurations, the FW may return EAGAIN if it is not able to respond to commands immediately. Retry the init commands in this case to prevent errors from reaching the client. Fix up some return-code stuff while here, for clarity. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_

[PATCH 33/35] net/ionic: use a helper variable for page size

2022-10-07 Thread Andrew Boyer
This improves readability. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index affb6a44af..0affdd9dc4 100644 --- a/driver

[PATCH 32/35] net/ionic: add optimized handlers for non-scattered Rx/Tx

2022-10-07 Thread Andrew Boyer
The code is very similar, but the simple case can skip a few branches in the hot path. This improves PPS when 10KB mbufs are used. S/G is enabled on the Rx side by offload DEV_RX_OFFLOAD_SCATTER. S/G is enabled on the Tx side by offload DEV_TX_OFFLOAD_MULTI_SEGS. S/G is automatically enabled on t

[PATCH 30/35] net/ionic: add alignment and socket info in allocations

2022-10-07 Thread Andrew Boyer
This will avoid memory access penalties on NUMA systems. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c| 5 +++-- drivers/net/ionic/ionic_lif.c | 13 - drivers/net/ionic/ionic_rx_filter.c | 3 +-- 3 files changed, 12 insertions(+), 9 deletions(-) diff -

[PATCH 29/35] net/ionic: update array allocations to use calloc

2022-10-07 Thread Andrew Boyer
Use rte_calloc() where appropriate. This makes the code clearer. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_ethdev.c | 6 +++--- drivers/net/ionic/ionic_lif.c| 12 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/ionic/ionic_ethdev.c b/dri

[PATCH 31/35] net/ionic: allow client to specify Tx free threshold

2022-10-07 Thread Andrew Boyer
Some clients have opinions about how often to flush the transmit ring. The default value is the number of Tx descriptors minus the default Tx burst size. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_dev.h| 1 + drivers/net/ionic/ionic_ethdev.c | 4 ++-- drivers/net/ionic/ionic_

[PATCH 28/35] net/ionic: add Q-in-CMB option controlled by devarg

2022-10-07 Thread Andrew Boyer
When 'ionic_cmb' is set to '1', queue memory will be allocated from the device's onboard memory (Controller Memory Buffer). In some configurations, this will dramatically reduce packet latency and increase PPS. Add the WC_ACTIVATE flag to the PCI driver flags. Write combining must be enabled to ac

[PATCH 27/35] net/ionic: add Tx descriptor status function

2022-10-07 Thread Andrew Boyer
This may be useful for clients. Signed-off-by: Andrew Boyer Signed-off-by: Allen Hubbe --- doc/guides/nics/features/ionic.ini | 1 + drivers/net/ionic/ionic_ethdev.c | 1 + drivers/net/ionic/ionic_rxtx.c | 51 ++ drivers/net/ionic/ionic_rxtx.h | 1 + 4 f

[PATCH 26/35] net/ionic: add Rx descriptor status functions

2022-10-07 Thread Andrew Boyer
These may be useful for clients. Signed-off-by: Andrew Boyer Signed-off-by: Allen Hubbe --- doc/guides/nics/features/ionic.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/ionic/ionic_ethdev.c | 2 ++ drivers/net/ionic/ionic_rxtx.c | 39 +

[PATCH 25/35] net/ionic: advertise supported packet types

2022-10-07 Thread Andrew Boyer
This improves performance, since clients may be able to skip SW packet classification. Signed-off-by: Andrew Boyer --- doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/ionic/ionic_ethdev.c | 1 + drivers/net/ionic/ionic_rxtx.c | 19 +++ drivers/net/ionic/

[PATCH 24/35] net/ionic: add a lookup table for checksum flags

2022-10-07 Thread Andrew Boyer
This improves performance by reducing branching. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 47 -- 1 file changed, 33 insertions(+), 14 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index bb09c4eb1

[PATCH 23/35] net/ionic: add a lookup table for packet type

2022-10-07 Thread Andrew Boyer
This improves performance by reducing branching. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_rxtx.c | 63 -- 1 file changed, 29 insertions(+), 34 deletions(-) diff --git a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c index 5ee6573a5

[PATCH 22/35] net/ionic: do bulk allocations of receive mbufs

2022-10-07 Thread Andrew Boyer
Do bulk allocations to improve performance. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.h | 6 ++ drivers/net/ionic/ionic_rxtx.c | 35 ++ 2 files changed, 33 insertions(+), 8 deletions(-) diff --git a/drivers/net/ionic/ionic_lif.h b/drivers/

[PATCH 21/35] net/ionic: add support for mbuf fast free

2022-10-07 Thread Andrew Boyer
Use a put() rather than a free() in the optimized case. Signed-off-by: Andrew Boyer --- doc/guides/nics/features/ionic.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/ionic/ionic_ethdev.c | 2 +- drivers/net/ionic/ionic_lif.h | 1 + drivers/net/ionic/ionic

[PATCH 19/35] net/ionic: overhaul receive side for performance

2022-10-07 Thread Andrew Boyer
Linearize RX mbuf chains in the expanded info array. Clean one and fill one per CQE (completions are not coalesced). Touch the mbufs as little as possible in the fill stage. When touching the mbuf in the clean stage, use the rearm_data unions. Ring the doorbell once at the end of the bulk clean/fil

[PATCH 20/35] net/ionic: overhaul transmit side for performance

2022-10-07 Thread Andrew Boyer
Linearize Tx mbuf chains in the info array. This avoids walking the mbuf chain during flush. Move a few branches out of the hot path. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 2 +- drivers/net/ionic/ionic_rxtx.c | 143 - 2 files changed,

  1   2   >