RE: [EXT] [PATCH v2 0/4] crypto/ccp cleanup

2022-10-06 Thread Akhil Goyal
Hi Sunil, Please review and ack. Regards, Akhil > This is a *untested* cleanup series after looking for usage of > rte_pci_device objects in DPDK drivers. > I can't test those patches by lack of hw, so I hope the driver maintainer > can look into them. > > Thanks. > -- > David Marchand > > Cha

RE: [EXT] [PATCH v4 0/5] add remaining SGL support to AESNI_MB

2022-10-06 Thread Akhil Goyal
> -- > Currently, the intel-ipsec-mb library only supports SGL for > GCM and ChaCha20-Poly1305 algorithms through the JOB API. > > To add SGL support for other algorithms, a workaround approach is > added in the AESNI_MB PMD. SG

RE: [EXT] [PATCH v4] ethdev: support congestion management

2022-10-06 Thread Sunil Kumar Kori
> -Original Message- > From: Andrew Rybchenko > Sent: Tuesday, October 4, 2022 2:33 PM > To: Ferruh Yigit ; Thomas Monjalon > ; Ray Kinsella > Cc: dev@dpdk.org; Jerin Jacob Kollanukkaran ; Sunil > Kumar Kori > Subject: [EXT] [PATCH v4] ethdev: support congestion management > > External

RE: [EXT] [PATCH v12 0/7] bbdev changes for 22.11

2022-10-06 Thread Akhil Goyal
> Thanks Akhil, > > A couple of things I miss in term of guidelines for my benefit and that I > don't see > in documentation: > - May I ask what rule we should use for documentation line breaking? I am > unclear of the reason for some of the changes you made whose origin version > looked legit to

[PATCH v2 16/16] net/dpaa: fix buffer free in slow path

2022-10-06 Thread Gagandeep Singh
If there is any error in packet or taildrop feature is enabled, HW can reject those packets and put them in error queue. Driver poll this error queue to free the buffers. DPAA driver has an issue while freeing these rejected buffers. In case of scatter gather packets, it is preparing the mbuf SG li

[PATCH v2 15/16] net/dpaa: fix buffer free on transmit SG packets

2022-10-06 Thread Gagandeep Singh
When using SG list to TX with external and direct buffers, HW free direct buffers and driver free external buffers. Software scans the complete SG mbuf list to find the external buffers to free, but this is wrong as hardware can free the direct buffers if any present in the list and same can be re

[PATCH v2 14/16] bus/dpaa: mempool ops registration change

2022-10-06 Thread Gagandeep Singh
moving the mempool ops registration before DPAA devices probe so that device probe functions can also be able to use mempool operations. Signed-off-by: Gagandeep Singh Acked-by: Hemant Agrawal --- drivers/bus/dpaa/dpaa_bus.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH v2 12/16] bus/dpaa: pass interface name as a string instead of pointer

2022-10-06 Thread Gagandeep Singh
From: Rohit Raj Due to change in latest kernel, passing the interface name to kernel through IOCTL as string instead of character pointer. Signed-off-by: Rohit Raj Acked-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/process.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH v2 13/16] net/dpaa: use internal mempool for SG table

2022-10-06 Thread Gagandeep Singh
Creating and using driver's mempool for allocating the SG table memory required for FD creation. Signed-off-by: Gagandeep Singh Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 18 ++ drivers/net/dpaa/dpaa_ethdev.h | 9 + drivers/net/dpaa/dpaa_rxtx.c | 9

[PATCH v2 11/16] doc: add kernel version compatible information

2022-10-06 Thread Gagandeep Singh
DPAA driver has dependency on kernel to perform various functionalities. So kernel and DPDK version should be compatible for proper working. This patch updates the DPAA guide with the information that user can refer to find the compatible kernel version. Signed-off-by: Gagandeep Singh --- doc/g

[PATCH v2 10/16] net/dpaa: fix Jumbo packet Rx in case of VSP

2022-10-06 Thread Gagandeep Singh
From: Rohit Raj For packet length of size more than 2K bytes, segmented packets were being received in DPDK even if mbuf size was greater than packet length. This is due to the configuration in VSP. This patch fixes the issue by configuring the VSP according to the mbuf size configured during me

[PATCH v2 09/16] bus/fslmc: add timeout in MC send command API

2022-10-06 Thread Gagandeep Singh
From: Rohit Raj Adding one second timeout in MC send command API to ensure it doesn't gets stuck in case of failure. Signed-off-by: Rohit Raj Acked-by: Hemant Agrawal --- drivers/bus/fslmc/mc/mc_sys.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/driv

[PATCH v2 08/16] net/dpaa2: fix buffer free on transmit SG packets

2022-10-06 Thread Gagandeep Singh
When using SG list to TX with external and direct buffers, HW free the direct buffers and driver free the external buffers. Software scans the complete SG mbuf list to find the external buffers to free, but this is wrong as hardware can free the direct buffers if any present in the list and same c

[PATCH v2 06/16] net/dpaa: support ESP packet type in packet parsing

2022-10-06 Thread Gagandeep Singh
Add support of ESP packet type in packet receive path. Signed-off-by: Gagandeep Singh Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 3 ++- drivers/net/dpaa/dpaa_rxtx.c | 10 ++ drivers/net/dpaa/dpaa_rxtx.h | 6 ++ 3 files changed, 18 insertions(+), 1 deletion(-

[PATCH v2 07/16] net/dpaa2: use internal mempool for SG table

2022-10-06 Thread Gagandeep Singh
Creating and using driver's mempool for allocating the SG table memory required for FD creation instead of relying on user mempool. Signed-off-by: Gagandeep Singh Acked-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 19 +++ drivers/net/dpaa2/dpaa2_ethdev.h | 9 ++

[PATCH v2 05/16] net/dpaa2: check free enqueue descriptors before Tx

2022-10-06 Thread Gagandeep Singh
From: Brick Yang Check if there exists free enqueue descriptors before enqueuing Tx packet. Also try to free enqueue descriptors in case they are not free. Fixes: ed1cdbed6a15 ("net/dpaa2: support multiple Tx queues enqueue for ordered") Cc: sta...@dpdk.org Signed-off-by: Brick Yang Signed-of

[PATCH v2 04/16] net/dpaa2: fix dpdmux configuration for error behaviour

2022-10-06 Thread Gagandeep Singh
From: Vanshika Shukla Driver is giving the wrong interface ID while setting the error behaviour. This patch fixes the issue by passing the correct MAC interface index value to the API. Fixes: 3d43972b1b42 ("net/dpaa2: do not drop parse error packets by dpdmux") Cc: sta...@dpdk.org Signed-off-b

[PATCH v2 03/16] net/enetfec: fix buffer leak issue

2022-10-06 Thread Gagandeep Singh
From: Apeksha Gupta Driver has no proper handling to free unused allocated mbufs in case of error or when the rx processing complete because of which mempool can be empty after some time. This patch fixes this issue by moving the buffer allocation code to the right place in driver. Fixes: ecae7

[PATCH v2 02/16] net/enetfec: fix restart issue

2022-10-06 Thread Gagandeep Singh
From: Apeksha Gupta Queue reset is missing in restart because of which IO cannot work on device restart. This patch fixes the issue by resetting the queues on device restart. Fixes: b84fdd39638b ("net/enetfec: support UIO") Cc: sta...@dpdk.org Signed-off-by: Apeksha Gupta Signed-off-by: Sachi

[PATCH v2 01/16] bus/dpaa: use non-block mode for FD open

2022-10-06 Thread Gagandeep Singh
From: Vanshika Shukla This patch sets qman portal file descriptors used for interrupts IO processing in non-blocking mode to avoid any unwanted blocks while IO operations over the FD. Signed-off-by: Vanshika Shukla Acked-by: Hemant Agrawal --- drivers/bus/dpaa/base/qbman/qman_driver.c | 6 +++

[PATCH v2 00/16] DPAA and DPAA2 driver changes

2022-10-06 Thread Gagandeep Singh
This series have list of patch for bug fixes and some enhancements to DPAA1 and DPAA2 net drivers. v2-change-log: * update commit messages * update DPAA NIC doc for kernel version matching * update DPAA supported packet type info * Freeing the internal pool on last device remove * fixes syntax for

[PATCH 24/24] net/nfp: add the offload support of set IPv6 DSCP action

2022-10-06 Thread Chaoyong He
Add the corresponding logics to support the offload of set IPv6 DSCP action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 2 +- drivers/net/nfp/nfp_flow.c | 39 ++

[PATCH 23/24] net/nfp: add the offload support of set IPv4 DSCP action

2022-10-06 Thread Chaoyong He
Add the corresponding logics to support the offload of set IPv4 DSCP action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 39 +++

[PATCH 22/24] net/nfp: add the offload support of set TTL action

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of set TTL action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 44

[PATCH 21/24] net/nfp: add the offload support of set TP DST port action

2022-10-06 Thread Chaoyong He
Add the corresponding logics to support the offload of set TP dest port action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 15 +++

[PATCH 19/24] net/nfp: add the offload support of set DST IPv6 action

2022-10-06 Thread Chaoyong He
Add the corresponding logics to support the offload of set dest IPv6 address action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 2 +- drivers/net/nfp/nfp_flow.c | 9 + 3

[PATCH 20/24] net/nfp: add the offload support of set TP SRC port action

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of set TP source port action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 21 +++ drivers/net/nfp/nfp_

[PATCH 18/24] net/nfp: add the offload support of set SRC IPv6 action

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of set source IPv6 address action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 33 ++

[PATCH 17/24] net/nfp: add the offload support of set DST IPv4 action

2022-10-06 Thread Chaoyong He
Add the corresponding logics to support the offload of set dest IPv4 address action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 16 +++

[PATCH 16/24] net/nfp: add the offload support of set SRC IPv4 action

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of set source IPv4 address action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 25 ++ drivers/net/

[PATCH 15/24] net/nfp: add the offload support of push VLAN action

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of push_vlan action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 3 ++ doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h |

[PATCH 14/24] net/nfp: add the offload support of pop VLAN action

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of pop_vlan action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 5 + drivers/net/nfp/nfp_flow.c

[PATCH 13/24] net/nfp: add the offload support of set DST MAC action

2022-10-06 Thread Chaoyong He
Add the corresponding logics to support the offload of set dest MAC action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 15 +++ 3 f

[PATCH 12/24] net/nfp: add the offload support of set SRC MAC action

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of set source MAC action. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 27 ++ drivers/net/nfp/nfp_f

[PATCH 11/24] net/nfp: add the offload support of SCTP item

2022-10-06 Thread Chaoyong He
Add the corresponding logics to support the offload of SCTP item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 63 ++

[PATCH 10/24] net/nfp: add the offload support of UDP item

2022-10-06 Thread Chaoyong He
Add the corresponding logics to support the offload of UDP item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 63 +++

[PATCH 09/24] net/nfp: add the offload support of TCP item

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of TCP item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 91 +++

[PATCH 08/24] net/nfp: add the offload support of IPv6 item

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of IPv6 item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 2 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 33

[PATCH 07/24] net/nfp: add the offload support of IPv4 item

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of IPv4 item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 38

[PATCH 06/24] net/nfp: add the offload support of VLAN item

2022-10-06 Thread Chaoyong He
Add the corresponding data structure and logics, to support the offload of VLAN item. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 1 + doc/guides/rel_notes/release_22_11.rst | 1 + drivers/net/nfp/nfp_flow.c | 46 ++

[PATCH 05/24] net/nfp: add the offload support of basic actions

2022-10-06 Thread Chaoyong He
Add the offload support of very basic actions: mark, rss, count, drop and output. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 6 ++ doc/guides/rel_notes/release_22_11.rst | 6 ++ drivers/net/nfp/flower/nfp_flower_cmsg.h | 11 +++

[PATCH 04/24] net/nfp: add the offload support of basic items

2022-10-06 Thread Chaoyong He
Add the offload support of very basic items: ethernet and port id. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- doc/guides/nics/features/nfp.ini | 4 + doc/guides/rel_notes/release_22_11.rst | 4 + drivers/net/nfp/flower/nfp_flower_cmsg.h | 20 +++ drivers/net/nfp

[PATCH 03/24] net/nfp: add the flow APIs of nfp PMD

2022-10-06 Thread Chaoyong He
Add the flow validate/create/query/destroy/flush API of nfp PMD. The flow create API construct a control cmsg and send it to firmware, then add this flow to the hash table. The flow query API get flow stats from the flow_priv structure. Note there exist an rte_spin_lock to prevent the update and

[PATCH 02/24] net/nfp: add the structures and functions for flow offload

2022-10-06 Thread Chaoyong He
Add the structures and functions to process mask table, flow table, and flow stats id, which are used in the rte_flow offload logics. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.c | 11 +- drivers/net/nfp/meson.build | 3 + drivers/n

[PATCH 01/24] net/nfp: add the stats process logic in ctrl VNIC service

2022-10-06 Thread Chaoyong He
Add the flow stats process logic in the ctrl VNIC service. The flower firmware pass the flow stats to nfp driver through control message, we store them in the flow_priv structure. Signed-off-by: Chaoyong He Reviewed-by: Niklas Söderlund --- drivers/net/nfp/flower/nfp_flower.h | 2 + drive

[PATCH 00/24] add the basic rte_flow offload support of nfp PMD

2022-10-06 Thread Chaoyong He
This is the second patch series to add the support of rte_flow offload for nfp PMD, includes: Implement the rte_flow related API Implement the offload framework of nfp card Add the offload support of common rte_flow pattern items Add the offload support of common rte_flow actions Chaoyong He (24):

Re: [EXT] Re: [PATCH v4] ethdev: support congestion management

2022-10-06 Thread Jerin Jacob Kollanukkaran
Thanks Andrew. Changes are fine with me From: Andrew Rybchenko Sent: Thursday, October 6, 2022 2:06 PM To: Ferruh Yigit ; Thomas Monjalon ; Ray Kinsella Cc: dev@dpdk.org ; Jerin Jacob Kollanukkaran ; Sunil Kumar Kori Subject: [EXT] Re: [PATCH v4] ethdev: suppo

RE: [EXT] [dpdk-dev v5] lib/cryptodev: multi-process IPC request handler

2022-10-06 Thread Ji, Kai
Hi Akhill, Thanks for your reply, please see my comments below. > -Original Message- > From: Akhil Goyal > Sent: Thursday, October 6, 2022 7:49 PM > To: Ji, Kai ; dev@dpdk.org > Cc: Fan Zhang ; Ray Kinsella ; > Burakov, Anatoly ; Mcnamara, John > > Subject: RE: [EXT] [dpdk-dev v5] lib/

Re: [dpdk-dev v5] lib/cryptodev: multi-process IPC request handler

2022-10-06 Thread Konstantin Ananyev
06/10/2022 18:06, Kai Ji пишет: As some cryptode PMDs have multiprocess support, the secondary process needs queue-pair to be configured by the primary process before to use. This patch adds an IPC register function to help the primary process to register IPC action that allow secondary process t

RE: [EXT] [PATCH v12 0/7] bbdev changes for 22.11

2022-10-06 Thread Chautru, Nicolas
Thanks Akhil, A couple of things I miss in term of guidelines for my benefit and that I don't see in documentation: - May I ask what rule we should use for documentation line breaking? I am unclear of the reason for some of the changes you made whose origin version looked legit to me. Were you

[PATCH] eal: non-temporal memcpy

2022-10-06 Thread Morten Brørup
This patch provides a function for memory copy using non-temporal store, load or both, controlled by flags passed to the function. Applications sometimes copy data to another memory location, which is only used much later. In this case, it is inefficient to pollute the data cache with the copied d

Re: [PATCH v5 01/10] memarea: introduce memarea library

2022-10-06 Thread Mattias Rönnblom
On 2022-10-05 06:09, datshan wrote: From: Chengwen Feng The memarea library is an allocator of variable-size object which based on a memory region. This patch provides create/destroy API. Signed-off-by: Chengwen Feng --- MAINTAINERS| 5 + doc/api/doxy-api-ind

Re: [PATCH v5 07/10] memarea: support backup memory mechanism

2022-10-06 Thread Mattias Rönnblom
On 2022-10-05 06:09, datshan wrote: From: Chengwen Feng This patch supports backup memory mechanism, the memarea could use another memarea as a backup. Maybe it's worth mentioning what backup means already here. "This patch adds a memarea backup mechanism, where an allocation request which

Re: [PATCH v5 03/10] memarea: support alloc/free/update-refcnt API

2022-10-06 Thread Mattias Rönnblom
On 2022-10-05 06:09, datshan wrote: From: Chengwen Feng This patch supports rte_memarea_alloc()/rte_memarea_free()/ rte_memarea_update_refcnt() API. Signed-off-by: Chengwen Feng --- doc/guides/prog_guide/memarea_lib.rst | 10 ++ lib/memarea/memarea_private.h | 3 + lib/memarea/

Re: [PATCH v3] test/service: fix spurious failures by extending timeout

2022-10-06 Thread David Marchand
On Thu, Oct 6, 2022 at 3:27 PM Morten Brørup wrote: > > This commit extends the timeout for service_may_be_active() > > from 100ms to 1000ms. Local testing on a idle and loaded system > > (compiling DPDK with all cores) always completes after 1 ms. > > > > The wait time for a service-lcore to fini

Re: [PATCH v2] drivers/bus: set device NUMA node to unknown by default

2022-10-06 Thread David Marchand
On Tue, Oct 4, 2022 at 4:59 PM Olivier Matz wrote: > > The dev->device.numa_node field is set by each bus driver for > every device it manages to indicate on which NUMA node this device lies. > > When this information is unknown, the assigned value is not consistent > across the bus drivers. > > S

Re: [PATCH v5 0/6] add thread lifetime and attributes API

2022-10-06 Thread David Marchand
On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff wrote: > > add rte thread lifetime and attributes api. with these api additions > there is now sufficient platform abstracted thread api to remove the > use of pthread in the unit tests. > > v5: > * include errno.h in rte_thread.c since errno.h is no

[PATCH 3/3] sched: support for 100G+ rates in subport/pipe config

2022-10-06 Thread Megha Ajmera
Config load functions updated to support 100G rates for subport and pipes. Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 64 +-- 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/examples/qos_sched/cfg_file.c b/examples/qos_sched/cf

[PATCH 2/3] sched: removed unused subport field in hqos profile

2022-10-06 Thread Megha Ajmera
Removed unused subport field from profile.cfg Correctly using subport profile id in subport config load. Fixes: 802d214dc880 ("examples/qos_sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera --- examples/qos_sched/cfg_file.c | 2 +- examples/

[PATCH 1/3] sched: fix subport profile id not set correctly

2022-10-06 Thread Megha Ajmera
In rte_sched_subport_config() API, subport_profile_id is not set correctly. Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") Cc: cristian.dumitre...@intel.com Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/sched/rte_s

RE: [EXT] [dpdk-dev v5] lib/cryptodev: multi-process IPC request handler

2022-10-06 Thread Akhil Goyal
> As some cryptode PMDs have multiprocess support, the secondary > process needs queue-pair to be configured by the primary process before > to use. This patch adds an IPC register function to help the primary > process to register IPC action that allow secondary process to configure > cryptodev qu

[PATCH] linux/igb_uio: fix build with kernel 5.18+

2022-10-06 Thread Georg Müller
pci_set_dma_mask() and pci_set_consistent_dma_mask() were removed with kernel 5.18. They both were just wrappers for dma_set_mask() and dma_set_coherent_mask(). Instead, use dma_set_mask_and_coherent(), which is a combination of dma_set_mask() and dma_set_coherent_mask(). dma_set_mask_and_coheren

[PATCH v3 1/1] app/testpmd: control passing Rx metadata to PMD

2022-10-06 Thread Hanumanth Pothula
Presently, Rx metadata is sent to PMD by default, leading to a performance drop as processing for the same in rx path takes extra cycles. Hence, introducing command line argument, 'nic-to-pmd-rx-metadata' to control passing rx metadata to PMD. By default it’s disabled. Signed-off-by: Hanumanth Po

Re: [PATCH] eal: fix return type of bsf safe functions

2022-10-06 Thread Mattias Rönnblom
On 2022-10-05 17:40, Thomas Monjalon wrote: In a recent commit, changing return type from int to uint32_t, I did a last minute change to functions rte_bsf32_safe and rte_bsf64_safe, because thought they were forgotten. Actually these functions are returning 0 or 1, so it should be int. Wouldn't

RE: [PATCH v6 1/3] ethdev: support mulitiple mbuf pools per Rx queue

2022-10-06 Thread Hanumanth Reddy Pothula
Hello Andrew/Thomas/Ferruh, Thank You for your comments. I have taken care and uploaded new patch-set. As tomorrow is RC1 release. Could you please help in reviewing the changes and in merging the changes, if changes looks good. Regards, Hanumanth > -Original Message- > From: Hanumanth

RE: [Patch v10 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD

2022-10-06 Thread Long Li
> Subject: Re: [Patch v10 00/18] Introduce Microsoft Azure Network Adatper > (MANA) PMD > > On 10/6/2022 9:54 AM, Ferruh Yigit wrote: > > On 10/6/2022 12:21 AM, lon...@linuxonhyperv.com wrote: > > > >> > >> From: Long Li > >> > >> MANA is a network interface card to be used in the Azure cloud > >

[PATCH v6 3/3] app/testpmd: support mulitiple mbuf pools per Rx queue

2022-10-06 Thread Hanumanth Pothula
This patch adds support for the mulitiple mempool. Some of the HW has support for choosing memory pools based on the packet's size. The pool sort capability allows PMD to choose a memory pool based on the packet's length. On multiple mempool support enabled, populate mempool array and also print p

[PATCH v6 2/3] net/cnxk: support mulitiple mbuf pools per Rx queue

2022-10-06 Thread Hanumanth Pothula
Presently, HW is programmed only to receive packets from LPB pool. Making all packets received from LPB pool. But, CNXK HW supports two pools, - SPB -> packets with smaller size (less than 4K) - LPB -> packets with bigger size (greater than 4K) Patch enables multiple mempool capability, pool is

[PATCH v6 1/3] ethdev: support mulitiple mbuf pools per Rx queue

2022-10-06 Thread Hanumanth Pothula
This patch adds support for multiple mempool capability. Some of the HW has support for choosing memory pools based on the packet's size. The capability allows PMD to choose a memory pool based on the packet's length. This is often useful for saving the memory where the application can create a di

RE: [dpdklab] RE: rte_service unit test failing randomly

2022-10-06 Thread Honnappa Nagarahalli
> > > > > > On 2022-10-06 10:18, Morten Brørup wrote: > > > >> From: Mattias Rönnblom [mailto:mattias.ronnb...@ericsson.com] > > > >> Sent: Thursday, 6 October 2022 09.51 > > > >> > > > >> On 2022-10-06 08:53, Morten Brørup wrote: > > > > > > > > [...] > > > > > > > >>> I have been wondering how

RE: [EXT] [PATCH v12 0/7] bbdev changes for 22.11

2022-10-06 Thread Akhil Goyal
> Hi Akhil, Thomas, > > v12: minor change to fix misaligned comment on patch 6 raised by Thomas. > Thanks. > v11: updated based on Thomas review notably on comments through the serie > and ordering. Thanks. I have also updated rel_notes and deprecation through > the serie this time. > v10: replaci

Re: [PATCH v9 1/3] power: add Intel uncore frequency control API to power library

2022-10-06 Thread Stephen Hemminger
On Thu, 6 Oct 2022 09:38:01 + Tadhg Kearney wrote: > Add API to allow uncore frequency adjustment. Uncore is a > term used by Intel to describe function of a microprocessor > that are closely connected to the core to achieve high > performance. This is done through manipulating related > unc

[dpdk-dev v5] lib/cryptodev: multi-process IPC request handler

2022-10-06 Thread Kai Ji
As some cryptode PMDs have multiprocess support, the secondary process needs queue-pair to be configured by the primary process before to use. This patch adds an IPC register function to help the primary process to register IPC action that allow secondary process to configure cryptodev queue-pair v

[PATCH v5 3/3] app/testpmd: support mulitiple mbuf pools per Rx queue

2022-10-06 Thread Hanumanth Pothula
This patch adds support for the mulitiple mempool. Some of the HW has support for choosing memory pools based on the packet's size. The pool sort capability allows PMD to choose a memory pool based on the packet's length. On multiple mempool support enabled, populate mempool array and also print p

[PATCH v5 2/3] net/cnxk: support mulitiple mbuf pools per Rx queue

2022-10-06 Thread Hanumanth Pothula
Presently, HW is programmed only to receive packets from LPB pool. Making all packets received from LPB pool. But, CNXK HW supports two pools, - SPB -> packets with smaller size (less than 4K) - LPB -> packets with bigger size (greater than 4K) Patch enables multiple mempool capability, pool is

[PATCH v5 1/3] ethdev: support mulitiple mbuf pools per Rx queue

2022-10-06 Thread Hanumanth Pothula
This patch adds support for multiple mempool capability. Some of the HW has support for choosing memory pools based on the packet's size. The capability allows PMD to choose a memory pool based on the packet's length. This is often useful for saving the memory where the application can create a di

Re: [Patch v10 00/18] Introduce Microsoft Azure Network Adatper (MANA) PMD

2022-10-06 Thread Ferruh Yigit
On 10/6/2022 9:54 AM, Ferruh Yigit wrote: On 10/6/2022 12:21 AM, lon...@linuxonhyperv.com wrote: From: Long Li MANA is a network interface card to be used in the Azure cloud environment. MANA provides safe access to user memory through memory registration. It has IOMMU built into the hard

Re: [PATCH v5 0/3] support ethdev Rx/Tx descriptor dump

2022-10-06 Thread Ferruh Yigit
On 10/6/2022 1:05 PM, Dongdong Liu wrote: Support ethdev Rx/Tx descriptor dump by using procinfo tool. Thanks to Ferruh, Andrew and Reshma help to review the patchset. NOTE: October 1st to October 7th is China's National Day holiday. I don't have a test environment available at the moment. I wi

Re: [PATCH v5 2/3] net/hns3: support Rx/Tx bd dump

2022-10-06 Thread Ferruh Yigit
On 10/6/2022 1:05 PM, Dongdong Liu wrote: This patch support query HW descriptor from hns3 device. HW descriptor is also called BD(buffer description) which is shared memory between software and hardware. Signed-off-by: Min Hu (Connor) Signed-off-by: Dongdong Liu Acked-by: Ferruh Yigit

Re: [PATCH v5 1/3] ethdev: introduce ethdev desc dump API

2022-10-06 Thread Ferruh Yigit
On 10/6/2022 1:05 PM, Dongdong Liu wrote: Added the ethdev Rx/Tx desc dump API which provides functions for query descriptor from device. HW descriptor info differs in different NICs. The information demonstrates I/O process which is important for debug. As the information is different between NI

RE: [dpdk-dev v4] lib/cryptodev: multi-process IPC request handler

2022-10-06 Thread Power, Ciara
Hi Kai, > -Original Message- > From: Kai Ji > Sent: Thursday 6 October 2022 09:17 > To: dev@dpdk.org > Cc: Ji, Kai ; Akhil Goyal ; Fan Zhang > ; Ray Kinsella ; Burakov, Anatoly > > Subject: [dpdk-dev v4] lib/cryptodev: multi-process IPC request handler > > As some cryptode PMDs have mul

RE: [PATCH v3 1/4] ethdev: add trace points

2022-10-06 Thread Morten Brørup
> From: Ankur Dwivedi [mailto:adwiv...@marvell.com] > Sent: Thursday, 6 October 2022 17.19 > > Add trace points for ethdev functions. > > Signed-off-by: Ankur Dwivedi > --- I did my best, but this series needs review by people with direct knowledge about the affected functions. rte_eth_call_r

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-10-06 Thread Tyler Retzlaff
On Thu, Oct 06, 2022 at 05:26:10PM +0200, David Marchand wrote: > On Thu, Oct 6, 2022 at 5:20 PM Tyler Retzlaff > wrote: > > > > On Thu, Oct 06, 2022 at 05:14:55PM +0200, Thomas Monjalon wrote: > > > 06/10/2022 17:10, Tyler Retzlaff: > > > > On Thu, Oct 06, 2022 at 03:36:12PM +0200, Thomas Monjalo

Re: [PATCH v7 0/4] Add lcore poll busyness telemetry

2022-10-06 Thread Mattias Rönnblom
On 2022-10-06 15:25, Morten Brørup wrote: >> From: Kevin Laatz [mailto:kevin.la...@intel.com] >> Sent: Wednesday, 5 October 2022 15.45 >> >> On 14/09/2022 10:29, Kevin Laatz wrote: >>> Currently, there is no way to measure lcore polling busyness in a >> passive >>> way, without any modifications to

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-10-06 Thread David Marchand
On Thu, Oct 6, 2022 at 5:20 PM Tyler Retzlaff wrote: > > On Thu, Oct 06, 2022 at 05:14:55PM +0200, Thomas Monjalon wrote: > > 06/10/2022 17:10, Tyler Retzlaff: > > > On Thu, Oct 06, 2022 at 03:36:12PM +0200, Thomas Monjalon wrote: > > > > 05/10/2022 18:34, Tyler Retzlaff: > > > > > On Wed, Oct 05,

[PATCH v3 4/4] ethdev: add trace points for tm

2022-10-06 Thread Ankur Dwivedi
Adds trace points for rte_tm specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 90 ++ lib/ethdev/rte_ethdev_trace.h| 283 +++ lib/ethdev/rte_tm.c | 40 + lib/ethdev/version.map

[PATCH v3 3/4] ethdev: add trace points for mtr

2022-10-06 Thread Ankur Dwivedi
Adds trace points for rte_mtr specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 57 ++ lib/ethdev/rte_ethdev_trace.h| 176 +++ lib/ethdev/rte_mtr.c | 27 + lib/ethdev/version.map

[PATCH v3 2/4] ethdev: add trace points for flow

2022-10-06 Thread Ankur Dwivedi
Adds trace points for rte_flow specific functions in ethdev lib. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_trace_points.c | 117 + lib/ethdev/rte_ethdev_trace.h| 434 +++ lib/ethdev/rte_flow.c| 54 lib/ethdev/version.map

[PATCH v3 1/4] ethdev: add trace points

2022-10-06 Thread Ankur Dwivedi
Add trace points for ethdev functions. Signed-off-by: Ankur Dwivedi --- lib/ethdev/ethdev_private.c |3 + lib/ethdev/ethdev_trace_points.c | 435 +++ lib/ethdev/rte_ethdev.c | 152 lib/ethdev/rte_ethdev_trace.h| 1194 ++ lib/ethdev

[PATCH v3 0/4] add trace points in ethdev library

2022-10-06 Thread Ankur Dwivedi
This series adds trace points for functions in the ethdev library. The trace points are added in ethdev, flow, mtr and tm files. v3: - Moved the trace functions from EXPERIMENTAL to INTERNAL in version.map. - Moved trace functions call to the end, in ethdev and flow trace. - Added code to pr

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-10-06 Thread Tyler Retzlaff
On Thu, Oct 06, 2022 at 05:14:55PM +0200, Thomas Monjalon wrote: > 06/10/2022 17:10, Tyler Retzlaff: > > On Thu, Oct 06, 2022 at 03:36:12PM +0200, Thomas Monjalon wrote: > > > 05/10/2022 18:34, Tyler Retzlaff: > > > > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > > > > > Newly

Re: [PATCH v5 4/6] test/threads: add tests for thread lifetime API

2022-10-06 Thread Tyler Retzlaff
On Thu, Oct 06, 2022 at 10:32:56AM +0200, David Marchand wrote: > On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff > wrote: > > > > Test basic functionality and demonstrate use of following thread > > lifetime api. > > > > * rte_thread_create > > * rte_thread_detach > > And, to some extent,

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-10-06 Thread Thomas Monjalon
06/10/2022 17:10, Tyler Retzlaff: > On Thu, Oct 06, 2022 at 03:36:12PM +0200, Thomas Monjalon wrote: > > 05/10/2022 18:34, Tyler Retzlaff: > > > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > > > > Newly added code can go to eal_common_thread.c rather than introduce a > > > > >

DPDK Deprecation Notice Review Meeting 2022-09-30

2022-10-06 Thread Mcnamara, John
DPDK Deprecation Notice Review Meeting 2022-09-30 = DPDK Community member met and reviewed the status of the DPDK deprecation notices prior to the RC1 deadline. The source document is https://git.dpdk.org/dpdk/tree/doc/guides/rel_notes/deprecation.rs

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-10-06 Thread Tyler Retzlaff
On Thu, Oct 06, 2022 at 08:52:02AM +0200, David Marchand wrote: > On Wed, Oct 5, 2022 at 6:34 PM Tyler Retzlaff > wrote: > > > > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > > hi David, > > > > > > > > > > > > > > Newly added code can go to eal_common_thread.c rather than in

Re: [PATCH v4 0/6] add thread lifetime and attributes API

2022-10-06 Thread Tyler Retzlaff
On Thu, Oct 06, 2022 at 03:36:12PM +0200, Thomas Monjalon wrote: > 05/10/2022 18:34, Tyler Retzlaff: > > On Wed, Oct 05, 2022 at 09:11:26AM -0700, Tyler Retzlaff wrote: > > > > Newly added code can go to eal_common_thread.c rather than introduce a > > > > new common/rte_thread.c file (or is there a

[v2 19/19] net/mlx5/hws: Enable HWS

2022-10-06 Thread Alex Vesker
Replace stub implenation of HWS with mlx5dr code. Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/meson.build | 18 + drivers/net/mlx5/hws/mlx5dr.h | 594 + drivers/net/mlx5/hws/mlx5dr_internal.h | 93 drivers/net/mlx5/meson.build | 1

[v2 15/19] net/mlx5/hws: Add HWS matcher object

2022-10-06 Thread Alex Vesker
HWS matcher resides under the table object, each table can have multiple chained matcher with different attributes. Each matcher represents a combination of match and action templates. Each matcher can contain multiple configurations based on the templates. Packets are steered from the table to the

[v2 18/19] net/mlx5/hws: Add HWS debug layer

2022-10-06 Thread Alex Vesker
The debug layer is used to generate a debug CSV file containing details of the context, table, matcher, rules and other useful debug information. Signed-off-by: Hamdan Igbaria Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_debug.c | 462 drivers/net/mlx5

[v2 17/19] net/mlx5/hws: Add HWS action object

2022-10-06 Thread Alex Vesker
Action objects are used for executing different HW actions over packets. Each action contains the HW resources and parameters needed for action use over the HW when creating a rule. Signed-off-by: Erez Shitrit Signed-off-by: Alex Vesker --- drivers/net/mlx5/hws/mlx5dr_action.c | 2221 +

  1   2   3   >