> From: Ankur Dwivedi [mailto:adwiv...@marvell.com] > Sent: Thursday, 6 October 2022 17.19 > > Add trace points for ethdev functions. > > Signed-off-by: Ankur Dwivedi <adwiv...@marvell.com> > ---
I did my best, but this series needs review by people with direct knowledge about the affected functions. rte_eth_call_rx/tx_callbacks() are treated as fast path functions, but I think more functions should be too: rte_eth_tx_buffer_drop_callback() and rte_eth_tx_buffer_count_callback() are certainly fast path functions. rte_eth_tx_done_cleanup()probably is too. rte_eth_macaddr_get() could be, but probably isn't. If treated as slow path, it could be noted in its documentation. I don't know about rte_eth_timesync_read_rx/tx_timestamp(), rte_eth_timesync_adjust/read/write_time() and rte_eth_read_clock().
