[PATCH] vdpa/ifc/base: fix null pointer dereference

2022-07-07 Thread Andy Pei
Fix null pointer dereference reported in coverity scan. Output some log information when lm_cfg is null. Make lm_cfg is not null before operate on lm_cfg. Coverity issue: 378882 Fixes: d7fe5a2861e7 ("net/ifc: support live migration") Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.c

RE: [PATCH V2] app/testpmd: fix display types failure when query RSS rule

2022-07-07 Thread Li, WeiyuanX
> -Original Message- > From: Huisong Li > Sent: Friday, July 8, 2022 9:42 AM > To: ferruh.yi...@xilinx.com; andrew.rybche...@oktetlabs.ru; > dev@dpdk.org > Cc: tho...@monjalon.net; Li, WeiyuanX ; > huangda...@huawei.com; liudongdo...@huawei.com; > lihuis...@huawei.com > Subject: [PATCH V2]

ice QinQ Offload not working on DPDK 21.11.1

2022-07-07 Thread 韩爽
Hello, We recently tested QINQ offload for intel E810 nic. [Ethernet controller: Intel Corporation Ethernet Controller E810-C for SFP (rev 02) Device id 8086:1593] relative software versions as below: DPDK: 21.11.1 kernel driver: 1.7.16 OS default DDP: 1.3.27 Firmware: 3.1 We've tested testpmd a

RE: [PATCH v4] net/i40e: restore disable double VLAN by default

2022-07-07 Thread Zhang, Qi Z
> -Original Message- > From: Xing, Beilei > Sent: Friday, July 8, 2022 8:22 AM > To: Liu, KevinX ; dev@dpdk.org > Cc: Zhang, Yuying ; Yang, SteveX > > Subject: RE: [PATCH v4] net/i40e: restore disable double VLAN by default > > > > > -Original Message- > > From: Liu, KevinX

RE: [PATCH v4] net/i40e: restore disable double VLAN by default

2022-07-07 Thread Xing, Beilei
> -Original Message- > From: Liu, KevinX > Sent: Friday, July 8, 2022 1:05 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Yuying > ; Yang, SteveX ; Liu, KevinX > > Subject: [PATCH v4] net/i40e: restore disable double VLAN by default > > Previously, QinQ is enabled by default and ca

[PATCH v1 10/10] baseband/acc200: add PF configure companion function

2022-07-07 Thread Nicolas Chautru
Add configure function notably to configure the device from the PF within DPDK and bbdev-test (without external dependency). Signed-off-by: Nicolas Chautru --- app/test-bbdev/meson.build | 3 + app/test-bbdev/test_bbdev_perf.c | 76 + drivers/baseband/acc200/meson.bu

[PATCH v1 08/10] baseband/acc200: support interrupt

2022-07-07 Thread Nicolas Chautru
Adding support for capability and functions for MSI/MSI-X interript and underlying information ring. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 370 ++- 1 file changed, 368 insertions(+), 2 deletions(-) diff --git a/drivers/baseband

[PATCH v1 09/10] baseband/acc200: add device status and vf2pf comms

2022-07-07 Thread Nicolas Chautru
Add support to expose the device status seen from the host through v2pf mailbox communication. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/baseband/acc200/rte_acc200_pmd.c b

[PATCH v1 07/10] baseband/acc200: add support for FFT operations

2022-07-07 Thread Nicolas Chautru
Add functions and capability for FFT processing Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 272 ++- 1 file changed, 270 insertions(+), 2 deletions(-) diff --git a/drivers/baseband/acc200/rte_acc200_pmd.c b/drivers/baseband/acc200/r

[PATCH v1 06/10] baseband/acc200: add LTE processing functions

2022-07-07 Thread Nicolas Chautru
Add functions and capability for 4G FEC Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 1244 +- 1 file changed, 1235 insertions(+), 9 deletions(-) diff --git a/drivers/baseband/acc200/rte_acc200_pmd.c b/drivers/baseband/acc200/rte_acc2

[PATCH v1 05/10] baseband/acc200: add LDPC processing functions

2022-07-07 Thread Nicolas Chautru
Adding LDPC encode and decode processing functions. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/rte_acc200_pmd.c | 2116 +- 1 file changed, 2112 insertions(+), 4 deletions(-) diff --git a/drivers/baseband/acc200/rte_acc200_pmd.c b/drivers/baseband/acc

[PATCH v1 04/10] baseband/acc200: add queue configuration

2022-07-07 Thread Nicolas Chautru
Adding fuinction to create and configure queues for the device. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/acc200_pmd.h | 62 drivers/baseband/acc200/rte_acc200_pmd.c | 506 ++- 2 files changed, 567 insertions(+), 1 deletion(-) diff --git a/

[PATCH v1 03/10] baseband/acc200: add info get function

2022-07-07 Thread Nicolas Chautru
Add support for info_get to allow to query the device. Null capability exposed. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/acc200_pmd.h | 2 + drivers/baseband/acc200/rte_acc200_cfg.h | 94 drivers/baseband/acc200/rte_acc200_pmd.c | 256 +++

[PATCH v1 02/10] baseband/acc200: add HW register definitions

2022-07-07 Thread Nicolas Chautru
Add registers list and structure to access the device. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc200/acc200_pf_enum.h | 468 drivers/baseband/acc200/acc200_pmd.h | 588 +++ drivers/baseband/acc200/acc200_vf_enum.h | 89 +

[PATCH v1 01/10] baseband/acc200: introduce PMD for ACC200

2022-07-07 Thread Nicolas Chautru
This patch introduce stubs for device driver for the ACC200 integrated VRAN accelerator on SPR-EEC Signed-off-by: Nicolas Chautru --- MAINTAINERS | 3 + doc/guides/bbdevs/acc200.rst | 244 +++ doc/guides/bbdevs/index.rst

[PATCH v1 00/10] baseband/acc200

2022-07-07 Thread Nicolas Chautru
This is targeting 22.11 and includes the PMD for the integrated accelerator on Intel Xeon SPR-EEC. There is a dependency on that parallel serie still in-flight which extends the bbdev api https://patches.dpdk.org/project/dpdk/list/?series=23894 I will be offline for a few weeks for the summer b

RE: [Patch v3 01/17] net/mana: add basic driver, build environment and doc

2022-07-07 Thread Long Li
> Subject: Re: [Patch v3 01/17] net/mana: add basic driver, build environment > and > doc > > On Thu, 7 Jul 2022 13:30:06 -0700 > lon...@linuxonhyperv.com wrote: > > > + file = fopen(path, "rb"); > > Minor nit, if you make any later changes. > "rb" is same as "r" on Linux. b means binary, a

RE: [Patch v3 10/17] net/mana: implement memory registration

2022-07-07 Thread Long Li
> Subject: Re: [Patch v3 10/17] net/mana: implement memory registration > > On Thu, 7 Jul 2022 13:30:15 -0700 > lon...@linuxonhyperv.com wrote: > > > +int mana_new_pmd_mr(struct mana_mr_btree *local_tree, struct mana_priv > *priv, > > + struct rte_mempool *pool) > > +{ > > + stru

RE: [PATCH] doc: add deprecation for restrictions in telemetry naming

2022-07-07 Thread Morten Brørup
> From: Bruce Richardson [mailto:bruce.richard...@intel.com] > Sent: Thursday, 7 July 2022 15.40 > > Following discussion on-list [1], we will look to limited the allowed > characters in names for items in telemetry. This will simplify the > escaping needed for json output, or any future output fo

Re: [Patch v3 01/17] net/mana: add basic driver, build environment and doc

2022-07-07 Thread Stephen Hemminger
On Thu, 7 Jul 2022 13:30:06 -0700 lon...@linuxonhyperv.com wrote: > +static int mana_pci_probe_mac(struct rte_pci_driver *pci_drv __rte_unused, > + struct rte_pci_device *pci_dev, > + struct rte_ether_addr *mac_addr) > +{ > + struct ibv_devi

Re: [Patch v3 10/17] net/mana: implement memory registration

2022-07-07 Thread Stephen Hemminger
On Thu, 7 Jul 2022 13:30:15 -0700 lon...@linuxonhyperv.com wrote: > +int mana_new_pmd_mr(struct mana_mr_btree *local_tree, struct mana_priv *priv, > + struct rte_mempool *pool) > +{ > + struct ibv_mr *ibv_mr; > + struct mana_range ranges[pool->nb_mem_chunks]; > + uint3

Re: [Patch v3 01/17] net/mana: add basic driver, build environment and doc

2022-07-07 Thread Stephen Hemminger
On Thu, 7 Jul 2022 13:30:06 -0700 lon...@linuxonhyperv.com wrote: > + file = fopen(path, "rb"); Minor nit, if you make any later changes. "rb" is same as "r" on Linux. b means binary, and this is actually a text file.

RE: [PATCH 2/2] net: have checksum routines accept unaligned data

2022-07-07 Thread Morten Brørup
> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > Sent: Thursday, 7 July 2022 20.35 > > From: Mattias Rönnblom > > __rte_raw_cksum() (used by rte_raw_cksum() among others) accessed its > data through an uint16_t pointer, which allowed the compiler to assume > the data was 16-bit aligned.

RE: [PATCH v8] sched: enable CMAN at runtime

2022-07-07 Thread Danilewicz, MarcinX
> > For an instance: > > If (cman_params.cman_mode == RTE_SCHED_CMAN_PIE || > > cman_params.cman_mode == RTE_SCHED_CMAN_RED) { Then set > > subport_params[i].cman_params to cman_params. > > } > > Yes, this is correct as well. I'm happy to hear that.

[Patch v3 17/17] net/mana: add function to report queue stats

2022-07-07 Thread longli
From: Long Li Report packet statistics. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 2 + drivers/net/mana/mana.c | 77 +++ 2 files changed, 79 insertions(+) diff --git a/doc/guides/nics/features/mana.ini b/doc/guides/nics/features/man

[Patch v3 16/17] net/mana: add function to start/stop device

2022-07-07 Thread longli
From: Long Li Add support for starting/stopping the device. Signed-off-by: Long Li --- Change log: v2: Use spinlock for memory registration cache. Add prefix mana_ to all function names. drivers/net/mana/mana.c | 70 + 1 file changed, 70 insertions(+)

[Patch v3 15/17] net/mana: add function to send packets

2022-07-07 Thread longli
From: Long Li With all the TX queues created, MANA can send packets over those queues. Signed-off-by: Long Li --- Change log: v2: Rename all camel cases. doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 1 + drivers/net/mana/mana.h | 65 dri

[Patch v3 14/17] net/mana: add function to receive packets

2022-07-07 Thread longli
From: Long Li With all the RX queues created, MANA can use those queues to receive packets. Signed-off-by: Long Li --- Change log: v2: Add mana_ to all function names. Rename a camel case. doc/guides/nics/features/mana.ini | 2 + drivers/net/mana/mana.c | 2 + drivers/net/mana/m

[Patch v3 13/17] net/mana: add function to start/stop RX queues

2022-07-07 Thread longli
From: Long Li MANA allocates device queues through the IB layer when starting RX queues. When device is stopped all the queues are unmapped and freed. Signed-off-by: Long Li --- Change log: v2: Add prefix mana_ to all function names. Remove unused header files. drivers/net/mana/mana.h |

[Patch v3 12/17] net/mana: add function to start/stop TX queues

2022-07-07 Thread longli
From: Long Li MANA allocate device queues through the IB layer when starting TX queues. When device is stopped all the queues are unmapped and freed. Signed-off-by: Long Li --- Change log: v2: Add prefix mana_ to all function names. Remove unused header files. doc/guides/nics/features/mana.in

[Patch v3 11/17] net/mana: implement the hardware layer operations

2022-07-07 Thread longli
From: Long Li The hardware layer of MANA understands the device queue and doorbell formats. Those functions are implemented for use by packet RX/TX code. Signed-off-by: Long Li --- Change log: v2: Remove unused header files. Rename a camel case. drivers/net/mana/gdma.c | 284

[Patch v3 10/17] net/mana: implement memory registration

2022-07-07 Thread longli
From: Long Li MANA hardware has iommu built-in, that provides hardware safe access to user memory through memory registration. Since memory registration is an expensive operation, this patch implements a two level memory registration cache mechanisum for each queue and for each port. Signed-off-

[Patch v3 09/17] net/mana: add function to configure TX queues

2022-07-07 Thread longli
From: Long Li TX hardware queue is allocated when starting the queue, this is for pre configuration. Signed-off-by: Long Li --- drivers/net/mana/mana.c | 65 + 1 file changed, 65 insertions(+) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana

[Patch v3 08/17] net/mana: add function to configure RX queues

2022-07-07 Thread longli
From: Long Li RX hardware queue is allocated when starting the queue. This function is for queue configuration pre starting. Signed-off-by: Long Li --- drivers/net/mana/mana.c | 68 + 1 file changed, 68 insertions(+) diff --git a/drivers/net/mana/mana.c

[Patch v3 07/17] net/mana: add function to configure RSS

2022-07-07 Thread longli
From: Long Li Currently this PMD supports RSS configuration when the device is stopped. Configuring RSS in running state will be supported in the future. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 61 +++

[Patch v3 06/17] net/mana: add device info

2022-07-07 Thread longli
From: Long Li Add the function to get device info. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 82 +++ 2 files changed, 83 insertions(+) diff --git a/doc/guides/nics/features/mana.ini b/doc/guides/nics/f

[Patch v3 05/17] net/mana: add function for device removal interrupts

2022-07-07 Thread longli
From: Long Li MANA supports PCI hot plug events. Add this interrupt to DPDK core so its parent PMD can detect device removal during Azure servicing or live migration. Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 97 +++

[Patch v3 04/17] net/mana: add link update

2022-07-07 Thread longli
From: Long Li The carrier state is managed by the Azure host. MANA runs as a VF and always reports "up". Signed-off-by: Long Li --- doc/guides/nics/features/mana.ini | 1 + drivers/net/mana/mana.c | 17 + 2 files changed, 18 insertions(+) diff --git a/doc/guides/nic

[Patch v3 03/17] net/mana: add function to report support ptypes

2022-07-07 Thread longli
From: Long Li Report supported protocol types. Signed-off-by: Long Li --- drivers/net/mana/mana.c | 16 drivers/net/mana/mana.h | 2 -- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index 1ea2cecd37..5deea1b0

[Patch v3 02/17] net/mana: add device configuration and stop

2022-07-07 Thread longli
From: Long Li MANA defines its memory allocation functions to override IB layer default functions to allocate device queues. This patch adds the code for device configuration and stop. Signed-off-by: Long Li --- Change log: v2: Removed validation for offload settings in mana_dev_configure().

[Patch v3 01/17] net/mana: add basic driver, build environment and doc

2022-07-07 Thread longli
From: Long Li MANA is a PCI device. It uses IB verbs to access hardware through the kernel RDMA layer. This patch introduces build environment and basic device probe functions. Signed-off-by: Long Li --- Change log: v2: Fix typos. Make the driver build only on x86-64 and Linux. Remove unused he

[Patch v3 00/17] Introduce Microsoft Azure Network Adatper (MANA) PMD

2022-07-07 Thread longli
From: Long Li MANA is a network interface card to be used in the Azure cloud environment. MANA provides safe access to user memory through memory registration. It has IOMMU built into the hardware. MANA uses IB verbs and RDMA layer to configure hardware resources. It requires the corresponding R

[RFC] rwlock: prevent readers from starving writers

2022-07-07 Thread Stephen Hemminger
The original reader/writer lock in DPDK can cause a stream of readers to starve writers. The new version uses an additional bit to indicate that a writer is waiting and which keeps readers from starving the writer. Signed-off-by: Stephen Hemminger --- Would like this to be in 22.11, but needs so

Re: [PATCH 1/2] common: add safe version of foreach-list to Linux

2022-07-07 Thread Thomas Monjalon
07/07/2022 17:59, Khan, Hamza: > > > -Original Message- > > From: Thomas Monjalon > > Sent: Tuesday 5 July 2022 17:16 > > To: Khan, Hamza > > Cc: dev@dpdk.org > > Subject: Re: [PATCH 1/2] common: add safe version of foreach-list to Linux > > > > 01/06/2022 12:54, Hamza Khan: > > > Linux

RE: [PATCH 1/2] common: add safe version of foreach-list to Linux

2022-07-07 Thread Khan, Hamza
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday 5 July 2022 17:16 > To: Khan, Hamza > Cc: dev@dpdk.org > Subject: Re: [PATCH 1/2] common: add safe version of foreach-list to Linux > > 01/06/2022 12:54, Hamza Khan: > > Linux EAL does not have the LIST_FOREACH_SAFE version

[PATCH v2] examples/vm_power_manager: use safe version of list iterator

2022-07-07 Thread Hamza Khan
Currently, when vm_power_manager exits, we are using a LIST_FOREACH macro to iterate over VM info structures while freeing them. This leads to use-after-free error. To address this, replace all usages of LIST_* with TAILQ_* macros, and use the RTE_TAILQ_FOREACH_SAFE macro to iterate and delete VM i

Port traffic shaping

2022-07-07 Thread Joshua Ani
I noticed that traffic shaping is implemented for the subport and pipe level, but not the port level. Why is this? When I tried implementing it, most of the work was just copying subport traffic shaping logic for the port, though I had to make some changes to fix a bandwidth issue with multiple por

[PATCH 2/2] net: have checksum routines accept unaligned data

2022-07-07 Thread Mattias Rönnblom
From: Mattias Rönnblom __rte_raw_cksum() (used by rte_raw_cksum() among others) accessed its data through an uint16_t pointer, which allowed the compiler to assume the data was 16-bit aligned. This in turn would, with certain architectures and compiler flag combinations, result in code with SIMD

[PATCH 1/2] app/test: add cksum performance test

2022-07-07 Thread Mattias Rönnblom
From: Mattias Rönnblom Add performance test for the rte_raw_cksum() function, which delegates the actual work to __rte_raw_cksum(), which in turn is used by other functions in need of Internet checksum calculation. Signed-off-by: Mattias Rönnblom --- MAINTAINERS| 1 + app/tes

RE: Service core statistics MT safety

2022-07-07 Thread Honnappa Nagarahalli
> > > > > In my mind, any LTS/backports get the simplest/highest-confidence > > > bugfix: using > > > > atomics. > > > > The atomics are behind the "service stats" feature enable, so > > > > impact > > > is only > > > > when those are enabled. > > > > > > > > If there is still a performance hit,

RE: [PATCH v4 4/7] drivers/baseband: update PMDs to expose queue per operation

2022-07-07 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > Sent: Thursday, July 7, 2022 6:21 AM > To: Chautru, Nicolas ; dev@dpdk.org; > tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com > Cc: maxime.coque...@redhat.com; m...@ashroe.eu; Richardson, Bruce > ; david.march...@redhat.com;

RE: [PATCH v4 2/7] bbdev: add device status info

2022-07-07 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > Sent: Thursday, July 7, 2022 6:37 AM > To: Chautru, Nicolas ; dev@dpdk.org; > tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com > Cc: maxime.coque...@redhat.com; m...@ashroe.eu; Richardson, Bruce > ; david.march...@redhat.com;

RE: [PATCH v4 3/7] bbdev: add device info on queue topology

2022-07-07 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > Sent: Thursday, July 7, 2022 6:34 AM > To: Chautru, Nicolas ; dev@dpdk.org; > tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com > Cc: maxime.coque...@redhat.com; m...@ashroe.eu; Richardson, Bruce > ; david.march...@redhat.com;

RE: [PATCH v4 5/7] bbdev: add new operation for FFT processing

2022-07-07 Thread Chautru, Nicolas
Hi Tom, > -Original Message- > From: Tom Rix > > Nic, > > Not all my comments were addressed. > > The one I am most interested in is the default type / size and how it > interacts > with fp16. My bad, I had replied to all that (and fixed some of them in the new version) but I must

RE: [PATCH v8] sched: enable CMAN at runtime

2022-07-07 Thread Singh, Jasvinder
> > > -#ifdef RTE_SCHED_CMAN > > > - set_subport_cman_params(subport_params+i, > > > cman_params); > > > -#endif > > > + subport_params[i].cman_params = &cman_params; > > > > Since cman_params_is global variable, memory is allocated regardless > > of whether cman

Re: [PATCH v3 4/4] doc/prog_guide: add reference to virtio-user from KNI doc

2022-07-07 Thread Maxime Coquelin
On 6/10/22 17:35, Bruce Richardson wrote: To help encourage use of virtio-user in place of KNI, put a reference to the relevant howto section at the top of the KNI doc. Signed-off-by: Bruce Richardson --- doc/guides/prog_guide/kernel_nic_interface.rst | 6 ++ 1 file changed, 6 inserti

Re: [PATCH v3 3/4] doc/howto: add code example to virtio-user exception path doc

2022-07-07 Thread Maxime Coquelin
On 6/10/22 17:35, Bruce Richardson wrote: The HOWTO guide for using virtio-user as an exception path to the kernel only provided an example of how testpmd may be used for that purpose. However, a real application wanting to use virtio-user as exception path would likely want to create such dev

Re: [PATCH v3 2/4] doc/howto: rename files to match new content name

2022-07-07 Thread Maxime Coquelin
On 6/10/22 17:35, Bruce Richardson wrote: Since the section in the "howto" has been renamed from "exceptional path" to "exception path", we can rename the relevant files to match this new name too. Signed-off-by: Bruce Richardson --- ...ptional_path.svg => virtio_user_as_exception_path.svg

Re: [PATCH v4] net: fix checksum with unaligned buffer

2022-07-07 Thread Stanisław Kardach
On Thu, Jun 30, 2022 at 6:32 PM Morten Brørup wrote: > > > From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > > Sent: Tuesday, 28 June 2022 08.28 > > > > On 2022-06-27 22:21, Morten Brørup wrote: > > >> From: Mattias Rönnblom [mailto:hof...@lysator.liu.se] > > >> Sent: Monday, 27 June 2022 1

Re: [PATCH] doc: add deprecation for restrictions in telemetry naming

2022-07-07 Thread Andrew Rybchenko
On 7/7/22 16:39, Bruce Richardson wrote: Following discussion on-list [1], we will look to limited the allowed characters in names for items in telemetry. This will simplify the escaping needed for json output, or any future output formats. The lists will initially be minimal, since expansion to

[PATCH v2] examples/link_status_interrupt: fix stats refresh rate

2022-07-07 Thread Omar Awaysa
From: Raja Zidane TIMER_MILLISECOND is defined as the number of cpu cycles per millisecond, current definition is correct for cores with frequency of 2GHZ, for cores with different frequency, it caused different periods between refresh, (i.e. the definition is about 14ms on ARM cores). Use dpdk

[PATCH] doc: update doc for NVIDIA devices

2022-07-07 Thread Raslan Darawsheh
This updates the doc to include new supported devices like ConnectX7, and updates the description of older ones. Signed-off-by: Raslan Darawsheh --- doc/guides/nics/mlx5.rst | 10 ++ doc/guides/platform/mlx5.rst | 4 +++- doc/guides/regexdevs/mlx5.rst | 2 +- doc/guides/vdpadevs/

Re: [RFC PATCH 00/29] cover letter for net/qdma PMD

2022-07-07 Thread Hemant Agrawal
On 7/7/2022 7:45 PM, Thomas Monjalon wrote: 07/07/2022 15:55, Aman Kumar: On 07/07/22 12:27 pm, Thomas Monjalon wrote: 06/07/2022 09:51, Aman Kumar: This patch series provides net PMD for VVDN's NR(5G) Hi-PHY solution over T1 telco card. These telco accelerator NIC cards are targeted for ORA

Re: [RFC PATCH 00/29] cover letter for net/qdma PMD

2022-07-07 Thread Thomas Monjalon
07/07/2022 15:55, Aman Kumar: > On 07/07/22 12:27 pm, Thomas Monjalon wrote: > > 06/07/2022 09:51, Aman Kumar: > >> This patch series provides net PMD for VVDN's NR(5G) Hi-PHY solution over > >> T1 telco card. These telco accelerator NIC cards are targeted for ORAN DU > >> systems to offload inline

Re: [RFC PATCH 00/29] cover letter for net/qdma PMD

2022-07-07 Thread Aman Kumar
On 07/07/22 12:27 pm, Thomas Monjalon wrote: 06/07/2022 09:51, Aman Kumar: This patch series provides net PMD for VVDN's NR(5G) Hi-PHY solution over T1 telco card. These telco accelerator NIC cards are targeted for ORAN DU systems to offload inline NR Hi-PHY (split 7.2) operations. For the DU ho

[PATCH] doc: add tested platforms with NVIDIA NICs

2022-07-07 Thread Raslan Darawsheh
Add tested platforms with NVIDIA NICs to the 22.07 release notes. Signed-off-by: Raslan Darawsheh --- doc/guides/rel_notes/release_22_07.rst | 153 + 1 file changed, 153 insertions(+) diff --git a/doc/guides/rel_notes/release_22_07.rst b/doc/guides/rel_notes/release_22_

RE: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api

2022-07-07 Thread Satha Koteswara Rao Kottidi
-Original Message- From: Andrew Rybchenko Sent: Thursday, July 7, 2022 6:23 PM To: Satha Koteswara Rao Kottidi ; Ray Kinsella Cc: dev@dpdk.org Subject: [EXT] Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api External Email ---

[PATCH] doc: add deprecation for restrictions in telemetry naming

2022-07-07 Thread Bruce Richardson
Following discussion on-list [1], we will look to limited the allowed characters in names for items in telemetry. This will simplify the escaping needed for json output, or any future output formats. The lists will initially be minimal, since expansion to allow more characters can be done without a

RE: release candidate 22.07-rc3

2022-07-07 Thread Wael Abualrub
Hi, > -Original Message- > From: Thomas Monjalon > Sent: Tuesday, July 5, 2022 11:36 PM > To: annou...@dpdk.org > Subject: release candidate 22.07-rc3 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v22.07-rc3 > > There are 82 new patches

Re: [PATCH v4 2/7] bbdev: add device status info

2022-07-07 Thread Tom Rix
On 7/6/22 2:16 PM, Chautru, Nicolas wrote: -Original Message- From: Tom Rix Subject: Re: [PATCH v4 2/7] bbdev: add device status info On 7/5/22 5:23 PM, Nicolas Chautru wrote: Added device status information, so that the PMD can expose information related to the underlying accelerat

Re: [PATCH v4 3/7] bbdev: add device info on queue topology

2022-07-07 Thread Tom Rix
On 7/6/22 2:12 PM, Chautru, Nicolas wrote: Hi Tom, -Original Message- From: Tom Rix Subject: Re: [PATCH v4 3/7] bbdev: add device info on queue topology On 7/5/22 5:23 PM, Nicolas Chautru wrote: Adding more options in the API to expose the number of queues exposed and related prio

Re: [PATCH v4 4/7] drivers/baseband: update PMDs to expose queue per operation

2022-07-07 Thread Tom Rix
On 7/6/22 2:10 PM, Chautru, Nicolas wrote: Hi Tom, -Original Message- From: Tom Rix Sent: Wednesday, July 6, 2022 9:15 AM To: Chautru, Nicolas ; dev@dpdk.org; tho...@monjalon.net; gak...@marvell.com; hemant.agra...@nxp.com Cc: maxime.coque...@redhat.com; m...@ashroe.eu; Richardson, B

[Bug 1049] Adding OpenSSL vdev also enables IPSEC tests

2022-07-07 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1049 Bug ID: 1049 Summary: Adding OpenSSL vdev also enables IPSEC tests Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

Re: [PATCH] app/testpmd: fix display types failure when query RSS rule

2022-07-07 Thread Ferruh Yigit
On 7/7/2022 1:42 PM, lihuisong (C) wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. 在 2022/7/7 20:22, Ferruh Yigit 写道: On 7/7/2022 11:50 AM, Huisong Li wrote: No

Re: [PATCH v4 5/7] bbdev: add new operation for FFT processing

2022-07-07 Thread Tom Rix
Nic, Not all my comments were addressed. The one I am most interested in is the default type / size and how it interacts with fp16. Please see the others below On 7/6/22 2:04 PM, Chautru, Nicolas wrote: Hi Tom, -Original Message- From: Tom Rix > On 7/5/22 5:23 PM, Nicolas Chautru

RE: [PATCH v8] sched: enable CMAN at runtime

2022-07-07 Thread Danilewicz, MarcinX
> > Signed-off-by: Marcin Danilewicz > > --- > > Log: v2 change in rte_sched.h to avoid ABI breakage. > > v3 changes from comments > > v4 rebase to 22.07-rc1 > > v5 rebase to main latest > > v6 commit message fixed > > v7 changes from comments > > v8 with changes fro

Re: [PATCH] doc: announce changes to rte_eth_set_queue_rate_limit api

2022-07-07 Thread Andrew Rybchenko
On 7/1/22 18:32, skotesh...@marvell.com wrote: From: Satha Rao rte_eth_set_queue_rate_limit argument rate modified to uint64_t to support more than 64Gbps. Signed-off-by: Satha Rao --- doc/guides/rel_notes/deprecation.rst | 5 + 1 file changed, 5 insertions(+) diff --git a/doc/guides/

Re: [PATCH v4 7/7] bbdev: add a lock option for enqueue/dequeue operation

2022-07-07 Thread Tom Rix
On 7/6/22 1:21 PM, Chautru, Nicolas wrote: Hi Stephen, Tom., -Original Message- From: Stephen Hemminger On Wed, 6 Jul 2022 12:01:19 -0700 Tom Rix wrote: On 7/5/22 5:23 PM, Nicolas Chautru wrote: Locking is not explicitly required but can be valuable in case the application canno

Re: [PATCH] app/testpmd: fix memory leak for dscp table

2022-07-07 Thread Andrew Rybchenko
On 7/6/22 17:32, Andrew Rybchenko wrote: In summary: dscp -> DSCP On 6/29/22 20:30, Singh, Aman Deep wrote: On 6/28/2022 6:59 PM, Jasvinder Singh wrote: This patch fixes memory leak reported by coverity. Coverity issue: 379220 Fixes: 9f5488e326d3 ("app/testpmd: support different input color

RE: [PATCH 1/2] doc: announce region based device mapping support

2022-07-07 Thread Xia, Chenbo
Hi Sunil, > -Original Message- > From: sk...@marvell.com > Sent: Tuesday, June 28, 2022 9:54 PM > To: Ray Kinsella > Cc: dev@dpdk.org; Sunil Kumar Kori > Subject: [PATCH 1/2] doc: announce region based device mapping support > > From: Sunil Kumar Kori > > Adding region based device m

Re: [PATCH] vdpa/sfc: resolve race between libvhost and dev_conf

2022-07-07 Thread Maxime Coquelin
On 7/6/22 11:24, abhimanyu.sa...@xilinx.com wrote: From: Abhimanyu Saini libvhost calls dev_conf() before prosessing the VHOST_USER_SET_VRING_CALL message for the last VQ. So this message is processed after dev_conf() returns. However, the dev_conf() function spawns a thread to set rte_vhos

Re: [PATCH v2] app/testpmd: fix GTP PSC raw processing

2022-07-07 Thread Andrew Rybchenko
On 7/6/22 19:11, Gregory Etelson wrote: Fix GTP PSP extension size initialization. Clear input buffer. Fixes: c65282c9aa31 ("app/testpmd: fix GTP PSC raw processing") Cc: sta...@dpdk.org Signed-off-by: Gregory Etelson Acked-by: Aman Singh Reviewed-by: Andrew Rybchenko Applied to dpdk-next-

RE: [PATCH v3] doc: add release notes for async vhost dequeue data-path

2022-07-07 Thread Xia, Chenbo
> -Original Message- > From: Jiang, Cheng1 > Sent: Tuesday, June 28, 2022 10:07 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; Ma, WenwuX ; Wang, YuanX > ; Yang, YvonneX ; Jiang, > Cheng1 > Subject: [PATCH v3] doc: add release notes for as

Re: [PATCH] app/testpmd: fix display types failure when query RSS rule

2022-07-07 Thread Ferruh Yigit
On 7/7/2022 11:50 AM, Huisong Li wrote: Now testpmd fails to display types when query RSS rule. The failure is because the '\n' character is missing at the end of the function 'rss_config_display()'. Bugzilla ID: 1048 Fixes: 534988c490f1 ("app/testpmd: unify RSS types display") Signed-off-b

Re: [PATCH] vhost: fix unnecessary dirty page logging

2022-07-07 Thread Maxime Coquelin
On 7/7/22 08:55, xuan.d...@intel.com wrote: From: Xuan Ding The dirty page logging is only required in vhost enqueue direction for live migration. This patch removes the unnecessary dirty page logging in vhost dequeue direction. Otherwise, it will result in a performance drop. Some if-else j

[PATCH] event/dsw: fix migration bug

2022-07-07 Thread Mattias Rönnblom
From: Mattias Rönnblom Fix bug in flow migration, which under certain conditions causes reordering and violation of atomicity guarantees. The issue occurs when the processing of a flow (on an atomic queue) has resulted in events enqueued to a flow currently being migrated, and the former (produc

[PATCH] config: set pkgconfig for ppc64le

2022-07-07 Thread Ali Alnubani
Meson fails to detect the dependencies that are included in PKG_CONFIG_PATH and built for ppc64le if binaries.pkgconfig is not set in the ppc64le cross-file for Ubuntu. This fixes the issue by setting binaries.pkgconfig to the binary provided by the package 'pkg-config-powerpc64le-linux-gnu'. Sig

Re: [PATCH] vhost: fix unnecessary dirty page logging

2022-07-07 Thread Maxime Coquelin
On 7/7/22 11:51, Xia, Chenbo wrote: -Original Message- From: Ding, Xuan Sent: Thursday, July 7, 2022 2:55 PM To: maxime.coque...@redhat.com; Xia, Chenbo Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang ; Yang, YvonneX ; Jiang, Cheng1 ; Ding, Xuan Subject: [PATCH] vhost: fix unnecessary d

Re: [PATCH] net/af_xdp: limit libbpf version to <= v0.7.0

2022-07-07 Thread Andrew Rybchenko
On 6/24/22 14:48, Andrew Rybchenko wrote: On 6/24/22 13:10, Thomas Monjalon wrote: 24/06/2022 10:37, Loftus, Ciara: 24/06/2022 08:06, Ciara Loftus: Linking with libbpf v0.8.0 causes deprication warnings. As a temporary measure, prevent linking with libbpf versions v0.8.0 and greater. This lim

RE: [PATCH 1/2] doc: announce region based device mapping support

2022-07-07 Thread Sunil Kumar Kori
Please look into following deprecation notice and ack if looks okay. > -Original Message- > From: sk...@marvell.com > Sent: Tuesday, June 28, 2022 7:24 PM > To: Ray Kinsella > Cc: dev@dpdk.org; Sunil Kumar Kori > Subject: [PATCH 1/2] doc: announce region based device mapping support >

RE: [PATCH] vhost: fix unnecessary dirty page logging

2022-07-07 Thread Xia, Chenbo
> -Original Message- > From: Ding, Xuan > Sent: Thursday, July 7, 2022 2:55 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; He, Xingguang > ; Yang, YvonneX ; Jiang, > Cheng1 ; Ding, Xuan > Subject: [PATCH] vhost: fix unnecessary dirty page logging > > Fr

RE: [Patch v2] net/mlx4: fix verbs fd leak in the secondary process

2022-07-07 Thread Slava Ovsiienko
> -Original Message- > From: lon...@linuxonhyperv.com > Sent: Wednesday, July 6, 2022 20:49 > To: Matan Azrad ; Ferruh Yigit > Cc: dev@dpdk.org; Karanjot Singh ; NBU- > Contact-longli (EXTERNAL) > Subject: [Patch v2] net/mlx4: fix verbs fd leak in the secondary process > > From: Long Li

RE: [Patch v2] net/mlx5: fix verbs fd leak in the secondary process

2022-07-07 Thread Slava Ovsiienko
> -Original Message- > From: lon...@linuxonhyperv.com > Sent: Wednesday, July 6, 2022 20:49 > To: Matan Azrad ; Ferruh Yigit > Cc: dev@dpdk.org; Karanjot Singh ; NBU- > Contact-longli (EXTERNAL) > Subject: [Patch v2] net/mlx5: fix verbs fd leak in the secondary process > > From: Long Li

RE: [PATCH] doc: announce some raw/ifpga API removal

2022-07-07 Thread Huang, Wei
> -Original Message- > From: David Marchand > Sent: Thursday, July 7, 2022 17:30 > To: Huang, Wei ; Zhang, Tianfei > ; Xu, Rosen > Cc: dev@dpdk.org; Ray Kinsella > Subject: Re: [PATCH] doc: announce some raw/ifpga API removal > > On Fri, Jul 1, 2022 at 10:35 AM David Marchand > wrote

Re: [PATCH] doc: announce some raw/ifpga API removal

2022-07-07 Thread David Marchand
On Fri, Jul 1, 2022 at 10:35 AM David Marchand wrote: > > > > > > Can't this application use rte_dev_remove and rte_dev_probe? > > > > > > If not, we should add the missing parts in the API. > > > > > > > > > > > Both rte_dev_remove and rte_dev_probe need rte_device pointer. In > > > > > this appl

[PATCH] lib: Check for the NULL pointer after calling malloc

2022-07-07 Thread 835703180
From: Shiqi Liu <835703...@qq.com> As the possible failure of the malloc(), the not_checked and checked could be NULL pointer. Therefore, it should be better to check it in order to avoid the dereference of the NULL pointer. Fixes: fa8054c8c88 ("lib/node: add ethdev control") Signed-off-by: Shiqi

Re: [PATCH v9 0/4] add an api to support proto based buffer split

2022-07-07 Thread Thomas Monjalon
21/06/2022 10:56, Ding, Xuan: > This protocol based buffer split patch series have been updated to v9. > Sincerely thank you for the effort you put into this series. > > Hope to know your considerations about this series now. > Do you think is it possible to get in 22.07? Or there are still some c

Re: [PATCH v9 2/4] ethdev: introduce protocol hdr based buffer split

2022-07-07 Thread Thomas Monjalon
13/06/2022 12:25, wenxuanx...@intel.com: > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -1176,6 +1176,9 @@ struct rte_eth_txmode { > * specified in the first array element, the second buffer, from the > * pool in the second element, and so on. > * > + * - The proto_h

RE: release candidate 22.07-rc3

2022-07-07 Thread Jiang, YuX
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, July 6, 2022 4:36 AM > To: annou...@dpdk.org > Subject: release candidate 22.07-rc3 > > A new DPDK release candidate is ready for testing: > https://git.dpdk.org/dpdk/tag/?id=v22.07-rc3 > > There are 82 new patches in th

[PATCH v4] net/i40e: restore disable double VLAN by default

2022-07-07 Thread Kevin Liu
Previously, QinQ is enabled by default and can't be disabled, but there'll be performance drop if QinQ is enabled. So, disable QinQ by default. Fixes: ae97b8b89826 ("net/i40e: fix error disable double VLAN") Signed-off-by: Kevin Liu --- v2: update doc and refine commit log --- v3: refine commit

  1   2   >