On 7/7/22 11:51, Xia, Chenbo wrote:
-----Original Message----- From: Ding, Xuan <xuan.d...@intel.com> Sent: Thursday, July 7, 2022 2:55 PM To: maxime.coque...@redhat.com; Xia, Chenbo <chenbo....@intel.com> Cc: dev@dpdk.org; Hu, Jiayu <jiayu...@intel.com>; He, Xingguang <xingguang...@intel.com>; Yang, YvonneX <yvonnex.y...@intel.com>; Jiang, Cheng1 <cheng1.ji...@intel.com>; Ding, Xuan <xuan.d...@intel.com> Subject: [PATCH] vhost: fix unnecessary dirty page logging From: Xuan Ding <xuan.d...@intel.com> The dirty page logging is only required in vhost enqueue direction for live migration. This patch removes the unnecessary dirty page logging in vhost dequeue direction. Otherwise, it will result in a performance drop. Some if-else judgements are also optimized to improve performance. Fixes: 6d823bb302c7 ("vhost: prepare sync for descriptor to mbuf refactoring") Fixes: b6eee3e83402 ("vhost: fix sync dequeue offload") Signed-off-by: Xuan Ding <xuan.d...@intel.com> ---Reviewed-by: Chenbo Xia <chenbo....@intel.com> Although it's late in release, we can consider to merge this as I see it impacts the performance by 5%: http://inbox.dpdk.org/dev/byapr11mb2711f13cda2b0a4535a6591efe...@byapr11mb2711.namprd11.prod.outlook.com/T/#t
Yes, I raised we need it in -rc4 at today's Release status meeting. I'll review it today.
But also, it will be good to know the performance issue is solved by sharing the test results.
Yes, Intel performance results would be appreciated.
Thanks, Chenbo
Thanks, Maxime
