06/07/2022 03:28, luzhipeng:
> My name: zhipeng Lu
OK I will change it to Zhipeng Lu (with capital letters).
Are you OK with this v3?
> >>> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> >>> I did some changes in this v3:
> >>> - PHYTIUM -> Phytium (as on the website)
> >>> - ft2000plus ->
From: Shiqi Liu <835703...@qq.com>
As the possible failure of the malloc(), the not_checked and
checked could be NULL pointer.
Therefore, it should be better to check it in order to avoid
the dereference of the NULL pointer.
Fixes: b7aaf417f93 ("raw/ioat: add bus driver for device scanning
autom
In function "skeleton_rawdev_enqueue_bugs", variable "context" is being
typecasted to (int*), and then assigned to a "uint16_t" type variable
"q_id". As the value is a "uint16_t", (int*) is replaced by (uint16_t*).
Signed-off-by: Usman Tanveer
---
drivers/raw/skeleton/skeleton_rawdev.c | 2 +-
1
From: Peng Zhang
The origin design is if error happen during the step 3 of given
situation, it will return error directly without retry. While
in current patch, it will retry at every interval time during
certain time if receive designed error code 'VIRTCHNL_STATUS_ERR_RETRY'
from kernel. If retr
Hi All,
In multithreaded/Multicore environment can we use
RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF
independently,
or this flag should always be used with
RTE_HASH_EXTRA_FLAGS_MULTI_WRITER_ADD.
We are trying to create and access the hash table with
RTE_HASH_EXTRA_FLAGS_RW_CONCURRENCY_LF
only.
We ar
From: Wenxuan Wu
Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can
not handle gtp_psc properly, we introduce a new structure to fix this
gap between kernel driver and struct rte_gtp_psc_generic_hdr.
Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
Cc: simei
From: Wenxuan Wu
Due to the change of struct rte_gtp_psc_generic_hdr, kernel driver can
not handle gtp_psc properly, we introduce a new structure to fix this
gap between kernel driver and struct rte_gtp_psc_generic_hdr.
Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
Cc: simei
My name: zhipeng Lu
Thanks.
在 2022/7/5 22:31, Morten Brørup 写道:
From: Morten Brørup
Sent: Tuesday, 5 July 2022 16.25
From: Thomas Monjalon [mailto:tho...@monjalon.net]
Sent: Tuesday, 5 July 2022 15.31
From: luzhipeng
Here adds configs for Phytium server.
Signed-off-by: luzhipeng
Reviewed
Extension of bbdev operation to support FFT based operations.
Signed-off-by: Nicolas Chautru
Acked-by: Hemant Agrawal
---
doc/guides/prog_guide/bbdev.rst | 130 +++
lib/bbdev/rte_bbdev.c | 11 ++-
lib/bbdev/rte_bbdev.h | 76 +
Add support in existing bbdev PMDs for the explicit number of queue
and priority for each operation type configured on the device.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc100/rte_acc100_pmd.c | 29 +-
drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
Adding more options in the API to expose the number
of queues exposed and related priority.
Signed-off-by: Nicolas Chautru
---
lib/bbdev/rte_bbdev.h | 4
1 file changed, 4 insertions(+)
diff --git a/lib/bbdev/rte_bbdev.h b/lib/bbdev/rte_bbdev.h
index 9b1ffa4..ac941d6 100644
--- a/lib/bbdev
Added device status information, so that the PMD can
expose information related to the underlying accelerator device status.
Minor order change in structure to fit into padding hole.
Signed-off-by: Nicolas Chautru
---
drivers/baseband/acc100/rte_acc100_pmd.c | 1 +
drivers/baseband/fp
This allows to expose more information with regards to any
queue related failure and warning which cannot be supported
in existing API.
Signed-off-by: Nicolas Chautru
---
app/test-bbdev/test_bbdev_perf.c | 2 ++
lib/bbdev/rte_bbdev.c| 21 +
lib/bbdev/rte_bbdev.h
Updating the enum for rte_bbdev_op_type
to allow to keep ABI compatible for enum insertion
while adding padded maximum value for array need.
Removing RTE_BBDEV_OP_TYPE_COUNT and instead exposing
RTE_BBDEV_OP_TYPE_PADDED_MAX.
Signed-off-by: Nicolas Chautru
---
app/test-bbdev/test_bbdev.c | 2
Locking is not explicitly required but can be valuable
in case the application cannot guarantee to be thread-safe,
or specifically is at risk of using the same queue from multiple threads.
This is an option for PMD to use this.
Signed-off-by: Nicolas Chautru
---
lib/bbdev/rte_bbdev.h | 2 ++
1 f
v4: update to the last 2 commits to include function to print the queue status
and a fix to the rte_lock within the wrong structure
v3: update to device status info to also use padded size for the related array.
Adding also 2 additionals commits to allow the API struc to expose more
information r
From: Long Li
Report packet statistics.
Signed-off-by: Long Li
---
doc/guides/nics/features/mana.ini | 2 +
drivers/net/mana/mana.c | 77 +++
2 files changed, 79 insertions(+)
diff --git a/doc/guides/nics/features/mana.ini
b/doc/guides/nics/features/man
From: Long Li
Add support for starting/stopping the device.
Signed-off-by: Long Li
---
Change log:
v2:
Use spinlock for memory registration cache.
Add mana_ to some function names.
drivers/net/mana/mana.c | 70 +
1 file changed, 70 insertions(+)
diff -
From: Long Li
With all the TX queues created, MANA can send packets over those queues.
Signed-off-by: Long Li
---
Change log:
v2:
Rename several camel cases.
doc/guides/nics/features/mana.ini | 1 +
drivers/net/mana/mana.c | 1 +
drivers/net/mana/mana.h | 65
From: Long Li
With all the RX queues created, MANA can use those queues to receive packets.
Signed-off-by: Long Li
---
Change log:
v2:
Add mana_ to some function names.
Rename a camel case.
doc/guides/nics/features/mana.ini | 2 +
drivers/net/mana/mana.c | 2 +
drivers/net/mana/
From: Long Li
MANA allocates device queues through the IB layer when starting RX queues.
When device is stopped all the queues are unmapped and freed.
Signed-off-by: Long Li
---
Change log:
v2:
Add prefix mana_ to some function names.
Remove unused header files.
drivers/net/mana/mana.h |
From: Long Li
MANA allocate device queues through the IB layer when starting TX queues.
When device is stopped all the queues are unmapped and freed.
Signed-off-by: Long Li
---
Change log:
v2:
Add prefix mana_ to some function names.
Remove unused header files.
doc/guides/nics/features/mana.
From: Long Li
The hardware layer of MANA understands the device queue and doorbell
formats. Those functions are implemented for use by packet RX/TX code.
Signed-off-by: Long Li
---
Change log:
v2:
Remove unused header files.
Rename a camel case.
drivers/net/mana/gdma.c | 284 ++
From: Long Li
MANA hardware has iommu built-in, that provides hardware safe access to
user memory through memory registration. Since memory registration is an
expensive operation, this patch implements a two level memory registration
cache mechanisum for each queue and for each port.
Signed-off-
From: Long Li
TX hardware queue is allocated when starting the queue, this is for
pre configuration.
Signed-off-by: Long Li
---
drivers/net/mana/mana.c | 65 +
1 file changed, 65 insertions(+)
diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana
From: Long Li
RX hardware queue is allocated when starting the queue. This function is
for queue configuration pre starting.
Signed-off-by: Long Li
---
drivers/net/mana/mana.c | 68 +
1 file changed, 68 insertions(+)
diff --git a/drivers/net/mana/mana.c
From: Long Li
Currently this PMD supports RSS configuration when the device is stopped.
Configuring RSS in running state will be supported in the future.
Signed-off-by: Long Li
---
doc/guides/nics/features/mana.ini | 1 +
drivers/net/mana/mana.c | 61 +++
From: Long Li
Add the function to get device info.
Signed-off-by: Long Li
---
doc/guides/nics/features/mana.ini | 1 +
drivers/net/mana/mana.c | 82 +++
2 files changed, 83 insertions(+)
diff --git a/doc/guides/nics/features/mana.ini
b/doc/guides/nics/f
From: Long Li
MANA supports PCI hot plug events. Add this interrupt to DPDK core so its
parent PMD can detect device removal during Azure servicing or live
migration.
Signed-off-by: Long Li
---
doc/guides/nics/features/mana.ini | 1 +
drivers/net/mana/mana.c | 97 +++
From: Long Li
The carrier state is managed by the Azure host. MANA runs as a VF and
always reports "up".
Signed-off-by: Long Li
---
doc/guides/nics/features/mana.ini | 1 +
drivers/net/mana/mana.c | 17 +
2 files changed, 18 insertions(+)
diff --git a/doc/guides/nic
From: Long Li
Report supported protocol types.
Signed-off-by: Long Li
---
drivers/net/mana/mana.c | 16
drivers/net/mana/mana.h | 2 --
2 files changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c
index 1ea2cecd37..5deea1b0
From: Long Li
MANA defines its memory allocation functions to override IB layer default
functions to allocate device queues. This patch adds the code for device
configuration and stop.
Signed-off-by: Long Li
---
Change log:
v2:
Removed validation for offload settings in mana_dev_configure().
From: Long Li
MANA is a PCI device. It uses IB verbs to access hardware through the kernel
RDMA layer. This patch introduces build environment and basic device probe
functions.
Signed-off-by: Long Li
---
Change log:
v2:
Fix typos.
Make the driver build only on x86-64 and Linux.
Remove unused h
From: Long Li
MANA is a network interface card to be used in the Azure cloud environment.
MANA provides safe access to user memory through memory registration. It has
IOMMU built into the hardware.
MANA uses IB verbs and RDMA layer to configure hardware resources. It
requires the corresponding R
> Here only mode is set to RTE_SCHED_CMAN_RED. But I could not find the
> place where cman_params are set from cfg_file (for e.g. red_params). Can
> you clarify?
Look beyond that particular change. All this is joined work. I am adding final
touch to what I've started, he continued and now we all
The DPDK is not designed to be used from a signal handler.
Add a notice in the documentation describing this limitation,
similar to Linux signal-safety manual page.
Bugzilla ID: 1030
Signed-off-by: Stephen Hemminger
Acked-by: Tyler Retzlaff
Acked-by: Chengwen Feng
---
doc/guides/prog_guide/env
A new DPDK release candidate is ready for testing:
https://git.dpdk.org/dpdk/tag/?id=v22.07-rc3
There are 82 new patches in this snapshot.
Release notes:
https://doc.dpdk.org/guides/rel_notes/release_22_07.html
Please test and report issues on bugs.dpdk.org.
You may share some re
05/07/2022 10:09, Raslan Darawsheh:
> When allocating multi segmented buffers, and in case there is
> a remainder in total buf len, the actual job len might be more
> than expected job_len.
>
> This adds additional space in the mbuf in the multi seg case,
> to allow the remaining memory to be stor
24/05/2021 10:57, Thierry Herbelot:
> Check that nb_jobs is not zero before using it for a division.
>
> Fixes: f5cffb7eb7fb6 ("app/regex: read data file once at startup")
> Cc: sta...@dpdk.org
> Cc: Ori Kam
>
> Signed-off-by: Thierry Herbelot
Missing ack, but applied after a long wait, sorry.
> > Add PPD (PCIe Port Definition) status check for SPR (Sapphire Rapids).
> >
> > Note that NTB on SPR has the same device id with that on ICX, while
> > the field offsets of PPD Control Register are different. Here, we use
> > the PCI device revision id to distinguish the HW platform (ICX/SPR)
>
> Subject: Re: [PATCH 01/17] net/mana: add basic driver, build environment and
> doc
>
> On Sun, 3 Jul 2022 07:56:18 +
> Long Li wrote:
>
> > > Subject: Re: [PATCH 01/17] net/mana: add basic driver, build
> > > environment and doc
> > >
> > > On Fri, 1 Jul 2022 02:02:31 -0700
> > > lon...@l
27/06/2022 19:52, 835703...@qq.com:
> From: Shiqi Liu <835703...@qq.com>
>
> As the possible failure of the malloc(), the not_checked and
> checked could be NULL pointer.
> Therefore, it should be better to check it in order to avoid
> the dereference of the NULL pointer.
>
> Fixes: b7aaf417f93 (
04/07/2022 17:27, Kevin Laatz:
> This patchset addresses the device close for IDXD PCI devices.
> Initially, there was a memory leak reported by ASAN for the 'pci' member
> of the 'idxd_dmadev' struct due to a missing free. In addition, this
> patch set corrects the behaviour of the device close fu
05/07/2022 15:44, Spike Du:
> Replace vdpa interrupt handle creation logic with common interrupt
> management API.
>
> Signed-off-by: Spike Du
Applied, thanks.
>
> Added changes to enable CMAN (RED or PIE) at init from profile configuration
> file.
>
> By default CMAN code is enable but not in use, when there is no RED or PIE
> profile configured.
>
> Signed-off-by: Marcin Danilewicz
> ---
> Log: v2 change in rte_sched.h to avoid ABI breakage.
>
> -Original Message-
> From: Morten Brørup
> Sent: Friday, July 1, 2022 9:52 PM
> To: Honnappa Nagarahalli ; Van Haaren, Harry
> ; Mattias Rönnblom ;
> mattias.ronnblom ; dev@dpdk.org
> Cc: nd ; nd ; nd
> Subject: RE: Service core statistics MT safety
>
> > From: Honnappa Nagarahalli [ma
Added changes to enable CMAN (RED or PIE) at init
from profile configuration file.
By default CMAN code is enable but not in use, when
there is no RED or PIE profile configured.
Signed-off-by: Marcin Danilewicz
---
Log: v2 change in rte_sched.h to avoid ABI breakage.
v3 changes from comment
01/07/2022 13:54, Tomasz Duszynski:
> Since firmware has added support for toggling PTP mode on 10k platforms
> userspace code should allow doing that as well.
>
> Cc: sta...@dpdk.org
>
> Signed-off-by: Tomasz Duszynski
> Reviewed-by: Jerin Jacob Kollanukkaran
Applied, thanks.
> EVP_PKEY function need to be called twice for rsa sign and verify
> operations in 3.0 EVP API, original openssl 1.x routines are
> untouched. The OPENSSL_API_COMPAT also removed as this branch code
> will be executed when Openssl 3.0 lib is detected on the host.
>
> Fixes: d7bd42f6db19 ("crypto/
> --
> From: Rebecca Troy
>
> Currently when running the dpdk-perf-test with docsis
> security sessions, a segmentation fault occurs. This
> is due to the check being made that the session is not
> equal to op->sym->sec_session.
> > From: Kumara Parameshwaran
> >
> > A packet with RTE_PTYPE_L4_FRAG(0x300) contains both RTE_PTYPE_L4_TCP
> > (0x100) & RTE_PTYPE_L4_UDP (0x200). A fragmented packet as defined in
> > rte_mbuf_ptype.h cannot be recognized as other L4 types and hence the
> > GRO layer should not use IS_IPV4_TCP
01/06/2022 12:54, Hamza Khan:
> Linux EAL does not have the LIST_FOREACH_SAFE version of the
> iterator macros. Add it.
>
> Signed-off-by: Hamza Khan
> ---
> lib/eal/linux/include/rte_os.h | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/lib/eal/linux/include/rte_os.h b/lib/eal/l
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, July 4, 2022 8:18 PM
> To: Rahul Bhansali
> Cc: dev@dpdk.org; David Christensen ; Ruifeng Wang
> ; Bruce Richardson ;
> Konstantin Ananyev ; Jerin Jacob
> Kollanukkaran ; Akhil Goyal
> Subject: [EXT] Re: [PATCH v3 1/2] examp
On Wed, Jun 08, 2022 at 05:34:30PM -0700, Nicolas Chautru wrote:
> Intent to resolve in DPDK 22.11 historical usage which prevents
> graceful extension of enum and API without troublesome ABI breakage
> as well as extending API RTE_BBDEV_OP_FFT for new operation type
> in bbdev as well as other new
Current PMD logs all DevX errors at RTE_LOG_ERR level.
DevX interface can fail queue counters allocation on some hardware
types. That is a known issue.
PMD fallback to VERB API to allocate queue counters
when it detects the fault.
That DevX failure should not be logged as PMD error.
The patch pro
> From: Morten Brørup
> Sent: Tuesday, 5 July 2022 16.25
>
> > From: Thomas Monjalon [mailto:tho...@monjalon.net]
> > Sent: Tuesday, 5 July 2022 15.31
> >
> > From: luzhipeng
> >
> > Here adds configs for Phytium server.
> >
> > Signed-off-by: luzhipeng
> > Reviewed-by: Thomas Monjalon
> > ---
05/07/2022 15:32, Harry van Haaren:
> This commit fixes an issue where calling rte_service_lcore_stop()
> would result in a service's "active on lcore" status becoming stale.
>
> The stale status would result in rte_service_may_be_active() always
> returning "1", indiciating that the service is no
> From: Thomas Monjalon [mailto:tho...@monjalon.net]
> Sent: Tuesday, 5 July 2022 15.31
>
> From: luzhipeng
>
> Here adds configs for Phytium server.
>
> Signed-off-by: luzhipeng
> Reviewed-by: Thomas Monjalon
> ---
> I did some changes in this v3:
> - PHYTIUM -> Phytium (as on the website)
>
05/07/2022 15:50, Ruifeng Wang:
> From: Thomas Monjalon
> > @@ -214,7 +228,7 @@ implementer_qualcomm = {
> > '0xc00': {
> > 'march': 'armv8-a',
> > 'march_features': ['crc']
> > -}
> > +},
>
> Unintentional change?
> The change is valid, but not
> -Original Message-
> From: Thomas Monjalon
> Sent: Tuesday, July 5, 2022 9:31 PM
> To: dev@dpdk.org
> Cc: luzhipeng ; Ruifeng Wang
> ; Jan Viktorin ; Bruce
> Richardson
> Subject: [PATCH v3] config/arm: add Phytium FT-2000+
>
> From: luzhipeng
>
> Here adds configs for Phytium server
Replace vdpa interrupt handle creation logic with common interrupt
management API.
Signed-off-by: Spike Du
---
drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 25 -
1 file changed, 4 insertions(+), 21 deletions(-)
diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c
b/drivers/vdpa/ml
> From: Konstantin Ananyev [mailto:konstantin.v.anan...@yandex.ru]
> Sent: Tuesday, 5 July 2022 10.55
>
> 04/07/2022 12:35, Morten Brørup пишет:
> > Does anyone here remember why the
> __rte_ring_enqueue/dequeue_elems_64/128() functions support unaligned
> object arrays, when the __rte_ring_enqueu
This commit fixes an issue where calling rte_service_lcore_stop()
would result in a service's "active on lcore" status becoming stale.
The stale status would result in rte_service_may_be_active() always
returning "1", indiciating that the service is not certainly stopped.
This is fixed by ensurin
From: luzhipeng
Here adds configs for Phytium server.
Signed-off-by: luzhipeng
Reviewed-by: Thomas Monjalon
---
I did some changes in this v3:
- PHYTIUM -> Phytium (as on the website)
- ft2000plus -> FT-2000+ (as found online)
- alphabetical ordering
- extra commas for future extensions
- g++
From: Rebecca Troy
Currently when running the dpdk-perf-test with docsis
security sessions, a segmentation fault occurs. This
is due to the check being made that the session is not
equal to op->sym->sec_session. This check passes the
first time but on the second iteration fails and doesn't
create
EVP_PKEY function need to be called twice for rsa sign and verify
operations in 3.0 EVP API, original openssl 1.x routines are
untouched. The OPENSSL_API_COMPAT also removed as this branch code
will be executed when Openssl 3.0 lib is detected on the host.
Fixes: d7bd42f6db19 ("crypto/openssl: upd
> -Original Message-
> From: wenxuanx...@intel.com
> Sent: Tuesday, July 5, 2022 6:10 PM
> To: Wu, Jingjing ; Xing, Beilei
> ;
> dev@dpdk.org
> Cc: Yang, Qiming ; Zhou, YidingX
> ; Wu, WenxuanX ; Su,
> Simei ; sta...@dpdk.com
> Subject: [PATCH] net/iavf: fix gtpu extension flow error
>
05/07/2022 12:43, Ji, Kai:
> From: Thomas Monjalon
> > 30/06/2022 12:38, Kai Ji:
> > > EVP_PKEY function need to be called twice for rsa sign and verify
> > > operations. This patch also remove the OPENSSL_API_COMPAT as all the
> > > deprecated APIs are avoid if 3.0 lib is present.
> >
> > I pref
04/07/2022 09:42, David Marchand:
> On Mon, Jul 4, 2022 at 9:11 AM Yuan Wang wrote:
> >
> > The callfds[] array stores eventfds sequentially for Rx and Tx vq.
> >
> > Fixes: d61138d4f0e2 ("drivers: remove direct access to interrupt handle")
> > Cc: sta...@dpdk.org
> >
> > Signed-off-by: Yuan Wang
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon
> Sent: Monday, July 4, 2022 8:45 PM
> To: Ji, Kai
> Cc: dev@dpdk.org; gak...@marvell.com
> Subject: Re: [dpdk-dev v1] crypto/openssl: EVP_PKEY routine update in rsa
> op
>
> 30/06/2022 12:38, Kai Ji:
> > EVP_PKEY function need to
On Tue, Jun 28, 2022 at 01:52:26AM +0800, 835703...@qq.com wrote:
> From: Shiqi Liu <835703...@qq.com>
>
> As the possible failure of the malloc(), the not_checked and
> checked could be NULL pointer.
> Therefore, it should be better to check it in order to avoid
> the dereference of the NULL poin
From: Wenxuan Wu
Due to the change of struct rte_gtp_psc_generic_hdr, firmware can
not handle gtp_psc properly, we induce a new structure to fix this
gap between firmware and struct rte_gtp_psc_generic_hdr.
Fixes: d5eb3e600d9e ("net/iavf: support flow director basic rule")
Cc: simei...@intel.com
Hi Song,
Currently this patch is just fix the issue detected for rx queue on secondary
process.
Later patch for tx queue will be submit.
@Andrew, what's your opinion about the solution of this patch?
Thanks,
Peng
> -Original Message-
> From: lihuisong (C)
> Sent: Monday, July 4, 2022 1
04/07/2022 12:35, Morten Brørup пишет:
Does anyone here remember why the __rte_ring_enqueue/dequeue_elems_64/128()
functions support unaligned object arrays, when the
__rte_ring_enqueue/dequeue_elems_32() functions require 4 byte aligned object
arrays?
As I remember, we added 'unaligned' to
When allocating multi segmented buffers, and in case there is
a remainder in total buf len, the actual job len might be more
than expected job_len.
This adds additional space in the mbuf in the multi seg case,
to allow the remaining memory to be stored in one segment.
Fixes: c1d1b94eec58 ("app/re
75 matches
Mail list logo