Re: [PATCH v2] app/testpmd: fix quit testpmd with vfs and pf

2022-06-22 Thread Thomas Monjalon
Adding more about this patch: testpmd is a test application. It allows you to find some issues in some scenarios. It seems you found an issue and you decided to hide it in the test application. That's really wrong! This kind of issue should be solved in the API or in the driver. In this case, I b

Re: [PATCH v2] vhost: fix avail idx update error when desc copy failed

2022-06-22 Thread Gaoxiang Liu
Hi, Chenbo Yes. It is the latest patch. Replied Message | From | Xia, Chenbo | | Date | 06/23/2022 11:07 | | To | Gaoxiang Liu, maxime.coque...@redhat.com | | Cc | dev@dpdk.org, liugaoxi...@huawei.com, sta...@dpdk.org | | Subject | RE: [PATCH v2] vhost: fix avail idx update error when

RE: [PATCH] raw/ifpga: avoid potential integer overflow

2022-06-22 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Thursday, June 23, 2022 11:12 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH] raw/ifpga: avoid po

RE: [PATCH] raw/ifpga/base: check pointer before dereference

2022-06-22 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Thursday, June 23, 2022 11:12 > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH] raw/ifpga/base: che

[PATCH v9 7/7] doc/eth_tx: update instance get API

2022-06-22 Thread Ganapati Kundapura
Added rte_event_eth_tx_adapter_instance_get() details. Signed-off-by: Ganapati Kundapura --- doc/guides/prog_guide/event_ethernet_tx_adapter.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst b/doc/guides/prog_guide/event_ethernet_t

[PATCH v9 6/7] doc/eth_rx: update instance get API

2022-06-22 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() details Signed-off-by: Ganapati Kundapura --- doc/guides/prog_guide/event_ethernet_rx_adapter.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx

[PATCH v9 5/7] test/eth_tx: add testcase for instance get API

2022-06-22 Thread Ganapati Kundapura
Added testcase for rte_event_eth_tx_adapter_instance_get() Signed-off-by: Ganapati Kundapura --- app/test/test_event_eth_tx_adapter.c | 75 1 file changed, 75 insertions(+) diff --git a/app/test/test_event_eth_tx_adapter.c b/app/test/test_event_eth_tx_adapt

[PATCH v9 4/7] eventdev/eth_tx: add instance get API

2022-06-22 Thread Ganapati Kundapura
Added rte_event_eth_tx_adapter_instance_get() to get the adapter instance id for specified ethernet device id and tx queue index. Signed-off-by: Ganapati Kundapura --- lib/eventdev/eventdev_pmd.h | 23 +++ lib/eventdev/rte_event_eth_tx_adapter.c | 102 +++

[PATCH v9 3/7] test/eth_rx: add test case for instance get API

2022-06-22 Thread Ganapati Kundapura
Added test case for rte_event_eth_rx_adapter_instance_get() Signed-off-by: Ganapati Kundapura --- app/test/test_event_eth_rx_adapter.c | 203 ++- 1 file changed, 202 insertions(+), 1 deletion(-) diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_e

[PATCH v9 2/7] eventdev/eth_rx: add telemetry callback for instance get

2022-06-22 Thread Ganapati Kundapura
Added telemetry handler for rte_event_eth_rx_adapter_instance_get() to retrieve adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura --- lib/eventdev/rte_event_eth_rx_adapter.c | 66 + 1 file changed, 66 insert

[PATCH v9 1/7] eventdev/eth_rx: add adapter instance get API

2022-06-22 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() to get adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura Reviewed-by: Naga Harish K S V Acked-by: Jay Jayatheerthan --- v9: * Corrected rte_event_eth_tx_adapter_instanceget to * rte_event_eth

RE: [PATCH v2] app/test: add additional stream cipher tests

2022-06-22 Thread Tejasree Kondoj
Hi Ciara, Thanks for pointing it out. Will rework test vectors and submit new version. Thanks Tejasree > -Original Message- > From: Power, Ciara > Sent: Tuesday, June 21, 2022 7:58 PM > To: Akhil Goyal ; Tejasree Kondoj > ; Zhang, Roy Fan > Cc: Anoob Joseph ; Ankur Dwivedi > ; dev@dpdk

RE: [PATCH] raw/ifpga: avoid potential integer overflow

2022-06-22 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Thursday, June 23, 2022 11:12 AM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH] raw/ifpga: avoid p

RE: [PATCH] raw/ifpga/base: check pointer before dereference

2022-06-22 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Thursday, June 23, 2022 11:12 AM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH] raw/ifpga/base: ch

Re: [PATCH 0/2] remove unnecessary words in function documention

2022-06-22 Thread Tyler Retzlaff
On Wed, Jun 22, 2022 at 01:54:46PM -0700, Stephen Hemminger wrote: > On Wed, 22 Jun 2022 13:37:12 -0700 > Tyler Retzlaff wrote: > > > On Wed, Jun 22, 2022 at 01:27:36PM -0700, Stephen Hemminger wrote: > > > The phrase "This API is used to" is unnecessary and changes the > > > documentation into p

RE: [PATCH v2] net/igc: fix segmentation fault in secondary dpdk-symmetric_mp

2022-06-22 Thread Zhang, Qi Z
> -Original Message- > From: zhichaox.z...@intel.com > Sent: Wednesday, June 22, 2022 6:49 PM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Yang, Qiming ; Zeng, ZhichaoX > ; alvinx.zh...@intel.com; Guo, Junfeng > ; Su, Simei ; Ferruh Yigit > > Subject: [PATCH v2] net/igc: fix segmentation

[dpdk-dev] [PATCH] common/cnxk: fix GRE tunnel parsing issue

2022-06-22 Thread psatheesh
From: Satheesh Paul After parsing GRE tunnel, parse subsequent protocols (for example, TCP or UDP) as tunneled versions. Fixes: c34ea71b878 ("common/cnxk: add NPC parsing API") Cc: sta...@dpdk.org Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar K --- drivers/common/cnxk/roc_npc_parse.c

RE: [PATCH v2 0/7] Fixes and supports for Wangxun NICs

2022-06-22 Thread Jiawen Wu
On Wednesday, June 22, 2022 6:56 PM, Ferruh Yigit wrote: > On 6/22/2022 7:56 AM, Jiawen Wu wrote: > > Fix the remaining bugs, support more OEM devices. > > > > v2: > > - remove useless variable initializers > > - define macros for loop counts > > - supplement detailed commit log > > > > Jiawen Wu (

RE: [PATCH v3] doc: clean vhost async path doc

2022-06-22 Thread Xia, Chenbo
> -Original Message- > From: Ding, Xuan > Sent: Wednesday, June 22, 2022 9:46 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > Subject: [PATCH v3] doc: clean vhost async path doc > > From: Xuan Ding > > This patch moves the 'Recommended I

RE: [PATCH v2] doc: update async enqueue API usage

2022-06-22 Thread Xia, Chenbo
> -Original Message- > From: Ding, Xuan > Sent: Tuesday, June 21, 2022 3:22 PM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > > Subject: [PATCH v2] doc: update async enqueue API usage > > From: Xuan Ding > > This patch updates the correct us

RE: [PATCH v2] vhost: fix avail idx update error when desc copy failed

2022-06-22 Thread Xia, Chenbo
Hi Gaoxiang, > -Original Message- > From: Gaoxiang Liu > Sent: Wednesday, June 22, 2022 9:20 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; liugaoxi...@huawei.com; Gaoxiang Liu > ; sta...@dpdk.org > Subject: [PATCH v2] vhost: fix avail idx update error when desc cop

[PATCH] raw/ifpga: avoid potential integer overflow

2022-06-22 Thread Wei Huang
Expression "tx_chunks * ctx->dma_buf_size" in dma_fpga_to_fpga() is evaluated using 32-bit arithmetic, which would overflow potentially. Change tx_chunks to type "uint64_t" to avoid such issue. Coverity issue: 379203 Fixes: 7d63899a5c19 ("raw/ifpga: add N3000 AFU driver") Signed-off-by: Wei Huan

[PATCH] raw/ifpga/base: check pointer before dereference

2022-06-22 Thread Wei Huang
Do null-checking on hw->adapter in fme_pmci_init() before dereference it. Coverity issue: 379202 Fixes: ca6eb0f7c836 ("raw/ifpga/base: add PMCI base driver") Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_fme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

RE: Fw:[PATCH v2] vhost: fix avail idx update error when desc copy failed

2022-06-22 Thread Xia, Chenbo
Hi Gaoxiang, > From: Gaoxiang Liu > Sent: Wednesday, June 22, 2022 10:30 PM > To: Xia, Chenbo ; maxime.coque...@redhat.com > Cc: dev@dpdk.org > Subject: Fw:[PATCH v2] vhost: fix avail idx update error when desc copy failed > > > Hi, Chen bo, Maxime, >      Please help to review the patch below

RE: [PATCH v4] examples/vhost: fix retry logic on eth rx path

2022-06-22 Thread Xia, Chenbo
> -Original Message- > From: Wang, YuanX > Sent: Wednesday, June 22, 2022 5:26 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; He, Xingguang ; > Jiang, Cheng1 ; Wang, YuanX ; > sta...@dpdk.org; Ling, WeiX > Subject: [PATCH v4] examples/vhost: fix retry

RE: [PATCH] vhost: fix unchecked return value

2022-06-22 Thread Xia, Chenbo
Hi Jiayu, > -Original Message- > From: Hu, Jiayu > Sent: Thursday, June 23, 2022 9:09 AM > To: dev@dpdk.org > Cc: maxime.coque...@redhat.com; Xia, Chenbo ; Hu, > Jiayu > Subject: [PATCH] vhost: fix unchecked return value > > This patch checks the return value of rte_dma_info_get() > cal

Re: [PATCH] ip_frag: replace the rte memcpy with memcpy

2022-06-22 Thread Stephen Hemminger
On Wed, 22 Jun 2022 23:49:39 +0100 Konstantin Ananyev wrote: > > @@ -26,7 +25,7 @@ static inline void __fill_ipv4hdr_frag(struct > > rte_ipv4_hdr *dst, > > const struct rte_ipv4_hdr *src, uint16_t header_len, > > uint16_t len, uint16_t fofs, uint16_t dofs, uint32_t mf) >

[PATCH v4 13/13] net/nfp: modify RSS logic

2022-06-22 Thread Jin Liu
Now NFP NIC support two type of RSS logic, NFP_NET_CFG_CTRL_RSS and NFP_NET_CFG_CTRL_RSS2, use NFP_NET_CFG_CTRL_RSS2 if NIC capability support, otherwise use NFP_NET_CFG_CTRL_RSS. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-b

[PATCH v4 12/13] net/nfp: nfdk packet xmit function

2022-06-22 Thread Jin Liu
Implement NFP3800 card packet transmit function for firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 3 +- drivers/net/nfp/nfp_ethdev_vf.c | 3 +-

[PATCH v4 11/13] net/nfp: move macro from C file to head file

2022-06-22 Thread Jin Liu
Move macro __round_mask, round_up and round_down from C file to corresponding head file, will be used by TX function of nfp net firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- driver

[PATCH v4 10/13] net/nfp: add queue stop and close helper function

2022-06-22 Thread Jin Liu
This commit does not introduce new features, just integrate some common logic into helper functions to reduce the same logic and increase code reuse, include queue stop and queue close logic, will be used when NFP net stop and close. queue stop: reset queue queue close: reset and release queue Mo

[PATCH v4 09/13] net/nfp: nfdk netdev option and queue function

2022-06-22 Thread Jin Liu
Add ethdev option for firmware with NFDk, implement tx_queue setup function for firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 32 - drive

[PATCH v4 08/13] net/nfp: structure adjustment

2022-06-22 Thread Jin Liu
Add and modify the nfp PMD struct and macro that will be used by firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_rxtx.h | 58 +

[PATCH v4 07/13] net/nfp: support firmware with NFDk

2022-06-22 Thread Jin Liu
Modify nfp driver logic, add firmware version (NFD3 or NFDK) judgment, will according to the firmware version, mount different driver functions. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- doc/guide

[PATCH v4 06/13] net/nfp: support NFP3800 card

2022-06-22 Thread Jin Liu
Add support for a new type of NIC NFP3800 card, and update some network card data acquisition interface functions. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- doc/guides/nics/nfp.rst

[PATCH v4 05/13] net/nfp: rename function and struct

2022-06-22 Thread Jin Liu
Add 'nfd3' into the firmware with NFD3 eth driver function name, preparation for the next work, as we will support another version firmware with NFDk. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- dri

[PATCH v4 04/13] net/nfp: rename set MAC function

2022-06-22 Thread Jin Liu
The NFP eth driver function name start with 'nfp_net', but set_mac function start with 'nfp' only, rename it, be consistent with others. Signed-off-by: Jin Liu Signed-off-by: Diana Wang Signed-off-by: Peng Zhang Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- drivers/net/nfp/n

[PATCH v4 03/13] net/nfp: remove pessimistic limit

2022-06-22 Thread Jin Liu
Multiple writes cause intermediate pointer values that do not end on complete TX descriptors. The QCP peripheral on the NFP provides a number of access modes. In some access modes, the maximum amount to add must be restricted to a 6bit value. The particular access mode used by _nfp_qcp_ptr_add() h

[PATCH v4 02/13] net/nfp: remove unnecessary forward function declaration

2022-06-22 Thread Jin Liu
This commit remove some unnecessary forward function declarations. Signed-off-by: Chaoyong He Signed-off-by: Jin Liu Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 22 -- drivers/net/nfp/nfp_ethdev_vf.c | 12 drivers/net/nfp/nfp_rxtx.c

[PATCH v4 01/13] net/nfp: change the coding style

2022-06-22 Thread Jin Liu
Change the coding style of some logics, to make it more compatible with the DPDK coding style. Signed-off-by: Chaoyong He Signed-off-by: Jin Liu Signed-off-by: Niklas Söderlund --- drivers/net/nfp/nfp_ethdev.c| 149 drivers/net/nfp/nfp_ethdev_vf.c | 8 +-

[PATCH v4 00/13] Add support of NFP3800 chip and firmware with NFDk

2022-06-22 Thread Jin Liu
NFD is part of NFP firmware, and there only exist a NFD3 version before this patch series. This patch series mainly add the support of the new NFP3800 chip use firmware with NFD3/NFDk. * Changes since v1 - Added updated documentation for NFP to cover NFD. - Documented the addition of NFD in the

[PATCH] vhost: fix unchecked return value

2022-06-22 Thread Jiayu Hu
This patch checks the return value of rte_dma_info_get() called in rte_vhost_async_dma_configure(). Coverity issue: 379066 Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path") Signed-off-by: Jiayu Hu --- lib/vhost/vhost.c | 6 +- 1 file changed, 5 insertions(+), 1 delet

Re: [EXT] Re: [PATCH v2 1/2] examples/l3fwd: common packet group functionality

2022-06-22 Thread Konstantin Ananyev
21/06/2022 17:50, Rahul Bhansali пишет: -Original Message- From: Konstantin Ananyev Sent: Tuesday, June 21, 2022 4:43 AM To: Rahul Bhansali ; dev@dpdk.org; Ruifeng Wang Cc: Jerin Jacob Kollanukkaran Subject: [EXT] Re: [PATCH v2 1/2] examples/l3fwd: common packet group functionality

Re: [PATCH] ip_frag: replace the rte memcpy with memcpy

2022-06-22 Thread Konstantin Ananyev
18/06/2022 15:09, Huichao Cai пишет: To resolve the compilation warning,replace the rte_memcpy with memcpy. Modify in file test_ipfrag.c and rte_ipv4_fragmentation.c. Signed-off-by: Huichao Cai --- app/test/test_ipfrag.c | 13 ++--- lib/ip_frag/rte_ipv4_fragmentation.c

Re: [PATCH v2] app/testpmd: fix quit testpmd with vfs and pf

2022-06-22 Thread Thomas Monjalon
Sorry, this patch looks really wrong, I cannot pull it into the main branch. See below for an explanation. 21/06/2022 12:43, Ferruh Yigit: > On 6/21/2022 10:24 AM, Ke Zhang wrote: > > When testpmd startups with pf and vfs,this error occurs when quitting, > > results in pf is released before vfs ,

Re: [PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory

2022-06-22 Thread Dmitry Kozlyuk
2022-06-22 19:03 (UTC+0200), David Marchand: > On Sat, Jun 18, 2022 at 1:29 PM Dmitry Kozlyuk > wrote: > > > > Hi Fidaullah, > > > > Thanks for the fix, > > Acked-by: Dmitry Kozlyuk > > This seems backport material. > Dmitry, Anatoly, do you agree? If so I'll mark it when applying. > > As fo

Re: [PATCH 0/2] remove unnecessary words in function documention

2022-06-22 Thread Stephen Hemminger
On Wed, 22 Jun 2022 13:37:12 -0700 Tyler Retzlaff wrote: > On Wed, Jun 22, 2022 at 01:27:36PM -0700, Stephen Hemminger wrote: > > The phrase "This API is used to" is unnecessary and changes the > > documentation into passive voice. > > > > Stephen Hemminger (2): > > rawdev, dmadev: remove pass

[PATCH v4] lib: document existing free functions

2022-06-22 Thread Stephen Hemminger
Make sure all functions which use the convention that XXX_free(NULL) is a nop are all documented. The wording is chosen to match the documentation of free(3). "If ptr is NULL, no operation is performed." Signed-off-by: Stephen Hemminger --- lib/bitratestats/rte_bitrate.h | 1 + lib/compressde

[PATCH] rte_rib6: fix references to rte_rib

2022-06-22 Thread Stephen Hemminger
The comments in rte_rib6 were cut-and-pasted from rte_rib and because of that some references to rte_rib_node were not updated. Signed-off-by: Stephen Hemminger --- lib/rib/rte_rib6.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/rib/rte_rib6.h b/lib/rib/rte_rib6.

Re: [PATCH 0/2] remove unnecessary words in function documention

2022-06-22 Thread Tyler Retzlaff
On Wed, Jun 22, 2022 at 01:27:36PM -0700, Stephen Hemminger wrote: > The phrase "This API is used to" is unnecessary and changes the > documentation into passive voice. > > Stephen Hemminger (2): > rawdev, dmadev: remove passive voice in function doc > eal: remove passive voice from interrupt

[PATCH 2/2] eal: remove passive voice from interrupt function documentation

2022-06-22 Thread Stephen Hemminger
The phrase "This API is used" is unnecessary, remove it. Reword to describe function in active voice. Signed-off-by: Stephen Hemminger --- lib/eal/include/rte_interrupts.h | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/lib/eal/include/rte_interrupts

[PATCH 1/2] rawdev, dmadev: remove passive voice in function doc

2022-06-22 Thread Stephen Hemminger
Remove extraneous phrase "This API is used to" and use active instead of passive voice when describing a function. Signed-off-by: Stephen Hemminger --- drivers/raw/ioat/rte_ioat_rawdev.h | 2 +- lib/dmadev/rte_dmadev.h| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --g

[PATCH 0/2] remove unnecessary words in function documention

2022-06-22 Thread Stephen Hemminger
The phrase "This API is used to" is unnecessary and changes the documentation into passive voice. Stephen Hemminger (2): rawdev, dmadev: remove passive voice in function doc eal: remove passive voice from interrupt function documentation drivers/raw/ioat/rte_ioat_rawdev.h | 2 +- lib/dmadev

[PATCH v3 5/6] test/threads: add tests for thread attributes API

2022-06-22 Thread Tyler Retzlaff
test basic functionality and demonstrate use of following thread attributes api. additionally, test attributes are processed when supplied to rte_thread_create(). * rte_thread_attr_init * rte_thread_attr_set_affinity * rte_thread_attr_get_affinity * rte_thread_attr_set_priority Si

[PATCH v3 6/6] test/threads: remove unit test use of pthread

2022-06-22 Thread Tyler Retzlaff
now that rte_thread provides thread lifetime functions stop using pthread in unit tests. Signed-off-by: Tyler Retzlaff --- app/test/test_threads.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/app/test/test_threads.c b/app/test/test_threads.c index 3c22cec..e0f18e4 1

[PATCH v3 2/6] eal: add thread lifetime management

2022-06-22 Thread Tyler Retzlaff
The *rte_thread_create()* function can optionally receive an rte_thread_attr_t object that will cause the thread to be created with the affinity and priority described by the attributes object. If no rte_thread_attr_t is passed (parameter is NULL), the default affinity and priority are used. On Wi

[PATCH v3 1/6] eal: add thread attributes

2022-06-22 Thread Tyler Retzlaff
Implement thread attributes for: * thread affinity * thread priority Implement functions for managing thread attributes. Priority is represented through an enum that allows for two levels: * RTE_THREAD_PRIORITY_NORMAL * RTE_THREAD_PRIORITY_REALTIME_CRITICAL Affinity is desc

[PATCH v3 4/6] test/threads: add tests for thread lifetime API

2022-06-22 Thread Tyler Retzlaff
test basic functionality and demonstrate use of following thread lifetime api. * rte_thread_create * rte_thread_detach * rte_thread_join Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff --- app/test/test_threads.c | 54 +++-- 1

[PATCH v3 3/6] eal: add basic rte thread ID equal API

2022-06-22 Thread Tyler Retzlaff
Add rte_thread_equal() that tests if two rte_thread_id are equal. Signed-off-by: Narcisa Vasile Signed-off-by: Tyler Retzlaff Acked-by: Chengwen Feng Acked-by: Konstantin Ananyev --- lib/eal/include/rte_thread.h | 19 +++ lib/eal/unix/rte_thread.c| 6 ++ lib/eal/versi

[PATCH v3 0/6] add thread lifetime and attributes API

2022-06-22 Thread Tyler Retzlaff
add rte thread lifetime and attributes api. with these api additions there is now sufficient platform abstracted thread api to remove the use of pthread in the unit tests. v3: * change rte_thread_func return type to uint32_t for exit value. * change rte_thread_join retval to be uint32_t (match

RE: [RFC PATCH v1] net/i40e: put mempool cache out of API

2022-06-22 Thread Honnappa Nagarahalli
> Subject: RE: [RFC PATCH v1] net/i40e: put mempool cache out of API > > > From: Feifei Wang [mailto:feifei.wa...@arm.com] > > Sent: Monday, 13 June 2022 07.52 > > > > Refer to "i40e_tx_free_bufs_avx512", this patch puts mempool cache out > > of API to free buffers directly. There are two change

Re: [PATCH 0/3] more null pointer check removal

2022-06-22 Thread Tyler Retzlaff
On Wed, Jun 22, 2022 at 11:51:55AM -0700, Stephen Hemminger wrote: > Reran the Cocci script to check for unnecessary null > pointer comparisons before free related functions. > > Stephen Hemminger (3): > vdpa/mlx5: remove unnecessary null check > raw/ifpga: remove unnecessary null check > dm

[PATCH 3/3] dmap/dpaa2: remove unnecessary null check

2022-06-22 Thread Stephen Hemminger
The function rte_free already handles being called with NULL. Found by nullfree.cocci. Signed-off-by: Stephen Hemminger --- drivers/dma/dpaa2/dpaa2_qdma.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2/dpaa2_qdma.c ind

[PATCH 2/3] raw/ifpga: remove unnecessary null check

2022-06-22 Thread Stephen Hemminger
The function rte_kvargs_free handles calling with NULL. Found by nullfree.cocci. Signed-off-by: Stephen Hemminger --- drivers/raw/ifpga/ifpga_rawdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index c

[PATCH 1/3] vdpa/mlx5: remove unnecessary null check

2022-06-22 Thread Stephen Hemminger
Found by nullfree.cocci. Signed-off-by: Stephen Hemminger --- drivers/vdpa/mlx5/mlx5_vdpa_virtq.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c b/drivers/vdpa/mlx5/mlx5_vdpa_virtq.c index e025be47d277..e06d6afb676f 100644 --- a/drivers

[PATCH 0/3] more null pointer check removal

2022-06-22 Thread Stephen Hemminger
Reran the Cocci script to check for unnecessary null pointer comparisons before free related functions. Stephen Hemminger (3): vdpa/mlx5: remove unnecessary null check raw/ifpga: remove unnecessary null check dmap/dpaa2: remove unnecessary null check drivers/dma/dpaa2/dpaa2_qdma.c | 6

Re: [PATCH v2 2/6] eal: add thread lifetime management

2022-06-22 Thread Tyler Retzlaff
On Wed, Jun 22, 2022 at 01:24:14AM +0300, Dmitry Kozlyuk wrote: > 2022-06-21 14:28 (UTC-0700), Tyler Retzlaff: > > On Tue, Jun 21, 2022 at 10:44:21PM +0300, Dmitry Kozlyuk wrote: > > > 2022-06-21 11:51 (UTC-0700), Tyler Retzlaff: > > > > > > +int > > > > > > +rte_thread_join(rte_thread_t thread_i

RE: [PATCH v8 1/7] eventdev/eth_rx: add adapter instance get API

2022-06-22 Thread Jayatheerthan, Jay
Aside of the minor documentation fix in patch 7/7, the full patchset looks good to me. Thanks for posting it! Please fix it and add Acked-by: Jay Jayatheerthan -Jay > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 22, 2022 10:24 PM > To: dev@dpdk.org; jer...@

RE: [PATCH v8 7/7] doc/eth_tx: update instance get API

2022-06-22 Thread Jayatheerthan, Jay
> -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 22, 2022 10:24 PM > To: dev@dpdk.org; jer...@marvell.com; Jayatheerthan, Jay > ; Naga Harish K, S V > > Subject: [PATCH v8 7/7] doc/eth_tx: update instance get API > > Added rte_event_eth_tx_adapter_instance_get()

RE: [PATCH v8 6/7] doc/eth_rx: update instance get API

2022-06-22 Thread Naga Harish K, S V
Reviewed-by: Naga Harish K S V > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 22, 2022 10:24 PM > To: dev@dpdk.org; jer...@marvell.com; Jayatheerthan, Jay > ; Naga Harish K, S V > > Subject: [PATCH v8 6/7] doc/eth_rx: update instance get API > > Added rte_even

RE: [PATCH v8 7/7] doc/eth_tx: update instance get API

2022-06-22 Thread Naga Harish K, S V
Reviewed-by: Naga Harish K S V > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 22, 2022 10:24 PM > To: dev@dpdk.org; jer...@marvell.com; Jayatheerthan, Jay > ; Naga Harish K, S V > > Subject: [PATCH v8 7/7] doc/eth_tx: update instance get API > > Added rte_even

RE: [PATCH v8 1/7] eventdev/eth_rx: add adapter instance get API

2022-06-22 Thread Naga Harish K, S V
Reviewed-by: Naga Harish K S V > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 22, 2022 10:24 PM > To: dev@dpdk.org; jer...@marvell.com; Jayatheerthan, Jay > ; Naga Harish K, S V > > Subject: [PATCH v8 1/7] eventdev/eth_rx: add adapter instance get API > > Adde

RE: [PATCH v8 5/7] test/eth_tx: add testcase for instance get API

2022-06-22 Thread Naga Harish K, S V
Reviewed-by: Naga Harish K S V > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 22, 2022 10:24 PM > To: dev@dpdk.org; jer...@marvell.com; Jayatheerthan, Jay > ; Naga Harish K, S V > > Subject: [PATCH v8 5/7] test/eth_tx: add testcase for instance get API > > Add

RE: [PATCH v8 4/7] eventdev/eth_tx: add instance get API

2022-06-22 Thread Naga Harish K, S V
Reviewed-by: Naga Harish K S V > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 22, 2022 10:24 PM > To: dev@dpdk.org; jer...@marvell.com; Jayatheerthan, Jay > ; Naga Harish K, S V > > Subject: [PATCH v8 4/7] eventdev/eth_tx: add instance get API > > Added rte_ev

RE: [PATCH v8 3/7] test/eth_rx: add test case for instance get API

2022-06-22 Thread Naga Harish K, S V
Reviewed-by: Naga Harish K S V > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 22, 2022 10:24 PM > To: dev@dpdk.org; jer...@marvell.com; Jayatheerthan, Jay > ; Naga Harish K, S V > > Subject: [PATCH v8 3/7] test/eth_rx: add test case for instance get API > > Ad

RE: [PATCH v8 2/7] eventdev/eth_rx: add telemetry callback for instance get

2022-06-22 Thread Naga Harish K, S V
Reviewed-by: Naga Harish K S V > -Original Message- > From: Kundapura, Ganapati > Sent: Wednesday, June 22, 2022 10:24 PM > To: dev@dpdk.org; jer...@marvell.com; Jayatheerthan, Jay > ; Naga Harish K, S V > > Subject: [PATCH v8 2/7] eventdev/eth_rx: add telemetry callback for > instance

Re: [PATCH] vhost/crypto: fix descriptor processing

2022-06-22 Thread Maxime Coquelin
On 6/22/22 17:30, David Marchand wrote: copy_data was returning a pointer to an increased (off by one) descriptor. Subsequent calls to copy_data in the library were then failing. Fix this by incrementing the descriptor only if there is some left data to copy. Fixes: 7287660a21e0 ("vhost/crypt

Re: [PATCH] eal: fixes the bug where rte_malloc() fails to allocates memory

2022-06-22 Thread David Marchand
On Sat, Jun 18, 2022 at 1:29 PM Dmitry Kozlyuk wrote: > > Hi Fidaullah, > > Thanks for the fix, > Acked-by: Dmitry Kozlyuk This seems backport material. Dmitry, Anatoly, do you agree? If so I'll mark it when applying. As for a Fixes: line, the closer commit touching this part is 07dcbfe0101f ("

[PATCH v8 7/7] doc/eth_tx: update instance get API

2022-06-22 Thread Ganapati Kundapura
Added rte_event_eth_tx_adapter_instance_get() details. Signed-off-by: Ganapati Kundapura --- doc/guides/prog_guide/event_ethernet_tx_adapter.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst b/doc/guides/prog_guide/event_ethernet_t

[PATCH v8 6/7] doc/eth_rx: update instance get API

2022-06-22 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() details Signed-off-by: Ganapati Kundapura --- doc/guides/prog_guide/event_ethernet_rx_adapter.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx

[PATCH v8 5/7] test/eth_tx: add testcase for instance get API

2022-06-22 Thread Ganapati Kundapura
Added testcase for rte_event_eth_tx_adapter_instance_get() Signed-off-by: Ganapati Kundapura --- app/test/test_event_eth_tx_adapter.c | 75 1 file changed, 75 insertions(+) diff --git a/app/test/test_event_eth_tx_adapter.c b/app/test/test_event_eth_tx_adapt

[PATCH v8 4/7] eventdev/eth_tx: add instance get API

2022-06-22 Thread Ganapati Kundapura
Added rte_event_eth_tx_adapter_instance_get() to get the adapter instance id for specified ethernet device id and tx queue index. Signed-off-by: Ganapati Kundapura --- lib/eventdev/eventdev_pmd.h | 23 +++ lib/eventdev/rte_event_eth_tx_adapter.c | 102 +++

[PATCH v8 3/7] test/eth_rx: add test case for instance get API

2022-06-22 Thread Ganapati Kundapura
Added test case for rte_event_eth_rx_adapter_instance_get() Signed-off-by: Ganapati Kundapura --- app/test/test_event_eth_rx_adapter.c | 203 ++- 1 file changed, 202 insertions(+), 1 deletion(-) diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_e

[PATCH v8 2/7] eventdev/eth_rx: add telemetry callback for instance get

2022-06-22 Thread Ganapati Kundapura
Added telemetry handler for rte_event_eth_rx_adapter_instance_get() to retrieve adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura --- lib/eventdev/rte_event_eth_rx_adapter.c | 66 + 1 file changed, 66 insert

[PATCH v8 1/7] eventdev/eth_rx: add adapter instance get API

2022-06-22 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() to get adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura --- v8: * Removed limits.h inclusion v7: * Remove allocation of instance array and storage of instnace id * in instance array * Use Rx a

RE: [PATCH] vhost/crypto: fix descriptor processing

2022-06-22 Thread Zhang, Roy Fan
> -Original Message- > From: David Marchand > Sent: Wednesday, June 22, 2022 4:30 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; Poczatek, Jakub > ; Maxime Coquelin > ; Xia, Chenbo > Subject: [PATCH] vhost/crypto: fix descriptor processing > > copy_data was returning a pointer to an increa

RE: [PATCH v3] app/test: add event inline security tests

2022-06-22 Thread Anoob Joseph
> > Enable ability to run inline security tests using event > API(rte_event_eth_tx_adapter_enqueue/rte_event_dequeue_burst). > New test command - event_inline_ipsec_autotest will run same list of test > cases as inline_ipsec_autotest, but packets will go through eventdev. > > Signed-off-by: Volod

Re: [PATCH v3 12/13] net/nfp: nfdk packet xmit function

2022-06-22 Thread Ferruh Yigit
On 6/22/2022 5:03 PM, Thomas Monjalon wrote: 17/06/2022 11:34, Jin Liu: + if (unlikely(pkt->nb_segs > 1 && + !(hw->cap & NFP_NET_CFG_CTRL_GATHER))) { + PMD_INIT_LOG(INFO, "NFP_NET_CFG_CTRL_GATHER not set"); +

RE: [PATCH 1/2] config: Use G++ as C++ compiler

2022-06-22 Thread Morten Brørup
> From: Tyler Retzlaff [mailto:roret...@linux.microsoft.com] > Sent: Wednesday, 22 June 2022 18.06 > > On Wed, Jun 22, 2022 at 07:07:12AM +0200, Stanisław Kardach wrote: > > On Tue, Jun 21, 2022 at 9:53 PM Tyler Retzlaff > > wrote: > > > > > > > -cpp = ['ccache', 'arm-linux-gnueabihf-cpp'] > > >

Re: [PATCH 1/2] config: Use G++ as C++ compiler

2022-06-22 Thread Tyler Retzlaff
On Wed, Jun 22, 2022 at 07:07:12AM +0200, Stanisław Kardach wrote: > On Tue, Jun 21, 2022 at 9:53 PM Tyler Retzlaff > wrote: > > > > > -cpp = ['ccache', 'arm-linux-gnueabihf-cpp'] > > > +cpp = ['ccache', 'arm-linux-gnueabihf-g++'] > > > > suggest the variable should be 'cxx' not 'cpp' (to be cons

Re: [PATCH v3 12/13] net/nfp: nfdk packet xmit function

2022-06-22 Thread Thomas Monjalon
17/06/2022 11:34, Jin Liu: > + if (unlikely(pkt->nb_segs > 1 && > + !(hw->cap & NFP_NET_CFG_CTRL_GATHER))) { > + PMD_INIT_LOG(INFO, "NFP_NET_CFG_CTRL_GATHER not set"); > + rte_panic("Multisegment packet unsupported\n");

Re: [PATCH 08/12] net/qede/base: fix build with GCC 12

2022-06-22 Thread David Marchand
On Wed, Jun 22, 2022 at 1:17 AM Stephen Hemminger wrote: > > GCC raises the following warning: > > > > In function ‘_mm256_storeu_si256’, > > inlined from ‘rte_mov32’ at > > ../lib/eal/x86/include/rte_memcpy.h:320:2, > > inlined from ‘rte_mov128’ at > > ../lib/eal/x86/inclu

Re: [PATCH] vhost/crypto: fix descriptor processing

2022-06-22 Thread Maxime Coquelin
On 6/22/22 17:30, David Marchand wrote: copy_data was returning a pointer to an increased (off by one) descriptor. Subsequent calls to copy_data in the library were then failing. Fix this by incrementing the descriptor only if there is some left data to copy. Fixes: 7287660a21e0 ("vhost/crypt

Re: [PATCH v3] vhost/crypto: fix build with GCC 12

2022-06-22 Thread David Marchand
On Wed, Jun 22, 2022 at 5:22 PM Poczatek, Jakub wrote: > > Hey David, > > The code change fixes the errors and the performance test completes. I posted this fix against (not yet pulled into main) next-virtio repo. -- David Marchand

[PATCH] vhost/crypto: fix descriptor processing

2022-06-22 Thread David Marchand
copy_data was returning a pointer to an increased (off by one) descriptor. Subsequent calls to copy_data in the library were then failing. Fix this by incrementing the descriptor only if there is some left data to copy. Fixes: 7287660a21e0 ("vhost/crypto: fix build with GCC 12") Reported-by: Jaku

RE: [PATCH v3] vhost/crypto: fix build with GCC 12

2022-06-22 Thread Poczatek, Jakub
Hey David, The code change fixes the errors and the performance test completes. Kind Regards, Jakub Poczatek -Original Message- From: David Marchand Sent: Wednesday 22 June 2022 15:08 To: Poczatek, Jakub ; Zhang, Roy Fan Cc: Maxime Coquelin ; dev@dpdk.org; sta...@dpdk.org; Xia, C

RE: [PATCH v6] sched: enable CMAN at runtime

2022-06-22 Thread Danilewicz, MarcinX
Hi Cristian, > The code changes in the library (rte-sched.c) look good to me, but I do have > some questions for the qos_sched app and the Soft NIC driver on how CMAN > gets enabled/disabled. That was open q from start. We finally found a time to discuss this. > How do we control whether conges

Re: [PATCH v3 4/8] lib: document existing free functions

2022-06-22 Thread Stephen Hemminger
On Wed, 22 Jun 2022 11:23:04 +0200 Thomas Monjalon wrote: > 28/02/2022 18:08, Stephen Hemminger: > > On Mon, 28 Feb 2022 09:42:47 + > > Bruce Richardson wrote: > > > > > On Sun, Feb 27, 2022 at 09:48:57PM +0100, Thomas Monjalon wrote: > > > > 20/02/2022 19:21, Stephen Hemminger: > >

Fw:[PATCH v2] vhost: fix avail idx update error when desc copy failed

2022-06-22 Thread Gaoxiang Liu
Hi, Chen bo, Maxime, Please help to review the patch below. Thanks. Gaoxiang. Forwarding messages From: "Gaoxiang Liu" Date: 2022-06-22 09:19:44 To: maxime.coque...@redhat.com,chenbo@intel.com Cc: dev@dpdk.org,liugaoxi...@huawei.com,"Gaoxiang Liu" ,sta...@dpdk.org

[Bug 1041] dma/idxd build failure with clang 3.4.2

2022-06-22 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1041 Bug ID: 1041 Summary: dma/idxd build failure with clang 3.4.2 Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity: normal

  1   2   >