dev@dpdk.org

2022-06-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1029 Bug ID: 1029 Summary: [dpdk 22.07-rc1] drivers/net/cxgbe meson build failed with cflag param optimization=1 on Ubuntu22.04 &&RHEL8.6 with gcc11.2.0&&8.5.0 Product: DPDK V

[PATCH v4] net/i40e: add outer VLAN processing

2022-06-08 Thread Kevin Liu
From: Robin Zhang Outer VLAN processing is supported after firmware v8.4, kernel driver also change the default behavior to support this feature. To align with kernel driver, add support for outer VLAN processing in DPDK. But it is forbidden for firmware to change the Inner/Outer VLAN configurat

RE: [PATCH v4] doc: announce changes in bbdev related to enum extension

2022-06-08 Thread Hemant Agrawal
> -Original Message- > From: Nicolas Chautru > Sent: Thursday, June 9, 2022 6:05 AM > To: dev@dpdk.org; gak...@marvell.com; tho...@monjalon.net; > maxime.coque...@redhat.com > Cc: t...@redhat.com; ray.kinse...@intel.com; bruce.richard...@intel.com; > Hemant Agrawal ; > david.march...@re

RE: [PATCH] vhost: fix null pointer dereference

2022-06-08 Thread Hu, Jiayu
Hi Maxime, This issue has fixed in https://patches.dpdk.org/project/dpdk/patch/2022040013.18624-4-david.march...@redhat.com/. Thanks, Jiayu > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 1, 2022 3:58 PM > To: Hu, Jiayu > Cc: dev ; dpdk stable ; David Marchand

[PATCH v3] net/i40e: add outer VLAN processing

2022-06-08 Thread Kevin Liu
From: Robin Zhang Outer VLAN processing is supported after firmware v8.4, kernel driver also change the default behavior to support this feature. To align with kernel driver, add support for outer VLAN processing in DPDK. But it is forbidden for firmware to change the Inner/Outer VLAN configurat

[PATCH v1] ip_frag: add IPv4 fragment copy packet API

2022-06-08 Thread Huichao Cai
Some NIC drivers support MBUF_FAST_FREE(Device supports optimization for fast release of mbufs. When set application must guarantee that per-queue all mbufs comes from the same mempool and has refcnt = 1) offload. In order to adapt to this offload function, add this API. Add some test data for this

[PATCH v6 5/5] raw/ifpga: add HE-HSSI AFU driver

2022-06-08 Thread Wei Huang
HE-HSSI is one of the host exerciser modules in OFS FPGA, which is used to test HSSI (High Speed Serial Interface). This driver initialize the module and report test result. Signed-off-by: Wei Huang --- drivers/raw/ifpga/afu_pmd_he_hssi.c | 371 drivers/raw/i

[PATCH v6 4/5] raw/ifpga: add HE-MEM AFU driver

2022-06-08 Thread Wei Huang
HE-MEM is one of the host exerciser modules in OFS FPGA, which is used to test local memory with built-in traffic generator. This driver initialize the module and report test result. Signed-off-by: Wei Huang --- drivers/raw/ifpga/afu_pmd_he_mem.c | 183 + driv

[PATCH v6 3/5] raw/ifpga: add HE-LPBK AFU driver

2022-06-08 Thread Wei Huang
HE-LPBK and HE-MEM-LPBK are host exerciser modules in OFS FPGA, HE-LPBK is used to test PCI bus and HE-MEM-LPBK is used to test local memory. This driver initialize the modules and report test result. Signed-off-by: Wei Huang --- drivers/raw/ifpga/afu_pmd_he_lpbk.c | 436

[PATCH v6 2/5] raw/ifpga: add N3000 AFU driver

2022-06-08 Thread Wei Huang
N3000 AFU includes NLB0 and DMA modules, NLB0 is used to test PCI bus and DMA is used to test local memory. This driver initialize the modules and report test result. Signed-off-by: Wei Huang --- drivers/raw/ifpga/afu_pmd_core.h | 18 + drivers/raw/ifpga/afu_pmd_n3000.c | 2019 +++

[PATCH v6 1/5] raw/ifpga: introduce AFU driver framework

2022-06-08 Thread Wei Huang
AFU (Acceleration Function Unit) is part of FPGA and enumerated by ifpga driver. This driver implements common AFU device interfaces and exposes them to application as standard raw device APIs. Normally application can operate specified AFU as below, 1. call rte_rawdev_pmd_get_named_dev() to find A

[PATCH v6 0/5] introduce AFU PMD driver of FPGA

2022-06-08 Thread Wei Huang
The first patch implements the framework of the AFU PMD driver based on raw device interfaces. The subsequent patches implement the driver of some AFUs. Changes from v5: 1. Move source files to raw/ifpga directory and rename them. 2. Use spinlock to prevent AFU from accessing simultaneously. 3. Re

Re: Lgtm scan of DPDK

2022-06-08 Thread Stephen Hemminger
On Wed, 8 Jun 2022 08:35:45 + "Mcnamara, John" wrote: > > -Original Message- > > From: Thomas Monjalon > > Sent: Wednesday, June 8, 2022 9:23 AM > > To: Stephen Hemminger > > Cc: dev@dpdk.org; Mcnamara, John ; > > david.march...@redhat.com > > Subject: Re: Lgtm scan of DPDK > > > >

Re: Minutes of Technical Board Meeting, 2022-06-01

2022-06-08 Thread Stephen Hemminger
On Thu, 9 Jun 2022 10:07:28 +0800 fengchengwen wrote: > On 2022/6/9 9:31, Stephen Hemminger wrote: > > On Thu, 9 Jun 2022 08:41:35 +0800 > > fengchengwen wrote: > > > >> [snip] > >> > >>> > >>> 4) Removal of KNI > >>> - > >>> > >>> There is no more maintainer for KNI. > >>>

RE: [PATCH v2 6/6] net/vhost: perform SW checksum in Tx path

2022-06-08 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 8, 2022 8:50 PM > To: dev@dpdk.org; jasow...@redhat.com; Xia, Chenbo ; > david.march...@redhat.com; Matz, Olivier ; Ma, > WenwuX ; Zhang, Yuying ; > Singh, Aman Deep > Cc: Maxime Coquelin > Subject: [PATCH v

[Bug 1017] [dpdk-22.07*] kernel/linux/kni meson build failed with gcc 11.2.0 on Ub22.04/64

2022-06-08 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1017 gaodaxue (daxuex@intel.com) changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

RE: [PATCH v2 5/6] net/vhost: perform SW checksum in Rx path

2022-06-08 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 8, 2022 8:50 PM > To: dev@dpdk.org; jasow...@redhat.com; Xia, Chenbo ; > david.march...@redhat.com; Matz, Olivier ; Ma, > WenwuX ; Zhang, Yuying ; > Singh, Aman Deep > Cc: Maxime Coquelin > Subject: [PATCH v

Re: Minutes of Technical Board Meeting, 2022-06-01

2022-06-08 Thread Stephen Hemminger
On Thu, 9 Jun 2022 08:41:35 +0800 fengchengwen wrote: > [snip] > > > > > 4) Removal of KNI > > - > > > > There is no more maintainer for KNI. > > > > A progressive removal proposal was made: > > - add a message at runtime and/or compilation to announce deprecation > > - remove

RE: [PATCH 6/6] net/vhost: perform SW checksum in Tx path

2022-06-08 Thread Ma, WenwuX
> -Original Message- > From: Maxime Coquelin > Sent: 2022年6月8日 16:14 > To: Ma, WenwuX ; dev@dpdk.org; > jasow...@redhat.com; Xia, Chenbo ; > david.march...@redhat.com; Matz, Olivier > Cc: sta...@dpdk.org > Subject: Re: [PATCH 6/6] net/vhost: perform SW checksum in Tx path > > Hi Wenwu,

[PATCH v4] doc: announce changes in bbdev related to enum extension

2022-06-08 Thread Nicolas Chautru
Intent to resolve in DPDK 22.11 historical usage which prevents graceful extension of enum and API without troublesome ABI breakage as well as extending API RTE_BBDEV_OP_FFT for new operation type in bbdev as well as other new members in existing structures. Signed-off-by: Nicolas Chautru --- do

[PATCH v4] doc: announce changes in bbdev related to enum extension

2022-06-08 Thread Nicolas Chautru
v4: correcting typo. Hemant, Maxime kindly review/ack. v3: being more explicit wrt the list of intended changes for 22.11 v2: indentation fix Realizing when submitting new bbdev operation in this patch (https://patchwork.dpdk.org/project/dpdk/list/?series=22111) that this is not workable in pract

[PATCH v3] doc: announce changes in bbdev related to enum extension

2022-06-08 Thread Nicolas Chautru
Intent to resolve in DPDK 22.11 historical usage which prevents graceful extension of enum and API without troublesome ABI breakage as well as extending API RTE_BBDEV_OP_FFT for new operation type in bbdev as well as other new members in existing structures. Signed-off-by: Nicolas Chautru --- do

[PATCH v3] doc: announce changes in bbdev related to enum extension

2022-06-08 Thread Nicolas Chautru
v3: being more explicit wrt the list of intended changes for 22.11 v2: indentation fix Realizing when submitting new bbdev operation in this patch (https://patchwork.dpdk.org/project/dpdk/list/?series=22111) that this is not workable in practice to extend this API into 22.07 without fundamental A

[RFC] eal/x86: disable array bounds checks in rte_memcpy_generic with gcc-12

2022-06-08 Thread Stephen Hemminger
Gcc 12 adds more array bounds checking (good); but it is not smart enough to realize that for small fixed sizes, the bigger move options are not used. An example is using rte_memcpy() on a RSS key of 40 bytes may trigger rte_memcpy complaints from rte_mov128 reading past end of input. In order to

RE: [PATCH v1] bbdev: add device status info

2022-06-08 Thread Chautru, Nicolas
Hi Stephen, > -Original Message- > From: Stephen Hemminger > Sent: Tuesday, June 7, 2022 9:43 AM > To: Maxime Coquelin > Cc: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com; hemant.agra...@nxp.com; Vargas, > Hernan > Subject: Re: [PATCH v1] bbdev: add device stat

Re: [RFC 1/8] net/ena: fix warnings related to rte_memcpy and gcc-12

2022-06-08 Thread Stephen Hemminger
On Wed, 8 Jun 2022 21:18:15 +0200 Michał Krawczyk wrote: > śr., 8 cze 2022 o 17:32 Stephen Hemminger > napisał(a): > > > > On Wed, 8 Jun 2022 14:29:58 +0200 > > Michał Krawczyk wrote: > > > > > wt., 7 cze 2022 o 19:17 Stephen Hemminger > > > napisał(a): > > > > > > > > Rte_memcpy is not ne

release candidate 22.07-rc1

2022-06-08 Thread Thomas Monjalon
A new DPDK release candidate is ready for testing: https://git.dpdk.org/dpdk/tag/?id=v22.07-rc1 There are 576 new patches in this snapshot, constituting what the reviewers and maintainers were able to handle. Release notes: https://doc.dpdk.org/guides/rel_notes/release_22_07.html

Re: [PATCH v5 1/7] net/mlx5: add LWM support for Rxq

2022-06-08 Thread Matan Azrad
Series-acked-by: Matan Azrad mailto:ma...@nvidia.com>> קבל ‏Outlook עבור Android‏ From: Spike Du Sent: Tuesday, June 7, 2022 3:59:36 PM To: Matan Azrad ; Slava Ovsiienko ; Ori Kam ; NBU-Contact-Thomas Monjalon (EXTERNAL) Cc: andrew.rybch

Re: [RFC 1/8] net/ena: fix warnings related to rte_memcpy and gcc-12

2022-06-08 Thread Michał Krawczyk
śr., 8 cze 2022 o 17:32 Stephen Hemminger napisał(a): > > On Wed, 8 Jun 2022 14:29:58 +0200 > Michał Krawczyk wrote: > > > wt., 7 cze 2022 o 19:17 Stephen Hemminger > > napisał(a): > > > > > > Rte_memcpy is not needed for small objects only used on control > > > path. Regular memcpy is as fast o

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

2022-06-08 Thread Stanisław Kardach
On Wed, Jun 8, 2022 at 7:17 PM Jerin Jacob wrote: > > On Wed, Jun 8, 2022 at 2:00 PM Thomas Monjalon wrote: > > > > 08/06/2022 10:22, Jerin Jacob: > > > On Thu, Jun 2, 2022 at 5:30 PM Jerin Jacob wrote: > > > > > > > > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon > > > > wrote: > > > > > > >

Re: [PATCH v6] ethdev: introduce available Rx descriptors threshold

2022-06-08 Thread Thomas Monjalon
08/06/2022 19:22, Thomas Monjalon: > 08/06/2022 18:35, Andrew Rybchenko: > > From: Spike Du > > > > A new event RTE_ETH_EVENT_RX_AVAIL_THRESH should be generated by HW > > when number of available descriptors in Rx queue goes below the > > threshold. > > > > The threshold is defined as a percent

Re: [PATCH v5 0/2] kni: fix build warnings with Linux 5.17+

2022-06-08 Thread Andrew Rybchenko
On 6/8/22 15:11, Andrew Rybchenko wrote: v5: - fix broken build v4: - restore original patch author - resend with cover letter to address patchwork recognition as a series v3: - split single patch into two - clarify patches summary and description Ke Zhang (2):

Re: [PATCH v6] ethdev: introduce available Rx descriptors threshold

2022-06-08 Thread Thomas Monjalon
08/06/2022 18:35, Andrew Rybchenko: > From: Spike Du > > A new event RTE_ETH_EVENT_RX_AVAIL_THRESH should be generated by HW > when number of available descriptors in Rx queue goes below the > threshold. > > The threshold is defined as a percentage of an Rx queue size with valid > values from 0

Re: [PATCH] devtools: unify cross-compilation tests

2022-06-08 Thread Thomas Monjalon
08/06/2022 18:34, David Marchand: > On Wed, Jun 8, 2022 at 5:50 PM Thomas Monjalon wrote: > > > > Reduce the number of Arm builds from 3 to 1: > > only generic armv8 with GCC. > > The specific PPC builds on Ubuntu are skipped. > > > > The build directories for PPC and RISC-V > > are also renamed f

Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build

2022-06-08 Thread Jerin Jacob
On Wed, Jun 8, 2022 at 2:00 PM Thomas Monjalon wrote: > > 08/06/2022 10:22, Jerin Jacob: > > On Thu, Jun 2, 2022 at 5:30 PM Jerin Jacob wrote: > > > > > > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon > > > wrote: > > > > > > > > 02/06/2022 11:43, Jerin Jacob: > > > > > On Thu, Jun 2, 2022 at

[dpdk-dev] [PATCH v2] build: ccache support for cross build

2022-06-08 Thread jerinj
From: Jerin Jacob By default, ccache is not used for cross build[1]. Update all cross files to use ccache if it is available in build machine. Also, updated devtools/test-meson-builds.sh script to find the correct DPDK_TARGET due to change in cross file syntax. [1] https://mesonbuild.com/Machin

[PATCH v6] ethdev: introduce available Rx descriptors threshold

2022-06-08 Thread Andrew Rybchenko
From: Spike Du A new event RTE_ETH_EVENT_RX_AVAIL_THRESH should be generated by HW when number of available descriptors in Rx queue goes below the threshold. The threshold is defined as a percentage of an Rx queue size with valid values from 0 to 99 (inclusive). Zero (default) value disables it.

Re: [PATCH] devtools: unify cross-compilation tests

2022-06-08 Thread David Marchand
On Wed, Jun 8, 2022 at 5:50 PM Thomas Monjalon wrote: > > Reduce the number of Arm builds from 3 to 1: > only generic armv8 with GCC. > The specific PPC builds on Ubuntu are skipped. > > The build directories for PPC and RISC-V > are also renamed for consistency: > - build-arm64-generic-gc

Re: [PATCH v6] pcap: support MTU set for linux interafces

2022-06-08 Thread Stephen Hemminger
On Wed, 8 Jun 2022 19:04:19 +0300 Ido Goshen wrote: > +int > +osdep_iface_mtu_set(const char *if_name, uint16_t mtu) > +{ > + struct ifreq ifr; > + int if_fd = socket(AF_INET, SOCK_DGRAM, 0); > + > + if (if_fd == -1) > + return -1; > + > + rte_strscpy(ifr.ifr_name, if

[PATCH v6] pcap: support MTU set for linux interafces

2022-06-08 Thread Ido Goshen
Support rte_eth_dev_set_mtu for pcap ifaces vdevs by setting the underlying OS network interface's MTU. Support is for pcap ifaces only and not for pcap files. Support is for Linux only. Bugzilla ID: 961 Signed-off-by: Ido Goshen --- v6: Fixes for v5 approach 1. freebsd compilation fix 2. checkp

[PATCH] devtools: unify cross-compilation tests

2022-06-08 Thread Thomas Monjalon
Reduce the number of Arm builds from 3 to 1: only generic armv8 with GCC. The specific PPC builds on Ubuntu are skipped. The build directories for PPC and RISC-V are also renamed for consistency: - build-arm64-generic-gcc - build-ppc64-power8-gcc - build-riscv64-generic-gcc

Re: [PATCH v2] build: try to get kernel version from kernel source

2022-06-08 Thread David Marchand
On Tue, Mar 8, 2022 at 4:55 PM Ferruh Yigit wrote: > > On 3/3/2022 1:15 PM, Ferdinand Thiessen wrote: > > When building the kernel modules, try to get the kernel > > version from the kernel sources first. This fixes the > > kernel modules installation directory if the target kernel > > version dif

Re: [RFC 1/8] net/ena: fix warnings related to rte_memcpy and gcc-12

2022-06-08 Thread Stephen Hemminger
On Wed, 8 Jun 2022 14:29:58 +0200 Michał Krawczyk wrote: > wt., 7 cze 2022 o 19:17 Stephen Hemminger > napisał(a): > > > > Rte_memcpy is not needed for small objects only used on control > > path. Regular memcpy is as fast or faster and there is more > > robust since static analysis etc knows wh

RE: [PATCH v3] sched: enable CMAN at runtime

2022-06-08 Thread Danilewicz, MarcinX
Hi Cristian, Ok, let me check. BR, /Marcin > -Original Message- > From: Dumitrescu, Cristian > Sent: Wednesday, June 8, 2022 1:59 PM > To: Danilewicz, MarcinX ; dev@dpdk.org; > Singh, Jasvinder > Cc: Ajmera, Megha ; Liu, Yu Y > > Subject: RE: [PATCH v3] sched: enable CMAN at runtime >

Re: [RFC 8/8] ip_frag: fix gcc-12 warnings

2022-06-08 Thread Stephen Hemminger
On Wed, 8 Jun 2022 09:19:20 +0100 Konstantin Ananyev wrote: > 07/06/2022 18:17, Stephen Hemminger пишет: > > The function rte_memcpy can derference past source buffer which > > will cause array out of bounds warnings. But there is no good reason > > to use rte_memcpy instead of memcpy in this cod

Re: [PATCH 0/4] clean up zero-length arrays

2022-06-08 Thread Stephen Hemminger
On Thu, 2 Jun 2022 16:08:30 +0100 Bruce Richardson wrote: > This patchset adds a coccinelle script to clean-up zero-length > arrays in structures. The final patches are the result of running > that script on the DPDK repository. > > Bruce Richardson (4): > cocci: add script for zero-length ar

Re: [PATCH v2] eal: remove unused arch specific headers for locks

2022-06-08 Thread Thomas Monjalon
08/06/2022 15:16, Stanisław Kardach: > On Wed, Jun 8, 2022 at 1:57 PM David Marchand > wrote: > > > > MCS lock, PF lock and Ticket lock have no arch specific implementation, > > there is no need for the extra redirection in headers. > > > > Signed-off-by: David Marchand > > Acked-by: Stephen Hem

Re: [PATCH v2] eal: remove unused arch specific headers for locks

2022-06-08 Thread Stanisław Kardach
On Wed, Jun 8, 2022 at 1:57 PM David Marchand wrote: > > MCS lock, PF lock and Ticket lock have no arch specific implementation, > there is no need for the extra redirection in headers. > > Signed-off-by: David Marchand > Acked-by: Stephen Hemminger > --- > Note: this was mentionned during the s

Re: [PATCH v5 2/2] kni: fix warning about discarding const qualifier

2022-06-08 Thread Ferruh Yigit
On 6/8/2022 1:54 PM, Ferruh Yigit wrote: On 6/8/2022 1:11 PM, Andrew Rybchenko wrote: From: Ke Zhang The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const intentionally in v5.17 to prevent using it direc

Re: [PATCH v5 2/2] kni: fix warning about discarding const qualifier

2022-06-08 Thread Ferruh Yigit
On 6/8/2022 1:11 PM, Andrew Rybchenko wrote: From: Ke Zhang The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const intentionally in v5.17 to prevent using it directly. See kernel series [1] for more inform

Re: [PATCH v5 1/2] kni: use dedicated function to set random MAC address

2022-06-08 Thread Ferruh Yigit
On 6/8/2022 1:11 PM, Andrew Rybchenko wrote: From: Ke Zhang eth_hw_addr_random() sets address type correctly. eth_hw_addr_random() is available since Linux v3.4, so no compat is required. Also fix the warning: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer tar

[PATCH v2 6/6] net/vhost: perform SW checksum in Tx path

2022-06-08 Thread Maxime Coquelin
Virtio specification supports guest checksum offloading for L4, which is enabled with VIRTIO_NET_F_GUEST_CSUM feature negotiation. However, the Vhost PMD does not advertise Tx checksum offload capabilities. Advertising these offload capabilities at the ethdev level is not enough, because we could

[PATCH v2 5/6] net/vhost: perform SW checksum in Rx path

2022-06-08 Thread Maxime Coquelin
Virtio specification supports host checksum offloading for L4, which is enabled with VIRTIO_NET_F_CSUM feature negotiation. However, the Vhost PMD does not advertise Rx checksum offload capabilities, so we can end-up with the VIRTIO_NET_F_CSUM feature being negotiated, implying the Vhost library re

[PATCH v2 4/6] net/vhost: make VLAN stripping flag a boolean

2022-06-08 Thread Maxime Coquelin
This trivial patch makes the vlan_strip field of the pmd_internal struct a boolean, since it is handled as such. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- drivers/net/vhost/rte_eth_vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/vhost/rte

[PATCH v2 3/6] net/vhost: enable compliant offloading mode

2022-06-08 Thread Maxime Coquelin
This patch enables the compliant offloading flags mode by default, which prevents the Rx path to set Tx offload flags, which is illegal. A new legacy-ol-flags devarg is introduced to enable the legacy behaviour. Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- doc/guides/nics/vhost.rs

[PATCH v2 2/6] vhost: fix missing enqueue pseudo-header calculation

2022-06-08 Thread Maxime Coquelin
The Virtio specification requires that in case of checksum offloading, the pseudo-header checksum must be set in the L4 header. When received from another Vhost-user port, the packet checksum might already contain the pseudo-header checksum but we have no way to know it. So we have no other choice

[PATCH v2 1/6] Revert "app/testpmd: modify mac in csum forwarding"

2022-06-08 Thread Maxime Coquelin
This patch reverts commit 10f4620f02e1 ("app/testpmd: modify mac in csum forwarding"), as the checksum forwarding is expected to only perform checksum and not also overwrites the source and destination MAC addresses. Doing so, we can test checksum offloading with real traffic without breaking bro

[PATCH v2 0/6] Vhost checksum offload improvements

2022-06-08 Thread Maxime Coquelin
This series aims at improving Vhost checksum offloading support. The first patch reverts overwritting MAC address in testpmd CSUM forward mode. This is required to be able to test checksum offloading with real traffic. MAC forwarding mode should be used if the MAC addresses need to be changed. Se

Re: [dpdk-dev] [PATCH 0/2] fixes for failsafe/tap

2022-06-08 Thread Andrew Rybchenko
On 6/7/22 09:49, Yunjian Wang wrote: This series include two fixes patches for failsafe/tap Yunjian Wang (2): net/failsafe: fix freeing after device release net/tap: fix use after free on error path drivers/net/failsafe/failsafe.c | 2 +- drivers/net/tap/rte_eth_tap.c | 2 +- 2 file

Re: [RFC 1/8] net/ena: fix warnings related to rte_memcpy and gcc-12

2022-06-08 Thread Michał Krawczyk
wt., 7 cze 2022 o 19:17 Stephen Hemminger napisał(a): > > Rte_memcpy is not needed for small objects only used on control > path. Regular memcpy is as fast or faster and there is more > robust since static analysis etc knows what it does. > > In this driver it was redefining all memcpy as rte_memc

Re: [PATCH v4 0/8] Introduce support for RISC-V architecture

2022-06-08 Thread Stanisław Kardach
On Wed, Jun 8, 2022 at 10:42 AM David Marchand wrote: > > On Tue, May 31, 2022 at 4:14 PM Stanislaw Kardach wrote: > > > > This patchset adds support for building and running DPDK on 64bit RISC-V > > architecture. The initial support targets rv64gc (rv64imafdc) ISA and > > was tested on SiFive Un

Re: [PATCH 11/12] app/flow-perf: fix build with GCC 12

2022-06-08 Thread David Marchand
On Wed, Jun 8, 2022 at 11:03 AM Wisam Monther wrote: > > Hi David, > > > -Original Message- > > From: David Marchand > > Sent: Wednesday, May 18, 2022 1:17 PM > > To: dev@dpdk.org > > Cc: NBU-Contact-Thomas Monjalon (EXTERNAL) ; > > ferruh.yi...@xilinx.com; sta...@dpdk.org; Wisam Monther

[PATCH v6 7/7] doc/eth_tx: update instance get API

2022-06-08 Thread Ganapati Kundapura
Added rte_event_eth_tx_adapter_instance_get() details. Signed-off-by: Ganapati Kundapura diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst index f80d226..dc3e6a1 100644 --- a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst

[PATCH v6 6/7] doc/eth_rx: update instance get API

2022-06-08 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() details Signed-off-by: Ganapati Kundapura diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst index 3b4ef50..5b9d0cf 100644 --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst

[PATCH v6 5/7] test/eth_tx: add testcase for instance get API

2022-06-08 Thread Ganapati Kundapura
Added testcase for rte_event_eth_tx_adapter_instance_get() Signed-off-by: Ganapati Kundapura diff --git a/app/test/test_event_eth_tx_adapter.c b/app/test/test_event_eth_tx_adapter.c index 2900532..ebbc622 100644 --- a/app/test/test_event_eth_tx_adapter.c +++ b/app/test/test_event_eth_tx_adapter

[PATCH v6 4/7] eventdev/eth_tx: add instance get API

2022-06-08 Thread Ganapati Kundapura
Added rte_event_eth_tx_adapter_instance_get() to get the adapter instance id for specified ethernet device id and tx queue index. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c index 1b304f0..d9de6e5 100644 --- a/

[PATCH v6 3/7] test/eth_rx: add test case for instance get API

2022-06-08 Thread Ganapati Kundapura
Added test case for rte_event_eth_rx_adapter_instance_get() Signed-off-by: Ganapati Kundapura diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c index e358a70..878004b 100644 --- a/app/test/test_event_eth_rx_adapter.c +++ b/app/test/test_event_eth_rx_adapte

[PATCH v6 2/7] eventdev/eth_rx: add telemetry callback for instance get

2022-06-08 Thread Ganapati Kundapura
Added telemetry handler for rte_event_eth_rx_adapter_instance_get() to retrieve adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index d1b4874

[PATCH v6 1/7] eventdev/eth_rx: add adapter instance get API

2022-06-08 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() to get adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura --- v6: * rx adapter changes removed from patch4 and moved to patch1 v5: * patch is split into saperate patches v4: * Moved instance ar

[PATCH v5 2/2] kni: fix warning about discarding const qualifier

2022-06-08 Thread Andrew Rybchenko
From: Ke Zhang The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const intentionally in v5.17 to prevent using it directly. See kernel series [1] for more information. [1] https://lore.kernel.org/netdev/YZYAb4

[PATCH v5 1/2] kni: use dedicated function to set random MAC address

2022-06-08 Thread Andrew Rybchenko
From: Ke Zhang eth_hw_addr_random() sets address type correctly. eth_hw_addr_random() is available since Linux v3.4, so no compat is required. Also fix the warning: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const inten

[PATCH v5 0/2] kni: fix build warnings with Linux 5.17+

2022-06-08 Thread Andrew Rybchenko
v5: - fix broken build v4: - restore original patch author - resend with cover letter to address patchwork recognition as a series v3: - split single patch into two - clarify patches summary and description Ke Zhang (2): kni: use dedicated function to set random MAC a

Re: [PATCH v3 1/1] app/testpmd: support different input color method

2022-06-08 Thread Andrew Rybchenko
On 6/3/22 16:06, sk...@marvell.com wrote: From: Sunil Kumar Kori To enable input coloring, based on VLAN or DSCP, patch adds command line interface to configure the following: - configuring input coloring using VLAN or DSCP while creating meter i.e. during rte_mtr_create() - Update VL

Re: [PATCH v3] app/testpmd: fix issue with memory leaks when quit testpmd

2022-06-08 Thread Ferruh Yigit
On 4/4/2022 4:34 PM, Zhang, Yuying wrote: Hi Ke, -Original Message- From: Zhang, Ke1X Sent: Friday, March 25, 2022 4:36 PM To: Li, Xiaoyun ; Singh, Aman Deep ; Zhang, Yuying ; dev@dpdk.org Cc: Zhang, Ke1X Subject: [PATCH v3] app/testpmd: fix issue with memory leaks when quit testpmd

RE: [PATCH v3] sched: enable CMAN at runtime

2022-06-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Danilewicz, MarcinX > Sent: Wednesday, June 8, 2022 10:42 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v3] sched: enable CMAN at runtime > > Added changes to enable CMAN (RED or PIE) at init > from

[PATCH 2/2] common/mlx5: update log format after devx_obj_create error

2022-06-08 Thread Gregory Etelson
Application can fetch syndrome value after FW operation failure starting from Mellanox OFED-5.6. The patch updates log data after devx_obj_create error. Signed-off-by: Gregory Etelson Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 77 ++-- 1 file change

[PATCH 1/2] common/mlx5: update log format after devx_general_cmd error

2022-06-08 Thread Gregory Etelson
Application can fetch syndrome value after FW operation failure starting from Mellanox OFED-5.6. The patch updates log data issued after devx_general_cmd error. Signed-off-by: Gregory Etelson Acked-by: Matan Azrad --- drivers/common/mlx5/mlx5_devx_cmds.c | 103 --- 1 fil

[PATCH v2] eal: remove unused arch specific headers for locks

2022-06-08 Thread David Marchand
MCS lock, PF lock and Ticket lock have no arch specific implementation, there is no need for the extra redirection in headers. Signed-off-by: David Marchand Acked-by: Stephen Hemminger --- Note: this was mentionned during the seqlock patch review, and I spotted it again, while reviewing the RISC

RE: [PATCH v3 0/7] ethdev: separate metering and marking from policing

2022-06-08 Thread Dumitrescu, Cristian
> -Original Message- > From: Alexander Kozyrev > Sent: Wednesday, June 1, 2022 4:44 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; > jerinjac...@gmail.com; or...@nvidia.com; tho...@monjalon.net; > ivan.ma...@oktetlabs.ru; andrew.rybche...@oktetlabs.ru; > ferruh.yi...@xilinx.com; Awa

Re: [PATCH] app/testpmd: fix packets segments allocation

2022-06-08 Thread Andrew Rybchenko
On 6/2/22 15:59, Raja Zidane wrote: When --mbuf-size cmdln parameter is specified, the segments to scatter packets on are allocated sequentially from these extra memory pools (the mbuf for the first segment is allocated from the first pool, the second one from the second pool, and so on, if segme

RE: [PATCH v3] eventdev: add adapter instance get API

2022-06-08 Thread Kundapura, Ganapati
Hi Jay, Patch is split into 7 patch sets in V5 as suggested. Thanks, Ganapati > -Original Message- > From: Jayatheerthan, Jay > Sent: 07 June 2022 18:49 > To: Kundapura, Ganapati ; > jerinjac...@gmail.com; dev@dpdk.org > Subject: RE: [PATCH v3] eventdev: add adapter instance get API >

RE: [PATCH v4] eventdev: add adapter instance get API

2022-06-08 Thread Kundapura, Ganapati
Hi Harish, > -Original Message- > From: Naga Harish K, S V > Sent: 08 June 2022 09:57 > To: Kundapura, Ganapati ; > jerinjac...@gmail.com; dev@dpdk.org; Jayatheerthan, Jay > > Subject: RE: [PATCH v4] eventdev: add adapter instance get API > > Hi Ganapati, >Some comments inline. > >

Re: [PATCH v2 06/11] net/hns3: fix coverity codecheck

2022-06-08 Thread Andrew Rybchenko
Hi Dongdong, On 6/6/22 10:48, Dongdong Liu wrote: Hi Andrew Many thanks for your review. I will take over Hu Min's current work and continue to do the upstream work. On 2022/6/1 16:32, Andrew Rybchenko wrote: On 6/1/22 06:52, Min Hu (Connor) wrote: In bitwise operation, "val" should be an

[PATCH v5 5/7] test/eth_tx: add testcase for instance get API

2022-06-08 Thread Ganapati Kundapura
Added testcase for rte_event_eth_tx_adapter_instance_get() Signed-off-by: Ganapati Kundapura diff --git a/app/test/test_event_eth_tx_adapter.c b/app/test/test_event_eth_tx_adapter.c index 2900532..ebbc622 100644 --- a/app/test/test_event_eth_tx_adapter.c +++ b/app/test/test_event_eth_tx_adapter

[PATCH v5 6/7] doc/eth_rx: update instance get API

2022-06-08 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() details Signed-off-by: Ganapati Kundapura diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst index 3b4ef50..5b9d0cf 100644 --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst

[PATCH v5 7/7] doc/eth_tx: update instance get API

2022-06-08 Thread Ganapati Kundapura
Added rte_event_eth_tx_adapter_instance_get() details. Signed-off-by: Ganapati Kundapura diff --git a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst b/doc/guides/prog_guide/event_ethernet_tx_adapter.rst index f80d226..dc3e6a1 100644 --- a/doc/guides/prog_guide/event_ethernet_tx_adapter.rst

[PATCH v5 4/7] eventdev/eth_tx: add instance get API

2022-06-08 Thread Ganapati Kundapura
Added rte_event_eth_tx_adapter_instance_get() to get the adapter instance id for specified ethernet device id and tx queue index. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h index f56938d..45140a6 100644 --- a/

[PATCH v5 3/7] test/eth_rx: add test case for instance get API

2022-06-08 Thread Ganapati Kundapura
Added test case for rte_event_eth_rx_adapter_instance_get() Signed-off-by: Ganapati Kundapura diff --git a/app/test/test_event_eth_rx_adapter.c b/app/test/test_event_eth_rx_adapter.c index e358a70..878004b 100644 --- a/app/test/test_event_eth_rx_adapter.c +++ b/app/test/test_event_eth_rx_adapte

[PATCH v5 2/7] eventdev/eth_rx: add telemetry callback for instance get

2022-06-08 Thread Ganapati Kundapura
Added telemetry handler for rte_event_eth_rx_adapter_instance_get() to retrieve adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index d1b4874

[PATCH v5 1/7] eventdev/eth_rx: add adapter instance get API

2022-06-08 Thread Ganapati Kundapura
Added rte_event_eth_rx_adapter_instance_get() to get adapter instance id for specified ethernet device id and rx queue index. Signed-off-by: Ganapati Kundapura diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index bf8741d..d1b4874 100644 --- a/lib/

[PATCH v4 2/2] kni: fix warning about discarding const qualifier

2022-06-08 Thread Andrew Rybchenko
From: Ke Zhang The warning info: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const intentionally in v5.17 to prevent using it directly. See kernel series [1] for more information. [1] https://lore.kernel.org/netdev/YZYAb4

[PATCH v4 1/2] kni: use dedicated function to set random MAC address

2022-06-08 Thread Andrew Rybchenko
From: Ke Zhang eth_hw_addr_random() sets address type correctly. eth_hw_addr_random() is available since Linux v3.4, so no compat is required. Also fix the warning: warning: passing argument 1 of ‘memcpy’ discards ‘const’ qualifier from pointer target type Variable dev_addr is done const inten

[PATCH v4 0/2] kni: fix build warnings with Linux 5.17+

2022-06-08 Thread Andrew Rybchenko
v4: - restore original patch author - resend with cover letter to address patchwork recognition as a series v3: - split single patch into two - clarify patches summary and description Ke Zhang (2): kni: use dedicated function to set random MAC address kni: fix warning ab

Re: [PATCH] Fix RISC-V builds

2022-06-08 Thread Heinrich Schuchardt
On 6/8/22 12:01, David Marchand wrote: On Wed, Jun 8, 2022 at 11:56 AM Heinrich Schuchardt wrote: @Keith Maybe CONTRIBUTING.txt in that package should suggest a title prefix for PktGen patches to avoid future confusion. Yes, and I marked the patch as Not applicable in patchwork. See https:

Re: [PATCH] eal: fix segment fault when exit trace

2022-06-08 Thread Jerin Jacob
On Tue, Jun 7, 2022 at 5:36 PM Chengwen Feng wrote: > > Bug scenario: > 1. start testpmd: > dpdk-testpmd -l 4-6 -a :7d:00.0 --trace=.* -- -i > 2. quit testpmd and then observed segment fault: > Bye... > Segmentation fault (core dumped) > > The root cause is that rte_tra

Re: [PATCH v3 1/4] ethdev: introduce ethdev HW desc dump PI

2022-06-08 Thread Andrew Rybchenko
Cc various driver maintainers looking for opinion about API discussion below On 6/7/22 16:59, Dongdong Liu wrote: Hi Andrew Many thanks for your review. On 2022/6/2 3:53, Andrew Rybchenko wrote: On 6/1/22 10:49, Min Hu (Connor) wrote: Added the ethdev HW Rx desc dump API which provides funct

Re: [PATCH] Fix RISC-V builds

2022-06-08 Thread David Marchand
On Wed, Jun 8, 2022 at 11:56 AM Heinrich Schuchardt wrote: > > On 6/8/22 09:23, David Marchand wrote: > > Hello, > > > > On Mon, May 30, 2022 at 4:11 PM Heinrich Schuchardt > > wrote: > >> > >> Building on RISC-V results in an error > >> > >> cc: error: ‘-march=native’: ISA string must begin

[PATCH v4] gro: bug fix in identifying fragmented packets

2022-06-08 Thread Kumara Parameshwaran
From: Kumara Parameshwaran A packet with RTE_PTYPE_L4_FRAG(0x300) contains both RTE_PTYPE_L4_TCP (0x100) & RTE_PTYPE_L4_UDP (0x200). A fragmented packet as defined in rte_mbuf_ptype.h cannot be recognized as other L4 types and hence the GRO layer should not use IS_IPV4_TCP_PKT or IS_IPV4_UDP_PKT

Re: [PATCH] Fix RISC-V builds

2022-06-08 Thread Heinrich Schuchardt
On 6/8/22 09:23, David Marchand wrote: Hello, On Mon, May 30, 2022 at 4:11 PM Heinrich Schuchardt wrote: Building on RISC-V results in an error cc: error: ‘-march=native’: ISA string must begin with rv32 or rv64 As GCC does not support -march=native on RISC-V avoid this argument. Sign

Re: [PATCH v4 0/8] Introduce support for RISC-V architecture

2022-06-08 Thread Heinrich Schuchardt
On 6/8/22 10:41, David Marchand wrote: On Tue, May 31, 2022 at 4:14 PM Stanislaw Kardach wrote: This patchset adds support for building and running DPDK on 64bit RISC-V architecture. The initial support targets rv64gc (rv64imafdc) ISA and was tested on SiFive Unmatched development board with t

  1   2   >