[PATCH v4 12/12] cryptodev: add salt length and optional label

2022-05-30 Thread Arek Kusztal
- Added salt length and optional label. Common parameters to PSS and OAEP padding for RSA. - Changed RSA hash padding fields names. Now it corresponds to the RSA documents. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 19 +-- 1 file changed, 17 insertions(+),

[PATCH v4 11/12] cryptodev: clarify rsa verify with none padding

2022-05-30 Thread Arek Kusztal
- Clarified where should output be stored of signature decryption with padding none. PMD is not able to know what padding algorithm was used, therefore decrypted signature should be returned to the user. - Removed incorrect big-endian constraints. Not all data in RSA can be treated as big endian in

[PATCH v4 10/12] cryptodev: move RSA padding into separate struct

2022-05-30 Thread Arek Kusztal
- move RSA padding into separate struct. More padding members should be added into padding, therefore having separate struct for padding parameters will make this more readable. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 10 ++-- drivers/common/cpt/cpt_ucode_as

[PATCH v4 09/12] cryptodev: clarify usage of rsa padding hash

2022-05-30 Thread Arek Kusztal
- Clarified usage of RSA padding hash. It was not specified how to use hash for PKCS1_5 padding. This could lead to incorrect implementation. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --g

[PATCH v4 08/12] cryptodev: add asym op flags

2022-05-30 Thread Arek Kusztal
- Added flags to rte_crypto_asym_op struct. It may be shared between different algorithms. - Added Diffie-Hellman padding flags. Diffie-Hellman padding is used in certain protocols, in others, leading zero bytes need to be stripped. Even same protocol may use a different approach - most glaring exa

[PATCH v4 07/12] cryptodev: add public key verify option

2022-05-30 Thread Arek Kusztal
- Added key exchange public key verify option. For some elliptic curves public point in DH exchange needs to be checked, if it lays on the curve. Modular exponentiation needs certain checks as well, though mathematically much easier. This commit adds verify option to asym_op operations. Signed-off

[PATCH v4 06/12] cryptodev: add elliptic curve diffie hellman

2022-05-30 Thread Arek Kusztal
- Added elliptic curve Diffie-Hellman parameters. Point multiplication allows the user to process every phase of ECDH, but for phase 1, user should not really care about the generator. The user does not even need to know what the generator looks like, therefore setting ec xform would make this work

[PATCH v4 05/12] cryptodev: move dh type from xform to dh op

2022-05-30 Thread Arek Kusztal
- Moved dh operation type to dh operation struct. Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should be free to choose for any operation. One xform/session should be enough to perform both DH operations, if op_type would be xform member, session would have to be to be created twice for th

[PATCH v4 04/12] cryptodev: clarify usage of private key in dh

2022-05-30 Thread Arek Kusztal
- Clarified usage of private key in Diffie-Hellman. CSRNG capable device should generate private key and then use it for public key generation. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/cryptodev/rte_crypto_asym.h

[PATCH v4 03/12] cryptodev: remove comment about using ephemeral key in dsa

2022-05-30 Thread Arek Kusztal
- Removed comment that stated DSA can be used with Diffie Hellman ephemeral key. DH and DSA integration allowed to use ephemeral keys for random integer, but not for private keys. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 8 +--- 1 file changed, 1 insertion(+), 7 dele

[PATCH v4 02/12] cryptodev: separate key exchange operation enum

2022-05-30 Thread Arek Kusztal
- Separated key exchange enum from asym op type. Key exchange and asymmetric crypto operations like signatures, encryption/decryption should not share same operation enum as its use cases are unrelated and mutually exclusive. Therefore op_type was separate into: 1) operation type 2) key exchange op

[PATCH v4 01/12] cryptodev: redefine ec group enum

2022-05-30 Thread Arek Kusztal
- EC enum was renamed to rte_crypto_curve_id. Elliptic curve enum name was incorrectly associated with a group (it comes from the current tls registry name). - Clarified comments about TLS deprecation. Some curves included are deprecated with TLS 1.3. Comments to address it were added. - Clarified

[PATCH v4 00/12] cryptodev: rsa, dh, ecdh changes

2022-05-30 Thread Arek Kusztal
This patchset introduces some of changes discussed on mailing list for 22.07 release in cryptodev asym. Key changes: - It fixes API for RSA (expescially signature paddings) - Adds Elliptic-Curve Diffie-Hellman - Adds Eliiptic-Curve point verification - Adds RSA missing padding fields - Adds asym

[PATCH] common/mlx5: fix list unused lcore check

2022-05-30 Thread Suanming Mou
While non-lcore list operations were supported, non-lcore index will be converted to MLX5_LIST_NLCORE. In that case, no need to check the lcore index be -1 or not anymore. This commit removes the unused lcore check in list. Fixes: 7e1cf892711b ("common/mlx5: support list non-lcore operations") Cc

RE: [PATCH v4 5/5] guides/rawdevs: add description of ofs in ifpga doc

2022-05-30 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Friday, May 27, 2022 4:34 PM > To: dev@dpdk.org; tho...@monjalon.net; nipun.gu...@nxp.com; > hemant.agra...@nxp.com > Cc: sta...@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v4 5/5] guides/rawdevs:

Re: [PATCH v2 0/2] ACL fix 8B field

2022-05-30 Thread Thomas Monjalon
> Konstantin Ananyev (2): > acl: fix rules with 8 bytes field size are broken > app/acl: support different formats for IPv6 address Applied, thanks.

RE: [PATCH v9] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, Comments inline below. > diff --git a/lib/sched/rte_sched.h b/lib/sched/rte_sched.h > index 5ece64e527..317ab3b68e 100644 > --- a/lib/sched/rte_sched.h > +++ b/lib/sched/rte_sched.h > @@ -579,6 +579,24 @@ rte_sched_port_enqueue(struct rte_sched_port > *port, struct rte_mbuf **pkts, uin

Re: [PATCH v3 1/2] lpm: add const to lpm arg of rte_lpm_lookup

2022-05-30 Thread Stephen Hemminger
On Mon, 30 May 2022 20:24:36 +0200 Stanislaw Kardach wrote: > All other rte_lpm_lookup* functions take lpm argument as a const. As the > basic rte_lpm_lookup() performs the same function, it should also do > that. > > As this function is inline, no API/ABI change happens. > > Signed-off-by: Sta

Re: [dpdk-dev] [RFC PATCH] ethdev: support congestion management

2022-05-30 Thread Ajit Khaparde
On Mon, May 30, 2022 at 6:16 AM wrote: > > From: Jerin Jacob > > NIC HW controllers often come with congestion management support on > various HW objects such as Rx queue depth or mempool queue depth. > > Also, it can support various modes of operation such as RED > (Random early discard), WRED e

[PATCH v9] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Marcin Danilewicz
Added new API for flag to enable or disable TC oversubscription for best effort traffic class at subport level. By default TC OV is enabled. Signed-off-by: Marcin Danilewicz --- History: - v1 - TC OV disabled by default - v2 - throughput improvements - v3, v4, v5 - changes from comments - v6 -

[PATCH v3 2/2] lpm: add a scalar version of lookupx4 function

2022-05-30 Thread Stanislaw Kardach
From: Michal Mazurek Add an implementation of the rte_lpm_lookupx4() function for platforms without support for vector operations. This will be useful in the upcoming RISC-V port as well as any platform which may want to start with a basic level of LPM support. Signed-off-by: Michal Mazurek Si

[PATCH v3 1/2] lpm: add const to lpm arg of rte_lpm_lookup

2022-05-30 Thread Stanislaw Kardach
All other rte_lpm_lookup* functions take lpm argument as a const. As the basic rte_lpm_lookup() performs the same function, it should also do that. As this function is inline, no API/ABI change happens. Signed-off-by: Stanislaw Kardach --- lib/lpm/rte_lpm.h | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH v3] pcap: support MTU set

2022-05-30 Thread Ferruh Yigit
On 5/30/2022 11:36 AM, Ido Goshen wrote: Support rte_eth_dev_set_mtu by pcap vdevs Enforce mtu on rx/tx Still not sure about enforcing MTU on pcap, but please find comments on mechanical issues Bugzilla ID: 961 Signed-off-by: Ido Goshen --- v3: Preserve pcap behavior to support max size

RE: [EXT] [PATCH v3 00/12] cryptodev: rsa, dh, ecdh changes

2022-05-30 Thread Akhil Goyal
> This patchset introduces some of changes discussed on mailing list for 22.07 > release in cryptodev asym. > > Key changes: > > - It fixes API for RSA (expescially signature paddings) > - Adds Elliptic-Curve Diffie-Hellman > - Adds Eliiptic-Curve point verification > - Adds RSA missing padding f

Re: [RFC 1/2] ethdev: port flags for pre-configuration flow hints

2022-05-30 Thread Thomas Monjalon
We were waiting for a v2 of this patch. More comments below. 07/04/2022 07:30, Xiaoyu Min: > The data-path focused flow rule management can manage flow rules in more > optimized way then tranditional one by using hits provided by hits -> hints > application in initialization phase. > > In addit

Re: [RFC 2/2] ethdev: queue-based flow aged report

2022-05-30 Thread Thomas Monjalon
07/04/2022 07:30, Xiaoyu Min: > When application use queue-based flow management and operate the same > flow on the same queue, e.g create/destroy/query, API for querying aged > flows should also with queue id parameter just like other queue-based > flow APIs. A verb is missing, I am not sure to u

Re: [PATCH v3] lib/eal: fix segfaults due to thread exit order

2022-05-30 Thread Stephen Hemminger
On Mon, 30 May 2022 13:47:38 + zhichaox.z...@intel.com wrote: > @@ -883,6 +896,8 @@ rte_eal_init(int argc, char **argv) > > eal_mcfg_complete(); > > + pthread_atfork(NULL, warn_parent, scratch_child); > + > return fctret; > } There are lots of other cases where DPDK will

Re: [PATCH v3] lib/eal: fix segfaults due to thread exit order

2022-05-30 Thread Stephen Hemminger
On Mon, 30 May 2022 13:47:38 + zhichaox.z...@intel.com wrote: > +static void warn_parent(void) > +{ > + RTE_LOG(WARNING, EAL, "fork() was called, DPDK won't work in the child " > + "process unless it calls rte_eal_init()\n"); > +} > + Too wordy. Don't break messages across lin

[PATCH] doc/compressdev: fix grammar and formatting

2022-05-30 Thread Ciara Power
Small improvements made to the compressdev programmer's guide. This includes rephrasing some sentences, fixing grammar, and aligning formatting. Fixes: a584d3bea902 ("doc: add compressdev library guide") Fixes: f7095d41bba6 ("doc: clarify data plane error handling in compressdev") Cc: ashish.gu...

[v9, 10/10] doc: add notes about acvp validation support

2022-05-30 Thread Gowrishankar Muthukrishnan
Add notes on algorithms supported for ACVP validation. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/sample_app_ug/fips_validation.rst | 30 +++- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/doc/guides/sample_app_ug/fips_validation.rst b/doc/guides/s

[v9, 09/10] examples/fips_validation: add parsing for aes_cbc

2022-05-30 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for AES_CBC test. Signed-off-by: Gowrishankar Muthukrishnan -- v6: * fixed local variable initialization in fips_mct_aes_test. --- examples/fips_validation/fips_validation.c| 8 +- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/

[v9, 08/10] examples/fips_validation: add parsing for cmac

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added function to parse algorithm for CMAC test. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan -- v5: * parser_read_cmac_direction_str implementation moved to static. --- examples/fips_validation/fips_validation.c | 19 --- examples/fips_

[v9, 07/10] examples/fips_validation: implement json cmac test

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Implemented JSON support for the CMAC test. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan --- v5: * parser_read_cmac_direction_str is static. --- examples/fips_validation/fips_validation.h| 3 + .../fips_validation/fips_validation_cmac.c| 80 +++

[v9, 06/10] examples/fips_validation: add json to hmac

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Adds JSON support for the HMAC algorithm. Signed-off-by: Brandon Lo Acked-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 6 ++ .../fips_validation/fips_validation_hmac.c| 93 +++

[v9, 05/10] examples/fips_validation: add json to gcm test

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Adds json-specific testing and writeback function. Allows the user to test AES-GCM vector sets. Signed-off-by: Brandon Lo Acked-by: Gowrishankar Muthukrishnan --- v8: * reset IV generation var in every test group as initialization. v3: * fix checkpatch warnings --- examples/

[v9, 04/10] examples/fips_validation: allow json file as input

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added the ability to use the json format as the input and output of the example application. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan -- v8: * dont steal refcount on write_set using _new as latter is updated subsequently in same function. * fix fip

[v9, 03/10] examples/fips_validation: add json parsing

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added functions to parse the required information from a vector set given in the new json format. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan --- v7: * pulled json_info define from next patch. v3: * fix checkpatch warnings v2: * fix for loop initializ

[v9, 02/10] examples/fips_validation: add json info to header

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added json-specific functions and other information needed to test the new FIPS test vectors. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan --- v7: * fix switch clause for info.file_type. v5: * fix typo in macro name for prefixes. v2: * fix type of pref

[v9, 01/10] examples/fips_validation: add jansson dependency

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added a check for RTE_HAS_JANSSON into the meson configuration file for JSON support. Signed-off-by: Brandon Lo Acked-by: Gowrishankar Muthukrishnan --- examples/fips_validation/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/meson

[v9, 00/10] Add JSON vector set support to fips validation

2022-05-30 Thread Gowrishankar Muthukrishnan
Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format. v9: * doc update. v8: * Fixed

[PATCH v3 12/12] cryptodev: add salt length and optional label

2022-05-30 Thread Arek Kusztal
- Added salt length and optional label. Common parameters to PSS and OAEP padding for RSA. - Changed RSA hash padding fields names. Now it corresponds to the RSA documents. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 19 +-- 1 file changed, 17 insertions(+),

[PATCH v3 11/12] cryptodev: clarify rsa verify with none padding

2022-05-30 Thread Arek Kusztal
- Clarified where should output be stored of signature decryption with padding none. PMD is not able to know what padding algorithm was used, therefore decrypted signature should be returned to the user. - Removed incorrect big-endian constraints. Not all data in RSA can be treated as big endian in

[PATCH v3 10/12] cryptodev: move RSA padding into separate struct

2022-05-30 Thread Arek Kusztal
- move RSA padding into separate struct. More padding members should be added into padding, therefore having separate struct for padding parameters will make this more readable. Signed-off-by: Arek Kusztal --- app/test/test_cryptodev_asym.c | 10 ++-- drivers/common/cpt/cpt_ucode_as

[PATCH v3 09/12] cryptodev: clarify usage of rsa padding hash

2022-05-30 Thread Arek Kusztal
- Clarified usage of RSA padding hash. It was not specified how to use hash for PKCS1_5 padding. This could lead to incorrect implementation. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --g

[PATCH v3 08/12] cryptodev: add asym op flags

2022-05-30 Thread Arek Kusztal
- Added flags to rte_crypto_asym_op struct. It may be shared between different algorithms. - Added Diffie-Hellman padding flags. Diffie-Hellman padding is used in certain protocols, in others, leading zero bytes need to be stripped. Even same protocol may use a different approach - most glaring exa

[PATCH v3 07/12] cryptodev: add public key verify option

2022-05-30 Thread Arek Kusztal
- Added key exchange public key verify option. For some elliptic curves public point in DH exchange needs to be checked, if it lays on the curve. Modular exponentiation needs certain checks as well, though mathematically much easier. This commit adds verify option to asym_op operations. Signed-off

[PATCH v3 06/12] cryptodev: add elliptic curve diffie hellman

2022-05-30 Thread Arek Kusztal
- Added elliptic curve Diffie-Hellman parameters. Point multiplication allows the user to process every phase of ECDH, but for phase 1, user should not really care about the generator. The user does not even need to know what the generator looks like, therefore setting ec xform would make this work

[PATCH v3 05/12] cryptodev: move dh type from xform to dh op

2022-05-30 Thread Arek Kusztal
- Moved dh operation type to dh operation struct. Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should be free to choose for any operation. One xform/session should be enough to perform both DH operations, if op_type would be xform member, session would have to be to be created twice for th

[PATCH v3 04/12] cryptodev: clarify usage of private key in dh

2022-05-30 Thread Arek Kusztal
- Clarified usage of private key in Diffie-Hellman. CSRNG capable device should generate private key and then use it for public key generation. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 5 + 1 file changed, 5 insertions(+) diff --git a/lib/cryptodev/rte_crypto_asym.h

[PATCH v3 03/12] cryptodev: remove comment about using ephemeral key in dsa

2022-05-30 Thread Arek Kusztal
- Removed comment that stated DSA can be used with Diffie Hellman ephemeral key. DH and DSA integration allowed to use ephemeral keys for random integer, but not for private keys. Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 8 +--- 1 file changed, 1 insertion(+), 7 dele

[PATCH v3 02/12] cryptodev: separate key exchange operation enum

2022-05-30 Thread Arek Kusztal
- Separated key exchange enum from asym op type. Key exchange and asymmetric crypto operations like signatures, encryption/decryption should not share same operation enum as its use cases are unrelated and mutually exclusive. Therefore op_type was separate into: 1) operation type 2) key exchange op

[PATCH v3 01/12] cryptodev: redefine ec group enum

2022-05-30 Thread Arek Kusztal
- EC enum was renamed to rte_crypto_curve_id. Elliptic curve enum name was incorrectly associated with a group (it comes from the current tls registry name). - Clarified comments about TLS deprecation. Some curves included are deprecated with TLS 1.3. Comments to address it were added. - Clarified

[PATCH v3 00/12] cryptodev: rsa, dh, ecdh changes

2022-05-30 Thread Arek Kusztal
This patchset introduces some of changes discussed on mailing list for 22.07 release in cryptodev asym. Key changes: - It fixes API for RSA (expescially signature paddings) - Adds Elliptic-Curve Diffie-Hellman - Adds Eliiptic-Curve point verification - Adds RSA missing padding fields - Adds asym

RE: [PATCH 1/3] ixgbe: make link update thread periodic

2022-05-30 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, May 30, 2022 10:21 PM > To: Daly, Jeff ; dev@dpdk.org; Yang, Qiming > ; Wu, Wenjun1 > Cc: Stephen Douthit > Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic > > > > > -Original Message- > > From: Jeff D

RE: [PATCH 1/3] ixgbe: make link update thread periodic

2022-05-30 Thread Zhang, Qi Z
> -Original Message- > From: Jeff Daly > Sent: Monday, May 30, 2022 9:47 PM > To: Zhang, Qi Z ; dev@dpdk.org; Yang, Qiming > ; Wu, Wenjun1 > Cc: Stephen Douthit > Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic > > > > > -Original Message- > > From: Zhang, Q

[PATCH] Fix RISC-V builds

2022-05-30 Thread Heinrich Schuchardt
Building on RISC-V results in an error cc: error: ‘-march=native’: ISA string must begin with rv32 or rv64 As GCC does not support -march=native on RISC-V avoid this argument. Signed-off-by: Heinrich Schuchardt --- meson.build | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Danilewicz, MarcinX
Hi Cristian, > Nope, it looks like we have a misunderstanding here. Looking back at my > comments from V3: What I meant is that the configuration values related to > this feature (all the tc_ov configuration values) should be computed at > initialization regardless of whether this feature is enabl

RE: [PATCH v2] sched: enable CMAN at runtime

2022-05-30 Thread Danilewicz, MarcinX
Hi Cristian, > Can you please explain why you need to add the new > RTE_SCHED_CMAN_NONE value to this enumeration and what is the ABI > breakage that you are trying to avoid? > > The library expects the struct rte_sched_subport_params:: cman_params to > be NULL when the CMAN is disabled, why i

Hang in ixgbe_dev_link_update_share()

2022-05-30 Thread Lewis Donzis
Using DPDK 21.11.1 on FreeBSD 13.1, calling rte_eth_link_get_nowait() appears to hang waiting for the link to come up on an XL710 or 82599 based NIC. This call eventually makes its way to ixgbe_dev_link_update_share() with wait_to_complete set to false. Inside that function, there is this code:

RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, > > > > Still only changes in rte_sched.c and no change in rte_sched.h for the API > to > > configure this feature? > > Yes, because you said to remove whole > rte_sched_subport_tc_ov_config(struct rte_sched_port *port, > uint32_t subport_id, > bool tc_ov_enable) > here

RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-05-30 Thread Zhang, Qi Z
> -Original Message- > From: Jeff Daly > Sent: Monday, May 30, 2022 9:33 PM > To: Zhang, Qi Z ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices > > > > > -Original Message-

RE: [PATCH 1/3] ixgbe: make link update thread periodic

2022-05-30 Thread Jeff Daly
> -Original Message- > From: Zhang, Qi Z > Sent: Sunday, May 29, 2022 7:25 PM > To: Jeff Daly ; dev@dpdk.org; Yang, Qiming > ; Wu, Wenjun1 > Cc: Stephen Douthit > Subject: RE: [PATCH 1/3] ixgbe: make link update thread periodic > > Caution: This is an external email. Please take care

[PATCH] app/test: add event inline security tests

2022-05-30 Thread Volodymyr Fialko
Enable ability to run inline security tests using event API(rte_event_eth_tx_adapter_enqueue/rte_event_dequeue_burst). New test command - event_inline_ipsec_autotest will run same list of test cases as inline_ipsec_autotest, but packets will go through eventdev. Signed-off-by: Volodymyr Fialko --

[PATCH v8] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Marcin Danilewicz
Added new flag to enable or disable TC oversubscription for best effort traffic class at subport level. By default TC OV is disabled. Signed-off-by: Marcin Danilewicz --- History: - v1 - TC OV disabled by default - v2 - throughput improvements - v3, v4, v5 - changes from comments - v6 - removed

RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Danilewicz, MarcinX
Hi Cristian, Please find inline answers: > > History: > > - v1 - TC OV disabled by default > > - v2 - throughput improvements > > - v3, v4, v5 - changes from comments > > - v6 - removed rte_sched_subport_tc_ov_config declaration and map > > - v7 - changes from comments on v6 > > I see you moved

RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-05-30 Thread Jeff Daly
> -Original Message- > From: Zhang, Qi Z > Sent: Sunday, May 29, 2022 6:49 PM > To: Jeff Daly ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH v2] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 > devices > > Caution: This is an external email

RE: [PATCH] net/iavf: remove unimplemented function call

2022-05-30 Thread Zhang, Qi Z
> -Original Message- > From: Nicolau, Radu > Sent: Monday, May 30, 2022 8:49 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: Re: [PATCH] net/iavf: remove unimplemented function call > > > On 5/30/2022 12:36 PM, Qi Zhang wrote: > > Remove unimplemented function call

[PATCH] event/cnxk: add free for Tx adapter

2022-05-30 Thread Volodymyr Fialko
Tx adapter allocate data during eth_tx_adapter_queue_add() call and it's only cleaned but not freed during eth_tx_adapter_queue_del(). Implemented eth_tx_adapter_free() callback to free adapter data. Signed-off-by: Volodymyr Fialko --- drivers/event/cnxk/cn10k_eventdev.c | 3 +++ drivers/e

[dpdk-dev] [RFC PATCH] ethdev: support congestion management

2022-05-30 Thread jerinj
From: Jerin Jacob NIC HW controllers often come with congestion management support on various HW objects such as Rx queue depth or mempool queue depth. Also, it can support various modes of operation such as RED (Random early discard), WRED etc on those HW objects. This patch adds a framework t

Re: FreeBSD 13.1 changes

2022-05-30 Thread Bruce Richardson
On Mon, May 30, 2022 at 07:50:19AM -0500, Lewis Donzis wrote: > > > - On May 30, 2022, at 3:09 AM, Bruce Richardson > bruce.richard...@intel.com wrote: > > > On Sun, May 29, 2022 at 06:36:21AM -0500, Lewis Donzis wrote: > >> Apparently FreeBSD 13.1 changed the syntax of the CPUSET macros, s

Re: [PATCH 1/3] app/testpmd: fix displaying RSS info

2022-05-30 Thread Ferruh Yigit
On 5/30/2022 1:32 PM, lihuisong (C) wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. 在 2022/5/30 18:43, Ferruh Yigit 写道: On 5/27/2022 3:30 AM, lihuisong (C) wrote

[PATCH] event/cnxk: add free for Tx adapter

2022-05-30 Thread Volodymyr Fialko
Tx adapter allocate data during eth_tx_adapter_queue_add() call and it's only cleaned but not freed during eth_tx_adapter_queue_del(). Implemented eth_tx_adapter_free() callback to free adapter data. Signed-off-by: Volodymyr Fialko Change-Id: I72480c5ac8a65688aa790d4ad66a2f5b0c3148a9 --- drivers

Re: FreeBSD 13.1 changes

2022-05-30 Thread Lewis Donzis
- On May 30, 2022, at 3:09 AM, Bruce Richardson bruce.richard...@intel.com wrote: > On Sun, May 29, 2022 at 06:36:21AM -0500, Lewis Donzis wrote: >> Apparently FreeBSD 13.1 changed the syntax of the CPUSET macros, so DPDK no >> longer compiles. >> >> For example, here's one definition on

Re: [PATCH] net/iavf: remove unimplemented function call

2022-05-30 Thread Nicolau, Radu
On 5/30/2022 12:36 PM, Qi Zhang wrote: Remove unimplemented function call be wrapped by RTE_LIBRTE_IAVF_DEBUG_TX_DESC_RING Fixes: 1e728b01120c ("net/iavf: rework Tx path") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- Acked-by: Radu Nicolau

Re: [PATCH v2 2/2] lpm: add a scalar version of lookupx4 function

2022-05-30 Thread Bruce Richardson
On Mon, May 30, 2022 at 01:20:50PM +0200, Stanisław Kardach wrote: > On Mon, May 30, 2022 at 12:42 PM Bruce Richardson > wrote: > > > > On Mon, May 30, 2022 at 10:00:34AM +0200, Morten Brørup wrote: > > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > > Sent: Monday, 30 May 202

[v8, 10/10] doc: add notes about acvp validation support

2022-05-30 Thread Gowrishankar Muthukrishnan
Add notes on algorithms supported for ACVP validation. Signed-off-by: Gowrishankar Muthukrishnan --- doc/guides/sample_app_ug/fips_validation.rst | 30 +++- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/doc/guides/sample_app_ug/fips_validation.rst b/doc/guides/s

[v8, 09/10] examples/fips_validation: add parsing for aes_cbc

2022-05-30 Thread Gowrishankar Muthukrishnan
Added function to parse algorithm for AES_CBC test. Signed-off-by: Gowrishankar Muthukrishnan -- v6: * fixed local variable initialization in fips_mct_aes_test. --- examples/fips_validation/fips_validation.c| 8 +- examples/fips_validation/fips_validation.h| 4 + .../fips_validation/

[v8, 08/10] examples/fips_validation: add parsing for cmac

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added function to parse algorithm for CMAC test. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan -- v5: * parser_read_cmac_direction_str implementation moved to static. --- examples/fips_validation/fips_validation.c | 19 --- examples/fips_

[v8, 07/10] examples/fips_validation: implement json cmac test

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Implemented JSON support for the CMAC test. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan --- v5: * parser_read_cmac_direction_str is static. --- examples/fips_validation/fips_validation.h| 3 + .../fips_validation/fips_validation_cmac.c| 80 +++

[v8, 06/10] examples/fips_validation: add json to hmac

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Adds JSON support for the HMAC algorithm. Signed-off-by: Brandon Lo Acked-by: Gowrishankar Muthukrishnan --- examples/fips_validation/fips_validation.c| 2 + examples/fips_validation/fips_validation.h| 6 ++ .../fips_validation/fips_validation_hmac.c| 93 +++

[v8, 05/10] examples/fips_validation: add json to gcm test

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Adds json-specific testing and writeback function. Allows the user to test AES-GCM vector sets. Signed-off-by: Brandon Lo Acked-by: Gowrishankar Muthukrishnan --- v8: * reset IV generation var in every test group as initialization. v3: * fix checkpatch warnings --- examples/

[v8, 04/10] examples/fips_validation: allow json file as input

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added the ability to use the json format as the input and output of the example application. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan -- v8: * dont steal refcount on write_set using _new as latter is updated subsequently in same function. * fix fip

[v8, 03/10] examples/fips_validation: add json parsing

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added functions to parse the required information from a vector set given in the new json format. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan --- v7: * pulled json_info define from next patch. v3: * fix checkpatch warnings v2: * fix for loop initializ

[v8, 02/10] examples/fips_validation: add json info to header

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added json-specific functions and other information needed to test the new FIPS test vectors. Signed-off-by: Brandon Lo Signed-off-by: Gowrishankar Muthukrishnan --- v7: * fix switch clause for info.file_type. v5: * fix typo in macro name for prefixes. v2: * fix type of pref

[v8, 01/10] examples/fips_validation: add jansson dependency

2022-05-30 Thread Gowrishankar Muthukrishnan
From: Brandon Lo Added a check for RTE_HAS_JANSSON into the meson configuration file for JSON support. Signed-off-by: Brandon Lo Acked-by: Gowrishankar Muthukrishnan --- examples/fips_validation/meson.build | 4 1 file changed, 4 insertions(+) diff --git a/examples/fips_validation/meson

[v8, 00/10] Add JSON vector set support to fips validation

2022-05-30 Thread Gowrishankar Muthukrishnan
Adds a very basic introduction to JSON vector sets in the fips validation example application. This patch set will only introduce the AES-GCM test using a JSON request file because the other algorithms need more information than what is given in the new JSON format. v8: * Fixed overlapped places f

RE: [PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, Comments inline below. > -Original Message- > From: Danilewicz, MarcinX > Sent: Monday, May 30, 2022 12:55 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v7] sched: enable traffic class oversubscription conditionally >

Re: [PATCH v3 5/5] ethdev: fix dev state when stop

2022-05-30 Thread Ferruh Yigit
On 5/26/2022 11:21 AM, Thomas Monjalon wrote: [CAUTION: External Email] 25/05/2022 19:44, Ferruh Yigit: On 5/3/2022 11:02 AM, Min Hu (Connor) wrote: Currently, 'dev_started' is always set to be 0 when dev stop, whether it succeeded or failed. This is unreasonable and this patch fixed it. Fixe

RE: [PATCH v6] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Danilewicz, MarcinX
Hi Cristian, > > By default TC OV is disabled. > > History: > > - v1 - TC OV disabled by default > > - v2 - throughput improvements > > - v3, v4, v5 - changes from comments > > - v6 - removed rte_sched_subport_tc_ov_config declaration and map > > The place of the history log is not here. If you

RE: [PATCH v6] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Danilewicz, MarcinX
Hi Cristian, > > Using a switch statement for a binary condition instead of if-else does not > make sense to me. I know you mention you saw better performance with the > switch, but I am pretty sure it is not the switch providing the performance > increase. You are using if-else for testing the

RE: [PATCH v6] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Danilewicz, MarcinX
Hi Cristian, Thank you for comments. Please find my response inline. > > Signed-off-by: Marcin Danilewicz > > --- > > lib/sched/rte_sched.c | 96 > > +-- > > 1 file changed, 93 insertions(+), 3 deletions(-) > > > This latest version of your patch only con

[PATCH v7] sched: enable traffic class oversubscription conditionally

2022-05-30 Thread Marcin Danilewicz
Added new flag to enable or disable TC oversubscription for best effort traffic class at subport level. By default TC OV is disabled. Signed-off-by: Marcin Danilewicz History: - v1 - TC OV disabled by default - v2 - throughput improvements - v3, v4, v5 - changes from comments - v6 - removed rte

RE: [PATCH v5 3/3] rte_pie: fix incorrect floating point math

2022-05-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 26, 2022 9:27 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian ; Singh, Jasvinder > ; Wojciech Liguzinski > > Subject: [PATCH v5 3/3] rte_pie: fix incorrect floating point math > > The function

RE: [PATCH v5 2/3] rte_pie: remove unnecessary floating point

2022-05-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 26, 2022 9:27 PM > To: dev@dpdk.org > Cc: Stephen Hemminger ; Dumitrescu, > Cristian ; Singh, Jasvinder > ; Wojciech Liguzinski > > Subject: [PATCH v5 2/3] rte_pie: remove unnecessary floating point > > The qdelay va

RE: [PATCH v2] net/iavf: increase the reset complete wait count

2022-05-30 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Monday, May 30, 2022 1:35 PM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Yang, Qiming > ; sta...@dpdk.org > Subject: [PATCH v2] net/iavf: increase the reset complete wait count > > Kernel iavf driver has sent patch to increase the completion

Re: [PATCH 2/4] app/test: support test last-idx when no DMA completed

2022-05-30 Thread Kevin Laatz
Tested with IOAT and IDXD, both pass unit tests. Tested-by: Kevin Laatz On 27/05/2022 04:40, Chengwen Feng wrote: If no DMA request is completed, the ring_idx of the last completed operation need returned by last_idx parameter. This patch adds testcase for it. Signed-off-by: Chengwen Feng --

[PATCH] net/iavf: remove unimplemented function call

2022-05-30 Thread Qi Zhang
Remove unimplemented function call be wrapped by RTE_LIBRTE_IAVF_DEBUG_TX_DESC_RING Fixes: 1e728b01120c ("net/iavf: rework Tx path") Cc: sta...@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/iavf/iavf_rxtx.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx.c

RE: [PATCH v2] sched: enable CMAN at runtime

2022-05-30 Thread Dumitrescu, Cristian
Hi Marcin, Comments inline below. > -Original Message- > From: Danilewicz, MarcinX > Sent: Thursday, May 12, 2022 2:11 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v2] sched: enable CMAN at runtime > > Added changes to enable C

Re: [PATCH v2 2/2] lpm: add a scalar version of lookupx4 function

2022-05-30 Thread Stanisław Kardach
On Mon, May 30, 2022 at 12:42 PM Bruce Richardson wrote: > > On Mon, May 30, 2022 at 10:00:34AM +0200, Morten Brørup wrote: > > > From: Bruce Richardson [mailto:bruce.richard...@intel.com] > > > Sent: Monday, 30 May 2022 09.52 > > > > > > On Fri, May 27, 2022 at 01:15:20PM -0700, Stephen Hemminger

RE: [PATCH v2] sched: enable CMAN at runtime

2022-05-30 Thread Dumitrescu, Cristian
> -Original Message- > From: Danilewicz, MarcinX > Sent: Thursday, May 12, 2022 2:11 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v2] sched: enable CMAN at runtime > > Added changes to enable CMAN (RED or PIE) at init > from p

  1   2   >