RE: [PATCH] eal/freebsd: fix use of newer CPU_* macros

2022-05-23 Thread Gao, DaxueX
> -Original Message- > From: Bruce Richardson > Sent: 2022年5月21日 2:11 > To: dev@dpdk.org > Cc: David Marchand ; sta...@dpdk.org; > Richardson, Bruce > Subject: [PATCH] eal/freebsd: fix use of newer CPU_* macros > > From: David Marchand > > FreeBSD has updated its CPU macros to align mo

Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6

2022-05-23 Thread Andrew Rybchenko
Hi Pankai, I'd consider a patch which adds RETA controls as well. IMHO it is a major feature which could be interesting to end users. Regards, Andrew. On 5/23/22 23:56, Pankaj Gupta wrote: Hi Andrew, New features were introduced in following two patches so I will update release_22_07.rst for

Re: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark

2022-05-23 Thread Andrew Rybchenko
On 5/23/22 17:39, Thomas Monjalon wrote: 23/05/2022 16:10, Spike Du: From: Thomas Monjalon If you stick with percentage, it only needs 7 bits, and you can make the remaining one bit reserved. Agree, will change to use 7 bits. I'm not sure it's worth introducing a bit field here. +1

[PATCH v7 5/5] ethdev: format module EEPROM for SFF-8636

2022-05-23 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8636 Rev 2.7 Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 4 + lib/ethdev/meson.build| 1 + lib/ethdev/sff_8636.c | 775 ++ lib/ethdev/sff_8636.h

[PATCH v7 4/5] ethdev: format module EEPROM for SFF-8472

2022-05-23 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8472 Rev 12.0 Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 4 + lib/ethdev/meson.build| 1 + lib/ethdev/sff_8472.c | 286 ++ 3 files changed, 291 insertion

[PATCH v7 3/5] ethdev: format module EEPROM for SFF-8079

2022-05-23 Thread Robin Zhang
This patch implements format module EEPROM information for SFF-8079 Rev 1.7 Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 3 + lib/ethdev/meson.build| 1 + lib/ethdev/sff_8079.c | 406 ++ 3 files changed, 410 insertions

[PATCH v7 2/5] ethdev: common utilities for different SFF specs

2022-05-23 Thread Robin Zhang
This patch implements SFF-8024 Rev 4.0 of pluggable I/O configuration and some common utilities for SFF-8436/8636 and SFF-8472/8079. Signed-off-by: Robin Zhang --- lib/ethdev/meson.build | 1 + lib/ethdev/sff_common.c | 326 lib/ethdev/sff_common.h | 1

[PATCH v7 1/5] ethdev: add telemetry command for module EEPROM

2022-05-23 Thread Robin Zhang
Add a new telemetry command /ethdev/module_eeprom to dump the module EEPROM of each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Signed-off-by: Robin Zhang --- lib/ethdev/ethdev_sff_telemetry.c | 138 ++ li

[PATCH v7 0/5] add telemetry command for show module EEPROM

2022-05-23 Thread Robin Zhang
Introduce a new telemetry command /ethdev/module_eeprom to show module EEPROM for each port. The format of module EEPROM information follows the SFF(Small Form Factor) Committee specifications. Current the format support SFP(Small Formfactor Pluggable)/SFP+/ QSFP+(Quad Small Formfactor Pluggable)/

RE: [PATCH v10 04/13] vdpa/ifc: add blk ops for ifc device

2022-05-23 Thread Pei, Andy
Hi Chenbo, Thanks for your effort. > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, May 24, 2022 2:28 PM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATCH v10 04/13] vdpa/ifc: add blk

Re: Undefined reference to symbol while compiling DPPD-PROX

2022-05-23 Thread Avijit Pandey
Yes, works. Made changes into the meson.build as sed -i "139i deps += [cc.find_library('dl', required: true)]" meson.build Thanks a lot. From: Stephen Hemminger Sent: Thursday, April 28, 2022 8:43 PM To: Avijit Pandey Cc: dev@dpdk.org Subject: Re: Undefined re

RE: [PATCH v10 04/13] vdpa/ifc: add blk ops for ifc device

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Tuesday, May 24, 2022 10:48 AM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v10 04/13] vdpa/ifc: add blk ops for ifc device > > For virtio blk

RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails

2022-05-23 Thread Rakesh Kudurumalla
ping > -Original Message- > From: Rakesh Kudurumalla > Sent: Monday, May 9, 2022 3:32 PM > To: 'Thomas Monjalon' ; Jerin Jacob Kollanukkaran > > Cc: 'sta...@dpdk.org' ; 'dev@dpdk.org' > ; 'david.march...@redhat.com' > ; 'ferruh.yi...@intel.com' > ; 'andrew.rybche...@oktetlabs.ru' > ; 'aji

[dpdk-dev] [PATCH v2] examples/ipsec-secgw: support more flow patterns and actions

2022-05-23 Thread psatheesh
From: Satheesh Paul Added support to create flow rules with count, mark and security actions and mark pattern. Signed-off-by: Satheesh Paul --- v2: * Updated documentation in ipsec_secgw.rst doc/guides/sample_app_ug/ipsec_secgw.rst | 58 - examples/ipsec-secgw/flow.c | 280 +

RE: [EXT] Re: [PATCH v2] common/cnxk: add CN103XX platform support

2022-05-23 Thread Rahul Bhansali
Ping. > -Original Message- > From: Jerin Jacob > Sent: Monday, May 2, 2022 9:54 PM > To: Rahul Bhansali ; Thomas Monjalon > > Cc: dpdk-dev ; Nithin Kumar Dabilpuram > ; Kiran Kumar Kokkilagadda > ; Sunil Kumar Kori ; Satha > Koteswara Rao Kottidi ; Pavan Nikhilesh > Bhagavatula ; Shijith

RE: [PATCH v10 03/13] vhost: add vhost msg support for get/set config

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Tuesday, May 24, 2022 10:48 AM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v10 03/13] vhost: add vhost msg support for get/set config > > Add

RE: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark

2022-05-23 Thread Spike Du
> -Original Message- > From: Stephen Hemminger > Sent: Tuesday, May 24, 2022 6:55 AM > To: Spike Du > Cc: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon (EXTERNAL) ; dev@dpdk.org; > Raslan Darawsheh > Subject: Re: [RFC v2 3/7] ethdev: introduce Rx queue bas

[PATCH v10 13/13] vdpa/ifc/base: access correct register for blk device

2022-05-23 Thread Andy Pei
Register address is different between net and blk device. We are re-using most of the code, when register address is different, we have to check net and blk device go through different code. Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.c | 34 +

[PATCH v10 12/13] vdpa/ifc: add interrupt handling for config space

2022-05-23 Thread Andy Pei
Create a thread to poll and relay config space change interrupt. Use VHOST_USER_SLAVE_CONFIG_CHANGE_MSG to inform QEMU. Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/ifcvf_vdpa.c | 121 +- 1 file changed, 120 insertions(+), 1 deleti

[PATCH v10 11/13] vdpa/ifc: add log for config space of virtio blk

2022-05-23 Thread Andy Pei
Add some log of virtio blk device config space information at VDPA launch before qemu connects. Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/ifcvf_vdpa.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c

[PATCH v10 10/13] usertools: add support for virtio blk device

2022-05-23 Thread Andy Pei
Add virtio blk device support to devbind. Signed-off-by: Andy Pei Acked-by: Chenbo Xia --- usertools/dpdk-devbind.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py index ace4627..18c7d67 100755 --- a/usertools/dpdk-d

[PATCH v10 09/13] examples/vdpa: add virtio blk support

2022-05-23 Thread Andy Pei
Add virtio blk device support to vDPA example. Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- examples/vdpa/main.c | 56 examples/vdpa/vdpa_blk_compact.h | 50 +++ 2 files changed, 106 insertions(+) creat

[PATCH v10 08/13] vdpa/ifc: add get device type ops to ifc driver

2022-05-23 Thread Andy Pei
Add get device type ops to ifc driver. Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/ifcvf_vdpa.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c index 0f9db8a..f4c6198 100644 ---

[PATCH v10 07/13] vhost: add API to get vDPA device type

2022-05-23 Thread Andy Pei
Vhost backend of different devices have different features. Add an API to get vDPA device type, net device or blk device currently, so users can set different features for different kinds of devices. Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- doc/guides/prog_guide/vhost_lib.rst| 5

[PATCH v10 06/13] vdpa/ifc: add block device SW live-migration

2022-05-23 Thread Andy Pei
Add SW live-migration support to block device. For block device, it is critical that no packet should be dropped. So when virtio blk device is paused, make sure hardware last_avail_idx and last_used_idx are the same. This indicates all requests have received acks, and no inflight IO. Signed-off-by

[PATCH v10 05/13] vdpa/ifc: add vDPA interrupt relay for blk device

2022-05-23 Thread Andy Pei
For the net device type, only interrupt of rxq needed to be relayed. But for block, since all the queues are used for both read and write requests. Interrupt of all queues needed to be relayed. Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/ifcvf_vdpa.c | 9 - 1 fi

[PATCH v10 04/13] vdpa/ifc: add blk ops for ifc device

2022-05-23 Thread Andy Pei
For virtio blk device, re-use part of ifc driver ops. Implement ifcvf_blk_get_config for virtio blk device. Support VHOST_USER_PROTOCOL_F_CONFIG feature for virtio blk device. Signed-off-by: Andy Pei --- drivers/vdpa/ifc/base/ifcvf.h | 4 ++ drivers/vdpa/ifc/ifcvf_vdpa.c | 96 ++

[PATCH v10 03/13] vhost: add vhost msg support for get/set config

2022-05-23 Thread Andy Pei
Add support for VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG. VHOST_USER_GET_CONFIG and VHOST_USER_SET_CONFIG message is only supported by virtio blk VDPA device. Signed-off-by: Andy Pei --- lib/vhost/vhost_user.c | 85 ++ lib/vhost/vhost_user.h

[PATCH v10 02/13] vhost: add vDPA ops for blk device

2022-05-23 Thread Andy Pei
Get_config and set_config are necessary ops for blk device. Add get_config and set_config ops to vDPA ops. Signed-off-by: Andy Pei Reviewed-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/vhost/vdpa_driver.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/lib/vh

[PATCH v10 01/13] vdpa/ifc: add support for virtio blk device

2022-05-23 Thread Andy Pei
Re-use the vdpa/ifc code, distinguish blk and net device by pci_device_id. Blk and net device are implemented with proper feature and ops. Signed-off-by: Andy Pei Reviewed-by: Chenbo Xia --- drivers/vdpa/ifc/base/ifcvf.h | 22 +++--- drivers/vdpa/ifc/ifcvf_vdpa.c | 95 ++

[PATCH v10 00/13] add virtio_blk device support to vdpa/ifc

2022-05-23 Thread Andy Pei
This patch set add virtio_blk device support to vdpa/ifc driver. With a lot of similarities, I re-use part of vdpa/ifc driver. Distinguish the virtio net and blk device by device id, and implement specific features and ops. Add example to vdpa to support virtio_blk device. To support blk device li

RE: [PATCH v9 04/13] vdpa/ifc: add blk ops for ifc device

2022-05-23 Thread Pei, Andy
> -Original Message- > From: Xia, Chenbo > Sent: Tuesday, May 24, 2022 10:55 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATCH v9 04/13] vdpa/ifc: add blk ops for ifc device > > > -Or

RE: [PATCH v9 03/13] vhost: add vhost msg support for get/set config

2022-05-23 Thread Pei, Andy
> -Original Message- > From: Xia, Chenbo > Sent: Tuesday, May 24, 2022 10:52 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATCH v9 03/13] vhost: add vhost msg support for get/set > config >

RE: [PATCH v9 13/13] vdpa/ifc/base: access correct register for blk device

2022-05-23 Thread Pei, Andy
Hi Chenbo, Sure. Thanks for your review. I will address in V10. > -Original Message- > From: Xia, Chenbo > Sent: Tuesday, May 24, 2022 11:10 AM > To: Pei, Andy ; dev@dpdk.org > Cc: maxime.coque...@redhat.com; Cao, Gang ; Liu, > Changpeng ; Xu, Rosen ; > Xiao, QimaiX > Subject: RE: [PATC

RE: [PATCH v9 13/13] vdpa/ifc/base: access correct register for blk device

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 13/13] vdpa/ifc/base: access correct register for blk > device > >

RE: [PATCH v9 12/13] vdpa/ifc: add interrupt handling for config space

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 12/13] vdpa/ifc: add interrupt handling for config > space > > Cre

RE: [PATCH v9 11/13] vdpa/ifc: add log for config space of virtio blk

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 11/13] vdpa/ifc: add log for config space of virtio blk > > Add so

RE: [PATCH v9 10/13] usertools: add support for virtio blk device

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 10/13] usertools: add support for virtio blk device > > Add virtio

RE: [PATCH v9 09/13] examples/vdpa: add virtio blk support

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 09/13] examples/vdpa: add virtio blk support > > Add virtio blk de

RE: [PATCH v9 08/13] vdpa/ifc: add get device type ops to ifc driver

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 08/13] vdpa/ifc: add get device type ops to ifc driver > > Add get

RE: [PATCH v9 07/13] vhost: add API to get vDPA device type

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 07/13] vhost: add API to get vDPA device type > > Vhost backend of

RE: [PATCH v9 06/13] vdpa/ifc: add block device SW live-migration

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 06/13] vdpa/ifc: add block device SW live-migration > > Add SW liv

RE: [PATCH v9 05/13] vdpa/ifc: add vDPA interrupt relay for blk device

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 05/13] vdpa/ifc: add vDPA interrupt relay for blk > device > > For

RE: [PATCH v9 04/13] vdpa/ifc: add blk ops for ifc device

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 04/13] vdpa/ifc: add blk ops for ifc device > > For virtio blk dev

RE: [PATCH v9 03/13] vhost: add vhost msg support for get/set config

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 03/13] vhost: add vhost msg support for get/set config > > Add sup

RE: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark

2022-05-23 Thread Spike Du
> -Original Message- > From: Thomas Monjalon > Sent: Tuesday, May 24, 2022 5:46 AM > To: Stephen Hemminger ; Spike Du > > Cc: dev@dpdk.org; Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; Raslan Darawsheh > ; ferruh.yi...@amd.com; > andrew.rybche...@oktetlabs.ru > Subject: Re: [RFC v2 3/7]

RE: [PATCH v1 1/2] net/ice: support dump ice ddp package

2022-05-23 Thread Zhang, Qi Z
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, May 18, 2022 12:22 PM > To: Yang, SteveX ; dev@dpdk.org > Cc: Zhang, Yuying ; Yang, Qiming > ; m...@ashroe.eu > Subject: RE: [PATCH v1 1/2] net/ice: support dump ice ddp package > > > > > -Original Message- > > From:

RE: [PATCH v9 02/13] vhost: add vDPA ops for blk device

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 02/13] vhost: add vDPA ops for blk device > > Get_config and set_c

RE: [PATCH v9 01/13] vdpa/ifc: add support for virtio blk device

2022-05-23 Thread Xia, Chenbo
> -Original Message- > From: Pei, Andy > Sent: Monday, May 23, 2022 5:35 PM > To: dev@dpdk.org > Cc: Xia, Chenbo ; maxime.coque...@redhat.com; Cao, > Gang ; Liu, Changpeng ; Xu, > Rosen ; Xiao, QimaiX > Subject: [PATCH v9 01/13] vdpa/ifc: add support for virtio blk device > > Re-use the

Re: [PATCH v1 0/5] Direct re-arming of buffers on receive side

2022-05-23 Thread Konstantin Ananyev
16/05/2022 07:10, Feifei Wang пишет: Currently, the transmit side frees the buffers into the lcore cache and the receive side allocates buffers from the lcore cache. The transmit side typically frees 32 buffers resulting in 32*8=256B of stores to lcore cache. The receive side allocates 32 buffe

RE: [PATCH v2 5/5] baseband/fpga_5gnr_fec: remove filler from HARQ

2022-05-23 Thread Chautru, Nicolas
Thanks Hernan > -Original Message- > From: Vargas, Hernan > Sent: Thursday, May 19, 2022 8:06 PM > To: dev@dpdk.org; gak...@marvell.com; t...@redhat.com > Cc: Chautru, Nicolas ; Zhang, Qi Z > ; Vargas, Hernan > Subject: [PATCH v2 5/5] baseband/fpga_5gnr_fec: remove filler from HARQ > >

[PATCH v5 5/5] baseband/acc100: configuration of ACC101 from PF

2022-05-23 Thread Nicolas Chautru
Adding companion function specific to ACC100 and it can be called from bbdev-test when running from PF. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 22 ++- drivers/baseband/acc100/rte_acc100_cfg.h | 17 ++ drivers/baseband/acc100/rte_acc100_pmd.c | 302 +++

[PATCH v5 3/5] baseband/acc100: introduce PMD for ACC101

2022-05-23 Thread Nicolas Chautru
Support for ACC101 as a derivative of ACC100. Reusing existing code when possible. Signed-off-by: Nicolas Chautru --- MAINTAINERS | 1 + doc/guides/bbdevs/acc100.rst | 37 +-- doc/guides/bbdevs/features/acc101.ini| 13 +++ doc/guides/rel_notes

[PATCH v5 4/5] baseband/acc100: modify validation code for ACC101

2022-05-23 Thread Nicolas Chautru
The validation requirement is different for the two devices. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 47 1 file changed, 35 insertions(+), 12 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/base

[PATCH v5 2/5] baseband/acc100: add protection for some negative scenario

2022-05-23 Thread Nicolas Chautru
Catch exception in PMD in case of invalid input parameter. Fixes: 5ad5060f8f7a ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/bas

[PATCH v5 1/5] baseband/acc100: update companion PF configure function

2022-05-23 Thread Nicolas Chautru
Update of the device configuration function from PF used for bbdev-test to latest sequence for ACC199 PRQ device and matching version in pf_bb_config 22.03. Fixes: b17d70922d5d ("baseband/acc100: add configure function") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/ac

[PATCH v5 0/5] drivers/baseband: PMD to support ACC100/ACC101 devices

2022-05-23 Thread Nicolas Chautru
v5: minor fix to doc and intermediate commit caught in CI v4: incremental updates based on reviews Changed order of patchset to include two ACC100 specific commits first: updating formally the companion configure function from PF and the protection adjustment. Then next 3 commits for the actual

RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices

2022-05-23 Thread Zhang, Qi Z
> -Original Message- > From: Jeff Daly > Sent: Monday, May 23, 2022 10:14 PM > To: Zhang, Qi Z ; Thomas Monjalon > ; dev@dpdk.org > Cc: Stephen Douthit ; Yang, Qiming > ; Wu, Wenjun1 > Subject: RE: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices > > > > > -Origi

Re: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark

2022-05-23 Thread Stephen Hemminger
On Mon, 23 May 2022 03:01:20 + Spike Du wrote: > Hi, pls see below. > > > -Original Message- > > From: Stephen Hemminger > > Sent: Sunday, May 22, 2022 11:23 PM > > To: Spike Du > > Cc: Matan Azrad ; Slava Ovsiienko > > ; Ori Kam ; NBU-Contact- > > Thomas Monjalon (EXTERNAL) ; dev@

DPDK PIE computation is broken

2022-05-23 Thread Stephen Hemminger
Was looking at where rte_rand() is currently used in DPDK. Found that rte_pie uses it (that is expected. But it also using it wrong on a couple of levels. First. Look at: #define RTE_RAND_MAX ~0LLU/**< Max value of the random number */ _rte_pie_drop(const struct rte_pie_config *pie_cfg

RE: [PATCH v4] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-05-23 Thread Kathleen Capella
In this section of the code: stack_ptr = rte_zmalloc_socket("lcore_stack", stack_size, stack_size, rte_lcore_to_socket_id(lcore_id)); stack memory is aligned to the stack_size. Acc

Re: [RFC v2 3/7] ethdev: introduce Rx queue based limit watermark

2022-05-23 Thread Thomas Monjalon
23/05/2022 05:01, Spike Du: > From: Stephen Hemminger > > Spike Du wrote: > > > --- a/lib/ethdev/rte_ethdev.h > > > +++ b/lib/ethdev/rte_ethdev.h > > > @@ -1249,7 +1249,16 @@ struct rte_eth_rxconf { > > >*/ > > > union rte_eth_rxseg *rx_seg; > > > > > > - uint64_t reserved_64s[2

[PATCH v4 5/5] baseband/acc100: configuration of ACC101 from PF

2022-05-23 Thread Nicolas Chautru
Adding companion function specific to ACC100 and it can be called from bbdev-test when running from PF. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 22 ++- drivers/baseband/acc100/rte_acc100_cfg.h | 17 ++ drivers/baseband/acc100/rte_acc100_pmd.c | 302 +++

[PATCH v4 4/5] baseband/acc100: modify validation code for ACC101

2022-05-23 Thread Nicolas Chautru
The validation requirement is different for the two devices. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 40 ++-- 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/base

[PATCH v4 1/5] baseband/acc100: update companion PF configure function

2022-05-23 Thread Nicolas Chautru
Update of the device configuration function from PF used for bbdev-test to latest sequence for ACC199 PRQ device and matching version in pf_bb_config 22.03. Fixes: b17d70922d5d ("baseband/acc100: add configure function") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/ac

[PATCH v4 3/5] baseband/acc100: introduce PMD for ACC101

2022-05-23 Thread Nicolas Chautru
Support for ACC101 as a derivative of ACC100. Reusing existing code when possible. Signed-off-by: Nicolas Chautru --- MAINTAINERS | 1 + doc/guides/bbdevs/acc100.rst | 37 -- doc/guides/bbdevs/features/acc101.ini| 13 +++ doc/guides/bbdevs/ind

[PATCH v4 0/5] drivers/baseband: PMD to support ACC100/ACC101 devices

2022-05-23 Thread Nicolas Chautru
v4: incremental updates based on reviews Changed order of patchset to include two ACC100 specific commits first: updating formally the companion configure function from PF and the protection adjustment. Then next 3 commits for the actual changes specific to ACC101: the device specific function

[PATCH v4 2/5] baseband/acc100: add protection for some negative scenario

2022-05-23 Thread Nicolas Chautru
Catch exception in PMD in case of invalid input parameter. Fixes: 5ad5060f8f7a ("baseband/acc100: add LDPC processing functions") Cc: sta...@dpdk.org Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/bas

Re: [PATCH] net/nfp: fix the issue about set the vlan strip offload off

2022-05-23 Thread Niklas Söderlund
Hi Peng, Thanks for your work. On 2022-04-19 10:38:57 +0200, Peng Zhang wrote: > When set the vlan_strip_offload off, it doesn't work. > Because we can't update the msg in the nic. > > This patch will fix this error. > > Fixes: d4a27a3b092a ("nfp: add basic features") > Cc: sta...@dpdk.org > >

Re: [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6

2022-05-23 Thread Pankaj Gupta
Hi Andrew, New features were introduced in following two patches so I will update release_22_07.rst for these two patches. [PATCH v6 1/9] net/vmxnet3: add version 5 support [PATCH v6 6/9] net/vmxnet3: add version 6 support Let me know if I am missing anything. Thanks, Pankaj From: Andrew Rybc

[PATCH v3 4/4] examples/l3fwd_power: add cli for configurable options

2022-05-23 Thread Kevin Laatz
Add CLI options to l3fwd_power to utilize the new power APIs introduced in this patchset. These CLI options allow the user to configure the heuritstics made available through the new API via the l3fwd_power application options. Signed-off-by: Kevin Laatz --- v2: add doc update for l3fwd-power v3

[PATCH v3 3/4] lib/power: add get and set API for scaling freq min and max with pstate mode

2022-05-23 Thread Kevin Laatz
Add new get/set API to allow the user or application to set the minimum and maximum frequencies to use when scaling. Previously, the frequency range was determined by the HW capabilities of the CPU. With this new API, the user or application can constrain this if required. Signed-off-by: Kevin Laa

[PATCH v3 2/4] lib/power: add get and set API for pause duration

2022-05-23 Thread Kevin Laatz
Add new get/set API for configuring 'pause_duration' which used to adjust the pause mode callback duration. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella Acked-by: Anatoly Burakov --- v3: changed printf to RTE_LOG --- lib/power/rte_power_pmd_mgmt.c | 25 +++-- lib/powe

[PATCH v3 1/4] lib/power: add get and set API for emptypoll max

2022-05-23 Thread Kevin Laatz
Add new get/set APIs to configure emptypoll max which is used to determine when a queue can go into sleep state. Signed-off-by: Kevin Laatz Acked-by: Ray Kinsella --- lib/power/rte_power_pmd_mgmt.c | 21 ++--- lib/power/rte_power_pmd_mgmt.h | 27 +++ lib/

[PATCH v3 0/4] Add APIs for configurable power options

2022-05-23 Thread Kevin Laatz
The power library contains some variables which are currently set by defines, hard-coded values or set using sysfs values. In order to configure these, code changes and recompiles are required, making configuring these variables tedious. This patchset introduces some new get/set APIs which allow u

RE: [PATCH] mempool/cnxk: avoid batch op free for empty mempools

2022-05-23 Thread Ashwin Sekhar Thalakalath Kottilveetil
PING. Ashwin Sekhar T K > -Original Message- > From: Ashwin Sekhar T K > Sent: Thursday, April 28, 2022 3:30 PM > To: dev@dpdk.org > Cc: Jerin Jacob Kollanukkaran ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > ; Pavan Nikhilesh Bhagavatula > ; Kiran Kumar Kokkilagadda > ; Satheesh

Re: [PATCH] app/procinfo: show all non-owned ports

2022-05-23 Thread Thomas Monjalon
23/05/2022 18:10, Subendu Santra: > Sure. Will add a sentence about the issue which is getting fixed. > However, I have already added Fixes: 1dd6cffb6571 in the patch. Sorry I missed it. > Is there anything else that needs to be done apart from this w.r.to > "Fixes:" comment? No that's fine, tha

RE: [PATCH v2 1/5] baseband/acc100: introduce PMD for ACC101

2022-05-23 Thread Chautru, Nicolas
Hi Tom, I realize I had not replied to that one > -Original Message- > From: Tom Rix > Sent: Tuesday, May 10, 2022 4:56 AM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com > Cc: tho...@monjalon.net; Kinsella, Ray ; > Richardson, Bruce ; > hemant.agra...@nxp.com; Zhang, Mingsha

RE: [PATCH v3 3/4] baseband/acc100: configuration of ACC101 from PF

2022-05-23 Thread Chautru, Nicolas
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Thursday, May 19, 2022 1:14 PM > To: Chautru, Nicolas ; dev@dpdk.org; > gak...@marvell.com; t...@redhat.com > Cc: tho...@monjalon.net; Kinsella, Ray ; > Richardson, Bruce ; > hemant.agra...@nxp.com; Vargas, Hernan ; > david.

Re: [PATCH v4] event/dlb2: add support for single 512B write of 4 QEs

2022-05-23 Thread Bruce Richardson
On Mon, May 23, 2022 at 05:52:06PM +0100, McDaniel, Timothy wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: Monday, May 23, 2022 11:34 AM > > To: McDaniel, Timothy > > Cc: jer...@marvell.com; dev@dpdk.org; Wires, Kent > > Subject: Re: [PATCH v4] event/dlb2: add

Re: [PATCH v2 4/4] examples/l3fwd_power: add cli for configurable options

2022-05-23 Thread Kevin Laatz
On 18/05/2022 10:11, Burakov, Anatoly wrote: On 19-Apr-22 12:25 PM, Kevin Laatz wrote: Add CLI options to l3fwd_power to utilize the new power APIs introduced in this patchset. These CLI options allow the user to configure the heuritstics made available through the new API via the l3fwd_power

RE: [PATCH v4] event/dlb2: add support for single 512B write of 4 QEs

2022-05-23 Thread McDaniel, Timothy
> -Original Message- > From: Richardson, Bruce > Sent: Monday, May 23, 2022 11:34 AM > To: McDaniel, Timothy > Cc: jer...@marvell.com; dev@dpdk.org; Wires, Kent > Subject: Re: [PATCH v4] event/dlb2: add support for single 512B write of 4 QEs > > On Mon, May 23, 2022 at 11:09:55AM -05

RE: [PATCH v4] event/dlb2: add support for single 512B write of 4 QEs

2022-05-23 Thread McDaniel, Timothy
Sorry Bruce, but I don't have a clue what you are talking about here. > -Original Message- > From: Richardson, Bruce > Sent: Monday, May 23, 2022 11:37 AM > To: McDaniel, Timothy > Cc: jer...@marvell.com; dev@dpdk.org; Wires, Kent > Subject: Re: [PATCH v4] event/dlb2: add support for si

Re: [PATCH v4] event/dlb2: add support for single 512B write of 4 QEs

2022-05-23 Thread Bruce Richardson
On Mon, May 23, 2022 at 11:09:55AM -0500, Timothy McDaniel wrote: > On Xeon, as 512b accesses are available, movdir64 instruction is able to > perform 512b read and write to DLB producer port. In order for movdir64 > to be able to pull its data from store buffers (store-buffer-forwarding) > (before

Re: [PATCH v4] event/dlb2: add support for single 512B write of 4 QEs

2022-05-23 Thread Bruce Richardson
On Mon, May 23, 2022 at 11:09:55AM -0500, Timothy McDaniel wrote: > On Xeon, as 512b accesses are available, movdir64 instruction is able to > perform 512b read and write to DLB producer port. In order for movdir64 > to be able to pull its data from store buffers (store-buffer-forwarding) > (before

Re: [PATCH v2 3/4] lib/power: add get and set API for scaling freq min and max with pstate mode

2022-05-23 Thread Kevin Laatz
On 18/05/2022 10:05, Burakov, Anatoly wrote: On 19-Apr-22 12:25 PM, Kevin Laatz wrote: Add new get/set API to allow the user or application to set the minimum and maximum frequencies to use when scaling. Previously, the frequency range was determined by the HW capabilities of the CPU. With thi

[PATCH v2 11/11] net/thunderx: populate max and min MTU values

2022-05-23 Thread Harman Kalra
From: Hanumanth Pothula Populate maximum and minimum MTU values while retrieving device information. Signed-off-by: Hanumanth Pothula --- drivers/net/thunderx/nicvf_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicv

[PATCH v2 10/11] net/thunderx: device attach from secondary

2022-05-23 Thread Harman Kalra
Adding support for device hotplugging - attach and detach from secondary Signed-off-by: Harman Kalra --- drivers/net/thunderx/base/nicvf_mbox.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/net/thunderx/base/nicvf_mbox.c b/drivers/net/thunderx/ba

[PATCH v2 09/11] net/octeontx: support allmulticast

2022-05-23 Thread Harman Kalra
Implement allmulticast operations for octeontx driver: rte_eth_allmulticast_enable()/rte_eth_allmulticast_disable(). Signed-off-by: Harman Kalra --- drivers/net/octeontx/base/octeontx_bgx.c | 19 ++ drivers/net/octeontx/base/octeontx_bgx.h | 1 + drivers/net/octeontx/octeontx_ethdev.c

[PATCH v2 08/11] net/octeontx: implement xstats

2022-05-23 Thread Harman Kalra
Adding support for xstats eth operations. Signed-off-by: Harman Kalra --- drivers/net/octeontx/base/octeontx_bgx.c | 17 +++ drivers/net/octeontx/base/octeontx_bgx.h | 3 + drivers/net/octeontx/octeontx_ethdev.c | 126 +++ drivers/net/octeontx/octeontx_stats.h| 41 +

[PATCH v2 07/11] net/thunderx: setting link attributes

2022-05-23 Thread Harman Kalra
Adding support to configure link attributes like speed, duplex, negotiation. Signed-off-by: Harman Kalra --- drivers/net/thunderx/base/nicvf_mbox.c | 16 + drivers/net/thunderx/base/nicvf_mbox.h | 14 drivers/net/thunderx/nicvf_ethdev.c| 88 -- drivers/net/th

[PATCH v2 06/11] net/thunderx: reset Rx DMAC control register

2022-05-23 Thread Harman Kalra
From: Hanumanth Pothula During initialization, reset RX DMAC control register by sending mbox message NIC_MBOX_MSG_RESET_XCAST to PF. Signed-off-by: Hanumanth Pothula --- drivers/net/thunderx/base/nicvf_mbox.c | 9 + drivers/net/thunderx/base/nicvf_mbox.h | 2 ++ drivers/net/thunderx/n

[PATCH v2 05/11] net/thunderx: implement polling of link state change

2022-05-23 Thread Harman Kalra
From: Hanumanth Pothula Moving the logic of link polling to VF from PF. Now VF is supposed to poll for the link status, rather PF alerting VF about any link change. Signed-off-by: Hanumanth Pothula --- drivers/net/thunderx/base/nicvf_mbox.c | 9 drivers/net/thunderx/base/nicvf_mbox.h

[PATCH v2 04/11] net/octeontx: handle port reconfiguration

2022-05-23 Thread Harman Kalra
Adding support for port reconfiguration as user may require to do so on a running system. Signed-off-by: Harman Kalra --- drivers/net/octeontx/octeontx_ethdev.c | 38 +++--- drivers/net/octeontx/octeontx_ethdev.h | 1 + 2 files changed, 23 insertions(+), 16 deletions(-) dif

[PATCH v2 03/11] net/octeontx: setting link attributes

2022-05-23 Thread Harman Kalra
Adding support to configure link attributes like speed, duplex, negotiation. Signed-off-by: Harman Kalra --- drivers/net/octeontx/base/octeontx_bgx.c | 19 ++ drivers/net/octeontx/base/octeontx_bgx.h | 12 drivers/net/octeontx/octeontx_ethdev.c | 80 ++-- 3 files c

Re: [PATCH] app/procinfo: show all non-owned ports

2022-05-23 Thread Subendu Santra
Sure. Will add a sentence about the issue which is getting fixed. However, I have already added Fixes: 1dd6cffb6571 in the patch. Is there anything else that needs to be done apart from this w.r.to "Fixes:" comment? Regards, Subendu. On Mon, May 23, 2022 at 8:12 PM Thomas Monjalon wrote: > > 23

[PATCH v2 02/11] net/octeontx: fix port close

2022-05-23 Thread Harman Kalra
Segmentation fault has been observed while closing the ethernet port. Reason for the segfault is, eth port close also shuts down event device while other ethernet port is still using the event device. Fixes: da6c687471a3 ("net/octeontx: add start and stop support") Signed-off-by: Harman Kalra --

[PATCH v2 01/11] event/octeontx: fix SSO fastpath

2022-05-23 Thread Harman Kalra
Segmentation fault is observed as soon as any dpdk application with ethdev event is launched. Handling the event types appropriately. Fixes: 8dc6c2f12ecf ("crypto/octeontx: add crypto adapter data path") Signed-off-by: Harman Kalra --- V2: * Seperated out a generic patch from the series driv

[PATCH v4] event/dlb2: add support for single 512B write of 4 QEs

2022-05-23 Thread Timothy McDaniel
On Xeon, as 512b accesses are available, movdir64 instruction is able to perform 512b read and write to DLB producer port. In order for movdir64 to be able to pull its data from store buffers (store-buffer-forwarding) (before actual write), data should be in single 512b write format. This commit ad

Re: static link + pkg-config assistance

2022-05-23 Thread Ben Magistro
I completely missed that so thanks for pointing it out. On the CentOS environment I don't have an easy way to update it right now so I switched over to another host and am seeing similar behavior. The major deltas are listed below. OS: Ubuntu 21.10 meson: 0.56.2 pkg-config: 0.29.2 (+ 1.7.3 via p

  1   2   >