[PATCH v3] fix mbuf release function point corrupt in multi-process

2022-05-06 Thread Ke Zhang
In the multi process environment, the sub process operates on the shared memory and changes the function pointer of the main process, resulting in the failure to find the address of the function when main process releasing, resulting in crash. Signed-off-by: Ke Zhang --- drivers/net/iavf/iavf_rx

RE: [PATCH v3] vhost: fix deadlock when message handling failed

2022-05-06 Thread Xia, Chenbo
> -Original Message- > From: Ma, WenwuX > Sent: Saturday, May 7, 2022 9:28 PM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; He, > Xingguang ; Ma, WenwuX ; > sta...@dpdk.org > Subject: [PATCH v3] vhost: fix deadlock when message handling fail

[PATCH v3] vhost: fix deadlock when message handling failed

2022-05-06 Thread Wenwu Ma
In vhost_user_msg_handler(), if vhost message handling failed, we should check whether the queue is locked and release the lock before returning. Or, it will cause a deadlock later. Fixes: 7f31d4ea05ca ("vhost: fix lock on device readiness notification") Cc: sta...@dpdk.org Signed-off-by: Wenwu M

RE: [PATCH v2 1/2] ci: switch to Ubuntu 20.04

2022-05-06 Thread Ruifeng Wang
> -Original Message- > From: David Marchand > Sent: Friday, May 6, 2022 7:58 PM > To: dev@dpdk.org > Cc: Aaron Conole ; Michael Santana > ; Ruifeng Wang ; > Jan Viktorin ; Bruce Richardson > ; David Christensen > Subject: [PATCH v2 1/2] ci: switch to Ubuntu 20.04 > > Ubuntu 18.04 is now

RE: [PATCH 6/6] net/vhost: perform SW checksum in Tx path

2022-05-06 Thread Ma, WenwuX
> -Original Message- > From: Maxime Coquelin > Sent: 2022年5月5日 18:27 > To: dev@dpdk.org; jasow...@redhat.com; Xia, Chenbo > ; david.march...@redhat.com; > olivier.m...@6wind.com > Cc: sta...@dpdk.org; Maxime Coquelin > Subject: [PATCH 6/6] net/vhost: perform SW checksum in Tx path > >

[PATCH] net/iavf: fix mismatch between rx_pkt_burst and RX descriptor

2022-05-06 Thread Yiding Zhou
Some kernel drivers return the capability VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC when IAVF_RXDID_COMMS_OVS_1 is not supported. This causes PMD to use rx_pkt_burst that handles the Flex Receive Descriptor format, but actually configures the RXDID into IAVF_RXDID_LEGACY_1, then the fields of rte_mbuf Will

[PATCH v2] net/ice/base: enable FDIR support for IPV6_NETX_PROTO

2022-05-06 Thread Jie Wang
To support the new DDP and be compatible with the old version DDP file, API function 'check_ddp_support_proto_id' is added to detect if the required protocol ID is supported by the current DDP file. Add new protocol ID IPV6_NETX_PROTO support for PF FDIR if current DDP is new DDP and keep behavior

[PATCH v1 5/5] net/ark: add PMD support for devices as virtual functions

2022-05-06 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 79 drivers/net/ark/ark_global.h | 1 + 2 files changed, 45 insertions(+), 35 deletions(-) diff --git a/driver

[PATCH v1 4/5] net/ark: add new devices to support list

2022-05-06 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 4 +++- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index c965406a7b..cec6fce2ff 100644 --- a/doc/guid

[PATCH v1 3/5] net/ark: update udm code to match current hardware version

2022-05-06 Thread Ed Czeck
new version code remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by hardware remove performance structs as they are not in the hardware module Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 34 +-- drivers/net/ark/ar

[PATCH v1 2/5] net/ark: update ddm code to match current hardware version

2022-05-06 Thread Ed Czeck
new version code remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by hardware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ddm.c | 80 +- drivers/net/ark/ark_ddm.h | 86 +

[PATCH v1 1/5] net/ark: update mpu code to match current hardware version

2022-05-06 Thread Ed Czeck
new version code remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 2 -- drivers/net/ark/ark_ethdev_rx.c | 4 drivers/net/ark/ark_mpu.c | 21 - drivers/net/ark/ark_mpu.h |

Re: [PATCH] maintainers: update for vmxnet3 driver

2022-05-06 Thread Yong Wang
> On May 6, 2022, at 1:07 PM, Jochen Behrens wrote: > > Make Jochen Behrens the maintainer of the net/vmxnet3 device > driver as Yong Wang is not working on vmxnet3 any more. > > Signed-off-by: Jochen Behrens > --- Acked-by: yongw...@vmware.com > MAINTAINERS | 2 +- > 1 file changed, 1 inse

[PATCH] maintainers: update for vmxnet3 driver

2022-05-06 Thread Jochen Behrens
Make Jochen Behrens the maintainer of the net/vmxnet3 device driver as Yong Wang is not working on vmxnet3 any more. Signed-off-by: Jochen Behrens --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 7c4f541dba..2bd6bc71da 100644 ---

Re: [PATCH v5 1/3] eal: add basic thread ID and current thread identifier API

2022-05-06 Thread Konstantin Ananyev
05/05/2022 08:11, Tyler Retzlaff пишет: On Wed, May 04, 2022 at 11:55:57PM +0100, Konstantin Ananyev wrote: 04/05/2022 16:46, Tyler Retzlaff пишет: Provide a portable type-safe thread identifier. Provide rte_thread_self for obtaining current thread identifier. Signed-off-by: Narcisa Vasile Si

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Konstantin Ananyev
06/05/2022 17:39, Bruce Richardson пишет: On Fri, May 06, 2022 at 09:33:41AM -0700, Stephen Hemminger wrote: On Fri, 6 May 2022 16:28:41 +0100 Bruce Richardson wrote: On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: On Thu, May 05, 2022 at 10:59:32PM +, Honnappa N

RE: [PATCH] rte_dev: allow C-symbol-in-C++ dma operations

2022-05-06 Thread Morten Brørup
> From: Tianhao Chai [mailto:cth...@gmail.com] > Sent: Thursday, 5 May 2022 06.40 > To: dev@dpdk.org > Cc: Tianhao Chai > Subject: [PATCH] rte_dev: allow C-symbol-in-C++ dma operations > > Currently the "extern C" section ends right before rte_dev_dma_unmap > and other DMA function declarations, c

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Bruce Richardson
On Fri, May 06, 2022 at 09:33:41AM -0700, Stephen Hemminger wrote: > On Fri, 6 May 2022 16:28:41 +0100 > Bruce Richardson wrote: > > > On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: > > > > > > > > > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wro

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Bruce Richardson
On Fri, May 06, 2022 at 08:41:12AM -0700, Stephen Hemminger wrote: > On Fri, 6 May 2022 00:24:34 -0700 > Tyler Retzlaff wrote: > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > > Thanks Stephen. Do you see any performance difference with this change? > > > > as a

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Stephen Hemminger
On Fri, 6 May 2022 16:28:41 +0100 Bruce Richardson wrote: > On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: > > > > > > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > > > Thanks Stephen. Do you see any performance difference with this cha

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Stephen Hemminger
On Fri, 6 May 2022 00:24:34 -0700 Tyler Retzlaff wrote: > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > Thanks Stephen. Do you see any performance difference with this change? > > as a matter of due diligence i think a comparison should be made just > to be confiden

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Bruce Richardson
On Fri, May 06, 2022 at 03:12:32PM +, Honnappa Nagarahalli wrote: > > > > > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > > Thanks Stephen. Do you see any performance difference with this change? > > > > as a matter of due diligence i think a comparison should be

RE: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Honnappa Nagarahalli
> > On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > > Thanks Stephen. Do you see any performance difference with this change? > > as a matter of due diligence i think a comparison should be made just to be > confident nothing is regressing. > > i support this change in p

[PATCH v3] build: add definitions for use as meson subproject

2022-05-06 Thread Bruce Richardson
To allow other projects to easily use DPDK as a subproject, add in the necessary dependency definitions. Slightly different definitions are necessary for static and shared builds, since for shared builds the drivers should not be linked in, and the internal meson dependency objects are more complet

RE: [EXT] Re: [PATCH 1/2] config/arm: add SVE control flag

2022-05-06 Thread Rahul Bhansali
> -Original Message- > From: Bruce Richardson > Sent: Thursday, May 5, 2022 8:09 PM > To: Rahul Bhansali > Cc: dev@dpdk.org; Ruifeng Wang ; Jan Viktorin > ; Jerin Jacob Kollanukkaran > Subject: [EXT] Re: [PATCH 1/2] config/arm: add SVE control flag > > External Email > > ---

Re: [PATCH v2] build: add definitions for use as meson subproject

2022-05-06 Thread Bruce Richardson
On Fri, Nov 05, 2021 at 10:22:13AM -0700, Stephen Hemminger wrote: > Some other projects using meson may not be able to use DPDK > using the standard distribution pkg-config mechanism. > Meson supports a way to handle this via the subproject > https://mesonbuild.com/Subprojects.html > > This pat

[PATCH v2] net/cxgbe: track packets dropped by TP due to congestion

2022-05-06 Thread Rahul Lakkireddy
Transport Processor (TP) on the NIC delivers the incoming packets from the wire to NIC's DMA engine to place the packets in Rx buffers. TP sends signal towards the Multi-Port Switch (MPS) near the MAC when the Rxqs run out of Rx buffers posted by driver. These MPS buffer drop stats are already acco

RE: [EXT] Re: [PATCH 2/2] config/arm: disable SVE for cn10k

2022-05-06 Thread Rahul Bhansali
> -Original Message- > From: Ruifeng Wang > Sent: Friday, May 6, 2022 12:53 PM > To: fengchengwen ; Rahul Bhansali > ; dev@dpdk.org; Jan Viktorin > ; Bruce Richardson > Cc: Jerin Jacob Kollanukkaran ; nd > Subject: RE: [EXT] Re: [PATCH 2/2] config/arm: disable SVE for cn10k > > >

Re: [PATCH 4/5] net/cxgbe: track packets dropped by TP due to congestion

2022-05-06 Thread Ferruh Yigit
On 5/6/2022 12:09 PM, Rahul Lakkireddy wrote: On Thursday, May 05/05/22, 2022 at 17:28:55 +0100, Ferruh Yigit wrote: On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote: Rx packets can get dropped at TP due to congestion and this info will not get propagated to MPS. Track these Rx dropped packets in

RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op

2022-05-06 Thread Kusztal, ArkadiuszX
Hi Akhil, > -Original Message- > From: Kusztal, ArkadiuszX > Sent: Friday, April 29, 2022 8:26 AM > To: Akhil Goyal ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op > > > > > -Original Message- > > From: Akhil G

[PATCH v2 2/2] ci: add mingw cross compilation in GHA

2022-05-06 Thread David Marchand
Add mingw cross compilation in our public CI so that users with their own github repository have a first level of checks for Windows compilation before submitting to the mailing list. This does not replace our better checks in other entities of the CI. Only the helloworld example is compiled (same

[PATCH v2 1/2] ci: switch to Ubuntu 20.04

2022-05-06 Thread David Marchand
Ubuntu 18.04 is now rather old. Besides, other entities in our CI are also testing this distribution. Switch to a newer Ubuntu release and benefit from more recent tool(chain)s: for example, net/cnxk now builds fine and can be re-enabled. Note: Ubuntu 18.04 and 20.04 seem to preserve the same pat

Re: [PATCH 5/5] net/cxgbe: read firmware configuration file from filesystem

2022-05-06 Thread Rahul Lakkireddy
On Thursday, May 05/05/22, 2022 at 17:36:06 +0100, Ferruh Yigit wrote: > On 5/5/2022 5:29 PM, Ferruh Yigit wrote: > > On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote: > > > Add support to read firmware configuration file from > > > /lib/firmware/cxgb4/ path in the filesystem. > > > > > > > Hi Rahul

Re: [PATCH 4/5] net/cxgbe: track packets dropped by TP due to congestion

2022-05-06 Thread Rahul Lakkireddy
On Thursday, May 05/05/22, 2022 at 17:28:55 +0100, Ferruh Yigit wrote: > On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote: > > Rx packets can get dropped at TP due to congestion and this info > > will not get propagated to MPS. Track these Rx dropped packets > > in imissed counter. Also add xstats for

[PATCH] net/iavf: fix device stop

2022-05-06 Thread Radu Nicolau
Move security context destroy from device stop to device close function. Deleting the context on device stop can prevent the application from properly cleaning and releasing resources. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Cc: sta...@dpdk.org Signed-off-by: Radu Nicolau -

Re: [PATCH 00/11] Introduce support for RISC-V architecture

2022-05-06 Thread David Marchand
On Thu, May 5, 2022 at 7:30 PM Stanislaw Kardach wrote: > > This patchset adds support for building and running DPDK on 64bit RISC-V > architecture. The initial support targets rv64gc (rv64imafdc) ISA and > was tested on SiFive Unmatched development board with the Freedom U740 > SoC running Linux

RE: [PATCH v3] doc: fix vhost multi-queue reconnection

2022-05-06 Thread Xia, Chenbo
> -Original Message- > From: Ding, Xuan > Sent: Friday, April 15, 2022 10:08 AM > To: maxime.coque...@redhat.com; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Ding, Xuan > ; sta...@dpdk.org > Subject: [PATCH v3] doc: fix vhost multi-queue reconnection > > From: Xuan Ding > > Since QEMU

RE: [PATCH v2] vhost: fix deadlock when handling user messages

2022-05-06 Thread Xia, Chenbo
> -Original Message- > From: Ma, WenwuX > Sent: Friday, May 6, 2022 12:17 AM > To: maxime.coque...@redhat.com; Xia, Chenbo ; > dev@dpdk.org > Cc: Hu, Jiayu ; Wang, Yinan ; He, > Xingguang ; Ma, WenwuX ; > sta...@dpdk.org > Subject: [PATCH v2] vhost: fix deadlock when handling user messages

Re: [RFC] rte_ring: don't use always inline

2022-05-06 Thread Tyler Retzlaff
On Thu, May 05, 2022 at 10:59:32PM +, Honnappa Nagarahalli wrote: > Thanks Stephen. Do you see any performance difference with this change? as a matter of due diligence i think a comparison should be made just to be confident nothing is regressing. i support this change in principal since it

RE: [EXT] Re: [PATCH 2/2] config/arm: disable SVE for cn10k

2022-05-06 Thread Ruifeng Wang
> -Original Message- > From: fengchengwen > Sent: Friday, May 6, 2022 2:36 PM > To: Rahul Bhansali ; dev@dpdk.org; Ruifeng Wang > ; Jan Viktorin ; Bruce > Richardson > Cc: jer...@marvell.com > Subject: Re: [EXT] Re: [PATCH 2/2] config/arm: disable SVE for cn10k > > On 2022/5/6 12:54, Rah

Re: [PATCH 1/2] vhost: remove unneeded max enums

2022-05-06 Thread David Marchand
On Thu, May 5, 2022 at 9:58 PM Maxime Coquelin wrote: > On 4/25/22 14:54, David Marchand wrote: > > Move message handler description and callbacks into a single array and > > remove unneeded VHOST_USER_MAX and VHOST_SLAVE_MAX enums. > > > > Signed-off-by: David Marchand > > --- > > drivers/net/