RE: [PATCH v5] eal: add seqlock

2022-05-05 Thread Honnappa Nagarahalli
> >>> +__rte_experimental > >>> +static inline bool > >>> +rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t > >>> +begin_sn) { > >>> + uint32_t end_sn; > >>> + > >>> + /* An odd sequence number means the protected data was being > >>> + * modified already at the point of the rte_seq

RE: [EXT] Re: [PATCH 2/2] config/arm: disable SVE for cn10k

2022-05-05 Thread Rahul Bhansali
> -Original Message- > From: fengchengwen > Sent: Friday, May 6, 2022 8:00 AM > To: Rahul Bhansali ; dev@dpdk.org; Ruifeng Wang > ; Jan Viktorin ; Bruce > Richardson > Cc: Jerin Jacob Kollanukkaran > Subject: [EXT] Re: [PATCH 2/2] config/arm: disable SVE for cn10k > > External Email >

[RFC v1 7/7] app/testpmd: add LWM and Host Shaper command

2022-05-05 Thread Spike Du
Add command line options to support LWM per-rxq configure. - Command syntax: set port rxq lwm mlx5 set port host_shaper lwm_triggered <0|1> rate - Example commands: To configure LWM as 30% of rxq size on port 1 rxq 0: testpmd> set port 1 rxq 0 lwm 30 To disable LWM on port 1 rxq 0: testp

[RFC v1 6/7] net/mlx5: add private API to config host port shaper

2022-05-05 Thread Spike Du
Host port shaper can be configured with QSHR(QoS Shaper Host Register). Add check in build files to enable this function or not. The host shaper configuration affects all the ethdev ports belonging to the same host port. Host shaper can configure shaper rate and lwm-triggered for a host port. The

[RFC v1 5/7] net/mlx5: support Rx queue based limit watermark

2022-05-05 Thread Spike Du
Add mlx5 specific LWM(limit watermark) configuration handler. While the Rx queue fullness reaches the LWM limit, the driver catches an HW event and invokes the user callback. Signed-off-by: Spike Du --- doc/guides/nics/mlx5.rst | 4 ++ doc/guides/rel_notes/release_22_07.rst | 1

[RFC v1 4/7] net/mlx5: add LWM event handling support

2022-05-05 Thread Spike Du
When LWM meets RQ WQE, the kernel driver raises an event to SW. Use devx event_channel to catch this and to notify the user. Allocate this channel per shared device. The channel has a cookie that informs the specific event port and queue. Signed-off-by: Spike Du --- drivers/net/mlx5/mlx5.c

[RFC v1 3/7] ethdev: introduce Rx queue based limit watermark

2022-05-05 Thread Spike Du
LWM(limit watermark) is a per Rx queue attribute that notifies dpdk application event of RTE_ETH_EVENT_RXQ_LIMIT_REACHED when the Rx queue's usable descriptor is under the watermark. To simplify its configuration, LWM is a percentage of Rx queue descriptor size with valid value of [0,99]. Setting L

[RFC v1 2/7] common/mlx5: share interrupt management

2022-05-05 Thread Spike Du
There are many duplicate code of creating and initializing rte_intr_handle. Add a new mlx5_os API to do this, replace all PMD related code with this API. Signed-off-by: Spike Du --- drivers/common/mlx5/linux/mlx5_common_os.c | 131 ++ drivers/common/mlx5/linux/mlx5_comm

[RFC v1 1/7] net/mlx5: add LWM support for Rxq

2022-05-05 Thread Spike Du
Add lwm(Limit WaterMark) field to Rxq object which indicates the percentage of RX queue size used by HW to raise LWM event to the user. Allow LWM setting in modify_rq command. Allow the LWM configuration dynamically by adding RDY2RDY state change. Signed-off-by: Spike Du --- drivers/net/mlx5/mlx

[RFC v1 0/7] net/mlx5: introduce limit watermark and host shaper

2022-05-05 Thread Spike Du
LWM(limit watermark) is per RX queue attribute, when RX queue fullness reach the LWM limit, HW sends an event to dpdk application. Host shaper can configure shaper rate and lwm-triggered for a host port. The shaper limits the rate of traffic from host port to wire port. If lwm-triggered is enabled,

RE: [PATCH v4 0/5] vhost: support async dequeue data path

2022-05-05 Thread Ding, Xuan
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, May 6, 2022 3:53 AM > To: Ding, Xuan ; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Jiang, Cheng1 > ; Pai G, Sunil ; > lian...@liangbit.com > Subject: Re: [PATCH v4 0/5] vhost: support async dequeue data path > > Hi

RE: [PATCH v1 1/2] vhost: add unsafe API to check inflight packets

2022-05-05 Thread Ding, Xuan
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Friday, May 6, 2022 3:21 AM > To: Ding, Xuan ; Xia, Chenbo > Cc: dev@dpdk.org; Hu, Jiayu ; Jiang, Cheng1 > ; Pai G, Sunil > Subject: Re: [PATCH v1 1/2] vhost: add unsafe API to check inflight packets > > > > On 4/8/22 12

RE: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Honnappa Nagarahalli
> > > Thanks Stephen. Do you see any performance difference with this change? > > > > > -Original Message- > > > From: Stephen Hemminger > > > Sent: Thursday, May 5, 2022 5:46 PM > > > To: dev@dpdk.org > > > Cc: Stephen Hemminger > > > Subject: [RFC] rte_ring: don't use always inline >

RE: [PATCH v5] eal: add seqlock

2022-05-05 Thread Honnappa Nagarahalli
> > +__rte_experimental > > +static inline bool > > +rte_seqlock_read_retry(const rte_seqlock_t *seqlock, uint32_t > > +begin_sn) { > > + uint32_t end_sn; > > + > > + /* An odd sequence number means the protected data was being > > +* modified already at the point of the rte_seqlock_read_

Re: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Stephen Hemminger
On Thu, 5 May 2022 16:10:27 -0700 Stephen Hemminger wrote: > On Thu, 5 May 2022 22:59:32 + > Honnappa Nagarahalli wrote: > > > Thanks Stephen. Do you see any performance difference with this change? > > > > > -Original Message- > > > From: Stephen Hemminger > > > Sent: Thursday,

Re: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Stephen Hemminger
On Thu, 5 May 2022 22:59:32 + Honnappa Nagarahalli wrote: > Thanks Stephen. Do you see any performance difference with this change? > > > -Original Message- > > From: Stephen Hemminger > > Sent: Thursday, May 5, 2022 5:46 PM > > To: dev@dpdk.org > > Cc: Stephen Hemminger > > Subjec

RE: [RFC] rte_ring: don't use always inline

2022-05-05 Thread Honnappa Nagarahalli
Thanks Stephen. Do you see any performance difference with this change? > -Original Message- > From: Stephen Hemminger > Sent: Thursday, May 5, 2022 5:46 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [RFC] rte_ring: don't use always inline > > Forcing compiler to inline with

[RFC] rte_ring: don't use always inline

2022-05-05 Thread Stephen Hemminger
Forcing compiler to inline with always inline can lead to worse and sometimes broken code. Better to use the standard inline keyword and let compiler have some flexibilty. Signed-off-by: Stephen Hemminger --- This is RFC because the use of large scale inlining is debatable. This change may slow

[PATCH v4 8/8] Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")

2022-05-05 Thread Pankaj Gupta
Fix merge error in initialization for rxDataRing feature. Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/driver

[PATCH v4 7/8] net/vmxnet3: set packet type for fragmented packet

2022-05-05 Thread Pankaj Gupta
The packet type is set even if it is a fragmented packet Tested, using testpmd, for different hardware versions on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 17 + 1 file changed, 17 insertions(+) diff --

[PATCH v4 5/8] net/vmxnet3: version 6

2022-05-05 Thread Pankaj Gupta
vmxnet3 version 6 supports some new features, including but not limited to: - Increased max MTU up to 9190 - Increased max number of queues, both for Rx and Tx - Removes power-of-two limitations - Extended interrupt structures, required implementation for additional number of queues Tested, usin

[PATCH v4 6/8] net/vmxnet3: advertise RETA size in device info

2022-05-05 Thread Pankaj Gupta
Currently the driver assumes that the size of the reta table is four times the number of Rx queues at multiple places. However, it sets it to four times the maximum number of queues (4 * 32 = 128) when it first initializes the device. Change the other uses to use the stored value, not the assumed d

[PATCH v4 4/8] net/vmxnet3: report HW version on FW version get

2022-05-05 Thread Pankaj Gupta
Implement fw_version_get API for vmxnet3 Align addition order in vmxnet3_eth_dev_ops with eth_dev_ops Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 35 +

[PATCH v4 3/8] net/vmxnet3: add Rx queue usage count utility

2022-05-05 Thread Pankaj Gupta
Count the number of entries in the Rx queue for debugging. Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2 Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 1 + drivers/net/vmxnet3/vmxnet3_ethdev.h | 3 +++ drivers/

[PATCH v4 2/8] net/vmxnet3: implement reta query and reta update

2022-05-05 Thread Pankaj Gupta
Add reta query and reta update support for VMXNET3 Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 67 1 file changed, 67 insertions(+) d

[PATCH v4 1/8] net/vmxnet3: add V5 support

2022-05-05 Thread Pankaj Gupta
Add VMXNET3 v5 support Tested, using testpmd, for different hardware version on ESXi 7.0 Update 2. Signed-off-by: Pankaj Gupta Reviewed-by: Jochen Behrens --- drivers/net/vmxnet3/vmxnet3_ethdev.c | 7 +-- drivers/net/vmxnet3/vmxnet3_ethdev.h | 2 ++ 2 files changed, 7 insertions(+), 2 dele

[PATCH v4 0/8] vmxnet3 version V5 and V6

2022-05-05 Thread Pankaj Gupta
v4: Changing the subject for [Patch 8/8] from "net/vmxnet3: fix merge error in initialization for rxDataRing feature" to "Fixes: 046f11619567 ("net/vmxnet3: support MSI-X interrupt")" v3: adding Reviewed-by info in all the patches v2: address review comments from Andrew Ryb

Re: [PATCH v2 5/7] vdpa/mlx5: cache and reuse hardware resources

2022-05-05 Thread Maxime Coquelin
Hi Xueming, On 4/25/22 15:28, Xueming(Steven) Li wrote: Hi Maxime, Thanks for the suggestion, I'll send out a new version. Ok, if you sent it early next week, it could be part of next week's PR. Thanks, Maxime Regards, Xueming Li -Original Message- From: Maxime Coquelin Sent: We

Re: [PATCH 2/2] vhost: validate fds attached to messages

2022-05-05 Thread Maxime Coquelin
On 4/25/22 14:54, David Marchand wrote: Some message handlers do not expect any file descriptor attached as ancillary data. Provide a common way to enforce this by adding a accepts_fd boolean in the message handler structure. When a message handler sets accepts_fd to true, it is responsible fo

Re: [PATCH 1/2] vhost: remove unneeded max enums

2022-05-05 Thread Maxime Coquelin
On 4/25/22 14:54, David Marchand wrote: Move message handler description and callbacks into a single array and remove unneeded VHOST_USER_MAX and VHOST_SLAVE_MAX enums. Signed-off-by: David Marchand --- drivers/net/virtio/virtio_user/vhost_user.c | 1 - examples/vhost_blk/blk_spec.h

Re: [PATCH] net/vhost: fix TSO feature default disablement

2022-05-05 Thread Maxime Coquelin
On 4/22/22 11:35, Maxime Coquelin wrote: By default, TSO feature should be disabled because it requires application's support to be functionnal as mentionned in the documentation. However, if "tso" devarg was not specified, the feature did not get disabled. This patch fixes this issue, so th

Re: [PATCH] net/virtio: restore some optimisations with AVX512

2022-05-05 Thread Maxime Coquelin
On 4/11/22 17:04, David Marchand wrote: Those optimisations were only enabled with make builds, fix the meson part. Fixes: 77d66da83834 ("net/virtio: add vectorized packed ring Rx") Cc: sta...@dpdk.org Signed-off-by: David Marchand --- drivers/net/virtio/meson.build | 6 +++--- 1 file ch

Re: [PATCH v1 0/2] vhost: add unsafe API to get DMA inflight packets

2022-05-05 Thread Maxime Coquelin
On 4/8/22 12:22, xuan.d...@intel.com wrote: > This patchset introduces an unsafe API to get the number of inflight > packets in DMA engine. It should be only used within the vhost ops > which already holds the lock. Like vring state changes or device is > destroyed. Compared with rte_vhost_asyn

Re: [PATCH] net/vhost: fix access to freed memory

2022-05-05 Thread Maxime Coquelin
On 3/11/22 17:35, Yuan Wang wrote: This patch fixes heap-use-after-free reported by ASan. It is possible for the rte_vhost_dequeue_burst() to access the vq is freed when numa_realloc() gets called in the device running state. The control plane will set the vq->access_lock to protected the vq

Re: [PATCH] net/virtio: support NAPI when using vhost_net backend

2022-05-05 Thread Maxime Coquelin
On 3/2/22 10:41, Harold Huang wrote: In patch [1], NAPI has been supported in kernel tun driver to accelerate packet processing received from vhost_net. This will greatly improve the throughput of the tap device in the vhost_net backend. [1]: https://git.kernel.org/pub/scm/linux/kernel/git/n

Re: [PATCH v4 0/5] vhost: support async dequeue data path

2022-05-05 Thread Maxime Coquelin
Hi Xuan, On 5/5/22 08:23, xuan.d...@intel.com wrote: From: Xuan Ding The presence of asynchronous path allows applications to offload memory copies to DMA engine, so as to save CPU cycles and improve the copy performance. This patch set implements vhost async dequeue data path for split ring.

Re: [PATCH v4 5/5] examples/vhost: support async dequeue data path

2022-05-05 Thread Maxime Coquelin
On 5/5/22 08:23, xuan.d...@intel.com wrote: From: Xuan Ding This patch adds the use case for async dequeue API. Vswitch can leverage DMA device to accelerate vhost async dequeue path. Signed-off-by: Wenwu Ma Signed-off-by: Yuan Wang Signed-off-by: Xuan Ding --- doc/guides/sample_app_ug

Re: [PATCH v4 4/5] vhost: support async dequeue for split ring

2022-05-05 Thread Maxime Coquelin
On 5/5/22 08:23, xuan.d...@intel.com wrote: From: Xuan Ding This patch implements asynchronous dequeue data path for vhost split ring, a new API rte_vhost_async_try_dequeue_burst() is introduced. Signed-off-by: Xuan Ding Signed-off-by: Yuan Wang --- doc/guides/prog_guide/vhost_lib.rst

Re: [PATCH v1 1/2] vhost: add unsafe API to check inflight packets

2022-05-05 Thread Maxime Coquelin
On 4/8/22 12:22, xuan.d...@intel.com wrote: From: Xuan Ding In async data path, when vring state changes or device is destroyed, it is necessary to know the number of inflight packets in DMA engine. This patch provides a thread unsafe API to return the number of inflight packets for a vhost

Re: [PATCH 02/11] examples/l3fwd: fix scalar LPM compilation

2022-05-05 Thread Stephen Hemminger
On Thu, 5 May 2022 19:49:28 +0200 Stanisław Kardach wrote: > On Thu, May 5, 2022 at 7:39 PM Stephen Hemminger > wrote: > > > On Thu, 5 May 2022 19:29:54 +0200 > > Stanislaw Kardach wrote: > > > > > The lpm_process_event_pkt() can either process a packet using an > > > architecture specific

Re: [PATCH 09/11] test/ring: disable problematic tests for RISC-V

2022-05-05 Thread Stephen Hemminger
On Thu, 5 May 2022 19:43:43 +0200 Stanisław Kardach wrote: > On Thu, May 5, 2022 at 7:35 PM Stephen Hemminger > wrote: > > > On Thu, 5 May 2022 19:30:01 +0200 > > Stanislaw Kardach wrote: > > > > > When compiling for RISC-V in debug mode the large amount of inlining in > > > test_ring_basic

Re: [PATCH 02/11] examples/l3fwd: fix scalar LPM compilation

2022-05-05 Thread Stanisław Kardach
On Thu, May 5, 2022 at 7:39 PM Stephen Hemminger wrote: > On Thu, 5 May 2022 19:29:54 +0200 > Stanislaw Kardach wrote: > > > The lpm_process_event_pkt() can either process a packet using an > > architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec) > > path or a scalar one. The

Re: [PATCH 09/11] test/ring: disable problematic tests for RISC-V

2022-05-05 Thread Stanisław Kardach
On Thu, May 5, 2022 at 7:35 PM Stephen Hemminger wrote: > On Thu, 5 May 2022 19:30:01 +0200 > Stanislaw Kardach wrote: > > > When compiling for RISC-V in debug mode the large amount of inlining in > > test_ring_basic_ex() and test_ring_with_exact_size() (in test_ring.c) > > leads to large loop

Re: [PATCH 02/11] examples/l3fwd: fix scalar LPM compilation

2022-05-05 Thread Stephen Hemminger
On Thu, 5 May 2022 19:29:54 +0200 Stanislaw Kardach wrote: > The lpm_process_event_pkt() can either process a packet using an > architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec) > path or a scalar one. The choice is however done using an ifdef > pre-processor macro. Because

Re: [PATCH 09/11] test/ring: disable problematic tests for RISC-V

2022-05-05 Thread Stephen Hemminger
On Thu, 5 May 2022 19:30:01 +0200 Stanislaw Kardach wrote: > When compiling for RISC-V in debug mode the large amount of inlining in > test_ring_basic_ex() and test_ring_with_exact_size() (in test_ring.c) > leads to large loop bodies. This causes 'goto' and 'for' loop > PC-relative jumps generat

[PATCH 11/11] test/hash: report non HTM numbers for single r/w

2022-05-05 Thread Stanislaw Kardach
In hash_readwrite_perf_autotest a single read and write operation is benchmarked for both HTM and non HTM cases. However the result summary only shows the HTM value. Therefore add the non HTM value for completeness. Fixes: 0eb3726ebcf1 ("test/hash: add test for read/write concurrency") Cc: yipeng1

[PATCH 10/11] devtools: add RISC-V to test-meson-builds.sh

2022-05-05 Thread Stanislaw Kardach
Validate RISC-V compilation when test-meson-builds.sh is called. The check will be only performed if appropriate toolchain is present on the system (same as with other architectures). Signed-off-by: Stanislaw Kardach Sponsored-by: Frank Zhao Sponsored-by: Sam Grove --- devtools/test-meson-buil

[PATCH 09/11] test/ring: disable problematic tests for RISC-V

2022-05-05 Thread Stanislaw Kardach
When compiling for RISC-V in debug mode the large amount of inlining in test_ring_basic_ex() and test_ring_with_exact_size() (in test_ring.c) leads to large loop bodies. This causes 'goto' and 'for' loop PC-relative jumps generated by the compiler to go beyond the architecture limitation of +/-1MB

[PATCH 08/11] test/cpuflags: add test for RISC-V cpu flag

2022-05-05 Thread Stanislaw Kardach
From: Michal Mazurek Add checks for all flag values defined in the RISC-V misa CSR register. Signed-off-by: Michal Mazurek Signed-off-by: Stanislaw Kardach Sponsored-by: Frank Zhao Sponsored-by: Sam Grove --- app/test/test_cpuflags.c | 81 1 file cha

[PATCH 07/11] examples/l3fwd: enable RISC-V operation

2022-05-05 Thread Stanislaw Kardach
Add missing em_mask_key() implementation and fix l3fwd_common.h inclusion in FIB lookup functions to enable the l3fwd to be run on RISC-V. Signed-off-by: Stanislaw Kardach Sponsored-by: Frank Zhao Sponsored-by: Sam Grove --- examples/l3fwd/l3fwd_em.c | 8 examples/l3fwd/l3fwd_fib.c |

[PATCH 06/11] net/tap: set BPF syscall ID for RISC-V

2022-05-05 Thread Stanislaw Kardach
Define the missing __NR_bpf syscall id to enable the tap PMD. Signed-off-by: Stanislaw Kardach --- drivers/net/tap/meson.build | 5 - drivers/net/tap/tap_bpf.h | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/tap/meson.build b/drivers/net/tap/meson.build i

[PATCH 05/11] net/memif: set memfd syscall ID on RISC-V

2022-05-05 Thread Stanislaw Kardach
Define the missing __NR_memfd_create syscall id to enable the memif PMD. Signed-off-by: Stanislaw Kardach --- drivers/net/memif/meson.build | 5 - drivers/net/memif/rte_eth_memif.h | 2 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/memif/meson.build b/driv

[PATCH 03/11] eal: add initial support for RISC-V architecture

2022-05-05 Thread Stanislaw Kardach
From: Michal Mazurek Add all necessary elements for DPDK to compile and run EAL on SiFive Freedom U740 SoC which is based on SiFive U74-MC (ISA: rv64imafdc) core complex. This includes: - EAL library implementation for rv64imafdc ISA. - meson build structure for 'riscv' architecture. RTE_ARCH_R

[PATCH 04/11] net/ixgbe: enable vector stubs for RISC-V

2022-05-05 Thread Stanislaw Kardach
Re-use vector processing stubs in ixgbe PMD defined for PPC for RISC-V. This enables ixgbe PMD usage in scalar mode on this architecture. The ixgbe PMD driver was validated with Intel X520-DA2 NIC and the test-pmd application. Packet transfer checked using all UIO drivers available for non-IOMMU p

[PATCH 02/11] examples/l3fwd: fix scalar LPM compilation

2022-05-05 Thread Stanislaw Kardach
The lpm_process_event_pkt() can either process a packet using an architecture specific (defined for X86/SSE, ARM/Neon and PPC64/Altivec) path or a scalar one. The choice is however done using an ifdef pre-processor macro. Because of that the scalar version was apparently not widely excersized/compi

[PATCH 01/11] lpm: add a scalar version of lookupx4 function

2022-05-05 Thread Stanislaw Kardach
From: Michal Mazurek Add an implementation of the rte_lpm_lookupx4() function for platforms without support for vector operations. Signed-off-by: Michal Mazurek Signed-off-by: Stanislaw Kardach Sponsored-by: Frank Zhao Sponsored-by: Sam Grove --- doc/guides/rel_notes/release_22_07.rst | 5

[PATCH 00/11] Introduce support for RISC-V architecture

2022-05-05 Thread Stanislaw Kardach
This patchset adds support for building and running DPDK on 64bit RISC-V architecture. The initial support targets rv64gc (rv64imafdc) ISA and was tested on SiFive Unmatched development board with the Freedom U740 SoC running Linux (freedom-u-sdk based kernel). I have tested this codebase using DPD

[Bug 1005] Build failure with gcc11 in When Using Environment Modules

2022-05-05 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=1005 Bug ID: 1005 Summary: Build failure with gcc11 in When Using Environment Modules Product: DPDK Version: 22.03 Hardware: POWER OS: Linux Status: UNCONFIR

Re: [Patch v2] net/netvsc: report correct stats values

2022-05-05 Thread Ferruh Yigit
On 5/5/2022 5:40 PM, Stephen Hemminger wrote: On Thu, 5 May 2022 17:28:38 +0100 Ferruh Yigit wrote: On 5/4/2022 7:38 PM, Long Li wrote: Subject: Re: [Patch v2] net/netvsc: report correct stats values On 5/3/2022 9:48 PM, Long Li wrote: Subject: Re: [Patch v2] net/netvsc: report correct stat

Re: [Patch v2] net/netvsc: report correct stats values

2022-05-05 Thread Stephen Hemminger
On Thu, 5 May 2022 17:28:38 +0100 Ferruh Yigit wrote: > On 5/4/2022 7:38 PM, Long Li wrote: > >> Subject: Re: [Patch v2] net/netvsc: report correct stats values > >> > >> On 5/3/2022 9:48 PM, Long Li wrote: > Subject: Re: [Patch v2] net/netvsc: report correct stats values > > On

Re: [PATCH 5/5] net/cxgbe: read firmware configuration file from filesystem

2022-05-05 Thread Ferruh Yigit
On 5/5/2022 5:29 PM, Ferruh Yigit wrote: On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote: Add support to read firmware configuration file from /lib/firmware/cxgb4/ path in the filesystem. Hi Rahul, Can you please document the FW config file in the driver documentation? Please add: - Path of th

Re: [PATCH 0/5] net/cxgbe: updates and bug fixes

2022-05-05 Thread Ferruh Yigit
On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote: This series of patches add the following updates and bug fixes to the cxgbe PMD. Patch 1 fixes an issue with wrong port id being filled in mbufs allocated in Rx path. Patch 2 fixes an issue with Txq getting stuck when trying to coalesce mbufs with

Re: [PATCH 5/5] net/cxgbe: read firmware configuration file from filesystem

2022-05-05 Thread Ferruh Yigit
On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote: Add support to read firmware configuration file from /lib/firmware/cxgb4/ path in the filesystem. Hi Rahul, Can you please document the FW config file in the driver documentation? Please add: - Path of the config file - Content of the config file

Re: [PATCH 4/5] net/cxgbe: track packets dropped by TP due to congestion

2022-05-05 Thread Ferruh Yigit
On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote: Rx packets can get dropped at TP due to congestion and this info will not get propagated to MPS. Track these Rx dropped packets in imissed counter. Also add xstats for these counters. Signed-off-by: Rahul Lakkireddy What 'TP' stands for? As far as

Re: [Patch v2] net/netvsc: report correct stats values

2022-05-05 Thread Ferruh Yigit
On 5/4/2022 7:38 PM, Long Li wrote: Subject: Re: [Patch v2] net/netvsc: report correct stats values On 5/3/2022 9:48 PM, Long Li wrote: Subject: Re: [Patch v2] net/netvsc: report correct stats values On 5/3/2022 8:14 PM, Long Li wrote: Subject: Re: [Patch v2] net/netvsc: report correct stats

Re: [PATCH 0/5] refactor for device info dump

2022-05-05 Thread Ferruh Yigit
On 4/14/2022 2:00 PM, Min Hu (Connor) wrote: This patch set contains three patches for refactor, and two patches for bugfix. Min Hu (Connor) (5): net/hns3: refactor adapter state dump net/hns3: refactor feature capability dump net/hns3: refactor queue info dump net/hns3: fix dump TM

[PATCH v1 5/5] net/ark: add PMD support for devices as virtual functions

2022-05-05 Thread Ed Czeck
Add capabilities field isvf to dev struct Disable configuration calls as required by vf Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c | 79 drivers/net/ark/ark_global.h | 1 + 2 files changed, 45 insertions(+), 35 deletions(-) diff --git a/driver

[PATCH v1 4/5] net/ark: add new devices to support list

2022-05-05 Thread Ed Czeck
update device list is doc Signed-off-by: Ed Czeck --- doc/guides/nics/ark.rst | 4 +++- drivers/net/ark/ark_ethdev.c | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst index c965406a7b..cec6fce2ff 100644 --- a/doc/guid

[PATCH v1 3/5] net/ark: update udm code to match current hardware version

2022-05-05 Thread Ed Czeck
new version code remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by hardware remove performance structs as they are not in the hardware module Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 34 +-- drivers/net/ark/ar

[PATCH v1 2/5] net/ark: update ddm code to match current hardware version

2022-05-05 Thread Ed Czeck
new version code remove device-level start, stop, and reset operations add queue-based start, stop and reset as required by hardware Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ddm.c | 80 +- drivers/net/ark/ark_ddm.h | 86 +

[PATCH v1 1/5] net/ark: update mpu code to match current hardware version

2022-05-05 Thread Ed Czeck
new version code remove device-level global operations remove ark_mpu_reset_stats function Signed-off-by: Ed Czeck --- drivers/net/ark/ark_ethdev.c| 2 -- drivers/net/ark/ark_ethdev_rx.c | 4 drivers/net/ark/ark_mpu.c | 21 - drivers/net/ark/ark_mpu.h |

RE: [EXT] [PATCH 0/3] add partial SGL support to AESNI_MB

2022-05-05 Thread De Lara Guarch, Pablo
Hi Akhil, > -Original Message- > From: Akhil Goyal > Sent: Monday, May 2, 2022 10:48 AM > To: Power, Ciara ; dev@dpdk.org; De Lara Guarch, > Pablo > Cc: Zhang, Roy Fan ; Ji, Kai > Subject: RE: [EXT] [PATCH 0/3] add partial SGL support to AESNI_MB > > Hi Pablo, > Can you review this ser

Re: [PATCH 1/2] config/arm: add SVE control flag

2022-05-05 Thread Bruce Richardson
On Thu, May 05, 2022 at 07:57:43PM +0530, Rahul Bhansali wrote: > This add the control flag for SVE to enable or disable > RTE_HAS_SVE_ACLE macro in the build. > > Signed-off-by: Rahul Bhansali > --- > config/arm/meson.build | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --g

Re: [PATCH 2/2] vhost: validate fds attached to messages

2022-05-05 Thread Maxime Coquelin
On 4/25/22 14:54, David Marchand wrote: Some message handlers do not expect any file descriptor attached as ancillary data. Provide a common way to enforce this by adding a accepts_fd boolean in the message handler structure. When a message handler sets accepts_fd to true, it is responsible fo

[PATCH 2/2] config/arm: disable SVE for cn10k

2022-05-05 Thread Rahul Bhansali
This disable the SVE flag for cn10k. Performance impact:- With l3fwd example, lpm lookup performance increased by ~21% if Neon is used instead of SVE. Signed-off-by: Rahul Bhansali --- config/arm/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/config/arm/meson.

[PATCH 1/2] config/arm: add SVE control flag

2022-05-05 Thread Rahul Bhansali
This add the control flag for SVE to enable or disable RTE_HAS_SVE_ACLE macro in the build. Signed-off-by: Rahul Bhansali --- config/arm/meson.build | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 8aead74086..dafb342cc6

Re: [PATCH 1/2] vhost: remove unneeded max enums

2022-05-05 Thread Maxime Coquelin
Hi David, On 4/25/22 14:54, David Marchand wrote: Move message handler description and callbacks into a single array and remove unneeded VHOST_USER_MAX and VHOST_SLAVE_MAX enums. Signed-off-by: David Marchand --- drivers/net/virtio/virtio_user/vhost_user.c | 1 - examples/vhost_blk/blk_sp

Re: [PATCH] net/vhost: get csum offload capabilities of vhost backend

2022-05-05 Thread Maxime Coquelin
Hi Wenwu, On 2/17/22 16:16, Wenwu Ma wrote: The current vhost backend lacks csum offloads information, which will cause testpmd command such as "csum set tcp hw " to fail. This patch adds the information according to the device features. Signed-off-by: Wenwu Ma --- drivers/net/vhost/rte_eth_

Re: [PATCH] net/vhost: fix access to freed memory

2022-05-05 Thread Maxime Coquelin
Hi Yuan, On 3/11/22 17:35, Yuan Wang wrote: This patch fixes heap-use-after-free reported by ASan. It is possible for the rte_vhost_dequeue_burst() to access the vq is freed when numa_realloc() gets called in the device running state. The control plane will set the vq->access_lock to protected

Re: [PATCH] net/virtio: support NAPI when using vhost_net backend

2022-05-05 Thread Maxime Coquelin
Hi Harold, On 3/2/22 10:41, Harold Huang wrote: In patch [1], NAPI has been supported in kernel tun driver to accelerate packet processing received from vhost_net. This will greatly improve the throughput of the tap device in the vhost_net backend. [1]: https://git.kernel.org/pub/scm/linux/ker

[PATCH] ethdev: fix compilation issue with vtune option

2022-05-05 Thread Aman Singh
When VTune profile option is enabled, compilation error is seen. Bugzilla ID: 1004 Fixes: 2c1bbab7f09d ("ethdev: change vtune profiling approach") Cc: ilia.kura...@intel.com Signed-off-by: Aman Singh --- lib/ethdev/ethdev_profile.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/ethdev/

[PATCH v3 28/28] common/cnxk: add support for per-port RQ in inline device

2022-05-05 Thread Nithin Dabilpuram
Add support for per port RQ in inline device thereby using Aura/Pool attributes from that port specific first RQ. When inline device is used with channel masking, it will fallback to single RQ for all ethdev ports. Also remove clamping up of CQ size for LBK ethdev when inline inbound is enabled as

[PATCH v3 04/28] common/cnxk: support to configure the ts pkind in CPT

2022-05-05 Thread Nithin Dabilpuram
From: Vidya Sagar Velumuri Add new API to configure the SA table entries with new CPT PKIND when timestamp is enabled. Signed-off-by: Vidya Sagar Velumuri Acked-by: Ray Kinsella --- drivers/common/cnxk/roc_nix_inl.c | 59 ++ drivers/common/cnxk/roc_nix_inl

[PATCH v3 27/28] net/cnxk: fix hotplug detach sequence for first device

2022-05-05 Thread Nithin Dabilpuram
Fix hotplug detach sequence to handle case where first PCI device that is hosting NPA LF is being destroyed while in use. Fixes: 5a4341c84979 ("net/cnxk: add platform specific probe and remove") Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev.c | 6 +-

[PATCH v3 26/28] net/cnxk: fix multi-seg extraction in vwqe path

2022-05-05 Thread Nithin Dabilpuram
Fix multi-seg extraction in vwqe path to avoid updating mbuf[] array until it is used via cq0 path. Fixes: 7fbbc981d54f ("event/cnxk: support vectorized Rx event fast path") Cc: pbhagavat...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram Acked-by: Pavan Nikhilesh --- drivers/

[PATCH v3 25/28] net/cnxk: perform early MTU setup for eventmode

2022-05-05 Thread Nithin Dabilpuram
Perform early MTU setup for event mode path in order to update the Rx/Tx offload flags before Rx adapter setup starts. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev.c | 11 +++ drivers/net/cnxk/cn9k_ethdev.c | 11 +++ 2 files changed, 22 insertions(+) diff

[PATCH v3 24/28] net/cnxk: add support for flow control for outbound inline

2022-05-05 Thread Nithin Dabilpuram
Add support for flow control in outbound inline path using fc updates from CPT. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev.c | 3 +++ drivers/net/cnxk/cn10k_ethdev.h | 1 + drivers/net/cnxk/cn10k_tx.h | 37 - drivers/net/cnxk/cnxk

[PATCH v3 23/28] net/cnxk: support security stats

2022-05-05 Thread Nithin Dabilpuram
From: Akhil Goyal Enabled rte_security stats operation based on the configuration of SA options set while creating session. Signed-off-by: Vamsi Attunuru Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 56 ++--- 1 file changed, 52 insertion

[PATCH v3 22/28] net/cnxk: add capabilities for IPsec options

2022-05-05 Thread Nithin Dabilpuram
From: Akhil Goyal Added supported capabilities for various IPsec SA options. Signed-off-by: Akhil Goyal Signed-off-by: Vamsi Attunuru --- drivers/net/cnxk/cn10k_ethdev_sec.c | 57 ++--- 1 file changed, 53 insertions(+), 4 deletions(-) diff --git a/drivers/net/

[PATCH v3 21/28] net/cnxk: add capabilities for IPsec crypto algos

2022-05-05 Thread Nithin Dabilpuram
From: Akhil Goyal Added supported crypto algorithms for inline IPsec offload. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 166 1 file changed, 166 insertions(+) diff --git a/drivers/net/cnxk/cn10k_ethdev_sec.c b/drivers/net/cnxk/c

[PATCH v3 20/28] net/cnxk: update olflags with L3/L4 csum offload

2022-05-05 Thread Nithin Dabilpuram
From: Akhil Goyal When the packet is processed with inline IPsec offload, the ol_flags were updated only with RTE_MBUF_F_RX_SEC_OFFLOAD. But the hardware can also update the L3/L4 csum offload flags. Hence, ol_flags are updated with RTE_MBUF_F_RX_IP_CKSUM_GOOD, RTE_MBUF_F_RX_L4_CKSUM_GOOD, etc ba

[PATCH v3 19/28] net/cnxk: optimize Rx fast path for security pkts

2022-05-05 Thread Nithin Dabilpuram
Optimize Rx fast path for security pkts by preprocessing most of the operations such as sa pointer compute, inner wqe pointer fetch and ucode completion translation before the pkt is characterized as inbound inline pkt. Preprocessed info will be discarded if pkt is not found to be security pkt. Als

[PATCH v3 18/28] net/cnxk: support decrement TTL for inline IPsec

2022-05-05 Thread Nithin Dabilpuram
From: Akhil Goyal Added support for decrementing TTL(IPv4)/hoplimit(IPv6) while doing inline IPsec processing if the security session sa options is enabled with dec_ttl. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev.h | 3 ++- drivers/net/cnxk/cn10k_ethdev_sec.c | 1 + drive

[PATCH v3 17/28] net/cnxk: reset offload flag if reassembly is disabled

2022-05-05 Thread Nithin Dabilpuram
From: Akhil Goyal The rx offload flag need to be reset if IP reassembly flag is not set while calling reassembly_conf_set. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/cnxk/cn10k_ethdev.c b/drivers/net/cnxk

[PATCH v3 16/28] net/cnxk: change env for debug IV

2022-05-05 Thread Nithin Dabilpuram
From: Akhil Goyal Changed environment variable name for specifying debug IV for unit testing of inline IPsec offload with known test vectors. Signed-off-by: Akhil Goyal --- drivers/net/cnxk/cn10k_ethdev_sec.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH v3 15/28] net/cnxk: update inline device in ethdev telemetry

2022-05-05 Thread Nithin Dabilpuram
From: Rakesh Kudurumalla inline pf func is updated in ethdev_tel_handle_info when inline device is attached to any dpdk process Signed-off-by: Rakesh Kudurumalla --- drivers/net/cnxk/cnxk_ethdev_telemetry.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/cnxk/cnxk_ethdev_tel

[PATCH v3 14/28] net/cnxk: fix roundup size with transport mode

2022-05-05 Thread Nithin Dabilpuram
For transport mode, roundup needs to be based on L4 data and shouldn't include L3 length. By including l3 length, rlen that is calculated and put in send hdr would cross the final length of the packet in some scenarios where padding is necessary. Also when outer and inner checksum offload flags are

[PATCH v3 13/28] net/cnxk: disable default inner chksum for outb inline

2022-05-05 Thread Nithin Dabilpuram
Disable default inner L3/L4 checksum generation for outbound inline path and enable based on SA options or RTE_MBUF flags as per the spec. Though the checksum generation is not impacting much performance, it is overwriting zero checksum for UDP packets which is not always good. Signed-off-by: Nith

[PATCH v3 12/28] net/cnxk: add barrier after meta batch free in scalar

2022-05-05 Thread Nithin Dabilpuram
Add barrier after meta batch free in scalar routine when lmt lines are exactly full to make sure that next LMT line user in Tx only starts writing the lines only when previous stoerl's are complete. Fixes: 4382a7ccf781 ("net/cnxk: support Rx security offload on cn10k") Cc: sta...@dpdk.org Signed-

[PATCH v3 11/28] net/cnxk: update LBK ethdev link info

2022-05-05 Thread Nithin Dabilpuram
Update link info of LBK ethdev i.e AF's VF's as always up and 100G. This is because there is no phy for the LBK interfaces and we won't get a link update notification for the same. Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cnxk_link.c | 11 +++ 1 file changed, 11 insertions(+

  1   2   >