Undefined reference to symbol while compiling DPPD-PROX

2022-04-27 Thread Avijit Pandey
I have OS: Ubuntu 20.04 with kernel: 5.4.0-42-generic Built DPDK from the following steps: cd /opt export RTE_SDK="/opt/dpdk" export RTE_TARGET="x86_64-native-linuxapp-gcc" export PKG_CONFIG_PATH="/usr/local/lib/x86_64-linux-gnu/pkgconfig" git clone https://github.com/DPDK/dpdk.git git clone http

RE: [PATCH v5 6/7] test/security: add ESN and anti-replay cases for inline

2022-04-27 Thread Anoob Joseph
Hi Akhil, Please see inline. Thanks, Anoob > Subject: [PATCH v5 6/7] test/security: add ESN and anti-replay cases for > inline > > Added cases to test anti replay for inline IPsec processing with and without > extended sequence number support. > > Signed-off-by: Akhil Goyal > --- > app/test

RE: [PATCH] examples/ipsec-secgw: destroy lookaside sessions

2022-04-27 Thread Anoob Joseph
> > Lookaside mode also creates security and crypto sessions that needs to be > destroyed after they are no longer used. > > Signed-off-by: Volodymyr Fialko > --- > examples/ipsec-secgw/ipsec-secgw.c | 48 +- > examples/ipsec-secgw/ipsec.c | 12 > 2 fi

RE: [EXT] [PATCH] examples/ipsec-secgw: fix uninitialized memory access

2022-04-27 Thread Anoob Joseph
> > -- > rte_flow_validate and rte_flow_create not always initialize flow error. > Using error.message in some error cases will cause read from uninitialized > memory. > > Fixes: 6738c0a9569 ("examples/ipsec-secgw: support flow d

[PATCH v9 9/9] net/ice: add warning log for unsupported configuration

2022-04-27 Thread Wenjun Wu
Priority configuration is enabled in level 3 and level 4. Weight configuration is enabled in level 4. This patch adds warning log for unsupported priority and weight configuration. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/

[PATCH v9 8/9] net/ice: support queue group priority configuration

2022-04-27 Thread Wenjun Wu
This patch adds queue group priority configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 4d7bb9102c..f604523ead 100644 --- a/drivers/net/ice/ice_tm.c ++

[PATCH v9 7/9] net/ice: support queue weight configuration

2022-04-27 Thread Wenjun Wu
This patch adds queue weight configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 91e420d653..4d7bb9102c 100644 --- a/drivers/net/i

[PATCH v9 5/9] net/ice: support queue group bandwidth limit

2022-04-27 Thread Wenjun Wu
To set up the exact queue group, we need to reconfigure topology by delete and then recreate queue nodes. This patch adds queue group configuration support and queue group bandwidth limit support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.h | 9 +- drivers/net/ice/ice_tm.c |

[PATCH v9 6/9] net/ice: support queue priority configuration

2022-04-27 Thread Wenjun Wu
This patch adds queue priority configuration support. The highest priority is 0, and the lowest priority is 7. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_

[PATCH v9 1/9] net/ice/base: fix dead lock issue when getting node from ID type

2022-04-27 Thread Wenjun Wu
The function ice_sched_get_node_by_id_type needs to be called with the scheduler lock held. However, the function ice_sched_get_node also requests the scheduler lock. It will cause the dead lock issue. This patch replaces function ice_sched_get_node with function ice_sched_find_node_by_teid to sol

[PATCH v9 4/9] net/ice: support queue bandwidth limit

2022-04-27 Thread Wenjun Wu
From: Ting Xu Enable basic TM API for PF only. Support for adding profiles and queue nodes. Only max bandwidth is supported in profiles. Profiles can be assigned to target queues. Only TC0 is valid. Signed-off-by: Wenjun Wu Signed-off-by: Ting Xu --- doc/guides/rel_notes/release_22_07.rst |

[PATCH v9 2/9] net/ice/base: support queue BW allocation configuration

2022-04-27 Thread Wenjun Wu
This patch adds BW allocation support of queue scheduling node to support WFQ in queue level. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 64 drivers/net/ice/base/ice_sched.h | 3 ++ 2 files changed, 67 insertions(+) diff --git a/drivers/net

[PATCH v9 0/9] Enable ETS-based TX QoS on PF

2022-04-27 Thread Wenjun Wu
This patch set enables ETS-based TX QoS on PF. It is supported to configure bandwidth and priority in both queue and queue group level, and weight only in queue level. v2: fix code style issue. v3: fix uninitialization issue. v4: fix logical issue. v5: fix CI testing issue. Add explicit cast. v6:

[PATCH v9 3/9] net/ice/base: support priority configuration of the exact node

2022-04-27 Thread Wenjun Wu
This patch adds priority configuration support of the exact node in the scheduler tree. This function does not need additional calls to the scheduler lock. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 22 ++ drivers/net/ice/base/ice_sched.h | 3 +++ 2 file

[PATCH v8 9/9] net/ice: add warning log for unsupported configuration

2022-04-27 Thread Wenjun Wu
Priority configuration is enabled in level 3 and level 4. Weight configuration is enabled in level 4. This patch adds warning log for unsupported priority and weight configuration. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/

[PATCH v8 8/9] net/ice: support queue group priority configuration

2022-04-27 Thread Wenjun Wu
This patch adds queue group priority configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 4d7bb9102c..f604523ead 100644 --- a/drivers/net/ice/ice_tm.c ++

[PATCH v8 7/9] net/ice: support queue weight configuration

2022-04-27 Thread Wenjun Wu
This patch adds queue weight configuration support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_tm.c index 91e420d653..4d7bb9102c 100644 --- a/drivers/net/i

[PATCH v8 6/9] net/ice: support queue priority configuration

2022-04-27 Thread Wenjun Wu
This patch adds queue priority configuration support. The highest priority is 0, and the lowest priority is 7. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_tm.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/ice/ice_tm.c b/drivers/net/ice/ice_

[PATCH v8 5/9] net/ice: support queue group bandwidth limit

2022-04-27 Thread Wenjun Wu
To set up the exact queue group, we need to reconfigure topology by delete and then recreate queue nodes. This patch adds queue group configuration support and queue group bandwidth limit support. Signed-off-by: Wenjun Wu --- drivers/net/ice/ice_ethdev.h | 9 +- drivers/net/ice/ice_tm.c |

[PATCH v8 4/9] net/ice: support queue bandwidth limit

2022-04-27 Thread Wenjun Wu
From: Ting Xu Enable basic TM API for PF only. Support for adding profiles and queue nodes. Only max bandwidth is supported in profiles. Profiles can be assigned to target queues. Only TC0 is valid. Signed-off-by: Wenjun Wu Signed-off-by: Ting Xu --- doc/guides/rel_notes/release_22_07.rst |

[PATCH v8 3/9] net/ice/base: support priority configuration of the exact node

2022-04-27 Thread Wenjun Wu
This patch adds priority configuration support of the exact node in the scheduler tree. This function does not need additional calls to the scheduler lock. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 22 ++ drivers/net/ice/base/ice_sched.h | 3 +++ 2 file

[PATCH v8 2/9] net/ice/base: support queue BW allocation configuration

2022-04-27 Thread Wenjun Wu
This patch adds BW allocation support of queue scheduling node to support WFQ in queue level. Signed-off-by: Wenjun Wu --- drivers/net/ice/base/ice_sched.c | 64 drivers/net/ice/base/ice_sched.h | 3 ++ 2 files changed, 67 insertions(+) diff --git a/drivers/net

[PATCH v8 1/9] net/ice/base: fix dead lock issue when getting node from ID type

2022-04-27 Thread Wenjun Wu
The function ice_sched_get_node_by_id_type needs to be called with the scheduler lock held. However, the function ice_sched_get_node also requests the scheduler lock. It will cause the dead lock issue. This patch replaces function ice_sched_get_node with function ice_sched_find_node_by_teid to sol

[PATCH v8 0/9] Enable ETS-based TX QoS on PF

2022-04-27 Thread Wenjun Wu
This patch set enables ETS-based TX QoS on PF. It is supported to configure bandwidth and priority in both queue and queue group level, and weight only in queue level. v2: fix code style issue. v3: fix uninitialization issue. v4: fix logical issue. v5: fix CI testing issue. Add explicit cast. v6:

[PATCH] app/testpmd: fix help of create meter command

2022-04-27 Thread Jin liu
The help message of create meter command is incomplete, lack of policy_id param, update help string. Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color") Cc: sta...@dpdk.org Signed-off-by: Jin liu Signed-off-by: Chaoyong He Signed-off-by: Niklas Söderlund --- app/test-pmd/cmd

[PATCH] pipeline: fix emit instruction for invalid headers

2022-04-27 Thread Cristian Dumitrescu
Fix the emit instruction for the pathological case of all headers to be emitted being invalid. In this case, the for loop was essentially skipped and the last emitted header (or an invalid memory location) getting corrupted by setting its size to 0 through the assignment to ho->n_bytes right after

Re: OVS DPDK DMA-Dev library/Design Discussion

2022-04-27 Thread Bruce Richardson
On Mon, Apr 25, 2022 at 11:46:01PM +0200, Ilya Maximets wrote: > On 4/20/22 18:41, Mcnamara, John wrote: > >> -Original Message- > >> From: Ilya Maximets > >> Sent: Friday, April 8, 2022 10:58 AM > >> To: Hu, Jiayu ; Maxime Coquelin > >> ; Van Haaren, Harry > >> ; Morten Brørup ; > >> Rich

[RFC] ethdev: datapath-focused meter actions

2022-04-27 Thread Alexander Kozyrev
BEGIN:VCALENDAR METHOD:REQUEST PRODID:Microsoft Exchange Server 2010 VERSION:2.0 BEGIN:VTIMEZONE TZID:Eastern Standard Time BEGIN:STANDARD DTSTART:16010101T02 TZOFFSETFROM:-0400 TZOFFSETTO:-0500 RRULE:FREQ=YEARLY;INTERVAL=1;BYDAY=1SU;BYMONTH=11 END:STANDARD BEGIN:DAYLIGHT DTSTART:16010101T02000

Re: [PATCH] net/pcap: support MTU set

2022-04-27 Thread Stephen Hemminger
On Wed, 27 Apr 2022 18:21:37 + Ido Goshen wrote: > > From: Ferruh Yigit > > Sent: Tuesday, 26 April 2022 20:04 > > > > On 3/22/2022 1:02 PM, Ido Goshen wrote: > > > This test > > > https://doc.dpdk.org/dts/test_plans/jumboframes_test_plan.html#test-ca > > > se-jumbo-frames-with-no-jumbo-f

RE: [RFC] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-04-27 Thread Honnappa Nagarahalli
> > > >> Add support for using hugepages for worker lcore stack memory. The > >> intent is to improve performance by reducing stack memory related TLB > >> misses and also by using memory local to the NUMA node of each lcore. > > This is a good idea. Have you measured any performance differences

RE: [PATCH 05/10] baseband/ark: add ark baseband device

2022-04-27 Thread Chautru, Nicolas
Hi John, Do you think this one can be split into a few incremental commits? There are a few TODOs, is that v1 ready for review? Also you are targeting 22.11 right? Thanks Nic > -Original Message- > From: John Miller > Sent: Thursday, April 21, 2022 8:19 AM > To: dev@dpdk.org > Cc: fe

[PATCH v2 5/5] baseband/acc100: add protection for some negative scenario

2022-04-27 Thread Nicolas Chautru
Catch exception in PMD in case of invalid input parameter. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index b588f5f..a13

[PATCH v2 3/5] baseband/acc100: configuration of ACC101 from PF

2022-04-27 Thread Nicolas Chautru
Adding companion function specific to ACC100 and it can be called from bbdev-test when running from PF. Signed-off-by: Nicolas Chautru --- app/test-bbdev/test_bbdev_perf.c | 57 ++ drivers/baseband/acc100/rte_acc100_cfg.h | 17 ++ drivers/baseband/acc100/rte_acc100_pmd.c | 302

[PATCH v2 4/5] baseband/acc100: start explicitly PF Monitor from PMD

2022-04-27 Thread Nicolas Chautru
Ensure the performance monitor is restarted in case this is reset after VF FLR. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 4 drivers/baseband/acc100/rte_acc100_pmd.h | 6 ++ 2 files changed, 10 insertions(+) diff --git a/drivers/baseband/acc100/rte_a

[PATCH v2 0/5] drivers/baseband: PMD to support ACC101 device

2022-04-27 Thread Nicolas Chautru
v2: Based on good feedback from Thomas and David, now implementing the ACC101 PMD as a close derivative from existing ACC100 PMD with hooks to have different behaviour based on variant. This prevents code duplication and only rely on different functions and behaviour when hardware requires or supp

[PATCH v2 2/5] baseband/acc100: modify validation code for ACC101

2022-04-27 Thread Nicolas Chautru
The validation requirement is different for the two devices. Signed-off-by: Nicolas Chautru --- drivers/baseband/acc100/rte_acc100_pmd.c | 40 ++-- 1 file changed, 28 insertions(+), 12 deletions(-) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/base

[PATCH v2 1/5] baseband/acc100: introduce PMD for ACC101

2022-04-27 Thread Nicolas Chautru
Support for ACC101 as a derivative of ACC100. Reusing existing code when possible. Signed-off-by: Nicolas Chautru --- doc/guides/bbdevs/acc101.rst | 237 +++ doc/guides/bbdevs/features/acc101.ini| 13 ++ doc/guides/bbdevs/index.rst | 1

RE: [PATCH] net/pcap: support MTU set

2022-04-27 Thread Ido Goshen
> From: Ferruh Yigit > Sent: Tuesday, 26 April 2022 20:04 > > On 3/22/2022 1:02 PM, Ido Goshen wrote: > > This test > > https://doc.dpdk.org/dts/test_plans/jumboframes_test_plan.html#test-ca > > se-jumbo-frames-with-no-jumbo-frame-support fails for pcap pmd Jumbo > > packet is unexpectedly receiv

Re: [PATCH v2] net/nfp: update how MAX MTU is read

2022-04-27 Thread Niklas Söderlund
Hi Ferruh, On 2022-04-27 10:47:03 +0100, Ferruh Yigit wrote: > On 4/27/2022 9:37 AM, Niklas Söderlund wrote: > > Hello, > > > > I have a question about the Checks that ran on this patch in patchwork > > [1]. It appears the job ci/iol-x86_64-compile-testing, > > dpdk_mingw64_compile have failed on

Re: [RFC] eal: allow worker lcore stacks to be allocated from hugepage memory

2022-04-27 Thread Don Wallwork
On 4/26/2022 8:42 PM, Honnappa Nagarahalli wrote: Add support for using hugepages for worker lcore stack memory. The intent is to improve performance by reducing stack memory related TLB misses and also by using memory local to the NUMA node of each lcore. This is a good idea. Have you measu

RE: [PATCH v3] sched: enable/disable TC OV at runtime

2022-04-27 Thread Singh, Jasvinder
> -Original Message- > From: Danilewicz, MarcinX > Sent: Wednesday, April 27, 2022 10:24 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v3] sched: enable/disable TC OV at runtime > > Added new API to enable or disable TC over su

RE: [PATCH v5 3/7] test/security: add combined mode inline IPsec cases

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, April 27, 2022 4:11 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; ano...@marvell.com; Ananyev, Konstantin > ; Power, Ciara ; > ferruh.yi...@intel.com; andrew.rybche...@oktetl

RE: [PATCH v5 6/7] test/security: add ESN and anti-replay cases for inline

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, April 27, 2022 4:11 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; ano...@marvell.com; Ananyev, Konstantin > ; Power, Ciara ; > ferruh.yi...@intel.com; andrew.rybche...@oktetl

RE: [PATCH v5 7/7] test/security: add inline IPsec IPv6 flow label cases

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, April 27, 2022 4:11 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; ano...@marvell.com; Ananyev, Konstantin > ; Power, Ciara ; > ferruh.yi...@intel.com; andrew.rybche...@oktetl

RE: [PATCH v5 2/7] test/security: add inline inbound IPsec cases

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, April 27, 2022 4:11 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; ano...@marvell.com; Ananyev, Konstantin > ; Power, Ciara ; > ferruh.yi...@intel.com; andrew.rybche...@oktetl

RE: [EXT] [PATCH v4 0/3] cryptodev: move dh type from xform to dh op

2022-04-27 Thread Akhil Goyal
Hi Arek, > Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should > be free to choose for any operation. One xform/session should > be enough to perform both DH operations, if op_type would be xform > member, session would have to be to be created twice for the same > group. Similar problem w

RE: [PATCH v5 1/7] app/test: add unit cases for inline IPsec offload

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, April 27, 2022 4:11 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; ano...@marvell.com; Ananyev, Konstantin > ; Power, Ciara ; > ferruh.yi...@intel.com; andrew.rybche...@oktetl

RE: [PATCH v5 0/7] app/test: add inline IPsec and reassembly cases

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, April 27, 2022 4:11 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; ano...@marvell.com; Ananyev, Konstantin > ; Power, Ciara ; > ferruh.yi...@intel.com; andrew.rybche...@oktetl

RE: [PATCH v3 6/7] test/event: add asymmetric cases for crypto adapter

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 3:37 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subject: [PATCH v3 6/7] test/event:

RE: [PATCH v5 5/7] test/security: add more inline IPsec functional cases

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, April 27, 2022 4:11 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; ano...@marvell.com; Ananyev, Konstantin > ; Power, Ciara ; > ferruh.yi...@intel.com; andrew.rybche...@oktetl

RE: [PATCH v5 4/7] test/security: add inline IPsec reassembly cases

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Wednesday, April 27, 2022 4:11 PM > To: dev@dpdk.org > Cc: tho...@monjalon.net; david.march...@redhat.com; > hemant.agra...@nxp.com; ano...@marvell.com; Ananyev, Konstantin > ; Power, Ciara ; > ferruh.yi...@intel.com; andrew.rybche...@oktetl

RE: [PATCH v3 4/7] test/event: use new API to set event crypto metadata

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 3:37 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subject: [PATCH v3 4/7] test/event:

RE: [PATCH v3 5/7] eventdev: use new API to get event crypto metadata

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 3:37 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subject: [PATCH v3 5/7] eventdev: u

RE: [PATCH v3 3/7] crypto/octeontx: use new API for event metadata

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 3:37 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subject: [PATCH v3 3/7] crypto/octe

RE: [PATCH v3 1/7] cryptodev: add APIs to get/set event metadata

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 3:37 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subject: [PATCH v3 1/7] cryptodev:

RE: [PATCH v3 7/7] test-eventdev: support asym ops for crypto adapter

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 3:37 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subject: [PATCH v3 7/7] test-eventd

Re: [PATCH v3] sched: enable/disable TC OV at runtime

2022-04-27 Thread Stephen Hemminger
On Wed, 27 Apr 2022 08:58:48 + Marcin Danilewicz wrote: > Added new API to enable or disable TC over subscription for best > effort traffic class at subport level. > Added changes after review and increased throughput. > > By default TC OV is disabled. > > Signed-off-by: Marcin Danilewicz

RE: [PATCH v3 0/7] Add new cryptodev op for event metadata

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 3:37 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subject: [PATCH v3 0/7] Add new

RE: [PATCH v3 2/7] crypto/cnxk: add event metadata set operation

2022-04-27 Thread Zhang, Roy Fan
> -Original Message- > From: Akhil Goyal > Sent: Thursday, April 21, 2022 3:37 PM > To: dev@dpdk.org > Cc: ano...@marvell.com; jer...@marvell.com; Gujjar, Abhinandan S > ; Jayatheerthan, Jay > ; Vangati, Narender > ; vfia...@marvell.com; Akhil Goyal > > Subject: [PATCH v3 2/7] crypto/cnxk

Re: [PATCH 2/3] mem: fix ASan shadow for remapped memory segments

2022-04-27 Thread Burakov, Anatoly
On 26-Apr-22 5:07 PM, Burakov, Anatoly wrote: On 26-Apr-22 3:15 PM, David Marchand wrote: On Tue, Apr 26, 2022 at 2:54 PM Burakov, Anatoly wrote: @@ -1040,9 +1040,25 @@ malloc_heap_free(struct malloc_elem *elem)   rte_mcfg_mem_write_unlock();    free_unlock: -   /* Poison memory r

[PATCH v7 2/2] hash: unify crc32 selection for x86 and Arm

2022-04-27 Thread Pavan Nikhilesh
Merge crc32 hash calculation public API implementation for x86 and Arm. Select the best available CRC32 algorithm when unsupported algorithm on a given CPU architecture is requested by an application. Previously, if an application directly includes `rte_crc_arm64.h` without including `rte_hash_crc

[PATCH v7 1/2] hash: split x86 and SW hash CRC intrinsics

2022-04-27 Thread Pavan Nikhilesh
Split x86 and SW hash crc intrinsics into a separate files. Signed-off-by: Pavan Nikhilesh --- v7 Changes: - Fix build with ppc and other arch. v6 Changes: - Simplify rte_hash_crc_set_alg function. (Ruifeng) v5 Changes: - Move CRC functions to implementation specific files to remove ifde

[PATCH v5 7/7] test/security: add inline IPsec IPv6 flow label cases

2022-04-27 Thread Akhil Goyal
From: Vamsi Attunuru Patch adds unit tests for IPv6 flow label set & copy operations. Signed-off-by: Vamsi Attunuru --- app/test/test_cryptodev_security_ipsec.c | 35 ++- app/test/test_cryptodev_security_ipsec.h | 10 +++ app/test/test_security_inline_proto.c| 79 ++

[PATCH v5 6/7] test/security: add ESN and anti-replay cases for inline

2022-04-27 Thread Akhil Goyal
Added cases to test anti replay for inline IPsec processing with and without extended sequence number support. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_proto.c | 308 ++ 1 file changed, 308 insertions(+) diff --git a/app/test/test_security_inline_prot

[PATCH v5 5/7] test/security: add more inline IPsec functional cases

2022-04-27 Thread Akhil Goyal
Added more inline IPsec functional verification cases. These cases do not have known vectors but are verified using encap + decap test for all the algo combinations. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_proto.c | 517 ++ 1 file changed, 517 inserti

[PATCH v5 4/7] test/security: add inline IPsec reassembly cases

2022-04-27 Thread Akhil Goyal
Added unit test cases for IP reassembly of inline IPsec inbound scenarios. In these cases, known test vectors of fragments are first processed for inline outbound processing and then received back on loopback interface for inbound processing along with IP reassembly of the corresponding decrypted p

[PATCH v5 3/7] test/security: add combined mode inline IPsec cases

2022-04-27 Thread Akhil Goyal
Added combined encap and decap test cases for various algorithm combinations Signed-off-by: Akhil Goyal --- app/test/test_security_inline_proto.c | 102 ++ 1 file changed, 102 insertions(+) diff --git a/app/test/test_security_inline_proto.c b/app/test/test_security_inli

[PATCH v5 2/7] test/security: add inline inbound IPsec cases

2022-04-27 Thread Akhil Goyal
Added test cases for inline Inbound protocol offload verification with known test vectors from Lookaside mode. Signed-off-by: Akhil Goyal --- app/test/test_security_inline_proto.c | 65 +++ 1 file changed, 65 insertions(+) diff --git a/app/test/test_security_inline_proto

[PATCH v5 1/7] app/test: add unit cases for inline IPsec offload

2022-04-27 Thread Akhil Goyal
A new test suite is added in test app to test inline IPsec protocol offload. In this patch, predefined vectors from Lookaside IPsec test are used to verify the IPsec functionality without the need of external traffic generators. The sent packet is loopbacked onto the same interface which is receive

[PATCH v5 0/7] app/test: add inline IPsec and reassembly cases

2022-04-27 Thread Akhil Goyal
IP reassembly offload was added in last release. The test app for unit testing IP reassembly of inline inbound IPsec flows is added in this patchset. For testing IP reassembly, base inline IPsec is also added. The app is enhanced in v4 to handle more functional unit test cases for inline IPsec simi

[PATCH 17/17] net/bnxt: don't wait for link up completion in dev start

2022-04-27 Thread Kalesh A P
From: Somnath Kotur Invoking bnxt_link_update_op() with wait_for_completion set would result in the driver waiting for 10s in case the port link is down to complete port initialization (dev_start_op()). Change it by not waiting for the completion when invoking it in dev_start_op() Signed-off-by:

[PATCH 16/17] net/bnxt: fix freeing of VNIC filters

2022-04-27 Thread Kalesh A P
From: Somnath Kotur In bnxt_free_all_filters(), all the filters attached to a vnic are removed. But each of these filters hold a backreference ptr to the vnic and they need to be reset to NULL now. Otherwise, during a normal testpmd quit, as part of dev_close_op(), first bnxt_free_all_filters() i

[PATCH 15/17] net/bnxt: recheck FW readiness if FW is in reset process

2022-04-27 Thread Kalesh A P
From: Kalesh AP If Firmware is still in reset process and returns the error HWRM_ERR_CODE_HOT_RESET_PROGRESS, retry VER_GET command. We have to do it in bnxt_handle_if_change_status(). Fixes: 0b533591238f ("net/bnxt: inform firmware about IF state changes") Cc: sta...@dpdk.org Signed-off-by: Ka

[PATCH 13/17] net/bnxt: force PHY update on certain configurations

2022-04-27 Thread Kalesh A P
From: Kalesh AP Device is not obliged link down in certain scenarios, even when forced. When FW does not allow any user other than the BMC to shutdown the port, bnxt_get_hwrm_link_config() call always returns link up. Force phy update always in that case, else user configuration for speed/autoneg

[PATCH 14/17] net/bnxt: fix reporting link status when port is stopped

2022-04-27 Thread Kalesh A P
From: Kalesh AP Driver forces link down during port stop. But device is not obliged link down in certain scenarios, even when forced. In that case, subsequent link queries returns link as up. Fixed to return link status as down when port is stopped. Driver is already doing that for VF/NPAR/MH fun

[PATCH 12/17] net/bnxt: fix setting autoneg speed

2022-04-27 Thread Kalesh A P
From: Kalesh AP The "active_fec_signal_mode" in HWRM_PORT_PHY_QCFG response does not return correct value till the link is up. Driver cannot rely on active_fec_signal_mode while setting autoneg speed. While setting autoneg speed, driver is currently checking only "auto_link_speed_mask". Fixed to

[PATCH 11/17] net/bnxt: avoid unnecessary endianness conversion

2022-04-27 Thread Kalesh A P
From: Kalesh AP The "active_fec_signal_mode" in HWRM_PORT_PHY_QCFG response is uint8_t. So no need of endianness conversion while parsing response. Also, signal_mode is the first 4bits of "active_fec_signal_mode". Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link") Cc: sta...@dpdk.org Sign

[PATCH 10/17] net/bnxt: fix to handle queue stop during RSS flow create

2022-04-27 Thread Kalesh A P
From: Somnath Kotur The programming of the RSS table was not taking into account if any of the queues in the set were stopped prior to the flow creation, hence leading to a vnic RSS config cmd failure thrown by the FW. Fix by programming only the active queues in the RSS action queue set. Fixes:

[PATCH 09/17] net/bnxt: add check for dupliate queue ids

2022-04-27 Thread Kalesh A P
From: Kalesh AP Currently driver does not have a check for duplicate queue ids. User must either specify all Rx queues created or no queues in the flow create command. Repeating the queue index is invalid. Also, moved the check for invalid queue to the beginning of the function. Fixes: 239695f7

[PATCH 08/17] net/bnxt: fix to reconfigure the VNIC's default receive ring

2022-04-27 Thread Kalesh A P
From: Somnath Kotur When an Rx queue is stopped and restarted, as part of that workflow, for cards that have ring groups, we free and reallocate the ring group. This new ring group is not communicated to the VNIC though via HWRM_VNIC_CFG cmd. Fix to issue HWRM_VNIC_CFG cmd on all adapters now in

[PATCH 07/17] net/bnxt: fix RSS action support

2022-04-27 Thread Kalesh A P
From: Kalesh AP Specifying a subset of Rx queues created by the application in the "flow create" command is invalid. User must either specify all Rx queues created or no queues. Also removed a wrong comment as RSS action will not be supported if user or application specifies MARK or COUNT action

[PATCH 06/17] net/bnxt: remove support for COUNT action

2022-04-27 Thread Kalesh A P
From: Somnath Kotur 'Count' action was never really implemented in the legacy/AFM model. But there was some place holder code, remove it so that the user will see a failure when a flow with 'count' action is being created. Signed-off-by: Somnath Kotur Reviewed-by: Kalesh AP --- drivers/net/bn

[PATCH 05/17] net/bnxt: fix support for tunnel stateless offloads

2022-04-27 Thread Kalesh A P
From: Kalesh AP The HW only supports tunnel header parsing globally for supported tunnel types. When a function uses one default VNIC to receive both the tunnel and non-tunnel packets, applying the same stateless offload operation to both tunnel and non-tunnel packets can cause problems in certai

[PATCH 04/17] net/bnxt: fix Rxq configure

2022-04-27 Thread Kalesh A P
From: Kalesh AP We are currently not handling RX/RSS modes correctly. After launching testpmd with multiple RXQs, if the user tries to set the number of RXQs to 1, driver is not updating the "hash_type" and "hash_mode" values of the VNICs. As a result, driver issues bnxt_vnic_rss_configure() unne

[PATCH 03/17] net/bnxt: fix to remove an unused macro

2022-04-27 Thread Kalesh A P
From: Kalesh AP BNXT_FLAG_UPDATE_HASH is redundant now, remove it. Fixes: 1ebb765090a6 ("net/bnxt: fix config RSS update") Cc: sta...@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde Reviewed-by: Somnath Kotur --- drivers/net/bnxt/bnxt.h| 1 - drivers/net/bnxt/bnxt_ethde

[PATCH 02/17] net/bnxt: fix device capability reporting

2022-04-27 Thread Kalesh A P
From: Kalesh AP 1. Added two functions bnxt_get_tx_port_offloads() and bnxt_get_rx_port_offloads() to report the device tx/rx offload capabilities to the application. 2. This avoids few duplicate code in the driver and make VF-rep capability the same as VF. 3. This will help in selective

[dpdk-dev] [PATCH 00/17] bnxt PMD fixes

2022-04-27 Thread Kalesh A P
From: Kalesh AP This patch set contains bug fixes in bnxt PMD. Please apply. Kalesh AP (12): net/bnxt: update HWRM structures net/bnxt: fix device capability reporting net/bnxt: fix to remove an unused macro net/bnxt: fix Rxq configure net/bnxt: fix support for tunnel stateless offload

RE: OVS DPDK DMA-Dev library/Design Discussion

2022-04-27 Thread Mcnamara, John
> -Original Message- > From: Ilya Maximets > Sent: Monday, April 25, 2022 10:46 PM > To: Mcnamara, John ; Hu, Jiayu > ; Maxime Coquelin ; Van > Haaren, Harry ; Morten Brørup > ; Richardson, Bruce > > Cc: i.maxim...@ovn.org; Pai G, Sunil ; Stokes, > Ian ; Ferriter, Cian ; > ovs-...@openv

[PATCH] doc: describe ixgbe devargs fiber_sdp3_no_tx_disable

2022-04-27 Thread Jeff Daly
The devargs option for the IXGBE driver is introduced in order to inform the driver to skip checking SDP3 as an indicator of laser enable/disable for SFP modules. Signed-off-by: Jeff Daly --- doc/guides/nics/ixgbe.rst | 17 + 1 file changed, 17 insertions(+) diff --git a/doc/gui

[PATCH v6 2/2] hash: unify crc32 selection for x86 and Arm

2022-04-27 Thread Pavan Nikhilesh
Merge crc32 hash calculation public API implementation for x86 and Arm. Select the best available CRC32 algorithm when unsupported algorithm on a given CPU architecture is requested by an application. Previously, if an application directly includes `rte_crc_arm64.h` without including `rte_hash_crc

[PATCH v6 1/2] hash: split x86 and SW hash CRC intrinsics

2022-04-27 Thread Pavan Nikhilesh
Split x86 and SW hash crc intrinsics into a separate files. Signed-off-by: Pavan Nikhilesh --- v6 Changes: - Simplify rte_hash_crc_set_alg function. (Ruifeng) v5 Changes: - Move CRC functions to implementation specific files to remove ifdef clutter. (Ruifeng) lib/hash/hash_crc_sw.h | 419

Re: [PATCH 1/2] app/testpmd: fix stats get when display fwd stats

2022-04-27 Thread Singh, Aman Deep
On 4/6/2022 2:15 PM, Min Hu (Connor) wrote: In function 'fwd_stats_display', if function 'rte_eth_stats_get' fails, 'stats' is uncertainty value. The display result will be abnormal. This patch check the return value of 'rte_eth_stats_get' to avoid display abnormal stats. Fixes: 53324971a14e

[PATCH 3/3 v2] event/cnxk: implement event port quiesce function

2022-04-27 Thread Pavan Nikhilesh
Implement event port quiesce function to clean up any lcore resources used. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 78 ++--- drivers/event/cnxk/cn9k_eventdev.c | 60 +- 2 files changed, 130 insertions(+), 8 deletions(

[PATCH 1/3 v2] eventdev: add function to quiesce an event port

2022-04-27 Thread Pavan Nikhilesh
Add function to quiesce any core specific resources consumed by the event port. When the application decides to migrate the event port to another lcore or teardown the current lcore it may to call `rte_event_port_quiesce` to make sure that all the data associated with the event port are released f

[PATCH 2/3 v2] eventdev: update examples to use port quiesce

2022-04-27 Thread Pavan Nikhilesh
Quiesce event ports used by the workers core on exit to free up any outstanding resources. Signed-off-by: Pavan Nikhilesh --- Depends-on: Series-22677 app/test-eventdev/test_perf_common.c | 8 app/test-eventdev/test_pipeline_common.c | 12 examples/eventdev_p

[PATCH 3/3] event/cnxk: implement event port quiesce function

2022-04-27 Thread Pavan Nikhilesh
Implement event port quiesce function to clean up any lcore resources used. Signed-off-by: Pavan Nikhilesh Change-Id: I7dda3d54dc698645d25ebbfbabd81760940fe649 --- drivers/event/cnxk/cn10k_eventdev.c | 78 ++--- drivers/event/cnxk/cn9k_eventdev.c | 60 +++

[PATCH 2/3] eventdev: update examples to use port quiesce

2022-04-27 Thread Pavan Nikhilesh
Quiesce event ports used by the workers core on exit to free up any outstanding resources. Signed-off-by: Pavan Nikhilesh Change-Id: Iea1f933d4f4926630d82a9883fbe3f1e75876097 --- Depends-on: Series-22677 app/test-eventdev/test_perf_common.c | 8 app/test-eventdev/test_pipelin

[PATCH 1/3] eventdev: add function to quiesce an event port

2022-04-27 Thread Pavan Nikhilesh
Add function to quiesce any core specific resources consumed by the event port. When the application decides to migrate the event port to another lcore or teardown the current lcore it may to call `rte_event_port_quiesce` to make sure that all the data associated with the event port are released f

[Bug 996] DPDK:20.11.1: net/ena crash while fetching xstats

2022-04-27 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=996 Michal Krawczyk (m...@semihalf.com) changed: What|Removed |Added Resolution|WONTFIX |--- Status|RESOL

RE: [PATCH] doc: fix support table for ETH and VLAN flow items

2022-04-27 Thread Asaf Penso
>-Original Message- >From: Ferruh Yigit >Sent: Tuesday, April 26, 2022 1:48 PM >To: Asaf Penso ; Ilya Maximets ; >dev@dpdk.org; Ori Kam >Cc: Ajit Khaparde ; Rahul Lakkireddy >; Hemant Agrawal >; Haiyue Wang ; John >Daley ; Guoyang Zhou ; >Min Hu (Connor) ; Beilei Xing >; Jingjing Wu ; Qi

  1   2   >