Hi Arek, > Operation type (PUBLIC_KEY_GENERATION, SHARED_SECRET) should > be free to choose for any operation. One xform/session should > be enough to perform both DH operations, if op_type would be xform > member, session would have to be to be created twice for the same > group. Similar problem would be observed in sessionless case. > Additionally, it will help extend DH to support Elliptic Curves. > rte_crypto_asym_op_type is moved to rte_crypto_dh_op_param. But why not move to rte_crypto_asym_op? I see that in other ops also, Op_type is there, we can move that out. Right?
Also, I see one more potential issue. There is a union of various ops in rte_crypto_asym_op, but how will User identify which one to use. There should be a union to identify which Struct to choose from. > v4: > - changed op_type coment > - added openssl fix > > Arek Kusztal (3): > cryptodev: move dh type from xform to dh op > crypto/openssl: move dh type from xform to dh op > test/crypto: move dh type from xform to dh op > > app/test/test_cryptodev_asym.c | 11 +++--- > drivers/crypto/openssl/rte_openssl_pmd.c | 54 > ++-------------------------- > drivers/crypto/openssl/rte_openssl_pmd_ops.c | 26 -------------- > lib/cryptodev/rte_crypto_asym.h | 14 ++++---- > 4 files changed, 16 insertions(+), 89 deletions(-) > > -- > 2.13.6
