[PATCH] crypto/qat: fix a memory leak in error branch

2022-02-18 Thread Weiguo Li
Fixes: 1703e94ac5ce ("qat: add driver for QuickAssist devices") Signed-off-by: Weiguo Li --- drivers/crypto/qat/qat_sym_session.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/crypto/qat/qat_sym_session.c b/drivers/crypto/qat/qat_sym_session.c index 8ca475ca8b..fa7d020d0e 100644 -

[PATCH v7 11/11] app/testpmd: add async indirect actions operations

2022-02-18 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_async_action_handle API. Provide the command line interface for operations dequeue. Usage example: flow queue 0 indirect_action 0 create action_id 9 ingress postpone yes action rss / end flow queue 0 indirect_action 0 update action_id 9 action queue

[PATCH v7 10/11] app/testpmd: add flow queue pull operation

2022-02-18 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_pull API. Provide the command line interface for pulling operations results. Usage example: flow pull 0 queue 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 +++- app/test-pmd/config.c

[PATCH v7 09/11] app/testpmd: add flow queue push operation

2022-02-18 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_push API. Provide the command line interface for pushing operations. Usage example: flow queue 0 push 0 Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- app/test-pmd/cmdline_flow.c | 56 - app/test-pmd/config.c

[PATCH v7 08/11] app/testpmd: add async flow create/destroy operations

2022-02-18 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_q_create/rte_flow_q_destroy API. Provide the command line interface for enqueueing flow creation/destruction operations. Usage example: testpmd> flow queue 0 create 0 postpone no template_table 6 pattern_template 0 actions_template 0 patt

[PATCH v7 07/11] app/testpmd: add flow table management

2022-02-18 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_table API. Provide the command line interface for the flow table creation/destruction. Usage example: testpmd> flow template_table 0 create table_id 6 group 9 priority 4 ingress mode 1 rules_number 64 pattern_template 2 actions_template 4 testpmd> fl

[PATCH v7 05/11] app/testpmd: add flow engine configuration

2022-02-18 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_configure API. Provide the command line interface for the Flow management. Usage example: flow configure 0 queues_number 8 queues_size 256 Implement rte_flow_info_get API to get available resources: Usage example: flow info 0 Signed-off-by: Alexander Kozyrev

[PATCH v7 06/11] app/testpmd: add flow template management

2022-02-18 Thread Alexander Kozyrev
Add testpmd support for the rte_flow_pattern_template and rte_flow_actions_template APIs. Provide the command line interface for the template creation/destruction. Usage example: testpmd> flow pattern_template 0 create pattern_template_id 2 template eth dst is 00:16:3e:31:15:c3 / end

[PATCH v7 04/11] ethdev: bring in async indirect actions operations

2022-02-18 Thread Alexander Kozyrev
Queue-based flow rules management mechanism is suitable not only for flow rules creation/destruction, but also for speeding up other types of Flow API management. Indirect action object operations may be executed asynchronously as well. Provide async versions for all indirect action operations, nam

[PATCH v7 03/11] ethdev: bring in async queue-based flow rules operations

2022-02-18 Thread Alexander Kozyrev
A new, faster, queue-based flow rules management mechanism is needed for applications offloading rules inside the datapath. This asynchronous and lockless mechanism frees the CPU for further packet processing and reduces the performance impact of the flow rules creation/destruction on the datapath.

[PATCH v7 02/11] ethdev: add flow item/action templates

2022-02-18 Thread Alexander Kozyrev
Treating every single flow rule as a completely independent and separate entity negatively impacts the flow rules insertion rate. Oftentimes in an application, many flow rules share a common structure (the same item mask and/or action list) so they can be grouped and classified together. This knowl

[PATCH v7 01/11] ethdev: introduce flow engine configuration

2022-02-18 Thread Alexander Kozyrev
The flow rules creation/destruction at a large scale incurs a performance penalty and may negatively impact the packet processing when used as part of the datapath logic. This is mainly because software/hardware resources are allocated and prepared during the flow rule creation. In order to optimi

[PATCH v7 00/10] ethdev: datapath-focused flow rules management

2022-02-18 Thread Alexander Kozyrev
Three major changes to a generic RTE Flow API were implemented in order to speed up flow rule insertion/destruction and adapt the API to the needs of a datapath-focused flow rules management applications: 1. Pre-configuration hints. Application may give us some hints on what type of resources are

RE: [PATCH v2] ip_frag: add IPv4 options fragment and test data

2022-02-18 Thread Ananyev, Konstantin
Hi Huichao, > According to RFC791,the options may appear or not in datagrams. > They must be implemented by all IP modules (host and gateways). > What is optional is their transmission in any particular datagram, > not their implementation.So we have to deal with it during the > fragmenting proce

Re: [PATCH 1/2] net/af_xdp: ensure xsk is deleted on Rx queue setup error

2022-02-18 Thread Ferruh Yigit
On 2/18/2022 11:20 AM, Ciara Loftus wrote: The Rx queue setup can fail for many reasons eg. failure to setup the custom program, failure to allocate or reserve fill queue buffers, failure to configure busy polling etc. When a failure like one of these occurs, if the xsk is already set up it shoul

Re: [PATCH 2/2] net/af_xdp: reserve fill queue before socket create

2022-02-18 Thread Ferruh Yigit
On 2/18/2022 11:20 AM, Ciara Loftus wrote: Some zero copy AF_XDP drivers eg. ice require that there are addresses already in the fill queue before the socket is created. Otherwise you may see log messages such as: XSK buffer pool does not provide enough addresses to fill 2047 buffers on Rx ring

[PATCH] net/bnxt: fix a memory leak when new malloc fail

2022-02-18 Thread Weiguo Li
When new memory is not available and the memory "ctx" allocated beforehand was not assigned to anywhere, so "ctx" should be freed, otherwise will cause a memory leak. Fixes: b4f740511655 ("net/bnxt: remove unnecessary return check") Signed-off-by: Weiguo Li --- drivers/net/bnxt/bnxt_hwrm.c | 1

[PATCH] common/dpaax: fix a memory leak in iterate dir

2022-02-18 Thread Weiguo Li
Release the memory when error occur. Fixes: 2183c6f69d7e ("bus/dpaa: add OF parser for device scanning") Signed-off-by: Weiguo Li --- drivers/common/dpaax/dpaa_of.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/common/dpaax/dpaa_of.c b/drivers/common/dpaax/dpaa_

Re: [PATCH v6 00/11] Add cnxk_gpio

2022-02-18 Thread Thomas Monjalon
> Tomasz Duszynski (11): > raw/cnxk_gpio: add GPIO driver skeleton > raw/cnxk_gpio: support reading default queue conf > raw/cnxk_gpio: support reading queue count > raw/cnxk_gpio: support queue setup > raw/cnxk_gpio: support queue release > raw/cnxk_gpio: support enqueuing buffers >

[dpdk-dev v9 8/9] crypto/qat: unify raw data path functions

2022-02-18 Thread Kai Ji
This patch unifies QAT's raw dp api implementations to the same enqueue/dequeue methods used in crypto operations. The specific functions for different QAT generation are updated respectively. The qat_sym_hw_dp.c is removed as no longer required. Signed-off-by: Kai Ji --- drivers/common/qat/meso

[dpdk-dev v9 7/9] crypto/qat: rework burst data path

2022-02-18 Thread Kai Ji
This patch enable the op_build_request function in qat_enqueue_op_burst, and the qat_dequeue_process_response function in qat_dequeue_op_burst. The op_build_request invoked in crypto build request op is based on crypto operations setup'd during session init. Signed-off-by: Kai Ji --- drivers/com

[dpdk-dev v9 9/9] crypto/qat: support out of place SG list

2022-02-18 Thread Kai Ji
This patch adds the SGL out of place support to QAT PMD Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 28 -- drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 14 - drivers/crypto/qat/dev/qat_sym_pmd_gen1.c| 55 +--- 3 files changed, 83 ins

[dpdk-dev v9 6/9] crypto/qat: unify asymmetric functions

2022-02-18 Thread Kai Ji
This patch removes qat_asym_pmd.c and integrates all the functions into qat_asym.c. The unified/integrated asym crypto pmd functions should make them easier to maintain. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build| 2 +- drivers/crypto/qat/qat_asym.c | 180

[dpdk-dev v9 5/9] crypto/qat: unify symmetric functions

2022-02-18 Thread Kai Ji
This patch removes qat_sym_pmd.c and integrates all the functions into qat_sym.c. The unified/integrated qat sym crypto pmd functions should make them easier to maintain. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 4 +- drivers/common/qat/qat_device.c | 4 +- drive

[dpdk-dev v9 4/9] crypto/qat: rework asymmetric op build operation

2022-02-18 Thread Kai Ji
This patch reworks the asymmetric crypto data path implementation in QAT driver. The changes include asymmetric crypto data path separation for QAT hardware generations, and code optimisation of the device capabilities declaration. Signed-off-by: Kai Ji --- drivers/common/qat/qat_qp.c | 5 +-

[dpdk-dev v9 2/9] crypto/qat: support symmetric build op request

2022-02-18 Thread Kai Ji
This patch adds common inline functions for QAT symmetric crypto driver to process crypto op, and the implementation of build op request function for QAT generation 1. Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 832 ++- drivers/crypto/qat/dev/qat_sym

[dpdk-dev v9 3/9] crypto/qat: rework session functions

2022-02-18 Thread Kai Ji
This patch introduces a set of set_session methods to QAT generations. In addition, the reuse of QAT session between generations is prohibit as the support of min_qat_dev_gen_id' is removed. Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_asym_pmd_gen1.c | 9 +- drivers/crypto/qat/dev/q

[dpdk-dev v9 1/9] common/qat: define build request and dequeue ops

2022-02-18 Thread Kai Ji
This patch introduce build request and dequeue op function pointers to the qat queue pair implementation. The function poniters are assigned during qat session generation based on input crypto operation request. Signed-off-by: Kai Ji --- drivers/common/qat/qat_qp.c | 10 -- drivers/

[dpdk-dev v9 0/9] drivers/qat: QAT symmetric crypto datapatch rework

2022-02-18 Thread Kai Ji
This patch reworks QAT symmetric crypto datapatch implementation where each generation request building separated and the crypto operation under the raw datapath api implementation are unified. In addtion this patchset also enables QAT OOP support in raw datapath api implementation. v9: - commit

[PATCH] baseband/acc100: fix a memory leak in acc100 queue setup

2022-02-18 Thread Weiguo Li
Add a memory free in error branch. Fixes: 060e76729302 ("baseband/acc100: add queue configuration") Signed-off-by: Weiguo Li --- drivers/baseband/acc100/rte_acc100_pmd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_a

Re: [PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd

2022-02-18 Thread Ferruh Yigit
On 2/17/2022 10:14 AM, wenxuanx...@intel.com wrote: From: wenxuan wu There is a heap-free-after-use bug when quit testpmd with pf and vfs, stop and close ports in reverse order is a more reasonable approach. Cc: sta...@dpdk.org Signed-off-by: wenxuan wu --- lib/ethdev/rte_ethdev.h | 14 +++

Re: [PATCH 1/2] app/testpmd: fix quit testpmd with vfs and pf

2022-02-18 Thread Ferruh Yigit
On 2/17/2022 10:14 AM, wenxuanx...@intel.com wrote: From: wenxuan wu When testpmd startups with pf and vfs,this error occurs when quitting, results in pf is released before vfs ,so the vf would access an freed heap memory. The solution is that release our allocated ports in reverse order,add t

[PATCH 4/4] crypto/ipsec_mb: fix length and offset settings

2022-02-18 Thread Pablo de Lara
KASUMI, SNOW3G and ZUC require lengths and offsets to be set in bits or bytes depending on the algorithm. There were some algorithms that were mixing these two, so this commit is fixing this issue. Fixes: ae8e085c608d ("crypto/aesni_mb: support KASUMI F8/F9") Fixes: 6c42e0cf4d12 ("crypto/aesni_mb:

[PATCH 3/4] crypto/ipsec_mb: fix crypto operation overwrite

2022-02-18 Thread Pablo de Lara
ZUC PMD batches crypto operations depending on their type (encryption + tag generation, tag verification + decryption, etc), to allow parallelization. The array used to store the pointers to these operations was always the same array provided by dequeue_burst() function, and it was looping around t

[PATCH 2/4] crypto/ipsec_mb: fix ZUC authentication verify

2022-02-18 Thread Pablo de Lara
ZUC authentication is done over multiple buffers at a time. When authentication verification is done, multiple scratch buffers are using to generate the tags that will be compared afterwards. However, the same scratch buffer was used always, instead of having different ones for each crypto operatio

[PATCH 1/4] crypto/ipsec_mb: check for missing operation types

2022-02-18 Thread Pablo de Lara
When processing crypto operations in ZUC PMD, there were two operation types that were set at session level, but not checked when the operations are enqueued and processed, leaving the buffers untouched silently. Fixes: cde8df1bda9d ("crypto/ipsec_mb: move zuc PMD") Cc: piotrx.bronow...@intel.com

[PATCH 0/4] ipsec_mb fixes for ZUC algorithm

2022-02-18 Thread Pablo de Lara
This patchset fixes various issues affecting ZUC and AESNI MB PMD, when ZUC algorithm is used. Pablo de Lara (4): crypto/ipsec_mb: check for missing operation types crypto/ipsec_mb: fix ZUC authentication verify crypto/ipsec_mb: fix crypto operation overwrite crypto/ipsec_mb: fix length an

Re: [PATCH] app/pdump: check lcore is not the maximum core

2022-02-18 Thread Stephen Hemminger
On Fri, 18 Feb 2022 15:18:41 + Reshma Pattan wrote: > lcore_id = rte_get_next_lcore(lcore_id, 1, 0); > + if (lcore_id == RTE_MAX_LCORE) { > + printf("Invalid core %u for the packet capture!\n", lcore_id); > + return; > + } Since nothing useful can be don

Re: [PATCH v1 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Stephen Hemminger
On Fri, 18 Feb 2022 07:41:45 + Megha Ajmera wrote: > diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst > b/doc/guides/sample_app_ug/qos_scheduler.rst > index 49c14a00da..7016ca4078 100644 > --- a/doc/guides/sample_app_ug/qos_scheduler.rst > +++ b/doc/guides/sample_app_ug/qos_scheduler.

Re: [PATCH] net/sfc: fix the argument to sizeof for unit cache

2022-02-18 Thread Ferruh Yigit
On 2/18/2022 2:43 PM, Andrew Rybchenko wrote: On 2/18/22 17:38, Ferruh Yigit wrote: On 12/21/2021 6:41 AM, Weiguo Li wrote: The size of unit cache should be sizeof(**cache) instead of sizeof(*cache). Memory reallocation is inadequate by sizeof(*cache) for the platform whose size of pointer is 3

[PATCH] net/ice: fix overwriting of LSE bit by DCF

2022-02-18 Thread Michal Wilczynski
After enabling DCF on a VF, the ice driver stops receiving link updates on it's Admin Receive Queue. During the init of DCF ice_aqc_opc_get_link_status command is send to the firmware without LSE(LINK STATUS EVENT) bit set. This prevents the ice driver from receiving up/down events, and correspondi

Re: [PATCH 1/3] common/sfc_efx/base: fix recirculation ID set in outer rules

2022-02-18 Thread Ferruh Yigit
On 2/17/2022 10:25 PM, Ivan Malov wrote: Recirculation ID field of MAE outer rule insert MCDI is part of the lookup control structure and it has non-zero bit offset relative to the byte offset of the structure. Fixes: 5cf153e79c6c ("common/sfc_efx/base: support recirculation ID in outer rules")

[PATCH] app/pdump: check lcore is not the maximum core

2022-02-18 Thread Reshma Pattan
Check lcore id value is not the maximum core supported. Using lcore id without this check might cause out of bound access inside the rte_eal_wait_lcore. Coverity issue: 375841 Fixes: b2854d5317e8 ("app/pdump: support multi-core capture") Cc: vipin.vargh...@intel.com Cc: sta...@dpdk.org Signed-off

Re: [PATCH] net/sfc: fix the argument to sizeof for unit cache

2022-02-18 Thread Andrew Rybchenko
On 2/18/22 17:38, Ferruh Yigit wrote: On 12/21/2021 6:41 AM, Weiguo Li wrote: The size of unit cache should be sizeof(**cache) instead of sizeof(*cache). Memory reallocation is inadequate by sizeof(*cache) for the platform whose size of pointer is 32-bits. Found by coccinelle (see https://coccin

Re: [PATCH] net/sfc: fix the argument to sizeof for unit cache

2022-02-18 Thread Ferruh Yigit
On 12/21/2021 6:41 AM, Weiguo Li wrote: The size of unit cache should be sizeof(**cache) instead of sizeof(*cache). Memory reallocation is inadequate by sizeof(*cache) for the platform whose size of pointer is 32-bits. Found by coccinelle (see https://coccinelle.gitlabpages.inria.fr/website) scri

RE: [PATCH] crypto: fix asymmetric private session variable size

2022-02-18 Thread Zhang, Roy Fan
> -Original Message- > From: Power, Ciara > Sent: Friday, February 18, 2022 12:58 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; gak...@marvell.com; Kusztal, > ArkadiuszX ; Power, Ciara > > Subject: [PATCH] crypto: fix asymmetric private session variable size > > When creating the asymmetr

Re: [PATCH 2/4] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-02-18 Thread Nithin Kumar Dabilpuram
On 2/18/22 12:47 AM, Ananyev, Konstantin wrote: Enable Tx IPv4 checksum offload only when Tx inline crypto is needed. In other cases such as Tx Inline protocol offload, checksum computation is implicitly taken care by HW. Why is that? These is two separate HW offload and user has to enable

Re: [PATCH v2] eventdev/eth_rx: fix queue config get logic

2022-02-18 Thread Jerin Jacob
On Tue, Feb 15, 2022 at 10:24 PM Jayatheerthan, Jay wrote: > > Looks good. Thanks! > > Acked-by: Jay Jayatheerthan Applied to dpdk-next-net-eventdev/for-main. Thanks > -Jay > > > > > -Original Message- > > From: Naga Harish K, S V > > Sent: Monday, February 14, 2022 10:40 PM > > To:

RE: [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-18 Thread Zhang, Roy Fan
> -Original Message- > From: Ji, Kai > Sent: Friday, February 18, 2022 11:51 AM > To: dev@dpdk.org > Cc: gak...@marvell.com; Zhang, Roy Fan ; Ji, Kai > > Subject: [dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto > routine > > This patch update the symmetric EVP routine in

RE: [PATCH] crypto: fix asymmetric private session variable size

2022-02-18 Thread Zhang, Roy Fan
Hi Ciara, > -Original Message- > From: Power, Ciara > Sent: Friday, February 18, 2022 12:58 PM > To: dev@dpdk.org > Cc: Zhang, Roy Fan ; gak...@marvell.com; Kusztal, > ArkadiuszX ; Power, Ciara > > Subject: [PATCH] crypto: fix asymmetric private session variable size > > When creating t

RE: [PATCH] net/ice: fix overwriting of LSE bit by DCF

2022-02-18 Thread Wang, Haiyue
> -Original Message- > From: Wilczynski, Michal > Sent: Friday, February 18, 2022 19:57 > To: dev@dpdk.org > Cc: Wang, Haiyue ; Zhang, Qi Z ; > Wilczynski, Michal > > Subject: [PATCH] net/ice: fix overwriting of LSE bit by DCF > > After enabling DCF on a VF, the ice driver stops receivi

[PATCH] crypto: fix asymmetric private session variable size

2022-02-18 Thread Ciara Power
When creating the asymmetric session mempool, the maximum private session size of all devices is used when creating the mempool object size. The return value for ``rte_cryptodev_asym_get_private_session_size`` is unsigned int, whereas the variable was uint8_t, leading to a possible overflow issue.

[PATCH 2/2] test/crypto: add L4 checksum case for transport mode

2022-02-18 Thread Volodymyr Fialko
Added test case to verify L4 checksum offload in IPsec transport mode. Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph --- app/test/test_cryptodev.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index f6c3cd2b7b

[PATCH 1/2] test/crypto: add TTL and hop limit decrement cases

2022-02-18 Thread Volodymyr Fialko
Add test cases to verify TTL and hop limit decrement with lookaside IPsec offload. Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph --- app/test/test_cryptodev.c| 29 +++ app/test/test_cryptodev_security_ipsec.c | 37 app/test/test_

[PATCH 0/2] Add new IPsec test cases

2022-02-18 Thread Volodymyr Fialko
Following test cases were added: - IPv4 TTL - IPv6 hop limit - IPv4 L4 checksum in transport mode Volodymyr Fialko (2): test/crypto: add TTL and hop limit decrement cases test/crypto: add L4 checksum case for transport mode app/test/test_cryptodev.c| 44 ++

[PATCH] crypto/cnxk: support for TTL or hop limit decrement

2022-02-18 Thread Volodymyr Fialko
Add support for TTL if IPv4 or hop limit if IPv6 decrement for cn10k. Signed-off-by: Volodymyr Fialko Acked-by: Anoob Joseph --- drivers/crypto/cnxk/cn10k_ipsec.c | 2 ++ drivers/crypto/cnxk/cnxk_cryptodev_capabilities.c | 1 + 2 files changed, 3 insertions(+) diff --git a/driv

[PATCH v6] app/eventdev: add crypto producer mode

2022-02-18 Thread Shijith Thotton
In crypto producer mode, producer core enqueues cryptodev with software generated crypto ops and worker core dequeues crypto completion events from the eventdev. Event crypto metadata used for above processing is pre-populated in each crypto session. Parameter --prod_type_cryptodev can be used to

RE: [EXT] [PATCH v5] app/eventdev: add crypto producer mode

2022-02-18 Thread Shijith Thotton
Hi Akhil, >Few comments inline. >With those fixed. >Acked-by: Akhil Goyal > Thanks. >> +static int >> +perf_event_crypto_adapter_setup(struct test_perf *t, struct prod_data *p) >> +{ >> +struct evt_options *opt = t->opt; >> +uint32_t cap; >> +int ret; >> + >> +ret = rte_event_c

[dpdk-dev v5] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-18 Thread Kai Ji
This patch update the symmetric EVP routine in crypto openssl pmd to adopt openssl 3.0 library. Signed-off-by: Kai Ji v5: - checkpatch fix v4: - code comments addressed v3: - rebase to 22.03-RC1 - enable openssl 3.0 lagacy library of DES - remove local ctx in combined op as EVP_CIPHER_CTX_copy

Re: [PATCH v2 0/4] sched: HQoS Library cleanup

2022-02-18 Thread Thomas Monjalon
18/02/2022 11:58, Dumitrescu, Cristian: > > > -Original Message- > > From: Ajmera, Megha > > Sent: Friday, February 18, 2022 9:37 AM > > To: dev@dpdk.org; Singh, Jasvinder ; > > Dumitrescu, Cristian ; > > tho...@monjalon.net; david.march...@redhat.com > > Subject: [PATCH v2 0/4] sched: HQ

Re: [PATCH v6 01/11] raw/cnxk_gpio: add GPIO driver skeleton

2022-02-18 Thread Thomas Monjalon
17/02/2022 12:09, Tomasz Duszynski: > --- a/doc/guides/rel_notes/release_22_03.rst > +++ b/doc/guides/rel_notes/release_22_03.rst > @@ -55,6 +55,7 @@ New Features > Also, make sure to start the actual text at the margin. > === > > +<

RE: [EXT] [PATCH] examples/ipsec-secgw: add check for unprotected port mask

2022-02-18 Thread Anoob Joseph
> -- > Usage of unprotected port mask without any configured SA inbound, will cause > use of uninitialized SA context, so disallow such configuration. > > Signed-off-by: Volodymyr Fialko > > --- > examples/ipsec-secgw/ipsec-sec

[PATCH 2/2] net/af_xdp: reserve fill queue before socket create

2022-02-18 Thread Ciara Loftus
Some zero copy AF_XDP drivers eg. ice require that there are addresses already in the fill queue before the socket is created. Otherwise you may see log messages such as: XSK buffer pool does not provide enough addresses to fill 2047 buffers on Rx ring 0 This commit ensures that the addresses are

[PATCH 1/2] net/af_xdp: ensure xsk is deleted on Rx queue setup error

2022-02-18 Thread Ciara Loftus
The Rx queue setup can fail for many reasons eg. failure to setup the custom program, failure to allocate or reserve fill queue buffers, failure to configure busy polling etc. When a failure like one of these occurs, if the xsk is already set up it should be deleted before returning. This commit en

RE: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Dumitrescu, Cristian
> > -/* rte_sched defines */ > > -#undef RTE_SCHED_CMAN > > So what is the purpose of the code under RTE_SCHED_CMAN #ifdef? > Is it a dead code? Should it be enabled with a hidden option? > We want to keep congestion management enabled through CFLAGS for now, as we have a bit more homework to d

RE: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Dumitrescu, Cristian
> > +/* KNI defines */ > > +#define RTE_KNI_PREEMPT_DEFAULT 1 > > The KNI addition is unrelated. > > Why these KNI lines, hopefully it is not intentional and it will get removed in the next version?

RE: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > tho...@monjalon.net; david.march...@redhat.com > Subject: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from > rte_config > > Cle

RE: [PATCH v2 4/4] sched: Removed code defined under VECTOR Defines.

2022-02-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > tho...@monjalon.net; david.march...@redhat.com > Subject: [PATCH v2 4/4] sched: Removed code defined under VECTOR > Defines. > > Remove

RE: [PATCH v2 3/4] sched: Always enable best effort TC oversubscription in HQoS library.

2022-02-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > tho...@monjalon.net; david.march...@redhat.com > Subject: [PATCH v2 3/4] sched: Always enable best effort TC oversubscription > in HQoS

RE: [PATCH v2 2/4] sched: Always enable stats in HQoS library.

2022-02-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > tho...@monjalon.net; david.march...@redhat.com > Subject: [PATCH v2 2/4] sched: Always enable stats in HQoS library. > > Removed "RTE_S

RE: [PATCH v2 0/4] sched: HQoS Library cleanup

2022-02-18 Thread Dumitrescu, Cristian
> -Original Message- > From: Ajmera, Megha > Sent: Friday, February 18, 2022 9:37 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian ; > tho...@monjalon.net; david.march...@redhat.com > Subject: [PATCH v2 0/4] sched: HQoS Library cleanup > > v2: > * Rebased with latest ma

Re: [PATCH v2] net/af_xdp: make the PMD compatible with libbpf >= v0.7.0

2022-02-18 Thread Ferruh Yigit
On 2/17/2022 2:45 PM, Ciara Loftus wrote: libbpf v0.7.0 deprecates the bpf_prog_load function. Use meson to detect if libbpf >= v0.7.0 is linked and if so, use the recommended replacement functions bpf_object__open_file and bpf_object__load. Signed-off-by: Ciara Loftus Applied to dpdk-next-ne

Re: [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Thomas Monjalon
18/02/2022 10:36, Megha Ajmera: > Cleanup of sched config options those are by-default not defined. > > Signed-off-by: Megha Ajmera > Acked-by: Cristian Dumitrescu > --- > config/rte_config.h| 8 ++-- > doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- > lib/sched/

Re: [PATCH] examples/multi_process: add options to control port configuration

2022-02-18 Thread Bruce Richardson
On Fri, Feb 18, 2022 at 10:10:58AM +, Ma, WenwuX wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: 2022年2月18日 17:42 > > To: Ma, WenwuX > > Cc: Burakov, Anatoly ; dev@dpdk.org; Hu, > > Jiayu ; Wang, Yinan ; He, > > Xingguang > > Subject: Re: [PATCH] examples/mu

RE: [PATCH] examples/multi_process: add options to control port configuration

2022-02-18 Thread Ma, WenwuX
> -Original Message- > From: Richardson, Bruce > Sent: 2022年2月18日 17:42 > To: Ma, WenwuX > Cc: Burakov, Anatoly ; dev@dpdk.org; Hu, > Jiayu ; Wang, Yinan ; He, > Xingguang > Subject: Re: [PATCH] examples/multi_process: add options to control port > configuration > > On Fri, Feb 18, 20

RE: [Bug 937] [dpdk-22.03] unit_tests_mempool/test_mempool_perf: timeout on mempool_perf_autotest

2022-02-18 Thread Morten Brørup
> From: Jiang, YuX [mailto:yux.ji...@intel.com] > Sent: Friday, 18 February 2022 10.52 > > > From: Morten Brørup > > Sent: Friday, February 18, 2022 4:10 PM > > > > > From: Jiang, YuX [mailto:yux.ji...@intel.com] > > > Sent: Thursday, 17 February 2022 11.31 > > > > > > > From: Morten Brørup > >

RE: [Bug 937] [dpdk-22.03] unit_tests_mempool/test_mempool_perf: timeout on mempool_perf_autotest

2022-02-18 Thread Jiang, YuX
> -Original Message- > From: Morten Brørup > Sent: Friday, February 18, 2022 4:10 PM > To: Jiang, YuX ; bugzi...@dpdk.org; dev@dpdk.org > Subject: RE: [Bug 937] [dpdk-22.03] > unit_tests_mempool/test_mempool_perf: timeout on > mempool_perf_autotest > > > From: Jiang, YuX [mailto:yux.ji...

[dpdk-dev v4] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-18 Thread Kai Ji
This patch update the symmetric EVP routine in crypto openssl pmd to adopt openssl 3.0 library. Signed-off-by: Kai Ji v4: - code comments addressed v3: - rebase to 22.03-RC1 - enable openssl 3.0 lagacy library of DES - remove local ctx in combined op as EVP_CIPHER_CTX_copy refuse copy without

Re: [PATCH] examples/multi_process: add options to control port configuration

2022-02-18 Thread Bruce Richardson
On Fri, Feb 18, 2022 at 06:49:19AM +, Ma, WenwuX wrote: > > > > -Original Message- > > From: Richardson, Bruce > > Sent: 2022年2月17日 17:06 > > To: Ma, WenwuX > > Cc: Burakov, Anatoly ; dev@dpdk.org; Hu, > > Jiayu ; Wang, Yinan ; He, > > Xingguang > > Subject: Re: [PATCH] examples/mu

RE: [PATCH v1 0/4] sched: HQoS Library cleanup.

2022-02-18 Thread Ajmera, Megha
Hi David, I have rebased patch-set with latest main branch code resolving the conflicts. Also updated cover letter. Regards, Megha -Original Message- From: David Marchand Sent: Friday, February 18, 2022 1:42 PM To: Ajmera, Megha Cc: dev ; Singh, Jasvinder ; Dumitrescu, Cristian ; Th

Re: [PATCH v6] eventdev/eth_rx: fix memory leak when token parsing finished

2022-02-18 Thread Jerin Jacob
On Fri, Feb 4, 2022 at 3:17 PM Jayatheerthan, Jay wrote: > > Looks good. Thanks Weiguo for posting this patch and addressing all the > comments! > > Acked-by: Jay Jayatheerthan < jay.jayatheert...@intel.com> Applied to dpdk-next-net-eventdev/for-main. Thanks > > -Jay > > > > > -Original Me

[PATCH v2 4/4] sched: Removed code defined under VECTOR Defines.

2022-02-18 Thread Megha Ajmera
Removed "RTE_SCHED_VECTOR" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 53 --- 1 file changed, 53 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 807134b48d..8ad5ca7e05 100644 --- a/lib/sched/rte_s

[PATCH v2 3/4] sched: Always enable best effort TC oversubscription in HQoS library.

2022-02-18 Thread Megha Ajmera
Removed "RTE_SCHED_SUBPORT_TC_OV" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 91 --- 1 file changed, 91 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 6f2d85edc0..807134b48d 100644 --- a/lib/sche

[PATCH v2 2/4] sched: Always enable stats in HQoS library.

2022-02-18 Thread Megha Ajmera
Removed "RTE_SCHED_COLLECT_STATS" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 12 1 file changed, 12 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 6c3e3bb0bf..6f2d85edc0 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/r

[PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-18 Thread Megha Ajmera
Cleanup of sched config options those are by-default not defined. Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- config/rte_config.h| 8 ++-- doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- lib/sched/rte_sched.c | 4 3 fil

[PATCH v2 0/4] sched: HQoS Library cleanup

2022-02-18 Thread Megha Ajmera
v2: * Rebased with latest main branch code resolved conflicts. v1: This patchset involves the cleanup of HQoS Library: * Removed unused HQoS #defines from rte_config. RTE_SCHED_CMAN, RTE_SCHED_COLLECT_STATS, RTE_SCHED_SUBPORT_TC_OV, RTE_SCHED_VECTOR * RTE_SCHED_COLLECT_STATS flag is removed f

Re: [PATCH v6 00/26] Net/SPNIC: support SPNIC into DPDK 22.03

2022-02-18 Thread Yanling Song
On Sun, 13 Feb 2022 19:07:09 +0100 Thomas Monjalon wrote: > 12/02/2022 15:01, Yanling Song: > > On Fri, 21 Jan 2022 10:22:10 + > > Ferruh Yigit wrote: > > > > > On 1/21/2022 9:27 AM, Yanling Song wrote: > > > > On Wed, 19 Jan 2022 16:56:52 + > > > > Ferruh Yigit wrote: > > > >

Re: [PATCH V2] app/testpmd: fix GENEVE parsing in csum forward mode

2022-02-18 Thread Singh, Aman Deep
On 2/16/2022 6:07 PM, Raja Zidane wrote: The csum FWD mode parses any received packet to set mbuf offloads for the transmitting burst, mainly in the checksum/TSO areas. In the case of a tunnel header, the csum FWD tries to detect known tunnels by the standard definition using the header'sdata an

RE: [PATCH 1/2] app/testpmd: fix quit testpmd with vfs and pf

2022-02-18 Thread Zhang, Yuying
Hi Wenxuan, > -Original Message- > From: Wu, WenxuanX > Sent: Thursday, February 17, 2022 6:14 PM > To: Yang, Qiming ; Zhang, Qi Z > ; Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying > Cc: dev@dpdk.org > Subject: [PATCH 1/2] app/testpmd: fix quit testpmd with vfs and pf > > From: wenxu

RE: [PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd

2022-02-18 Thread Zhang, Yuying
Hi Wenxuan, > -Original Message- > From: Wu, WenxuanX > Sent: Thursday, February 17, 2022 6:14 PM > To: Yang, Qiming ; Zhang, Qi Z > ; Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying > Cc: dev@dpdk.org > Subject: [PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd > > From: wenxu

Re: [PATCH v3] mempool/cnxk: fix bug in batch alloc issue failure path

2022-02-18 Thread Jerin Jacob
On Fri, Feb 18, 2022 at 12:54 PM Ashwin Sekhar T K wrote: > > Fix bug in batch alloc issue failure path where it was > enqueuing invalid pointers back to the pool. The code > should rightly be falling back to default dequeue path > in such cases. > > Fixes: 91531e63f4 ("mempool/cnxk: add cn10k bat

Re: [PATCH v1 0/4] sched: HQoS Library cleanup.

2022-02-18 Thread David Marchand
On Fri, Feb 18, 2022 at 8:42 AM Megha Ajmera wrote: > > v1: > * Removed unused HQoS #defines from rte_config. > * Enabled stats in HQoS by default. > * TC subscription for best effort queues is always enabled in HQoS library. > * VECTOR defines are removed from HQoS library. This series does not

RE: [Bug 937] [dpdk-22.03] unit_tests_mempool/test_mempool_perf: timeout on mempool_perf_autotest

2022-02-18 Thread Morten Brørup
> From: Jiang, YuX [mailto:yux.ji...@intel.com] > Sent: Thursday, 17 February 2022 11.31 > > > From: Morten Brørup > > Sent: Thursday, February 17, 2022 6:16 PM > > > > > From: bugzi...@dpdk.org [mailto:bugzi...@dpdk.org] > > > Sent: Thursday, 17 February 2022 10.11 > > > > > > https://bugs.dpdk.