[PATCH v2] crypto: fix misspelled key in qt format

2022-02-17 Thread Arek Kusztal
This patch fixes misspelled RTE_RSA_KEY_TYPE_QT, this will prevent checkpach from complaining wherever change to RSA is being made. Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions") Signed-off-by: Arek Kusztal --- v2: - added ignore hint to abidiff suppression file app

[PATCH v2 2/2] net/mlx5: new method to get E-Switch manager vport ID

2022-02-17 Thread Shun Hao
Currently the E-Switch manager vport ID is supposed to be default - 0 for standalone NICs, and 0xFFFE for the SmartNICs, and is deduced from the device PCI ID. This uses the new method that takes the value queried from firmware as vport ID by default. If the new method is not provided (legacy firm

[PATCH v2 1/2] common/mlx5: query E-Switch manager vport ID

2022-02-17 Thread Shun Hao
One of the E-Switch vports plays the special role - it is assigned as "E-Switch manager" and has some special exclusive rights and duties - it maintains all the representors, manages FDB domain flows, etc. By default, the E-Switch vport index was supposed to be zero on standalone NICs (regular Conn

[PATCH v2 0/2] Get E-Switch Manager vport ID

2022-02-17 Thread Shun Hao
One of the E-Switch vports plays the special role - it is assigned as "E-Switch manager" and has some special exclusive rights and duties - it maintains all the representors, manages FDB domain flows, etc. By default, the E-Switch vport index was supposed to be zero on standalone NICs (regular Conn

Re: [dpdk-dev] [PATCH] net/cnxk: unify the file name

2022-02-17 Thread Jerin Jacob
On Fri, Feb 18, 2022 at 11:48 AM Kiran Kumar Kokkilagadda wrote: > > > > > -Original Message- > > From: jer...@marvell.com > > Sent: Wednesday, February 9, 2022 10:20 PM > > To: dev@dpdk.org; Nithin Kumar Dabilpuram ; > > Kiran Kumar Kokkilagadda ; Sunil Kumar Kori > > ; Satha Koteswara R

[PATCH v1] net/mlx5: provide correct items to meter sub-policy

2022-02-17 Thread Shun Hao
If meter policy action was RSS, the correct items were not provided for sub-policy creation. This fixes the issue by providing original items in meter split, so the sub-policy creation gets the correct items. Fixes: 3c481324baf3 ("net/mlx5: fix meter flow direction check") Cc: sta...@dpdk.org Si

[PATCH v1 4/4] sched: Removed code defined under VECTOR Defines.

2022-02-17 Thread Megha Ajmera
Removed "RTE_SCHED_VECTOR" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 53 --- 1 file changed, 53 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 807134b48d..8ad5ca7e05 100644 --- a/lib/sched/rte_s

[PATCH v1 3/4] sched: Always enable best effort TC oversubscription in HQoS library.

2022-02-17 Thread Megha Ajmera
Removed "RTE_SCHED_SUBPORT_TC_OV" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 91 --- 1 file changed, 91 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 6f2d85edc0..807134b48d 100644 --- a/lib/sche

[PATCH v1 2/4] sched: Always enable stats in HQoS library.

2022-02-17 Thread Megha Ajmera
Removed "RTE_SCHED_COLLECT_STATS" flag from HQoS. Signed-off-by: Megha Ajmera --- lib/sched/rte_sched.c | 12 1 file changed, 12 deletions(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 6c3e3bb0bf..6f2d85edc0 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/r

[PATCH v1 1/4] sched: Cleanup qos scheduler defines from rte_config

2022-02-17 Thread Megha Ajmera
Cleanup of sched config options those are by-default not defined. Signed-off-by: Megha Ajmera Acked-by: Cristian Dumitrescu --- config/rte_config.h| 7 --- doc/guides/sample_app_ug/qos_scheduler.rst | 3 +-- lib/sched/rte_sched.c | 4 3 file

[PATCH v1] raw/ifpga: fix interrupt handle allocation

2022-02-17 Thread Wei Huang
Allocate FPGA interrupt handle instance for each card. Fixes: e0a1aafe2af9 ("raw/ifpga: introduce IRQ functions") Cc: sta...@dpdk.org Signed-off-by: Wei Huang --- drivers/raw/ifpga/ifpga_rawdev.c | 94 drivers/raw/ifpga/ifpga_rawdev.h | 7 ++- 2 files c

[PATCH v1 0/4] sched: HQoS Library cleanup.

2022-02-17 Thread Megha Ajmera
v1: * Removed unused HQoS #defines from rte_config. * Enabled stats in HQoS by default. * TC subscription for best effort queues is always enabled in HQoS library. * VECTOR defines are removed from HQoS library. Megha Ajmera (4): sched: Cleanup qos scheduler defines from rte_config sched: Al

[PATCH v3] mempool/cnxk: fix bug in batch alloc issue failure path

2022-02-17 Thread Ashwin Sekhar T K
Fix bug in batch alloc issue failure path where it was enqueuing invalid pointers back to the pool. The code should rightly be falling back to default dequeue path in such cases. Fixes: 91531e63f4 ("mempool/cnxk: add cn10k batch dequeue") Signed-off-by: Ashwin Sekhar T K --- drivers/mempool/cnx

[PATCH v1 2/2] net/mlx5: new method to get E-Switch manager vport ID

2022-02-17 Thread Shun Hao
Currently the E-Switch manager vport ID is supposed to be default - 0 for standalone NICs, and 0xFFFE for the SmartNICs, and is deduced from the device PCI ID. This uses the new method that takes the value queried from firmware as vport ID by default. If the new method is not provided (legacy firm

[PATCH v1 1/2] common/mlx5: query E-Switch manager vport ID

2022-02-17 Thread Shun Hao
One of the E-Switch vports plays the special role - it is assigned as "E-Switch manager" and has some special exclusive rights and duties - it maintains all the representors, manages FDB domain flows, etc. By default, the E-Switch vport index was supposed to be zero on standalone NICs (regular Conn

[PATCH v1 0/2] Get E-Switch Manager vport ID

2022-02-17 Thread Shun Hao
One of the E-Switch vports plays the special role - it is assigned as "E-Switch manager" and has some special exclusive rights and duties - it maintains all the representors, manages FDB domain flows, etc. By default, the E-Switch vport index was supposed to be zero on standalone NICs (regular Conn

RE: [PATCH] examples/multi_process: add options to control port configuration

2022-02-17 Thread Ma, WenwuX
> -Original Message- > From: Richardson, Bruce > Sent: 2022年2月17日 17:06 > To: Ma, WenwuX > Cc: Burakov, Anatoly ; dev@dpdk.org; Hu, > Jiayu ; Wang, Yinan ; He, > Xingguang > Subject: Re: [PATCH] examples/multi_process: add options to control port > configuration > > On Thu, Feb 17, 2

[PATCH v2] mempool/cnxk: fix bug in batch alloc issue failure path

2022-02-17 Thread Ashwin Sekhar T K
Fix bug in batch alloc issue failure path where it was enqueing invalid pointers back to the pool. The code should rightly be falling back to default dequeue path in such cases. Fixes: 91531e63f4 ("mempool/cnxk: add cn10k batch dequeue") Signed-off-by: Ashwin Sekhar T K --- drivers/mempool/cnxk

RE: [dpdk-dev] [PATCH] net/cnxk: unify the file name

2022-02-17 Thread Kiran Kumar Kokkilagadda
> -Original Message- > From: jer...@marvell.com > Sent: Wednesday, February 9, 2022 10:20 PM > To: dev@dpdk.org; Nithin Kumar Dabilpuram ; > Kiran Kumar Kokkilagadda ; Sunil Kumar Kori > ; Satha Koteswara Rao Kottidi > > Cc: ferruh.yi...@intel.com; Satheesh Paul ; Jerin > Jacob Kollanu

Re: [PATCH v9 2/2] net/cnxk: support priority flow control

2022-02-17 Thread Jerin Jacob
On Mon, Feb 14, 2022 at 3:40 PM wrote: > > From: Sunil Kumar Kori > > Patch implements priority flow control support for CNXK platforms. Add support for priority flow control support for CNXK platforms. > > Signed-off-by: Sunil Kumar Kori > --- > v1..v2: > - fix application restart issue. > >

RE: [EXT] [PATCH] crypto: fix misspelled key in qt format

2022-02-17 Thread Kusztal, ArkadiuszX
> -Original Message- > From: Akhil Goyal > Sent: Saturday, February 12, 2022 12:34 PM > To: Kusztal, ArkadiuszX ; dev@dpdk.org > Cc: Zhang, Roy Fan > Subject: RE: [EXT] [PATCH] crypto: fix misspelled key in qt format > > > This patch fixes misspelled RTE_RSA_KEY_TYPE_QT, this will pre

Re: [dpdk-dev] [PATCH v2] drivers: enable keep flow rule device capability for cnxk

2022-02-17 Thread Jerin Jacob
On Mon, Feb 14, 2022 at 3:39 PM Ray Kinsella wrote: > > > psathe...@marvell.com writes: > > > From: Kiran Kumar K > > > > Adding changes to enable keep flow rule device capability. > > With this change, flow rules will be kept across device restart. > > > > Signed-off-by: Kiran Kumar K > > Revie

Re: [PATCH] net/cnxk: fix uninitialized local variable

2022-02-17 Thread Jerin Jacob
On Sat, Feb 12, 2022 at 6:11 PM Gowrishankar Muthukrishnan wrote: > > Fix uninitialized local variable as reported by coverity scan. > > Fixes: 6af19a9d89b ("net/cnxk: support meter action to flow destroy") > Coverity issue: 373630 > > Signed-off-by: Gowrishankar Muthukrishnan Acked-by: Jerin

Re: [PATCH] common/cnxk: add CNF950_A0 support

2022-02-17 Thread Jerin Jacob
On Mon, Feb 14, 2022 at 3:30 AM Thomas Monjalon wrote: > > 11/02/2022 09:27, Tomasz Duszynski: > > Add PCI IDs which match CNF95O_A0 SoC. > > > > Signed-off-by: Tomasz Duszynski > > Reviewed-by: Jerin Jacob Kollanukkaran > > --- > > drivers/common/cnxk/roc_constants.h | 1 + > > drivers/event/c

Re: [PATCH 1/3] common/cnxk: check return value for error

2022-02-17 Thread Jerin Jacob
On Sat, Feb 12, 2022 at 6:08 PM Gowrishankar Muthukrishnan wrote: > > This patch fixes coverity issue by adding checks on return values. > > Coverity issue: 373628, 374858, 370213, 370215 > Fixes: af75aac78978 ("common/cnxk: support telemetry for NIX") > Fixes: d61138d4f0e ("drivers: remove direct

[PATCH v2] raw/ifpga: initialize scalar variable before using

2022-02-17 Thread Wei Huang
Scalar variable sub_brg_bdf may be used uninitialized in function ifpga_rawdev_fill_info(), this fix initialize it. Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Wei Huang --- v2: add space after comma to meet coding style requirement --- driver

[PATCH v1] raw/ifpga: initialize scalar variable before using

2022-02-17 Thread Wei Huang
Scalar variable sub_brg_bdf may be used uninitialized in function ifpga_rawdev_fill_info(), this fix initialize it. Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Wei Huang --- drivers/raw/ifpga/ifpga_rawdev.c | 2 +- 1 file changed, 1 insertion(

[PATCH 3/3] net/sfc: fix flow tunnel support detection

2022-02-17 Thread Ivan Malov
The condition for that must use the new MAE admin status. Fixes: 2f577f0ea1a3 ("net/sfc: allow ports without MAE privilege") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/net/sfc/sfc_flow_tunnel.c | 2 +- 1 file changed, 1 in

[PATCH 2/3] common/sfc_efx/base: add missing handler for 1-byte fields

2022-02-17 Thread Ivan Malov
One may set RECIRC_ID in a MAE action rule specification. This field is not a network one, and its handling goes to the code snippet which does not recognise field sizes other than 4 bytes. Add the missing handler. Fixes: 3a73dcfdb255 ("common/sfc_efx/base: match on recirc ID in action rules") Cc:

[PATCH 1/3] common/sfc_efx/base: fix recirculation ID set in outer rules

2022-02-17 Thread Ivan Malov
Recirculation ID field of MAE outer rule insert MCDI is part of the lookup control structure and it has non-zero bit offset relative to the byte offset of the structure. Fixes: 5cf153e79c6c ("common/sfc_efx/base: support recirculation ID in outer rules") Cc: sta...@dpdk.org Signed-off-by: Ivan M

RE: [PATCH v2 2/4] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-02-17 Thread Ananyev, Konstantin
> Enable Tx IPv4 checksum offload only when Tx inline crypto is needed. > In other cases such as Tx Inline protocol offload, checksum computation > is implicitly taken care by HW. The advantage of having only necessary > offloads enabled is that Tx burst function can be as light as possible. I

RE: [PATCH 2/4] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-02-17 Thread Ananyev, Konstantin
> >> Enable Tx IPv4 checksum offload only when Tx inline crypto is needed. > >> In other cases such as Tx Inline protocol offload, checksum computation > >> is implicitly taken care by HW. > > > > Why is that? > > These is two separate HW offload and user has to enable each of them > > explicitly

RE: [EXT] [PATCH] crypto/ipsec_mb: fix qp cleanup unreachable code

2022-02-17 Thread Akhil Goyal
> The qp is never NULL when it reaches the qp_setup_cleanup error handling > code. This is due to checks earlier in the function that return an error > if qp is NULL. > > Coverity issue: 375013 > Fixes: 581c39b1cb7d ("crypto/ipsec_mb: fix queue cleanup null pointer > dereference") > Cc: sta...@dpd

RE: [PATCH v2 0/2] Adding new cases to lookaside IPsec tests

2022-02-17 Thread Akhil Goyal
> Adding new test cases to lookaside IPsec tests. > * Set and copy DSCP cases > * ESN and antireplay support > > Changes in v2: > * Fixed 32-bit build failure > Series applied to dpdk-next-crypto Thanks.

RE: [PATCH v2 4/4] examples/ipsec-secgw: add per port pool and vector pool size

2022-02-17 Thread Akhil Goyal
> Add support to enable per port packet pool and also override > vector pool size from command line args. This is useful > on some HW to tune performance based on usecase. > > Signed-off-by: Nithin Dabilpuram > --- > examples/ipsec-secgw/event_helper.c | 17 ++-- > examples/ipsec-secgw/event

RE: [PATCH v2 3/4] examples/ipsec-secgw: fix buffer free logic in vector mode

2022-02-17 Thread Akhil Goyal
> Fix packet processing to skip after mbuf is freed instead of > touching and Tx'ing it. > > Also free vector event buffer in event worker when after processing > there is no pkt to be enqueued to Tx adapter. > > Fixes: 86738ebe1e3d ("examples/ipsec-secgw: support event vector") > Cc: scha...@mar

RE: [PATCH v2 2/4] examples/ipsec-secgw: disable Tx chksum offload for inline

2022-02-17 Thread Akhil Goyal
> Enable Tx IPv4 checksum offload only when Tx inline crypto is needed. > In other cases such as Tx Inline protocol offload, checksum computation > is implicitly taken care by HW. The advantage of having only necessary > offloads enabled is that Tx burst function can be as light as possible. > > S

RE: [PATCH v2 1/4] examples/ipsec-secgw: update error prints to data path log

2022-02-17 Thread Akhil Goyal
> > Update error prints in data path to RTE_LOG_DP(). > Error prints in fast path are not good for performance > as they slow down the application when few bad packets are > received. > > Signed-off-by: Nithin Dabilpuram > --- Acked-by: Akhil Goyal

RE: [PATCH v2 2/2] test/cryptodev: add ESN and Antireplay tests

2022-02-17 Thread Akhil Goyal
> Adding test cases for IPsec ESN and Antireplay. > > Signed-off-by: Tejasree Kondoj > --- Acked-by: Akhil Goyal

RE: [PATCH v2 1/2] test/crypto: add copy and set DSCP cases

2022-02-17 Thread Akhil Goyal
> From: Anoob Joseph > > Add test cases to verify copy and set DSCP with IPv4 and IPv6 tunnels. > > Signed-off-by: Anoob Joseph Acked-by: Akhil Goyal

RE: [EXT] [dpdk-dev v3] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-17 Thread Akhil Goyal
> This patch update the symmetric EVP routine in crypto openssl pmd > to adopt openssl 3.0 library. > > Signed-off-by: Kai Ji > > v3: > - rebase to 22.03-RC1 > - enable openssl 3.0 lagacy library of DES > - remove local ctx in combined op as EVP_CIPHER_CTX_copy refuse copy > without > a valid

RE: [EXT] [dpdk-dev v8 00/10] drivers/qat: QAT symmetric crypto datapatch rework

2022-02-17 Thread Akhil Goyal
> -- > This patch reworks QAT symmetric crypto datapatch implementation where > each > generation request building separated and the crypto operation under the > raw datapath api implementation are unified. > > In addtion this pat

Re: [PATCH] net/af_xdp: add missing trailing newline in logs

2022-02-17 Thread Ferruh Yigit
On 2/17/2022 1:34 PM, Loftus, Ciara wrote: Subject: [PATCH] net/af_xdp: add missing trailing newline in logs Caught while trying --in-memory mode, some log messages in this driver are not terminated with a newline: rte_pmd_af_xdp_probe(): net_af_xdp: Failed to register multi-process IPC callback

Re: [PATCH 1/2] net/cnxk: add telemetry for inline IPsec for cn9k

2022-02-17 Thread Jerin Jacob
On Thu, Feb 10, 2022 at 12:24 PM Ankur Dwivedi wrote: > > Adds telemetry function to get information about inline > outbound and inline inbound sa's. The function takes port id > as input. Some fields in the structures roc_onf_ipsec_outb_sa > and roc_onf_ipsec_inb_sa are returned as output. Acke

Re: [PATCH 3/3] doc/dmadev/idxd: improve configuration examples

2022-02-17 Thread Kevin Laatz
On 16/02/2022 16:06, Bruce Richardson wrote: The documentation on how to configure device instances using accel-config can be improved by a number of changes: * For initial example, when only configuring one queue, omit configuration of a second engine, which is unused later. * Add the "max-b

Re: [PATCH 2/3] dma/idxd: configure max batch size to high value

2022-02-17 Thread Kevin Laatz
On 16/02/2022 16:06, Bruce Richardson wrote: When configuring an Intel DSA instance using the utility script dpdk_idxd_cfg.py, explicitly set the max supported batch size value to a high value, to ensure large bursts are supported if so desired. The default in the linux kernel is now just 32 [1],

Re: [PATCH 1/3] app/test: fix missing checks for DMA device capacity

2022-02-17 Thread Kevin Laatz
On 16/02/2022 16:06, Bruce Richardson wrote: For some DMA HW devices, e.g. those using the idxd driver, the maximum burst size is configurable, which can lead to test failures if the value is set too small. Add explicit check for this to give reasonable error messages for devices which need their

[dpdk-dev v3] crypto/openssl: openssl 3.0 support on sym crypto routine

2022-02-17 Thread Kai Ji
This patch update the symmetric EVP routine in crypto openssl pmd to adopt openssl 3.0 library. Signed-off-by: Kai Ji v3: - rebase to 22.03-RC1 - enable openssl 3.0 lagacy library of DES - remove local ctx in combined op as EVP_CIPHER_CTX_copy refuse copy without a valid dup function pointer.

Re: [PATCH v2] net/af_xdp: allow operation when multiprocess is disabled

2022-02-17 Thread Ferruh Yigit
On 2/17/2022 1:29 PM, Loftus, Ciara wrote: Subject: [PATCH v2] net/af_xdp: allow operation when multiprocess is disabled If EAL multiprocess feature has been disabled via rte_mp_disable() function, AF_XDP driver may not be able to register its IPC callback. Previously this leads to probe failure

[PATCH v3 3/4] app/test: add IP reassembly cases with multiple fragments

2022-02-17 Thread Akhil Goyal
More cases are added in test_inline_ipsec test suite to verify packets having multiple IP(v4/v6) fragments. These fragments are encrypted and then decrypted as per inline IPsec processing and then an attempt is made to reassemble the fragments. The reassembled packet content is matched with the kno

[PATCH v3 2/4] app/test: add IP reassembly case with no frags

2022-02-17 Thread Akhil Goyal
test_inline_ipsec testsuite is extended to test IP reassembly of inbound fragmented packets. The fragmented packet is sent on an interface which encrypts the packet and then it is loopbacked on the same interface which decrypts the packet and then attempts IP reassembly of the decrypted packets. In

[PATCH v3 4/4] app/test: add IP reassembly negative cases

2022-02-17 Thread Akhil Goyal
test_inline_ipsec testsuite is added with cases where the IP reassembly is incomplete and software will need to reassemble them later. The failure cases added are: - all fragments are not received. - same fragment is received more than once. - out of order fragments. Signed-off-by: Akhil Goyal --

[PATCH v3 1/4] app/test: add unit cases for inline IPsec offload

2022-02-17 Thread Akhil Goyal
A new test suite is added in test app to test inline IPsec protocol offload. In this patch, a couple of predefined plain and cipher test vectors are used to verify the IPsec functionality without the need of external traffic generators. The sent packet is loopbacked onto the same interface which is

[PATCH v3 0/4] app/test: add inline IPsec and reassembly cases

2022-02-17 Thread Akhil Goyal
IP reassembly RX offload is introduced in [1]. This patchset is added to test the IP reassembly RX offload and to test other inline IPsec test cases which need to be verified before testing IP reassembly in inline inbound cases. In this app, plain IP packets(with/without IP fragments) are sent on o

Re: [PATCH 0/2] update DPDK Linux kernel version

2022-02-17 Thread Bruce Richardson
On Thu, Feb 17, 2022 at 08:45:15AM -0800, Stephen Hemminger wrote: > The 4.4 kernel is dead. > > Stephen Hemminger (2): > doc: update required kernel version to 4.9 > known_issues: drop note about UIO with really old kernels > > doc/guides/linux_gsg/sys_reqs.rst | 5 +++-- > doc/guides/

[PATCH 2/2] known_issues: drop note about UIO with really old kernels

2022-02-17 Thread Stephen Hemminger
The DPDK has not supported 3.9 kernel for a long time so the release note about UIO kernel bug in older versions is no longer relevant. Signed-off-by: Stephen Hemminger --- doc/guides/rel_notes/known_issues.rst | 21 - 1 file changed, 21 deletions(-) diff --git a/doc/guides/

[PATCH 1/2] doc: update required kernel version to 4.9

2022-02-17 Thread Stephen Hemminger
The 4.4 kernel has passed its end of life date (after 6 years). It is no longer supported and therefore DPDK should update its minimum required kernel version. Signed-off-by: Stephen Hemminger --- doc/guides/linux_gsg/sys_reqs.rst | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH 0/2] update DPDK Linux kernel version

2022-02-17 Thread Stephen Hemminger
The 4.4 kernel is dead. Stephen Hemminger (2): doc: update required kernel version to 4.9 known_issues: drop note about UIO with really old kernels doc/guides/linux_gsg/sys_reqs.rst | 5 +++-- doc/guides/rel_notes/known_issues.rst | 21 - 2 files changed, 3 insertion

Re: [PATCH v3 01/15] bus/vmbus: scan and get the network device

2022-02-17 Thread Stephen Hemminger
On Thu, 17 Feb 2022 21:35:59 +0530 Srikanth Kaka wrote: > +/* > + * GUID associated with network devices > + * {f8615163-df3e-46c5-913f-f2d2f965ed0e} > + */ > +static const rte_uuid_t vmbus_nic_uuid = { > + 0xf8, 0x61, 0x51, 0x63, > + 0xdf, 0x3e, > + 0x46, 0xc5, > + 0x91, 0x3f, >

[dpdk-dev v8 10/10] crypto/qat: support out of place SG list

2022-02-17 Thread Kai Ji
This patch adds the SGL out of place support to QAT PMD Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 28 -- drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 14 - drivers/crypto/qat/dev/qat_sym_pmd_gen1.c| 55 +--- 3 files changed, 83 ins

[dpdk-dev v8 09/10] crypto/qat: raw dp api integration

2022-02-17 Thread Kai Ji
This patch "unifies" QAT's raw dp api implementations to share the same enqueue/dequeue methods as the crypto operation enqueue/dequeue methods. In addition, different QAT generation specific implementations are done respectively. The qat_sym_hw_dp.c is removed as no longer required. Signed-off-by

[dpdk-dev v8 08/10] crypto/qat: op burst data path rework

2022-02-17 Thread Kai Ji
This patch enable op_build_request function in qat_enqueue_op_burst, and qat_dequeue_process_response function in qat_dequeue_op_burst. The op_build_request invoked in crypto build request op is based on crypto operations setup during session init. Signed-off-by: Kai Ji --- drivers/common/qat/qa

[dpdk-dev v8 07/10] crypto/qat: unify qat asym pmd apis

2022-02-17 Thread Kai Ji
This patch removes qat_asym_pmd.c and integrates all the functions into qat_asym.c. The unified/integrated asym crypto pmd apis should make them easier to maintain. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build| 2 +- drivers/crypto/qat/qat_asym.c | 180 +

[dpdk-dev v8 06/10] crypto/qat: unify qat sym pmd apis

2022-02-17 Thread Kai Ji
This patch removes qat_sym_pmd.c and integrates all the apis into qat_sym.c. The unified/integrated qat sym crypto pmd apis should make them easier to maintain. Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 4 +- drivers/common/qat/qat_device.c | 4 +- drivers/common/

[dpdk-dev v8 05/10] crypto/qat: rework asymmetric crypto build operation

2022-02-17 Thread Kai Ji
This patch reworks the asymmetric crypto data path implementation to QAT driver. The change includes separation of different QAT generations' asymmetric crypto data path implementations and shrink the device capabilities declaration code size. Signed-off-by: Kai Ji --- drivers/common/qat/qat_qp.

[dpdk-dev v8 04/10] crypto/qat: rework session APIs

2022-02-17 Thread Kai Ji
This patch introduces the set_session methods for different generations of QAT. In addition, the patch replaces 'min_qat_dev_gen_id' with 'qat_dev_gen'. Thus, the session no longer allow to be created by one generation of QAT used by another generation. Signed-off-by: Kai Ji --- drivers/crypto/q

[dpdk-dev v8 03/10] crypto/qat: qat generation specific enqueue

2022-02-17 Thread Kai Ji
This patch add in specific aead & auth build op enqueue functions for QAT Gen3 & Gen4 Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 117 ++- drivers/crypto/qat/dev/qat_crypto_pmd_gen4.c | 34 +- 2 files changed, 149 insertions(+), 2 deletions(-) d

[dpdk-dev v8 02/10] crypto/qat: sym build op request specific implementation

2022-02-17 Thread Kai Ji
This patch adds common inline functions for QAT symmetric crypto driver to process crypto op and the build op request function pointer implementation for QAT generation 1. Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 832 ++- drivers/crypto/qat/dev/qat

[dpdk-dev v8 01/10] common/qat: define build op request and dequeue op

2022-02-17 Thread Kai Ji
This patch introduce build request op and dequeue op function pointers to qat queue pair implementation. Those two functions are used to be assigned during qat session generation based on crypto operation Signed-off-by: Kai Ji --- drivers/common/qat/qat_qp.c | 10 -- drivers/common/

[dpdk-dev v8 00/10] drivers/qat: QAT symmetric crypto datapatch rework

2022-02-17 Thread Kai Ji
This patch reworks QAT symmetric crypto datapatch implementation where each generation request building separated and the crypto operation under the raw datapath api implementation are unified. In addtion this patchset also enables QAT OOP support in raw datapath api implementation. v8: - rebase

[PATCH v3 15/15] bus/vmbus: update MAINTAINERS and docs

2022-02-17 Thread Srikanth Kaka
updated MAINTAINERS and doc files for FreeBSD support Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- MAINTAINERS| 2 ++ doc/guides/nics/netvsc.rst | 11 +++ 2 files changed, 13 insertions(+) diff --git a/MAINTAINERS b/MAINTAI

[PATCH v3 14/15] bus/vmbus: add APIs to mask/unmask IRQs

2022-02-17 Thread Srikanth Kaka
the IRQ masking/unmasking APIs use the HV_UIO driver's read and write CBs for their work. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_bus.c | 15 ++ drivers/bus/vmbus/freebsd/vmbus_uio.c | 28

[PATCH v3 13/15] net/netvsc: add meson support for FreeBSD

2022-02-17 Thread Srikanth Kaka
add meson support for FreeBSD Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/netvsc/freebsd/meson.build | 6 ++ drivers/net/netvsc/linux/meson.build | 6 ++ drivers/net/netvsc/meson.build | 3 +++ 3 files changed, 15 inse

[PATCH v3 12/15] bus/vmbus: add meson support for FreeBSD

2022-02-17 Thread Srikanth Kaka
add meson support for FreeBSD OS Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/meson.build | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/bus/vmbus/meson.build b/drivers/bus/vmbus/meson.build index

[PATCH v3 11/15] net/netvsc: moving hotplug retry to OS dir

2022-02-17 Thread Srikanth Kaka
Moved netvsc_hotplug_retry to respective OS dir as it contains OS dependent code. For Linux, it is copied as is and for FreeBSD it is not supported yet. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/netvsc/freebsd/hn_os.c | 6 ++ drivers

[PATCH v3 10/15] bus/vmbus: get subchannel info

2022-02-17 Thread Srikanth Kaka
Using sysctl, all the subchannel information is fetched Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_uio.c | 85 +++ 1 file changed, 85 insertions(+) diff --git a/drivers/bus/vmbus/freebsd/vmb

[PATCH v3 09/15] net/netvsc: make IOCTL call to open subchannels

2022-02-17 Thread Srikanth Kaka
make IOCTL call to open subchannels Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/netvsc/hn_ethdev.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 8b1e07b775.

[PATCH v3 08/15] bus/vmbus: open subchannels

2022-02-17 Thread Srikanth Kaka
In FreeBSD, unlike Linux there is no sub-channel open callback that could be called by HV_UIO driver, upon their grant by the hypervisor. Thus the PMD makes an IOCTL to the HV_UIO to open the sub-channels On Linux, the vmbus_uio_subchan_open() will always return success as the Linux HV_UIO opens t

[PATCH v3 07/15] bus/vmbus: add stub for subchannel support API

2022-02-17 Thread Srikanth Kaka
subchannels are always supported and so making vmbus_uio_subchannels_supported() always return true. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_uio.c | 8 1 file changed, 8 insertions(+) diff --git a/drive

[PATCH v3 06/15] bus/vmbus: add ring mapping APIs

2022-02-17 Thread Srikanth Kaka
Based on its channel id, mapping of primary channel or subchannel is determined. The primary channel memmory is mapped in the same way as done in Linux. For the subchannel an mmap request is directly made after determining the subchan memory offset Signed-off-by: Srikanth Kaka Signed-off-by: Vag

[PATCH v3 05/15] net/netvsc: make event monitor OS dependent

2022-02-17 Thread Srikanth Kaka
Event monitoring is not yet supported on FreeBSD, hence moving it to the OS specific files Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/net/netvsc/freebsd/hn_os.c | 16 drivers/net/netvsc/hn_ethdev.c | 7 +++ driver

[PATCH v3 04/15] bus/vmbus: add resource by index

2022-02-17 Thread Srikanth Kaka
Map the memory region created by hv_uio driver by passing their index number Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_uio.c | 70 +++ 1 file changed, 70 insertions(+) diff --git a/drivers/

[PATCH v3 03/15] bus/vmbus: get device resource values using sysctl

2022-02-17 Thread Srikanth Kaka
The UIO device's relid, monitor id, etc values are retrieved using following sysctl variables: $ sysctl dev.hv_uio.0 dev.hv_uio.0.send_buf.gpadl: 925241 dev.hv_uio.0.send_buf.size: 16777216 dev.hv_uio.0.recv_buf.gpadl: 925240 dev.hv_uio.0.recv_buf.size: 32505856 dev.hv_uio.0.monitor_page.size: 4096

[PATCH v3 02/15] bus/vmbus: handle mapping of device resources

2022-02-17 Thread Srikanth Kaka
All resource values are published by HV_UIO driver as sysctl key value pairs and they are read at a later point of the code flow Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_bus.c | 18 ++ 1 file chang

[PATCH v3 01/15] bus/vmbus: scan and get the network device

2022-02-17 Thread Srikanth Kaka
Using sysctl, all the devices on the VMBUS are identified by the PMD. On finding the Network device's device id, it is added to VMBUS dev list. Signed-off-by: Srikanth Kaka Signed-off-by: Vag Singh Signed-off-by: Anand Thulasiram --- drivers/bus/vmbus/freebsd/vmbus_bus.c | 249

[PATCH v3 00/15] add FreeBSD support to VMBUS & NetVSC PMDs

2022-02-17 Thread Srikanth Kaka
This patch series adds support to VMBUS & NetVSC PMDs run on FreeBSD Changelog: v3: - split the patches into further logical parts - updated docs v2: - replaced strncpy with memcpy - replaced malloc.h with stdlib.h - added comment in linux/vmbus_uio.c v1: Intial release Srikanth Kaka

Re: [PATCH] distributor: fix potential overflow bug

2022-02-17 Thread David Hunt
Hi Bruce, On 17/2/2022 3:02 PM, Bruce Richardson wrote: Coverity flags the fact that the tag values used in distributor are 32-bit, which means that when we use bit-manipulation to convert a tag match/no-match to a bit in an array, we need to typecast to a 64-bit type before shifting past 32 bit

[PATCH] distributor: fix potential overflow bug

2022-02-17 Thread Bruce Richardson
Coverity flags the fact that the tag values used in distributor are 32-bit, which means that when we use bit-manipulation to convert a tag match/no-match to a bit in an array, we need to typecast to a 64-bit type before shifting past 32 bits. Coverity issue: 375808 Fixes: 08ccf3faa6a9 ("distributo

[PATCH v2] net/af_xdp: make the PMD compatible with libbpf >= v0.7.0

2022-02-17 Thread Ciara Loftus
libbpf v0.7.0 deprecates the bpf_prog_load function. Use meson to detect if libbpf >= v0.7.0 is linked and if so, use the recommended replacement functions bpf_object__open_file and bpf_object__load. Signed-off-by: Ciara Loftus --- v1 -> v2: * Fix typo in commit message * Fix typo in meson.build

Re: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-17 Thread Thomas Monjalon
17/02/2022 15:16, Ori Kam: > From: Ori Kam > > From: Andrew Rybchenko > > > On 2/16/22 17:53, Ori Kam wrote: > > > > From: Andrew Rybchenko > > > >> On 2/12/22 05:19, Alexander Kozyrev wrote: > > > >>> On Fri, Feb 11, 2022 7:42 Andrew Rybchenko > > > >>> : > > > > +/** > > > > + * @warni

RE: [PATCH] net/af_xdp: make the PMD compatible with libbpf >= v0.7.0

2022-02-17 Thread Loftus, Ciara
> Subject: Re: [PATCH] net/af_xdp: make the PMD compatible with libbpf >= > v0.7.0 > > On Thu, Feb 17, 2022 at 12:14:30PM +, Ciara Loftus wrote: > > libbpf v0.7.0 deprecates the bpf_prog_load function. Use meson to detect > > if libbpf >= v0.7.0 is linked and if so, use the recommended replace

RE: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules operations

2022-02-17 Thread Ori Kam
Hi Andrew, > -Original Message- > From: Ori Kam > Sent: Thursday, February 17, 2022 1:09 PM > Subject: RE: [PATCH v5 03/10] ethdev: bring in async queue-based flow rules > operations > > Hi Andrew, > > > -Original Message- > > From: Andrew Rybchenko > > Sent: Thursday, February

Re: [PATCH 20/20] net/cnxk: add option to override outbound inline sa iv

2022-02-17 Thread Jerin Jacob
On Mon, Feb 7, 2022 at 1:02 PM Nithin Dabilpuram wrote: > > Add option to override outbound inline sa iv for debug sa -> SA IV -> IV Please check the subject too > purposes via environment variable. User can set env variable as: > export CN10K_ETH_SEC_IV_OVR="0x0, 0x0,..." Please add a table f

Re: [PATCH 15/20] net/cnxk: use raw mbuf free on inline sec err

2022-02-17 Thread Jerin Jacob
On Mon, Feb 7, 2022 at 1:01 PM Nithin Dabilpuram wrote: You could change the subject as net/cnxk: fix inline IPsec security error handling > > Use raw mbuf free on inline sec error to simulate sec- > security > HW NPA free instead of doing rte_pktmbuf_free(). This > is needed as the callback w

Re: [PATCH 11/20] common/cnxk: removed tracking of mark actions

2022-02-17 Thread Jerin Jacob
On Mon, Feb 7, 2022 at 1:01 PM Nithin Dabilpuram wrote: > > From: Satha Rao Subject change removed to remove > > Removed roc npc apis which tracks addition and deletion of NPC and APIs > mark actions. Tell why it is removed. > > Signed-off-by: Satha Rao > --- > drivers/common/cnxk/roc_np

RE: [PATCH] net/af_xdp: add missing trailing newline in logs

2022-02-17 Thread Loftus, Ciara
> Subject: [PATCH] net/af_xdp: add missing trailing newline in logs > > Caught while trying --in-memory mode, some log messages in this driver > are not terminated with a newline: > rte_pmd_af_xdp_probe(): net_af_xdp: Failed to register multi-process IPC > callback: Operation not supportedvdev_pro

Re: [PATCH 10/20] net/cnxk: added Rx metadata negotiate operation

2022-02-17 Thread Jerin Jacob
On Mon, Feb 7, 2022 at 1:01 PM Nithin Dabilpuram wrote: > > From: Satha Rao > > Added rx_metadata_negotiate api to enable mark update RX offload. > Removed software logic to enable/disable mark update inside flow > create/destroy apis. APIs > Signed-off-by: Satha Rao > --- > +static int > +cn

RE: [PATCH v2] net/af_xdp: allow operation when multiprocess is disabled

2022-02-17 Thread Loftus, Ciara
> Subject: [PATCH v2] net/af_xdp: allow operation when multiprocess is > disabled > > If EAL multiprocess feature has been disabled via rte_mp_disable() > function, AF_XDP driver may not be able to register its IPC callback. > Previously this leads to probe failure. > This commit adds a check for

Re: [PATCH 08/20] common/cnxk: use SSO time counter threshold for IRQ

2022-02-17 Thread Jerin Jacob
On Mon, Feb 7, 2022 at 1:00 PM Nithin Dabilpuram wrote: > > Enable time counter based threshold for raising SSO > EXE_INT instead of IAQ threshold. Please update the reason for doing the same. > > Signed-off-by: Nithin Dabilpuram > --- > drivers/common/cnxk/roc_nix_inl_dev_irq.c | 13 +

Re: [PATCH 07/20] common/cnxk: support to enable aura tail drop for RQ

2022-02-17 Thread Jerin Jacob
On Mon, Feb 7, 2022 at 1:01 PM Nithin Dabilpuram wrote: > > Add support to enable aura tail drop via RQ specifically aura-> AURA > for inline device RQ's pkt pool. This is better than RQ > red drop as it can be applied to all RQ's that are not red->RED > having security enabled but using same

  1   2   >