Re: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails

2022-01-31 Thread Thomas Monjalon
octeontx2 driver is removed Can we close this patch? 01/02/2022 07:30, Rakesh Kudurumalla: > ping > > > -Original Message- > > From: Rakesh Kudurumalla > > Sent: Monday, January 10, 2022 2:35 PM > > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > > > Cc: sta...@dpdk.org; dev@dpdk.or

Re: [EXT] Re: [PATCH v5 1/2] eal: add API for bus close

2022-01-31 Thread Thomas Monjalon
01/02/2022 06:40, Rohit Raj: > From: Thomas Monjalon > > 20/01/2022 15:51, Rohit Raj: > > > Hi Thomas, > > > > > > This "rte_bus_close" API is introduced to do the opposite of what > > "rte_bus_probe" does. Just like there are plug and unplug APIs for plugging > > and > > unplugging a single devi

RE: [EXT] Re: [dpdk-stable] [PATCH v2] test: avoid hang if queues are full and Tx fails

2022-01-31 Thread Rakesh Kudurumalla
ping > -Original Message- > From: Rakesh Kudurumalla > Sent: Monday, January 10, 2022 2:35 PM > To: Thomas Monjalon ; Jerin Jacob Kollanukkaran > > Cc: sta...@dpdk.org; dev@dpdk.org; david.march...@redhat.com; > ferruh.yi...@intel.com; andrew.rybche...@oktetlabs.ru; > ajit.khapa...@broadc

RE: [PATCH] eal/windows: set pthread affinity

2022-01-31 Thread Tal Shnaiderman
> Subject: [PATCH] eal/windows: set pthread affinity > > External email: Use caution opening links or attachments > > > Sometimes OS tries to switch the core. So, bind the lcore thread to a fixed > core. > Implement affinity call on Windows similar to Linux. > > Signed-off-by: Qiao Liu > Signe

RE: [EXT] Re: [PATCH v5 1/2] eal: add API for bus close

2022-01-31 Thread Rohit Raj
> -Original Message- > From: Thomas Monjalon > Sent: Thursday, January 20, 2022 8:28 PM > To: Rohit Raj > Cc: Bruce Richardson ; Ray Kinsella > ; Dmitry Kozlyuk ; Narcisa Ana > Maria Vasile ; Dmitry Malloy > ; Pallavi Kadam ; > dev@dpdk.org; Nipun Gupta ; Sachin Saxena > ; Hemant Agraw

RE: [PATCH v2 03/10] ethdev: bring in async queue-based flow rules

2022-01-31 Thread Ivan Malov
Hi all, On Thu, 27 Jan 2022, Alexander Kozyrev wrote: On Wednesday, January 26, 2022 13:54 Ajit Khaparde wrote: On Tue, Jan 25, 2022 at 9:03 PM Alexander Kozyrev wrote: On Monday, January 24, 2022 19:00 Ivan Malov wrote: This series is very helpful as it draws attention to the problem

[PATCH] add missing file to meson build for installation

2022-01-31 Thread Martijn Bakker
Signed-off-by: Martijn Bakker --- lib/eal/include/meson.build | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build index 86468d1a2b..9700494816 100644 --- a/lib/eal/include/meson.build +++ b/lib/eal/include/meson.build @@ -60,6 +60,7 @@ gen

[dpdk-dev] [PATCH v3 2/2] app/testpmd: add queue based pfc CLI options

2022-01-31 Thread jerinj
From: Sunil Kumar Kori Patch adds command line options to configure queue based priority flow control. - Syntax command is given as below: set pfc_queue_ctrl rx\ tx - Example command to configure queue based priority flow control on rx and tx side for port 0, Rx queue 0, Tx

[dpdk-dev] [PATCH v3 1/2] ethdev: support queue-based priority flow control

2022-01-31 Thread jerinj
From: Jerin Jacob Based on device support and use-case need, there are two different ways to enable PFC. The first case is the port level PFC configuration, in this case, rte_eth_dev_priority_flow_ctrl_set() API shall be used to configure the PFC, and PFC frames will be generated using based on V

Re: [PATCH v3] net/af_xdp: use libxdp if available

2022-01-31 Thread Bruce Richardson
On Mon, Jan 31, 2022 at 05:59:53PM +, Ferruh Yigit wrote: > On 1/28/2022 9:50 AM, Ciara Loftus wrote: > > AF_XDP support is deprecated in libbpf since v0.7.0 [1]. The libxdp > > library now provides the functionality which once was in libbpf and > > which the AF_XDP PMD relies on. This commit u

Re: [PATCH v3] net/af_xdp: use libxdp if available

2022-01-31 Thread Ferruh Yigit
On 1/28/2022 9:50 AM, Ciara Loftus wrote: AF_XDP support is deprecated in libbpf since v0.7.0 [1]. The libxdp library now provides the functionality which once was in libbpf and which the AF_XDP PMD relies on. This commit updates the AF_XDP meson build to use the libxdp library if a version >= v1

Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

2022-01-31 Thread Singh, Aman Deep
On 1/30/2022 4:48 PM, Raja Zidane wrote: I didn't want to remove the default parsing of tunnel as VxLan because I thought it might be used, Instead I moved it to the end, which makes it detect all supported tunnel through udp_dst_port, And only if no tunnel was matched it would default to VxLa

Re: [PATCH] app/testpmd: fix bonding mode set

2022-01-31 Thread Ferruh Yigit
On 1/28/2022 2:35 AM, Min Hu (Connor) wrote: when start testpmd, and type command like this, it will lead to Segmentation fault, like: testpmd> create bonded device 4 0 testpmd> add bonding slave 0 2 testpmd> add bonding slave 1 2 testpmd> port start 2 testpmd> set bonding mode 0 2 testpmd> quit

[PATCH v2 2/2] test/cryptodev: add ESN and Antireplay tests

2022-01-31 Thread Tejasree Kondoj
Adding test cases for IPsec ESN and Antireplay. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 186 +- app/test/test_cryptodev_security_ipsec.c | 23 ++- app/test/test_cryptodev_security_ipsec.h | 6 +- ...st_cryptodev_security_ips

[PATCH v2 1/2] test/crypto: add copy and set DSCP cases

2022-01-31 Thread Tejasree Kondoj
From: Anoob Joseph Add test cases to verify copy and set DSCP with IPv4 and IPv6 tunnels. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 166 +++ app/test/test_cryptodev_security_ipsec.c | 150 app/test/test_cryptodev_securit

[PATCH v2 0/2] Adding new cases to lookaside IPsec tests

2022-01-31 Thread Tejasree Kondoj
Adding new test cases to lookaside IPsec tests. * Set and copy DSCP cases * ESN and antireplay support Changes in v2: * Fixed 32-bit build failure Anoob Joseph (1): test/crypto: add copy and set DSCP cases Tejasree Kondoj (1): test/cryptodev: add ESN and Antireplay tests app/test/test_cryp

RE: [EXT] [PATCH v2 3/4] crypto: add asym session user data API

2022-01-31 Thread Anoob Joseph
Hi Ciara, Minor nits inline. Acked-by: Anoob Joseph Thanks, Anoob > -Original Message- > From: Ciara Power > Sent: Monday, January 24, 2022 8:34 PM > To: dev@dpdk.org > Cc: roy.fan.zh...@intel.com; Akhil Goyal ; Anoob Joseph > ; m...@ashroe.eu; Ciara Power > ; Declan Doherty > Subjec

RE: [EXT] [PATCH v2 4/4] crypto: modify return value for asym session create

2022-01-31 Thread Anoob Joseph
Hi Ciara, Minor nits. Please see inline. With the fixes, Acked-by: Anoob Joseph Thanks, Anoob > -Original Message- > From: Ciara Power > Sent: Monday, January 24, 2022 8:34 PM > To: dev@dpdk.org > Cc: roy.fan.zh...@intel.com; Akhil Goyal ; Anoob Joseph > ; m...@ashroe.eu; Ciara Power

[PATCH v3 2/2] net/tap: fix to populate fds in secondary process

2022-01-31 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

[PATCH v3 1/2] ethdev: define a function to get eth dev structure

2022-01-31 Thread Kumara Parameshwaran
From: Kumara Parameshwaran The PMDs would need a function to access the rte_eth_devices global array Cc: sta...@dpdk.org Signed-off-by: Kumara Parameshwaran --- lib/ethdev/ethdev_driver.h | 18 ++ lib/ethdev/rte_ethdev.c| 11 +++ lib/ethdev/version.map | 1 +

[PATCH v3 2/2] net/tap: fix to populate fds in secondary process

2022-01-31 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

[PATCH v3 1/2] ethdev: define a function to get eth dev structure

2022-01-31 Thread Kumara Parameshwaran
From: Kumara Parameshwaran The PMDs would need a function to access the rte_eth_devices global array Cc:sta...@dpdk.org Signed-off-by: Kumara Parameshwaran --- lib/ethdev/ethdev_driver.h | 18 ++ lib/ethdev/rte_ethdev.c| 11 +++ lib/ethdev/version.map | 1 + 3

Re: [PATCH 0/2] bugfix for bonding

2022-01-31 Thread Ferruh Yigit
On 1/28/2022 2:25 AM, Min Hu (Connor) wrote: Two bugfixed for bonding. Min Hu (Connor) (2): net/bonding: fix promiscuous and allmulticast state net/bonding: fix reference count on mbufs Series applied to dpdk-next-net/main, thanks.

Re: [PATCH 1/6] net/hns3: fix fail to rollback the max packet size in PF

2022-01-31 Thread Ferruh Yigit
On 1/28/2022 2:07 AM, Min Hu (Connor) wrote: From: Huisong Li HNS3 PF driver use the hns->pf.mps to restore the MTU when a reset occurs. If user fails to configure the MTU, the MPS of PF may not be restored to the original value, Fixes: 25fb790f7868 ("net/hns3: fix HW buffer size on MTU update

RE: [EXT] Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based pfc CLI options

2022-01-31 Thread Sunil Kumar Kori
-Original Message- From: Ajit Khaparde Sent: Thursday, January 27, 2022 10:27 PM To: Ferruh Yigit Cc: Sunil Kumar Kori ; Jerin Jacob Kollanukkaran ; dev@dpdk.org; Xiaoyun Li ; Aman Singh ; Yuying Zhang ; tho...@monjalon.net; abo...@pensando.io; andrew.rybche...@oktetlabs.ru; beilei.x

Re: [PATCH v4 1/3] net/enic: add support for eCPRI matching

2022-01-31 Thread Ferruh Yigit
On 1/28/2022 5:58 PM, John Daley wrote: eCPRI message can be over Ethernet layer (.1Q supported also) or over UDP layer. Message header formats are the same in these two variants. Only up though the first packet header in the PDU can be matched. RSS on the eCPRI payload is not supported. Signed

[PATCH 2/2] test/cryptodev: add ESN and Antireplay tests

2022-01-31 Thread Tejasree Kondoj
Adding test cases for IPsec ESN and Antireplay. Signed-off-by: Tejasree Kondoj --- app/test/test_cryptodev.c | 186 +- app/test/test_cryptodev_security_ipsec.c | 23 ++- app/test/test_cryptodev_security_ipsec.h | 6 +- ...st_cryptodev_security_ips

[PATCH 1/2] test/crypto: add copy and set DSCP cases

2022-01-31 Thread Tejasree Kondoj
From: Anoob Joseph Add test cases to verify copy and set DSCP with IPv4 and IPv6 tunnels. Signed-off-by: Anoob Joseph --- app/test/test_cryptodev.c| 166 +++ app/test/test_cryptodev_security_ipsec.c | 150 app/test/test_cryptodev_securit

[PATCH 0/2] Adding new cases to lookaside IPsec tests

2022-01-31 Thread Tejasree Kondoj
Adding new test cases to lookaside IPsec tests. * Set and copy DSCP cases * ESN and antireplay support Anoob Joseph (1): test/crypto: add copy and set DSCP cases Tejasree Kondoj (1): test/cryptodev: add ESN and Antireplay tests app/test/test_cryptodev.c | 352 +++

[PATCH 5/5] crypto/cnxk: fix updation of number of descriptors

2022-01-31 Thread Tejasree Kondoj
From: Anoob Joseph Pending queue also need to be adjusted while updating the number of descriptors. Fixes: a455fd869cd7 ("common/cnxk: align CPT queue depth to power of 2") Cc: ano...@marvell.com Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_cpt.c| 3 --- drivers/crypto/

[PATCH 4/5] crypto/cnxk: use unique cache line per inst

2022-01-31 Thread Tejasree Kondoj
From: Anoob Joseph CPT inflight request is used to track a request that is enqueued to cryptodev. Having more than one inst use the same cacheline can result in serialization of CPT result memory writes causing perf degradations. Align inflight request to ROC cache line to ensure only one result

[PATCH 3/5] common/cnxk: add ROC cache line size constant

2022-01-31 Thread Tejasree Kondoj
From: Anoob Joseph Add ROC cache line size constant. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/roc_constants.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/common/cnxk/roc_constants.h b/drivers/common/cnxk/roc_constants.h index 5f78823642..38e2087

[PATCH 2/5] crypto/cnxk: add ESN and antireplay support

2022-01-31 Thread Tejasree Kondoj
Adding lookaside IPsec ESN and anti-replay support through security session update. Signed-off-by: Tejasree Kondoj --- doc/guides/cryptodevs/cnxk.rst| 2 + doc/guides/rel_notes/release_22_03.rst| 1 + drivers/common/cnxk/cnxk_security.c | 3 ++ drivers/common

[PATCH 1/5] common/cnxk: add err ctl

2022-01-31 Thread Tejasree Kondoj
From: Anoob Joseph Add err ctl field in SA context. Signed-off-by: Anoob Joseph --- drivers/common/cnxk/cnxk_security.c | 6 -- drivers/common/cnxk/roc_ie_ot.h | 17 - 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/drivers/common/cnxk/cnxk_security.c

[PATCH 0/5] Adding new features and improvements in cnxk crypto PMD

2022-01-31 Thread Tejasree Kondoj
This series adds ESN, antireplay support and improvements to cnxk crypto PMDs. Anoob Joseph (4): common/cnxk: add err ctl common/cnxk: add ROC cache line size constant crypto/cnxk: use unique cache line per inst crypto/cnxk: fix updation of number of descriptors Tejasree Kondoj (1): cry

[PATCH v2] common/cnxk: enable NIX Tx interrupts errata

2022-01-31 Thread Harman Kalra
An errata exists whereby NIX may incorrectly overwrite the value in NIX_SQ_CTX_S[SQ_INT]. This may cause set interrupts to get cleared or causing an QINT when no error is outstanding. As a workaround, software should always read all SQ debug registers and not just rely on NIX_SQINT_E bits set in NI

Re: [PATCH] net/virtio: include ipv4 cksum to support cksum offload capability

2022-01-31 Thread Maxime Coquelin
Hi Harold, On 1/7/22 12:53, Harold Huang wrote: Device cksum offload capability usually include ipv4 cksum, tcp and udp cksum offload capability. The application such as OVS usually negotiate with the drive like this to enable cksum offload. Signed-off-by: Harold Huang --- drivers/net/virtio

Re: [PATCH] doc: update recommended IOVA mode for async vhost

2022-01-31 Thread Maxime Coquelin
On 11/22/21 09:49, Xuan Ding wrote: DPDK 21.11 adds vfio support for DMA device in vhost. This patch updates recommended IOVA mode in async datapath. Signed-off-by: Xuan Ding --- doc/guides/prog_guide/vhost_lib.rst | 9 + 1 file changed, 9 insertions(+) diff --git a/doc/guides/pr

Re: [PATCH v1] net/vhost: add queue status check

2022-01-31 Thread Maxime Coquelin
On 11/19/21 07:30, Li, Miao wrote: Hi -Original Message- From: Maxime Coquelin Sent: Tuesday, November 16, 2021 5:36 PM To: Li, Miao ; dev@dpdk.org Cc: Xia, Chenbo Subject: Re: [PATCH v1] net/vhost: add queue status check On 11/16/21 10:34, Maxime Coquelin wrote: On 11/16/21