[PATCH v3 2/2] net/ice: support drop any and steer all to queue

2022-01-25 Thread Yuying Zhang
This patch supports drop any and steer all to queue in switch filter. Support new rte_flow pattern any to handle all packets. The usage is listed below. 1. drop any: flow create 0 ingress pattern any / end actions drop / end All packets received in port 0 will be dropped. 2. steer all to queue: f

[PATCH v3 1/2] net/ice/base: add profile validation on switch filter

2022-01-25 Thread Yuying Zhang
Profile type was determined without validation when getting switch field vector bitmap. It caused error when associating profile id with given recipe if no lookup elements were given. Add profile validation to check if the profile is existing before getting bitmap. Signed-off-by: Yuying Zhang ---

[PATCH] net/ice: add support for setting promisc by DCF

2022-01-25 Thread Yiding Zhou
allow to enable/disable VFs promisc mode over VF0. this feature need to update ice kernel driver (newer than v1.8.0) Signed-off-by: Yiding Zhou --- drivers/net/ice/ice_dcf_vf_representor.c | 56 +--- 1 file changed, 39 insertions(+), 17 deletions(-) diff --git a/drivers/net/

RE: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function

2022-01-25 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Wednesday, January 26, 2022 11:30 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > ; Huang, Wei > Subject: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function > > Use rte_dev_r

RE: [PATCH v2 58/83] net/mlx5: remove unnecessary NULL checks

2022-01-25 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Monday, January 24, 2022 19:47 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Matan Azrad > ; Slava Ovsiienko > Subject: [PATCH v2 58/83] net/mlx5: remove unnecessary NULL checks > > Remove redundant NULL pointer checks before free fun

RE: [PATCH v2 57/83] net/mlx4: remove unnecessary NULL checks

2022-01-25 Thread Slava Ovsiienko
> -Original Message- > From: Stephen Hemminger > Sent: Monday, January 24, 2022 19:47 > To: dev@dpdk.org > Cc: Stephen Hemminger ; Matan Azrad > ; Slava Ovsiienko > Subject: [PATCH v2 57/83] net/mlx4: remove unnecessary NULL checks > > Remove redundant NULL pointer checks before free fun

RE: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function

2022-01-25 Thread Zhang, Tianfei
> -Original Message- > From: Huang, Wei > Sent: Wednesday, January 26, 2022 11:30 AM > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > ; Huang, Wei > Subject: [PATCH v1] raw/ifpga: fix ifpga devices cleanup function > > Use rte_dev_

RE: [EXT] Re: l2/l3_len fields

2022-01-25 Thread Liron Himi
-Original Message- From: Stephen Hemminger Sent: Tuesday, 25 January 2022 23:25 To: Liron Himi Cc: dev@dpdk.org Subject: Re: [EXT] Re: l2/l3_len fields On Tue, 25 Jan 2022 17:38:42 + Liron Himi wrote: > -Original Message- > From: Stephen Hemminger > Sent: Monday, 24 Jan

Re: [PATCH] eal/windows: set pthread affinity

2022-01-25 Thread Narcisa Ana Maria Vasile
On Thu, Jan 20, 2022 at 04:17:49PM -0800, Pallavi Kadam wrote: > Sometimes OS tries to switch the core. So, bind the lcore thread > to a fixed core. > Implement affinity call on Windows similar to Linux. > > Signed-off-by: Qiao Liu > Signed-off-by: Pallavi Kadam > --- > lib/eal/windows/eal.c |

RE: [PATCH v3 1/1] dma/cnxk: fix installing internal cnxk DMA headers

2022-01-25 Thread Radha Chintakuntla
> -Original Message- > From: Srikanth Yalavarthi > Sent: Tuesday, January 25, 2022 9:50 PM > To: Radha Chintakuntla ; Veerasenareddy Burru > > Cc: dev@dpdk.org; sta...@dpdk.org; Jerin Jacob Kollanukkaran > ; Shivah Shankar Shankar Narayan Rao > ; Srikanth Yalavarthi > > Subject: [PATCH v

[PATCH v2 6/6] net/iavf: support L2TPv2 for AVF FDIR

2022-01-25 Thread Jie Wang
Add support for L2TPv2(include PPP over L2TPv2) protocols FDIR based on outer MAC src address and L2TPv2 session ID. Add support for PPPoL2TPv2oUDP protocols FDIR based on inner IP src/dst address and UDP/TCP src/dst port. Patterns are listed below: eth/ipv4(6)/udp/l2tpv2 eth/ipv4(6)/udp/l2tpv2/p

[PATCH v2 5/6] net/iavf: support L2TPv2 for AVF HASH

2022-01-25 Thread Jie Wang
Add support for PPP over L2TPv2 over UDP protocol and L2TPv2 protocol RSS hash based on outer MAC src address and L2TPv2 session ID. Patterns are listed below: eth/ipv4/udp/l2tpv2 eth/ipv4/udp/l2tpv2/ppp eth/ipv6/udp/l2tpv2 eth/ipv6/udp/l2tpv2/ppp Signed-off-by: Jie Wang --- doc/guides/rel_note

[PATCH v2 4/6] common/iavf: add session ID fields for L2TPv2

2022-01-25 Thread Jie Wang
Add virtchnl fields session ID of L2TPv2 for AVF HASH. Signed-off-by: Jie Wang --- drivers/common/iavf/virtchnl.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h index 80e754a1b2..3e44eca7d8 100644 --- a/drivers/common/iavf/

[PATCH v2 3/6] app/testpmd: add 6 types of L2TPv2 message

2022-01-25 Thread Jie Wang
This patch adds L2TPv2 control message and 5 types of data message support for testpmd. The added L2TPv2 message types are listed below: 1. L2TPv2 control 2. L2TPv2 3. L2TPv2 + length option 4. L2TPv2 + sequence option 5. L2TPv2 + offset option 6. L2TPv2 + length option + sequence option Signed-o

[PATCH v2 2/6] net: fix L2TPv2 common header

2022-01-25 Thread Jie Wang
The fields of L2TPv2 common header were reversed in big endian and little endian. This patch fixes this error to ensure L2TPv2 can be parsed correctly. Fixes: 3a929df1f286 ("ethdev: support L2TPv2 and PPP procotol") Signed-off-by: Jie Wang --- lib/net/rte_l2tpv2.h | 20 ++-- 1

[PATCH v2 1/6] ethdev: add L2TPv2 RSS offload type

2022-01-25 Thread Jie Wang
This patch defines new RSS offload type for L2TPv2, which is required when users want to distribute packets based on the L2TPv2 session ID field. Signed-off-by: Jie Wang --- app/test-pmd/cmdline.c | 10 ++ app/test-pmd/config.c | 3 ++- doc/guides/rel_no

[PATCH v2 0/6] support L2TPv2 for AVF RSS hash and FDIR

2022-01-25 Thread Jie Wang
Support IAVF L2TPv2(include PPP over L2tpv2) RSS hash and flow director. Required to distribute packets based on outer MAC src address and L2TPv2 session ID. Support IAVF PPPoL2TPv2oUDP flow director. Required to distribute packets based on inner IP src+dest address and TCP/UDP src+dest port. ---

[PATCH v3 1/1] dma/cnxk: fix installing internal cnxk DMA headers

2022-01-25 Thread Srikanth Yalavarthi
DMA module internal header files are currently being installed to the prefix directory. This patch updates DMA meson config file to exclude internal headers during install stage. Fixes: 53f6d7328b (dma/cnxk: create and initialize device on PCI probing) Cc: sta...@dpdk.org Signed-off-by: Srikanth

[PATCH v2 1/1] dma/cnxk: fix installing internal cnxk DMA headers

2022-01-25 Thread Srikanth Yalavarthi
DMA module internal header files are currently being installed to the prefix directory. This patch updates DMA meson config file to exclude internal headers during install stage. Fixes: 53f6d7328b (dma/cnxk: create and initialize device on PCI probing) Cc: sta...@dpdk.org Signed-off-by: Srikanth

[PATCH 1/1] dma/cnxk: exclude internal DMA headers in install

2022-01-25 Thread Srikanth Yalavarthi
Update meson config files to exclude internal cnxk headers form DMA module during install stage Signed-off-by: Srikanth Yalavarthi --- drivers/dma/cnxk/meson.build | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/cnxk/meson.build b/drivers/dma/cnxk/meson.build index 633e92a20d..d4b

[PATCH v15 09/11] app/test: skip tests that are not supported yet

2022-01-25 Thread Jie Zhou
Skip tests which are not yet supported for Windows: - The libraries that tests depend on are not enabled on Windows yet - The tests can compile but with issue still under investigation * test_func_reentrancy: Windows EAL has no protection against repeated calls. * test_lcores: E

[PATCH v15 11/11] app/test: enable unit test on Windows

2022-01-25 Thread Jie Zhou
Enable a subset of unit tests for Windows CI - For driver tests, driver owners should enable corresponding tests when enabling driver for Windows. For example, the cryptodev tests will be enabled by "patch-18949: app/test: enable crypto unit tests on Windows" (which depends on this patchset

[PATCH v15 08/11] app/test: resolve name collision

2022-01-25 Thread Jie Zhou
Add OP_ prefix to resolve name collision to enable hash_perf test Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk --- app/test/test_hash_perf.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c index 76cda

[PATCH v15 10/11] app/test: replace .sh script with .py script

2022-01-25 Thread Jie Zhou
- Add python script to check if system supports hugepages - Remove corresponding .sh script - Replace calling of .sh with corresponding .py in meson.build Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk --- app/test/has-hugepage.sh | 11 --- app/test/has_hugepage.py | 26 ++

[PATCH v15 07/11] app/test: remove two alarm_autotest cases

2022-01-25 Thread Jie Zhou
Remove two alarm_autotest test cases which do bogus range check on Windows. Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk --- app/test/test_alarm.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index b4034339b8..70e97a3109 100644 --- a/

[PATCH v15 06/11] app/test: differentiate a strerror on different OS

2022-01-25 Thread Jie Zhou
On Windows, strerror returns just "Unknown error" for errnum greater than MAX_ERRNO, while linux and freebsd returns "Unknown error ", which is the current expectation for errno_autotest. Differentiate the error string on Windows to remove a "duplicate error code" failure. Signed-off-by: Jie Zhou

[PATCH v15 05/11] app/test: skip two logs_autotest cases on Windows

2022-01-25 Thread Jie Zhou
DPDK logs_autotest on Windows failed at "dynamic log types" tests. The failures are on 2 test cases for rte_log_set_level_regexp API, due to regular expression is not supported on Windows in DPDK yet and regcomp/regexec are just stubs on Windows (in regex.h). In app\test\test_logs.c, ifndef these

[PATCH v15 00/11] app/test: enable subset of tests on Windows

2022-01-25 Thread Jie Zhou
The goal of this patchset is to enable unit tests in CI for Windows. It mainly contains: - Replace POSIX specific codes - Fix some lib and tests per failures investigation - Add test stubs for not yet supported ones on Windows - Replace .sh script with .py script for meson.build - Enable build and

[PATCH v15 02/11] app/test: remove POSIX-specific code

2022-01-25 Thread Jie Zhou
- Replace POSIX-specific code with DPDK equivalents or conditionally disable it on Windows - Use NUL on Windows as /dev/null for Unix - Exclude tests not supported on Windows yet * multi-process * PMD performance statistics display on signal Signed-off-by: Jie Zhou Signed-off-by: Dmitry Koz

[PATCH v15 04/11] app/test: skip interrupt tests on Windows

2022-01-25 Thread Jie Zhou
Even though test_interrupts.c can compile on Windows, skip interrupt tests for now since majority of eal_interrupt on Windows are stubs. Will remove the skip after interrupt being fully enabled on Windows. Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk --- app/test/test_interrupts.c | 3 +++

[PATCH v15 01/11] eal/windows: return ENOTSUP for not supported API

2022-01-25 Thread Jie Zhou
UT memory_autotest on Windows has 2 failed cases on eal APIs eal_memalloc_get_seg_fd and eal_memalloc_get_seg_fd_offset. These 2 APIs are not supported on Windows yet. Should return ENOTSUP such that in test_memory.c these 2 ENOTSUP cases will not be marked as failures, same as other ENOTSUP cases.

[PATCH v15 03/11] app/test: fix incorrect errno variable

2022-01-25 Thread Jie Zhou
Fix incorrect errno variable used in memory autotest. Use rte_errno instead. Fixes: 086d426406bd ("app/test: fix memory autotests on FreeBSD") Cc: bruce.richard...@intel.com Signed-off-by: Jie Zhou Acked-by: Dmitry Kozlyuk --- app/test/test_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 de

RE: [PATCH v2 03/10] ethdev: bring in async queue-based flow rules

2022-01-25 Thread Alexander Kozyrev
On Monday, January 24, 2022 19:00 Ivan Malov wrote: > This series is very helpful as it draws attention to > the problem of making flow API efficient. That said, > there is much room for improvement, especially in > what comes to keeping things clear and concise. > > In example, the following API

[PATCH v1] raw/ifpga: fix ifpga devices cleanup function

2022-01-25 Thread Wei Huang
Use rte_dev_remove() to replace rte_rawdev_pmd_release() in ifpga_rawdev_cleanup(), resources occupied by ifpga raw devices such as threads can be released correctly. Fixes: f724a802 ("raw/ifpga: add miscellaneous APIs") Signed-off-by: Wei Huang --- drivers/raw/ifpga/ifpga_rawdev.c | 4 +++- 1

RE: [PATCH v2 9/9] vhost: use proper logging type for data path

2022-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 25, 2022 7:25 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 9/9] vhost: use proper logging type for data path > > This patch changes type from config to dat

RE: [PATCH v2 8/9] vhost: differentiate IOTLB logs

2022-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 25, 2022 7:25 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 8/9] vhost: differentiate IOTLB logs > > Same logging messages were used for both IOTLB cache >

RE: [PATCH v2 7/9] vhost: remove multi-line logs

2022-01-25 Thread Xia, Chenbo
Hi Maxime, > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 25, 2022 7:25 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 7/9] vhost: remove multi-line logs > > This patch replaces multi-lines logs in multi

RE: [PATCH v2 6/9] vhost: improve Virtio-net layer logs

2022-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 25, 2022 7:25 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 6/9] vhost: improve Virtio-net layer logs > > This patch standardizes logging done in Virtio-net

RE: [PATCH v2 5/9] vhost: improve socket layer logs

2022-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 25, 2022 7:25 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 5/9] vhost: improve socket layer logs > > This patch adds the Vhost socket path whenever possibl

RE: [PATCH v2 4/9] vhost: improve Vhost-user layer logs

2022-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 25, 2022 7:25 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 4/9] vhost: improve Vhost-user layer logs > > This patch adds the Vhost-user socket path to Vhos

RE: [PATCH v2 3/9] vhost: improve Vhost layer logs

2022-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 25, 2022 7:25 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 3/9] vhost: improve Vhost layer logs > > This patch prepends Vhost logs with the Vhost-user sock

RE: [PATCH v2 2/9] vhost: improve vDPA registration failure log

2022-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 25, 2022 7:25 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 2/9] vhost: improve vDPA registration failure log > > This patchs adds name of the device failin

RE: [PATCH v2 1/9] vhost: improve IOTLB logs

2022-01-25 Thread Xia, Chenbo
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, January 25, 2022 7:25 PM > To: dev@dpdk.org; Xia, Chenbo ; > david.march...@redhat.com > Cc: Maxime Coquelin > Subject: [PATCH v2 1/9] vhost: improve IOTLB logs > > This patch adds IOTLB mempool name when logging debug > or er

RE: [PATCH v1] raw/ifpga/base: fix port feature ID

2022-01-25 Thread Xu, Rosen
Hi, > -Original Message- > From: Huang, Wei > Sent: Tuesday, January 25, 2022 10:31 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: sta...@dpdk.org; Zhang, Tianfei ; Yigit, Ferruh > ; Huang, Wei > Subject: [PATCH v1] raw/ifpga/base: fix port feature ID > > Fix ID value of port feat

RE: [PATCH 1/2] net/ice: add module EEPROM ops for ice

2022-01-25 Thread Yang, SteveX
> -Original Message- > From: Yigit, Ferruh > Sent: Tuesday, January 25, 2022 10:49 PM > To: Yang, SteveX ; dev@dpdk.org > Cc: Zhang, Yuying ; Singh, Aman Deep > ; Yang, Qiming ; > Zhang, Qi Z ; Lu, Wenzhuo > Subject: Re: [PATCH 1/2] net/ice: add module EEPROM ops for ice > > On 1/20/202

Re: [EXT] Re: l2/l3_len fields

2022-01-25 Thread Stephen Hemminger
On Tue, 25 Jan 2022 17:38:42 + Liron Himi wrote: > -Original Message- > From: Stephen Hemminger > Sent: Monday, 24 January 2022 19:21 > To: Liron Himi > Cc: dev@dpdk.org > Subject: [EXT] Re: l2/l3_len fields > > External Email > > -

Re: [PATCH v2] eal: fix unaligned loads/stores in rte_memcpy_generic

2022-01-25 Thread Luc Pelletier
Hi Georg, > perhaps it's worth mentioning that the Linux Kernel is compiled with > -fno-strict-aliasing, because it contains code which violates the C > strict aliasing rules. Such code yields undefined behavior and is thus > unsafe when compiling with optmizing compilers such as GCC and Clang, by

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: support queue-based priority flow control

2022-01-25 Thread Jerin Jacob
On Tue, Jan 25, 2022 at 11:05 PM Ferruh Yigit wrote: > > On 1/13/2022 10:27 AM, jer...@marvell.com wrote: > > From: Jerin Jacob > > > > Based on device support and use-case need, there are two different ways > > to enable PFC. The first case is the port level PFC configuration, in > > this case,

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-25 Thread Jerin Jacob
On Tue, Jan 25, 2022 at 6:58 AM Alexander Kozyrev wrote: > > On Monday, January 24, 2022 12:41 Ajit Khaparde > wrote: > > On Mon, Jan 24, 2022 at 6:37 AM Jerin Jacob > > wrote: > > > > Ok, I'll adopt this wording in the v3. > > > > > + * > > > > + * @param port_id > > > > + * Port identifier

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-25 Thread Bruce Richardson
On Tue, Jan 25, 2022 at 06:09:42PM +, Bruce Richardson wrote: > On Tue, Jan 25, 2022 at 03:58:45PM +, Ori Kam wrote: > > Hi Bruce, > > > > > -Original Message- From: Bruce Richardson > > > Sent: Monday, January 24, 2022 8:09 PM > > > Subject: Re: [PATCH v2 01/10] ethdev: introduce

Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-25 Thread Bruce Richardson
On Tue, Jan 25, 2022 at 03:58:45PM +, Ori Kam wrote: > Hi Bruce, > > > -Original Message- > > From: Bruce Richardson > > Sent: Monday, January 24, 2022 8:09 PM > > Subject: Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints > > > > On Mon, Jan 24, 2022 at 11:16:15PM

RE: [EXT] Re: l2/l3_len fields

2022-01-25 Thread Liron Himi
-Original Message- From: Stephen Hemminger Sent: Monday, 24 January 2022 19:21 To: Liron Himi Cc: dev@dpdk.org Subject: [EXT] Re: l2/l3_len fields External Email -- On Mon, 24 Jan 2022 08:39:59 + Liron Himi wrot

Re: [dpdk-dev] [PATCH v2 2/2] app/testpmd: add queue based pfc CLI options

2022-01-25 Thread Ferruh Yigit
On 1/13/2022 10:27 AM, jer...@marvell.com wrote: From: Sunil Kumar Kori Patch adds command line options to configure queue based priority flow control. - Syntax command is given as below: set pfc_queue_ctrl rx\ tx Isn't the order of the paramters odd, it is mixing Rx/Tx co

Re: [dpdk-dev] [PATCH v2 1/2] ethdev: support queue-based priority flow control

2022-01-25 Thread Ferruh Yigit
On 1/13/2022 10:27 AM, jer...@marvell.com wrote: From: Jerin Jacob Based on device support and use-case need, there are two different ways to enable PFC. The first case is the port level PFC configuration, in this case, rte_eth_dev_priority_flow_ctrl_set() API shall be used to configure the PFC

RE: [PATCH v2 6/6] net/axgbe: alter the port speed bit range

2022-01-25 Thread Namburu, Chandu-babu
[Public] For series, Acked-by: Chandubabu Namburu -Original Message- From: sseba...@amd.com Sent: Tuesday, January 25, 2022 5:48 PM To: dev@dpdk.org Subject: [PATCH v2 6/6] net/axgbe: alter the port speed bit range From: Selwin Sebastian Newer generation Hardware uses the slightly d

RE: [RFC 1/3] ethdev: support GRE optional fields

2022-01-25 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, January 25, 2022 4:29 PM > Subject: Re: [RFC 1/3] ethdev: support GRE optional fields > > On 1/25/2022 1:06 PM, Ori Kam wrote: > > Hi Ferruh, > > > >> -Original Message- > >> From: Ferruh Yigit > >> Subject: R

RE: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints

2022-01-25 Thread Ori Kam
Hi Bruce, > -Original Message- > From: Bruce Richardson > Sent: Monday, January 24, 2022 8:09 PM > Subject: Re: [PATCH v2 01/10] ethdev: introduce flow pre-configuration hints > > On Mon, Jan 24, 2022 at 11:16:15PM +0530, Jerin Jacob wrote: > > On Mon, Jan 24, 2022 at 11:05 PM Thomas Mon

Re: [PATCH] net/ice/base: support E824S and E825 devices

2022-01-25 Thread Ferruh Yigit
On 12/29/2021 9:25 AM, Robin Zhang wrote: Add support for E824S and E825 family devices. Signed-off-by: Robin Zhang What do you think documenting these new device support on release notes?

Re: [PATCH 1/2] net/ice: add module EEPROM ops for ice

2022-01-25 Thread Ferruh Yigit
On 1/20/2022 2:59 AM, Steve Yang wrote: Add new callbacks for eth_dev_ops of ice to get the information and data of plugin module EEPROM. Signed-off-by: Steve Yang --- drivers/net/ice/ice_ethdev.c | 160 +++ drivers/net/ice/ice_ethdev.h | 25 ++ 2 files c

[PATCH] compress/octeontx: fix null pointer dereference

2022-01-25 Thread Weiguo Li
Check for memory allocation failure is added to avoid null pointer dereference. Signed-off-by: Weiguo Li --- drivers/compress/octeontx/otx_zip_pmd.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/compress/octeontx/otx_zip_pmd.c b/drivers/compress/octeontx/otx_z

Re: [RFC 1/3] ethdev: support GRE optional fields

2022-01-25 Thread Ferruh Yigit
On 1/25/2022 1:06 PM, Ori Kam wrote: Hi Ferruh, -Original Message- From: Ferruh Yigit Subject: Re: [RFC 1/3] ethdev: support GRE optional fields On 1/25/2022 9:49 AM, Sean Zhang (Networking SW) wrote: Hi, -Original Message- From: Ori Kam Sent: Wednesday, January 19, 2022 6

[PATCH] net/dpaa2: fix null pointer dereference

2022-01-25 Thread Weiguo Li
Check for memory allocation failure is added to avoid null pointer dereference. Fixes: 4690a6114ff6 ("net/dpaa2: enable error queues optionally") Signed-off-by: Weiguo Li --- drivers/net/dpaa2/dpaa2_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c

[PATCH] net/iavf: fix null pointer dereference

2022-01-25 Thread Weiguo Li
Check for memory allocation failure is added to avoid null pointer dereference. Fixes: 6bc987ecb860 ("net/iavf: support IPsec inline crypto") Signed-off-by: Weiguo Li --- drivers/net/iavf/iavf_ipsec_crypto.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/iavf/iavf_ipsec_crypt

[PATCH] compress/octeontx: fix null pointer dereference

2022-01-25 Thread Weiguo Li
Check for memory allocation failure is added to avoid null pointer dereference. Signed-off-by: Weiguo Li --- drivers/compress/octeontx/otx_zip_pmd.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/compress/octeontx/otx_zip_pmd.c b/drivers/compress/octeontx/otx_

RE: [PATCH v3] app/eventdev: add crypto producer mode

2022-01-25 Thread Gujjar, Abhinandan S
> -Original Message- > From: Shijith Thotton > Sent: Monday, January 24, 2022 12:29 PM > To: Gujjar, Abhinandan S ; dev@dpdk.org; > Jerin Jacob Kollanukkaran > Cc: Anoob Joseph ; Pavan Nikhilesh Bhagavatula > ; Akhil Goyal > Subject: RE: [PATCH v3] app/eventdev: add crypto producer mo

RE: [PATCH] examples/l3fwd-acl:memset the acl matching result array

2022-01-25 Thread Ananyev, Konstantin
> If we don't memset acl result array before matching, > we can get arbitrary dirty data from memory. I don't think it is the case. acl_classify() on successful completion will always populate result array. The only exception - user provided ivalid input parameters, or acl ctx is not build, et

RE: [PATCH v3] app/eventdev: add crypto producer mode

2022-01-25 Thread Gujjar, Abhinandan S
Hi Shijith, Some more comments. > -Original Message- > From: Gujjar, Abhinandan S > Sent: Monday, January 24, 2022 12:14 AM > To: Shijith Thotton ; dev@dpdk.org; > jer...@marvell.com > Cc: ano...@marvell.com; pbhagavat...@marvell.com; gak...@marvell.com > Subject: RE: [PATCH v3] app/event

[PATCH v3 4/4] doc: add an example arm64 cross file

2022-01-25 Thread Juraj Linkeš
The docs mention modifications and additions to the cross file, but there is no demonstration of how those should look like. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 26 +++ 1 file changed, 26 insertions(+) diff --gi

[PATCH v3 3/4] doc: arm64 cross build numactl compilers

2022-01-25 Thread Juraj Linkeš
Numactl cross compilation doesn't work with clang, remove it and fix the gcc cross compiler executable name. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/

[PATCH v3 2/4] doc: arm64 cross build binary names update

2022-01-25 Thread Juraj Linkeš
The newer versions have an extra -none- in the name. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/doc/guides/linux_gsg/cross_build_dpdk_for_arm64.rst b/

[PATCH v3 1/4] doc: arm64 cross build CFLAGS/LDFLAGS alternatives

2022-01-25 Thread Juraj Linkeš
Remove CFLAGS and LDFLAGS since Meson doesn't support them well enough. Add Meson alternatives: -Dc_args and -Dc_link_args on the command line and in cross files. Signed-off-by: Juraj Linkeš Acked-by: Ruifeng Wang --- .../linux_gsg/cross_build_dpdk_for_arm64.rst | 25 --- 1 fil

[PATCH v3 0/4] arm64 cross docs improvements/fixes

2022-01-25 Thread Juraj Linkeš
The docs are a bit outdated and in need of updates. Using CFLAGS and LDFLAGS is an artefact of the old build system, Meson doesn't support those well. Numaclt can't be cross compiled with clang. The names of downloaded binaried have an extra -none- in them. And to make these changes more easily

RE: [RFC 1/3] ethdev: support GRE optional fields

2022-01-25 Thread Ori Kam
Hi Ferruh, > -Original Message- > From: Ferruh Yigit > Subject: Re: [RFC 1/3] ethdev: support GRE optional fields > > On 1/25/2022 9:49 AM, Sean Zhang (Networking SW) wrote: > > Hi, > > > >> -Original Message- > >> From: Ori Kam > >> Sent: Wednesday, January 19, 2022 6:57 PM > >

Re: [dpdklab] Re: [dpdk-ci] [RFC] Proposal for allowing rerun of tests

2022-01-25 Thread Kevin Traynor
On 21/01/2022 17:57, Lincoln Lavoie wrote: Hi Kevin, Hi Lincoln, I'll add some notes around this to the 2022 planning doc. The retests requests for the periodic tests are tricky from the discussed patchworks / mailing list approach, because there isn't an associated patch or patch ID. So,

Re: [RFC v3] ethdev: introduce ethdev dump API

2022-01-25 Thread Ferruh Yigit
On 1/25/2022 12:56 PM, Ferruh Yigit wrote: On 1/18/2022 3:34 PM, Ajit Khaparde wrote: On Wed, Jan 12, 2022 at 4:06 AM Ray Kinsella wrote: Min Hu (Connor) writes: Added the ethdev dump API which provides functions for query private info from device. There exists many private properties in

Re: [RFC v3] ethdev: introduce ethdev dump API

2022-01-25 Thread Ferruh Yigit
On 1/18/2022 3:34 PM, Ajit Khaparde wrote: On Wed, Jan 12, 2022 at 4:06 AM Ray Kinsella wrote: Min Hu (Connor) writes: Added the ethdev dump API which provides functions for query private info from device. There exists many private properties in different PMD drivers, such as adapter state

Re: [PATCH v2] mempool: test performance with constant n

2022-01-25 Thread Olivier Matz
Hi Morten, On Mon, Jan 24, 2022 at 06:20:49PM +0100, Morten Brørup wrote: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Monday, 24 January 2022 16.00 > > > > From: Morten Brørup > > > > "What gets measured gets done." > > > > This patch adds mempool performance tests where t

Re: [PATCH v2 0/6] axgbe pmd updates

2022-01-25 Thread Ferruh Yigit
On 1/25/2022 12:17 PM, sseba...@amd.com wrote: From: Selwin Sebastian some updates to axgbe pmd driver Selwin Sebastian (6): net/axgbe: always attempt link training in KR mode net/axgbe: toggle PLL settings during rate change net/axgbe: simplify mailbox interface rate change code n

Re: [PATCH v2 0/6] axgbe pmd updates

2022-01-25 Thread Ferruh Yigit
On 1/25/2022 12:17 PM, sseba...@amd.com wrote: From: Selwin Sebastian some updates to axgbe pmd driver Selwin Sebastian (6): net/axgbe: always attempt link training in KR mode net/axgbe: toggle PLL settings during rate change net/axgbe: simplify mailbox interface rate change code n

Re: [PATCH] app/testpmd: update raw flow to take hex input

2022-01-25 Thread Ferruh Yigit
On 1/11/2022 5:05 AM, nipun.gu...@nxp.com wrote: From: Nipun Gupta This patch enables method to provide key and mask for raw rules to be provided as hexadecimal values. There is new parameter pattern_mask added to support this. Signed-off-by: Nipun Gupta Looks good to me. Ori, any objectio

[PATCH v2 6/6] net/axgbe: alter the port speed bit range

2022-01-25 Thread ssebasti
From: Selwin Sebastian Newer generation Hardware uses the slightly different port speed bit widths, so alter the existing port speed bit range to extend support to the newer generation hardware while maintaining the backward compatibility with older generation hardware. The previously reserved b

[PATCH v2 5/6] net/axgbe: add support for new port mode

2022-01-25 Thread ssebasti
From: Selwin Sebastian Add support for a new port mode that is a backplane connection without support for auto negotiation. Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/net/axgbe/axgbe_phy_impl.

[PATCH v2 4/6] net/axgbe: reset PHY Rx when mailbox command timeout

2022-01-25 Thread ssebasti
From: Selwin Sebastian Sometimes mailbox commands timeout when the RX data path becomes unresponsive. This prevents the submission of new mailbox commands to DXIO. This patch identifies the timeout and resets the RX data path so that the next message can be submitted properly. Signed-off-by: Sel

[PATCH v2 2/6] net/axgbe: toggle PLL settings during rate change

2022-01-25 Thread ssebasti
From: Selwin Sebastian For each rate change command submission, the FW has to do a phy power off sequence internally. For this to happen correctly, the PLL re-initialization control setting has to be turned off before sending mailbox commands and re-enabled once the command submission is complete

[PATCH v2 3/6] net/axgbe: simplify mailbox interface rate change code

2022-01-25 Thread ssebasti
From: Selwin Sebastian Simplify and centralize the mailbox command rate change interface by having a single function perform the writes to the mailbox registers to issue the request. Signed-off-by: Selwin Sebastian --- drivers/net/axgbe/axgbe_phy_impl.c | 95 -- 1 f

[PATCH v2 1/6] net/axgbe: always attempt link training in KR mode

2022-01-25 Thread ssebasti
From: Selwin Sebastian Link training is always attempted when in KR mode, but the code is structured to check if link training has been enabled before attempting to perform it.Since that check will always be true, simplify the code to always enable and start link training during KR auto-negotiati

[PATCH v2 0/6] axgbe pmd updates

2022-01-25 Thread ssebasti
From: Selwin Sebastian some updates to axgbe pmd driver Selwin Sebastian (6): net/axgbe: always attempt link training in KR mode net/axgbe: toggle PLL settings during rate change net/axgbe: simplify mailbox interface rate change code net/axgbe: reset PHY Rx when mailbox command timeout

[PATCH] net/enic: adjust memory check and use in proper order

2022-01-25 Thread Weiguo Li
Fixes: bb66d562aefc ("net/enic: share flow actions with same signature") Signed-off-by: Weiguo Li --- drivers/net/enic/enic_fm_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c index bf04d714d0..d8718d17ef

[PATCH] regex/mlx5: fix improper memory object check

2022-01-25 Thread Weiguo Li
Fixes: e3dbbf718ebc ("regex/mlx5: support configuration") Signed-off-by: Weiguo Li --- drivers/regex/mlx5/mlx5_rxp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regex/mlx5/mlx5_rxp.c b/drivers/regex/mlx5/mlx5_rxp.c index 5ead3ca341..51b6e71376 100644 --- a/drivers

Re: [RFC 1/3] ethdev: support GRE optional fields

2022-01-25 Thread Ferruh Yigit
On 1/25/2022 9:49 AM, Sean Zhang (Networking SW) wrote: Hi, -Original Message- From: Ori Kam Sent: Wednesday, January 19, 2022 6:57 PM To: NBU-Contact-Thomas Monjalon (EXTERNAL) ; Sean Zhang (Networking SW) ; Matan Azrad ; Ferruh Yigit Cc: Andrew Rybchenko ; dev@dpdk.org Subject: RE:

Re: [PATCH] net/sfc: validate queue span when parsing flow action RSS

2022-01-25 Thread Ferruh Yigit
On 1/10/2022 9:48 PM, Ivan Malov wrote: The current code silently shrinks the value if it exceeds the supported maximum. Do not do that. Validate the value. Fixes: d77d07391d4d ("net/sfc: support flow API RSS action") Cc: sta...@dpdk.org Signed-off-by: Ivan Malov Reviewed-by: Andrew Rybchenko

[PATCH v2 9/9] vhost: use proper logging type for data path

2022-01-25 Thread Maxime Coquelin
This patch changes type from config to data for functions called in the datapath. Suggested-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vhost.c b/lib/vhost/vhost.c index cd62dc238b..f59

[PATCH v2 7/9] vhost: remove multi-line logs

2022-01-25 Thread Maxime Coquelin
This patch replaces multi-lines logs in multiple single- line logs in order to ease logs filtering based on their socket path. Signed-off-by: Maxime Coquelin --- lib/vhost/socket.c | 10 ++-- lib/vhost/vhost.c | 8 ++-- lib/vhost/vhost_user.c | 106 +++

[PATCH v2 8/9] vhost: differentiate IOTLB logs

2022-01-25 Thread Maxime Coquelin
Same logging messages were used for both IOTLB cache insertion failure and IOTLB pending insertion failure. This patch differentiate them to ease logs analysis. Suggested-by: David Marchand Signed-off-by: Maxime Coquelin --- lib/vhost/iotlb.c | 12 1 file changed, 8 insertions(+),

[PATCH v2 6/9] vhost: improve Virtio-net layer logs

2022-01-25 Thread Maxime Coquelin
This patch standardizes logging done in Virtio-net, so that the Vhost-user socket path is always prepended to the logs. It will ease log analysis when multiple Vhost-user ports are in use. Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 165 -

[PATCH v2 5/9] vhost: improve socket layer logs

2022-01-25 Thread Maxime Coquelin
This patch adds the Vhost socket path whenever possible in order to make debugging possible when multiple Vhost devices are in use. Some vhost-user layer functions are modified to pass the device path down to the socket layer. Signed-off-by: Maxime Coquelin --- lib/vhost/socket.c | 146 +

[PATCH v2 4/9] vhost: improve Vhost-user layer logs

2022-01-25 Thread Maxime Coquelin
This patch adds the Vhost-user socket path to Vhost-user layer logs in order to ease logs filtering. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost_user.c | 573 - 1 file changed, 275 insertions(+), 298 deletions(-) diff --git a/lib/vhost/vhost_user.c

[PATCH v2 2/9] vhost: improve vDPA registration failure log

2022-01-25 Thread Maxime Coquelin
This patchs adds name of the device failing vDPA registration. Signed-off-by: Maxime Coquelin --- lib/vhost/vdpa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/vhost/vdpa.c b/lib/vhost/vdpa.c index 09ad5d866e..6df2230a67 100644 --- a/lib/vhost/vdpa.c +++ b/lib/vhos

[PATCH v2 3/9] vhost: improve Vhost layer logs

2022-01-25 Thread Maxime Coquelin
This patch prepends Vhost logs with the Vhost-user socket patch when available to ease filtering logs for a given port. Signed-off-by: Maxime Coquelin --- lib/vhost/vhost.c | 104 +++--- 1 file changed, 51 insertions(+), 53 deletions(-) diff --git a/lib/v

[PATCH v2 1/9] vhost: improve IOTLB logs

2022-01-25 Thread Maxime Coquelin
This patch adds IOTLB mempool name when logging debug or error messages, and also prepends the socket path. to all the logs. Signed-off-by: Maxime Coquelin --- lib/vhost/iotlb.c | 26 +++--- lib/vhost/iotlb.h | 10 +- lib/vhost/vhost.c | 2 +- lib/vhos

  1   2   >