> -----Original Message----- > From: Yigit, Ferruh <ferruh.yi...@intel.com> > Sent: Tuesday, January 25, 2022 10:49 PM > To: Yang, SteveX <stevex.y...@intel.com>; dev@dpdk.org > Cc: Zhang, Yuying <yuying.zh...@intel.com>; Singh, Aman Deep > <aman.deep.si...@intel.com>; Yang, Qiming <qiming.y...@intel.com>; > Zhang, Qi Z <qi.z.zh...@intel.com>; Lu, Wenzhuo <wenzhuo...@intel.com> > Subject: Re: [PATCH 1/2] net/ice: add module EEPROM ops for ice > > On 1/20/2022 2:59 AM, Steve Yang wrote: > > Add new callbacks for eth_dev_ops of ice to get the information and > > data of plugin module EEPROM. > > > > Signed-off-by: Steve Yang<stevex.y...@intel.com> > > --- > > drivers/net/ice/ice_ethdev.c | 160 > +++++++++++++++++++++++++++++++++++ > > drivers/net/ice/ice_ethdev.h | 25 ++++++ > > 2 files changed, 185 insertions(+) > > In the 'doc/guides/nics/features/ice.ini' file, the "Module EEPROM dump" > feature already documented as supported, but it is this patch add that > support. > > It looks like documenting "Module EEPROM dump" was mistake [1], > intention was to document "EEPROM dump" feature. > > Steve, can you please send another patch to fix it?
Ok, I'll add "EEPROM dump" line into the ice.ini to fix it within another patch later. Thanks. > > > [1] > Fixes: d0dd1c8e1997 ("net/ice: support EEPROM information getting") > > > > Thanks, > ferruh