RE: [PATCH v2 1/1] mempool: implement index-based per core cache

2022-01-20 Thread Morten Brørup
+Ray Kinsella, ABI Policy maintainer > From: Honnappa Nagarahalli [mailto:honnappa.nagaraha...@arm.com] > Sent: Friday, 21 January 2022 07.01 > > > > > +CC Beilei as i40e maintainer > > > > > From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] > > > Sent: Thursday, 13 January 2022 06.37 > > >

[dpdk-dev v3] [PATCH 4/4] common/cnxk: support extensions attributes in IPv6 item

2022-01-20 Thread psatheesh
From: Satheesh Paul Support matching existence of specific extension headers after RTE_FLOW_ITEM_TYPE_IPV6 item. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar Kokkilagadda --- drivers/common/cnxk/hw/npc.h| 17 drivers/common/cnxk/roc_npc.h | 33 +++

[dpdk-dev v3] [PATCH 3/4] common/cnxk: support matching VLAN existence in RTE Flow

2022-01-20 Thread psatheesh
From: Satheesh Paul Support matching existence of VLAN after RTE_FLOW_ITEM_TYPE_ETH and RTE_FLOW_ITEM_TYPE_VLAN items. Signed-off-by: Satheesh Paul Reviewed-by: Kiran Kumar Kokkilagadda --- drivers/common/cnxk/roc_npc.h | 56 - drivers/common/cnxk/roc_npc_mca

[dpdk-dev v3] [PATCH 2/4] common/cnxk: support custom pre L2 header parsing as raw

2022-01-20 Thread psatheesh
From: Kiran Kumar K Add roc API for parsing custom pre L2 headers as raw data. Only relative offset is supported and search and limit is not supported with this raw item type. Signed-off-by: Kiran Kumar K Reviewed-by: Satheesh Paul --- drivers/common/cnxk/roc_npc.c | 8 +- drivers

[dpdk-dev v3] [PATCH 1/4] drivers: support for switch header type pre_L2

2022-01-20 Thread psatheesh
From: Kiran Kumar K Adding changes to configure switch header type pre_L2 for cnxk. pre_L2 headers are custom headers placed before the ethernet header. Along with switch header type, user needs to provide the offset within the custom header that holds the size of the custom header and mask for t

RE: [PATCH v2 1/1] mempool: implement index-based per core cache

2022-01-20 Thread Honnappa Nagarahalli
> > +CC Beilei as i40e maintainer > > > From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] > > Sent: Thursday, 13 January 2022 06.37 > > > > Current mempool per core cache implementation stores pointers to mbufs > > On 64b architectures, each pointer consumes 8B This patch replaces it > > w

[PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-20 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

[PATCH v5] raw/ifpga: fix pthread cannot join

2022-01-20 Thread Wei Huang
From: Tianfei Zhang When we want to close a thread, we should set a flag to notify thread handler function. Fixes: 9c006c45 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- v2: update commit log --- v3: set thread id to 0 after pthread_join --- v4:

RE: [PATCH v1 1/1] vhost: integrate dmadev in asynchronous datapath

2022-01-20 Thread Hu, Jiayu
Hi Maxime, Thanks for your comments, and please see replies inline. Thanks, Jiayu > -Original Message- > From: Maxime Coquelin > Sent: Friday, January 21, 2022 1:00 AM > To: Hu, Jiayu ; dev@dpdk.org > Cc: i.maxim...@ovn.org; Xia, Chenbo ; Richardson, > Bruce ; Van Haaren, Harry > ; Pai

[PATCH v4] raw/ifpga: fix pthread cannot join

2022-01-20 Thread Wei Huang
From: Tianfei Zhang When we want to close a thread, we should set a flag to notify thread handler function. Fixes: 9c006c45 ("raw/ifpga: scan PCIe BDF device tree") Cc: sta...@dpdk.org Signed-off-by: Tianfei Zhang --- v2: update commit log --- v3: set thread id to 0 after pthread_join --- v4:

RE: [RFC] Python Version for DTS

2022-01-20 Thread Honnappa Nagarahalli
> > On Thu, 20 Jan 2022 09:42:51 -0500 > Owen Hilyard wrote: > > > Hello Everyone, > > > > DTS has operated using the version of python available in the oldest > > supported Ubuntu LTS for a while now, but after some discussion in the > > working group, we decided that DTS should designate a P

RE: DTS WG meeting minutes - 1/12/22

2022-01-20 Thread Honnappa Nagarahalli
> > DTS. Will be discussed when Lincoln and Juraj are available 5) The DTS > > user guide and DTS test plans are being built using makefile. This > > needs to be changed to using meson build. > > > For this point #5, not knowing the details here, but at a high level, I > wonder if > that really

[PATCH] eal/windows: set pthread affinity

2022-01-20 Thread Pallavi Kadam
Sometimes OS tries to switch the core. So, bind the lcore thread to a fixed core. Implement affinity call on Windows similar to Linux. Signed-off-by: Qiao Liu Signed-off-by: Pallavi Kadam --- lib/eal/windows/eal.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/eal/windows/eal.c b/l

RE: [PATCH] build: remove custom dependency checks in drivers

2022-01-20 Thread Long Li
> Subject: Re: [PATCH] build: remove custom dependency checks in drivers > > On Thu, Jan 20, 2022 at 11:54:21AM +0100, David Marchand wrote: > > Some drivers currently have their own checks and give some non > > consistent reasons when an internal dependency is unavailable. > > > > drivers/meson.b

[PATCH v2] build: fix warnings when running external commands

2022-01-20 Thread Bruce Richardson
Meson 0.61.1 is giving warnings that the calls to run_command do not always explicitly specify if the result is to be checked or not, i.e. there is a missing "check" parameter. This is because the default behaviour without the parameter is due to change in the future. We can fix these warnings by

[PATCH] build: fix warnings when running external commands

2022-01-20 Thread Bruce Richardson
Meson 0.61.1 is giving warnings that the calls to run_command do not always explicitly specify if the result is to be checked or not, i.e. there is a missing "check" parameter. This is because the default behaviour without the parameter is due to change in the future. We can fix these warnings by

RE: [EXT] Re: [PATCH v2 1/4] ethdev: introduce IP reassembly offload

2022-01-20 Thread Akhil Goyal
> On Thu, 20 Jan 2022 21:56:24 +0530 > Akhil Goyal wrote: > > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this structure may change without prior notice. > > + * > > + * A structure used to set IP reassembly configuration. > > + * > > + * If RTE_ETH_RX_OFFLOAD_IP_REASSEMBLY flag is set in of

[PATCH] crypto/ipsec_mb: fix buffer overrun

2022-01-20 Thread Pablo de Lara
Memory for ZUC cipher/auth key in session had to be expanded to 32 bytes, instead of 16 bytes, when adding ZUC-256 support. However, impact is low as this memory is part of a union with bigger size than 32 bytes. Coverity issue: 374374 Coverity issue: 374379 Fixes: 8c835018de84 ("crypto/ipsec_mb:

Re: [PATCH v1 1/1] vhost: integrate dmadev in asynchronous datapath

2022-01-20 Thread Maxime Coquelin
Hi Jiayu, On 12/30/21 22:55, Jiayu Hu wrote: Since dmadev is introduced in 21.11, to avoid the overhead of vhost DMA abstraction layer and simplify application logics, this patch integrates dmadev in asynchronous data path. Signed-off-by: Jiayu Hu Signed-off-by: Sunil Pai G --- doc/guides/p

[PATCH v4 1/2] common/cnxk: support priority flow ctrl config API

2022-01-20 Thread skori
From: Sunil Kumar Kori CNXK platforms support priority flow control(802.1qbb) to pause respective traffic per class on that link. Patch adds RoC interface to configure priority flow control on MAC block i.e. CGX on cn9k and RPM on cn10k. Signed-off-by: Sunil Kumar Kori --- v1..v2: - fix RoC A

[PATCH v4 2/2] net/cnxk: support priority flow control

2022-01-20 Thread skori
From: Sunil Kumar Kori Patch implements priority flow control support for CNXK platforms. Signed-off-by: Sunil Kumar Kori --- v1..v2: - fix application restart issue. v2..v3: - fix pause quanta configuration for cn10k. - fix review comments. v3..v4: - fix PFC configuration with other ty

[PATCH v2 4/4] net/cnxk: add option to override outbound inline sa iv

2022-01-20 Thread Akhil Goyal
From: Nithin Dabilpuram Add option to override outbound inline sa iv for debug purposes via environment variable. User can set env variable as: export CN10K_ETH_SEC_IV_OVR="0x0, 0x0,..." Signed-off-by: Nithin Dabilpuram --- drivers/net/cnxk/cn10k_ethdev_sec.c | 62 +

[PATCH v2 3/4] net/cnxk: add dev args for min-max spi

2022-01-20 Thread Akhil Goyal
From: Nithin Dabilpuram Add support for inline inbound SPI range via devargs instead of just max SPI value and range being 0..max. Signed-off-by: Nithin Dabilpuram --- doc/guides/nics/cnxk.rst | 28 ++- drivers/common/cnxk/roc_nix.h | 5 +- drivers/common/cnxk/r

[PATCH v2 1/4] common/cnxk: configure reassembly specific params

2022-01-20 Thread Akhil Goyal
From: Vidya Sagar Velumuri When reassembly is enabled by application, set corresponding flags in SA during creation. Provide roc API to configure reassembly unit with active and zombie limits and step size Signed-off-by: Vidya Sagar Velumuri --- drivers/common/cnxk/cnxk_security.c | 5 -

[PATCH v2 0/4] net/cnxk: support IP reassembly offload

2022-01-20 Thread Akhil Goyal
cn10k platform can support IP reassembly offload for upto 4 fragments in the inline IPsec path. The feature is enabled and tested as per unit test app[3]. The patchset depends on [1] and [2] patchsets. [1]: http://patches.dpdk.org/project/dpdk/list/?series=21283 [2]: http://patches.dpdk.org/proje

[PATCH v2 4/4] app/test: add IP reassembly negative cases

2022-01-20 Thread Akhil Goyal
test_inline_ipsec testsuite is added with cases where the IP reassembly is incomplete and software will need to reassemble them later. The failure cases added are: - all fragments are not received. - same fragment is received more than once. - out of order fragments. Signed-off-by: Akhil Goyal --

[PATCH v2 3/4] app/test: add IP reassembly cases with multiple fragments

2022-01-20 Thread Akhil Goyal
More cases are added in test_inline_ipsec test suite to verify packets having multiple IP(v4/v6) fragments. These fragments are encrypted and then decrypted as per inline IPsec processing and then an attempt is made to reassemble the fragments. The reassembled packet content is matched with the kno

[PATCH v2 2/4] app/test: add IP reassembly case with no frags

2022-01-20 Thread Akhil Goyal
test_inline_ipsec testsuite is extended to test IP reassembly of inbound fragmented packets. The fragmented packet is sent on an interface which encrypts the packet and then it is loopbacked on the same interface which decrypts the packet and then attempts IP reassembly of the decrypted packets. In

[PATCH v2 1/4] app/test: add unit cases for inline IPsec offload

2022-01-20 Thread Akhil Goyal
A new test suite is added in test app to test inline IPsec protocol offload. In this patch, a couple of predefined plain and cipher test vectors are used to verify the IPsec functionality without the need of external traffic generators. The sent packet is loopbacked onto the same interface which is

[PATCH v2 0/4] app/test: add inline IPsec and reassembly cases

2022-01-20 Thread Akhil Goyal
IP reassembly RX offload is introduced in [1]. This patchset is added to test the IP reassembly RX offload and to test other inline IPsec test cases which need to be verified before testing IP reassembly in inline inbound cases. In this app, plain IP packets(with/without IP fragments) are sent on o

Re: [PATCH v2 1/4] ethdev: introduce IP reassembly offload

2022-01-20 Thread Stephen Hemminger
On Thu, 20 Jan 2022 21:56:24 +0530 Akhil Goyal wrote: > +/** > + * @warning > + * @b EXPERIMENTAL: this structure may change without prior notice. > + * > + * A structure used to set IP reassembly configuration. > + * > + * If RTE_ETH_RX_OFFLOAD_IP_REASSEMBLY flag is set in offloads field, > + *

[PATCH v2 3/4] ethdev: add mbuf dynfield for incomplete IP reassembly

2022-01-20 Thread Akhil Goyal
Hardware IP reassembly may be incomplete for multiple reasons like reassembly timeout reached, duplicate fragments, etc. To save application cycles to process these packets again, a new mbuf dynflag is added to show that the mbuf received is not reassembled properly. Now if this dynflag is set, ap

[PATCH v2 4/4] security: add IPsec option for IP reassembly

2022-01-20 Thread Akhil Goyal
A new option is added in IPsec to enable and attempt reassembly of inbound packets. Signed-off-by: Akhil Goyal --- devtools/libabigail.abignore | 14 ++ lib/security/rte_security.h | 12 +++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/devtools/libabigail.

[PATCH v2 2/4] ethdev: add dev op to set/get IP reassembly configuration

2022-01-20 Thread Akhil Goyal
A new ethernet device op is added to give application control over the IP reassembly configuration. This operation is an optional call from the application, default values are set by PMD and exposed via rte_eth_dev_info. Application should always first retrieve the capabilities from rte_eth_dev_inf

[PATCH v2 1/4] ethdev: introduce IP reassembly offload

2022-01-20 Thread Akhil Goyal
IP Reassembly is a costly operation if it is done in software. The operation becomes even more costlier if IP fragments are encrypted. However, if it is offloaded to HW, it can considerably save application cycles. Hence, a new offload RTE_ETH_RX_OFFLOAD_IP_REASSEMBLY is introduced in ethdev for d

[PATCH v2 0/4] ethdev: introduce IP reassembly offload

2022-01-20 Thread Akhil Goyal
As discussed in the RFC[1] sent in 21.11, a new offload is introduced in ethdev for IP reassembly. This patchset add the IP reassembly RX offload. Currently, the offload is tested along with inline IPsec processing. It can also be updated as a standalone offload without IPsec, if there are some ha

Re: [RFC] Python Version for DTS

2022-01-20 Thread Stephen Hemminger
On Thu, 20 Jan 2022 09:42:51 -0500 Owen Hilyard wrote: > Hello Everyone, > > DTS has operated using the version of python available in the oldest > supported Ubuntu LTS for a while now, but after some discussion in the > working group, we decided that DTS should designate a Python version > expl

Re: [PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-20 Thread Stephen Hemminger
On Thu, 20 Jan 2022 16:42:15 +0530 Kumara Parameshwaran wrote: > +/** > +* Get rte_eth_dev from device name. The device name should be specified > +* as below: > +* - PCIe address (Domain:Bus:Device.Function), for example- :2:00.0 > +* - SoC device name, for example- fsl-gmac0 > +* - vdev dpd

Re: [PATCH v3] raw/ifpga: fix pthread cannot join

2022-01-20 Thread Stephen Hemminger
On Thu, 20 Jan 2022 00:58:14 -0500 Wei Huang wrote: > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > b/drivers/raw/ifpga/ifpga_rawdev.c > index 8d9db58..2bc569b 100644 > --- a/drivers/raw/ifpga/ifpga_rawdev.c > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > @@ -497,7 +497,7 @@ static int set_surprise

Re: [PATCH v2] net/enic: support GENEVE flow item

2022-01-20 Thread Ferruh Yigit
On 1/20/2022 2:26 PM, Hyong Youb Kim wrote: Recent VIC models can parse GENEVE, including options, and inner packet headers. Enable GENEVE header and option flow items. Currently, only the first option that follows the GENEVE header can be matched, and the GENEVE header item must specify option l

RE: [EXT] Re: [dpdk-dev] [PATCH v2] eal/arm: remove CASP constraints for GCC

2022-01-20 Thread Pavan Nikhilesh Bhagavatula
>On Mon, Nov 8, 2021 at 8:15 AM Ruifeng Wang > wrote: >> >> > -Original Message- >> > From: pbhagavat...@marvell.com >> > Sent: Friday, November 5, 2021 4:57 PM >> > To: Ruifeng Wang ; >david.march...@redhat.com; >> > jer...@marvell.com >> > Cc: dev@dpdk.org; Pavan Nikhilesh >> > Subject:

Re: [PATCH v3 00/15] features and fixes on NXP eth devices

2022-01-20 Thread Ferruh Yigit
On 1/12/2022 6:05 AM, Hemant Agrawal wrote: On 1/3/2022 3:31 PM, nipun.gu...@nxp.com wrote: From: Nipun Gupta This series adds few features and important fixes on DPAA, PFE and ENETC devices. Features added: - level 2 support for shaping on DPAA2 - loopback configuration for DPNI devices on

Re: [PATCH v4] devtools: spell check

2022-01-20 Thread Thomas Monjalon
01/12/2021 17:59, Henry Nadeau: > A spell check script to check for errors in patches. An > example of usage being cat PATCH_FILE | spell_check.sh. Does it mean all words are checked? Code and comments? I think there is no need to check the code. Note we are already using another tool, codespel

Re: [PATCH v5 01/50] devtools: script to remove unused headers includes

2022-01-20 Thread Thomas Monjalon
17/01/2022 21:18, Sean Morrissey: > This script can be used for removing headers flagged for removal by the > include-what-you-use (IWYU) tool. The script has the ability to remove > headers from specified sub-directories or dpdk as a whole and tests the > build after each removal by calling meson

Re: [EXT] Re: [PATCH v5 1/2] eal: add API for bus close

2022-01-20 Thread Thomas Monjalon
20/01/2022 15:51, Rohit Raj: > Hi Thomas, > > This "rte_bus_close" API is introduced to do the opposite of what > "rte_bus_probe" does. Just like there are plug and unplug APIs for plugging > and unplugging a single device. > > The API you mentioned, "rte_dev_remove" supports only rte_device.

[PATCH v2 8/8] net/cnxk: add CN10K template Tx functions to build

2022-01-20 Thread pbhagavatula
From: Pavan Nikhilesh Add CN10K segregated Tx and event Tx template functions to build, add macros to make future modifications simpler. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 19 +- drivers/event/cnxk/cn10k_worker.h| 36 +- drivers/even

[PATCH v2 7/8] net/cnxk: add CN10K segregated Tx functions

2022-01-20 Thread pbhagavatula
From: Pavan Nikhilesh Add CN10K segregated Rx and event Tx enqueue template functions, these help in parallelizing the build. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/tx/cn10k/tx_0_15.c | 10 ++ drivers/event/cnxk/tx/cn10k/tx_0_15_seg.c | 11 +++ dr

[PATCH v2 6/8] net/cnxk: add CN10K template Rx functions to build

2022-01-20 Thread pbhagavatula
From: Pavan Nikhilesh Add CN10K segregated Rx and event dequeue functions to build, add macros to make future modifications simpler. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn10k_eventdev.c | 114 +++-- drivers/event/cnxk/cn10k_worker.h | 71 ++- drivers/event/

[PATCH v2 5/8] net/cnxk: add CN10K segregated Rx functions

2022-01-20 Thread pbhagavatula
From: Pavan Nikhilesh Add CN10K segregated Rx and event dequeue template functions, these help in parallelizing the build. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/deq/cn10k/deq_0_15.c| 12 drivers/event/cnxk/deq/cn10k/deq_0_15_burst.c | 14 ++

[PATCH v2 4/8] net/cnxk: add CN9K template Tx functions to build

2022-01-20 Thread pbhagavatula
From: Pavan Nikhilesh Add CN9K segregated Tx and event Tx functions to build, add macros to make future modifications simpler. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn9k_eventdev.c| 29 +- drivers/event/cnxk/cn9k_worker.h | 62 ++- drivers/event/cnxk/

[PATCH v2 3/8] net/cnxk: add CN9K segregated Tx functions

2022-01-20 Thread pbhagavatula
From: Pavan Nikhilesh Add CN9K segregated Rx and event Tx enqueue template functions, these help in parallelizing the build. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/tx/cn9k/tx_0_15.c | 10 ++ drivers/event/cnxk/tx/cn9k/tx_0_15_dual.c| 11 +++ d

[PATCH v2 2/8] net/cnxk: add CN9K template Rx functions to build

2022-01-20 Thread pbhagavatula
From: Pavan Nikhilesh Add CN9K seggeregated Rx and event dequeue functions to build, add macros to make future modifications simpler. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn9k_eventdev.c| 229 + drivers/event/cnxk/cn9k_worker.h | 143 +- dr

RE: [EXT] Re: [PATCH v5 1/2] eal: add API for bus close

2022-01-20 Thread Rohit Raj
Hi Thomas, This "rte_bus_close" API is introduced to do the opposite of what "rte_bus_probe" does. Just like there are plug and unplug APIs for plugging and unplugging a single device. The API you mentioned, "rte_dev_remove" supports only rte_device. But we also need to close/remove private d

[RFC] Python Version for DTS

2022-01-20 Thread Owen Hilyard
Hello Everyone, DTS has operated using the version of python available in the oldest supported Ubuntu LTS for a while now, but after some discussion in the working group, we decided that DTS should designate a Python version explicitly for the sake of compatibility. My initial proposal is Python 3

[PATCH v2] net/enic: support GENEVE flow item

2022-01-20 Thread Hyong Youb Kim
Recent VIC models can parse GENEVE, including options, and inner packet headers. Enable GENEVE header and option flow items. Currently, only the first option that follows the GENEVE header can be matched, and the GENEVE header item must specify option length. Signed-off-by: Hyong Youb Kim Reviewe

Re: [PATCH v2] Add pragma to ignore gcc-compat warnings in clang when used with diagnose_if.

2022-01-20 Thread Thomas Monjalon
18/01/2022 00:23, Michael Barker: > When using clang with -Wall the use of diagnose_if kicks up a warning, Please could you copy the warning in the commit log? > requiring all dpdk includes to be wrapped with the pragma. This change > isolates the ignore just the appropriate location and makes i

Re: [PATCH v3] build: add missing arch define for Arm

2022-01-20 Thread Thomas Monjalon
20/01/2022 03:38, Ruifeng Wang: > As per design document, RTE_ARCH is the name of the architecture. > However, the definition was missing on Arm with meson build. > It impacts applications that refers to this string. > > Added for Arm builds. > > Fixes: b1d48c41189a ("build: support ARM with meso

[PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-20 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

Re: [PATCH] examples/performance-thread: remove

2022-01-20 Thread Thomas Monjalon
11/01/2022 17:20, Thomas Monjalon: > 17/12/2021 14:15, Ferruh Yigit: > > Remove sample application which is not clear if it is still relevant. > > > > Signed-off-by: Ferruh Yigit + remove a line in devtools/build-tags.sh > > --- > > Please comment if there is an reason to keep the sample applic

[PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-20 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

Re: [PATCH] eventdev: fix missing internal port checks

2022-01-20 Thread Jerin Jacob
On Tue, Dec 14, 2021 at 5:13 PM Jayatheerthan, Jay wrote: > > > Acked-by: Jay Jayatheerthan Updated git commit as eventdev/eth_rx: fix missing internal port checks When event delivery is through internal port, stats are mainitained by HW and we should avoid reading SW data structu

Re: [PATCH v1] gpu/cuda: add NVIDIA GPU A100 identifier for DPU

2022-01-20 Thread Thomas Monjalon
19/01/2022 22:41, eagost...@nvidia.com: > From: Elena Agostini > > Adding a new NVIDIA GPU identifier to let > driver recognize the A100 on a DPU card. > > Signed-off-by: Elena Agostini Applied, thanks

Re: [PATCH v1] gpu/cuda: fix memory list cleanup

2022-01-20 Thread Thomas Monjalon
21/12/2021 21:50, eagost...@nvidia.com: > From: Elena Agostini > > Memory list cleanup (called by cuda_mem_free) > was not properly set the new head of the list > when deleting an entry. > > Fixes: 1306a73b1958 ("gpu/cuda: introduce CUDA driver") > > Signed-off-by: Elena Agostini Applied, tha

Re: [PATCH v2 0/4] fixes for dma/idxd

2022-01-20 Thread Thomas Monjalon
11/01/2022 14:41, Bruce Richardson: > Collection of fixes for idxd driver, including one small enhancement to the > unit tests to help catch future errors too. > > V2: > * Changed from single patch for one issue (now patch 1) to multiple > patches to cover other issues discovered. > > Bruce Ric

DPDK Release Status Meeting 2022-01-20

2022-01-20 Thread Mcnamara, John
Release status meeting minutes 2022-01-20 = Agenda: * Release Dates * Subtrees * Roadmaps * LTS * Defects * Opens Participants: * ARM * Debian * Intel * Marvell * Nvidia * Red Hat Release Dates - The following are the proposed dates for 22.03

RE: mellanox connect x 5 drops when cache full

2022-01-20 Thread Matan Azrad
Hi Yaron Maybe the caching takes PCI bandwidth? Matan From: Yaron Illouz Sent: Wednesday, January 19, 2022 4:27 PM To: dev@dpdk.org Cc: Matan Azrad Subject: mellanox connect x 5 drops when cache full External email: Use caution opening links or attachments Hi I am using multiqueue with RSS

[PATCH v6] kni: allow configuring the kni thread granularity

2022-01-20 Thread Tudor Cornea
The Kni kthreads seem to be re-scheduled at a granularity of roughly 1 millisecond right now, which seems to be insufficient for performing tests involving a lot of control plane traffic. Even if KNI_KTHREAD_RESCHEDULE_INTERVAL is set to 5 microseconds, it seems that the existing code cannot resch

Re: [PATCH] net/enic: support GENEVE flow item

2022-01-20 Thread Ferruh Yigit
On 1/3/2022 2:58 AM, Hyong Youb Kim wrote: Recent VIC models can parse GENEVE, including options, and inner packet headers. Enable GENEVE header and option flow items. Currently, only the first option that follows the GENEVE header can be matched, and the GENEVE header item must specify option le

Re: [PATCH v2] doc/dlb2: update dlb2 documentation

2022-01-20 Thread Jerin Jacob
On Tue, Dec 14, 2021 at 9:41 PM McDaniel, Timothy wrote: > > > -Original Message- > > From: Shetty, Rashmi > > Sent: Tuesday, December 7, 2021 5:02 PM > > To: dev@dpdk.org > > Cc: jer...@marvell.com; Van Haaren, Harry ; > > Pathak, Pravin ; Chen, Mike Ximing > > ; McDaniel, Timothy > > ;

Re: [PATCH] build: remove custom dependency checks in drivers

2022-01-20 Thread Bruce Richardson
On Thu, Jan 20, 2022 at 11:54:21AM +0100, David Marchand wrote: > Some drivers currently have their own checks and give some non > consistent reasons when an internal dependency is unavailable. > > drivers/meson.build also checks for internal dependencies via 'deps'. > Let's rely on it for consist

Re: [PATCH] net/cxgbe: rework mailbox access to fix gcc12 -Wdangling-pointer

2022-01-20 Thread Ferruh Yigit
On 1/19/2022 9:56 PM, Rahul Lakkireddy wrote: Rework mailbox access serialization to dynamically allocate and free mbox entry. Also remove unnecessary temp memory and macros. Observed with: gcc-12.0 (GCC) 12.0.1 20220118 (experimental) In file included from ../lib/eal/linux/include/rte_os.h:14,

[PATCH] net/tap: Bug fix to populate fds in secondary process

2022-01-20 Thread Kumara Parameshwaran
From: Kumara Parameshwaran When a tap device is hotplugged to primary process which in turn adds the device to all secondary process, the secondary process does a tap_mp_attach_queues, but the fds are not populated in the primary during the probe they are populated during the queue_setup, added a

[PATCH] build: remove custom dependency checks in drivers

2022-01-20 Thread David Marchand
Some drivers currently have their own checks and give some non consistent reasons when an internal dependency is unavailable. drivers/meson.build also checks for internal dependencies via 'deps'. Let's rely on it for consistency, and smaller code. Signed-off-by: David Marchand --- drivers/net/k

Re: [PATCH v2 0/6] allow more DPDK libs to be disabled on build

2022-01-20 Thread David Marchand
On Wed, Jan 19, 2022 at 7:31 PM Bruce Richardson wrote: > > *A common request on-list has been to allow more of the DPDK build to be > disabled by those who are > doing their own builds and only use a subset of the libraries. To this end, > this patchset makes some > infrastructure changes [firs

RE: [EXT] [PATCH] crypto: use single buffer for asymmetric session

2022-01-20 Thread Power, Ciara
Hi Anoob, Thanks for the review, apologies for the delay in reply. Comments inline. Thanks, Ciara >-Original Message- >From: Anoob Joseph >Sent: Monday 13 December 2021 16:34 >To: Power, Ciara ; dev@dpdk.org >Cc: Zhang, Roy Fan ; Akhil Goyal >; Doherty, Declan ; Ankur >Dwivedi ; Tejasre

Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode

2022-01-20 Thread Singh, Aman Deep
On 1/18/2022 6:49 PM, Matan Azrad wrote: -Original Message- From: Ferruh Yigit Sent: Tuesday, January 18, 2022 3:03 PM To: Matan Azrad ; Raja Zidane ; dev@dpdk.org Cc: sta...@dpdk.org Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode External email: Use cauti

[PATCH] net/ice: fix ieee1588fwd not show PTP timestamp

2022-01-20 Thread Simei Su
For received PTP packets, the flag "RTE_MBUF_F_RX_IEEE1588_TMST" has not been set which leads to received PTP packet not timestamped by hardware shown in testpmd/ieee1588 fwd. Fixes: 646dcbe6c701 ("net/ice: support IEEE 1588 PTP") Cc: sta...@dpdk.org Signed-off-by: Simei Su --- drivers/net/ice/

RE: [PATCH 05/12] gen: add raw packet data API and tests

2022-01-20 Thread Van Haaren, Harry
> -Original Message- > From: Thomas Monjalon > Sent: Wednesday, January 19, 2022 2:56 PM > To: Randles, Ronan ; Van Haaren, Harry > > Cc: dev@dpdk.org; Jerin Jacob ; dev@dpdk.org; > Richardson, Bruce > Subject: Re: [PATCH 05/12] gen: add raw packet data API and tests > > 20/12/2021 11:2

Re: [PATCH] config/cn10k: align mempool elements to 128 bytes

2022-01-20 Thread Jerin Jacob
On Tue, Dec 14, 2021 at 2:53 PM Ruifeng Wang wrote: > > > -Original Message- > > From: pbhagavat...@marvell.com > > Sent: Monday, December 13, 2021 7:06 PM > > To: jer...@marvell.com; Jan Viktorin ; Ruifeng > > Wang ; Bruce Richardson > > > > Cc: dev@dpdk.org; Pavan Nikhilesh > > Subjec

Re: DTS WG meeting minutes - 1/12/22

2022-01-20 Thread Bruce Richardson
On Wed, Jan 19, 2022 at 09:25:50PM +, Honnappa Nagarahalli wrote: > Hello, Please find the minutes below. The history of minutes is at [1]. > > Thanks, Honnappa > > [1] > https://docs.google.com/document/d/1E2mkTHNQ5vyln1JvnJTil15cjacUTXP7LXb9K960Vxs/edit?usp=sharing > > Attendees: -

RE: [Bug 923] i40e PMD contains copy-pasted bug from mempool library

2022-01-20 Thread Morten Brørup
To: i40e, iavf, ice PMD maintainers CC: mempool library maintainers > From: bugzi...@dpdk.org [mailto:bugzi...@dpdk.org] > Sent: Thursday, 20 January 2022 09.43 > > https://bugs.dpdk.org/show_bug.cgi?id=923 > > Bug ID: 923 >Summary: i40e PMD contains copy-pasted bug from

Re: [PATCH v1 0/6] Fast restart with many hugepages

2022-01-20 Thread Bruce Richardson
On Wed, Jan 19, 2022 at 09:12:27PM +, Dmitry Kozlyuk wrote: > Hi Bruce, > > > From: Bruce Richardson > > [...] > > this seems really interesting, but in the absense of TB of memory > > being > > used, is it easily possible to see the benefits of this work? I've > > been > > playing with addin

Re: [PATCH v1 2/6] app/test: add allocator performance benchmark

2022-01-20 Thread Bruce Richardson
On Wed, Jan 19, 2022 at 09:12:35PM +, Dmitry Kozlyuk wrote: > > From: Bruce Richardson > > [...] > > > What is the expected running time of this test? When I tried it out > > on my > > > machine it appears to hang after the following output: > > > [...] > > It always runs within 50 seconds on

[Bug 924] Mellanox ConnectX6 DPDK dpdk-testpmd Receive error len error checksum UDP packet performance is very low!

2022-01-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=924 Bug ID: 924 Summary: Mellanox ConnectX6 DPDK dpdk-testpmd Receive error len error checksum UDP packet performance is very low! Product: DPDK Version: 21.11 Hardware: x86

[dpdk-dev] [PATCH 4/4] net/bnxt: fix VF resource allocation strategy

2022-01-20 Thread Kalesh A P
From: Ajit Khaparde 1. VFs need a notification queue to handle async messages. But the current logic does not reserve a notification queue leading to initialization failure in some cases. 2. With the current logic, DPDK PF driver reserves only one VNIC to the VFs leading to initialization failure

[dpdk-dev] [PATCH 3/4] net/bnxt: fix to alloc the memzone per VNIC

2022-01-20 Thread Kalesh A P
From: Kalesh AP In case of Thor RSS table size is too big. This could result in memory allocation failure when the supported vnic count is high. Instead of allocating the memzone for all VNICs in one shot, allocate for each VNIC individually. Also, fixed to free the memzone in the uninit path.

[dpdk-dev] [PATCH 2/4] net/bnxt: handle ring cleanup in case of error

2022-01-20 Thread Kalesh A P
From: Kalesh AP In bnxt_alloc_mem(), after bnxt_alloc_async_ring_struct(), any of the functions failure causes an error: bnxt_hwrm_ring_free(): hwrm_ring_free nq failed. rc:1 Fix this by initializing ring->fw_ring_id to INVALID_HW_RING_ID in bnxt_alloc_async_ring_struct(). Fixes: bd0a14c99f65

[dpdk-dev] [PATCH 1/4] net/bnxt: fix check for autoneg enablement

2022-01-20 Thread Kalesh A P
From: Kalesh AP HWRM_PORT_PHY_QCFG_OUTPUT response indicates the autoneg speed mask supported by the FW. While enabling autoneg, driver should also check the FW advertised PAM4 speeds supported in auto mode which is set in the HWRM_PORT_PHY_QCFG_OUTPUT response. Fixes: c23f9ded0391 ("net/bnxt: s

[dpdk-dev] [PATCH 0/4] bnxt fixes

2022-01-20 Thread Kalesh A P
From: Kalesh AP Please apply. Ajit Khaparde (1): net/bnxt: fix VF resource allocation strategy Kalesh AP (3): net/bnxt: fix check for autoneg enablement net/bnxt: handle ring cleanup in case of error net/bnxt: fix to alloc the memzone per VNIC drivers/net/bnxt/bnxt_hwrm.c | 35 +++

Re: [PATCH] common/cnxk: enable NIX Tx interrupts errata

2022-01-20 Thread Jerin Jacob
On Thu, Jan 13, 2022 at 5:48 PM Harman Kalra wrote: > > An errata exists whereby NIX may incorrectly overwrite the value in > NIX_SQ_CTX_S[SQ_INT]. This may cause set interrupts to get cleared or > causing an QINT when no error is outstanding. > As a workaround, software should always read all SQ

Re: [PATCH v3 1/2] net/cnxk: update meter bpf ID in Receive Queue

2022-01-20 Thread Jerin Jacob
On Thu, Jan 13, 2022 at 5:58 PM Rakesh Kudurumalla wrote: > > Patch updates configured meter bpf is in receive queue > context during meter creation > > Signed-off-by: Rakesh Kudurumalla > Acked-by: Sunil Kumar Kori Series Acked-by: Jerin Jacob Series applied to dpdk-next-net-mrvl/for-next-net

[Bug 923] i40e PMD contains copy-pasted bug from mempool library

2022-01-20 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=923 Bug ID: 923 Summary: i40e PMD contains copy-pasted bug from mempool library Product: DPDK Version: unspecified Hardware: All OS: All Status: UNCONFIRMED Severity:

Re: [PATCH v5 00/50] introduce IWYU

2022-01-20 Thread David Marchand
Hello Sean, On Mon, Jan 17, 2022 at 9:20 PM Sean Morrissey wrote: > > This patchset introduces the include-what-you-use script which removes > unused header includes. IWYU GitHub: > > https://github.com/include-what-you-use/include-what-you-use > > Along with the script there are some patches whi

RE: [PATCH v2 1/1] mempool: implement index-based per core cache

2022-01-20 Thread Morten Brørup
+CC Beilei as i40e maintainer > From: Dharmik Thakkar [mailto:dharmik.thak...@arm.com] > Sent: Thursday, 13 January 2022 06.37 > > Current mempool per core cache implementation stores pointers to mbufs > On 64b architectures, each pointer consumes 8B > This patch replaces it with index-based impl

Re: [PATCH v3] raw/ifpga: fix pthread cannot join

2022-01-20 Thread David Marchand
On Thu, Jan 20, 2022 at 7:01 AM Wei Huang wrote: > > From: Tianfei Zhang > > When we want to close a thread, we should set a flag to notify > thread handler function. > > Fixes: 9c006c45 ("raw/ifpga: scan PCIe BDF device tree") > Cc: sta...@dpdk.org > > Signed-off-by: Tianfei Zhang > --- > v2: u