RE: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write

2021-12-19 Thread Wang, Haiyue
> -Original Message- > From: Stephen Douthit > Sent: Tuesday, December 7, 2021 06:19 > To: Wang, Haiyue ; Lu, Wenzhuo ; > Changchun Ouyang > ; Zhang, Helin > Cc: dev@dpdk.org; Wen Wang ; Stephen Douthit > ; > sta...@dpdk.org > Subject: [PATCH v2 3/7] net/ixgbe: Check that SFF-8472 soft

RE: [PATCH v2 1/7] net/ixgbe: Fix ixgbe_is_sfp() to return valid result for X550EM_a devs

2021-12-19 Thread Wang, Haiyue
> -Original Message- > From: Stephen Douthit > Sent: Tuesday, December 7, 2021 06:19 > To: Wang, Haiyue ; Lu, Wenzhuo > Cc: dev@dpdk.org; Wen Wang ; Stephen Douthit > ; > sta...@dpdk.org > Subject: [PATCH v2 1/7] net/ixgbe: Fix ixgbe_is_sfp() to return valid result > for X550EM_a devs >

RE: [dpdk-dev] [PATCH] net/ixgbe: check ixgbe filter init failure

2021-12-19 Thread Wang, Haiyue
> -Original Message- > From: Yunjian Wang > Sent: Saturday, December 4, 2021 18:24 > To: dev@dpdk.org > Cc: Wang, Haiyue ; dingxiaoxi...@huawei.com; > xudin...@huawei.com; Yunjian Wang > ; sta...@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: check ixgbe filter init failure > > The fu

[Bug 913] [dpdk-19.11.11]'mk/' makefile build failed on Freebsd13 with clang11.0.1

2021-12-19 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=913 Bug ID: 913 Summary: [dpdk-19.11.11]'mk/' makefile build failed on Freebsd13 with clang11.0.1 Product: DPDK Version: 19.11 Hardware: All OS: All Status:

RE: [PATCH 3/3] net/ixgbe: reduce redundant store operation

2021-12-19 Thread Wang, Haiyue
> -Original Message- > From: Feifei Wang > Sent: Monday, December 20, 2021 13:51 > To: Wang, Haiyue > Cc: dev@dpdk.org; n...@arm.com; Feifei Wang ; Ruifeng > Wang > Subject: [PATCH 3/3] net/ixgbe: reduce redundant store operation > > For free buffer in ixgbe driver, it is unnecessary t

[PATCH 3/3] net/ixgbe: reduce redundant store operation

2021-12-19 Thread Feifei Wang
For free buffer in ixgbe driver, it is unnecessary to store 'NULL' into txep.mbuf. This is because when putting mbuf into Tx queue, tx_tail is the sentinel. And when doing tx_free, tx_next_dd is the sentinel. In all processes, mbuf==NULL is not a condition in check. Thus reset of mbuf is unnecessar

[PATCH 2/3] net/ice: reduce redundant store operation

2021-12-19 Thread Feifei Wang
For free buffer in ice driver, it is unnecessary to store 'NULL' into txep.mbuf. This is because when putting mbuf into Tx queue, tx_tail is the sentinel. And when doing tx_free, tx_next_dd is the sentinel. In all processes, mbuf==NULL is not a condition in check. Thus reset of mbuf is unnecessary

[PATCH 1/3] net/i40e: reduce redundant store operation

2021-12-19 Thread Feifei Wang
For free buffer operation in i40e driver, it is unnecessary to store 'NULL' into txep.mbuf. This is because when putting mbuf into Tx queue, tx_tail is the sentinel. And when doing tx_free, tx_next_dd is the sentinel. In all processes, mbuf==NULL is not a condition in check. Thus reset of mbuf is u

[PATCH 0/3] reduce redundant store operation for Tx free

2021-12-19 Thread Feifei Wang
Reduce redundant store operation for buffer free in Tx path. Feifei Wang (3): net/i40e: reduce redundant store operation net/ice: reduce redundant store operation net/ixgbe: reduce redundant store operation drivers/net/i40e/i40e_rxtx.c| 3 --- drivers/net/i40e/i40e_rxtx_vec_com

[PATCH] net/i40e: remove redundant judgment for rearm

2021-12-19 Thread Feifei Wang
Merged variable updates under the same condition. It reduces branch. In n1sdp, there is no performance improvement with this patch. In x86, there is also no performance improvement. Suggested-by: Honnappa Nagarahalli Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang --- drivers/net/i40e/i4

Re: [PATCH v1 16/25] net/spnic: add device configure/version/info

2021-12-19 Thread Stephen Hemminger
On Sat, 18 Dec 2021 10:51:43 +0800 Yanling Song wrote: > +static int spnic_dev_configure(struct rte_eth_dev *dev) > +{ > + struct spnic_nic_dev *nic_dev = SPNIC_ETH_DEV_TO_PRIVATE_NIC_DEV(dev); > + > + nic_dev->num_sqs = dev->data->nb_tx_queues; > + nic_dev->num_rqs = dev->data->nb_r

Re: [PATCH] crypto: use single buffer for asymmetric session

2021-12-19 Thread Ray Kinsella
Ciara, One minor niggle. Ciara Power writes: > diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map > index c50745fa8c..00b1c9ae35 100644 > --- a/lib/cryptodev/version.map > +++ b/lib/cryptodev/version.map > @@ -58,7 +58,6 @@ EXPERIMENTAL { > rte_cryptodev_asym_session_cle

Re: [PATCH v1 01/25] drivers/net: introduce a new PMD driver

2021-12-19 Thread Stephen Hemminger
On Sat, 18 Dec 2021 10:51:28 +0800 Yanling Song wrote: > +#ifdef CLOCK_MONOTONIC_RAW /* Defined in glibc bits/time.h */ > +#define CLOCK_TYPE CLOCK_MONOTONIC_RAW > +#else > +#define CLOCK_TYPE CLOCK_MONOTONIC > +#endif CLOCK_MONOTONIC_RAW was defined in Linux.2.6.28 DPDK does not support any ker

Build igb_uio.ko separately from building all DPDK code

2021-12-19 Thread Asaf Sinai
Hi, How to build 'igb_uio.ko', without the need to build all DPDK code? Thanks, Asaf [Radware] Asaf Sinai ND SW Engineer Email: asa...@radware.com T:+972-72-3917050 M:+972-50-6518541 F:+972-3-6488662 [Check out the latest and greatest from Radware]