[PATCH v2 2/2] devtools: report commit id on partial fixes

2021-12-02 Thread christian . ehrhardt
From: Christian Ehrhardt The candidate list for backports lists partial fixes like: "(21.02 (partially fixed in 21.08))" That is useful to identify fixes menat for later releases, but indirectly applying to older ones as well. While the devscript has no access to the stable tree to fully check

[PATCH v2 1/2] devtools: don't include headline "fix" in backports

2021-12-02 Thread christian . ehrhardt
From: Christian Ehrhardt It was important in the past to select anything with "fix" in the headline, but recently more often created false positives and work to sort tihngs out than identifying many helpful patches. The community and processes aroudn DPDK matured enough that developers (rightful

[PATCH] net/kni: reset rte_kni_conf struct before initialization

2021-12-02 Thread Harold Huang
When kni driver calls eth_kni_start to start device, some fields such as min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu value. This is unexpected and in some time we could not change the kni device mtu

[PATCH v3] kni: fix ioctl signature

2021-12-02 Thread Markus Theil
From: Markus Theil Fix kni's ioctl signature to correctly match the kernel's structs. This shaves off the (void*) casts and uses struct file* instead of struct inode*. With the correct signature, control flow integrity checkers are no longer confused at this point. Signed-off-by: Markus Theil T

Re: please help backporting some patches to stable release 19.11.11

2021-12-02 Thread Christian Ehrhardt
On Thu, Dec 2, 2021 at 9:18 PM Maxime Coquelin wrote: > > Hi Christian, > > On 12/2/21 14:45, Christian Ehrhardt wrote: > > On Tue, Nov 30, 2021 at 5:56 PM wrote: > >> > >> Hi commit authors (and maintainers), > >> > >> Despite being selected by the DPDK maintenance tool > >> ./devtools/git-log-

[Bug 893] no_hugetlbfs should not mean legacy_mem on iommu/vfio platforms

2021-12-02 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=893 Bug ID: 893 Summary: no_hugetlbfs should not mean legacy_mem on iommu/vfio platforms Product: DPDK Version: unspecified Hardware: All OS: All Status: UNC

[PATCH v11 7/9] app/test: remove two alarm_autotest cases

2021-12-02 Thread Jie Zhou
Remove two alarm_autotest test cases which do bogus range check on Windows. Signed-off-by: Jie Zhou --- app/test/test_alarm.c | 4 1 file changed, 4 insertions(+) diff --git a/app/test/test_alarm.c b/app/test/test_alarm.c index b4034339b8..70e97a3109 100644 --- a/app/test/test_alarm.c +++

[PATCH v11 9/9] app/test: enable subset of unit tests on Windows

2021-12-02 Thread Jie Zhou
- For fast tests and perf tests, add test stubs to skip not supported ones. - For driver tests, for now skip on Windows totally to avoid unnecessary amount of test stubs. For example, there are about 30 cryptodev related tests (even though in the meson for CI it only listed about half) whic

[PATCH v11 6/9] app/test: differentiate a strerror on different OS

2021-12-02 Thread Jie Zhou
On Windows, strerror returns just "Unknown error" for errnum greater than MAX_ERRNO, while linux and freebsd returns "Unknown error ", which is the current expectation for errno_autotest. Differentiate the error string on Windows to remove a "duplicate error code" failure. Signed-off-by: Jie Zhou

[PATCH v11 8/9] app/test: replace .sh script with .py script

2021-12-02 Thread Jie Zhou
- Add python script to check if system supports hugepages - Remove corresponding .sh script - Replace calling of .sh with corresponding .py in meson.build Signed-off-by: Jie Zhou --- app/test/has-hugepage.sh | 11 --- app/test/has_hugepage.py | 26 ++ app/test/me

[PATCH v11 5/9] app/test: skip two logs_autotest cases on Windows

2021-12-02 Thread Jie Zhou
DPDK logs_autotest on Windows failed at "dynamic log types" tests. The failures are on 2 test cases for rte_log_set_level_regexp API, due to regular expression is not supported on Windows in DPDK yet and regcomp/regexec are just stubs on Windows (in regex.h). In app\test\test_logs.c, ifndef these

[PATCH v11 2/9] app/test: remove POSIX-specific code

2021-12-02 Thread Jie Zhou
- Remove header inclusion of netinet/in.h and terminos.h - Include rte_os_shim.h - Replace sleep and usleep with rte_delay_us_sleep - Use NUL on Windows as /dev/null for Linux - Exclude tests not supported on Windows yet, e.g. multi-process, and IP address parsing (the test cases use linux netine

[PATCH v11 4/9] app/test: skip interrupt tests on Windows

2021-12-02 Thread Jie Zhou
Even though test_interrupts.c can compile on Windows, skip interrupt tests for now since majority of eal_interrupt on Windows are stubs. Will remove the skip after interrupt being fully enabled on Windows. Signed-off-by: Jie Zhou --- app/test/test_interrupts.c | 10 ++ 1 file changed, 1

[PATCH v11 3/9] app/test: fix incorrect errno variable

2021-12-02 Thread Jie Zhou
Fix incorrect errno variable used in memory autotest. Use rte_errno instead. Fixes: 086d426406bd ("app/test: fix memory autotests on FreeBSD") Cc: bruce.richard...@intel.com Signed-off-by: Jie Zhou --- app/test/test_memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/a

[PATCH v11 0/9] app/test: enable subset of tests on Windows

2021-12-02 Thread Jie Zhou
This patchset is to enable a subset of unit tests on windows. It mainly includes: - Replace POSIX specific codes - Add test stubs for not supported ones on Windows - Fix some lib and tests per failures investigation - Replace .sh script with .py script for meson.build - Enable build and run subset

[PATCH v11 1/9] eal/windows: return ENOTSUP for not supported API

2021-12-02 Thread Jie Zhou
UT memory_autotest on Windows has 2 failed cases on eal APIs eal_memalloc_get_seg_fd and eal_memalloc_get_seg_fd_offset. These 2 APIs are not supported on Windows yet. Should return ENOTSUP such that in test_memory.c these 2 ENOTSUP cases will not be marked as failures, same as other ENOTSUP cases.

Re: [PATCH v10 9/9] app/test: enable subset of unit tests on Windows

2021-12-02 Thread Jie Zhou
On Thu, Dec 02, 2021 at 10:17:48AM +0100, David Marchand wrote: > Hello, > > On Wed, Dec 1, 2021 at 7:45 PM Jie Zhou wrote: > > @@ -158,34 +152,17 @@ test_sources = files( > > ) > > > > test_deps = [ > > -'acl', > > 'bus_pci', > > 'bus_vdev', > > -'bpf', > > +

Re: [PATCH v2] version: 22.03-rc0

2021-12-02 Thread David Marchand
On Thu, Dec 2, 2021 at 7:11 PM David Marchand wrote: > > Start a new release cycle with empty release notes. > Bump version and ABI minor. > Enable ABI checks. > > Signed-off-by: David Marchand > Acked-by: Thomas Monjalon Applied, thanks. -- David Marchand

Re: please help backporting some patches to stable release 19.11.11

2021-12-02 Thread Maxime Coquelin
Hi Christian, On 12/2/21 14:45, Christian Ehrhardt wrote: On Tue, Nov 30, 2021 at 5:56 PM wrote: Hi commit authors (and maintainers), Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh I didn't apply following commits from DPDK main to 19.11 stable branch, as con

Re: [PATCH v2] version: 22.03-rc0

2021-12-02 Thread Thomas Monjalon
02/12/2021 19:11, David Marchand: > Start a new release cycle with empty release notes. > Bump version and ABI minor. > Enable ABI checks. > > Signed-off-by: David Marchand > Acked-by: Thomas Monjalon > --- > Changes since v1: > - stick to libabigail 1.8, OK it looks reasonnable.

Minutes of Technical Board Meeting, 2021-12-01

2021-12-02 Thread Stephen Hemminger
Members Attending = - Aaron - Bruce - David - Ferruh - Hemant - Honnappa - Jerin - Konstantin - Maxime - Olivier - Stephen (Chair) - Thomas NOTE: The technical board meetings every second Wednesday at https://meet.jit.si/DPDK at 3 pm UTC. Meetings are public, and DPDK community m

[PATCH v2] version: 22.03-rc0

2021-12-02 Thread David Marchand
Start a new release cycle with empty release notes. Bump version and ABI minor. Enable ABI checks. Signed-off-by: David Marchand Acked-by: Thomas Monjalon --- Changes since v1: - stick to libabigail 1.8, --- .github/workflows/build.yml| 4 +- .travis.yml

[PATCH] tap:remove maintainer

2021-12-02 Thread Wiles, Keith
I no longer have the bandwidth to support the TAP PMD, so I am removing myself as the maintainer so as to not hold up commits. Signed-off-by: Wiles, Keith --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 18d9edaf88..b43285b6ab 10

[PATCH] tap:remove maintainer

2021-12-02 Thread Wiles, Keith
I no longer have the bandwidth to support the TAP PMD, so I am removing myself as the maintainer so as to not hold up commits. Signed-off-by: Keith Wiles --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 18d9edaf88..b43285b6ab 100

Re: [PATCH] version: 22.03-rc0

2021-12-02 Thread David Marchand
On Tue, Nov 30, 2021 at 8:51 PM David Marchand wrote: > > On Tue, Nov 30, 2021 at 4:35 PM Thomas Monjalon wrote: > > > > 29/11/2021 14:16, David Marchand: > > > Start a new release cycle with empty release notes. > > > Bump version and ABI minor. > > > Enable ABI checks using latest libabigail. >

[PATCH v2] net/axgbe: use PCI root complex device to distinguish AMD hardware

2021-12-02 Thread Chandubabu Namburu
"bus/pci: optimize bus scan" broke axgbe on V1000/R1000. RV root complex pci device does not have any kernel driver assigned so it is removed from pci scan list which is used in "net/axgbe: add a HW quirk for register definitions". Get root complex device id directly from pci sysfs instead of pci

RE: [dpdk-dev] Question Regarding FIPS Validation in DPDK

2021-12-02 Thread Mcnamara, John
> -Original Message- > From: Mcnamara, John > Sent: Thursday, December 2, 2021 8:45 AM > To: Brandon Lo ; Zhang, Roy Fan > Cc: dev ; Kovacevic, Marko > Subject: RE: [dpdk-dev] Question Regarding FIPS Validation in DPDK > > > -Original Message- > > From: dev On Behalf Of Brand

RE: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister

2021-12-02 Thread Morten Brørup
> From: Ananyev, Konstantin [mailto:konstantin.anan...@intel.com] > Sent: Thursday, 2 December 2021 14.01 > > > > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > > Sent: Thursday, 2 December 2021 08.19 > > > > > > 01/12/2021 22:37, Tyler Retzlaff: > > > > On Wed, Nov 24, 2021 at 06:04:56PM

[PATCH] net/virtio: fix Tx queue 0 override by queue 128

2021-12-02 Thread Xueming Li
Both Rx queue and Tx queue are VirtQ in virtio, VQ index is 256 for Tx queue 128. Uint8 type of TxQ VQ index overflows and overrides Tx queue 0 data. This patch fixes VQ index type with uint16 type. Fixes: c1f86306a026 ("virtio: add new driver") Cc: sta...@dpdk.org Signed-off-by: Xueming Li ---

RE: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister

2021-12-02 Thread Ananyev, Konstantin
> > From: Thomas Monjalon [mailto:tho...@monjalon.net] > > Sent: Thursday, 2 December 2021 08.19 > > > > 01/12/2021 22:37, Tyler Retzlaff: > > > On Wed, Nov 24, 2021 at 06:04:56PM +, Bruce Richardson wrote: > > > > if (ret < 0 && rte_errno == EAGAIN) > > > > > > i only urge that this be ex

Re: [PATCH v2] dma/idxd: add allow/block list support

2021-12-02 Thread Kevin Laatz
On 02/12/2021 12:50, Radu Nicolau wrote: Add support for allow or block list for devices bound to the kernel driver. When used the allow or block list applies as an additional condition to the name prefix. Signed-off-by: Radu Nicolau Reviewed-by: Bruce Richardson Acked-by: Bruce Richardson

RE: [PATCH v2 2/2] net/ixgbe: fix spelling mistakes

2021-12-02 Thread Wang, Haiyue
> -Original Message- > From: Bin Zheng > Sent: Thursday, December 2, 2021 17:20 > To: dev@dpdk.org > Cc: Wang, Haiyue ; lian...@liangbit.com; Bin Zheng > > Subject: [PATCH v2 2/2] net/ixgbe: fix spelling mistakes > > fix comment spelling mistakes > > Signed-off-by: Bin Zheng > --- > d

[PATCH v2] dma/idxd: add allow/block list support

2021-12-02 Thread Radu Nicolau
Add support for allow or block list for devices bound to the kernel driver. When used the allow or block list applies as an additional condition to the name prefix. Signed-off-by: Radu Nicolau Reviewed-by: Bruce Richardson Acked-by: Bruce Richardson --- v2: corrected doc doc/guides/dmadevs/id

RE: [PATCH v1] gpudev: return EINVAL if invalid input pointer for free and unregister

2021-12-02 Thread Morten Brørup
> From: Thomas Monjalon [mailto:tho...@monjalon.net] > Sent: Thursday, 2 December 2021 08.19 > > 01/12/2021 22:37, Tyler Retzlaff: > > On Wed, Nov 24, 2021 at 06:04:56PM +, Bruce Richardson wrote: > > > if (ret < 0 && rte_errno == EAGAIN) > > > > i only urge that this be explicit as opposed

[PATCH] examples/ipsec-secgw: fix event dev start sequence

2021-12-02 Thread Nithin Dabilpuram
Start eventdev after complete initialization of event dev, rx adapter and tx adapter. Fixes: e0b0e55c8f15 ("examples/ipsec-secgw: add framework for event helper") Cc: ano...@marvell.com Cc: sta...@dpdk.org Signed-off-by: Nithin Dabilpuram --- examples/ipsec-secgw/event_helper.c | 17 +++

Re:RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2021-12-02 Thread Huichao Cai
Perhaps performance is more important.This code comes from the linux kernel(5.10.9 and so on). :) It is more performance-focused based on comments. :)

RE: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2021-12-02 Thread Ananyev, Konstantin
I didn't look at it in detail yet, just wonder would be real gain in terms of space? From: Huichao Cai Sent: Thursday, December 2, 2021 11:39 AM To: Dariusz Sosnowski Cc: Ananyev, Konstantin ; dev@dpdk.org Subject: Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data If options

Re:Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2021-12-02 Thread Huichao Cai
If options with copied flag unset are not copied, then IPv4 headers in the fragments (despite 1st fragment) will be shorter. This leaves more byte space for the payload and in effect fragmentation might produce less fragments. --Do I need to modify it this way?

Re: [PATCH] ip_frag: add IPv4 options fragment and unit test data

2021-12-02 Thread Dariusz Sosnowski
Hi, On Thu, 2 Dec 2021 10:24:40 +0800, Huichao Cai wrote: > > Substituting options with NOOP might cause rte_ipv4_fragment_packet to > > produce more fragments than necessary, since options with copied flag unset > > will still occupy space in IPv4 header. > --The "ip_options_fragment" just make

[PATCH v2 2/2] net/ixgbe: fix spelling mistakes

2021-12-02 Thread Bin Zheng
fix comment spelling mistakes Signed-off-by: Bin Zheng --- drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c index 5811749b95..4654d0adec 100644 --- a/drivers

[PATCH v2 1/2] net/ixgbe: add vector Rx parameter check

2021-12-02 Thread Bin Zheng
Under the circumstance that `rx_tail` wrap back to zero and the advance speed of `rx_tail` is greater than `rxrearm_start`, `rx_tail` will catch up with `rxrearm_start` and surpass it. This may cause some mbufs be reused by application. So we need to make some restrictions to ensure that `rx_tail

Re: [PATCH v10 9/9] app/test: enable subset of unit tests on Windows

2021-12-02 Thread David Marchand
Hello, On Wed, Dec 1, 2021 at 7:45 PM Jie Zhou wrote: > @@ -158,34 +152,17 @@ test_sources = files( > ) > > test_deps = [ > -'acl', > 'bus_pci', > 'bus_vdev', > -'bpf', > +'bitratestats', There is some issue with your rebase. Please don't reintroduce m

RE: [dpdk-dev] Question Regarding FIPS Validation in DPDK

2021-12-02 Thread Mcnamara, John
> -Original Message- > From: dev On Behalf Of Brandon Lo > Sent: Wednesday, November 3, 2021 5:45 PM > To: Kovacevic, Marko > Cc: dev > Subject: [dpdk-dev] Question Regarding FIPS Validation in DPDK > > Hello, > > I have been able to use Cisco's libacvp tool to retrieve test vectors fr