[dpdk-dev] 回复: [PATCH v5 1/5] eal: add new definitions for wait scheme

2021-10-26 Thread Feifei Wang
> -邮件原件- > 发件人: Ananyev, Konstantin > 发送时间: Tuesday, October 26, 2021 5:59 PM > 收件人: Feifei Wang > 抄送: dev@dpdk.org; nd ; nd > 主题: RE: [PATCH v5 1/5] eal: add new definitions for wait scheme > > > > > > Introduce macros as generic interface for address monitoring. > > > > For differe

Re: [dpdk-dev] AWS i3.metal and IOMMU

2021-10-26 Thread David Marchand
On Wed, Oct 27, 2021 at 2:55 AM fwefew 4t4tg <7532ya...@gmail.com> wrote: > > As per https://doc.dpdk.org/guides/nics/ena.html section 17.9 > enabling IOMMU on an AWS i3 metal instance is as simple as adding "iommu=1 > intel_iommu=on" to /etc/default/grub, update-grub, and reboot. > > I can't get t

Re: [dpdk-dev] [PATCH v3 3/3] lib/eal: add temporal store memcpy support on AMD platform

2021-10-26 Thread Aman Kumar
On Wed, Oct 27, 2021 at 2:41 AM Stephen Hemminger < step...@networkplumber.org> wrote: > On Tue, 26 Oct 2021 21:26:45 +0530 > Aman Kumar wrote: > > > This patch provides a rte_memcpy* call with temporal stores. > > Use -Dcpu_instruction_set=znverX with build to enable this API. > > > > Signed-off

Re: [dpdk-dev] [PATCH v3 3/3] lib/eal: add temporal store memcpy support on AMD platform

2021-10-26 Thread Aman Kumar
On Tue, Oct 26, 2021 at 9:44 PM Thomas Monjalon wrote: > 26/10/2021 17:56, Aman Kumar: > > This patch provides a rte_memcpy* call with temporal stores. > > Use -Dcpu_instruction_set=znverX with build to enable this API. > > > > Signed-off-by: Aman Kumar > > --- > > config/x86/meson.build

Re: [dpdk-dev] [PATCH v15 06/12] pdump: support pcapng and filtering

2021-10-26 Thread Wang, Yinan
Hi Hemminger, I meet an issue when using dpdk-pdump with your patch ,we try to capture pkts from virtio port, all packets captured shows malformed packets , and no issue if remove your patch. Bug link:https://bugs.dpdk.org/show_bug.cgi?id=840 Could you help to take a look at this issue? BR, Yi

Re: [dpdk-dev] [PATCH v3 2/3] doc/guides: add dpdk build instruction for AMD platforms

2021-10-26 Thread Aman Kumar
On Tue, Oct 26, 2021 at 9:37 PM Thomas Monjalon wrote: > 26/10/2021 17:56, Aman Kumar: > > linux guide updated with AMD platform related build > > instructions. > > > > Signed-off-by: Aman Kumar > > --- > > doc/guides/linux_gsg/build_dpdk.rst | 4 > > 1 file changed, 4 insertions(+) > > >

[dpdk-dev] [Bug 840] [dpdk-21.11] vm2vm_virtio_user/vm2vm_virtio_user_split_virtqueue_mergeable_path: dpdk-pdump capture the pcap file content are wrong

2021-10-26 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=840 Bug ID: 840 Summary: [dpdk-21.11] vm2vm_virtio_user/vm2vm_virtio_user_split_virtqueue_me rgeable_path: dpdk-pdump capture the pcap file content are wrong Product:

Re: [dpdk-dev] [PATCH v3 1/3] config/x86: add support for AMD platform

2021-10-26 Thread Aman Kumar
On Tue, Oct 26, 2021 at 9:31 PM Thomas Monjalon wrote: > 26/10/2021 17:56, Aman Kumar: > > -Dcpu_instruction_set=znverX meson option can be used > > to build dpdk for AMD platform. Supported options are > > znver1, znver2 and znver3. > > OK that approach looks good. > > > +# AMD platform support

Re: [dpdk-dev] [PATCH] net/bnxt: refactor Rx ring cleanup for representors

2021-10-26 Thread Ajit Khaparde
On Mon, Oct 25, 2021 at 10:14 PM Ajit Khaparde wrote: > > Rx ring for representors does not use aggregation rings for Rx. > Instead they use simple software buffers for handling Rx packets. > So there is no need to use the same cleanup routine as done by > the non-representor code path. > > Signed

Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS action parser

2021-10-26 Thread Ajit Khaparde
On Mon, Oct 25, 2021 at 10:14 PM Ajit Khaparde wrote: > > Minor fixes are needed in the RTE_FLOW RSS action parser. > 1. Update the comment in the parser to indicate rss level 1 implies > RSS on outer header. > 2. RSS action will not be supported if level is > 1. > 3. RSS action will not be suppor

[dpdk-dev] [PATCH] failsafe : support secondary process to attach to vdev created by primary process

2021-10-26 Thread Kumara Parameshwaran
Signed-off-by: Kumara Parameshwaran --- drivers/net/failsafe/failsafe.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/failsafe/failsafe.c b/drivers/net/failsafe/failsafe.c index 8216063..1adccaf 100644 --- a/drivers/net/failsafe/failsafe.c +++ b/drivers/net/fai

Re: [dpdk-dev] [PATCH v5] net/ice: fix function pointer in multi-process

2021-10-26 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Tuesday, October 26, 2021 9:56 AM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Wang, Haiyue ; Yu, DapengX > ; sta...@dpdk.org > Subject: [PATCH v5] net/ice: fix function pointer in multi-process > > From: Dapeng Yu > > This

Re: [dpdk-dev] [PATCH v5] net/ice: simplify the use of DCF device reset

2021-10-26 Thread Zhang, Qi Z
> -Original Message- > From: Yu, DapengX > Sent: Tuesday, October 26, 2021 5:53 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org; Yu, DapengX ; sta...@dpdk.org > Subject: [PATCH v5] net/ice: simplify the use of DCF device reset It's a workaround, so rename to "workaround DCF

[dpdk-dev] Question about bonding port promiscuous

2021-10-26 Thread Min Hu (Connor)
Hi, David, In function "bond_ethdev_promiscuous_disable", for "ROUND ROBIN","BALANCE","BROADCAST","8023AD" mode, Promiscuous mode is propagated to all slaves. While for "ACTIVE_BACKUP", "TLB", "ALB", promiscuous mode is propagated only to primary slave. Why? The second question, for "ACTIVE_B

[dpdk-dev] [PATCH v5 4/4] net/ice: enable protocol agnostic flow offloading in FDIR

2021-10-26 Thread Junfeng Guo
Protocol agnostic flow offloading in Flow Director is enabled by this patch based on the Parser Library, using existing rte_flow raw API. Note that the raw flow requires: 1. byte string of raw target packet bits. 2. byte string of mask of target packet. Here is an example: FDIR matching ipv4 dst

[dpdk-dev] [PATCH v5 0/4] enable protocol agnostic flow offloading in FDIR

2021-10-26 Thread Junfeng Guo
Protocol agnostic flow offloading in Flow Director is enabled by this patch set based on the Parser Library using existing rte_flow raw API [PATCH v4 1/4] net/ice/base: add method to disable FDIR SWAP option. [PATCH v4 2/4] net/ice/base: add function to set HW profile for raw flow. [PATCH v4 3/4]

[dpdk-dev] [PATCH v5 1/4] net/ice/base: add method to disable FDIR SWAP option

2021-10-26 Thread Junfeng Guo
The SWAP Flag in the FDIR Programming Descriptor doesn't work, thus add a method to disable the FDIR SWAP option by setting the swap and inset register set with certain values. The boolean fd_swap is used to enable/disable the SWAP option. Signed-off-by: Junfeng Guo --- drivers/net/ice/base/ice_

[dpdk-dev] [PATCH v5 3/4] app/testpmd: update Max RAW pattern size to 512

2021-10-26 Thread Junfeng Guo
Update max size for pattern in struct rte_flow_item_raw to enable protocol agnostic flow offloading. Signed-off-by: Junfeng Guo --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index d821

[dpdk-dev] [PATCH v5 2/4] net/ice/base: add function to set HW profile for raw flow

2021-10-26 Thread Junfeng Guo
Based on the parser library, we can directly set HW profile and associate the main/ctrl vsi. Signed-off-by: Junfeng Guo --- drivers/net/ice/base/ice_flex_pipe.c | 49 drivers/net/ice/base/ice_flex_pipe.h | 3 + drivers/net/ice/base/ice_flow.c | 87 +

Re: [dpdk-dev] [PATCH v4 2/4] net/ice/base: add function to set HW profile for raw flow

2021-10-26 Thread Guo, Junfeng
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, October 27, 2021 10:18 > To: Guo, Junfeng ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, Haiyue > ; Yan, Zhirun > Subject: RE: [PATCH v4 2/4] net/ice/base: add function to set HW profile > for raw f

Re: [dpdk-dev] [PATCH v4 2/4] net/ice/base: add function to set HW profile for raw flow

2021-10-26 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Wednesday, October 27, 2021 9:58 AM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, Haiyue > ; Yan, Zhirun > Subject: RE: [PATCH v4 2/4] net/ice/base: add function to set HW profile for > raw

[dpdk-dev] [PATCH] app/testpmd: fix error definition type

2021-10-26 Thread Jie Wang
In "msg_type |= 0xc800", wider "51200" has high-order bits (0xc800) that don't affect the narrower left-hand side. This patch fixs coverity issue by changing the definition type of "msg_type" from uint8_t to uint16_t. Coverity issue: 373651 Fixes: 748530f0354e ("app/testpmd: support L2TPv2 and PP

Re: [dpdk-dev] [PATCH v4 2/4] net/ice/base: add function to set HW profile for raw flow

2021-10-26 Thread Guo, Junfeng
> -Original Message- > From: Zhang, Qi Z > Sent: Wednesday, October 27, 2021 08:58 > To: Guo, Junfeng ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, Haiyue > ; Yan, Zhirun > Subject: RE: [PATCH v4 2/4] net/ice/base: add function to set HW profile > for raw f

Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS behavior on Thor

2021-10-26 Thread Ajit Khaparde
On Mon, Oct 25, 2021 at 9:54 PM Kalesh A P wrote: > > From: Kalesh AP > > Move the Rx queue state update before bnxt_setup_one_vnic() > is called. For Thor, rxq->rx_started and eth_dev->data->rx_queue_state[] > needs to be set for all queues before bnxt_hwrm_vnic_cfg() or > bnxt_vnic_rss_configur

[dpdk-dev] [PATCH v2] net/mlx5: allow meta modifications in legacy mode

2021-10-26 Thread Alexander Kozyrev
The MODIFY_FIELD RTE action rejects copy to/from metadata in case of the legacy mode extensive flow metadata support. It is not consistent with SET_META action that has no such restriction imposed. Registers A or B are used for META in legacy mode. Allow meta modifications in legacy mode as well.

Re: [dpdk-dev] [PATCH v4 2/4] net/ice/base: add function to set HW profile for raw flow

2021-10-26 Thread Zhang, Qi Z
> -Original Message- > From: Guo, Junfeng > Sent: Tuesday, October 26, 2021 8:01 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Xing, Beilei > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, Haiyue > ; Yan, Zhirun ; Guo, Junfeng > > Subject: [PATCH v4 2/4] net/ice/base: add function to set HW profil

[dpdk-dev] AWS i3.metal and IOMMU

2021-10-26 Thread fwefew 4t4tg
As per https://doc.dpdk.org/guides/nics/ena.html section 17.9 enabling IOMMU on an AWS i3 metal instance is as simple as adding "iommu=1 intel_iommu=on" to /etc/default/grub, update-grub, and reboot. I can't get this to work. Once done, I cannot ssh back into the instance; EC2 console can't get go

Re: [dpdk-dev] [PATCH v12 2/7] net/iavf: rework tx path

2021-10-26 Thread Zhang, Qi Z
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, October 26, 2021 9:57 PM > To: Wu, Jingjing ; Xing, Beilei > ; > Richardson, Bruce ; Ananyev, Konstantin > > Cc: dev@dpdk.org; Doherty, Declan ; Sinha, > Abhijit ; Zhang, Qi Z ; > Nicolau, > Radu > Subject: [PATCH v12 2/7]

Re: [dpdk-dev] [PATCH v12 0/7] iavf: add iAVF IPsec inline crypto support

2021-10-26 Thread Zhang, Qi Z
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, October 26, 2021 9:57 PM > Cc: dev@dpdk.org; Doherty, Declan ; Sinha, > Abhijit ; Wu, Jingjing ; > Zhang, > Qi Z ; Xing, Beilei ; Richardson, > Bruce ; Ananyev, Konstantin > ; Nicolau, Radu > Subject: [PATCH v12 0/7] iavf: ad

Re: [dpdk-dev] [PATCH v12 4/7] net/iavf: add iAVF IPsec inline crypto support

2021-10-26 Thread Zhang, Qi Z
> -Original Message- > From: Nicolau, Radu > Sent: Tuesday, October 26, 2021 9:57 PM > To: Wu, Jingjing ; Xing, Beilei > ; > Ray Kinsella > Cc: dev@dpdk.org; Doherty, Declan ; Sinha, > Abhijit ; Zhang, Qi Z ; > Richardson, Bruce ; Ananyev, Konstantin > ; Nicolau, Radu > Subject: [PAT

Re: [dpdk-dev] [PATCH] app/testpmd: fix statistics in multiple process

2021-10-26 Thread Min Hu (Connor)
在 2021/10/27 0:22, Ferruh Yigit 写道: On 9/17/2021 4:33 AM, Min Hu (Connor) wrote: Hi, Xiaoyun, 在 2021/9/16 13:17, Li, Xiaoyun 写道: Hi -Original Message- From: Min Hu (Connor) Sent: Tuesday, September 14, 2021 11:13 To: dev@dpdk.org Cc: Yigit, Ferruh ; Li, Xiaoyun Subject: [PATCH

Re: [dpdk-dev] Minutes of Technical Board Meeting, 2021-Oct-20

2021-10-26 Thread Ananyev, Konstantin
> > 4) GPU library / DWA library inclusion > > http://inbox.dpdk.org/dev/dm6pr12mb41079fae6b5da35102b1bbfacd...@dm6pr12mb4107.namprd12.prod.outlook.com/ > http://mails.dpdk.org/archives/dev/2021-October/226070.html > > Separate TB meeting is scheduled to cover that topic. > Date: Wednesd

[dpdk-dev] [PATCH 1/3] eventdev: allow for event devices requiring maintenance

2021-10-26 Thread Mattias Rönnblom
Extend Eventdev API to allow for event devices which require various forms of internal processing to happen, even when events are not enqueued to or dequeued from a port. PATCH v1: - Adapt to the move of fastpath function pointers out of rte_eventdev struct - Attempt to clarify how often t

[dpdk-dev] [PATCH 3/3] eventdev: have adapters support device maintenance

2021-10-26 Thread Mattias Rönnblom
Introduce support for event devices requiring calls to rte_event_maintain() in the Ethernet RX, Timer and Crypto Eventdev adapters. RFC v2: - For simplicity, the timer adapter now unconditionally calls rte_event_maintain(). - The RX adapter now only calls rte_event_maintain() when it has n

[dpdk-dev] [PATCH 2/3] event/dsw: make use of eventdev maintenance facility

2021-10-26 Thread Mattias Rönnblom
Set the RTE_EVENT_DEV_CAP_REQUIRES_MAINT flag, and perform DSW background tasks on rte_event_maintain() calls. RFC v2: Have dsw_event_maintain() occasionally flush the port output buffers. Signed-off-by: Mattias Rönnblom Tested-by: Richard Eklycke Tested-by: Liron Himi --- drivers/eve

Re: [dpdk-dev] [PATCH v18 5/5] app/test: add tests for PIE

2021-10-26 Thread Singh, Jasvinder
> -Original Message- > From: Liguzinski, WojciechX > Sent: Monday, October 25, 2021 12:32 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v18 5/5] app/test: add tests for PIE > > Tests for PIE code added to test application. > >

Re: [dpdk-dev] [PATCH v3 3/3] lib/eal: add temporal store memcpy support on AMD platform

2021-10-26 Thread Stephen Hemminger
On Tue, 26 Oct 2021 21:26:45 +0530 Aman Kumar wrote: > This patch provides a rte_memcpy* call with temporal stores. > Use -Dcpu_instruction_set=znverX with build to enable this API. > > Signed-off-by: Aman Kumar Ok, but would be better to get it into glibc. Would benefit wider array of platfor

Re: [dpdk-dev] [PATCH v18 4/5] doc/guides/prog_guide: added PIE

2021-10-26 Thread Singh, Jasvinder
> -Original Message- > From: Liguzinski, WojciechX > Sent: Monday, October 25, 2021 12:32 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v18 4/5] doc/guides/prog_guide: added PIE > > Added PIE related information to documentatio

Re: [dpdk-dev] [PATCH v18 3/5] example/ip_pipeline: add PIE support

2021-10-26 Thread Singh, Jasvinder
> -Original Message- > From: Liguzinski, WojciechX > Sent: Monday, October 25, 2021 12:32 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v18 3/5] example/ip_pipeline: add PIE support > > Adding the PIE support for IP Pipeline >

Re: [dpdk-dev] [PATCH v18 2/5] example/qos_sched: add PIE support

2021-10-26 Thread Singh, Jasvinder
> -Original Message- > From: Liguzinski, WojciechX > Sent: Monday, October 25, 2021 12:32 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v18 2/5] example/qos_sched: add PIE support > > patch add support enable PIE or RED by > pa

Re: [dpdk-dev] [PATCH v18 1/5] sched: add PIE based congestion management

2021-10-26 Thread Singh, Jasvinder
> -Original Message- > From: Liguzinski, WojciechX > Sent: Monday, October 25, 2021 12:32 PM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Ajmera, Megha > Subject: [PATCH v18 1/5] sched: add PIE based congestion management > > Implement PIE based congestion mana

Re: [dpdk-dev] [PATCH 2/4] dma/cnxk: create and initialize dmadev on pci probe

2021-10-26 Thread Radha Mohan
On Tue, Oct 26, 2021 at 2:32 AM Jerin Jacob wrote: > > On Tue, Oct 26, 2021 at 9:43 AM Radha Mohan Chintakuntla > wrote: > > > > This patch creates and initializes a dmadev device on pci probe. > > > > Signed-off-by: Radha Mohan Chintakuntla > > --- > > MAINTAINERS| 7 +- >

Re: [dpdk-dev] [PATCH 2/2] net/memif: fix driver init with default MTU

2021-10-26 Thread Stephen Hemminger
On Tue, 26 Oct 2021 16:38:01 +0100 Ferruh Yigit wrote: > diff --git a/drivers/net/memif/rte_eth_memif.c > b/drivers/net/memif/rte_eth_memif.c > index 8cec493ffdb9..cbc99067c1c8 100644 > --- a/drivers/net/memif/rte_eth_memif.c > +++ b/drivers/net/memif/rte_eth_memif.c > @@ -195,7 +195,7 @@ static

[dpdk-dev] DTS WG next steps

2021-10-26 Thread Honnappa Nagarahalli
Hello, Just wanted to update everyone on the discussions with the Techboard and figure out the next steps. However, tomorrow (10/27), I have a doctor's appointment to attend to, so we will do only 30mns. Thanks, Honnappa Honnappa Nagarahalli is inviting you to a schedule

Re: [dpdk-dev] [PATCH v5 5/5] test/thash: add performance tests for the Toeplitz hash

2021-10-26 Thread Medvedkin, Vladimir
Hi Stephen, On 25/10/2021 19:27, Stephen Hemminger wrote: On Thu, 21 Oct 2021 19:54:29 +0100 Vladimir Medvedkin wrote: +static uint8_t default_rss_key[] = { Should this be const? That way you can make sure API isn't modifying it. Thanks, I'll fix this in v6 -- Regards, Vladimir

[dpdk-dev] [PATCH v6 4/4] test/thash: add performance tests for the Toeplitz hash

2021-10-26 Thread Vladimir Medvedkin
This patch adds performance tests for the following Toeplitz hash function implementations: Scalar: - rte_softrss() - rte_softrss_be() Vector using gfni: - rte_thash_gfni() - rte_thash_gfni_bulk() Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app/t

[dpdk-dev] [PATCH v6 3/4] hash: enable gfni thash implementation

2021-10-26 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/hash/rte_thash.c | 42 ++ lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files chan

[dpdk-dev] [PATCH v6 2/4] hash: add bulk toeplitz hash implementation

2021-10-26 Thread Vladimir Medvedkin
This patch adds a bulk version for the Toeplitz hash implemented with Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test/test_thash.c | 67 - doc/guides/prog_guide/toeplitz_hash_lib

[dpdk-dev] [PATCH v6 1/4] hash: add new toeplitz hash implementation

2021-10-26 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- app/test/test_thash.c | 172 ++ doc/api/doxy-api-index.md | 1 + do

[dpdk-dev] [PATCH v6 0/4] optimized Toeplitz hash implementation

2021-10-26 Thread Vladimir Medvedkin
This patch series adds a new optimized implementation for the Toeplitz hash function using Galois Fields New instruction (GFNI). The main use case of this function is to calculate the hash value for a single data, so there is no bulk implementation. For performance reasons, the implementation was p

Re: [dpdk-dev] [PATCH] fib: add rib extension size parameter

2021-10-26 Thread Medvedkin, Vladimir
Hi Thomas, On 25/10/2021 19:23, Thomas Monjalon wrote: 06/09/2021 17:55, Vladimir Medvedkin: This patch adds a new parameter to the fib configuration to specify the size of the extension for internal RIB structure. It looks to be an announced API change. What happens if the new field is not i

Re: [dpdk-dev] [PATCH v5 3/5] doc/hash: update documentation for the thash library

2021-10-26 Thread Medvedkin, Vladimir
On 25/10/2021 19:04, Thomas Monjalon wrote: Vladimir, your patches are late and not perfect. You need reviews. Please ask other maintainers to help with reviews. 21/10/2021 20:54, Vladimir Medvedkin: This patch adds documentation for the new optimized Toeplitz hash implementation using GFNI

Re: [dpdk-dev] [PATCH v5 5/5] test/thash: add performance tests for the Toeplitz hash

2021-10-26 Thread Medvedkin, Vladimir
Hi Thomas, Thanks for the review, I'll address your comments in v6. Please find my comment below On 25/10/2021 19:02, Thomas Monjalon wrote: 21/10/2021 20:54, Vladimir Medvedkin: This patch adds performance tests for different implementations of the Toeplitz hash function. Please name them.

Re: [dpdk-dev] [PATCH] pdump: fix uninit not freeing statistics memzone

2021-10-26 Thread Stephen Hemminger
On Tue, 26 Oct 2021 12:53:01 +0100 Konstantin Ananyev wrote: > diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c > index 71602685d5..a708935861 100644 > --- a/lib/pdump/rte_pdump.c > +++ b/lib/pdump/rte_pdump.c > @@ -74,6 +74,7 @@ static const char MZ_RTE_PDUMP_STATS[] = "rte_pdump_stats

[dpdk-dev] [PATCH] buildtools: fix build with meson 0.60

2021-10-26 Thread Dmitry Kozlyuk
Meson 0.60 switched the format of uninstalled static libraries to thin archives, that is, they contain only paths to object files, not the files themselves. Files cannot be extracted in this case, resulting in build errors: ar: `x' cannot be used on thin archives. Handle thin archives when in

[dpdk-dev] [PATCH] app/testpmd: fix flex item flush

2021-10-26 Thread Gregory Etelson
Testpmd provides 2 sets of flex item create and destroy functions One for hosts with JSON library. These functions parse flex item configuration stored in JSON file and create or destroy flex item object. The second functions set is for hosts without JSON library for compilation compatibility. On

[dpdk-dev] [PATCH] net/mlx5: fix Tx meta width for modify field flow rule

2021-10-26 Thread Alexander Kozyrev
Register C is used for the metadata within NIC Rx domain. And its width can vary from 0 to 32 bits depending on its kernel usage. But it is not the case within NIC Tx domain, register A is always 32 bits there. Fix metadata width detection for the modify_field flow API within NIC Tx domain. Fixes:

[dpdk-dev] [PATCH] net/mlx5: allow meta modifications in legacy mode

2021-10-26 Thread Alexander Kozyrev
The MODIFY_FIELD RTE action rejects copy to/from metadata in case of the legacy mode extensive flow metadata support. It is not consistent with SET_META action that has no such restriction imposed. Registers A or B are used for META in legacy mode. Allow meta modifications in legacy mode as well.

Re: [dpdk-dev] [v5] cryptodev: add telemetry endpoint for cryptodev capabilities

2021-10-26 Thread Akhil Goyal
> > Please send a text to update in the documentation. > > Will update it while merging the patch. > > diff --git a/doc/guides/prog_guide/cryptodev_lib.rst > b/doc/guides/prog_guide/cryptodev_lib.rst > index 25663e552e..223e933bf4 100644 > --- a/doc/guides/prog_guide/cryptodev_lib.rst > +++ b/doc/

Re: [dpdk-dev] [PATCH] test: fix forwarding packets through not-ready port

2021-10-26 Thread David Marchand
On Tue, Oct 26, 2021 at 5:39 PM David Marchand wrote: > > On Tue, Oct 26, 2021 at 1:20 PM Konstantin Ananyev > wrote: > > > > (bitratestats_autotest|latencystats_autotest|pdump_autotest) tests > > generate a log of error messages like that: > > > > test_packet_forward() line 104: Error sending pa

Re: [dpdk-dev] [PATCH v9 06/10] ipsec: add transmit segmentation offload support

2021-10-26 Thread Ananyev, Konstantin
> > Hi, I reworked this patch as part of a new patchset, and some comments > below. > > On the comment about the offload capabilities, i.e. what happens if a > PMD supports SECURITY and TSO but not both in the same time, well, if > this is the case they should not be set both, Ok, let' take a

Re: [dpdk-dev] [PATCH v2 2/2] examples/ipsec-secgw: add support for TSO

2021-10-26 Thread Ananyev, Konstantin
> > Add support to allow user to specific MSS for TSO offload on a per SA > basis. MSS configuration in the context of IPsec is only supported for > outbound SA's in the context of an inline IPsec Crypto offload. If this feature is enabled (by mss config file option), shouldn't we check and

Re: [dpdk-dev] [PATCH v2 1/2] ipsec: add TSO support

2021-10-26 Thread Ananyev, Konstantin
> Add support for transmit segmentation offload to inline crypto processing > mode. This offload is not supported by other offload modes, as at a > minimum it requires inline crypto for IPsec to be supported on the > network interface. > > Signed-off-by: Declan Doherty > Signed-off-by: Radu Nic

[dpdk-dev] [dpdk-dev v1 4/7] crypto/qat: qat driver session method rework

2021-10-26 Thread Kai Ji
The patch introduce set_session & set_raw_dp_ctx methods to qat gen dev ops Replace min_qat_dev_gen_id with dev_id, the session will be invalid if the device generation id is not matching during init and ops Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gen2.c | 90 drive

[dpdk-dev] [dpdk-dev v1 6/7] app/test: cryptodev test fix

2021-10-26 Thread Kai Ji
test_mixed_auth_cipher: ensure enough space allocate in ibuf & obuf for mbuf to vec conversion test_kasumi_decryption: cipher length update. qat/dev: support sgl oop operation Fixes: 681f540da52b ("cryptodev: do not use AAD in wireless algorithms") Cc: pablo.de.lara.gua...@intel.com Fixes: e847fc

[dpdk-dev] [dpdk-dev v1 5/7] crypto/qat: qat driver datapath rework

2021-10-26 Thread Kai Ji
This patch introduce op_build_request func in qat enqueue op burst. Add-in qat_dequeue_process_response in qat dequeue op burst. Enable session build request op based on crypto operation Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 4 +- drivers/common/qat/qat_qp.c

[dpdk-dev] [dpdk-dev v1 3/7] crypto/qat: qat driver asym op refactor

2021-10-26 Thread Kai Ji
This patch add-in refactored qat asymmetric build request function implementation (qat_asym_refactor.c & qat_asym_refactor.h) Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_asym_pmd_gen1.c | 7 + drivers/crypto/qat/qat_asym_refactor.c | 994 + drivers/crypto/qat/q

[dpdk-dev] [dpdk-dev v1 2/7] crypto/qat: qat driver sym op refactor

2021-10-26 Thread Kai Ji
This patch add-in refactored qat symmetirc build request function implementation (qat_sym_refactor.c & qat_sym_refactor.h) Add-in QAT sym build ops in auth, cipher, chain and aead operation for QAT generation 1 Signed-off-by: Kai Ji --- drivers/crypto/qat/dev/qat_crypto_pmd_gens.h | 1071 +++

[dpdk-dev] [dpdk-dev v1 1/7] crypro/qat: qat driver refactor skeleton

2021-10-26 Thread Kai Ji
Add-in enqueue/dequeue op burst and build-request skeleton functions for qat crypto driver refactor. Signed-off-by: Kai Ji --- drivers/common/qat/qat_qp.c | 16 + drivers/common/qat/qat_qp.h | 22 + drivers/crypto/qat/qat_asym.c| 35 +

[dpdk-dev] [dpdk-dev v1 0/7] drivers/qat: QAT symmetric crypto datapatch rework

2021-10-26 Thread Kai Ji
This patch reworks QAT symmetric crypto datapatch implmentation where each generation request building separated and the crypto operation under the raw datapath api implmentations are unified. In addtion this patchset also enables QAT OOP support in raw datapath api implmentation. This patch depe

Re: [dpdk-dev] [PATCH] common/mlx5: optimize debug log

2021-10-26 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Sean Zhang > Sent: Monday, October 11, 2021 11:46 AM > To: dev@dpdk.org > Cc: sta...@dpdk.org; Matan Azrad > Subject: [dpdk-dev] [PATCH] common/mlx5: optimize debug log > > Remove debug log inside of mlx5_list_init to avoid flooding debu

Re: [dpdk-dev] [dpdk-dev v4 5/9] compress/qat: add gen specific data and function

2021-10-26 Thread Power, Ciara
>-Original Message- >From: dev On Behalf Of Fan Zhang >Sent: Friday 22 October 2021 18:04 >To: dev@dpdk.org >Cc: gak...@marvell.com; Zhang, Roy Fan ; Adam >Dybkowski ; Kusztal, ArkadiuszX >; Ji, Kai >Subject: [dpdk-dev] [dpdk-dev v4 5/9] compress/qat: add gen specific data >and function >

[dpdk-dev] [dpdk-dev v6 9/9] crypto/qat: add gen specific implementation

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT symmetric and asymmetric support implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/meson.bu

[dpdk-dev] [dpdk-dev v6 8/9] crypto/qat: add gen specific data and function

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch adds the symmetric and asymmetric crypto data structure and function prototypes for different QAT generations. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/crypto/qat/README |7 - drivers/crypto/qat/mes

[dpdk-dev] [dpdk-dev v6 7/9] crypto/qat: unified device private data structure

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch unifies the QAT symmetric and asymmetric device private data structures and functions. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 2 +- drivers/common/qat/qat_common.c | 15 ++ drive

[dpdk-dev] [dpdk-dev v6 6/9] compress/qat: add gen specific implementation

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT compression support implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Adam Dybkowski Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Acked-by: Ciara Power --- drivers/c

[dpdk-dev] [dpdk-dev v6 5/9] compress/qat: add gen specific data and function

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch adds the compression data structure and function prototypes for different QAT generations. Signed-off-by: Adam Dybkowski Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power --- .../common/qat/qat_adf/icp_qat_hw_gen4_co

[dpdk-dev] [dpdk-dev v6 4/9] common/qat: add gen specific queue implementation

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT queue pair configuration implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power --- drivers/comm

[dpdk-dev] [dpdk-dev v6 3/9] common/qat: add gen specific queue pair function

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch adds the queue pair data structure and function prototypes for different QAT generations. Signed-off-by: Fan Zhang --- drivers/common/qat/qat_qp.c | 3 ++ drivers/common/qat/qat_qp.h | 103 2 files changed, 71 insertions(+), 35

[dpdk-dev] [dpdk-dev v6 2/9] common/qat: add gen specific device implementation

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT device configuration implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/dev/qat_dev_gen1.c |

[dpdk-dev] [dpdk-dev v6 1/9] common/qat: add gen specific data and function

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch adds the data structure and function prototypes for different QAT generations. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power --- drivers/common/qat/qat_common.h | 14 -- drivers/common/qat/qat_device.c

[dpdk-dev] [dpdk-dev v6 0/9] drivers/qat: isolate implementations of qat generations

2021-10-26 Thread Kai Ji
This patchset introduces new qat driver structure and updates existing symmetric crypto qat PMD. The purpose of the change is to isolate QAT generation specific implementations from one to another. It is expected the changes to the specific generation driver code does minimum impact to other gene

Re: [dpdk-dev] [PATCH] ethdev: warn only once for badly behaving applications

2021-10-26 Thread Ananyev, Konstantin
> > Warning continuously is a pain when developping or if a unit test > is/gets broken. > > It could also be a problem if application behaves badly only in some > corner cases and a DoS results of those logs being continuously displayed. > > Let's warn once per port and per rx/tx. > > Getting

Re: [dpdk-dev] [PATCH] pdump: fix uninit not freeing statistics memzone

2021-10-26 Thread Pattan, Reshma
> -Original Message- > From: Ananyev, Konstantin . > > Fixes: 10f726efe26c ("pdump: support pcapng and filtering") The changes looks ok. In the commit message we should also add CC: with author name and email id below the fixes line. > > Signed-off-by: Konstantin Ananyev Acked-by:

[dpdk-dev] [dpdk-dev v5 8/9] crypto/qat: add gen specific data and function

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch adds the symmetric and asymmetric crypto data structure and function prototypes for different QAT generations. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/crypto/qat/README |7 - drivers/crypto/qat/mes

[dpdk-dev] [dpdk-dev v5 9/9] crypto/qat: add gen specific implementation

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT symmetric and asymmetric support implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/meson.bu

[dpdk-dev] [dpdk-dev v5 7/9] crypto/qat: unified device private data structure

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch unifies the QAT symmetric and asymmetric device private data structures and functions. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/meson.build | 2 +- drivers/common/qat/qat_common.c | 15 ++ drive

[dpdk-dev] [dpdk-dev v5 5/9] compress/qat: add gen specific data and function

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch adds the compression data structure and function prototypes for different QAT generations. Signed-off-by: Adam Dybkowski Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power @@ -332,7 +332,8 @@ qat_comp_build_request(voi

[dpdk-dev] [dpdk-dev v5 6/9] compress/qat: add gen specific implementation

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT compression support implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Adam Dybkowski Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciar

[dpdk-dev] [dpdk-dev v5 4/9] common/qat: add gen specific queue implementation

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT queue pair configuration implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power service_type == se

[dpdk-dev] [dpdk-dev v5 3/9] common/qat: add gen specific queue pair function

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch adds the queue pair data structure and function prototypes for different QAT generations. Signed-off-by: Fan Zhang --- drivers/common/qat/qat_qp.c | 3 ++ drivers/common/qat/qat_qp.h | 103 2 files changed, 71 insertions(+), 35

[dpdk-dev] [dpdk-dev v5 2/9] common/qat: add gen specific device implementation

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch replaces the mixed QAT device configuration implementation by separate files with shared or individual implementation for specific QAT generation. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji --- drivers/common/qat/dev/qat_dev_gen1.c |

[dpdk-dev] [dpdk-dev v5 1/9] common/qat: add gen specific data and function

2021-10-26 Thread Kai Ji
From: Fan Zhang This patch adds the data structure and function prototypes for different QAT generations. Signed-off-by: Arek Kusztal Signed-off-by: Fan Zhang Signed-off-by: Kai Ji Acked-by: Ciara Power

[dpdk-dev] [dpdk-dev v5 0/9] drivers/qat: isolate implementations of qat generations

2021-10-26 Thread Kai Ji
This patchset introduces new qat driver structure and updates existing symmetric crypto qat PMD. The purpose of the change is to isolate QAT generation specific implementations from one to another. It is expected the changes to the specific generation driver code does minimum impact to other gene

Re: [dpdk-dev] [PATCH v2] net/mlx5: optimize the device spawn time with representors

2021-10-26 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Jiawei(Jonny) Wang > Sent: Thursday, September 30, 2021 3:01 PM > To: Slava Ovsiienko ; Matan Azrad > ; Ori Kam ; NBU-Contact-Thomas > Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v2] net/mlx5: optimize the device spawn time with > repr

[dpdk-dev] [PATCH v2 15/15] vhost: increase number of async IO vectors

2021-10-26 Thread Maxime Coquelin
This patch increases the number of IO vectors for the asynchronous data path from 512 to 2048. It has been reported during testing the startvation of IO vectors during iperf benchmark with 64KB packet size. As there are no direct relationship between VHOST_MAX_ASYNC_VEC and BUF_VECTOR_MAX, this pa

[dpdk-dev] [PATCH v2 14/15] vhost: merge sync and async mbuf to desc filling

2021-10-26 Thread Maxime Coquelin
This patches merges copy_mbuf_to_desc() used by the sync path with async_mbuf_to_desc() used by the async path. Most of these complex functions are identical, so merging them will make the maintenance easier. In order not to degrade performance, the patch introduces a boolean function parameter t

[dpdk-dev] [PATCH v2 13/15] vhost: prepare sync for mbuf to desc refactoring

2021-10-26 Thread Maxime Coquelin
This patch extracts the descriptors buffers filling from copy_mbuf_to_desc() into a dedicated function as a preliminary step of merging copy_mubf_to_desc() and async_mbuf_to_desc(). Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 73 +- 1 file

[dpdk-dev] [PATCH v2 11/15] vhost: simplify getting the first in-flight index

2021-10-26 Thread Maxime Coquelin
This patch reworks the function getting the index for the first packet in-flight. When this index turns out to be zero, let's use the simple path. Doing that avoid having to do a modulo with the virtqueue size. The patch also rename the function for better clarifty, and only pass the virtqueue me

[dpdk-dev] [PATCH v2 12/15] vhost: prepare async for mbuf to desc refactoring

2021-10-26 Thread Maxime Coquelin
This patch extracts the IO vectors filling from async_mbuf_to_desc() into a dedicated function as a preliminary step of merging copy_mubf_to_desc() and async_mbuf_to_desc(). Signed-off-by: Maxime Coquelin --- lib/vhost/virtio_net.c | 206 ++--- 1 file changed,

  1   2   3   >