[dpdk-dev] [PATCH] eal: promote non-EAL lcore API as stable

2021-10-21 Thread David Marchand
This API has been around for more than a year (and is in LTS 20.11). It did not receive negative feedback and will be used in a next OVS release. Mark it stable. Signed-off-by: David Marchand --- lib/eal/include/rte_eal.h | 1 - lib/eal/include/rte_lcore.h | 6 -- lib/eal/version.map

Re: [dpdk-dev] [PATCH v6] ethdev: add namespace

2021-10-21 Thread Andrew Rybchenko
On 10/22/21 5:02 AM, Ferruh Yigit wrote: > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > way. The macros for backward compatibility can be removed in next LTS. > Also updated some struct names to hav

[dpdk-dev] [Bug 832] flow_classify_softnic/inconsistent_rules: create rule failed

2021-10-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=832 Bug ID: 832 Summary: flow_classify_softnic/inconsistent_rules: create rule failed Product: DPDK Version: 21.11 Hardware: All OS: All Status: UNCONFIRMED

Re: [dpdk-dev] [v2] mempool: add telemetry endpoint for mempool info

2021-10-21 Thread David Marchand
On Fri, Oct 22, 2021 at 5:28 AM Gowrishankar Muthukrishnan wrote: > > Add telemetry endpoint for mempool info. > > Signed-off-by: Gowrishankar Muthukrishnan > Reviewed-by: Bruce Richardson Windows compilation is broken. FAILED: lib/librte_mempool.a.p/mempool_rte_mempool.c.obj "clang" "-Ilib\li

Re: [dpdk-dev] [PATCH v4 3/6] net: advertise no support for keeping flow rules

2021-10-21 Thread Somnath Kotur
On Thu, 21 Oct 2021, 23:56 Ajit Khaparde, wrote: > On Wed, Oct 20, 2021 at 11:36 PM Dmitry Kozlyuk > wrote: > > > > When RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit is zero, > > the specified behavior is the same as it had been before > > this bit was introduced. Explicitly reset it in all PM

[dpdk-dev] [Bug 797] [dpdk-21.11]Segmentation fault when start txonly packet forward after set txpkts=40, 64 and txsplit=rand

2021-10-21 Thread bugzilla
https://bugs.dpdk.org/show_bug.cgi?id=797 jiang,yu (yux.ji...@intel.com) changed: What|Removed |Added Status|CONFIRMED |RESOLVED Resolution|---

Re: [dpdk-dev] [PATCH] app/test: fix event timer adapter create unit test

2021-10-21 Thread Shijith Thotton
>> >> Removed freeing of unallocated mempool in event timer adapter create unit >> test. >> >> Fixes: d1f3385d0076 ("test: add event timer adapter auto-test") >> >> Signed-off-by: Shijith Thotton >Acked-by: Erik Gabriel Carrillo Thomas, Please merge this patch.

[dpdk-dev] [v2] mempool: add telemetry endpoint for mempool info

2021-10-21 Thread Gowrishankar Muthukrishnan
Add telemetry endpoint for mempool info. Signed-off-by: Gowrishankar Muthukrishnan Reviewed-by: Bruce Richardson --- v2: - code alignments fixed --- lib/mempool/rte_mempool.c | 84 +++ 1 file changed, 84 insertions(+) diff --git a/lib/mempool/rte_mempool.c

Re: [dpdk-dev] [PATCH V2 1/1] app/testpmd: fix packet burst spreading stats

2021-10-21 Thread Ferruh Yigit
On 10/21/2021 2:20 PM, Eli Britstein wrote: RX/TX functions (rte_eth_rx_burst/rte_eth_tx_burst) get 'nb_pkts' argument, which specifies the maximum number to receive/transmit. It can be 0..nb_pkts, meaning nb_pkts+1 options. Testpmd can provide statistics of the burst sizes ('set record-burst-sta

Re: [dpdk-dev] [PATCH v3] net/hns3: add runtime config to set MBX limit time

2021-10-21 Thread Ferruh Yigit
On 10/22/2021 2:38 AM, Min Hu (Connor) wrote: From: Chengchang Tang Current, the max waiting time for MBX response is 500ms, but in some scenarios, it is not enough. Since it depends on the response of the kernel mode driver, and its response time is related to the scheduling of the system. In

Re: [dpdk-dev] [PATCH v2] ethdev: fix one MAC address occupies two index in mac addrs

2021-10-21 Thread lihuisong (C)
在 2021/10/21 16:30, Ferruh Yigit 写道: On 10/21/2021 3:05 AM, lihuisong (C) wrote: 在 2021/10/21 0:32, Ferruh Yigit 写道: On 10/20/2021 11:15 AM, Kevin Traynor wrote: On 20/10/2021 08:41, Ferruh Yigit wrote: On 10/20/2021 7:49 AM, lihuisong (C) wrote: Hi Ferruh 在 2021/10/20 1:45, Ferruh Yigit

Re: [dpdk-dev] [PATCH v7 1/2] net: fix IPv4 change announce

2021-10-21 Thread Ajit Khaparde
On Thu, Oct 14, 2021 at 1:00 PM Slava Ovsiienko wrote: > > > -Original Message- > > From: Gregory Etelson > > Sent: Thursday, October 14, 2021 20:41 > > To: dev@dpdk.org; Gregory Etelson > > Cc: Matan Azrad ; Raslan Darawsheh > > ; olivier.m...@6wind.com; NBU-Contact-Thomas > > Monjalon

Re: [dpdk-dev] [PATCH v2] net/hns3: add runtime config to set MBX limit time

2021-10-21 Thread Min Hu (Connor)
Hi, Ferruh, V3 has been sent,please check it out, thanks. 在 2021/10/21 21:06, Ferruh Yigit 写道: On 10/21/2021 3:22 AM, Min Hu (Connor) wrote: From: Chengchang Tang Current, the max waiting time for MBX response is 500ms, but in some scenarios, it is not enough. Since it depends on the r

[dpdk-dev] [PATCH v3] net/hns3: add runtime config to set MBX limit time

2021-10-21 Thread Min Hu (Connor)
From: Chengchang Tang Current, the max waiting time for MBX response is 500ms, but in some scenarios, it is not enough. Since it depends on the response of the kernel mode driver, and its response time is related to the scheduling of the system. In this special scenario, most of the cores are iso

Re: [dpdk-dev] [PATCH v3] net/vhost: merge vhost stats loop in vhost Tx/Rx

2021-10-21 Thread Gaoxiang Liu
Hi Ferruh, liugaoxi...@huawei.com is also my email address. You can update the commit to use it. Thanks, Gaoxiang 发自 网易邮箱大师 回复的原邮件 | 发件人 | Ferruh Yigit | | 日期 | 2021年10月22日 02:56 | | 收件人 | Gaoxiang Liu、maxime.coque...@redhat.com、chenbo@intel.com | | 抄送至 | dev@dpdk.org、liug

Re: [dpdk-dev] [PATCH v2] devtools: clarify that lines up to 100 characters are ok

2021-10-21 Thread Jerin Jacob
On Wed, Oct 20, 2021 at 7:58 PM Andrew Rybchenko wrote: > > On 10/20/21 5:26 PM, Bruce Richardson wrote: > > Since we allow line lengths of up to 100, and the CI checkpatches job > > only check for that amount, the rest of our tooling and docs should > > reflect this reality. Therefore we can: > >

Re: [dpdk-dev] [PATCH v4 1/5] eal: add new definitions for wait scheme

2021-10-21 Thread Jerin Jacob
On Wed, Oct 20, 2021 at 2:16 PM Feifei Wang wrote: > > Introduce macros as generic interface for address monitoring. > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > lib/eal/arm/include/rte_pause_64.h | 126 > lib/eal/include/generic/rte_pause.h |

Re: [dpdk-dev] [PATCH v13 5/7] app/testpmd: dump port info for shared Rx queue

2021-10-21 Thread Ajit Khaparde
On Thu, Oct 21, 2021 at 3:42 AM Xueming Li wrote: > > In case of shared Rx queue, source port mbuf from polling result isn't > the Rx port of forwarding stream. To provide original port ID, this > patch dumps mbuf->port for each packet in verbose mode if shared Rx > queue enabled. > > Signed-off-b

Re: [dpdk-dev] [PATCH v13 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-21 Thread Ajit Khaparde
On Thu, Oct 21, 2021 at 3:42 AM Xueming Li wrote: > > Adds "--rxq-share=X" parameter to enable shared RxQ. > > Rx queue is shared if device supports, otherwise fallback to standard > RxQ. > > Shared Rx queues are grouped per X ports. X defaults to UINT32_MAX, > implies all ports join share group 1

Re: [dpdk-dev] [PATCH v13 0/7] ethdev: introduce shared Rx queue

2021-10-21 Thread Ferruh Yigit
On 10/21/2021 11:41 AM, Xueming Li wrote: In current DPDK framework, all Rx queues is pre-loaded with mbufs for incoming packets. When number of representors scale out in a switch domain, the memory consumption became significant. Further more, polling all ports leads to high cache miss, high lat

Re: [dpdk-dev] [PATCH v2 1/2] lib/eal: add amd epyc2 memcpy routine to eal

2021-10-21 Thread Song, Keesang
[AMD Official Use Only] Hi Thomas, I've already asked our AMD tools team, but they're saying they are not really familiar with C code implementation. We need your approval for now since we really need to get this patch submitted to 21.11 LTS. Thanks, Keesang -Original Message- From: T

Re: [dpdk-dev] [PATCH v2 1/2] lib/eal: add amd epyc2 memcpy routine to eal

2021-10-21 Thread Song, Keesang
[AMD Official Use Only] Hi Ananyev, The current memcpy implementation in Glibc is based out of assembly coding. Although memcpy could have been implemented with intrinsic, but since our AMD library developers are working on the Glibc functions, they have provided a tailored implementation based

Re: [dpdk-dev] [PATCH v2 1/2] lib/eal: add amd epyc2 memcpy routine to eal

2021-10-21 Thread Song, Keesang
[AMD Official Use Only] Hi Thomas, I hope this can make some explanation to your question. We(AMD Linux library support team) have implemented the custom tailored memcpy solution which is a close match with DPDK use case requirements like the below. 1) Min 64B length data packet with cache

Re: [dpdk-dev] [PATCH v4 3/6] net: advertise no support for keeping flow rules

2021-10-21 Thread Ajit Khaparde
On Wed, Oct 20, 2021 at 11:36 PM Dmitry Kozlyuk wrote: > > When RTE_ETH_DEV_CAPA_FLOW_RULE_KEEP capability bit is zero, > the specified behavior is the same as it had been before > this bit was introduced. Explicitly reset it in all PMDs > supporting rte_flow API in order to attract the attention

[dpdk-dev] [PATCH v2] net/failsafe: link_update request crashing at boot

2021-10-21 Thread vipul . ashri
From: Vipul Ashri failsafe crashed while sending early link_update request during boot time initialization. Based on debugging we found failsafe device was good but sub- devices were progressing towards initialization and SUBOPS macro where expanding macro gives [partial_dev]->dev_ops->link_updat

[dpdk-dev] [PATCH v5 2/2] test/eal: add a test for rte_ctrl_thread_create

2021-10-21 Thread Honnappa Nagarahalli
Add a testcase to test launching of control threads. Signed-off-by: Honnappa Nagarahalli --- app/test/test_lcores.c | 41 + 1 file changed, 41 insertions(+) diff --git a/app/test/test_lcores.c b/app/test/test_lcores.c index 19a7ab9fce..35c47d5372 100644 -

[dpdk-dev] [PATCH v5 1/2] eal: simplify the implementation of rte_ctrl_thread_create

2021-10-21 Thread Honnappa Nagarahalli
Remove the usage of pthread barrier and replace it with synchronization using atomic variable. This also removes the use of reference count required to synchronize freeing the memory. Signed-off-by: Honnappa Nagarahalli Reviewed-by: Olivier Matz --- lib/eal/common/eal_common_thread.c | 87 +

Re: [dpdk-dev] [PATCH V4] ethdev: fix eth device released repeatedly

2021-10-21 Thread Ferruh Yigit
On 10/21/2021 3:24 AM, Huisong Li wrote: In secondary process, rte_eth_dev_close() doesn't clear eth_dev->data. If calling rte_dev_remove() after rte_eth_dev_close(), in rte_eth_dev_pci_generic_remove() function, the released eth device still can be found by its name in shared memory. As a result

Re: [dpdk-dev] [PATCH v4 1/2] eal: simplify the implementation of rte_ctrl_thread_create

2021-10-21 Thread Honnappa Nagarahalli
> > Hi Honnappa, > > On Wed, Oct 13, 2021 at 03:18:10PM -0500, Honnappa Nagarahalli wrote: > > Remove the usage of pthread barrier and replace it with > > synchronization using atomic variable. This also removes the use of > > reference count required to synchronize freeing the memory. > > > >

Re: [dpdk-dev] [PATCH] net/sfc: allow control threads for counter queue polling

2021-10-21 Thread Ferruh Yigit
On 10/21/2021 9:23 PM, Ferruh Yigit wrote: On 10/21/2021 8:03 AM, Andrew Rybchenko wrote: From: Viacheslav Galaktionov MAE counters can be polled from a control thread if no service core is allocated for this. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by

Re: [dpdk-dev] [PATCH] net/sfc: allow control threads for counter queue polling

2021-10-21 Thread David Marchand
On Thu, Oct 21, 2021 at 9:04 AM Andrew Rybchenko wrote: > > From: Viacheslav Galaktionov > > MAE counters can be polled from a control thread if no service core is > allocated for this. > > Signed-off-by: Viacheslav Galaktionov > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton > --

Re: [dpdk-dev] [PATCH] net/sfc: allow control threads for counter queue polling

2021-10-21 Thread Ferruh Yigit
On 10/21/2021 8:03 AM, Andrew Rybchenko wrote: From: Viacheslav Galaktionov MAE counters can be polled from a control thread if no service core is allocated for this. Signed-off-by: Viacheslav Galaktionov Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Applied to dpdk-next-net/m

Re: [dpdk-dev] [PATCH v2 3/3] dmadev: fix compile error in debug mode

2021-10-21 Thread David Marchand
On Thu, Oct 21, 2021 at 3:04 PM Chengwen Feng wrote: > > This patch fix compile error when enable RTE_DMADEV_DEBUG. > > Fixes: ea8cf0f8536d ("dmadev: add burst capacity API") > > Signed-off-by: Chengwen Feng Series applied, thanks. -- David Marchand

Re: [dpdk-dev] [PATCH v2 1/2] lib/eal: add amd epyc2 memcpy routine to eal

2021-10-21 Thread Thomas Monjalon
19/10/2021 12:47, Aman Kumar: > This patch provides rte_memcpy* calls optimized for > AMD EPYC platforms. Use config/x86/x86_amd_epyc_linux_gcc > as cross-file with meson to build dpdk for AMD EPYC platforms. [...] > --- a/config/x86/meson.build > +++ b/config/x86/meson.build > @@ -72,3 +72,10 @@ e

Re: [dpdk-dev] [PATCH v2 1/2] lib/eal: add amd epyc2 memcpy routine to eal

2021-10-21 Thread Thomas Monjalon
21/10/2021 21:03, Song, Keesang: > From: Thomas Monjalon > > 21/10/2021 20:12, Song, Keesang: > > > From: Ananyev, Konstantin > > > > 21/10/2021 19:10, Song, Keesang: > > > > > 19/10/2021 17:35, Stephen Hemminger: > > > > > > From: Thomas Monjalon > > > > > > > 19/10/2021 12:47, Aman Kumar: > >

[dpdk-dev] could DPDK BBDEV ACC100 use in a non-FlexRAN Ubuntu user

2021-10-21 Thread 李家雯
Hi, I don’t know I can contact with. Please help me to transfer the mail to someone can help. Thanks. I’m not a FlexRAN user, I use Ubuntu linux to develop some 5G 3GPP schedule. And I need a LDPC HW accelerator to offload LDPC time. I find Intel ACC100, and some PCIe board for it, But the they

Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-21 Thread Thomas Monjalon
21/10/2021 17:29, Stephen Hemminger: > On Thu, 21 Oct 2021 15:14:38 +0100 > "Kinsella, Ray" wrote: > > > On 20/10/2021 22:42, Stephen Hemminger wrote: > > > This is utility library for writing pcapng format files > > > used by Wireshark family of utilities. Older tcpdump > > > also knows how to r

Re: [dpdk-dev] [PATCH v3] net/vhost: merge vhost stats loop in vhost Tx/Rx

2021-10-21 Thread Ferruh Yigit
On 10/18/2021 12:19 AM, Gaoxiang Liu wrote: To improve performance in vhost Tx/Rx, merge vhost stats loop. eth_vhost_tx has 2 loop of send num iteraion. It can be merge into one. eth_vhost_rx has the same issue as Tx. Signed-off-by: Gaoxiang Liu Hi Gaoxiang, We are trying to keep unique ident

[dpdk-dev] [PATCH v5 5/5] test/thash: add performance tests for the Toeplitz hash

2021-10-21 Thread Vladimir Medvedkin
This patch adds performance tests for different implementations of the Toeplitz hash function. Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app/test/test_thash_perf.c | 120 + 2 files changed, 122 insertions(+) create mode

[dpdk-dev] [PATCH v5 4/5] test/thash: add tests for a new Toeplitz hash function

2021-10-21 Thread Vladimir Medvedkin
This patch provides a set of tests for verifying the new implementation of Toeplitz hash function using GFNI. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 237 ++ 1 file changed, 237 insertions(+) diff --git a/app/test/test_thash.

[dpdk-dev] [PATCH v5 3/5] doc/hash: update documentation for the thash library

2021-10-21 Thread Vladimir Medvedkin
This patch adds documentation for the new optimized Toeplitz hash implementation using GFNI. Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/toeplitz_hash_lib.rst | 37 + doc/guides/rel_notes/release_21_11.rst | 4 2 files changed, 37 insertions

[dpdk-dev] [PATCH v5 1/5] hash: add new toeplitz hash implementation

2021-10-21 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- doc/api/doxy-api-index.md | 1 + lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 29 ++ lib/hash/rt

[dpdk-dev] [PATCH v5 2/5] hash: enable gfni thash implementation

2021-10-21 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/hash/rte_thash.c | 42 ++ lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files chan

[dpdk-dev] [PATCH v5 0/5] optimized Toeplitz hash implementation

2021-10-21 Thread Vladimir Medvedkin
This patch series adds a new optimized implementation for the Toeplitz hash function using Galois Fields New instruction (GFNI). The main use case of this function is to calculate the hash value for a single data, so there is no bulk implementation. For performance reasons, the implementation was p

Re: [dpdk-dev] [pull-request] dpdk-next-eventdev - v21.11 - RC1

2021-10-21 Thread Thomas Monjalon
20/10/2021 20:29, Jerin Jacob Kollanukkaran: > http://dpdk.org/git/next/dpdk-next-eventdev Pulled, thanks. Note: I took care of consistency in commit titles and noticed the new prefix /rx_adapater. I decided to go with /eth_rx which maps the file names and applied the same logic for /crypto and

Re: [dpdk-dev] [PATCH v2 1/2] lib/eal: add amd epyc2 memcpy routine to eal

2021-10-21 Thread Thomas Monjalon
Please convert it to C code, thanks. 21/10/2021 20:12, Song, Keesang: > [AMD Official Use Only] > > Hi Ananyev, > > The current memcpy implementation in Glibc is based out of assembly coding. > Although memcpy could have been implemented with intrinsic, but since our AMD > library developers a

Re: [dpdk-dev] [PATCH v4 2/6] ethdev: add capability to keep shared objects on restart

2021-10-21 Thread Ajit Khaparde
On Wed, Oct 20, 2021 at 11:35 PM Dmitry Kozlyuk wrote: > > rte_flow_action_handle_create() did not mention what happens > with an indirect action when a device is stopped and started again. > It is natural for some indirect actions, like counter, to be persistent. > Keeping others at least saves a

Re: [dpdk-dev] [PATCH v2 1/2] lib/eal: add amd epyc2 memcpy routine to eal

2021-10-21 Thread Ananyev, Konstantin
> > Hi Thomas, > > I hope this can make some explanation to your question. > We(AMD Linux library support team) have implemented the custom tailored > memcpy solution which is a close match with DPDK use case > requirements like the below. > 1) Min 64B length data packet with cache aligne

[dpdk-dev] [PATCH V2 1/1] app/testpmd: fix packet burst spreading stats

2021-10-21 Thread Eli Britstein
RX/TX functions (rte_eth_rx_burst/rte_eth_tx_burst) get 'nb_pkts' argument, which specifies the maximum number to receive/transmit. It can be 0..nb_pkts, meaning nb_pkts+1 options. Testpmd can provide statistics of the burst sizes ('set record-burst-stats on') by incrementing an array cell of index

[dpdk-dev] [PATCH v4 5/5] test/thash: add performance tests for the Toeplitz hash

2021-10-21 Thread Vladimir Medvedkin
This patch adds performance tests for different implementations of the Toeplitz hash function. Signed-off-by: Vladimir Medvedkin --- app/test/meson.build | 2 + app/test/test_thash_perf.c | 120 + 2 files changed, 122 insertions(+) create mode

[dpdk-dev] [PATCH v4 4/5] test/thash: add tests for a new Toeplitz hash function

2021-10-21 Thread Vladimir Medvedkin
This patch provides a set of tests for verifying the new implementation of Toeplitz hash function using GFNI. Signed-off-by: Vladimir Medvedkin --- app/test/test_thash.c | 237 ++ 1 file changed, 237 insertions(+) diff --git a/app/test/test_thash.

[dpdk-dev] [PATCH v4 3/5] doc/hash: update documentation for the thash library

2021-10-21 Thread Vladimir Medvedkin
This patch adds documentation for the new optimized Toeplitz hash implementation using GFNI. Signed-off-by: Vladimir Medvedkin --- doc/guides/prog_guide/toeplitz_hash_lib.rst | 37 + doc/guides/rel_notes/release_21_11.rst | 4 2 files changed, 37 insertions

[dpdk-dev] [PATCH v4 0/5] optimized Toeplitz hash implementation

2021-10-21 Thread Vladimir Medvedkin
This patch series adds a new optimized implementation for the Toeplitz hash function using Galois Fields New instruction (GFNI). The main use case of this function is to calculate the hash value for a single data, so there is no bulk implementation. For performance reasons, the implementation was p

[dpdk-dev] [PATCH v4 1/5] hash: add new toeplitz hash implementation

2021-10-21 Thread Vladimir Medvedkin
This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- doc/api/doxy-api-index.md | 1 + lib/hash/meson.build | 1 + lib/hash/rte_thash.c | 29 ++ lib/hash/rt

[dpdk-dev] [PATCH v4 2/5] hash: enable gfni thash implementation

2021-10-21 Thread Vladimir Medvedkin
This patch enables new GFNI Toeplitz hash in predictable RSS library. Signed-off-by: Vladimir Medvedkin Acked-by: Konstantin Ananyev --- lib/hash/rte_thash.c | 42 ++ lib/hash/rte_thash.h | 19 +++ lib/hash/version.map | 1 + 3 files chan

Re: [dpdk-dev] [PATCH v7 1/3] ethdev: support L2TPv2 and PPP procotol

2021-10-21 Thread Ori Kam
Hi Jie > -Original Message- > From: dev On Behalf Of Wang, Jie1X > Sent: Thursday, October 21, 2021 11:41 AM > Subject: Re: [dpdk-dev] [PATCH v7 1/3] ethdev: support L2TPv2 and PPP procotol > > > > > -Original Message- > > From: Ori Kam > > Sent: Thursday, October 21, 2021 3:5

Re: [dpdk-dev] [PATCH v3 1/5] hash: add new toeplitz hash implementation

2021-10-21 Thread Medvedkin, Vladimir
Hi Konstantin, On 21/10/2021 11:42, Ananyev, Konstantin wrote: This patch add a new Toeplitz hash implementation using Galios Fields New Instructions (GFNI). Signed-off-by: Vladimir Medvedkin --- doc/api/doxy-api-index.md | 1 + lib/hash/meson.build | 1 + lib/hash/rte_t

[dpdk-dev] [PATCH v2] lpm: fix buffer overflow

2021-10-21 Thread Vladimir Medvedkin
This patch fixes buffer overflow reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=819 The rte_lpm6 keeps routing information for control plane purpose inside the rte_hash table which uses rte_jhash() as a hash function. >From the rte_jhash() documentation: If input key is n

Re: [dpdk-dev] [PATCH] lpm: fix buffer overflow

2021-10-21 Thread Medvedkin, Vladimir
Hi David, On 20/10/2021 21:55, David Marchand wrote: Hello Vladimir, On Fri, Oct 8, 2021 at 11:29 PM Vladimir Medvedkin wrote: This patch fixes buffer overflow reported by ASAN, please reference https://bugs.dpdk.org/show_bug.cgi?id=819 The rte_lpm6 keeps routing information for control pla

Re: [dpdk-dev] [PATCH v3] examples/vhost: change the default value of NIC's max queues

2021-10-21 Thread Ferruh Yigit
On 10/15/2021 5:48 PM, Wenwu Ma wrote: vswitch can't launch with a 40G i40e port due to device start fails what is 'vswitch' that is referred? I expect what can't launch should be this sample app but why referring it as 'vswitch'? Also patch title describes what is done, better to describe why

Re: [dpdk-dev] [PATCH v2 2/2] net/cnxk: support rte flow action type port ID

2021-10-21 Thread Jerin Jacob
On Thu, Oct 21, 2021 at 10:41 AM wrote: > > From: Satheesh Paul > > This patch adds support for rte flow action type port_id to > enable directing packets from an input port PF to an output > port which is a VF of the input port PF. > > Signed-off-by: Satheesh Paul Series Acked-by: Jerin Jacob

Re: [dpdk-dev] [PATCH v7 1/5] net/virtio: implement rte_power_monitor API

2021-10-21 Thread Ferruh Yigit
On 10/18/2021 3:16 PM, Miao Li wrote: This patch implements rte_power_monitor API in virtio PMD to reduce power consumption when no packet come in. According to current semantics of power monitor, this commit adds a callback function to decide whether aborts the sleep by checking current value ag

Re: [dpdk-dev] [PATCH v7 5/5] examples/l3fwd-power: support virtio/vhost

2021-10-21 Thread Ferruh Yigit
On 10/18/2021 3:16 PM, Miao Li wrote: In l3fwd-power, there is default port configuration which requires RSS and IPV4/UDP/TCP checksum. Once device does not support these, the l3fwd-power will exit and report an error. This patch updates the port configuration based on device capabilities after g

Re: [dpdk-dev] [PATCH v7 1/5] net/virtio: implement rte_power_monitor API

2021-10-21 Thread Ferruh Yigit
On 10/18/2021 3:16 PM, Miao Li wrote: This patch implements rte_power_monitor API in virtio PMD to reduce Hi Miao, If there will be a new version can you please drop the "This patch implements" part, you can directly start explaining what patch does. power consumption when no packet come in.

Re: [dpdk-dev] [PATCH v7 4/5] power: modify return of queue_stopped

2021-10-21 Thread Ferruh Yigit
On 10/18/2021 3:16 PM, Miao Li wrote: Since some vdevs like virtio and vhost do not support rxq_info_get and queue state inquiry, the error return value -ENOTSUP need to be ignored when queue_stopped cannot get rx queue information and rx queue state. This patch changes the return value of queue_

Re: [dpdk-dev] [PATCH v2] net/ixgbe: initialize port even if mtu config fails

2021-10-21 Thread Tudor Cornea
On Thu, 21 Oct 2021 at 18:33, Ferruh Yigit wrote: > On 10/20/2021 7:13 PM, Tudor Cornea wrote: > > On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't > > seem to initialize anymore, while running testpmd. > > > > Configuring Port 0 (socket 0) > > ixgbevf_dev_rx_init(): Set max pac

Re: [dpdk-dev] [PATCH v4 1/5] eal: add new definitions for wait scheme

2021-10-21 Thread Ananyev, Konstantin
> Introduce macros as generic interface for address monitoring. > > Signed-off-by: Feifei Wang > Reviewed-by: Ruifeng Wang > --- > lib/eal/arm/include/rte_pause_64.h | 126 > lib/eal/include/generic/rte_pause.h | 32 +++ > 2 files changed, 104 insertions(+), 5

Re: [dpdk-dev] [PATCH v2 1/2] vdpa/mlx5: workaround FW first completion in start

2021-10-21 Thread Xueming(Steven) Li
On Thu, 2021-10-21 at 14:27 +0200, Maxime Coquelin wrote: > > On 10/15/21 17:05, Xueming Li wrote: > > After a vDPA application restart, qemu restores VQ with used and > > available index, new incoming packet triggers virtio driver to > > handle buffers. Under heavy traffic, no available buffer fo

Re: [dpdk-dev] [PATCH] vhost: add vDPA resource cleanup callback

2021-10-21 Thread Xueming(Steven) Li
On Thu, 2021-10-21 at 14:00 +0200, Maxime Coquelin wrote: > Hi Xueming, > > On 10/19/21 13:39, Xueming Li wrote: > > This patch adds vDPA device cleanup callback to release resources on > > vhost user connection close. > > > > Signed-off-by: Xueming Li > > --- > > lib/vhost/rte_vdpa_dev.h | 3

Re: [dpdk-dev] [PATCH v1 0/2] set txq affinity in round-robin

2021-10-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Rongwei Liu > Sent: Thursday, October 21, 2021 11:57 AM > To: Matan Azrad ; Slava Ovsiienko > ; Ori Kam ; NBU-Contact- > Thomas Monjalon > Cc: dev@dpdk.org; Raslan Darawsheh > Subject: [PATCH v1 0/2] set txq affinity in round-robin > > Create multiple T

Re: [dpdk-dev] [PATCH V2 1/3] net: avoid cast-align warning in VLAN insert function

2021-10-21 Thread Stephen Hemminger
On Thu, 21 Oct 2021 19:16:19 +0300 Eli Britstein wrote: > On 10/21/2021 6:48 PM, Stephen Hemminger wrote: > > External email: Use caution opening links or attachments > > > > > > On Thu, 21 Oct 2021 11:51:30 +0300 > > Eli Britstein wrote: > > > >> In rte_vlan_insert there is a casting of rte_p

Re: [dpdk-dev] [PATCH V2 1/3] net: avoid cast-align warning in VLAN insert function

2021-10-21 Thread Eli Britstein
On 10/21/2021 6:48 PM, Stephen Hemminger wrote: External email: Use caution opening links or attachments On Thu, 21 Oct 2021 11:51:30 +0300 Eli Britstein wrote: In rte_vlan_insert there is a casting of rte_pktmbuf_prepend returned value to (struct rte_ether_hdr *), which causes cast-align

Re: [dpdk-dev] [EXT] Re: [PATCH v3 2/7] eal/interrupts: implement get set APIs

2021-10-21 Thread Harman Kalra
Hi Dmitry, David Please find responses inline. > -Original Message- > From: David Marchand > Sent: Thursday, October 21, 2021 7:03 PM > To: Dmitry Kozlyuk ; Harman Kalra > > Cc: Stephen Hemminger ; Thomas > Monjalon ; dev@dpdk.org; Ray Kinsella > > Subject: Re: [EXT] Re: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v15 12/12] MAINTAINERS: add entry for new packet capture features

2021-10-21 Thread Stephen Hemminger
On Wed, 20 Oct 2021 14:42:36 -0700 Stephen Hemminger wrote: > Since the packet capture is just extension of existing pdump; > add myself as maintainer of that. > > Signed-off-by: Stephen Hemminger > --- FYI the CI infrastructure is reporting false positives for spelling errors on this. "de fac

Re: [dpdk-dev] [PATCH V2 1/3] net: avoid cast-align warning in VLAN insert function

2021-10-21 Thread Stephen Hemminger
On Thu, 21 Oct 2021 11:51:30 +0300 Eli Britstein wrote: > In rte_vlan_insert there is a casting of rte_pktmbuf_prepend returned > value to (struct rte_ether_hdr *), which causes cast-align warning when > using strict cast align flag with supporting gcc: > gcc (Ubuntu 9.3.0-17ubuntu1~20.04) 9.3.0

Re: [dpdk-dev] [PATCH v4 1/2] eal: simplify the implementation of rte_ctrl_thread_create

2021-10-21 Thread Olivier Matz
Hi Honnappa, On Wed, Oct 13, 2021 at 03:18:10PM -0500, Honnappa Nagarahalli wrote: > Remove the usage of pthread barrier and replace it with > synchronization using atomic variable. This also removes > the use of reference count required to synchronize freeing > the memory. > > Signed-off-by: Hon

Re: [dpdk-dev] [PATCH v2] net/ixgbe: initialize port even if mtu config fails

2021-10-21 Thread Ferruh Yigit
On 10/20/2021 7:13 PM, Tudor Cornea wrote: On a VMware ESXi 6.0 setup with an Intel 82599 NIC the ports don't seem to initialize anymore, while running testpmd. Configuring Port 0 (socket 0) ixgbevf_dev_rx_init(): Set max packet length to 1518 failed. ixgbevf_dev_start(): Unable to initialize RX

Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-21 Thread Stephen Hemminger
On Thu, 21 Oct 2021 15:14:38 +0100 "Kinsella, Ray" wrote: > On 20/10/2021 22:42, Stephen Hemminger wrote: > > This is utility library for writing pcapng format files > > used by Wireshark family of utilities. Older tcpdump > > also knows how to read (but not write) this format. > > > > See > >

Re: [dpdk-dev] [PATCH v7 00/13] add test suite for DMA drivers

2021-10-21 Thread Bruce Richardson
On Thu, Oct 21, 2021 at 08:06:13PM +0800, fengchengwen wrote: > Hi Bruce, > > I observed a large number of checkpatch errors [1] when synchronizing to our > inner CI, > almost all of them are over 80 lines, and many are not LONG LOG. > > The DPDK coding style recommends to be not more than 80 ch

Re: [dpdk-dev] [PATCH v2] test: rely on EAL detection for core list

2021-10-21 Thread David Marchand
On Tue, Oct 19, 2021 at 9:09 PM Aaron Conole wrote: > > David Marchand writes: > > > Cores count has a direct impact on the time needed to complete unit > > tests. > > > > Currently, the core list used for unit test is enforced to "all cores on > > the system" with no way for (CI) users to adapt

[dpdk-dev] [PATCH v13 7/7] app/testpmd: add forwarding engine for shared Rx queue

2021-10-21 Thread Xueming Li
To support shared Rx queue, this patch introduces dedicate forwarding engine. The engine groups received packets by mbuf->port into sub-group, updates stream statistics and simply frees packets. Signed-off-by: Xueming Li --- app/test-pmd/meson.build| 1 + app/test-pmd/share

Re: [dpdk-dev] [PATCH v5 0/3] devargs: support path in global syntax

2021-10-21 Thread Xueming(Steven) Li
On Thu, 2021-10-21 at 11:22 +0200, David Marchand wrote: > On Wed, Oct 20, 2021 at 5:47 PM Xueming Li wrote: > > > > - Support path in global syntax. > > - Fix bus name resolving > > - Add devargs test cases > > > > v1: initial version > > v2: > > - add test cases to test suite > > - add more

[dpdk-dev] [PATCH v13 6/7] app/testpmd: force shared Rx queue polled on same core

2021-10-21 Thread Xueming Li
Shared Rx queue must be polled on same core. This patch checks and stops forwarding if shared RxQ being scheduled on multiple cores. It's suggested to use same number of Rx queues and polling cores. Signed-off-by: Xueming Li Acked-by: Xiaoyun Li --- app/test-pmd/config.c | 105 +++

[dpdk-dev] [PATCH v13 5/7] app/testpmd: dump port info for shared Rx queue

2021-10-21 Thread Xueming Li
In case of shared Rx queue, source port mbuf from polling result isn't the Rx port of forwarding stream. To provide original port ID, this patch dumps mbuf->port for each packet in verbose mode if shared Rx queue enabled. Signed-off-by: Xueming Li Acked-by: Xiaoyun Li --- app/test-pmd/util.c |

[dpdk-dev] [PATCH v13 2/7] ethdev: get device capability name as string

2021-10-21 Thread Xueming Li
This patch adds API to return name of device capability. Signed-off-by: Xueming Li Reviewed-by: Andrew Rybchenko Acked-by: Ajit Khaparde Acked-by: Thomas Monjalon --- lib/ethdev/rte_ethdev.c | 25 + lib/ethdev/rte_ethdev.h | 14 ++ lib/ethdev/version.map |

[dpdk-dev] [PATCH v13 3/7] app/testpmd: dump device capability and Rx domain info

2021-10-21 Thread Xueming Li
Dump device capability and Rx domain ID if shared Rx queue is supported by device. Signed-off-by: Xueming Li Acked-by: Andrew Rybchenko Acked-by: Xiaoyun Li Acked-by: Ajit Khaparde --- app/test-pmd/config.c | 29 + 1 file changed, 29 insertions(+) diff --git a/app

[dpdk-dev] [PATCH v13 0/7] ethdev: introduce shared Rx queue

2021-10-21 Thread Xueming Li
In current DPDK framework, all Rx queues is pre-loaded with mbufs for incoming packets. When number of representors scale out in a switch domain, the memory consumption became significant. Further more, polling all ports leads to high cache miss, high latency and low throughputs. This patch introd

[dpdk-dev] [PATCH v13 4/7] app/testpmd: new parameter to enable shared Rx queue

2021-10-21 Thread Xueming Li
Adds "--rxq-share=X" parameter to enable shared RxQ. Rx queue is shared if device supports, otherwise fallback to standard RxQ. Shared Rx queues are grouped per X ports. X defaults to UINT32_MAX, implies all ports join share group 1. Queue ID is mapped equally with shared Rx queue ID. Signed-off

[dpdk-dev] [PATCH v13 1/7] ethdev: introduce shared Rx queue

2021-10-21 Thread Xueming Li
In current DPDK framework, each Rx queue is pre-loaded with mbufs to save incoming packets. For some PMDs, when number of representors scale out in a switch domain, the memory consumption became significant. Polling all ports also leads to high cache miss, high latency and low throughput. This pat

Re: [dpdk-dev] [PATCH v2] net/mlx5: close tools socket with the last device

2021-10-21 Thread Raslan Darawsheh
Hi, > -Original Message- > From: dev On Behalf Of Dmitry Kozlyuk > Sent: Thursday, October 14, 2021 11:55 AM > To: dev@dpdk.org > Cc: David Marchand ; Raslan Darawsheh > ; Xueming Li ; > sta...@dpdk.org; Harman Kalra ; NBU-Contact- > Thomas Monjalon ; Matan Azrad > ; Viacheslav Ovsiienko

Re: [dpdk-dev] [PATCH v2 2/3] app/test: add check for DMA info get API

2021-10-21 Thread Walsh, Conor
> From: Laatz, Kevin > Sent: Thursday 21 October 2021 15:04 > To: Chengwen Feng ; dev@dpdk.org > Cc: david.march...@redhat.com; m...@ashroe.eu; Walsh, Conor > ; Richardson, Bruce > Subject: Re: [PATCH v2 2/3] app/test: add check for DMA info get API > > On 21/10/2021 13:59, Chengwen Feng wrote:

Re: [dpdk-dev] [PATCH v3 00/18] mlx5: sharing global MR cache between drivers

2021-10-21 Thread Thomas Monjalon
> Michael Baum (18): > net/mlx5/windows: fix miss callback register for mem event > common/mlx5: share basic probing with the internal drivers > common/mlx5: share common definitions > common/mlx5: share memory related devargs > net/mlx5/windows: rearrange probing code > common/mlx5: mo

Re: [dpdk-dev] [PATCH v2 3/3] dmadev: fix compile error in debug mode

2021-10-21 Thread Walsh, Conor
> From: Laatz, Kevin > Sent: Thursday 21 October 2021 15:04 > To: Chengwen Feng ; dev@dpdk.org > Cc: david.march...@redhat.com; m...@ashroe.eu; Walsh, Conor > ; Richardson, Bruce > Subject: Re: [PATCH v2 3/3] dmadev: fix compile error in debug mode > > On 21/10/2021 13:59, Chengwen Feng wrote: >

Re: [dpdk-dev] [PATCH v15 06/12] pdump: support pcapng and filtering

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: This enhances the DPDK pdump library to support new pcapng format and filtering via BPF. The internal client/server protocol is changed to support two versions: the original pdump basic version and a new pcapng version. The internal version numbe

Re: [dpdk-dev] [PATCH v15 05/12] bpf: add function to dump eBPF instructions

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: When debugging converted (and other) programs it is useful to see disassembled eBPF output. Signed-off-by: Stephen Hemminger Acked-by: Konstantin Ananyev --- lib/bpf/bpf_dump.c | 139 lib/bpf/meso

Re: [dpdk-dev] [PATCH v15 04/12] bpf: add function to convert classic BPF to DPDK BPF

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: The pcap library emits classic BPF (32 bit) and is useful for creating filter programs. The DPDK BPF library only implements extended BPF (eBPF). Add an function to convert from old to new. The rte_bpf_convert function uses rte_malloc to put the

Re: [dpdk-dev] [PATCH v15 02/12] librte_pcapng: add new library for writing pcapng files

2021-10-21 Thread Kinsella, Ray
On 20/10/2021 22:42, Stephen Hemminger wrote: This is utility library for writing pcapng format files used by Wireshark family of utilities. Older tcpdump also knows how to read (but not write) this format. See https://github.com/pcapng/pcapng/ Signed-off-by: Stephen Hemminger Acked-by:

Re: [dpdk-dev] [PATCH v2 2/3] app/test: add check for DMA info get API

2021-10-21 Thread Kevin Laatz
On 21/10/2021 13:59, Chengwen Feng wrote: This patch add check for rte_dma_info_get() API. Signed-off-by: Chengwen Feng --- app/test/test_dmadev.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) Acked-by: Kevin Laatz

Re: [dpdk-dev] [PATCH v2 3/3] dmadev: fix compile error in debug mode

2021-10-21 Thread Kevin Laatz
On 21/10/2021 13:59, Chengwen Feng wrote: This patch fix compile error when enable RTE_DMADEV_DEBUG. Fixes: ea8cf0f8536d ("dmadev: add burst capacity API") Signed-off-by: Chengwen Feng --- lib/dmadev/rte_dmadev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Kevin Laatz

Re: [dpdk-dev] [PATCH v2 1/3] dmadev: hide devices array

2021-10-21 Thread Kevin Laatz
On 21/10/2021 13:59, Chengwen Feng wrote: From: David Marchand No need to expose rte_dma_devices out of the dmadev library. Existing helpers should be enough, and inlines make use of rte_dma_fp_objs. Signed-off-by: David Marchand Reviewed-by: Chengwen Feng Tested-by: Conor Walsh --- app/t

  1   2   3   >